[INFO] fetching crate hdb 0.1.3... [INFO] linting hdb-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate hdb 0.1.3 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate hdb 0.1.3 [INFO] finished tweaking crates.io crate hdb 0.1.3 [INFO] tweaked toml for crates.io crate hdb 0.1.3 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hdb 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0370eb155624ec34b0e1ee06549b5379d4096e904fec6c6a62426bf96cb56346 [INFO] running `Command { std: "docker" "start" "-a" "0370eb155624ec34b0e1ee06549b5379d4096e904fec6c6a62426bf96cb56346", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0370eb155624ec34b0e1ee06549b5379d4096e904fec6c6a62426bf96cb56346", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0370eb155624ec34b0e1ee06549b5379d4096e904fec6c6a62426bf96cb56346", kill_on_drop: false }` [INFO] [stdout] 0370eb155624ec34b0e1ee06549b5379d4096e904fec6c6a62426bf96cb56346 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3210fc9d80951797a6f329b6dfac22c7501370d882ab3f08711897463036ec3 [INFO] running `Command { std: "docker" "start" "-a" "c3210fc9d80951797a6f329b6dfac22c7501370d882ab3f08711897463036ec3", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking hdb v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / /// SOFTWARE. [INFO] [stdout] 22 | | [INFO] [stdout] | |_^ [INFO] [stdout] 23 | static HOBBIT_STORAGE: &str = "/var/tmp/hdb/"; [INFO] [stdout] | --------------------- the comment documents this static item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! MIT License [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! Copyright (c) 2023 Chris Varga [INFO] [stdout] 4 ~ //! [INFO] [stdout] 5 ~ //! Permission is hereby granted, free of charge, to any person obtaining a copy [INFO] [stdout] 6 ~ //! of this software and associated documentation files (the "Software"), to deal [INFO] [stdout] 7 ~ //! in the Software without restriction, including without limitation the rights [INFO] [stdout] 8 ~ //! to use, copy, modify, merge, publish, distribute, sublicense, and/or sell [INFO] [stdout] 9 ~ //! copies of the Software, and to permit persons to whom the Software is [INFO] [stdout] 10 ~ //! furnished to do so, subject to the following conditions: [INFO] [stdout] 11 ~ //! [INFO] [stdout] 12 ~ //! The above copyright notice and this permission notice shall be included in all [INFO] [stdout] 13 ~ //! copies or substantial portions of the Software. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR [INFO] [stdout] 16 ~ //! IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, [INFO] [stdout] 17 ~ //! FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE [INFO] [stdout] 18 ~ //! AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER [INFO] [stdout] 19 ~ //! LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, [INFO] [stdout] 20 ~ //! OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE [INFO] [stdout] 21 ~ //! SOFTWARE. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / /// SOFTWARE. [INFO] [stdout] 22 | | [INFO] [stdout] | |_^ [INFO] [stdout] 23 | static HOBBIT_STORAGE: &str = "/var/tmp/hdb/"; [INFO] [stdout] | --------------------- the comment documents this static item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! MIT License [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! Copyright (c) 2023 Chris Varga [INFO] [stdout] 4 ~ //! [INFO] [stdout] 5 ~ //! Permission is hereby granted, free of charge, to any person obtaining a copy [INFO] [stdout] 6 ~ //! of this software and associated documentation files (the "Software"), to deal [INFO] [stdout] 7 ~ //! in the Software without restriction, including without limitation the rights [INFO] [stdout] 8 ~ //! to use, copy, modify, merge, publish, distribute, sublicense, and/or sell [INFO] [stdout] 9 ~ //! copies of the Software, and to permit persons to whom the Software is [INFO] [stdout] 10 ~ //! furnished to do so, subject to the following conditions: [INFO] [stdout] 11 ~ //! [INFO] [stdout] 12 ~ //! The above copyright notice and this permission notice shall be included in all [INFO] [stdout] 13 ~ //! copies or substantial portions of the Software. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR [INFO] [stdout] 16 ~ //! IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, [INFO] [stdout] 17 ~ //! FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE [INFO] [stdout] 18 ~ //! AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER [INFO] [stdout] 19 ~ //! LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, [INFO] [stdout] 20 ~ //! OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE [INFO] [stdout] 21 ~ //! SOFTWARE. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 101 | if map.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `map.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | if !std::fs::metadata(path.to_string()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(path.to_string()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/lib.rs:127:27 [INFO] [stdout] | [INFO] [stdout] 127 | if !std::fs::metadata(path.to_string()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `&path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/lib.rs:129:30 [INFO] [stdout] | [INFO] [stdout] 129 | match std::fs::write(path.to_string(), data.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `&path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 101 | if map.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `map.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | if !std::fs::metadata(path.to_string()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(path.to_string()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/lib.rs:127:27 [INFO] [stdout] | [INFO] [stdout] 127 | if !std::fs::metadata(path.to_string()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `&path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/lib.rs:129:30 [INFO] [stdout] | [INFO] [stdout] 129 | match std::fs::write(path.to_string(), data.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `&path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.64s [INFO] running `Command { std: "docker" "inspect" "c3210fc9d80951797a6f329b6dfac22c7501370d882ab3f08711897463036ec3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3210fc9d80951797a6f329b6dfac22c7501370d882ab3f08711897463036ec3", kill_on_drop: false }` [INFO] [stdout] c3210fc9d80951797a6f329b6dfac22c7501370d882ab3f08711897463036ec3