[INFO] fetching crate handy 0.1.4... [INFO] linting handy-0.1.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate handy 0.1.4 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate handy 0.1.4 [INFO] finished tweaking crates.io crate handy 0.1.4 [INFO] tweaked toml for crates.io crate handy 0.1.4 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate handy 0.1.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 549589bcf8f0037e6180fccf8680beee5128de43f5c92fabde0b489e8218668c [INFO] running `Command { std: "docker" "start" "-a" "549589bcf8f0037e6180fccf8680beee5128de43f5c92fabde0b489e8218668c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "549589bcf8f0037e6180fccf8680beee5128de43f5c92fabde0b489e8218668c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "549589bcf8f0037e6180fccf8680beee5128de43f5c92fabde0b489e8218668c", kill_on_drop: false }` [INFO] [stdout] 549589bcf8f0037e6180fccf8680beee5128de43f5c92fabde0b489e8218668c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f7d057e13d97a509152d620bf3c9b55664f8abc13ddf726929099d0c5abe030 [INFO] running `Command { std: "docker" "start" "-a" "6f7d057e13d97a509152d620bf3c9b55664f8abc13ddf726929099d0c5abe030", kill_on_drop: false }` [INFO] [stderr] Checking handy v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | let mut e = &mut self.entries[index]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:828:13 [INFO] [stdout] | [INFO] [stdout] 828 | let mut e = &mut self.entries[index]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/halloc.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | let i = h.index() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `h.index()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/typed.rs:633:29 [INFO] [stdout] | [INFO] [stdout] 633 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 634 | | Self { [INFO] [stdout] 635 | | h: self.h, [INFO] [stdout] 636 | | _marker: PhantomData, [INFO] [stdout] 637 | | } [INFO] [stdout] 638 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/typed.rs:656:1 [INFO] [stdout] | [INFO] [stdout] 656 | / impl PartialOrd for TypedHandle { [INFO] [stdout] 657 | | #[inline] [INFO] [stdout] 658 | | fn partial_cmp(&self, o: &Self) -> Option { [INFO] [stdout] 659 | | self.h.0.partial_cmp(&o.h.0) [INFO] [stdout] ... | [INFO] [stdout] 677 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 658 - fn partial_cmp(&self, o: &Self) -> Option { [INFO] [stdout] 659 - self.h.0.partial_cmp(&o.h.0) [INFO] [stdout] 660 - } [INFO] [stdout] 658 + fn partial_cmp(&self, o: &Self) -> Option { Some(self.cmp(o)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 155 | assert!(c < i32::max_value() as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 155 - assert!(c < i32::max_value() as usize); [INFO] [stdout] 155 + assert!(c < i32::MAX as usize); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/lib.rs:250:21 [INFO] [stdout] | [INFO] [stdout] 250 | self.next = core::mem::replace(&mut e.next, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `e.next.take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:316:20 [INFO] [stdout] | [INFO] [stdout] 316 | update_gen(&mut end); [INFO] [stdout] | ^^^^^^^^ help: change this to: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:671:24 [INFO] [stdout] | [INFO] [stdout] 671 | assert!(cap <= i32::max_value() as usize, "Capacity overflow"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 671 - assert!(cap <= i32::max_value() as usize, "Capacity overflow"); [INFO] [stdout] 671 + assert!(cap <= i32::MAX as usize, "Capacity overflow"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:701:14 [INFO] [stdout] | [INFO] [stdout] 701 | Some(current_cap as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `current_cap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | let mut e = &mut self.entries[index]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:828:13 [INFO] [stdout] | [INFO] [stdout] 828 | let mut e = &mut self.entries[index]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/halloc.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | let i = h.index() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `h.index()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/halloc.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | assert_eq!(a.dealloc(Handle::from_raw_parts(i, 2, 0xff)), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 168 - assert_eq!(a.dealloc(Handle::from_raw_parts(i, 2, 0xff)), true); [INFO] [stdout] 168 + assert!(a.dealloc(Handle::from_raw_parts(i, 2, 0xff))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/halloc.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 170 | assert_eq!(a.dealloc(Handle::from_raw_parts(i, 2, 0xff)), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 170 - assert_eq!(a.dealloc(Handle::from_raw_parts(i, 2, 0xff)), false); [INFO] [stdout] 170 + assert!(!a.dealloc(Handle::from_raw_parts(i, 2, 0xff))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/halloc.rs:172:13 [INFO] [stdout] | [INFO] [stdout] 172 | assert_eq!(a.dealloc(Handle::from_raw_parts(i, 3, 0xff)), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 172 - assert_eq!(a.dealloc(Handle::from_raw_parts(i, 3, 0xff)), false); [INFO] [stdout] 172 + assert!(!a.dealloc(Handle::from_raw_parts(i, 3, 0xff))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/typed.rs:633:29 [INFO] [stdout] | [INFO] [stdout] 633 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 634 | | Self { [INFO] [stdout] 635 | | h: self.h, [INFO] [stdout] 636 | | _marker: PhantomData, [INFO] [stdout] 637 | | } [INFO] [stdout] 638 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/typed.rs:656:1 [INFO] [stdout] | [INFO] [stdout] 656 | / impl PartialOrd for TypedHandle { [INFO] [stdout] 657 | | #[inline] [INFO] [stdout] 658 | | fn partial_cmp(&self, o: &Self) -> Option { [INFO] [stdout] 659 | | self.h.0.partial_cmp(&o.h.0) [INFO] [stdout] ... | [INFO] [stdout] 677 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 658 - fn partial_cmp(&self, o: &Self) -> Option { [INFO] [stdout] 659 - self.h.0.partial_cmp(&o.h.0) [INFO] [stdout] 660 - } [INFO] [stdout] 658 + fn partial_cmp(&self, o: &Self) -> Option { Some(self.cmp(o)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/typed.rs:956:17 [INFO] [stdout] | [INFO] [stdout] 956 | assert!(!(TH::from_raw(3) != TH::from_raw(3))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(TH::from_raw(3) == TH::from_raw(3))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/typed.rs:957:17 [INFO] [stdout] | [INFO] [stdout] 957 | assert!(!(TH::from_raw(3) == TH::from_raw(4))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(TH::from_raw(3) != TH::from_raw(4))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/typed.rs:962:17 [INFO] [stdout] | [INFO] [stdout] 962 | assert!(!(TH::from_raw(4) < TH::from_raw(4))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(TH::from_raw(4) >= TH::from_raw(4))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/typed.rs:963:17 [INFO] [stdout] | [INFO] [stdout] 963 | assert!(!(TH::from_raw(4) < TH::from_raw(3))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(TH::from_raw(4) >= TH::from_raw(3))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/typed.rs:965:17 [INFO] [stdout] | [INFO] [stdout] 965 | assert!(!(TH::from_raw(4) > TH::from_raw(4))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(TH::from_raw(4) <= TH::from_raw(4))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/typed.rs:966:17 [INFO] [stdout] | [INFO] [stdout] 966 | assert!(!(TH::from_raw(3) > TH::from_raw(4))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(TH::from_raw(3) <= TH::from_raw(4))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/typed.rs:974:17 [INFO] [stdout] | [INFO] [stdout] 974 | assert!(!(TH::from_raw(5) <= TH::from_raw(4))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(TH::from_raw(5) > TH::from_raw(4))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/typed.rs:975:17 [INFO] [stdout] | [INFO] [stdout] 975 | assert!(!(TH::from_raw(4) >= TH::from_raw(5))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(TH::from_raw(4) < TH::from_raw(5))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 155 | assert!(c < i32::max_value() as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 155 - assert!(c < i32::max_value() as usize); [INFO] [stdout] 155 + assert!(c < i32::MAX as usize); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/lib.rs:250:21 [INFO] [stdout] | [INFO] [stdout] 250 | self.next = core::mem::replace(&mut e.next, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `e.next.take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:316:20 [INFO] [stdout] | [INFO] [stdout] 316 | update_gen(&mut end); [INFO] [stdout] | ^^^^^^^^ help: change this to: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:671:24 [INFO] [stdout] | [INFO] [stdout] 671 | assert!(cap <= i32::max_value() as usize, "Capacity overflow"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 671 - assert!(cap <= i32::max_value() as usize, "Capacity overflow"); [INFO] [stdout] 671 + assert!(cap <= i32::MAX as usize, "Capacity overflow"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:701:14 [INFO] [stdout] | [INFO] [stdout] 701 | Some(current_cap as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `current_cap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:713:32 [INFO] [stdout] | [INFO] [stdout] 713 | self.capacity() <= i32::max_value() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 713 - self.capacity() <= i32::max_value() as usize, [INFO] [stdout] 713 + self.capacity() <= i32::MAX as usize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `Command { std: "docker" "inspect" "6f7d057e13d97a509152d620bf3c9b55664f8abc13ddf726929099d0c5abe030", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f7d057e13d97a509152d620bf3c9b55664f8abc13ddf726929099d0c5abe030", kill_on_drop: false }` [INFO] [stdout] 6f7d057e13d97a509152d620bf3c9b55664f8abc13ddf726929099d0c5abe030