[INFO] fetching crate haikunator 0.1.2... [INFO] linting haikunator-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate haikunator 0.1.2 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate haikunator 0.1.2 [INFO] finished tweaking crates.io crate haikunator 0.1.2 [INFO] tweaked toml for crates.io crate haikunator 0.1.2 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate haikunator 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding rand v0.3.23 (available: v0.10.0) [INFO] [stderr] Adding regex v0.1.80 (available: v1.12.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5af4ad26090fbfa87d3ba716375356dd084e29904c26c57cb5ce157e28cf88cb [INFO] running `Command { std: "docker" "start" "-a" "5af4ad26090fbfa87d3ba716375356dd084e29904c26c57cb5ce157e28cf88cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5af4ad26090fbfa87d3ba716375356dd084e29904c26c57cb5ce157e28cf88cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5af4ad26090fbfa87d3ba716375356dd084e29904c26c57cb5ce157e28cf88cb", kill_on_drop: false }` [INFO] [stdout] 5af4ad26090fbfa87d3ba716375356dd084e29904c26c57cb5ce157e28cf88cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 67d603f65d3c7f59ad659b86f8ec745b77bd8178c8f9bfdf844249d6cd86b84a [INFO] running `Command { std: "docker" "start" "-a" "67d603f65d3c7f59ad659b86f8ec745b77bd8178c8f9bfdf844249d6cd86b84a", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking haikunator v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:6:32 [INFO] [stdout] | [INFO] [stdout] 6 | pub const DEFAULT_ADJECTIVES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:6:42 [INFO] [stdout] | [INFO] [stdout] 6 | pub const DEFAULT_ADJECTIVES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | pub const DEFAULT_NOUNS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:22:37 [INFO] [stdout] | [INFO] [stdout] 22 | pub const DEFAULT_NOUNS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | let tokens; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `tokens` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 104 ~ [INFO] [stdout] 105 | [INFO] [stdout] 106 ~ let tokens = if self.token_hex { [INFO] [stdout] 107 ~ "0123456789abcdef" [INFO] [stdout] 108 | } else { [INFO] [stdout] 109 ~ self.token_chars [INFO] [stdout] 110 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | let adjective; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `adjective` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 115 ~ [INFO] [stdout] 116 | let noun; [INFO] [stdout] 117 | [INFO] [stdout] 118 | // avoid panic when low >= high in gen_range [INFO] [stdout] 119 ~ let adjective = if self.adjectives.len() > 0{ [INFO] [stdout] 120 ~ self.adjectives[rng.gen_range(0, self.adjectives.len())] [INFO] [stdout] 121 | } else { [INFO] [stdout] 122 ~ "" [INFO] [stdout] 123 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | let noun; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `noun` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 116 ~ [INFO] [stdout] 117 | [INFO] [stdout] ... [INFO] [stdout] 124 | [INFO] [stdout] 125 ~ let noun = if self.nouns.len() > 0 { [INFO] [stdout] 126 ~ self.nouns[rng.gen_range(0, self.nouns.len())] [INFO] [stdout] 127 | } else { [INFO] [stdout] 128 ~ "" [INFO] [stdout] 129 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | if self.adjectives.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.adjectives.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 125 | if self.nouns.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.nouns.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:144:33 [INFO] [stdout] | [INFO] [stdout] 144 | parts.retain(|s: &&str| s.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/lib.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | assert!(!(&name1 == &name2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(&name1 != &name2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> tests/lib.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 23 | assert!(!(&name1 == &name2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 23 - assert!(!(&name1 == &name2)); [INFO] [stdout] 23 + assert!(!(name1 == name2)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/lib.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | h.delimiter = "@"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Haikunator::<'_> { delimiter: "@", ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/lib.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | let mut h = Haikunator::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/lib.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | h.token_length = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Haikunator::<'_> { token_length: 0, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/lib.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | let mut h = Haikunator::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/lib.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | h.token_chars = "foo"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Haikunator::<'_> { token_chars: "foo", ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/lib.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | let mut h = Haikunator::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/lib.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | h.token_length = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Haikunator::<'_> { token_length: 0, adjectives: &[], nouns: &[], ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/lib.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | let mut h = Haikunator::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:6:32 [INFO] [stdout] | [INFO] [stdout] 6 | pub const DEFAULT_ADJECTIVES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:6:42 [INFO] [stdout] | [INFO] [stdout] 6 | pub const DEFAULT_ADJECTIVES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | pub const DEFAULT_NOUNS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:22:37 [INFO] [stdout] | [INFO] [stdout] 22 | pub const DEFAULT_NOUNS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | let tokens; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `tokens` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 104 ~ [INFO] [stdout] 105 | [INFO] [stdout] 106 ~ let tokens = if self.token_hex { [INFO] [stdout] 107 ~ "0123456789abcdef" [INFO] [stdout] 108 | } else { [INFO] [stdout] 109 ~ self.token_chars [INFO] [stdout] 110 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | let adjective; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `adjective` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 115 ~ [INFO] [stdout] 116 | let noun; [INFO] [stdout] 117 | [INFO] [stdout] 118 | // avoid panic when low >= high in gen_range [INFO] [stdout] 119 ~ let adjective = if self.adjectives.len() > 0{ [INFO] [stdout] 120 ~ self.adjectives[rng.gen_range(0, self.adjectives.len())] [INFO] [stdout] 121 | } else { [INFO] [stdout] 122 ~ "" [INFO] [stdout] 123 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | let noun; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `noun` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 116 ~ [INFO] [stdout] 117 | [INFO] [stdout] ... [INFO] [stdout] 124 | [INFO] [stdout] 125 ~ let noun = if self.nouns.len() > 0 { [INFO] [stdout] 126 ~ self.nouns[rng.gen_range(0, self.nouns.len())] [INFO] [stdout] 127 | } else { [INFO] [stdout] 128 ~ "" [INFO] [stdout] 129 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | if self.adjectives.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.adjectives.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 125 | if self.nouns.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.nouns.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:144:33 [INFO] [stdout] | [INFO] [stdout] 144 | parts.retain(|s: &&str| s.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.69s [INFO] running `Command { std: "docker" "inspect" "67d603f65d3c7f59ad659b86f8ec745b77bd8178c8f9bfdf844249d6cd86b84a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67d603f65d3c7f59ad659b86f8ec745b77bd8178c8f9bfdf844249d6cd86b84a", kill_on_drop: false }` [INFO] [stdout] 67d603f65d3c7f59ad659b86f8ec745b77bd8178c8f9bfdf844249d6cd86b84a