[INFO] fetching crate gscholar 0.1.0... [INFO] linting gscholar-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gscholar 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate gscholar 0.1.0 [INFO] finished tweaking crates.io crate gscholar 0.1.0 [INFO] tweaked toml for crates.io crate gscholar 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gscholar 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 232 packages to latest compatible versions [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] [stderr] Adding scraper v0.12.0 (available: v0.26.0) [INFO] [stderr] Adding select v0.5.0 (available: v0.6.1) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded xml5ever v0.16.2 [INFO] [stderr] Downloaded select v0.5.0 [INFO] [stderr] Downloaded markup5ever_rcdom v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c6390807b61c690ee60556b1062fc5d245cf1b4058859d80643adce08369ccf [INFO] running `Command { std: "docker" "start" "-a" "0c6390807b61c690ee60556b1062fc5d245cf1b4058859d80643adce08369ccf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c6390807b61c690ee60556b1062fc5d245cf1b4058859d80643adce08369ccf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c6390807b61c690ee60556b1062fc5d245cf1b4058859d80643adce08369ccf", kill_on_drop: false }` [INFO] [stdout] 0c6390807b61c690ee60556b1062fc5d245cf1b4058859d80643adce08369ccf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 775eb7679e4622c5dc9b96f88b26932b86f4fe4eabb6699597b63d98bbfd4eb1 [INFO] running `Command { std: "docker" "start" "-a" "775eb7679e4622c5dc9b96f88b26932b86f4fe4eabb6699597b63d98bbfd4eb1", kill_on_drop: false }` [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking phf_shared v0.11.3 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking dtoa v1.0.11 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking openssl v0.10.76 [INFO] [stderr] Checking thin-slice v0.1.1 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking getopts v0.2.24 [INFO] [stderr] Checking ego-tree v0.6.3 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking native-tls v0.2.18 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling html5ever v0.25.2 [INFO] [stderr] Compiling cssparser v0.27.2 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Compiling markup5ever v0.10.1 [INFO] [stderr] Compiling selectors v0.22.0 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking xml5ever v0.16.2 [INFO] [stderr] Checking markup5ever_rcdom v0.1.0 [INFO] [stderr] Checking scraper v0.12.0 [INFO] [stderr] Checking select v0.5.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking gscholar v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/scholar/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod scholar; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return Services::Scholar; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Services::Scholar; [INFO] [stdout] 78 + Services::Scholar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return 0usize [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return 0usize [INFO] [stdout] 85 + 0usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:164:8 [INFO] [stdout] | [INFO] [stdout] 164 | return Ok(url); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return Ok(url); [INFO] [stdout] 164 + Ok(url) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/scholar/scholar.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 93 | if self.query == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:151:16 [INFO] [stdout] | [INFO] [stdout] 151 | url.push_str("1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 153 | url.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 159 | url.push_str("1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | url.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scholar/scholar.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 188 | if !resp.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `resp.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | return Ok(val); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return Ok(val); [INFO] [stdout] 192 + Ok(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 237 - return Ok(response); [INFO] [stdout] 237 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/scholar/scholar.rs:234:17 [INFO] [stdout] | [INFO] [stdout] 228 | / let l = ScholarResult{ [INFO] [stdout] 229 | | title: ti, [INFO] [stdout] 230 | | author: au, [INFO] [stdout] 231 | | abs: ab, [INFO] [stdout] 232 | | link: li, [INFO] [stdout] 233 | | }; [INFO] [stdout] | |__________________- unnecessary `let` binding [INFO] [stdout] 234 | l [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 228 ~ [INFO] [stdout] 229 ~ ScholarResult{ [INFO] [stdout] 230 + title: ti, [INFO] [stdout] 231 + author: au, [INFO] [stdout] 232 + abs: ab, [INFO] [stdout] 233 + link: li, [INFO] [stdout] 234 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:254:27 [INFO] [stdout] | [INFO] [stdout] 254 | Ok(result) => return Ok(result), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 ~ Ok(result) => Ok(result), [INFO] [stdout] 255 | Err(e) => return Err(e), [INFO] [stdout] 256 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:255:23 [INFO] [stdout] | [INFO] [stdout] 255 | Err(e) => return Err(e), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 ~ Err(e) => Err(e), [INFO] [stdout] 256 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/scholar/scholar.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | let url: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `url` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 241 ~ [INFO] [stdout] 242 ~ let url: String = match args.get_url() { [INFO] [stdout] 243 ~ Ok(u) => u, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/scholar/scholar.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | let doc: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `doc` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 247 ~ [INFO] [stdout] 248 ~ let doc: String = match self.get_document(&url[..]).await { [INFO] [stdout] 249 ~ Ok(page) => page, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/scholar/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod scholar; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return Services::Scholar; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Services::Scholar; [INFO] [stdout] 78 + Services::Scholar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return 0usize [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return 0usize [INFO] [stdout] 85 + 0usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:164:8 [INFO] [stdout] | [INFO] [stdout] 164 | return Ok(url); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return Ok(url); [INFO] [stdout] 164 + Ok(url) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/scholar/scholar.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 93 | if self.query == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:151:16 [INFO] [stdout] | [INFO] [stdout] 151 | url.push_str("1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 153 | url.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 159 | url.push_str("1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | url.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scholar/scholar.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 188 | if !resp.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `resp.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | return Ok(val); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return Ok(val); [INFO] [stdout] 192 + Ok(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 237 - return Ok(response); [INFO] [stdout] 237 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/scholar/scholar.rs:234:17 [INFO] [stdout] | [INFO] [stdout] 228 | / let l = ScholarResult{ [INFO] [stdout] 229 | | title: ti, [INFO] [stdout] 230 | | author: au, [INFO] [stdout] 231 | | abs: ab, [INFO] [stdout] 232 | | link: li, [INFO] [stdout] 233 | | }; [INFO] [stdout] | |__________________- unnecessary `let` binding [INFO] [stdout] 234 | l [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 228 ~ [INFO] [stdout] 229 ~ ScholarResult{ [INFO] [stdout] 230 + title: ti, [INFO] [stdout] 231 + author: au, [INFO] [stdout] 232 + abs: ab, [INFO] [stdout] 233 + link: li, [INFO] [stdout] 234 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:254:27 [INFO] [stdout] | [INFO] [stdout] 254 | Ok(result) => return Ok(result), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 ~ Ok(result) => Ok(result), [INFO] [stdout] 255 | Err(e) => return Err(e), [INFO] [stdout] 256 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:255:23 [INFO] [stdout] | [INFO] [stdout] 255 | Err(e) => return Err(e), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 ~ Err(e) => Err(e), [INFO] [stdout] 256 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/scholar/scholar.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | let url: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `url` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 241 ~ [INFO] [stdout] 242 ~ let url: String = match args.get_url() { [INFO] [stdout] 243 ~ Ok(u) => u, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/scholar/scholar.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | let doc: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `doc` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 247 ~ [INFO] [stdout] 248 ~ let doc: String = match self.get_document(&url[..]).await { [INFO] [stdout] 249 ~ Ok(page) => page, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.61s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: xml5ever v0.16.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 5` [INFO] running `Command { std: "docker" "inspect" "775eb7679e4622c5dc9b96f88b26932b86f4fe4eabb6699597b63d98bbfd4eb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "775eb7679e4622c5dc9b96f88b26932b86f4fe4eabb6699597b63d98bbfd4eb1", kill_on_drop: false }` [INFO] [stdout] 775eb7679e4622c5dc9b96f88b26932b86f4fe4eabb6699597b63d98bbfd4eb1