[INFO] fetching crate grite-daemon 0.3.0... [INFO] linting grite-daemon-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate grite-daemon 0.3.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate grite-daemon 0.3.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate grite-daemon 0.3.0 [INFO] tweaked toml for crates.io crate grite-daemon 0.3.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate grite-daemon 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate grite-daemon 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bytecheck_derive v0.8.2 [INFO] [stderr] Downloaded bytecheck v0.8.2 [INFO] [stderr] Downloaded ptr_meta v0.3.1 [INFO] [stderr] Downloaded munge_macro v0.4.7 [INFO] [stderr] Downloaded ptr_meta_derive v0.3.1 [INFO] [stderr] Downloaded tree-sitter-language v0.1.6 [INFO] [stderr] Downloaded munge v0.4.7 [INFO] [stderr] Downloaded rkyv_derive v0.8.14 [INFO] [stderr] Downloaded libgrite-git v0.3.0 [INFO] [stderr] Downloaded libgrite-ipc v0.3.0 [INFO] [stderr] Downloaded rend v0.5.3 [INFO] [stderr] Downloaded libgrite-core v0.3.0 [INFO] [stderr] Downloaded nng v1.0.1 [INFO] [stderr] Downloaded rkyv v0.8.14 [INFO] [stderr] Downloaded rancor v0.1.1 [INFO] [stderr] Downloaded git2 v0.20.3 [INFO] [stderr] Downloaded tree-sitter-elixir v0.3.4 [INFO] [stderr] Downloaded tree-sitter-ruby v0.23.1 [INFO] [stderr] Downloaded nng-sys v1.4.0-rc.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c8bf784284a74e95e9983d036532f243b19b86d15a975d0c52cc49bed40afe0c [INFO] running `Command { std: "docker" "start" "-a" "c8bf784284a74e95e9983d036532f243b19b86d15a975d0c52cc49bed40afe0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c8bf784284a74e95e9983d036532f243b19b86d15a975d0c52cc49bed40afe0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8bf784284a74e95e9983d036532f243b19b86d15a975d0c52cc49bed40afe0c", kill_on_drop: false }` [INFO] [stdout] c8bf784284a74e95e9983d036532f243b19b86d15a975d0c52cc49bed40afe0c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d2a83ac4fe9c80297ba7c2bf4bc5721d59861b65b4b1ab5066321099d974f2d [INFO] running `Command { std: "docker" "start" "-a" "8d2a83ac4fe9c80297ba7c2bf4bc5721d59861b65b4b1ab5066321099d974f2d", kill_on_drop: false }` [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Compiling tree-sitter-language v0.1.6 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling zmij v1.0.17 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling libz-sys v1.1.23 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling tree-sitter-python v0.23.6 [INFO] [stderr] Compiling tree-sitter-cpp v0.23.4 [INFO] [stderr] Compiling tree-sitter-rust v0.23.3 [INFO] [stderr] Compiling tree-sitter-elixir v0.3.4 [INFO] [stderr] Compiling tree-sitter-java v0.23.5 [INFO] [stderr] Compiling tree-sitter-typescript v0.23.2 [INFO] [stderr] Compiling tree-sitter-go v0.23.4 [INFO] [stderr] Compiling tree-sitter-c v0.23.4 [INFO] [stderr] Compiling tree-sitter-ruby v0.23.1 [INFO] [stderr] Compiling tree-sitter-javascript v0.23.1 [INFO] [stderr] Compiling tree-sitter v0.24.7 [INFO] [stderr] Compiling nng-sys v1.4.0-rc.0 [INFO] [stderr] Compiling libgit2-sys v0.18.3+1.9.2 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerocopy-derive v0.8.33 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling ptr_meta_derive v0.3.1 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking ptr_meta v0.3.1 [INFO] [stderr] Compiling bytecheck_derive v0.8.2 [INFO] [stderr] Checking rancor v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling munge_macro v0.4.7 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling rkyv_derive v0.8.14 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking bytecheck v0.8.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking zerocopy v0.8.33 [INFO] [stderr] Checking rend v0.5.3 [INFO] [stderr] Checking munge v0.4.7 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking nng v1.0.1 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking libgrite-core v0.3.0 [INFO] [stderr] Checking rkyv v0.8.14 [INFO] [stderr] Checking git2 v0.20.3 [INFO] [stderr] Checking libgrite-ipc v0.3.0 [INFO] [stderr] Checking libgrite-git v0.3.0 [INFO] [stderr] Checking grite-daemon v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `lock` [INFO] [stdout] --> tests/integration_tests.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | let lock = DaemonLock::acquire( [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_lock` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_lock` [INFO] [stdout] --> tests/integration_tests.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let new_lock = DaemonLock::acquire( [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_lock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `WorkerNotFound`, `WorkerExists`, `Channel`, and `Shutdown` are never constructed [INFO] [stdout] --> src/error.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub enum DaemonError { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 18 | WorkerNotFound { repo_root: String, actor_id: String }, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | WorkerExists { repo_root: String, actor_id: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 50 | Channel(String), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | Shutdown, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DaemonError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `repo_root`, `actor_id`, and `data_dir` are never read [INFO] [stdout] --> src/supervisor.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 28 | struct WorkerHandle { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 29 | tx: mpsc::Sender, [INFO] [stdout] 30 | repo_root: PathBuf, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 31 | actor_id: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 32 | data_dir: PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_idle_timeout` is never used [INFO] [stdout] --> src/supervisor.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 66 | impl Supervisor { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 93 | fn is_idle_timeout(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `WorkerNotFound`, `WorkerExists`, `Channel`, and `Shutdown` are never constructed [INFO] [stdout] --> src/error.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub enum DaemonError { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 18 | WorkerNotFound { repo_root: String, actor_id: String }, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | WorkerExists { repo_root: String, actor_id: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 50 | Channel(String), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | Shutdown, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DaemonError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `repo_root`, `actor_id`, and `data_dir` are never read [INFO] [stdout] --> src/supervisor.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 28 | struct WorkerHandle { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 29 | tx: mpsc::Sender, [INFO] [stdout] 30 | repo_root: PathBuf, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 31 | actor_id: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 32 | data_dir: PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_idle_timeout` is never used [INFO] [stdout] --> src/supervisor.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 66 | impl Supervisor { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 93 | fn is_idle_timeout(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/supervisor.rs:343:16 [INFO] [stdout] | [INFO] [stdout] 343 | if let Err(_) = tx.send(msg).await { [INFO] [stdout] | -------^^^^^^--------------------- help: try: `if tx.send(msg).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/supervisor.rs:343:16 [INFO] [stdout] | [INFO] [stdout] 343 | if let Err(_) = tx.send(msg).await { [INFO] [stdout] | -------^^^^^^--------------------- help: try: `if tx.send(msg).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/worker.rs:590:27 [INFO] [stdout] | [INFO] [stdout] 590 | let do_pull = *pull || (!*pull && !*push); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 590 - let do_pull = *pull || (!*pull && !*push); [INFO] [stdout] 590 + let do_pull = !(!*pull && *push); [INFO] [stdout] | [INFO] [stdout] 590 - let do_pull = *pull || (!*pull && !*push); [INFO] [stdout] 590 + let do_pull = *pull || !*push; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/worker.rs:591:27 [INFO] [stdout] | [INFO] [stdout] 591 | let do_push = *push || (!*pull && !*push); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 591 - let do_push = *push || (!*pull && !*push); [INFO] [stdout] 591 + let do_push = !(!*push && *pull); [INFO] [stdout] | [INFO] [stdout] 591 - let do_push = *push || (!*pull && !*push); [INFO] [stdout] 591 + let do_push = *push || !*pull; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/worker.rs:244:16 [INFO] [stdout] | [INFO] [stdout] 244 | sled_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 244 - sled_path: &PathBuf, [INFO] [stdout] 244 + sled_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/worker.rs:245:15 [INFO] [stdout] | [INFO] [stdout] 245 | data_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 245 - data_dir: &PathBuf, [INFO] [stdout] 245 + data_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/worker.rs:246:14 [INFO] [stdout] | [INFO] [stdout] 246 | git_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 246 - git_dir: &PathBuf, [INFO] [stdout] 246 + git_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/worker.rs:590:27 [INFO] [stdout] | [INFO] [stdout] 590 | let do_pull = *pull || (!*pull && !*push); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 590 - let do_pull = *pull || (!*pull && !*push); [INFO] [stdout] 590 + let do_pull = !(!*pull && *push); [INFO] [stdout] | [INFO] [stdout] 590 - let do_pull = *pull || (!*pull && !*push); [INFO] [stdout] 590 + let do_pull = *pull || !*push; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/worker.rs:591:27 [INFO] [stdout] | [INFO] [stdout] 591 | let do_push = *push || (!*pull && !*push); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 591 - let do_push = *push || (!*pull && !*push); [INFO] [stdout] 591 + let do_push = !(!*push && *pull); [INFO] [stdout] | [INFO] [stdout] 591 - let do_push = *push || (!*pull && !*push); [INFO] [stdout] 591 + let do_push = *push || !*pull; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/worker.rs:244:16 [INFO] [stdout] | [INFO] [stdout] 244 | sled_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 244 - sled_path: &PathBuf, [INFO] [stdout] 244 + sled_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/worker.rs:245:15 [INFO] [stdout] | [INFO] [stdout] 245 | data_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 245 - data_dir: &PathBuf, [INFO] [stdout] 245 + data_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/worker.rs:246:14 [INFO] [stdout] | [INFO] [stdout] 246 | git_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 246 - git_dir: &PathBuf, [INFO] [stdout] 246 + git_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/main.rs:108:1 [INFO] [stdout] | [INFO] [stdout] 108 | fn setup_signal_handlers() -> impl std::future::Future { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] = note: `#[warn(clippy::manual_async_fn)]` on by default [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 108 ~ async fn setup_signal_handlers() { [INFO] [stdout] 109 + let ctrl_c = async { [INFO] [stdout] 110 + tokio::signal::ctrl_c() [INFO] [stdout] 111 + .await [INFO] [stdout] 112 + .expect("Failed to install Ctrl+C handler"); [INFO] [stdout] 113 + }; [INFO] [stdout] 114 + [INFO] [stdout] 115 + #[cfg(unix)] [INFO] [stdout] 116 + let terminate = async { [INFO] [stdout] 117 + tokio::signal::unix::signal(tokio::signal::unix::SignalKind::terminate()) [INFO] [stdout] 118 + .expect("Failed to install signal handler") [INFO] [stdout] 119 + .recv() [INFO] [stdout] 120 + .await; [INFO] [stdout] 121 + }; [INFO] [stdout] 122 + [INFO] [stdout] 123 + #[cfg(not(unix))] [INFO] [stdout] 124 + let terminate = std::future::pending::<()>(); [INFO] [stdout] 125 + [INFO] [stdout] 126 + tokio::select! { [INFO] [stdout] 127 + _ = ctrl_c => {} [INFO] [stdout] 128 + _ = terminate => {} [INFO] [stdout] 129 + } [INFO] [stdout] 130 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/main.rs:108:1 [INFO] [stdout] | [INFO] [stdout] 108 | fn setup_signal_handlers() -> impl std::future::Future { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] = note: `#[warn(clippy::manual_async_fn)]` on by default [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 108 ~ async fn setup_signal_handlers() { [INFO] [stdout] 109 + let ctrl_c = async { [INFO] [stdout] 110 + tokio::signal::ctrl_c() [INFO] [stdout] 111 + .await [INFO] [stdout] 112 + .expect("Failed to install Ctrl+C handler"); [INFO] [stdout] 113 + }; [INFO] [stdout] 114 + [INFO] [stdout] 115 + #[cfg(unix)] [INFO] [stdout] 116 + let terminate = async { [INFO] [stdout] 117 + tokio::signal::unix::signal(tokio::signal::unix::SignalKind::terminate()) [INFO] [stdout] 118 + .expect("Failed to install signal handler") [INFO] [stdout] 119 + .recv() [INFO] [stdout] 120 + .await; [INFO] [stdout] 121 + }; [INFO] [stdout] 122 + [INFO] [stdout] 123 + #[cfg(not(unix))] [INFO] [stdout] 124 + let terminate = std::future::pending::<()>(); [INFO] [stdout] 125 + [INFO] [stdout] 126 + tokio::select! { [INFO] [stdout] 127 + _ = ctrl_c => {} [INFO] [stdout] 128 + _ = terminate => {} [INFO] [stdout] 129 + } [INFO] [stdout] 130 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 57.72s [INFO] running `Command { std: "docker" "inspect" "8d2a83ac4fe9c80297ba7c2bf4bc5721d59861b65b4b1ab5066321099d974f2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d2a83ac4fe9c80297ba7c2bf4bc5721d59861b65b4b1ab5066321099d974f2d", kill_on_drop: false }` [INFO] [stdout] 8d2a83ac4fe9c80297ba7c2bf4bc5721d59861b65b4b1ab5066321099d974f2d