[INFO] fetching crate gostd_time 1.1.3... [INFO] linting gostd_time-1.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gostd_time 1.1.3 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate gostd_time 1.1.3 [INFO] finished tweaking crates.io crate gostd_time 1.1.3 [INFO] tweaked toml for crates.io crate gostd_time 1.1.3 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gostd_time 1.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f57bda03f538e41ff7c0bea90a2ab7fc23b05e76522be3a21539b36f8005c078 [INFO] running `Command { std: "docker" "start" "-a" "f57bda03f538e41ff7c0bea90a2ab7fc23b05e76522be3a21539b36f8005c078", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f57bda03f538e41ff7c0bea90a2ab7fc23b05e76522be3a21539b36f8005c078", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f57bda03f538e41ff7c0bea90a2ab7fc23b05e76522be3a21539b36f8005c078", kill_on_drop: false }` [INFO] [stdout] f57bda03f538e41ff7c0bea90a2ab7fc23b05e76522be3a21539b36f8005c078 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc16e0622a3704e2ca0144c7185bce148004089f496df8bb7b94a5304a9c8b96 [INFO] running `Command { std: "docker" "start" "-a" "cc16e0622a3704e2ca0144c7185bce148004089f496df8bb7b94a5304a9c8b96", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Checking gostd_builtin v1.0.4 [INFO] [stderr] Checking cvt v0.1.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling gostd_derive v0.0.3 [INFO] [stderr] Checking gostd_time v1.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/sys.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 15 | #[cfg(all(all(unix), not(target_os = "macos")))] [INFO] [stdout] | ^^^^^^^^^ help: try: `unix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/sys.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(any(target_os = "windows"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target_os = "windows"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/sys.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 15 | #[cfg(all(all(unix), not(target_os = "macos")))] [INFO] [stdout] | ^^^^^^^^^ help: try: `unix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/sys.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(any(target_os = "windows"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target_os = "windows"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:215:18 [INFO] [stdout] | [INFO] [stdout] 215 | self.0 / 1000_000 [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/lib.rs:355:42 [INFO] [stdout] | [INFO] [stdout] 355 | const maxWall: int64 = wallToInternal + (1 << 33 - 1); // year 2157 [INFO] [stdout] | ^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (33 - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:465:31 [INFO] [stdout] | [INFO] [stdout] 465 | let mut m1 = m2 / 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:466:23 [INFO] [stdout] | [INFO] [stdout] 466 | m2 = m2 % 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:468:23 [INFO] [stdout] | [INFO] [stdout] 468 | m1 = m1 % 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/lib.rs:470:35 [INFO] [stdout] | [INFO] [stdout] 470 | buf.extend_from_slice((" m=".as_bytes())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove them: `" m=".as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/lib.rs:511:29 [INFO] [stdout] | [INFO] [stdout] 511 | if 0 <= dsec && dsec <= (1 << 33) - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `dsec < (1 << 33)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:578:8 [INFO] [stdout] | [INFO] [stdout] 578 | /// let year3000 = time::Date(3000, 1, 1, 0, 0, 0, 0, time::UTC.clone()); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:580:8 [INFO] [stdout] | [INFO] [stdout] 580 | /// assert_eq!(true,year3000.After(&year2000));// True [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:581:8 [INFO] [stdout] | [INFO] [stdout] 581 | /// assert_eq!(false,year2000.After(&year3000)); // False [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:742:5 [INFO] [stdout] | [INFO] [stdout] 742 | / /// let afterTenDays = start.Add(&Duration::new(time::Hour * 24 * 10)); [INFO] [stdout] 743 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 751 | pub fn Add(&mut self, d: &Duration) -> Time { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 743 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:739:8 [INFO] [stdout] | [INFO] [stdout] 739 | /// let afterTenSeconds = start.Add(&Duration::new(time::Second * 10)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:740:8 [INFO] [stdout] | [INFO] [stdout] 740 | /// let afterTenMinutes = start.Add(&Duration::new(time::Minute * 10)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:741:8 [INFO] [stdout] | [INFO] [stdout] 741 | /// let afterTenHours = start.Add(&Duration::new(time::Hour * 10)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:742:8 [INFO] [stdout] | [INFO] [stdout] 742 | /// let afterTenDays = start.Add(&Duration::new(time::Hour * 24 * 10)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:744:8 [INFO] [stdout] | [INFO] [stdout] 744 | /// println!("start = {}", start); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:745:8 [INFO] [stdout] | [INFO] [stdout] 745 | /// println!("start.Add(time.Second * 10) = {}", afterTenSeconds); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:746:8 [INFO] [stdout] | [INFO] [stdout] 746 | /// println!("start.Add(time.Minute * 10) = {}", afterTenMinutes); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:747:8 [INFO] [stdout] | [INFO] [stdout] 747 | /// println!("start.Add(time.Hour * 10) = {}", afterTenHours); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:748:8 [INFO] [stdout] | [INFO] [stdout] 748 | /// println!("start.Add(time.Hour * 24 * 10) = {}", afterTenDays); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1237:55 [INFO] [stdout] | [INFO] [stdout] 1237 | self.unixSec() * 1000 + int64!(self.nsec()) / 1000_000 [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1245:26 [INFO] [stdout] | [INFO] [stdout] 1245 | self.unixSec() * 1000_000 + int64!(self.nsec()) / 1000 [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1254:26 [INFO] [stdout] | [INFO] [stdout] 1254 | self.unixSec() * 1000_000_000 + int64!(self.nsec()) [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1318:24 [INFO] [stdout] | [INFO] [stdout] 1318 | let n = nsec / 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1320:21 [INFO] [stdout] | [INFO] [stdout] 1320 | nsec -= n * 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1322:21 [INFO] [stdout] | [INFO] [stdout] 1322 | nsec += 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1360:39 [INFO] [stdout] | [INFO] [stdout] 1360 | Unix(msec / 1000, (msec % 1000) * 1000_000) [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1369:17 [INFO] [stdout] | [INFO] [stdout] 1369 | Unix(usec / 1000_000, (usec % 1000_000) * 1000) [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1369:35 [INFO] [stdout] | [INFO] [stdout] 1369 | Unix(usec / 1000_000, (usec % 1000_000) * 1000) [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:215:18 [INFO] [stdout] | [INFO] [stdout] 215 | self.0 / 1000_000 [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1442:39 [INFO] [stdout] | [INFO] [stdout] 1442 | let (sec, nsec) = norm(sec, nsec, 1000_000_000); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/lib.rs:355:42 [INFO] [stdout] | [INFO] [stdout] 355 | const maxWall: int64 = wallToInternal + (1 << 33 - 1); // year 2157 [INFO] [stdout] | ^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (33 - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:465:31 [INFO] [stdout] | [INFO] [stdout] 465 | let mut m1 = m2 / 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:466:23 [INFO] [stdout] | [INFO] [stdout] 466 | m2 = m2 % 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:468:23 [INFO] [stdout] | [INFO] [stdout] 468 | m1 = m1 % 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/lib.rs:470:35 [INFO] [stdout] | [INFO] [stdout] 470 | buf.extend_from_slice((" m=".as_bytes())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove them: `" m=".as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/lib.rs:511:29 [INFO] [stdout] | [INFO] [stdout] 511 | if 0 <= dsec && dsec <= (1 << 33) - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `dsec < (1 << 33)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:578:8 [INFO] [stdout] | [INFO] [stdout] 578 | /// let year3000 = time::Date(3000, 1, 1, 0, 0, 0, 0, time::UTC.clone()); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:580:8 [INFO] [stdout] | [INFO] [stdout] 580 | /// assert_eq!(true,year3000.After(&year2000));// True [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:581:8 [INFO] [stdout] | [INFO] [stdout] 581 | /// assert_eq!(false,year2000.After(&year3000)); // False [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:742:5 [INFO] [stdout] | [INFO] [stdout] 742 | / /// let afterTenDays = start.Add(&Duration::new(time::Hour * 24 * 10)); [INFO] [stdout] 743 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 751 | pub fn Add(&mut self, d: &Duration) -> Time { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 743 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:739:8 [INFO] [stdout] | [INFO] [stdout] 739 | /// let afterTenSeconds = start.Add(&Duration::new(time::Second * 10)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:740:8 [INFO] [stdout] | [INFO] [stdout] 740 | /// let afterTenMinutes = start.Add(&Duration::new(time::Minute * 10)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:741:8 [INFO] [stdout] | [INFO] [stdout] 741 | /// let afterTenHours = start.Add(&Duration::new(time::Hour * 10)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:742:8 [INFO] [stdout] | [INFO] [stdout] 742 | /// let afterTenDays = start.Add(&Duration::new(time::Hour * 24 * 10)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:744:8 [INFO] [stdout] | [INFO] [stdout] 744 | /// println!("start = {}", start); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:745:8 [INFO] [stdout] | [INFO] [stdout] 745 | /// println!("start.Add(time.Second * 10) = {}", afterTenSeconds); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:746:8 [INFO] [stdout] | [INFO] [stdout] 746 | /// println!("start.Add(time.Minute * 10) = {}", afterTenMinutes); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:747:8 [INFO] [stdout] | [INFO] [stdout] 747 | /// println!("start.Add(time.Hour * 10) = {}", afterTenHours); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:748:8 [INFO] [stdout] | [INFO] [stdout] 748 | /// println!("start.Add(time.Hour * 24 * 10) = {}", afterTenDays); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:2356:18 [INFO] [stdout] | [INFO] [stdout] 2356 | if ns < 0 || 1000_0000_000 < ns { [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/lib.rs:2378:17 [INFO] [stdout] | [INFO] [stdout] 2378 | if x > (1 << 63 - 1) / 10 { [INFO] [stdout] | ^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (63 - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/lib.rs:2407:17 [INFO] [stdout] | [INFO] [stdout] 2407 | if x > (1 << 63 - 1) / 10 { [INFO] [stdout] | ^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (63 - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1237:55 [INFO] [stdout] | [INFO] [stdout] 1237 | self.unixSec() * 1000 + int64!(self.nsec()) / 1000_000 [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1245:26 [INFO] [stdout] | [INFO] [stdout] 1245 | self.unixSec() * 1000_000 + int64!(self.nsec()) / 1000 [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1254:26 [INFO] [stdout] | [INFO] [stdout] 1254 | self.unixSec() * 1000_000_000 + int64!(self.nsec()) [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1318:24 [INFO] [stdout] | [INFO] [stdout] 1318 | let n = nsec / 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1320:21 [INFO] [stdout] | [INFO] [stdout] 1320 | nsec -= n * 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1322:21 [INFO] [stdout] | [INFO] [stdout] 1322 | nsec += 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1360:39 [INFO] [stdout] | [INFO] [stdout] 1360 | Unix(msec / 1000, (msec % 1000) * 1000_000) [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1369:17 [INFO] [stdout] | [INFO] [stdout] 1369 | Unix(usec / 1000_000, (usec % 1000_000) * 1000) [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1369:35 [INFO] [stdout] | [INFO] [stdout] 1369 | Unix(usec / 1000_000, (usec % 1000_000) * 1000) [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:1442:39 [INFO] [stdout] | [INFO] [stdout] 1442 | let (sec, nsec) = norm(sec, nsec, 1000_000_000); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:2690:9 [INFO] [stdout] | [INFO] [stdout] 2690 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:2710:1 [INFO] [stdout] | [INFO] [stdout] 2710 | use lazy_static; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3115:4 [INFO] [stdout] | [INFO] [stdout] 3115 | /// let complex = time::ParseDuration("1h10m10s").ok().unwrap(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3116:4 [INFO] [stdout] | [INFO] [stdout] 3116 | /// let micro = time::ParseDuration("1µs").ok().unwrap(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:2356:18 [INFO] [stdout] | [INFO] [stdout] 2356 | if ns < 0 || 1000_0000_000 < ns { [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3117:4 [INFO] [stdout] | [INFO] [stdout] 3117 | /// // The package also accepts the incorrect but common prefix u for micro. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/lib.rs:2378:17 [INFO] [stdout] | [INFO] [stdout] 2378 | if x > (1 << 63 - 1) / 10 { [INFO] [stdout] | ^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (63 - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3118:4 [INFO] [stdout] | [INFO] [stdout] 3118 | /// let micro2 = time::ParseDuration("1us").ok().unwrap(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/lib.rs:2407:17 [INFO] [stdout] | [INFO] [stdout] 2407 | if x > (1 << 63 - 1) / 10 { [INFO] [stdout] | ^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (63 - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3123:4 [INFO] [stdout] | [INFO] [stdout] 3123 | /// println!("{}",hours); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3124:4 [INFO] [stdout] | [INFO] [stdout] 3124 | /// println!("{}",complex); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3125:4 [INFO] [stdout] | [INFO] [stdout] 3125 | /// println!("There are {} seconds in {}.", complex.Seconds(), complex); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3126:4 [INFO] [stdout] | [INFO] [stdout] 3126 | /// println!("There are {} nanoseconds in {}.", micro.Nanoseconds(), micro); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3127:4 [INFO] [stdout] | [INFO] [stdout] 3127 | /// println!("There are {} seconds in {}.", micro2.Seconds(), micro2); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3128:4 [INFO] [stdout] | [INFO] [stdout] 3128 | /// ``` [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3129:4 [INFO] [stdout] | [INFO] [stdout] 3129 | /// ## Output: [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3131:4 [INFO] [stdout] | [INFO] [stdout] 3131 | /// ```text [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3133:4 [INFO] [stdout] | [INFO] [stdout] 3133 | /// 10h0m0s [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:3345:37 [INFO] [stdout] | [INFO] [stdout] 3345 | let mut tmp = (sec >> 32) * 1000_0000_000; [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:2690:9 [INFO] [stdout] | [INFO] [stdout] 2690 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:3348:36 [INFO] [stdout] | [INFO] [stdout] 3348 | tmp = (sec & 0xFFFFFFFF) * 1000_0000_000; [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:2710:1 [INFO] [stdout] | [INFO] [stdout] 2710 | use lazy_static; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:3744:16 [INFO] [stdout] | [INFO] [stdout] 3744 | const errBad: &'static str = "bad value for field"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3115:4 [INFO] [stdout] | [INFO] [stdout] 3115 | /// let complex = time::ParseDuration("1h10m10s").ok().unwrap(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3116:4 [INFO] [stdout] | [INFO] [stdout] 3116 | /// let micro = time::ParseDuration("1µs").ok().unwrap(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3117:4 [INFO] [stdout] | [INFO] [stdout] 3117 | /// // The package also accepts the incorrect but common prefix u for micro. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3118:4 [INFO] [stdout] | [INFO] [stdout] 3118 | /// let micro2 = time::ParseDuration("1us").ok().unwrap(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3123:4 [INFO] [stdout] | [INFO] [stdout] 3123 | /// println!("{}",hours); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3124:4 [INFO] [stdout] | [INFO] [stdout] 3124 | /// println!("{}",complex); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3125:4 [INFO] [stdout] | [INFO] [stdout] 3125 | /// println!("There are {} seconds in {}.", complex.Seconds(), complex); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3126:4 [INFO] [stdout] | [INFO] [stdout] 3126 | /// println!("There are {} nanoseconds in {}.", micro.Nanoseconds(), micro); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3127:4 [INFO] [stdout] | [INFO] [stdout] 3127 | /// println!("There are {} seconds in {}.", micro2.Seconds(), micro2); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3128:4 [INFO] [stdout] | [INFO] [stdout] 3128 | /// ``` [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3129:4 [INFO] [stdout] | [INFO] [stdout] 3129 | /// ## Output: [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3131:4 [INFO] [stdout] | [INFO] [stdout] 3131 | /// ```text [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:3133:4 [INFO] [stdout] | [INFO] [stdout] 3133 | /// 10h0m0s [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:3345:37 [INFO] [stdout] | [INFO] [stdout] 3345 | let mut tmp = (sec >> 32) * 1000_0000_000; [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/lib.rs:3348:36 [INFO] [stdout] | [INFO] [stdout] 3348 | tmp = (sec & 0xFFFFFFFF) * 1000_0000_000; [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:3744:16 [INFO] [stdout] | [INFO] [stdout] 3744 | const errBad: &'static str = "bad value for field"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:466:13 [INFO] [stdout] | [INFO] [stdout] 466 | m2 = m2 % 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m2 %= 1000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:466:13 [INFO] [stdout] | [INFO] [stdout] 466 | m2 = m2 % 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m2 %= 1000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 468 | m1 = m1 % 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m1 %= 1000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 468 | m1 = m1 % 1000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m1 %= 1000_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:503:9 [INFO] [stdout] | [INFO] [stdout] 503 | return self.sec() + internalToUnix; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 503 - return self.sec() + internalToUnix; [INFO] [stdout] 503 + self.sec() + internalToUnix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:511:16 [INFO] [stdout] | [INFO] [stdout] 511 | if 0 <= dsec && dsec <= (1 << 33) - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=(1 << 33) - 1).contains(&dsec)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:503:9 [INFO] [stdout] | [INFO] [stdout] 503 | return self.sec() + internalToUnix; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 503 - return self.sec() + internalToUnix; [INFO] [stdout] 503 + self.sec() + internalToUnix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:511:16 [INFO] [stdout] | [INFO] [stdout] 511 | if 0 <= dsec && dsec <= (1 << 33) - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=(1 << 33) - 1).contains(&dsec)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:551:16 [INFO] [stdout] | [INFO] [stdout] 551 | if sec < minWall || maxWall < sec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(minWall..=maxWall).contains(&sec)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:551:16 [INFO] [stdout] | [INFO] [stdout] 551 | if sec < minWall || maxWall < sec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(minWall..=maxWall).contains(&sec)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:671:12 [INFO] [stdout] | [INFO] [stdout] 671 | if l.name.len() == 0 || l.name.as_str() == "Local" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:676:16 [INFO] [stdout] | [INFO] [stdout] 676 | if l.cacheZone.name.len() != 0 && l.cacheStart <= sec && sec < l.cacheEnd { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.cacheZone.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:694:12 [INFO] [stdout] | [INFO] [stdout] 694 | if l.name.len() == 0 || l.name.as_str() == "Local" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:700:16 [INFO] [stdout] | [INFO] [stdout] 700 | if l.cacheZone.name.len() != 0 && l.cacheStart <= sec && sec < l.cacheEnd { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.cacheZone.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:671:12 [INFO] [stdout] | [INFO] [stdout] 671 | if l.name.len() == 0 || l.name.as_str() == "Local" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:676:16 [INFO] [stdout] | [INFO] [stdout] 676 | if l.cacheZone.name.len() != 0 && l.cacheStart <= sec && sec < l.cacheEnd { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.cacheZone.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:694:12 [INFO] [stdout] | [INFO] [stdout] 694 | if l.name.len() == 0 || l.name.as_str() == "Local" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:700:16 [INFO] [stdout] | [INFO] [stdout] 700 | if l.cacheZone.name.len() != 0 && l.cacheStart <= sec && sec < l.cacheEnd { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.cacheZone.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1087:9 [INFO] [stdout] | [INFO] [stdout] 1087 | return t.Add(&Duration::new(d1 - r.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1087 - return t.Add(&Duration::new(d1 - r.0)); [INFO] [stdout] 1087 + t.Add(&Duration::new(d1 - r.0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1087:9 [INFO] [stdout] | [INFO] [stdout] 1087 | return t.Add(&Duration::new(d1 - r.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1087 - return t.Add(&Duration::new(d1 - r.0)); [INFO] [stdout] 1087 + t.Add(&Duration::new(d1 - r.0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:1188:12 [INFO] [stdout] | [INFO] [stdout] 1188 | if l.name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1286:9 [INFO] [stdout] | [INFO] [stdout] 1286 | / return Date( [INFO] [stdout] 1287 | | year + years, [INFO] [stdout] 1288 | | uint!(months) + uint!(month), [INFO] [stdout] 1289 | | day + days, [INFO] [stdout] ... | [INFO] [stdout] 1294 | | self.loc.clone(), [INFO] [stdout] 1295 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1286 ~ Date( [INFO] [stdout] 1287 + year + years, [INFO] [stdout] 1288 + uint!(months) + uint!(month), [INFO] [stdout] 1289 + day + days, [INFO] [stdout] 1290 + hour, [INFO] [stdout] 1291 + min, [INFO] [stdout] 1292 + sec, [INFO] [stdout] 1293 + int!(self.nsec()), [INFO] [stdout] 1294 + self.loc.clone(), [INFO] [stdout] 1295 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/lib.rs:1317:8 [INFO] [stdout] | [INFO] [stdout] 1317 | if nsec < 0 || nsec >= 100_000_000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..100_000_000).contains(&nsec)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:1188:12 [INFO] [stdout] | [INFO] [stdout] 1188 | if l.name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:1423:1 [INFO] [stdout] | [INFO] [stdout] 1423 | / pub fn Date( [INFO] [stdout] 1424 | | year: int, [INFO] [stdout] 1425 | | month: uint, [INFO] [stdout] 1426 | | day: int, [INFO] [stdout] ... | [INFO] [stdout] 1431 | | loc: Location, [INFO] [stdout] 1432 | | ) -> Time { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1286:9 [INFO] [stdout] | [INFO] [stdout] 1286 | / return Date( [INFO] [stdout] 1287 | | year + years, [INFO] [stdout] 1288 | | uint!(months) + uint!(month), [INFO] [stdout] 1289 | | day + days, [INFO] [stdout] ... | [INFO] [stdout] 1294 | | self.loc.clone(), [INFO] [stdout] 1295 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1286 ~ Date( [INFO] [stdout] 1287 + year + years, [INFO] [stdout] 1288 + uint!(months) + uint!(month), [INFO] [stdout] 1289 + day + days, [INFO] [stdout] 1290 + hour, [INFO] [stdout] 1291 + min, [INFO] [stdout] 1292 + sec, [INFO] [stdout] 1293 + int!(self.nsec()), [INFO] [stdout] 1294 + self.loc.clone(), [INFO] [stdout] 1295 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/lib.rs:1317:8 [INFO] [stdout] | [INFO] [stdout] 1317 | if nsec < 0 || nsec >= 100_000_000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..100_000_000).contains(&nsec)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Some` value [INFO] [stdout] --> src/lib.rs:1468:13 [INFO] [stdout] | [INFO] [stdout] 1468 | let l = loc.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Some` and `unwrap()` [INFO] [stdout] --> src/lib.rs:1433:15 [INFO] [stdout] | [INFO] [stdout] 1433 | let loc = Some(loc); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:1423:1 [INFO] [stdout] | [INFO] [stdout] 1423 | / pub fn Date( [INFO] [stdout] 1424 | | year: int, [INFO] [stdout] 1425 | | month: uint, [INFO] [stdout] 1426 | | day: int, [INFO] [stdout] ... | [INFO] [stdout] 1431 | | loc: Location, [INFO] [stdout] 1432 | | ) -> Time { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Some` value [INFO] [stdout] --> src/lib.rs:1468:13 [INFO] [stdout] | [INFO] [stdout] 1468 | let l = loc.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Some` and `unwrap()` [INFO] [stdout] --> src/lib.rs:1433:15 [INFO] [stdout] | [INFO] [stdout] 1433 | let loc = Some(loc); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:1602:12 [INFO] [stdout] | [INFO] [stdout] 1602 | if err != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!err.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:1603:24 [INFO] [stdout] | [INFO] [stdout] 1603 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 1604 | | ErrorKind::Other, [INFO] [stdout] 1605 | | format!("{} {} {} {} {}", alayout, avalue, prefix, value, ""), [INFO] [stdout] 1606 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 1603 ~ return Err(Error::other( [INFO] [stdout] 1604 ~ format!("{} {} {} {} {}", alayout, avalue, prefix, value, ""), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:1610:28 [INFO] [stdout] | [INFO] [stdout] 1610 | return Err(Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1611 | | ErrorKind::Other, [INFO] [stdout] 1612 | | format!( [INFO] [stdout] 1613 | | "{} {} {} {}", [INFO] [stdout] ... | [INFO] [stdout] 1618 | | ), [INFO] [stdout] 1619 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 1610 ~ return Err(Error::other( [INFO] [stdout] 1611 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/lib.rs:1612:21 [INFO] [stdout] | [INFO] [stdout] 1612 | / format!( [INFO] [stdout] 1613 | | "{} {} {} {}", [INFO] [stdout] 1614 | | alayout, [INFO] [stdout] 1615 | | avalue, [INFO] [stdout] 1616 | | "", [INFO] [stdout] 1617 | | format!("{} {}", "extra text:", value) [INFO] [stdout] 1618 | | ), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:1602:12 [INFO] [stdout] | [INFO] [stdout] 1602 | if err != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!err.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:1603:24 [INFO] [stdout] | [INFO] [stdout] 1603 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 1604 | | ErrorKind::Other, [INFO] [stdout] 1605 | | format!("{} {} {} {} {}", alayout, avalue, prefix, value, ""), [INFO] [stdout] 1606 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 1603 ~ return Err(Error::other( [INFO] [stdout] 1604 ~ format!("{} {} {} {} {}", alayout, avalue, prefix, value, ""), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:1610:28 [INFO] [stdout] | [INFO] [stdout] 1610 | return Err(Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1611 | | ErrorKind::Other, [INFO] [stdout] 1612 | | format!( [INFO] [stdout] 1613 | | "{} {} {} {}", [INFO] [stdout] ... | [INFO] [stdout] 1618 | | ), [INFO] [stdout] 1619 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 1610 ~ return Err(Error::other( [INFO] [stdout] 1611 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/lib.rs:1612:21 [INFO] [stdout] | [INFO] [stdout] 1612 | / format!( [INFO] [stdout] 1613 | | "{} {} {} {}", [INFO] [stdout] 1614 | | alayout, [INFO] [stdout] 1615 | | avalue, [INFO] [stdout] 1616 | | "", [INFO] [stdout] 1617 | | format!("{} {}", "extra text:", value) [INFO] [stdout] 1618 | | ), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1722:61 [INFO] [stdout] | [INFO] [stdout] 1722 | if std == stdUnderDay && len!(value) > 0 && value.bytes().nth(0) == Some(b' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] = note: `#[warn(clippy::bytes_nth)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1742:28 [INFO] [stdout] | [INFO] [stdout] 1742 | && value.bytes().nth(0) == Some(b' ') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/lib.rs:1770:20 [INFO] [stdout] | [INFO] [stdout] 1770 | if hour < 0 || 24 <= hour { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..24).contains(&hour)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:1784:20 [INFO] [stdout] | [INFO] [stdout] 1784 | if hour < 0 || 12 < hour { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..=12).contains(&hour)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/lib.rs:1799:20 [INFO] [stdout] | [INFO] [stdout] 1799 | if min < 0 || 60 <= min { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..60).contains(&min)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1722:61 [INFO] [stdout] | [INFO] [stdout] 1722 | if std == stdUnderDay && len!(value) > 0 && value.bytes().nth(0) == Some(b' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] = note: `#[warn(clippy::bytes_nth)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/lib.rs:1813:20 [INFO] [stdout] | [INFO] [stdout] 1813 | if sec < 0 || 60 <= sec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..60).contains(&sec)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:1820:38 [INFO] [stdout] | [INFO] [stdout] 1820 | && commaOrPeriod(value.bytes().nth(0).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1742:28 [INFO] [stdout] | [INFO] [stdout] 1742 | && value.bytes().nth(0) == Some(b' ') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1884:24 [INFO] [stdout] | [INFO] [stdout] 1884 | && value.bytes().nth(0) == Some(b'Z') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/lib.rs:1770:20 [INFO] [stdout] | [INFO] [stdout] 1770 | if hour < 0 || 24 <= hour { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..24).contains(&hour)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:1784:20 [INFO] [stdout] | [INFO] [stdout] 1784 | if hour < 0 || 12 < hour { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..=12).contains(&hour)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1899:24 [INFO] [stdout] | [INFO] [stdout] 1899 | if value.bytes().nth(3) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(3).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/lib.rs:1799:20 [INFO] [stdout] | [INFO] [stdout] 1799 | if min < 0 || 60 <= min { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..60).contains(&min)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/lib.rs:1813:20 [INFO] [stdout] | [INFO] [stdout] 1813 | if sec < 0 || 60 <= sec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..60).contains(&sec)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:1820:38 [INFO] [stdout] | [INFO] [stdout] 1820 | && commaOrPeriod(value.bytes().nth(0).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1924:24 [INFO] [stdout] | [INFO] [stdout] 1924 | if value.bytes().nth(3) != Some(b':') || value.bytes().nth(6) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(3).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1924:62 [INFO] [stdout] | [INFO] [stdout] 1924 | if value.bytes().nth(3) != Some(b':') || value.bytes().nth(6) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(6).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1884:24 [INFO] [stdout] | [INFO] [stdout] 1884 | && value.bytes().nth(0) == Some(b'Z') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1899:24 [INFO] [stdout] | [INFO] [stdout] 1899 | if value.bytes().nth(3) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(3).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1981:23 [INFO] [stdout] | [INFO] [stdout] 1981 | match sign.bytes().nth(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `sign.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1924:24 [INFO] [stdout] | [INFO] [stdout] 1924 | if value.bytes().nth(3) != Some(b':') || value.bytes().nth(6) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(3).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1924:62 [INFO] [stdout] | [INFO] [stdout] 1924 | if value.bytes().nth(3) != Some(b':') || value.bytes().nth(6) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(6).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2023:39 [INFO] [stdout] | [INFO] [stdout] 2023 | || !commaOrPeriod(value.bytes().nth(0).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2024:24 [INFO] [stdout] | [INFO] [stdout] 2024 | || value.bytes().nth(1) < Some(b'0') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2025:37 [INFO] [stdout] | [INFO] [stdout] 2025 | || Some(b'9') < value.bytes().nth(1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2035:38 [INFO] [stdout] | [INFO] [stdout] 2035 | && Some(b'0') <= value.bytes().nth(i + 1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(i + 1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2036:24 [INFO] [stdout] | [INFO] [stdout] 2036 | && value.bytes().nth(i + 1) <= Some(b'9')) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(i + 1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2051:12 [INFO] [stdout] | [INFO] [stdout] 2051 | if rangeErrString != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rangeErrString.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2052:24 [INFO] [stdout] | [INFO] [stdout] 2052 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2053 | | ErrorKind::Other, [INFO] [stdout] 2054 | | format!("{} {}", rangeErrString, " out of range"), [INFO] [stdout] 2055 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2052 ~ return Err(Error::other( [INFO] [stdout] 2053 ~ format!("{} {}", rangeErrString, " out of range"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2057:12 [INFO] [stdout] | [INFO] [stdout] 2057 | if err != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!err.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2058:24 [INFO] [stdout] | [INFO] [stdout] 2058 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2059 | | ErrorKind::Other, [INFO] [stdout] 2060 | | format!("{} {}", "ParseError:", err), [INFO] [stdout] 2061 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2058 ~ return Err(Error::other( [INFO] [stdout] 2059 ~ format!("{} {}", "ParseError:", err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:1981:23 [INFO] [stdout] | [INFO] [stdout] 1981 | match sign.bytes().nth(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `sign.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2082:12 [INFO] [stdout] | [INFO] [stdout] 2082 | if yday < 1 || yday > 365 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=365).contains(&yday)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2083:24 [INFO] [stdout] | [INFO] [stdout] 2083 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2084 | | ErrorKind::Other, [INFO] [stdout] 2085 | | format!( [INFO] [stdout] 2086 | | "{} {} {} {} {}", [INFO] [stdout] 2087 | | alayout, avalue, "", value, ": day-of-year out of range" [INFO] [stdout] 2088 | | ), [INFO] [stdout] 2089 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2083 ~ return Err(Error::other( [INFO] [stdout] 2084 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2023:39 [INFO] [stdout] | [INFO] [stdout] 2023 | || !commaOrPeriod(value.bytes().nth(0).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2024:24 [INFO] [stdout] | [INFO] [stdout] 2024 | || value.bytes().nth(1) < Some(b'0') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2101:24 [INFO] [stdout] | [INFO] [stdout] 2101 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2102 | | ErrorKind::Other, [INFO] [stdout] 2103 | | format!( [INFO] [stdout] 2104 | | "{} {} {} {} {}", [INFO] [stdout] 2105 | | alayout, avalue, "", value, ": day-of-year does not match month" [INFO] [stdout] 2106 | | ), [INFO] [stdout] 2107 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2101 ~ return Err(Error::other( [INFO] [stdout] 2102 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2025:37 [INFO] [stdout] | [INFO] [stdout] 2025 | || Some(b'9') < value.bytes().nth(1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2035:38 [INFO] [stdout] | [INFO] [stdout] 2035 | && Some(b'0') <= value.bytes().nth(i + 1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(i + 1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2036:24 [INFO] [stdout] | [INFO] [stdout] 2036 | && value.bytes().nth(i + 1) <= Some(b'9')) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(i + 1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2111:24 [INFO] [stdout] | [INFO] [stdout] 2111 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2112 | | ErrorKind::Other, [INFO] [stdout] 2113 | | format!( [INFO] [stdout] 2114 | | "{} {} {} {} {}", [INFO] [stdout] 2115 | | alayout, avalue, "", value, ": day-of-year does not match day" [INFO] [stdout] 2116 | | ), [INFO] [stdout] 2117 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2111 ~ return Err(Error::other( [INFO] [stdout] 2112 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2051:12 [INFO] [stdout] | [INFO] [stdout] 2051 | if rangeErrString != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rangeErrString.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2052:24 [INFO] [stdout] | [INFO] [stdout] 2052 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2053 | | ErrorKind::Other, [INFO] [stdout] 2054 | | format!("{} {}", rangeErrString, " out of range"), [INFO] [stdout] 2055 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2052 ~ return Err(Error::other( [INFO] [stdout] 2053 ~ format!("{} {}", rangeErrString, " out of range"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2131:20 [INFO] [stdout] | [INFO] [stdout] 2131 | return Err(Error::new( [INFO] [stdout] | ____________________^ [INFO] [stdout] 2132 | | ErrorKind::Other, [INFO] [stdout] 2133 | | format!( [INFO] [stdout] 2134 | | "{} {} {} {} {}", [INFO] [stdout] 2135 | | alayout, avalue, "", value, ": day out of range" [INFO] [stdout] 2136 | | ), [INFO] [stdout] 2137 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2131 ~ return Err(Error::other( [INFO] [stdout] 2132 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2057:12 [INFO] [stdout] | [INFO] [stdout] 2057 | if err != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!err.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2140:8 [INFO] [stdout] | [INFO] [stdout] 2140 | if z.name != "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!z.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2058:24 [INFO] [stdout] | [INFO] [stdout] 2058 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2059 | | ErrorKind::Other, [INFO] [stdout] 2060 | | format!("{} {}", "ParseError:", err), [INFO] [stdout] 2061 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2058 ~ return Err(Error::other( [INFO] [stdout] 2059 ~ format!("{} {}", "ParseError:", err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2160:37 [INFO] [stdout] | [INFO] [stdout] 2160 | if offset == zoneOffset && (zoneName == "" || name == zoneName) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `zoneName.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2171:8 [INFO] [stdout] | [INFO] [stdout] 2171 | if zoneName != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!zoneName.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2082:12 [INFO] [stdout] | [INFO] [stdout] 2082 | if yday < 1 || yday > 365 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=365).contains(&yday)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2083:24 [INFO] [stdout] | [INFO] [stdout] 2083 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2084 | | ErrorKind::Other, [INFO] [stdout] 2085 | | format!( [INFO] [stdout] 2086 | | "{} {} {} {} {}", [INFO] [stdout] 2087 | | alayout, avalue, "", value, ": day-of-year out of range" [INFO] [stdout] 2088 | | ), [INFO] [stdout] 2089 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2083 ~ return Err(Error::other( [INFO] [stdout] 2084 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2209:27 [INFO] [stdout] | [INFO] [stdout] 2209 | while (len!(s) > 0 && s.bytes().nth(0) == Some(b' ')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2101:24 [INFO] [stdout] | [INFO] [stdout] 2101 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2102 | | ErrorKind::Other, [INFO] [stdout] 2103 | | format!( [INFO] [stdout] 2104 | | "{} {} {} {} {}", [INFO] [stdout] 2105 | | alayout, avalue, "", value, ": day-of-year does not match month" [INFO] [stdout] 2106 | | ), [INFO] [stdout] 2107 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2101 ~ return Err(Error::other( [INFO] [stdout] 2102 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2224:25 [INFO] [stdout] | [INFO] [stdout] 2224 | return Ok((int!(s.bytes().nth(0).unwrap() - b'0'), &s[1..])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2228:15 [INFO] [stdout] | [INFO] [stdout] 2228 | int!((s.bytes().nth(0).unwrap() - b'0') * 10) + int!(s.bytes().nth(1).unwrap() - b'0'), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2111:24 [INFO] [stdout] | [INFO] [stdout] 2111 | return Err(Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 2112 | | ErrorKind::Other, [INFO] [stdout] 2113 | | format!( [INFO] [stdout] 2114 | | "{} {} {} {} {}", [INFO] [stdout] 2115 | | alayout, avalue, "", value, ": day-of-year does not match day" [INFO] [stdout] 2116 | | ), [INFO] [stdout] 2117 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2111 ~ return Err(Error::other( [INFO] [stdout] 2112 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2228:62 [INFO] [stdout] | [INFO] [stdout] 2228 | int!((s.bytes().nth(0).unwrap() - b'0') * 10) + int!(s.bytes().nth(1).unwrap() - b'0'), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2238:27 [INFO] [stdout] | [INFO] [stdout] 2238 | n = n * 10 + int!(s.bytes().nth(i).unwrap() - b'0'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2131:20 [INFO] [stdout] | [INFO] [stdout] 2131 | return Err(Error::new( [INFO] [stdout] | ____________________^ [INFO] [stdout] 2132 | | ErrorKind::Other, [INFO] [stdout] 2133 | | format!( [INFO] [stdout] 2134 | | "{} {} {} {} {}", [INFO] [stdout] 2135 | | alayout, avalue, "", value, ": day out of range" [INFO] [stdout] 2136 | | ), [INFO] [stdout] 2137 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2131 ~ return Err(Error::other( [INFO] [stdout] 2132 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2250:8 [INFO] [stdout] | [INFO] [stdout] 2250 | if s != "" && (s.bytes().nth(0) == Some(b'-') || s.bytes().nth(0) == Some(b'+')) { [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2250:20 [INFO] [stdout] | [INFO] [stdout] 2250 | if s != "" && (s.bytes().nth(0) == Some(b'-') || s.bytes().nth(0) == Some(b'+')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2140:8 [INFO] [stdout] | [INFO] [stdout] 2140 | if z.name != "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!z.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2160:37 [INFO] [stdout] | [INFO] [stdout] 2160 | if offset == zoneOffset && (zoneName == "" || name == zoneName) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `zoneName.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2250:54 [INFO] [stdout] | [INFO] [stdout] 2250 | if s != "" && (s.bytes().nth(0) == Some(b'-') || s.bytes().nth(0) == Some(b'+')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2251:16 [INFO] [stdout] | [INFO] [stdout] 2251 | neg = (s.bytes().nth(0) == Some(b'-')); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2171:8 [INFO] [stdout] | [INFO] [stdout] 2171 | if zoneName != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!zoneName.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2277:8 [INFO] [stdout] | [INFO] [stdout] 2277 | if value.bytes().nth(0) == Some(b'+') || value.bytes().nth(0) == Some(b'-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2277:46 [INFO] [stdout] | [INFO] [stdout] 2277 | if value.bytes().nth(0) == Some(b'+') || value.bytes().nth(0) == Some(b'-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2209:27 [INFO] [stdout] | [INFO] [stdout] 2209 | while (len!(s) > 0 && s.bytes().nth(0) == Some(b' ')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2289:17 [INFO] [stdout] | [INFO] [stdout] 2289 | let c = value.bytes().nth(n); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(n).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2224:25 [INFO] [stdout] | [INFO] [stdout] 2224 | return Ok((int!(s.bytes().nth(0).unwrap() - b'0'), &s[1..])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2298:16 [INFO] [stdout] | [INFO] [stdout] 2298 | if value.bytes().nth(4) == Some(b'T') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(4).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2228:15 [INFO] [stdout] | [INFO] [stdout] 2228 | int!((s.bytes().nth(0).unwrap() - b'0') * 10) + int!(s.bytes().nth(1).unwrap() - b'0'), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2304:16 [INFO] [stdout] | [INFO] [stdout] 2304 | if value.bytes().nth(3) == Some(b'T') || &value[..4] == "WITA" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(3).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2228:62 [INFO] [stdout] | [INFO] [stdout] 2228 | int!((s.bytes().nth(0).unwrap() - b'0') * 10) + int!(s.bytes().nth(1).unwrap() - b'0'), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2238:27 [INFO] [stdout] | [INFO] [stdout] 2238 | n = n * 10 + int!(s.bytes().nth(i).unwrap() - b'0'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2343:5 [INFO] [stdout] | [INFO] [stdout] 2343 | return int!(len!(value) - len!(rem)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2343 - return int!(len!(value) - len!(rem)); [INFO] [stdout] 2343 + int!(len!(value) - len!(rem)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2324:16 [INFO] [stdout] | [INFO] [stdout] 2324 | let sign = value.bytes().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2250:8 [INFO] [stdout] | [INFO] [stdout] 2250 | if s != "" && (s.bytes().nth(0) == Some(b'-') || s.bytes().nth(0) == Some(b'+')) { [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2340:8 [INFO] [stdout] | [INFO] [stdout] 2340 | if x < -23 || 23 < x { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `!(-23..=23).contains(&x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2250:20 [INFO] [stdout] | [INFO] [stdout] 2250 | if s != "" && (s.bytes().nth(0) == Some(b'-') || s.bytes().nth(0) == Some(b'+')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2250:54 [INFO] [stdout] | [INFO] [stdout] 2250 | if s != "" && (s.bytes().nth(0) == Some(b'-') || s.bytes().nth(0) == Some(b'+')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2251:16 [INFO] [stdout] | [INFO] [stdout] 2251 | neg = (s.bytes().nth(0) == Some(b'-')); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2347:5 [INFO] [stdout] | [INFO] [stdout] 2347 | return b == b'.' || b == b','; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2347 - return b == b'.' || b == b','; [INFO] [stdout] 2347 + b == b'.' || b == b',' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2351:23 [INFO] [stdout] | [INFO] [stdout] 2351 | if !commaOrPeriod(value.bytes().nth(0).unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2356:8 [INFO] [stdout] | [INFO] [stdout] 2356 | if ns < 0 || 1000_0000_000 < ns { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..=1000_0000_000).contains(&ns)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2277:8 [INFO] [stdout] | [INFO] [stdout] 2277 | if value.bytes().nth(0) == Some(b'+') || value.bytes().nth(0) == Some(b'-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2277:46 [INFO] [stdout] | [INFO] [stdout] 2277 | if value.bytes().nth(0) == Some(b'+') || value.bytes().nth(0) == Some(b'-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2374:17 [INFO] [stdout] | [INFO] [stdout] 2374 | let c = s.bytes().nth(i).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2289:17 [INFO] [stdout] | [INFO] [stdout] 2289 | let c = value.bytes().nth(n); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(n).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2375:12 [INFO] [stdout] | [INFO] [stdout] 2375 | if c < b'0' || c > b'9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2298:16 [INFO] [stdout] | [INFO] [stdout] 2298 | if value.bytes().nth(4) == Some(b'T') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(4).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2304:16 [INFO] [stdout] | [INFO] [stdout] 2304 | if value.bytes().nth(3) == Some(b'T') || &value[..4] == "WITA" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(3).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2401:12 [INFO] [stdout] | [INFO] [stdout] 2401 | if c < b'0' || c > b'9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2343:5 [INFO] [stdout] | [INFO] [stdout] 2343 | return int!(len!(value) - len!(rem)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2343 - return int!(len!(value) - len!(rem)); [INFO] [stdout] 2343 + int!(len!(value) - len!(rem)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2324:16 [INFO] [stdout] | [INFO] [stdout] 2324 | let sign = value.bytes().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2427:12 [INFO] [stdout] | [INFO] [stdout] 2427 | if prefix.bytes().nth(0) == Some(b' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `prefix.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2428:35 [INFO] [stdout] | [INFO] [stdout] 2428 | if len!(value) > 0 && value.bytes().nth(0) != Some(b' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2429:28 [INFO] [stdout] | [INFO] [stdout] 2429 | return Err(Error::new(ErrorKind::Other, "skip err1")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2429 - return Err(Error::new(ErrorKind::Other, "skip err1")); [INFO] [stdout] 2429 + return Err(Error::other("skip err1")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2435:33 [INFO] [stdout] | [INFO] [stdout] 2435 | if len!(value) == 0 || (value.bytes().nth(0) != prefix.bytes().nth(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2340:8 [INFO] [stdout] | [INFO] [stdout] 2340 | if x < -23 || 23 < x { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `!(-23..=23).contains(&x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2435:57 [INFO] [stdout] | [INFO] [stdout] 2435 | if len!(value) == 0 || (value.bytes().nth(0) != prefix.bytes().nth(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `prefix.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2347:5 [INFO] [stdout] | [INFO] [stdout] 2347 | return b == b'.' || b == b','; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2347 - return b == b'.' || b == b','; [INFO] [stdout] 2347 + b == b'.' || b == b',' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2436:24 [INFO] [stdout] | [INFO] [stdout] 2436 | return Err(Error::new(ErrorKind::Other, "skip err2")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2436 - return Err(Error::new(ErrorKind::Other, "skip err2")); [INFO] [stdout] 2436 + return Err(Error::other("skip err2")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2351:23 [INFO] [stdout] | [INFO] [stdout] 2351 | if !commaOrPeriod(value.bytes().nth(0).unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2356:8 [INFO] [stdout] | [INFO] [stdout] 2356 | if ns < 0 || 1000_0000_000 < ns { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..=1000_0000_000).contains(&ns)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:2374:17 [INFO] [stdout] | [INFO] [stdout] 2374 | let c = s.bytes().nth(i).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2375:12 [INFO] [stdout] | [INFO] [stdout] 2375 | if c < b'0' || c > b'9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2496:12 [INFO] [stdout] | [INFO] [stdout] 2496 | if self.name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:2401:12 [INFO] [stdout] | [INFO] [stdout] 2401 | if c < b'0' || c > b'9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2427:12 [INFO] [stdout] | [INFO] [stdout] 2427 | if prefix.bytes().nth(0) == Some(b' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `prefix.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2428:35 [INFO] [stdout] | [INFO] [stdout] 2428 | if len!(value) > 0 && value.bytes().nth(0) != Some(b' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2526:12 [INFO] [stdout] | [INFO] [stdout] 2526 | if l.zone.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.zone.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2429:28 [INFO] [stdout] | [INFO] [stdout] 2429 | return Err(Error::new(ErrorKind::Other, "skip err1")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2429 - return Err(Error::new(ErrorKind::Other, "skip err1")); [INFO] [stdout] 2429 + return Err(Error::other("skip err1")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2435:33 [INFO] [stdout] | [INFO] [stdout] 2435 | if len!(value) == 0 || (value.bytes().nth(0) != prefix.bytes().nth(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:2435:57 [INFO] [stdout] | [INFO] [stdout] 2435 | if len!(value) == 0 || (value.bytes().nth(0) != prefix.bytes().nth(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `prefix.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2543:12 [INFO] [stdout] | [INFO] [stdout] 2543 | if l.tx.len() == 0 || sec < l.tx[0].when { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.tx.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:2436:24 [INFO] [stdout] | [INFO] [stdout] 2436 | return Err(Error::new(ErrorKind::Other, "skip err2")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 2436 - return Err(Error::new(ErrorKind::Other, "skip err2")); [INFO] [stdout] 2436 + return Err(Error::other("skip err2")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2548:16 [INFO] [stdout] | [INFO] [stdout] 2548 | if l.tx.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.tx.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2577:34 [INFO] [stdout] | [INFO] [stdout] 2577 | if lo == tx.len() - 1 && l.extend != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.extend.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2592:12 [INFO] [stdout] | [INFO] [stdout] 2592 | if self.tx.len() > 0 && self.zone[index].isDST { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.tx.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2496:12 [INFO] [stdout] | [INFO] [stdout] 2496 | if self.name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2526:12 [INFO] [stdout] | [INFO] [stdout] 2526 | if l.zone.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.zone.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2543:12 [INFO] [stdout] | [INFO] [stdout] 2543 | if l.tx.len() == 0 || sec < l.tx[0].when { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.tx.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2548:16 [INFO] [stdout] | [INFO] [stdout] 2548 | if l.tx.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.tx.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:2577:34 [INFO] [stdout] | [INFO] [stdout] 2577 | if lo == tx.len() - 1 && l.extend != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.extend.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `zo.get(0)` [INFO] [stdout] --> src/lib.rs:2704:20 [INFO] [stdout] | [INFO] [stdout] 2704 | cacheZone: zo.get(0).unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^ help: try: `zo.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2592:12 [INFO] [stdout] | [INFO] [stdout] 2592 | if self.tx.len() > 0 && self.zone[index].isDST { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.tx.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `zo.get(0)` [INFO] [stdout] --> src/lib.rs:2704:20 [INFO] [stdout] | [INFO] [stdout] 2704 | cacheZone: zo.get(0).unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^ help: try: `zo.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:2826:13 [INFO] [stdout] | [INFO] [stdout] 2826 | day = day - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `day -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:2836:5 [INFO] [stdout] | [INFO] [stdout] 2836 | let begin: int; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `begin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 2836 ~ [INFO] [stdout] 2837 ~ let begin: int = if day >= end { [INFO] [stdout] 2838 | m += 1; [INFO] [stdout] 2839 ~ end [INFO] [stdout] 2840 | } else { [INFO] [stdout] 2841 ~ int!(daysBefore[m]) [INFO] [stdout] 2842 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:2826:13 [INFO] [stdout] | [INFO] [stdout] 2826 | day = day - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `day -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:2836:5 [INFO] [stdout] | [INFO] [stdout] 2836 | let begin: int; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `begin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 2836 ~ [INFO] [stdout] 2837 ~ let begin: int = if day >= end { [INFO] [stdout] 2838 | m += 1; [INFO] [stdout] 2839 ~ end [INFO] [stdout] 2840 | } else { [INFO] [stdout] 2841 ~ int!(daysBefore[m]) [INFO] [stdout] 2842 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3147:8 [INFO] [stdout] | [INFO] [stdout] 3147 | if s != "" { [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3158:8 [INFO] [stdout] | [INFO] [stdout] 3158 | if s == "" { [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3161:11 [INFO] [stdout] | [INFO] [stdout] 3161 | while s != "" { [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3189:12 [INFO] [stdout] | [INFO] [stdout] 3189 | if s != "" && s.as_bytes()[0] == b'.' { [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:3206:21 [INFO] [stdout] | [INFO] [stdout] 3206 | let c = s.bytes().nth(i).expect("time: nht index error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(i).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:3207:29 [INFO] [stdout] | [INFO] [stdout] 3207 | if c == b'.' || (b'0' <= c && c <= b'9') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3147:8 [INFO] [stdout] | [INFO] [stdout] 3147 | if s != "" { [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3158:8 [INFO] [stdout] | [INFO] [stdout] 3158 | if s == "" { [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3161:11 [INFO] [stdout] | [INFO] [stdout] 3161 | while s != "" { [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3189:12 [INFO] [stdout] | [INFO] [stdout] 3189 | if s != "" && s.as_bytes()[0] == b'.' { [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:3206:21 [INFO] [stdout] | [INFO] [stdout] 3206 | let c = s.bytes().nth(i).expect("time: nht index error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(i).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:3207:29 [INFO] [stdout] | [INFO] [stdout] 3207 | if c == b'.' || (b'0' <= c && c <= b'9') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3373:17 [INFO] [stdout] | [INFO] [stdout] 3373 | u0 = u0 - d0; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `u0 -= d0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:3643:24 [INFO] [stdout] | [INFO] [stdout] 3643 | if offset == 0 [INFO] [stdout] | ________________________^ [INFO] [stdout] 3644 | | && (std == stdISO8601TZ [INFO] [stdout] 3645 | | || std == stdISO8601ColonTZ [INFO] [stdout] 3646 | | || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 | | || std == stdISO8601ShortTZ [INFO] [stdout] 3648 | | || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 3643 - if offset == 0 [INFO] [stdout] 3644 - && (std == stdISO8601TZ [INFO] [stdout] 3645 - || std == stdISO8601ColonTZ [INFO] [stdout] 3646 - || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 - || std == stdISO8601ShortTZ [INFO] [stdout] 3648 - || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] 3643 + if !(offset != 0 || std != stdISO8601TZ && std != stdISO8601ColonTZ && std != stdISO8601ColonSecondsTZ && std != stdISO8601ShortTZ) [INFO] [stdout] | [INFO] [stdout] 3643 - if offset == 0 [INFO] [stdout] 3644 - && (std == stdISO8601TZ [INFO] [stdout] 3645 - || std == stdISO8601ColonTZ [INFO] [stdout] 3646 - || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 - || std == stdISO8601ShortTZ [INFO] [stdout] 3648 - || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] 3643 + if (std == stdISO8601ShortTZ || std == stdISO8601ColonSecondsTZ || std == stdISO8601ColonTZ || std == stdISO8601TZ) && offset == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:3644:28 [INFO] [stdout] | [INFO] [stdout] 3644 | && (std == stdISO8601TZ [INFO] [stdout] | ____________________________^ [INFO] [stdout] 3645 | | || std == stdISO8601ColonTZ [INFO] [stdout] 3646 | | || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 | | || std == stdISO8601ShortTZ [INFO] [stdout] 3648 | | || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 3644 - && (std == stdISO8601TZ [INFO] [stdout] 3645 - || std == stdISO8601ColonTZ [INFO] [stdout] 3646 - || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 - || std == stdISO8601ShortTZ [INFO] [stdout] 3648 - || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] 3644 + && !(std != stdISO8601TZ && std != stdISO8601ColonTZ && std != stdISO8601ColonSecondsTZ && std != stdISO8601ShortTZ) [INFO] [stdout] | [INFO] [stdout] 3644 - && (std == stdISO8601TZ [INFO] [stdout] 3645 - || std == stdISO8601ColonTZ [INFO] [stdout] 3646 - || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 - || std == stdISO8601ShortTZ [INFO] [stdout] 3648 - || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] 3644 + && std == stdISO8601TZ || std == stdISO8601ColonTZ || std == stdISO8601ColonSecondsTZ || std == stdISO8601ShortTZ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3373:17 [INFO] [stdout] | [INFO] [stdout] 3373 | u0 = u0 - d0; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `u0 -= d0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3488:16 [INFO] [stdout] | [INFO] [stdout] 3488 | while (layout != "") { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!layout.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3490:16 [INFO] [stdout] | [INFO] [stdout] 3490 | if prefix != "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!prefix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:3533:41 [INFO] [stdout] | [INFO] [stdout] 3533 | b.extend_from_slice(&month.clone().String().as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `month.clone().String().as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:3548:41 [INFO] [stdout] | [INFO] [stdout] 3548 | b.extend_from_slice(&s.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `s.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:3643:24 [INFO] [stdout] | [INFO] [stdout] 3643 | if offset == 0 [INFO] [stdout] | ________________________^ [INFO] [stdout] 3644 | | && (std == stdISO8601TZ [INFO] [stdout] 3645 | | || std == stdISO8601ColonTZ [INFO] [stdout] 3646 | | || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 | | || std == stdISO8601ShortTZ [INFO] [stdout] 3648 | | || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 3643 - if offset == 0 [INFO] [stdout] 3644 - && (std == stdISO8601TZ [INFO] [stdout] 3645 - || std == stdISO8601ColonTZ [INFO] [stdout] 3646 - || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 - || std == stdISO8601ShortTZ [INFO] [stdout] 3648 - || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] 3643 + if !(offset != 0 || std != stdISO8601TZ && std != stdISO8601ColonTZ && std != stdISO8601ColonSecondsTZ && std != stdISO8601ShortTZ) [INFO] [stdout] | [INFO] [stdout] 3643 - if offset == 0 [INFO] [stdout] 3644 - && (std == stdISO8601TZ [INFO] [stdout] 3645 - || std == stdISO8601ColonTZ [INFO] [stdout] 3646 - || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 - || std == stdISO8601ShortTZ [INFO] [stdout] 3648 - || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] 3643 + if (std == stdISO8601ShortTZ || std == stdISO8601ColonSecondsTZ || std == stdISO8601ColonTZ || std == stdISO8601TZ) && offset == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:3644:28 [INFO] [stdout] | [INFO] [stdout] 3644 | && (std == stdISO8601TZ [INFO] [stdout] | ____________________________^ [INFO] [stdout] 3645 | | || std == stdISO8601ColonTZ [INFO] [stdout] 3646 | | || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 | | || std == stdISO8601ShortTZ [INFO] [stdout] 3648 | | || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 3644 - && (std == stdISO8601TZ [INFO] [stdout] 3645 - || std == stdISO8601ColonTZ [INFO] [stdout] 3646 - || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 - || std == stdISO8601ShortTZ [INFO] [stdout] 3648 - || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] 3644 + && !(std != stdISO8601TZ && std != stdISO8601ColonTZ && std != stdISO8601ColonSecondsTZ && std != stdISO8601ShortTZ) [INFO] [stdout] | [INFO] [stdout] 3644 - && (std == stdISO8601TZ [INFO] [stdout] 3645 - || std == stdISO8601ColonTZ [INFO] [stdout] 3646 - || std == stdISO8601ColonSecondsTZ [INFO] [stdout] 3647 - || std == stdISO8601ShortTZ [INFO] [stdout] 3648 - || std == stdISO8601ColonSecondsTZ) [INFO] [stdout] 3644 + && std == stdISO8601TZ || std == stdISO8601ColonTZ || std == stdISO8601ColonSecondsTZ || std == stdISO8601ShortTZ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3488:16 [INFO] [stdout] | [INFO] [stdout] 3488 | while (layout != "") { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!layout.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3490:16 [INFO] [stdout] | [INFO] [stdout] 3490 | if prefix != "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!prefix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3690:24 [INFO] [stdout] | [INFO] [stdout] 3690 | if name != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:3533:41 [INFO] [stdout] | [INFO] [stdout] 3533 | b.extend_from_slice(&month.clone().String().as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `month.clone().String().as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:3789:8 [INFO] [stdout] | [INFO] [stdout] 3789 | if 0 == s.len() { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:3548:41 [INFO] [stdout] | [INFO] [stdout] 3548 | b.extend_from_slice(&s.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `s.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:3792:13 [INFO] [stdout] | [INFO] [stdout] 3792 | let c = s.bytes().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:3793:5 [INFO] [stdout] | [INFO] [stdout] 3793 | b'a' <= c && c <= b'z' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'a'..=b'z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:3801:5 [INFO] [stdout] | [INFO] [stdout] 3801 | return b'0' <= c && c <= b'9'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 3801 - return b'0' <= c && c <= b'9'; [INFO] [stdout] 3801 + b'0' <= c && c <= b'9' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:3801:12 [INFO] [stdout] | [INFO] [stdout] 3801 | return b'0' <= c && c <= b'9'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:3690:24 [INFO] [stdout] | [INFO] [stdout] 3690 | if name != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3817:17 [INFO] [stdout] | [INFO] [stdout] 3817 | / if layout.len() >= i + 3 && &layout[i..i + 3] == "Jan" { [INFO] [stdout] 3818 | | if layout.len() >= i + 7 && &layout[i..i + 7] == "January" { [INFO] [stdout] 3819 | | return (&layout[..i], stdLongMonth, &layout[i + 7..]); [INFO] [stdout] ... | [INFO] [stdout] 3824 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3816 ~ b'J' [INFO] [stdout] 3817 ~ if layout.len() >= i + 3 && &layout[i..i + 3] == "Jan" => { [INFO] [stdout] 3818 | if layout.len() >= i + 7 && &layout[i..i + 7] == "January" { [INFO] [stdout] ... [INFO] [stdout] 3823 | } [INFO] [stdout] 3824 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3827:17 [INFO] [stdout] | [INFO] [stdout] 3827 | / if layout.len() >= i + 3 { [INFO] [stdout] 3828 | | if &layout[i..i + 3] == "Mon" { [INFO] [stdout] 3829 | | if layout.len() >= i + 6 && &layout[i..i + 6] == "Monday" { [INFO] [stdout] 3830 | | return (&layout[..i], stdLongWeekDay, &layout[i + 6..]); [INFO] [stdout] ... | [INFO] [stdout] 3839 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3826 ~ b'M' [INFO] [stdout] 3827 ~ if layout.len() >= i + 3 => { [INFO] [stdout] 3828 | if &layout[i..i + 3] == "Mon" { [INFO] [stdout] ... [INFO] [stdout] 3838 | } [INFO] [stdout] 3839 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3842:17 [INFO] [stdout] | [INFO] [stdout] 3842 | / if layout.len() >= i + 2 { [INFO] [stdout] 3843 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3844 | | if *next_byte >= b'1' && *next_byte <= b'6' { [INFO] [stdout] 3845 | | let idx = (*next_byte - b'1') as usize; [INFO] [stdout] ... | [INFO] [stdout] 3856 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3841 ~ b'0' [INFO] [stdout] 3842 ~ if layout.len() >= i + 2 => { [INFO] [stdout] 3843 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3855 | } [INFO] [stdout] 3856 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3875:17 [INFO] [stdout] | [INFO] [stdout] 3875 | / if layout.len() >= i + 2 { [INFO] [stdout] 3876 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3877 | | if *next_byte == b'2' { [INFO] [stdout] 3878 | | if layout.len() >= i + 5 && &layout[i + 1..i + 5] == "2006" { [INFO] [stdout] ... | [INFO] [stdout] 3891 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3874 ~ b'_' [INFO] [stdout] 3875 ~ if layout.len() >= i + 2 => { [INFO] [stdout] 3876 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3890 | } [INFO] [stdout] 3891 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3903:17 [INFO] [stdout] | [INFO] [stdout] 3903 | / if layout.len() >= i + 2 { [INFO] [stdout] 3904 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3905 | | if *next_byte == b'M' { [INFO] [stdout] 3906 | | return (&layout[..i], stdPM, &layout[i + 2..]); [INFO] [stdout] ... | [INFO] [stdout] 3909 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3902 ~ b'P' [INFO] [stdout] 3903 ~ if layout.len() >= i + 2 => { [INFO] [stdout] 3904 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3908 | } [INFO] [stdout] 3909 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3912:17 [INFO] [stdout] | [INFO] [stdout] 3912 | / if layout.len() >= i + 2 { [INFO] [stdout] 3913 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3914 | | if *next_byte == b'm' { [INFO] [stdout] 3915 | | return (&layout[..i], stdpm, &layout[i + 2..]); [INFO] [stdout] ... | [INFO] [stdout] 3918 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3911 ~ b'p' [INFO] [stdout] 3912 ~ if layout.len() >= i + 2 => { [INFO] [stdout] 3913 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3917 | } [INFO] [stdout] 3918 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3955:17 [INFO] [stdout] | [INFO] [stdout] 3955 | / if i + 1 < layout.len() { [INFO] [stdout] 3956 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3957 | | if *next_byte == b'0' || *next_byte == b'9' { [INFO] [stdout] 3958 | | let ch = *next_byte; [INFO] [stdout] ... | [INFO] [stdout] 3973 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3954 ~ b'.' | b',' [INFO] [stdout] 3955 ~ if i + 1 < layout.len() => { [INFO] [stdout] 3956 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3972 | } [INFO] [stdout] 3973 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:3789:8 [INFO] [stdout] | [INFO] [stdout] 3789 | if 0 == s.len() { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth().unwrap()` on a `str` [INFO] [stdout] --> src/lib.rs:3792:13 [INFO] [stdout] | [INFO] [stdout] 3792 | let c = s.bytes().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes()[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:3793:5 [INFO] [stdout] | [INFO] [stdout] 3793 | b'a' <= c && c <= b'z' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'a'..=b'z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:3801:5 [INFO] [stdout] | [INFO] [stdout] 3801 | return b'0' <= c && c <= b'9'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 3801 - return b'0' <= c && c <= b'9'; [INFO] [stdout] 3801 + b'0' <= c && c <= b'9' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:3801:12 [INFO] [stdout] | [INFO] [stdout] 3801 | return b'0' <= c && c <= b'9'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3817:17 [INFO] [stdout] | [INFO] [stdout] 3817 | / if layout.len() >= i + 3 && &layout[i..i + 3] == "Jan" { [INFO] [stdout] 3818 | | if layout.len() >= i + 7 && &layout[i..i + 7] == "January" { [INFO] [stdout] 3819 | | return (&layout[..i], stdLongMonth, &layout[i + 7..]); [INFO] [stdout] ... | [INFO] [stdout] 3824 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3816 ~ b'J' [INFO] [stdout] 3817 ~ if layout.len() >= i + 3 && &layout[i..i + 3] == "Jan" => { [INFO] [stdout] 3818 | if layout.len() >= i + 7 && &layout[i..i + 7] == "January" { [INFO] [stdout] ... [INFO] [stdout] 3823 | } [INFO] [stdout] 3824 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3827:17 [INFO] [stdout] | [INFO] [stdout] 3827 | / if layout.len() >= i + 3 { [INFO] [stdout] 3828 | | if &layout[i..i + 3] == "Mon" { [INFO] [stdout] 3829 | | if layout.len() >= i + 6 && &layout[i..i + 6] == "Monday" { [INFO] [stdout] 3830 | | return (&layout[..i], stdLongWeekDay, &layout[i + 6..]); [INFO] [stdout] ... | [INFO] [stdout] 3839 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3826 ~ b'M' [INFO] [stdout] 3827 ~ if layout.len() >= i + 3 => { [INFO] [stdout] 3828 | if &layout[i..i + 3] == "Mon" { [INFO] [stdout] ... [INFO] [stdout] 3838 | } [INFO] [stdout] 3839 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3842:17 [INFO] [stdout] | [INFO] [stdout] 3842 | / if layout.len() >= i + 2 { [INFO] [stdout] 3843 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3844 | | if *next_byte >= b'1' && *next_byte <= b'6' { [INFO] [stdout] 3845 | | let idx = (*next_byte - b'1') as usize; [INFO] [stdout] ... | [INFO] [stdout] 3856 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3841 ~ b'0' [INFO] [stdout] 3842 ~ if layout.len() >= i + 2 => { [INFO] [stdout] 3843 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3855 | } [INFO] [stdout] 3856 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3875:17 [INFO] [stdout] | [INFO] [stdout] 3875 | / if layout.len() >= i + 2 { [INFO] [stdout] 3876 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3877 | | if *next_byte == b'2' { [INFO] [stdout] 3878 | | if layout.len() >= i + 5 && &layout[i + 1..i + 5] == "2006" { [INFO] [stdout] ... | [INFO] [stdout] 3891 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3874 ~ b'_' [INFO] [stdout] 3875 ~ if layout.len() >= i + 2 => { [INFO] [stdout] 3876 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3890 | } [INFO] [stdout] 3891 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3903:17 [INFO] [stdout] | [INFO] [stdout] 3903 | / if layout.len() >= i + 2 { [INFO] [stdout] 3904 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3905 | | if *next_byte == b'M' { [INFO] [stdout] 3906 | | return (&layout[..i], stdPM, &layout[i + 2..]); [INFO] [stdout] ... | [INFO] [stdout] 3909 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3902 ~ b'P' [INFO] [stdout] 3903 ~ if layout.len() >= i + 2 => { [INFO] [stdout] 3904 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3908 | } [INFO] [stdout] 3909 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3912:17 [INFO] [stdout] | [INFO] [stdout] 3912 | / if layout.len() >= i + 2 { [INFO] [stdout] 3913 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3914 | | if *next_byte == b'm' { [INFO] [stdout] 3915 | | return (&layout[..i], stdpm, &layout[i + 2..]); [INFO] [stdout] ... | [INFO] [stdout] 3918 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3911 ~ b'p' [INFO] [stdout] 3912 ~ if layout.len() >= i + 2 => { [INFO] [stdout] 3913 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3917 | } [INFO] [stdout] 3918 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:3955:17 [INFO] [stdout] | [INFO] [stdout] 3955 | / if i + 1 < layout.len() { [INFO] [stdout] 3956 | | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] 3957 | | if *next_byte == b'0' || *next_byte == b'9' { [INFO] [stdout] 3958 | | let ch = *next_byte; [INFO] [stdout] ... | [INFO] [stdout] 3973 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3954 ~ b'.' | b',' [INFO] [stdout] 3955 ~ if i + 1 < layout.len() => { [INFO] [stdout] 3956 | if let Some(next_byte) = layout.as_bytes().get(i + 1) { [INFO] [stdout] ... [INFO] [stdout] 3972 | } [INFO] [stdout] 3973 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4064:21 [INFO] [stdout] | [INFO] [stdout] 4064 | return z; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4064 - return z; [INFO] [stdout] 4064 + z [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4066:29 [INFO] [stdout] | [INFO] [stdout] 4066 | Err(err) => return UTC.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4066 - Err(err) => return UTC.clone(), [INFO] [stdout] 4066 + Err(err) => UTC.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4070:26 [INFO] [stdout] | [INFO] [stdout] 4070 | Ok(z) => return z, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4070 - Ok(z) => return z, [INFO] [stdout] 4070 + Ok(z) => z, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4071:29 [INFO] [stdout] | [INFO] [stdout] 4071 | Err(err) => return UTC.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4071 - Err(err) => return UTC.clone(), [INFO] [stdout] 4071 + Err(err) => UTC.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4074:13 [INFO] [stdout] | [INFO] [stdout] 4074 | return UTC.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4074 - return UTC.clone(); [INFO] [stdout] 4074 + UTC.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4080:17 [INFO] [stdout] | [INFO] [stdout] 4080 | return z; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4080 - return z; [INFO] [stdout] 4080 + z [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4082:25 [INFO] [stdout] | [INFO] [stdout] 4082 | Err(err) => return UTC.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4082 - Err(err) => return UTC.clone(), [INFO] [stdout] 4082 + Err(err) => UTC.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:4097:9 [INFO] [stdout] | [INFO] [stdout] 4097 | Err(Error::new(ErrorKind::Other, "unknown time zone")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 4097 - Err(Error::new(ErrorKind::Other, "unknown time zone")) [INFO] [stdout] 4097 + Err(Error::other("unknown time zone")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:4108:26 [INFO] [stdout] | [INFO] [stdout] 4108 | let badDataErr = Err(Error::new(ErrorKind::Other, badData)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 4108 - let badDataErr = Err(Error::new(ErrorKind::Other, badData)); [INFO] [stdout] 4108 + let badDataErr = Err(Error::other(badData)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4064:21 [INFO] [stdout] | [INFO] [stdout] 4064 | return z; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4064 - return z; [INFO] [stdout] 4064 + z [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4066:29 [INFO] [stdout] | [INFO] [stdout] 4066 | Err(err) => return UTC.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4066 - Err(err) => return UTC.clone(), [INFO] [stdout] 4066 + Err(err) => UTC.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `n` [INFO] [stdout] --> src/lib.rs:4151:14 [INFO] [stdout] | [INFO] [stdout] 4151 | for i in 0..6 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 4151 - for i in 0..6 { [INFO] [stdout] 4151 + for in &mut n { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4070:26 [INFO] [stdout] | [INFO] [stdout] 4070 | Ok(z) => return z, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4070 - Ok(z) => return z, [INFO] [stdout] 4070 + Ok(z) => z, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4071:29 [INFO] [stdout] | [INFO] [stdout] 4071 | Err(err) => return UTC.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4071 - Err(err) => return UTC.clone(), [INFO] [stdout] 4071 + Err(err) => UTC.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4074:13 [INFO] [stdout] | [INFO] [stdout] 4074 | return UTC.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4074 - return UTC.clone(); [INFO] [stdout] 4074 + UTC.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4080:17 [INFO] [stdout] | [INFO] [stdout] 4080 | return z; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4080 - return z; [INFO] [stdout] 4080 + z [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4082:25 [INFO] [stdout] | [INFO] [stdout] 4082 | Err(err) => return UTC.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4082 - Err(err) => return UTC.clone(), [INFO] [stdout] 4082 + Err(err) => UTC.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `n` [INFO] [stdout] --> src/lib.rs:4183:18 [INFO] [stdout] | [INFO] [stdout] 4183 | for i in 0..6 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 4183 - for i in 0..6 { [INFO] [stdout] 4183 + for in &mut n { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `zones` [INFO] [stdout] --> src/lib.rs:4252:14 [INFO] [stdout] | [INFO] [stdout] 4252 | for i in 0..len!(zones) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 4252 - for i in 0..len!(zones) { [INFO] [stdout] 4252 + for in &mut zones { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:4097:9 [INFO] [stdout] | [INFO] [stdout] 4097 | Err(Error::new(ErrorKind::Other, "unknown time zone")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 4097 - Err(Error::new(ErrorKind::Other, "unknown time zone")) [INFO] [stdout] 4097 + Err(Error::other("unknown time zone")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:4108:26 [INFO] [stdout] | [INFO] [stdout] 4108 | let badDataErr = Err(Error::new(ErrorKind::Other, badData)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 4108 - let badDataErr = Err(Error::new(ErrorKind::Other, badData)); [INFO] [stdout] 4108 + let badDataErr = Err(Error::other(badData)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `n` [INFO] [stdout] --> src/lib.rs:4151:14 [INFO] [stdout] | [INFO] [stdout] 4151 | for i in 0..6 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 4151 - for i in 0..6 { [INFO] [stdout] 4151 + for in &mut n { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `n` [INFO] [stdout] --> src/lib.rs:4183:18 [INFO] [stdout] | [INFO] [stdout] 4183 | for i in 0..6 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 4183 - for i in 0..6 { [INFO] [stdout] 4183 + for in &mut n { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:4361:23 [INFO] [stdout] | [INFO] [stdout] 4361 | } else if l.extend != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.extend.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4454:9 [INFO] [stdout] | [INFO] [stdout] 4454 | return Ok(z); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4454 - return Ok(z); [INFO] [stdout] 4454 + Ok(z) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `zones` [INFO] [stdout] --> src/lib.rs:4252:14 [INFO] [stdout] | [INFO] [stdout] 4252 | for i in 0..len!(zones) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 4252 - for i in 0..len!(zones) { [INFO] [stdout] 4252 + for in &mut zones { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:4431:8 [INFO] [stdout] | [INFO] [stdout] 4431 | if name == "" || name == "UTC" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4438:12 [INFO] [stdout] | [INFO] [stdout] 4438 | || name.bytes().nth(0) == Some(b'/') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `name.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4439:12 [INFO] [stdout] | [INFO] [stdout] 4439 | || name.bytes().nth(0) == Some(b'\\') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `name.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:4443:20 [INFO] [stdout] | [INFO] [stdout] 4443 | return Err(Error::new(ErrorKind::Other, errLocation)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 4443 - return Err(Error::new(ErrorKind::Other, errLocation)); [INFO] [stdout] 4443 + return Err(Error::other(errLocation)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:4451:8 [INFO] [stdout] | [INFO] [stdout] 4451 | if zoneinfo != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!zoneinfo.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4476:5 [INFO] [stdout] | [INFO] [stdout] 4476 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4476 - return false; [INFO] [stdout] 4476 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4472:12 [INFO] [stdout] | [INFO] [stdout] 4472 | if s.bytes().nth(i) == Some(b'.') && s.bytes().nth(i + 1) == Some(b'.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(i).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4472:46 [INFO] [stdout] | [INFO] [stdout] 4472 | if s.bytes().nth(i) == Some(b'.') && s.bytes().nth(i + 1) == Some(b'.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(i + 1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:4361:23 [INFO] [stdout] | [INFO] [stdout] 4361 | } else if l.extend != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.extend.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4601:9 [INFO] [stdout] | [INFO] [stdout] 4601 | / return ( [INFO] [stdout] 4602 | | stdName.to_string(), [INFO] [stdout] 4603 | | stdOffset, [INFO] [stdout] 4604 | | abs, [INFO] [stdout] ... | [INFO] [stdout] 4607 | | true, [INFO] [stdout] 4608 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4601 ~ ( [INFO] [stdout] 4602 + stdName.to_string(), [INFO] [stdout] 4603 + stdOffset, [INFO] [stdout] 4604 + abs, [INFO] [stdout] 4605 + startSec + abs, [INFO] [stdout] 4606 + stdIsDST, [INFO] [stdout] 4607 + true, [INFO] [stdout] 4608 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4610:9 [INFO] [stdout] | [INFO] [stdout] 4610 | / return ( [INFO] [stdout] 4611 | | stdName.to_string(), [INFO] [stdout] 4612 | | stdOffset, [INFO] [stdout] 4613 | | endSec + abs, [INFO] [stdout] ... | [INFO] [stdout] 4616 | | true, [INFO] [stdout] 4617 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4610 ~ ( [INFO] [stdout] 4611 + stdName.to_string(), [INFO] [stdout] 4612 + stdOffset, [INFO] [stdout] 4613 + endSec + abs, [INFO] [stdout] 4614 + abs + 365 * secondsPerDay, [INFO] [stdout] 4615 + stdIsDST, [INFO] [stdout] 4616 + true, [INFO] [stdout] 4617 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4619:9 [INFO] [stdout] | [INFO] [stdout] 4619 | / return ( [INFO] [stdout] 4620 | | dstName.to_string(), [INFO] [stdout] 4621 | | dstOffset, [INFO] [stdout] 4622 | | startSec + abs, [INFO] [stdout] ... | [INFO] [stdout] 4625 | | true, [INFO] [stdout] 4626 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4619 ~ ( [INFO] [stdout] 4620 + dstName.to_string(), [INFO] [stdout] 4621 + dstOffset, [INFO] [stdout] 4622 + startSec + abs, [INFO] [stdout] 4623 + endSec + abs, [INFO] [stdout] 4624 + dstIsDST, [INFO] [stdout] 4625 + true, [INFO] [stdout] 4626 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4454:9 [INFO] [stdout] | [INFO] [stdout] 4454 | return Ok(z); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4454 - return Ok(z); [INFO] [stdout] 4454 + Ok(z) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:4431:8 [INFO] [stdout] | [INFO] [stdout] 4431 | if name == "" || name == "UTC" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4438:12 [INFO] [stdout] | [INFO] [stdout] 4438 | || name.bytes().nth(0) == Some(b'/') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `name.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4439:12 [INFO] [stdout] | [INFO] [stdout] 4439 | || name.bytes().nth(0) == Some(b'\\') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `name.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:4443:20 [INFO] [stdout] | [INFO] [stdout] 4443 | return Err(Error::new(ErrorKind::Other, errLocation)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 4443 - return Err(Error::new(ErrorKind::Other, errLocation)); [INFO] [stdout] 4443 + return Err(Error::other(errLocation)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:4451:8 [INFO] [stdout] | [INFO] [stdout] 4451 | if zoneinfo != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!zoneinfo.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4476:5 [INFO] [stdout] | [INFO] [stdout] 4476 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4476 - return false; [INFO] [stdout] 4476 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4472:12 [INFO] [stdout] | [INFO] [stdout] 4472 | if s.bytes().nth(i) == Some(b'.') && s.bytes().nth(i + 1) == Some(b'.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(i).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4472:46 [INFO] [stdout] | [INFO] [stdout] 4472 | if s.bytes().nth(i) == Some(b'.') && s.bytes().nth(i + 1) == Some(b'.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(i + 1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4650:9 [INFO] [stdout] | [INFO] [stdout] 4650 | return (s, "", true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4650 - return (s, "", true); [INFO] [stdout] 4650 + (s, "", true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4601:9 [INFO] [stdout] | [INFO] [stdout] 4601 | / return ( [INFO] [stdout] 4602 | | stdName.to_string(), [INFO] [stdout] 4603 | | stdOffset, [INFO] [stdout] 4604 | | abs, [INFO] [stdout] ... | [INFO] [stdout] 4607 | | true, [INFO] [stdout] 4608 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4601 ~ ( [INFO] [stdout] 4602 + stdName.to_string(), [INFO] [stdout] 4603 + stdOffset, [INFO] [stdout] 4604 + abs, [INFO] [stdout] 4605 + startSec + abs, [INFO] [stdout] 4606 + stdIsDST, [INFO] [stdout] 4607 + true, [INFO] [stdout] 4608 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4610:9 [INFO] [stdout] | [INFO] [stdout] 4610 | / return ( [INFO] [stdout] 4611 | | stdName.to_string(), [INFO] [stdout] 4612 | | stdOffset, [INFO] [stdout] 4613 | | endSec + abs, [INFO] [stdout] ... | [INFO] [stdout] 4616 | | true, [INFO] [stdout] 4617 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4610 ~ ( [INFO] [stdout] 4611 + stdName.to_string(), [INFO] [stdout] 4612 + stdOffset, [INFO] [stdout] 4613 + endSec + abs, [INFO] [stdout] 4614 + abs + 365 * secondsPerDay, [INFO] [stdout] 4615 + stdIsDST, [INFO] [stdout] 4616 + true, [INFO] [stdout] 4617 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4619:9 [INFO] [stdout] | [INFO] [stdout] 4619 | / return ( [INFO] [stdout] 4620 | | dstName.to_string(), [INFO] [stdout] 4621 | | dstOffset, [INFO] [stdout] 4622 | | startSec + abs, [INFO] [stdout] ... | [INFO] [stdout] 4625 | | true, [INFO] [stdout] 4626 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4619 ~ ( [INFO] [stdout] 4620 + dstName.to_string(), [INFO] [stdout] 4621 + dstOffset, [INFO] [stdout] 4622 + startSec + abs, [INFO] [stdout] 4623 + endSec + abs, [INFO] [stdout] 4624 + dstIsDST, [INFO] [stdout] 4625 + true, [INFO] [stdout] 4626 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4708:5 [INFO] [stdout] | [INFO] [stdout] 4708 | return (off, s, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4708 - return (off, s, true); [INFO] [stdout] 4708 + (off, s, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4666:8 [INFO] [stdout] | [INFO] [stdout] 4666 | if s.bytes().nth(0) == Some(b'+') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4668:15 [INFO] [stdout] | [INFO] [stdout] 4668 | } else if s.bytes().nth(0) == Some(b'-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4680:24 [INFO] [stdout] | [INFO] [stdout] 4680 | if len!(s) == 0 || s.bytes().nth(0) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4692:24 [INFO] [stdout] | [INFO] [stdout] 4692 | if len!(s) == 0 || s.bytes().nth(0) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:4717:12 [INFO] [stdout] | [INFO] [stdout] 4717 | if r < b'0' || r > b'9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(b'0'..=b'9').contains(&r)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4650:9 [INFO] [stdout] | [INFO] [stdout] 4650 | return (s, "", true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4650 - return (s, "", true); [INFO] [stdout] 4650 + (s, "", true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4708:5 [INFO] [stdout] | [INFO] [stdout] 4708 | return (off, s, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4708 - return (off, s, true); [INFO] [stdout] 4708 + (off, s, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4666:8 [INFO] [stdout] | [INFO] [stdout] 4666 | if s.bytes().nth(0) == Some(b'+') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4762:8 [INFO] [stdout] | [INFO] [stdout] 4762 | if s.bytes().nth(0) == Some(b'J') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4668:15 [INFO] [stdout] | [INFO] [stdout] 4668 | } else if s.bytes().nth(0) == Some(b'-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4763:9 [INFO] [stdout] | [INFO] [stdout] 4763 | let jday: int; [INFO] [stdout] | ^^^^^^^^^^^^^^ created here [INFO] [stdout] 4764 | let tuple = tzsetNum(&s[1..], 1, 365); [INFO] [stdout] 4765 | jday = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `jday` here [INFO] [stdout] | [INFO] [stdout] 4763 ~ [INFO] [stdout] 4764 | let tuple = tzsetNum(&s[1..], 1, 365); [INFO] [stdout] 4765 ~ let jday: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4680:24 [INFO] [stdout] | [INFO] [stdout] 4680 | if len!(s) == 0 || s.bytes().nth(0) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4774:15 [INFO] [stdout] | [INFO] [stdout] 4774 | } else if s.bytes().nth(0) == Some(b'M') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4692:24 [INFO] [stdout] | [INFO] [stdout] 4692 | if len!(s) == 0 || s.bytes().nth(0) != Some(b':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4775:9 [INFO] [stdout] | [INFO] [stdout] 4775 | let mon: int; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] 4776 | let tuple = tzsetNum(&s[1..], 1, 12); [INFO] [stdout] 4777 | mon = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `mon` here [INFO] [stdout] | [INFO] [stdout] 4775 ~ [INFO] [stdout] 4776 | let tuple = tzsetNum(&s[1..], 1, 12); [INFO] [stdout] 4777 ~ let mon: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4780:35 [INFO] [stdout] | [INFO] [stdout] 4780 | if !ok || len!(s) == 0 || s.bytes().nth(0) != Some(b'.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4783:9 [INFO] [stdout] | [INFO] [stdout] 4783 | let week: int; [INFO] [stdout] | ^^^^^^^^^^^^^^ created here [INFO] [stdout] 4784 | let tuple = tzsetNum(&s[1..], 1, 5); [INFO] [stdout] 4785 | week = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `week` here [INFO] [stdout] | [INFO] [stdout] 4783 ~ [INFO] [stdout] 4784 | let tuple = tzsetNum(&s[1..], 1, 5); [INFO] [stdout] 4785 ~ let week: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:4717:12 [INFO] [stdout] | [INFO] [stdout] 4717 | if r < b'0' || r > b'9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(b'0'..=b'9').contains(&r)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4788:35 [INFO] [stdout] | [INFO] [stdout] 4788 | if !ok || len!(s) == 0 || s.bytes().nth(0) != Some(b'.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4791:9 [INFO] [stdout] | [INFO] [stdout] 4791 | let day: int; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] 4792 | let tuple = tzsetNum(&s[1..], 0, 6); [INFO] [stdout] 4793 | day = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `day` here [INFO] [stdout] | [INFO] [stdout] 4791 ~ [INFO] [stdout] 4792 | let tuple = tzsetNum(&s[1..], 0, 6); [INFO] [stdout] 4793 ~ let day: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4804:9 [INFO] [stdout] | [INFO] [stdout] 4804 | let day: int; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] 4805 | let tuple = tzsetNum(s, 0, 365); [INFO] [stdout] 4806 | day = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `day` here [INFO] [stdout] | [INFO] [stdout] 4804 ~ [INFO] [stdout] 4805 | let tuple = tzsetNum(s, 0, 365); [INFO] [stdout] 4806 ~ let day: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4816:24 [INFO] [stdout] | [INFO] [stdout] 4816 | if len!(s) == 0 || s.bytes().nth(0) != Some(b'/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4762:8 [INFO] [stdout] | [INFO] [stdout] 4762 | if s.bytes().nth(0) == Some(b'J') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4763:9 [INFO] [stdout] | [INFO] [stdout] 4763 | let jday: int; [INFO] [stdout] | ^^^^^^^^^^^^^^ created here [INFO] [stdout] 4764 | let tuple = tzsetNum(&s[1..], 1, 365); [INFO] [stdout] 4765 | jday = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `jday` here [INFO] [stdout] | [INFO] [stdout] 4763 ~ [INFO] [stdout] 4764 | let tuple = tzsetNum(&s[1..], 1, 365); [INFO] [stdout] 4765 ~ let jday: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4774:15 [INFO] [stdout] | [INFO] [stdout] 4774 | } else if s.bytes().nth(0) == Some(b'M') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4775:9 [INFO] [stdout] | [INFO] [stdout] 4775 | let mon: int; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] 4776 | let tuple = tzsetNum(&s[1..], 1, 12); [INFO] [stdout] 4777 | mon = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `mon` here [INFO] [stdout] | [INFO] [stdout] 4775 ~ [INFO] [stdout] 4776 | let tuple = tzsetNum(&s[1..], 1, 12); [INFO] [stdout] 4777 ~ let mon: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:4891:8 [INFO] [stdout] | [INFO] [stdout] 4891 | if dir != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dir.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4780:35 [INFO] [stdout] | [INFO] [stdout] 4780 | if !ok || len!(s) == 0 || s.bytes().nth(0) != Some(b'.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:4893:9 [INFO] [stdout] | [INFO] [stdout] 4893 | temp.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `temp.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4783:9 [INFO] [stdout] | [INFO] [stdout] 4783 | let week: int; [INFO] [stdout] | ^^^^^^^^^^^^^^ created here [INFO] [stdout] 4784 | let tuple = tzsetNum(&s[1..], 1, 5); [INFO] [stdout] 4785 | week = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `week` here [INFO] [stdout] | [INFO] [stdout] 4783 ~ [INFO] [stdout] 4784 | let tuple = tzsetNum(&s[1..], 1, 5); [INFO] [stdout] 4785 ~ let week: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4913:5 [INFO] [stdout] | [INFO] [stdout] 4913 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4913 - return -1; [INFO] [stdout] 4913 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4788:35 [INFO] [stdout] | [INFO] [stdout] 4788 | if !ok || len!(s) == 0 || s.bytes().nth(0) != Some(b'.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4791:9 [INFO] [stdout] | [INFO] [stdout] 4791 | let day: int; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] 4792 | let tuple = tzsetNum(&s[1..], 0, 6); [INFO] [stdout] 4793 | day = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `day` here [INFO] [stdout] | [INFO] [stdout] 4791 ~ [INFO] [stdout] 4792 | let tuple = tzsetNum(&s[1..], 0, 6); [INFO] [stdout] 4793 ~ let day: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4937:13 [INFO] [stdout] | [INFO] [stdout] 4937 | return Some(p); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4937 - return Some(p); [INFO] [stdout] 4937 + Some(p) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4941:13 [INFO] [stdout] | [INFO] [stdout] 4941 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4941 - return None; [INFO] [stdout] 4941 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:4804:9 [INFO] [stdout] | [INFO] [stdout] 4804 | let day: int; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] 4805 | let tuple = tzsetNum(s, 0, 365); [INFO] [stdout] 4806 | day = tuple.0; [INFO] [stdout] | ^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `day` here [INFO] [stdout] | [INFO] [stdout] 4804 ~ [INFO] [stdout] 4805 | let tuple = tzsetNum(s, 0, 365); [INFO] [stdout] 4806 ~ let day: int = tuple.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `str` [INFO] [stdout] --> src/lib.rs:4816:24 [INFO] [stdout] | [INFO] [stdout] 4816 | if len!(s) == 0 || s.bytes().nth(0) != Some(b'/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4947:13 [INFO] [stdout] | [INFO] [stdout] 4947 | / return ( [INFO] [stdout] 4948 | | uint32!(p[3]) | uint32!(p[2]) << 8 | uint32!(p[1]) << 16 | uint32!(p[0]) << 24, [INFO] [stdout] 4949 | | true, [INFO] [stdout] 4950 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4947 ~ ( [INFO] [stdout] 4948 + uint32!(p[3]) | uint32!(p[2]) << 8 | uint32!(p[1]) << 16 | uint32!(p[0]) << 24, [INFO] [stdout] 4949 + true, [INFO] [stdout] 4950 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4969:13 [INFO] [stdout] | [INFO] [stdout] 4969 | return (p[0], true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4969 - return (p[0], true); [INFO] [stdout] 4969 + (p[0], true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4979:13 [INFO] [stdout] | [INFO] [stdout] 4979 | return Some(r); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4979 - return Some(r); [INFO] [stdout] 4979 + Some(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4992:5 [INFO] [stdout] | [INFO] [stdout] 4992 | return String::from_utf8(p).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4992 - return String::from_utf8(p).unwrap(); [INFO] [stdout] 4992 + String::from_utf8(p).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:4891:8 [INFO] [stdout] | [INFO] [stdout] 4891 | if dir != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dir.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:4893:9 [INFO] [stdout] | [INFO] [stdout] 4893 | temp.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `temp.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4913:5 [INFO] [stdout] | [INFO] [stdout] 4913 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4913 - return -1; [INFO] [stdout] 4913 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4937:13 [INFO] [stdout] | [INFO] [stdout] 4937 | return Some(p); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4937 - return Some(p); [INFO] [stdout] 4937 + Some(p) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4941:13 [INFO] [stdout] | [INFO] [stdout] 4941 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4941 - return None; [INFO] [stdout] 4941 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4947:13 [INFO] [stdout] | [INFO] [stdout] 4947 | / return ( [INFO] [stdout] 4948 | | uint32!(p[3]) | uint32!(p[2]) << 8 | uint32!(p[1]) << 16 | uint32!(p[0]) << 24, [INFO] [stdout] 4949 | | true, [INFO] [stdout] 4950 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4947 ~ ( [INFO] [stdout] 4948 + uint32!(p[3]) | uint32!(p[2]) << 8 | uint32!(p[1]) << 16 | uint32!(p[0]) << 24, [INFO] [stdout] 4949 + true, [INFO] [stdout] 4950 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4969:13 [INFO] [stdout] | [INFO] [stdout] 4969 | return (p[0], true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4969 - return (p[0], true); [INFO] [stdout] 4969 + (p[0], true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4979:13 [INFO] [stdout] | [INFO] [stdout] 4979 | return Some(r); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4979 - return Some(r); [INFO] [stdout] 4979 + Some(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:4992:5 [INFO] [stdout] | [INFO] [stdout] 4992 | return String::from_utf8(p).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4992 - return String::from_utf8(p).unwrap(); [INFO] [stdout] 4992 + String::from_utf8(p).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.95s [INFO] running `Command { std: "docker" "inspect" "cc16e0622a3704e2ca0144c7185bce148004089f496df8bb7b94a5304a9c8b96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc16e0622a3704e2ca0144c7185bce148004089f496df8bb7b94a5304a9c8b96", kill_on_drop: false }` [INFO] [stdout] cc16e0622a3704e2ca0144c7185bce148004089f496df8bb7b94a5304a9c8b96