[INFO] fetching crate gosh-linesearch 0.1.0... [INFO] linting gosh-linesearch-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gosh-linesearch 0.1.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate gosh-linesearch 0.1.0 [INFO] finished tweaking crates.io crate gosh-linesearch 0.1.0 [INFO] tweaked toml for crates.io crate gosh-linesearch 0.1.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gosh-linesearch 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 103 packages to latest compatible versions [INFO] [stderr] Adding gchemol-gut v0.3.1 (available: v0.4.4) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03d7ca8ad781141190b0a5d7c3b86781ce58aa4f54d62c0d89f57683e9960d8e [INFO] running `Command { std: "docker" "start" "-a" "03d7ca8ad781141190b0a5d7c3b86781ce58aa4f54d62c0d89f57683e9960d8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03d7ca8ad781141190b0a5d7c3b86781ce58aa4f54d62c0d89f57683e9960d8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03d7ca8ad781141190b0a5d7c3b86781ce58aa4f54d62c0d89f57683e9960d8e", kill_on_drop: false }` [INFO] [stdout] 03d7ca8ad781141190b0a5d7c3b86781ce58aa4f54d62c0d89f57683e9960d8e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71a52a058c6fe1fed674ee3327d7b0e09122953313db53812af0cc457c20206f [INFO] running `Command { std: "docker" "start" "-a" "71a52a058c6fe1fed674ee3327d7b0e09122953313db53812af0cc457c20206f", kill_on_drop: false }` [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking os_pipe v1.2.3 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking sigchld v0.2.4 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking shared_child v1.1.1 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking gchemol-gut v0.3.1 [INFO] [stderr] Checking gosh-linesearch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:414:21 [INFO] [stdout] | [INFO] [stdout] 414 | let mut ls = LineSearchIter { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:453:9 [INFO] [stdout] | [INFO] [stdout] 453 | let mut step = 1.0; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/lib.rs:457:21 [INFO] [stdout] | [INFO] [stdout] 457 | .find_iter(|a: f64, out: &mut Output| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `step` [INFO] [stdout] --> src/lib.rs:453:9 [INFO] [stdout] | [INFO] [stdout] 453 | let mut step = 1.0; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_step` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `LineSearchFind` is never used [INFO] [stdout] --> src/lib.rs:150:18 [INFO] [stdout] | [INFO] [stdout] 150 | pub(crate) trait LineSearchFind [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/backtracking.rs:136:19 [INFO] [stdout] | [INFO] [stdout] 136 | find_next(&self, stp, phi) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/morethuente.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | if brackt && (*stp <= stmin || stmax <= *stp || max_iterations <= count + 1) [INFO] [stdout] | ________________^ [INFO] [stdout] 130 | | || brackt && stmax - stmin <= vars.xtol * stmax [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 129 - if brackt && (*stp <= stmin || stmax <= *stp || max_iterations <= count + 1) [INFO] [stdout] 130 - || brackt && stmax - stmin <= vars.xtol * stmax [INFO] [stdout] 129 + if !(!brackt || *stp > stmin && stmax > *stp && max_iterations > count + 1 && stmax - stmin > vars.xtol * stmax) [INFO] [stdout] | [INFO] [stdout] 129 - if brackt && (*stp <= stmin || stmax <= *stp || max_iterations <= count + 1) [INFO] [stdout] 130 - || brackt && stmax - stmin <= vars.xtol * stmax [INFO] [stdout] 129 + if (stmax - stmin <= vars.xtol * stmax || max_iterations <= count + 1 || stmax <= *stp || *stp <= stmin) && brackt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | /// derivative at the best step obtained so far. The derivative must be [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 269 | /// derivative at the best step obtained so far. The derivative must be [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:270:9 [INFO] [stdout] | [INFO] [stdout] 270 | /// negative in the direction of the step, that is, dx and t-x must have [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 270 | /// negative in the direction of the step, that is, dx and t-x must have [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | /// opposite signs. On output these parameters are updated appropriately. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 271 | /// opposite signs. On output these parameters are updated appropriately. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | /// the derivative at the other endpoint of the interval of uncertainty. On [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 274 | /// the derivative at the other endpoint of the interval of uncertainty. On [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | /// output these parameters are updated appropriately. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 275 | /// output these parameters are updated appropriately. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | /// derivative at the current step. If bracket is set true then on input t [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 278 | /// derivative at the current step. If bracket is set true then on input t [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | /// must be between x and y. On output t is set to the new step. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 279 | /// must be between x and y. On output t is set to the new step. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:284:9 [INFO] [stdout] | [INFO] [stdout] 284 | /// minimizer has not been bracketed then on input brackt must be set false. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 284 | /// minimizer has not been bracketed then on input brackt must be set false. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 285 | /// If the minimizer is bracketed then on output `brackt` is set true. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 285 | /// If the minimizer is bracketed then on output `brackt` is set true. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/morethuente.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | / pub(crate) fn update_trial_interval( [INFO] [stdout] 288 | | x: &mut f64, [INFO] [stdout] 289 | | fx: &mut f64, [INFO] [stdout] 290 | | dx: &mut f64, [INFO] [stdout] ... | [INFO] [stdout] 299 | | brackt: &mut bool, [INFO] [stdout] 300 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/morethuente.rs:495:1 [INFO] [stdout] | [INFO] [stdout] 495 | fn cubic_minimizer2(cm: &mut f64, u: f64, fu: f64, du: f64, v: f64, fv: f64, dv: f64, xmin: f64, xmax: f64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/morethuente.rs:561:27 [INFO] [stdout] | [INFO] [stdout] 561 | mcsrch::find_next(&self, stp, phi) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing a legacy numeric constant [INFO] [stdout] --> src/lib.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | use std::f64::NAN; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import and use the associated constant `f64::NAN` from the primitive type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/lib.rs:289:20 [INFO] [stdout] | [INFO] [stdout] 289 | Self { fx: NAN, gx: NAN } [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 289 | Self { fx: f64::NAN, gx: NAN } [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/lib.rs:289:29 [INFO] [stdout] | [INFO] [stdout] 289 | Self { fx: NAN, gx: NAN } [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 289 | Self { fx: NAN, gx: f64::NAN } [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:414:21 [INFO] [stdout] | [INFO] [stdout] 414 | let mut ls = LineSearchIter { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `LineSearchFind` is never used [INFO] [stdout] --> src/lib.rs:150:18 [INFO] [stdout] | [INFO] [stdout] 150 | pub(crate) trait LineSearchFind [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/backtracking.rs:136:19 [INFO] [stdout] | [INFO] [stdout] 136 | find_next(&self, stp, phi) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/morethuente.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | if brackt && (*stp <= stmin || stmax <= *stp || max_iterations <= count + 1) [INFO] [stdout] | ________________^ [INFO] [stdout] 130 | | || brackt && stmax - stmin <= vars.xtol * stmax [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 129 - if brackt && (*stp <= stmin || stmax <= *stp || max_iterations <= count + 1) [INFO] [stdout] 130 - || brackt && stmax - stmin <= vars.xtol * stmax [INFO] [stdout] 129 + if !(!brackt || *stp > stmin && stmax > *stp && max_iterations > count + 1 && stmax - stmin > vars.xtol * stmax) [INFO] [stdout] | [INFO] [stdout] 129 - if brackt && (*stp <= stmin || stmax <= *stp || max_iterations <= count + 1) [INFO] [stdout] 130 - || brackt && stmax - stmin <= vars.xtol * stmax [INFO] [stdout] 129 + if (stmax - stmin <= vars.xtol * stmax || max_iterations <= count + 1 || stmax <= *stp || *stp <= stmin) && brackt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | /// derivative at the best step obtained so far. The derivative must be [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 269 | /// derivative at the best step obtained so far. The derivative must be [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:270:9 [INFO] [stdout] | [INFO] [stdout] 270 | /// negative in the direction of the step, that is, dx and t-x must have [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 270 | /// negative in the direction of the step, that is, dx and t-x must have [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | /// opposite signs. On output these parameters are updated appropriately. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 271 | /// opposite signs. On output these parameters are updated appropriately. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | /// the derivative at the other endpoint of the interval of uncertainty. On [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 274 | /// the derivative at the other endpoint of the interval of uncertainty. On [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | /// output these parameters are updated appropriately. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 275 | /// output these parameters are updated appropriately. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | /// derivative at the current step. If bracket is set true then on input t [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 278 | /// derivative at the current step. If bracket is set true then on input t [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | /// must be between x and y. On output t is set to the new step. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 279 | /// must be between x and y. On output t is set to the new step. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:284:9 [INFO] [stdout] | [INFO] [stdout] 284 | /// minimizer has not been bracketed then on input brackt must be set false. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 284 | /// minimizer has not been bracketed then on input brackt must be set false. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/morethuente.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 285 | /// If the minimizer is bracketed then on output `brackt` is set true. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 285 | /// If the minimizer is bracketed then on output `brackt` is set true. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/morethuente.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | / pub(crate) fn update_trial_interval( [INFO] [stdout] 288 | | x: &mut f64, [INFO] [stdout] 289 | | fx: &mut f64, [INFO] [stdout] 290 | | dx: &mut f64, [INFO] [stdout] ... | [INFO] [stdout] 299 | | brackt: &mut bool, [INFO] [stdout] 300 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/morethuente.rs:495:1 [INFO] [stdout] | [INFO] [stdout] 495 | fn cubic_minimizer2(cm: &mut f64, u: f64, fu: f64, du: f64, v: f64, fv: f64, dv: f64, xmin: f64, xmax: f64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/morethuente.rs:561:27 [INFO] [stdout] | [INFO] [stdout] 561 | mcsrch::find_next(&self, stp, phi) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing a legacy numeric constant [INFO] [stdout] --> src/lib.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | use std::f64::NAN; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import and use the associated constant `f64::NAN` from the primitive type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/lib.rs:289:20 [INFO] [stdout] | [INFO] [stdout] 289 | Self { fx: NAN, gx: NAN } [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 289 | Self { fx: f64::NAN, gx: NAN } [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/lib.rs:289:29 [INFO] [stdout] | [INFO] [stdout] 289 | Self { fx: NAN, gx: NAN } [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 289 | Self { fx: NAN, gx: f64::NAN } [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.14s [INFO] running `Command { std: "docker" "inspect" "71a52a058c6fe1fed674ee3327d7b0e09122953313db53812af0cc457c20206f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71a52a058c6fe1fed674ee3327d7b0e09122953313db53812af0cc457c20206f", kill_on_drop: false }` [INFO] [stdout] 71a52a058c6fe1fed674ee3327d7b0e09122953313db53812af0cc457c20206f