[INFO] fetching crate google-scholar-query 0.1.6... [INFO] linting google-scholar-query-0.1.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate google-scholar-query 0.1.6 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate google-scholar-query 0.1.6 [INFO] finished tweaking crates.io crate google-scholar-query 0.1.6 [INFO] tweaked toml for crates.io crate google-scholar-query 0.1.6 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate google-scholar-query 0.1.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate google-scholar-query 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded derive_more v0.99.19 [INFO] [stderr] Downloaded html5ever v0.26.0 [INFO] [stderr] Downloaded string_cache v0.8.8 [INFO] [stderr] Downloaded quinn-udp v0.5.10 [INFO] [stderr] Downloaded markup5ever v0.11.0 [INFO] [stderr] Downloaded xml5ever v0.17.0 [INFO] [stderr] Downloaded select v0.6.0 [INFO] [stderr] Downloaded cc v1.2.14 [INFO] [stderr] Downloaded markup5ever_rcdom v0.2.0 [INFO] [stderr] Downloaded serde_json v1.0.139 [INFO] [stderr] Downloaded ring v0.17.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e54c8f80a0f83d52bc29196a27bd6dc5ce8f90aa732a916c56a3910724a9876 [INFO] running `Command { std: "docker" "start" "-a" "1e54c8f80a0f83d52bc29196a27bd6dc5ce8f90aa732a916c56a3910724a9876", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e54c8f80a0f83d52bc29196a27bd6dc5ce8f90aa732a916c56a3910724a9876", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e54c8f80a0f83d52bc29196a27bd6dc5ce8f90aa732a916c56a3910724a9876", kill_on_drop: false }` [INFO] [stdout] 1e54c8f80a0f83d52bc29196a27bd6dc5ce8f90aa732a916c56a3910724a9876 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ce44078c027cca260cf3080b52c483e1f4faaba81a958c04649122a217d9c41 [INFO] running `Command { std: "docker" "start" "-a" "7ce44078c027cca260cf3080b52c483e1f4faaba81a958c04649122a217d9c41", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling serde v1.0.218 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking log v0.4.25 [INFO] [stderr] Checking bytes v1.10.0 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling cc v1.2.14 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking rustls-pki-types v1.11.0 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Compiling httparse v1.10.0 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Compiling rustls v0.23.23 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling ring v0.17.9 [INFO] [stderr] Compiling serde_json v1.0.139 [INFO] [stderr] Checking rustls-native-certs v0.8.1 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking servo_arc v0.4.0 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking ego-tree v0.10.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking string_cache v0.8.8 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling derive_more v0.99.19 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Compiling match_token v0.1.0 [INFO] [stderr] Compiling async-trait v0.1.86 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Compiling selectors v0.26.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Compiling markup5ever v0.14.1 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking cssparser v0.34.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tokio-rustls v0.26.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking html5ever v0.29.1 [INFO] [stderr] Checking xml5ever v0.17.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking scraper v0.23.1 [INFO] [stderr] Checking markup5ever_rcdom v0.2.0 [INFO] [stderr] Checking select v0.6.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking hyper-rustls v0.27.5 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Checking google-scholar-query v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/scholar/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod scholar; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return Services::Scholar; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return Services::Scholar; [INFO] [stdout] 91 + Services::Scholar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:171:8 [INFO] [stdout] | [INFO] [stdout] 171 | return Ok(url); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return Ok(url); [INFO] [stdout] 171 + Ok(url) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/scholar/scholar.rs:99:11 [INFO] [stdout] | [INFO] [stdout] 99 | if self.query == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | url.push_str("1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 159 | url.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | url.push_str("1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 167 | url.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | return 0 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return 0 [INFO] [stdout] 179 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scholar/scholar.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 204 | if !resp.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `resp.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | return Ok(val); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return Ok(val); [INFO] [stdout] 208 + Ok(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/scholar/scholar.rs:251:30 [INFO] [stdout] | [INFO] [stdout] 251 | let pdf_li = match pdf_link { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 252 | | None => None, [INFO] [stdout] 253 | | Some(pdf_link) => Some(pdf_link.to_string()) [INFO] [stdout] 254 | | }; [INFO] [stdout] | |_________________^ help: try: `pdf_link.map(|pdf_link| pdf_link.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/scholar/scholar.rs:263:28 [INFO] [stdout] | [INFO] [stdout] 263 | let conf = match long_author_matches.name("conference") { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 264 | | None => None, [INFO] [stdout] 265 | | Some(conference) => Some(conference.as_str().to_string()) [INFO] [stdout] 266 | | }; [INFO] [stdout] | |_________________^ help: try: `long_author_matches.name("conference").map(|conference| conference.as_str().to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/scholar/scholar.rs:267:26 [INFO] [stdout] | [INFO] [stdout] 267 | let yr = match long_author_matches.name("year") { [INFO] [stdout] | __________________________^ [INFO] [stdout] 268 | | None => None, [INFO] [stdout] 269 | | Some(year) => Some(year.as_str().to_string()) [INFO] [stdout] 270 | | }; [INFO] [stdout] | |_________________^ help: try: `long_author_matches.name("year").map(|year| year.as_str().to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/scholar/scholar.rs:276:33 [INFO] [stdout] | [INFO] [stdout] 276 | let citations = match citations_regex.captures(&ac) { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 277 | | None => None, [INFO] [stdout] 278 | | Some(matches) => Some(u64::from_str(&matches["citations"]).unwrap()), [INFO] [stdout] 279 | | }; [INFO] [stdout] | |_________________^ help: try: `citations_regex.captures(&ac).map(|matches| u64::from_str(&matches["citations"]).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 310 | / return match self.scrape_serialize(doc) { [INFO] [stdout] 311 | | Ok(result) => Ok(result), [INFO] [stdout] 312 | | Err(e) => Err(e), [INFO] [stdout] 313 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 310 ~ match self.scrape_serialize(doc) { [INFO] [stdout] 311 + Ok(result) => Ok(result), [INFO] [stdout] 312 + Err(e) => Err(e), [INFO] [stdout] 313 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/scholar/scholar.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | let url: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `url` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 298 ~ [INFO] [stdout] 299 ~ let url: String = match args.get_url() { [INFO] [stdout] 300 ~ Ok(u) => u, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/scholar/scholar.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | let doc: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `doc` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 304 ~ [INFO] [stdout] 305 ~ let doc: String = match self.get_document(&url[..]).await { [INFO] [stdout] 306 ~ Ok(page) => page, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/scholar/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod scholar; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return Services::Scholar; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return Services::Scholar; [INFO] [stdout] 91 + Services::Scholar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:171:8 [INFO] [stdout] | [INFO] [stdout] 171 | return Ok(url); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return Ok(url); [INFO] [stdout] 171 + Ok(url) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/scholar/scholar.rs:99:11 [INFO] [stdout] | [INFO] [stdout] 99 | if self.query == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | url.push_str("1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 159 | url.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | url.push_str("1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/scholar/scholar.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 167 | url.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | return 0 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return 0 [INFO] [stdout] 179 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scholar/scholar.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 204 | if !resp.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `resp.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | return Ok(val); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return Ok(val); [INFO] [stdout] 208 + Ok(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/scholar/scholar.rs:251:30 [INFO] [stdout] | [INFO] [stdout] 251 | let pdf_li = match pdf_link { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 252 | | None => None, [INFO] [stdout] 253 | | Some(pdf_link) => Some(pdf_link.to_string()) [INFO] [stdout] 254 | | }; [INFO] [stdout] | |_________________^ help: try: `pdf_link.map(|pdf_link| pdf_link.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/scholar/scholar.rs:263:28 [INFO] [stdout] | [INFO] [stdout] 263 | let conf = match long_author_matches.name("conference") { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 264 | | None => None, [INFO] [stdout] 265 | | Some(conference) => Some(conference.as_str().to_string()) [INFO] [stdout] 266 | | }; [INFO] [stdout] | |_________________^ help: try: `long_author_matches.name("conference").map(|conference| conference.as_str().to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/scholar/scholar.rs:267:26 [INFO] [stdout] | [INFO] [stdout] 267 | let yr = match long_author_matches.name("year") { [INFO] [stdout] | __________________________^ [INFO] [stdout] 268 | | None => None, [INFO] [stdout] 269 | | Some(year) => Some(year.as_str().to_string()) [INFO] [stdout] 270 | | }; [INFO] [stdout] | |_________________^ help: try: `long_author_matches.name("year").map(|year| year.as_str().to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/scholar/scholar.rs:276:33 [INFO] [stdout] | [INFO] [stdout] 276 | let citations = match citations_regex.captures(&ac) { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 277 | | None => None, [INFO] [stdout] 278 | | Some(matches) => Some(u64::from_str(&matches["citations"]).unwrap()), [INFO] [stdout] 279 | | }; [INFO] [stdout] | |_________________^ help: try: `citations_regex.captures(&ac).map(|matches| u64::from_str(&matches["citations"]).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scholar/scholar.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 310 | / return match self.scrape_serialize(doc) { [INFO] [stdout] 311 | | Ok(result) => Ok(result), [INFO] [stdout] 312 | | Err(e) => Err(e), [INFO] [stdout] 313 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 310 ~ match self.scrape_serialize(doc) { [INFO] [stdout] 311 + Ok(result) => Ok(result), [INFO] [stdout] 312 + Err(e) => Err(e), [INFO] [stdout] 313 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/scholar/scholar.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | let url: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `url` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 298 ~ [INFO] [stdout] 299 ~ let url: String = match args.get_url() { [INFO] [stdout] 300 ~ Ok(u) => u, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/scholar/scholar.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | let doc: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `doc` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 304 ~ [INFO] [stdout] 305 ~ let doc: String = match self.get_document(&url[..]).await { [INFO] [stdout] 306 ~ Ok(page) => page, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 11s [INFO] running `Command { std: "docker" "inspect" "7ce44078c027cca260cf3080b52c483e1f4faaba81a958c04649122a217d9c41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ce44078c027cca260cf3080b52c483e1f4faaba81a958c04649122a217d9c41", kill_on_drop: false }` [INFO] [stdout] 7ce44078c027cca260cf3080b52c483e1f4faaba81a958c04649122a217d9c41