[INFO] fetching crate gnostr-relay 1894.934224.276199... [INFO] linting gnostr-relay-1894.934224.276199 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gnostr-relay 1894.934224.276199 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate gnostr-relay 1894.934224.276199 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate gnostr-relay 1894.934224.276199 [INFO] tweaked toml for crates.io crate gnostr-relay 1894.934224.276199 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gnostr-relay 1894.934224.276199 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate gnostr-relay 1894.934224.276199 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nostr-kv v0.3.2 [INFO] [stderr] Downloaded temp-env v0.3.6 [INFO] [stderr] Downloaded include-flate v0.3.1 [INFO] [stderr] Downloaded actix-web-actors v4.3.1+deprecated [INFO] [stderr] Downloaded yada v0.5.1 [INFO] [stderr] Downloaded actix_derive v0.6.2 [INFO] [stderr] Downloaded actix-test v0.1.5 [INFO] [stderr] Downloaded cedarwood v0.4.6 [INFO] [stderr] Downloaded actix-http-test v3.2.0 [INFO] [stderr] Downloaded lindera-unidic v0.43.3 [INFO] [stderr] Downloaded unicode-blocks v0.1.9 [INFO] [stderr] Downloaded actix-cors v0.7.1 [INFO] [stderr] Downloaded lindera-ko-dic v0.43.3 [INFO] [stderr] Downloaded actix-tls v3.5.0 [INFO] [stderr] Downloaded clap v4.5.55 [INFO] [stderr] Downloaded awc v3.8.1 [INFO] [stderr] Downloaded actix v0.13.5 [INFO] [stderr] Downloaded duration-str v0.11.3 [INFO] [stderr] Downloaded zerocopy-derive v0.8.35 [INFO] [stderr] Downloaded irg-kvariants v0.1.1 [INFO] [stderr] Downloaded clap_builder v4.5.55 [INFO] [stderr] Downloaded kanaria v0.2.0 [INFO] [stderr] Downloaded jieba-macros v0.8.1 [INFO] [stderr] Downloaded whatlang v0.16.4 [INFO] [stderr] Downloaded zerocopy v0.8.35 [INFO] [stderr] Downloaded lindera-dictionary v0.43.3 [INFO] [stderr] Downloaded nostr-db v0.4.5 [INFO] [stderr] Downloaded include-flate-codegen v0.3.1 [INFO] [stderr] Downloaded include-flate-compress v0.3.1 [INFO] [stderr] Downloaded lindera-cc-cedict v0.43.3 [INFO] [stderr] Downloaded lindera-ipadic v0.43.3 [INFO] [stderr] Downloaded lindera-ipadic-neologd v0.43.3 [INFO] [stderr] Downloaded phf_codegen v0.13.1 [INFO] [stderr] Downloaded lindera v0.43.3 [INFO] [stderr] Downloaded wana_kana v4.0.0 [INFO] [stderr] Downloaded charabia v0.9.9 [INFO] [stderr] Downloaded fst v0.4.7 [INFO] [stderr] Downloaded jieba-rs v0.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d175d5b2c1e9703b1db6f88741c9866431630a4d9d5a5648e09897956bf243e [INFO] running `Command { std: "docker" "start" "-a" "1d175d5b2c1e9703b1db6f88741c9866431630a4d9d5a5648e09897956bf243e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d175d5b2c1e9703b1db6f88741c9866431630a4d9d5a5648e09897956bf243e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d175d5b2c1e9703b1db6f88741c9866431630a4d9d5a5648e09897956bf243e", kill_on_drop: false }` [INFO] [stdout] 1d175d5b2c1e9703b1db6f88741c9866431630a4d9d5a5648e09897956bf243e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20eccb4df16b9d6ea3a5c42d3a716a2551f66ed0da4649021c7fc62a9941732e [INFO] running `Command { std: "docker" "start" "-a" "20eccb4df16b9d6ea3a5c42d3a716a2551f66ed0da4649021c7fc62a9941732e", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Compiling zerocopy v0.8.35 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling zmij v1.0.17 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Compiling convert_case v0.10.0 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Compiling time-macros v0.2.26 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking bytestring v1.5.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Compiling bytes v1.11.0 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling regex-lite v0.1.8 [INFO] [stderr] Compiling ptr_meta_derive v0.1.4 [INFO] [stderr] Compiling bytecheck v0.6.12 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Compiling bytecheck_derive v0.6.12 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking ptr_meta v0.1.4 [INFO] [stderr] Compiling rend v0.4.2 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Checking ahash v0.7.8 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Compiling rkyv v0.7.46 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling rkyv_derive v0.7.46 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Checking seahash v4.1.0 [INFO] [stderr] Checking clap_builder v4.5.55 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking winnow v0.6.26 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling secp256k1-sys v0.10.1 [INFO] [stderr] Checking time v0.3.46 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking temp-env v0.3.6 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking metrics v0.23.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking secp256k1 v0.29.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling actix_derive v0.6.2 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling doxygen-rs v0.4.2 [INFO] [stderr] Compiling lmdb-master-sys v0.2.5 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking duration-str v0.11.3 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking clap v4.5.55 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking nostr-kv v0.3.2 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking nostr-db v0.4.5 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking config v0.14.1 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix v0.13.5 [INFO] [stderr] Checking actix-tls v3.5.0 [INFO] [stderr] Checking actix-http v3.11.2 [INFO] [stderr] Checking actix-web v4.12.1 [INFO] [stderr] Checking awc v3.8.1 [INFO] [stderr] Checking actix-http-test v3.2.0 [INFO] [stderr] Checking actix-cors v0.7.1 [INFO] [stderr] Checking actix-web-actors v4.3.1+deprecated [INFO] [stderr] Checking actix-test v0.1.5 [INFO] [stderr] Checking gnostr-relay v1894.934224.276199 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/writer.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / /// Batch write can improve tps [INFO] [stdout] 13 | | [INFO] [stdout] | |_^ [INFO] [stdout] 14 | const WRITE_INTERVAL_MS: u64 = 100; [INFO] [stdout] | ----------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/writer.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / /// Batch write can improve tps [INFO] [stdout] 13 | | [INFO] [stdout] | |_^ [INFO] [stdout] 14 | const WRITE_INTERVAL_MS: u64 = 100; [INFO] [stdout] | ----------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `setting_path` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:129:24 [INFO] [stdout] | [INFO] [stdout] 128 | let setting = if watch && setting_path.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 129 | let path = setting_path.as_ref().unwrap().as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/extension.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | / pub enum ExtensionMessageResult { [INFO] [stdout] 9 | | /// Continue run the next extension message method, the server takes over finally. [INFO] [stdout] 10 | | Continue(ClientMessage), [INFO] [stdout] | | ----------------------- the largest variant contains at least 336 bytes [INFO] [stdout] 11 | | /// Stop run the next, send outgoing message to client. [INFO] [stdout] 12 | | Stop(OutgoingMessage), [INFO] [stdout] | | --------------------- the second-largest variant contains at least 24 bytes [INFO] [stdout] 13 | | /// Stop run the next, does not send any messages to the client. [INFO] [stdout] 14 | | Ignore, [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ the entire enum is at least 336 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 10 - Continue(ClientMessage), [INFO] [stdout] 10 + Continue(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/message.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 86 | check_max!(self.text.as_bytes().len(), limitation.max_message_length); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.text.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `setting_path` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:129:24 [INFO] [stdout] | [INFO] [stdout] 128 | let setting = if watch && setting_path.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 129 | let path = setting_path.as_ref().unwrap().as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/extension.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | / pub enum ExtensionMessageResult { [INFO] [stdout] 9 | | /// Continue run the next extension message method, the server takes over finally. [INFO] [stdout] 10 | | Continue(ClientMessage), [INFO] [stdout] | | ----------------------- the largest variant contains at least 336 bytes [INFO] [stdout] 11 | | /// Stop run the next, send outgoing message to client. [INFO] [stdout] 12 | | Stop(OutgoingMessage), [INFO] [stdout] | | --------------------- the second-largest variant contains at least 24 bytes [INFO] [stdout] 13 | | /// Stop run the next, does not send any messages to the client. [INFO] [stdout] 14 | | Ignore, [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ the entire enum is at least 336 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 10 - Continue(ClientMessage), [INFO] [stdout] 10 + Continue(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/message.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 86 | check_max!(self.text.as_bytes().len(), limitation.max_message_length); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.text.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/message.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | limitation.max_limit = 300; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `setting::Limitation { max_limit: 300, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/message.rs:528:9 [INFO] [stdout] | [INFO] [stdout] 528 | let mut limitation = Limitation::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `sub.filters.get(0)` [INFO] [stdout] --> src/message.rs:533:60 [INFO] [stdout] | [INFO] [stdout] 533 | matches!(msg.msg, IncomingMessage::Req(sub) if sub.filters.get(0).unwrap().limit.unwrap() == 300) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `sub.filters.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `sub.filters.get(0)` [INFO] [stdout] --> src/message.rs:540:60 [INFO] [stdout] | [INFO] [stdout] 540 | matches!(msg.msg, IncomingMessage::Req(sub) if sub.filters.get(0).unwrap().limit.unwrap() == 300) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `sub.filters.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `sub.filters.get(0)` [INFO] [stdout] --> src/message.rs:547:60 [INFO] [stdout] | [INFO] [stdout] 547 | matches!(msg.msg, IncomingMessage::Req(sub) if sub.filters.get(0).unwrap().limit.unwrap() == 200) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `sub.filters.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `w.get(0)` [INFO] [stdout] --> src/server.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | assert!(w.get(0).unwrap().0.contains("Unsupported")); [INFO] [stdout] | ^^^^^^^^ help: try: `w.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `w.get(0)` [INFO] [stdout] --> src/server.rs:294:25 [INFO] [stdout] | [INFO] [stdout] 294 | assert!(w.get(0).unwrap().0.contains("EOSE")); [INFO] [stdout] | ^^^^^^^^ help: try: `w.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `w.get(0)` [INFO] [stdout] --> src/server.rs:307:25 [INFO] [stdout] | [INFO] [stdout] 307 | assert!(w.get(0).unwrap().0.contains("OK")); [INFO] [stdout] | ^^^^^^^^ help: try: `w.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `w.get(0)` [INFO] [stdout] --> src/server.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | assert!(w.get(0).unwrap().0.contains("OK")); [INFO] [stdout] | ^^^^^^^^ help: try: `w.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `w.get(0)` [INFO] [stdout] --> src/server.rs:333:29 [INFO] [stdout] | [INFO] [stdout] 333 | assert!(w.get(0).unwrap().0.contains("OK")); [INFO] [stdout] | ^^^^^^^^ help: try: `w.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `w.get(0)` [INFO] [stdout] --> src/server.rs:344:29 [INFO] [stdout] | [INFO] [stdout] 344 | assert!(w.get(0).unwrap().0.contains("OK")); [INFO] [stdout] | ^^^^^^^^ help: try: `w.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `w.get(0)` [INFO] [stdout] --> src/server.rs:375:25 [INFO] [stdout] | [INFO] [stdout] 375 | assert!(w.get(0).unwrap().0.contains("EVENT")); [INFO] [stdout] | ^^^^^^^^ help: try: `w.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/writer.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | let r = messages.read(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/writer.rs:282:44 [INFO] [stdout] | [INFO] [stdout] 282 | sleep(Duration::from_millis(1100)).await; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:70:54 [INFO] [stdout] | [INFO] [stdout] 70 | let db_error = Error::Db(nostr_db::Error::Io(std::io::Error::new( [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 71 | | std::io::ErrorKind::Other, [INFO] [stdout] 72 | | "db error", [INFO] [stdout] 73 | | ))); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 70 ~ let db_error = Error::Db(nostr_db::Error::Io(std::io::Error::other( [INFO] [stdout] 71 ~ "db error", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.17s [INFO] running `Command { std: "docker" "inspect" "20eccb4df16b9d6ea3a5c42d3a716a2551f66ed0da4649021c7fc62a9941732e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20eccb4df16b9d6ea3a5c42d3a716a2551f66ed0da4649021c7fc62a9941732e", kill_on_drop: false }` [INFO] [stdout] 20eccb4df16b9d6ea3a5c42d3a716a2551f66ed0da4649021c7fc62a9941732e