[INFO] fetching crate git-helpe-rs 1.0.5... [INFO] linting git-helpe-rs-1.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate git-helpe-rs 1.0.5 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate git-helpe-rs 1.0.5 [INFO] finished tweaking crates.io crate git-helpe-rs 1.0.5 [INFO] tweaked toml for crates.io crate git-helpe-rs 1.0.5 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate git-helpe-rs 1.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate git-helpe-rs 1.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.4.7 [INFO] [stderr] Downloaded serde_derive v1.0.190 [INFO] [stderr] Downloaded clap_complete v4.4.10 [INFO] [stderr] Downloaded serde v1.0.190 [INFO] [stderr] Downloaded clap_builder v4.4.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 710ecbd148bed9c487500b22acaab25aa9f237b0e381284cbd4803aee3d473f5 [INFO] running `Command { std: "docker" "start" "-a" "710ecbd148bed9c487500b22acaab25aa9f237b0e381284cbd4803aee3d473f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "710ecbd148bed9c487500b22acaab25aa9f237b0e381284cbd4803aee3d473f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "710ecbd148bed9c487500b22acaab25aa9f237b0e381284cbd4803aee3d473f5", kill_on_drop: false }` [INFO] [stdout] 710ecbd148bed9c487500b22acaab25aa9f237b0e381284cbd4803aee3d473f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 871ae935da30daad2c7ddf2eccb747751a04aadee21e613356404683ad540cb1 [INFO] running `Command { std: "docker" "start" "-a" "871ae935da30daad2c7ddf2eccb747751a04aadee21e613356404683ad540cb1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Compiling anstyle-query v1.0.0 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Compiling anstyle v1.0.4 [INFO] [stderr] Compiling clap_lex v0.6.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling anstyle-parse v0.2.2 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling clap v4.4.7 [INFO] [stderr] Compiling clap_complete v4.4.10 [INFO] [stderr] Compiling git-helpe-rs v1.0.5 (/opt/rustwide/workdir) [INFO] [stderr] warning: git-helpe-rs@1.0.5: completion file is generated: "/opt/rustwide/target/debug/build/git-helpe-rs-d994f6aae020058e/out/git-helpe-rs.bash" [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli/map_to_operation.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | use_template: use_template, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_template` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli/map_to_operation.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | interpolate_values: interpolate_values, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interpolate_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli/map_to_operation.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | key: key, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli/map_to_operation.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | use_template: use_template, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_template` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli/map_to_operation.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | interpolate_values: interpolate_values, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interpolate_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli/map_to_operation.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | key: key, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git_config.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git_config.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/branch.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / return match run_mode { [INFO] [stdout] 53 | | RunMode::Normal => { [INFO] [stdout] 54 | | let result = Command::new("git") [INFO] [stdout] 55 | | .arg("checkout") [INFO] [stdout] ... | [INFO] [stdout] 83 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ match run_mode { [INFO] [stdout] 53 + RunMode::Normal => { [INFO] [stdout] 54 + let result = Command::new("git") [INFO] [stdout] 55 + .arg("checkout") [INFO] [stdout] 56 + .arg("-b") [INFO] [stdout] 57 + .arg(full_branch_name) [INFO] [stdout] 58 + .output() [INFO] [stdout] 59 + .unwrap(); [INFO] [stdout] 60 + [INFO] [stdout] 61 + println!("git output: \n {:?}", String::from_utf8(result.stdout)); [INFO] [stdout] 62 + Ok(()) [INFO] [stdout] 63 + } [INFO] [stdout] 64 + RunMode::DryRun => { [INFO] [stdout] 65 + println!( [INFO] [stdout] 66 + "Going to run: \n \ [INFO] [stdout] 67 + git checkout -b {}", [INFO] [stdout] 68 + full_branch_name [INFO] [stdout] 69 + ); [INFO] [stdout] 70 + Ok(()) [INFO] [stdout] 71 + } [INFO] [stdout] 72 + RunMode::Copy => run_copy(&config, format!("git checkout -b {}", full_branch_name)), [INFO] [stdout] 73 + RunMode::DryRunAndCopy => { [INFO] [stdout] 74 + let copy_command = config.data.clipboard_commands.copy; [INFO] [stdout] 75 + [INFO] [stdout] 76 + println!( [INFO] [stdout] 77 + "Going to run: \n \ [INFO] [stdout] 78 + echo 'git checkout -b {}' > {}", [INFO] [stdout] 79 + full_branch_name, copy_command [INFO] [stdout] 80 + ); [INFO] [stdout] 81 + Ok(()) [INFO] [stdout] 82 + } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `clipboard_command.get(0)` [INFO] [stdout] --> src/cli/map_to_operation.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | let copy = clipboard_command.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `clipboard_command.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commit.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | / return match run_mode { [INFO] [stdout] 84 | | RunMode::Normal => { [INFO] [stdout] 85 | | let cmd = Command::new("git") [INFO] [stdout] 86 | | .arg("commit") [INFO] [stdout] ... | [INFO] [stdout] 116 | | ), [INFO] [stdout] 117 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 ~ match run_mode { [INFO] [stdout] 84 + RunMode::Normal => { [INFO] [stdout] 85 + let cmd = Command::new("git") [INFO] [stdout] 86 + .arg("commit") [INFO] [stdout] 87 + .arg("-m") [INFO] [stdout] 88 + .arg(interpolated_commit) [INFO] [stdout] 89 + .output() [INFO] [stdout] 90 + .unwrap() [INFO] [stdout] 91 + .stdout; [INFO] [stdout] 92 + println!("{}", String::from_utf8_lossy(&cmd)); [INFO] [stdout] 93 + [INFO] [stdout] 94 + Ok(()) [INFO] [stdout] 95 + } [INFO] [stdout] 96 + RunMode::DryRun => { [INFO] [stdout] 97 + println!( [INFO] [stdout] 98 + "Going to run: \n \ [INFO] [stdout] 99 + git commit -m \"{}\"", [INFO] [stdout] 100 + interpolated_commit [INFO] [stdout] 101 + ); [INFO] [stdout] 102 + Ok(()) [INFO] [stdout] 103 + } [INFO] [stdout] 104 + RunMode::DryRunAndCopy => { [INFO] [stdout] 105 + let copy_command = config.data.clipboard_commands.copy; [INFO] [stdout] 106 + println!( [INFO] [stdout] 107 + "Going to run: \n \ [INFO] [stdout] 108 + echo 'git commit -m \"{}\"' > {}", [INFO] [stdout] 109 + interpolated_commit, copy_command [INFO] [stdout] 110 + ); [INFO] [stdout] 111 + Ok(()) [INFO] [stdout] 112 + } [INFO] [stdout] 113 + RunMode::Copy => run_copy( [INFO] [stdout] 114 + &config, [INFO] [stdout] 115 + format!("git commit -m \"{}\"", interpolated_commit), [INFO] [stdout] 116 + ), [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commit.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 136 | if branch_number == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `branch_number.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/file_utils/config_file.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return home; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return home; [INFO] [stdout] 16 + home [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/branch.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / return match run_mode { [INFO] [stdout] 53 | | RunMode::Normal => { [INFO] [stdout] 54 | | let result = Command::new("git") [INFO] [stdout] 55 | | .arg("checkout") [INFO] [stdout] ... | [INFO] [stdout] 83 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ match run_mode { [INFO] [stdout] 53 + RunMode::Normal => { [INFO] [stdout] 54 + let result = Command::new("git") [INFO] [stdout] 55 + .arg("checkout") [INFO] [stdout] 56 + .arg("-b") [INFO] [stdout] 57 + .arg(full_branch_name) [INFO] [stdout] 58 + .output() [INFO] [stdout] 59 + .unwrap(); [INFO] [stdout] 60 + [INFO] [stdout] 61 + println!("git output: \n {:?}", String::from_utf8(result.stdout)); [INFO] [stdout] 62 + Ok(()) [INFO] [stdout] 63 + } [INFO] [stdout] 64 + RunMode::DryRun => { [INFO] [stdout] 65 + println!( [INFO] [stdout] 66 + "Going to run: \n \ [INFO] [stdout] 67 + git checkout -b {}", [INFO] [stdout] 68 + full_branch_name [INFO] [stdout] 69 + ); [INFO] [stdout] 70 + Ok(()) [INFO] [stdout] 71 + } [INFO] [stdout] 72 + RunMode::Copy => run_copy(&config, format!("git checkout -b {}", full_branch_name)), [INFO] [stdout] 73 + RunMode::DryRunAndCopy => { [INFO] [stdout] 74 + let copy_command = config.data.clipboard_commands.copy; [INFO] [stdout] 75 + [INFO] [stdout] 76 + println!( [INFO] [stdout] 77 + "Going to run: \n \ [INFO] [stdout] 78 + echo 'git checkout -b {}' > {}", [INFO] [stdout] 79 + full_branch_name, copy_command [INFO] [stdout] 80 + ); [INFO] [stdout] 81 + Ok(()) [INFO] [stdout] 82 + } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `clipboard_command.get(0)` [INFO] [stdout] --> src/cli/map_to_operation.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | let copy = clipboard_command.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `clipboard_command.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git_config.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / return GitConfig { [INFO] [stdout] 61 | | data: Data::default(), [INFO] [stdout] 62 | | config_path: get_path_to_config(None).to_path_buf(), [INFO] [stdout] 63 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 ~ GitConfig { [INFO] [stdout] 61 + data: Data::default(), [INFO] [stdout] 62 + config_path: get_path_to_config(None).to_path_buf(), [INFO] [stdout] 63 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git_config.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / return GitConfig { [INFO] [stdout] 74 | | data: Data { [INFO] [stdout] 75 | | clipboard_commands, [INFO] [stdout] 76 | | branch_template_variants: branch_format_variants, [INFO] [stdout] ... | [INFO] [stdout] 85 | | }, [INFO] [stdout] 86 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 ~ GitConfig { [INFO] [stdout] 74 + data: Data { [INFO] [stdout] 75 + clipboard_commands, [INFO] [stdout] 76 + branch_template_variants: branch_format_variants, [INFO] [stdout] 77 + commit_template_variants: commit_format_variants, [INFO] [stdout] 78 + branch_prefix_variants, [INFO] [stdout] 79 + autocomplete_values: None, [INFO] [stdout] 80 + }, [INFO] [stdout] 81 + config_path: if let Some(config_path) = config_path { [INFO] [stdout] 82 + config_path [INFO] [stdout] 83 + } else { [INFO] [stdout] 84 + get_path_to_config(None).to_path_buf() [INFO] [stdout] 85 + }, [INFO] [stdout] 86 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commit.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | / return match run_mode { [INFO] [stdout] 84 | | RunMode::Normal => { [INFO] [stdout] 85 | | let cmd = Command::new("git") [INFO] [stdout] 86 | | .arg("commit") [INFO] [stdout] ... | [INFO] [stdout] 116 | | ), [INFO] [stdout] 117 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 ~ match run_mode { [INFO] [stdout] 84 + RunMode::Normal => { [INFO] [stdout] 85 + let cmd = Command::new("git") [INFO] [stdout] 86 + .arg("commit") [INFO] [stdout] 87 + .arg("-m") [INFO] [stdout] 88 + .arg(interpolated_commit) [INFO] [stdout] 89 + .output() [INFO] [stdout] 90 + .unwrap() [INFO] [stdout] 91 + .stdout; [INFO] [stdout] 92 + println!("{}", String::from_utf8_lossy(&cmd)); [INFO] [stdout] 93 + [INFO] [stdout] 94 + Ok(()) [INFO] [stdout] 95 + } [INFO] [stdout] 96 + RunMode::DryRun => { [INFO] [stdout] 97 + println!( [INFO] [stdout] 98 + "Going to run: \n \ [INFO] [stdout] 99 + git commit -m \"{}\"", [INFO] [stdout] 100 + interpolated_commit [INFO] [stdout] 101 + ); [INFO] [stdout] 102 + Ok(()) [INFO] [stdout] 103 + } [INFO] [stdout] 104 + RunMode::DryRunAndCopy => { [INFO] [stdout] 105 + let copy_command = config.data.clipboard_commands.copy; [INFO] [stdout] 106 + println!( [INFO] [stdout] 107 + "Going to run: \n \ [INFO] [stdout] 108 + echo 'git commit -m \"{}\"' > {}", [INFO] [stdout] 109 + interpolated_commit, copy_command [INFO] [stdout] 110 + ); [INFO] [stdout] 111 + Ok(()) [INFO] [stdout] 112 + } [INFO] [stdout] 113 + RunMode::Copy => run_copy( [INFO] [stdout] 114 + &config, [INFO] [stdout] 115 + format!("git commit -m \"{}\"", interpolated_commit), [INFO] [stdout] 116 + ), [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git_config.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | / return Err(Error::msg(format!( [INFO] [stdout] 123 | | "There was no interpolation signature: {{}} introduced in {name_of_field_to_check}" [INFO] [stdout] 124 | | ))); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 ~ Err(Error::msg(format!( [INFO] [stdout] 123 + "There was no interpolation signature: {{}} introduced in {name_of_field_to_check}" [INFO] [stdout] 124 ~ ))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/git_config.rs:179:16 [INFO] [stdout] | [INFO] [stdout] 179 | if !std::fs::metadata(&dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git_config.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return Ok(()); [INFO] [stdout] 186 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git_config.rs:179:35 [INFO] [stdout] | [INFO] [stdout] 179 | if !std::fs::metadata(&dir).is_ok() { [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commit.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 136 | if branch_number == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `branch_number.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/run_mode.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | let echo = Command::new("echo") [INFO] [stdout] | ________________^ [INFO] [stdout] 34 | | .arg(value_to_copy) [INFO] [stdout] 35 | | .stdout(Stdio::piped()) [INFO] [stdout] 36 | | .spawn() [INFO] [stdout] 37 | | .unwrap(); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/template.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | format: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 - format: &String, [INFO] [stdout] 8 + format: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/commit.rs:174:22 [INFO] [stdout] | [INFO] [stdout] 174 | Ok(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/commit.rs:175:23 [INFO] [stdout] | [INFO] [stdout] 175 | Err(_) => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/template.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | let splitted = format.split(custom_pattern).into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `format.split(custom_pattern)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/template.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | format: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 35 - format: &String, [INFO] [stdout] 35 + format: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/template.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | return x.to_owned() + &values[i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return x.to_owned() + &values[i]; [INFO] [stdout] 47 + x.to_owned() + &values[i] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/commit.rs:271:22 [INFO] [stdout] | [INFO] [stdout] 271 | Ok(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/commit.rs:272:23 [INFO] [stdout] | [INFO] [stdout] 272 | Err(_) => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/file_utils/config_file.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return home; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return home; [INFO] [stdout] 16 + home [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git_config.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / return GitConfig { [INFO] [stdout] 61 | | data: Data::default(), [INFO] [stdout] 62 | | config_path: get_path_to_config(None).to_path_buf(), [INFO] [stdout] 63 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 ~ GitConfig { [INFO] [stdout] 61 + data: Data::default(), [INFO] [stdout] 62 + config_path: get_path_to_config(None).to_path_buf(), [INFO] [stdout] 63 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git_config.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / return GitConfig { [INFO] [stdout] 74 | | data: Data { [INFO] [stdout] 75 | | clipboard_commands, [INFO] [stdout] 76 | | branch_template_variants: branch_format_variants, [INFO] [stdout] ... | [INFO] [stdout] 85 | | }, [INFO] [stdout] 86 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 ~ GitConfig { [INFO] [stdout] 74 + data: Data { [INFO] [stdout] 75 + clipboard_commands, [INFO] [stdout] 76 + branch_template_variants: branch_format_variants, [INFO] [stdout] 77 + commit_template_variants: commit_format_variants, [INFO] [stdout] 78 + branch_prefix_variants, [INFO] [stdout] 79 + autocomplete_values: None, [INFO] [stdout] 80 + }, [INFO] [stdout] 81 + config_path: if let Some(config_path) = config_path { [INFO] [stdout] 82 + config_path [INFO] [stdout] 83 + } else { [INFO] [stdout] 84 + get_path_to_config(None).to_path_buf() [INFO] [stdout] 85 + }, [INFO] [stdout] 86 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git_config.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | / return Err(Error::msg(format!( [INFO] [stdout] 123 | | "There was no interpolation signature: {{}} introduced in {name_of_field_to_check}" [INFO] [stdout] 124 | | ))); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 ~ Err(Error::msg(format!( [INFO] [stdout] 123 + "There was no interpolation signature: {{}} introduced in {name_of_field_to_check}" [INFO] [stdout] 124 ~ ))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/git_config.rs:179:16 [INFO] [stdout] | [INFO] [stdout] 179 | if !std::fs::metadata(&dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/git_config.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return Ok(()); [INFO] [stdout] 186 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git_config.rs:179:35 [INFO] [stdout] | [INFO] [stdout] 179 | if !std::fs::metadata(&dir).is_ok() { [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/run_mode.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | let echo = Command::new("echo") [INFO] [stdout] | ________________^ [INFO] [stdout] 34 | | .arg(value_to_copy) [INFO] [stdout] 35 | | .stdout(Stdio::piped()) [INFO] [stdout] 36 | | .spawn() [INFO] [stdout] 37 | | .unwrap(); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/run_mode.rs:60:39 [INFO] [stdout] | [INFO] [stdout] 60 | RunMode::DryRunAndCopy => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/run_mode.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 61 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/run_mode.rs:71:30 [INFO] [stdout] | [INFO] [stdout] 71 | RunMode::Copy => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/run_mode.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 72 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/run_mode.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 82 | RunMode::DryRun => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/run_mode.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 83 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/run_mode.rs:93:32 [INFO] [stdout] | [INFO] [stdout] 93 | RunMode::Normal => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/run_mode.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/template.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | format: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 - format: &String, [INFO] [stdout] 8 + format: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/template.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | let splitted = format.split(custom_pattern).into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `format.split(custom_pattern)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/template.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | format: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 35 - format: &String, [INFO] [stdout] 35 + format: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/template.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | return x.to_owned() + &values[i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return x.to_owned() + &values[i]; [INFO] [stdout] 47 + x.to_owned() + &values[i] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/template.rs:96:22 [INFO] [stdout] | [INFO] [stdout] 96 | let values = vec![String::from("world"), String::from("extra")]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[String::from("world"), String::from("extra")]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.11s [INFO] running `Command { std: "docker" "inspect" "871ae935da30daad2c7ddf2eccb747751a04aadee21e613356404683ad540cb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "871ae935da30daad2c7ddf2eccb747751a04aadee21e613356404683ad540cb1", kill_on_drop: false }` [INFO] [stdout] 871ae935da30daad2c7ddf2eccb747751a04aadee21e613356404683ad540cb1