[INFO] fetching crate git-flow-rs 0.4.3... [INFO] linting git-flow-rs-0.4.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate git-flow-rs 0.4.3 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate git-flow-rs 0.4.3 [INFO] finished tweaking crates.io crate git-flow-rs 0.4.3 [INFO] tweaked toml for crates.io crate git-flow-rs 0.4.3 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate git-flow-rs 0.4.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate git-flow-rs 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded toml_datetime v0.6.5 [INFO] [stderr] Downloaded serde v1.0.197 [INFO] [stderr] Downloaded bytecount v0.6.7 [INFO] [stderr] Downloaded terminal_size v0.3.0 [INFO] [stderr] Downloaded tabled_derive v0.7.0 [INFO] [stderr] Downloaded windows-targets v0.52.4 [INFO] [stderr] Downloaded toml v0.8.10 [INFO] [stderr] Downloaded anstream v0.6.13 [INFO] [stderr] Downloaded anyhow v1.0.80 [INFO] [stderr] Downloaded clap v4.5.2 [INFO] [stderr] Downloaded papergrid v0.11.0 [INFO] [stderr] Downloaded winnow v0.6.5 [INFO] [stderr] Downloaded cc v1.0.95 [INFO] [stderr] Downloaded miniz_oxide v0.7.2 [INFO] [stderr] Downloaded socket2 v0.5.6 [INFO] [stderr] Downloaded syn v2.0.60 [INFO] [stderr] Downloaded clap_builder v4.5.2 [INFO] [stderr] Downloaded indexmap v2.2.5 [INFO] [stderr] Downloaded toml_edit v0.22.6 [INFO] [stderr] Downloaded autocfg v1.2.0 [INFO] [stderr] Downloaded tabled v0.15.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.81 [INFO] [stderr] Downloaded serde_derive v1.0.197 [INFO] [stderr] Downloaded windows_x86_64_gnullvm v0.52.4 [INFO] [stderr] Downloaded windows_aarch64_gnullvm v0.52.4 [INFO] [stderr] Downloaded regex-automata v0.4.6 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.52.4 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.52.4 [INFO] [stderr] Downloaded windows_i686_gnu v0.52.4 [INFO] [stderr] Downloaded windows_i686_msvc v0.52.4 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.52.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4b1c0585a39b74f15586a525dadf0082557e2a558f4041961bd819edb0d13c1 [INFO] running `Command { std: "docker" "start" "-a" "d4b1c0585a39b74f15586a525dadf0082557e2a558f4041961bd819edb0d13c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4b1c0585a39b74f15586a525dadf0082557e2a558f4041961bd819edb0d13c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4b1c0585a39b74f15586a525dadf0082557e2a558f4041961bd819edb0d13c1", kill_on_drop: false }` [INFO] [stdout] d4b1c0585a39b74f15586a525dadf0082557e2a558f4041961bd819edb0d13c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b1c392735db97c827e9908285b28ca3ca932a9ea176bfcfeaedd0c6cee65b03 [INFO] running `Command { std: "docker" "start" "-a" "2b1c392735db97c827e9908285b28ca3ca932a9ea176bfcfeaedd0c6cee65b03", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking winnow v0.6.5 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking papergrid v0.11.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling tabled_derive v0.7.0 [INFO] [stderr] Checking tabled v0.15.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.6 [INFO] [stderr] Checking toml v0.8.10 [INFO] [stderr] Checking git-flow-rs v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/command/finish.rs:70:64 [INFO] [stdout] | [INFO] [stdout] 70 | fn resolve_target_branches(branch_name: &str, target_branches: &Vec) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 70 - fn resolve_target_branches(branch_name: &str, target_branches: &Vec) -> Result<()> { [INFO] [stdout] 70 + fn resolve_target_branches(branch_name: &str, target_branches: &[TargetBranch]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/finish.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 144 | if commits.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `commits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/command/finish.rs:145:23 [INFO] [stdout] | [INFO] [stdout] 145 | Echo::success(&format!("no commits to cherry pick to {}", target_branch)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("no commits to cherry pick to {}", target_branch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/command/finish.rs:70:64 [INFO] [stdout] | [INFO] [stdout] 70 | fn resolve_target_branches(branch_name: &str, target_branches: &Vec) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 70 - fn resolve_target_branches(branch_name: &str, target_branches: &Vec) -> Result<()> { [INFO] [stdout] 70 + fn resolve_target_branches(branch_name: &str, target_branches: &[TargetBranch]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/finish.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 144 | if commits.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `commits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/command/finish.rs:145:23 [INFO] [stdout] | [INFO] [stdout] 145 | Echo::success(&format!("no commits to cherry pick to {}", target_branch)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("no commits to cherry pick to {}", target_branch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/list.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | if config_v.branch_types.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config_v.branch_types.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/command/list.rs:75:50 [INFO] [stdout] | [INFO] [stdout] 75 | .with(Width::increase(width)) [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 76 | | .to_string() [INFO] [stdout] | |________________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/list.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | if config_v.branch_types.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config_v.branch_types.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/command/list.rs:75:50 [INFO] [stdout] | [INFO] [stdout] 75 | .with(Width::increase(width)) [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 76 | | .to_string() [INFO] [stdout] | |________________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/sync.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | if repos.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `repos.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/sync.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | if redundant_branches.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `redundant_branches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/sync.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | if repos.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `repos.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/sync.rs:143:8 [INFO] [stdout] | [INFO] [stdout] 143 | if missing_branches.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `missing_branches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/sync.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | if redundant_branches.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `redundant_branches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/command/track.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 27 | Echo::info(&format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 28 | | "no commits ahead of the source branch {} on {}", [INFO] [stdout] 29 | | &branch_type.from, &branch_name, [INFO] [stdout] 30 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 ~ Echo::info(format!( [INFO] [stdout] 28 + "no commits ahead of the source branch {} on {}", [INFO] [stdout] 29 + &branch_type.from, &branch_name, [INFO] [stdout] 30 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/command/track.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | Echo::info(&format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 33 | | "these commits are ahead of the source branch {}:\n", [INFO] [stdout] 34 | | &branch_type.from, [INFO] [stdout] 35 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 ~ Echo::info(format!( [INFO] [stdout] 33 + "these commits are ahead of the source branch {}:\n", [INFO] [stdout] 34 + &branch_type.from, [INFO] [stdout] 35 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command/sync.rs:143:8 [INFO] [stdout] | [INFO] [stdout] 143 | if missing_branches.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `missing_branches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/command/track.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 27 | Echo::info(&format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 28 | | "no commits ahead of the source branch {} on {}", [INFO] [stdout] 29 | | &branch_type.from, &branch_name, [INFO] [stdout] 30 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 ~ Echo::info(format!( [INFO] [stdout] 28 + "no commits ahead of the source branch {} on {}", [INFO] [stdout] 29 + &branch_type.from, &branch_name, [INFO] [stdout] 30 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/command/track.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | Echo::info(&format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 33 | | "these commits are ahead of the source branch {}:\n", [INFO] [stdout] 34 | | &branch_type.from, [INFO] [stdout] 35 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 ~ Echo::info(format!( [INFO] [stdout] 33 + "these commits are ahead of the source branch {}:\n", [INFO] [stdout] 34 + &branch_type.from, [INFO] [stdout] 35 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config/path/mod.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | while !cur_dir.parent().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cur_dir.parent().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config/validate/mod.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | no_duplicate_branch_type(&config)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config/validate/mod.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | target_is_valid_regex(&config)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/config/path/test.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | assert_eq!(regex.is_match(global_config_path.to_str().unwrap()), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 12 - assert_eq!(regex.is_match(global_config_path.to_str().unwrap()), true); [INFO] [stdout] 12 + assert!(regex.is_match(global_config_path.to_str().unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config/validate/mod.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | create_is_valid(&config)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `branch_types` [INFO] [stdout] --> src/config/validate/mod.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | for j in 0..i { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 22 - for j in 0..i { [INFO] [stdout] 22 + for in branch_types.iter().take(i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/config/path/test.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | assert_eq!(path.join(".git").is_dir(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 21 - assert_eq!(path.join(".git").is_dir(), true); [INFO] [stdout] 21 + assert!(path.join(".git").is_dir()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config/path/mod.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | while !cur_dir.parent().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cur_dir.parent().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/config/read/test.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(read_config(None).is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(read_config(None).is_ok(), true); [INFO] [stdout] 5 + assert!(read_config(None).is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config/validate/mod.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 78 | if invalid_creates.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!invalid_creates.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/config/validate/test.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | assert_eq!(validate_config(&config_list).is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7 - assert_eq!(validate_config(&config_list).is_ok(), true); [INFO] [stdout] 7 + assert!(validate_config(&config_list).is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/echo/mod.rs:32:49 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn progress>(msg: T) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config/validate/mod.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | no_duplicate_branch_type(&config)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config/validate/mod.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | target_is_valid_regex(&config)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config/validate/mod.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | create_is_valid(&config)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `branch_types` [INFO] [stdout] --> src/config/validate/mod.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | for j in 0..i { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 22 - for j in 0..i { [INFO] [stdout] 22 + for in branch_types.iter().take(i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/git/branch.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 78 | .filter(|x| *x != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/git/branch.rs:93:40 [INFO] [stdout] | [INFO] [stdout] 93 | .filter(|(i, x)| *i > 0 && *x != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter` for `Some` followed by `unwrap` [INFO] [stdout] --> src/git/branch.rs:107:14 [INFO] [stdout] | [INFO] [stdout] 107 | .filter(|x| x.is_some()) [INFO] [stdout] | ______________^ [INFO] [stdout] 108 | | .map(|x| x.unwrap()); [INFO] [stdout] | |________________________________^ help: consider using `flatten` instead: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_filter_map [INFO] [stdout] = note: `#[warn(clippy::option_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config/validate/mod.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 78 | if invalid_creates.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!invalid_creates.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/echo/mod.rs:32:49 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn progress>(msg: T) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(Git::git_installed(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(Git::git_installed(), true); [INFO] [stdout] 5 + assert!(Git::git_installed()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | assert_eq!(Git::in_git_project(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 10 - assert_eq!(Git::in_git_project(), true); [INFO] [stdout] 10 + assert!(Git::in_git_project()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 16 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 16 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 18 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 18 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 24 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 24 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/git/mod.rs:98:25 [INFO] [stdout] | [INFO] [stdout] 98 | .filter(|x| *x != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 30 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 36 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 36 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 42 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 42 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/git/mod.rs:129:25 [INFO] [stdout] | [INFO] [stdout] 129 | .filter(|x| *x != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | assert_eq!(result.is_ok(), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 48 - assert_eq!(result.is_ok(), false) [INFO] [stdout] 48 + assert!(!result.is_ok()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/utils.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | let config = match read_config(config_path) { [INFO] [stdout] | __________________^ [INFO] [stdout] 38 | | Err(err) => return Err(err), [INFO] [stdout] 39 | | Ok(config_v) => config_v, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_____^ help: try instead: `read_config(config_path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | assert_eq!(result.is_ok(), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 54 - assert_eq!(result.is_ok(), false) [INFO] [stdout] 54 + assert!(!result.is_ok()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | assert_eq!(result.is_ok(), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 60 - assert_eq!(result.is_ok(), false) [INFO] [stdout] 60 + assert!(!result.is_ok()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | assert_eq!(result.iter().find(|x| x.as_str() == "main").is_some(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 66 - assert_eq!(result.iter().find(|x| x.as_str() == "main").is_some(), true); [INFO] [stdout] 66 + assert!(result.iter().find(|x| x.as_str() == "main").is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | assert_eq!(repos.iter().any(|x| x == "origin"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 87 - assert_eq!(repos.iter().any(|x| x == "origin"), true); [INFO] [stdout] 87 + assert!(repos.iter().any(|x| x == "origin")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/git/test.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 94 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 94 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/git/branch.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 78 | .filter(|x| *x != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/git/branch.rs:93:40 [INFO] [stdout] | [INFO] [stdout] 93 | .filter(|(i, x)| *i > 0 && *x != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter` for `Some` followed by `unwrap` [INFO] [stdout] --> src/git/branch.rs:107:14 [INFO] [stdout] | [INFO] [stdout] 107 | .filter(|x| x.is_some()) [INFO] [stdout] | ______________^ [INFO] [stdout] 108 | | .map(|x| x.unwrap()); [INFO] [stdout] | |________________________________^ help: consider using `flatten` instead: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_filter_map [INFO] [stdout] = note: `#[warn(clippy::option_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/git/mod.rs:98:25 [INFO] [stdout] | [INFO] [stdout] 98 | .filter(|x| *x != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/git/mod.rs:129:25 [INFO] [stdout] | [INFO] [stdout] 129 | .filter(|x| *x != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/utils.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | let config = match read_config(config_path) { [INFO] [stdout] | __________________^ [INFO] [stdout] 38 | | Err(err) => return Err(err), [INFO] [stdout] 39 | | Ok(config_v) => config_v, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_____^ help: try instead: `read_config(config_path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.25s [INFO] running `Command { std: "docker" "inspect" "2b1c392735db97c827e9908285b28ca3ca932a9ea176bfcfeaedd0c6cee65b03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b1c392735db97c827e9908285b28ca3ca932a9ea176bfcfeaedd0c6cee65b03", kill_on_drop: false }` [INFO] [stdout] 2b1c392735db97c827e9908285b28ca3ca932a9ea176bfcfeaedd0c6cee65b03