[INFO] fetching crate git-cloak 0.0.1... [INFO] linting git-cloak-0.0.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate git-cloak 0.0.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate git-cloak 0.0.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate git-cloak 0.0.1 [INFO] tweaked toml for crates.io crate git-cloak 0.0.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate git-cloak 0.0.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate git-cloak 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gix-trace v0.1.17 [INFO] [stderr] Downloaded gix-utils v0.3.1 [INFO] [stderr] Downloaded gix-revwalk v0.26.0 [INFO] [stderr] Downloaded gix-actor v0.38.0 [INFO] [stderr] Downloaded fs-set-times v0.20.3 [INFO] [stderr] Downloaded rustix-linux-procfs v0.1.1 [INFO] [stderr] Downloaded io-extras v0.18.4 [INFO] [stderr] Downloaded gix-transport v0.53.0 [INFO] [stderr] Downloaded gix-config v0.51.0 [INFO] [stderr] Downloaded gix-diff v0.58.0 [INFO] [stderr] Downloaded gix-index v0.46.0 [INFO] [stderr] Downloaded cap-primitives v3.4.5 [INFO] [stderr] Downloaded prodash v31.0.0 [INFO] [stderr] Downloaded arc-swap v1.8.1 [INFO] [stderr] Downloaded gix v0.78.0 [INFO] [stderr] Downloaded gix-odb v0.75.0 [INFO] [stderr] Downloaded gix-pack v0.65.0 [INFO] [stderr] Downloaded gix-ref v0.58.0 [INFO] [stderr] Downloaded gix-tempfile v21.0.0 [INFO] [stderr] Downloaded gix-features v0.46.0 [INFO] [stderr] Downloaded cap-std v3.4.5 [INFO] [stderr] Downloaded gix-discover v0.46.0 [INFO] [stderr] Downloaded gix-protocol v0.56.0 [INFO] [stderr] Downloaded gix-refspec v0.36.0 [INFO] [stderr] Downloaded gix-revision v0.40.0 [INFO] [stderr] Downloaded gix-fs v0.19.0 [INFO] [stderr] Downloaded gix-commitgraph v0.32.0 [INFO] [stderr] Downloaded gix-error v0.0.0 [INFO] [stderr] Downloaded gix-hash v0.22.0 [INFO] [stderr] Downloaded gix-config-value v0.17.0 [INFO] [stderr] Downloaded gix-command v0.7.0 [INFO] [stderr] Downloaded gix-sec v0.13.0 [INFO] [stderr] Downloaded gix-chunk v0.5.0 [INFO] [stderr] Downloaded gix-date v0.13.0 [INFO] [stderr] Downloaded faster-hex v0.10.0 [INFO] [stderr] Downloaded gix-hashtable v0.12.0 [INFO] [stderr] Downloaded winx v0.36.4 [INFO] [stderr] Downloaded io-lifetimes v2.0.4 [INFO] [stderr] Downloaded unicode-bom v2.0.3 [INFO] [stderr] Downloaded gix-bitmap v0.2.15 [INFO] [stderr] Downloaded clru v0.6.2 [INFO] [stderr] Downloaded gix-packetline v0.21.0 [INFO] [stderr] Downloaded gix-quote v0.6.1 [INFO] [stderr] Downloaded maybe-async v0.2.10 [INFO] [stderr] Downloaded gix-glob v0.24.0 [INFO] [stderr] Downloaded gix-lock v21.0.0 [INFO] [stderr] Downloaded gix-shallow v0.8.0 [INFO] [stderr] Downloaded gix-object v0.55.0 [INFO] [stderr] Downloaded gix-path v0.11.0 [INFO] [stderr] Downloaded gix-traverse v0.52.0 [INFO] [stderr] Downloaded gix-url v0.35.0 [INFO] [stderr] Downloaded gix-validate v0.11.0 [INFO] [stderr] Downloaded sha1-checked v0.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f1a07c4cad283687f96d83edd56f2b8446318bf9bdd66d1674eaf9801833197e [INFO] running `Command { std: "docker" "start" "-a" "f1a07c4cad283687f96d83edd56f2b8446318bf9bdd66d1674eaf9801833197e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f1a07c4cad283687f96d83edd56f2b8446318bf9bdd66d1674eaf9801833197e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1a07c4cad283687f96d83edd56f2b8446318bf9bdd66d1674eaf9801833197e", kill_on_drop: false }` [INFO] [stdout] f1a07c4cad283687f96d83edd56f2b8446318bf9bdd66d1674eaf9801833197e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d31123557cf3b60756361ef77e203152a088d43b0dd7e181c45aaf41c5418578 [INFO] running `Command { std: "docker" "start" "-a" "d31123557cf3b60756361ef77e203152a088d43b0dd7e181c45aaf41c5418578", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking gix-trace v0.1.17 [INFO] [stderr] Checking zlib-rs v0.5.5 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking jiff v0.2.19 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Compiling io-lifetimes v2.0.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking gix-sec v0.13.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling io-extras v0.18.4 [INFO] [stderr] Compiling cap-primitives v3.4.5 [INFO] [stderr] Checking sha1-checked v0.10.0 [INFO] [stderr] Checking gix-utils v0.3.1 [INFO] [stderr] Checking clru v0.6.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking arc-swap v1.8.1 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Compiling cap-std v3.4.5 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking ambient-authority v0.0.2 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking clap_builder v4.5.57 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking prodash v31.0.0 [INFO] [stderr] Checking faster-hex v0.10.0 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking gix-validate v0.11.0 [INFO] [stderr] Checking gix-error v0.0.0 [INFO] [stderr] Checking gix-chunk v0.5.0 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking fs-set-times v0.20.3 [INFO] [stderr] Checking rustix-linux-procfs v0.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling maybe-async v0.2.10 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking gix-date v0.13.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking gix-path v0.11.0 [INFO] [stderr] Checking gix-actor v0.38.0 [INFO] [stderr] Checking gix-quote v0.6.1 [INFO] [stderr] Checking gix-packetline v0.21.0 [INFO] [stderr] Checking gix-bitmap v0.2.15 [INFO] [stderr] Checking gix-features v0.46.0 [INFO] [stderr] Checking gix-command v0.7.0 [INFO] [stderr] Checking gix-url v0.35.0 [INFO] [stderr] Checking gix-config-value v0.17.0 [INFO] [stderr] Checking gix-hash v0.22.0 [INFO] [stderr] Checking gix-fs v0.19.0 [INFO] [stderr] Checking gix-glob v0.24.0 [INFO] [stderr] Checking gix-transport v0.53.0 [INFO] [stderr] Checking clap v4.5.57 [INFO] [stderr] Checking gix-hashtable v0.12.0 [INFO] [stderr] Checking gix-commitgraph v0.32.0 [INFO] [stderr] Checking gix-tempfile v21.0.0 [INFO] [stderr] Checking gix-object v0.55.0 [INFO] [stderr] Checking gix-lock v21.0.0 [INFO] [stderr] Checking gix-shallow v0.8.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking gix-revwalk v0.26.0 [INFO] [stderr] Checking gix-ref v0.58.0 [INFO] [stderr] Checking gix-pack v0.65.0 [INFO] [stderr] Checking gix-diff v0.58.0 [INFO] [stderr] Checking gix-revision v0.40.0 [INFO] [stderr] Checking gix-traverse v0.52.0 [INFO] [stderr] Checking gix-index v0.46.0 [INFO] [stderr] Checking gix-refspec v0.36.0 [INFO] [stderr] Checking gix-protocol v0.56.0 [INFO] [stderr] Checking gix-discover v0.46.0 [INFO] [stderr] Checking gix-config v0.51.0 [INFO] [stderr] Checking gix-odb v0.75.0 [INFO] [stderr] Checking gix v0.78.0 [INFO] [stderr] Checking git-cloak v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `NotARepo` is never constructed [INFO] [stdout] --> src/git_utils.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub enum GitUtilError { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 12 | #[error("not a git repository")] [INFO] [stdout] 13 | NotARepo, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitUtilError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ProjectNotFound` is never constructed [INFO] [stdout] --> src/store.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub enum StoreError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 30 | ProjectNotFound(String), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StoreError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/git_utils.rs:23:33 [INFO] [stdout] | [INFO] [stdout] 17 | Discover(#[from] gix::discover::Error), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn repo_root(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `git_utils::GitUtilError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/git_utils.rs:30:36 [INFO] [stdout] | [INFO] [stdout] 17 | Discover(#[from] gix::discover::Error), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn exclude_path(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `git_utils::GitUtilError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/git_utils.rs:47:6 [INFO] [stdout] | [INFO] [stdout] 17 | Discover(#[from] gix::discover::Error), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 47 | ) -> Result<(), GitUtilError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `git_utils::GitUtilError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/git_utils.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / if let Some(parent) = rel_path.parent() { [INFO] [stdout] 76 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 77 | | dir.create_dir_all(parent).map_err(io_err)?; [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ if let Some(parent) = rel_path.parent() [INFO] [stdout] 76 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 77 | dir.create_dir_all(parent).map_err(io_err)?; [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/git_utils.rs:93:6 [INFO] [stdout] | [INFO] [stdout] 17 | Discover(#[from] gix::discover::Error), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 93 | ) -> Result<(), GitUtilError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `git_utils::GitUtilError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> src/git_utils.rs:139:29 [INFO] [stdout] | [INFO] [stdout] 139 | let after_end = content[after_end..] [INFO] [stdout] | _____________________________^ [INFO] [stdout] 140 | | .starts_with('\n') [INFO] [stdout] 141 | | .then(|| after_end + 1) [INFO] [stdout] 142 | | .unwrap_or(after_end); [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] = note: `#[warn(clippy::obfuscated_if_else)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 139 ~ let after_end = if content[after_end..] [INFO] [stdout] 140 ~ .starts_with('\n') { after_end + 1 } else { after_end }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 59 | fn resolve() -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ops.rs:78:35 [INFO] [stdout] | [INFO] [stdout] 78 | if repo_root.is_some() && !repo_dir.symlink_metadata(".git").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `repo_dir.symlink_metadata(".git").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NotARepo` is never constructed [INFO] [stdout] --> src/git_utils.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub enum GitUtilError { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 12 | #[error("not a git repository")] [INFO] [stdout] 13 | NotARepo, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitUtilError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ProjectNotFound` is never constructed [INFO] [stdout] --> src/store.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub enum StoreError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 30 | ProjectNotFound(String), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StoreError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:119:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 119 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:137:43 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 137 | fn validate_target_path(target: &Path) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:217:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 217 | ) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/git_utils.rs:23:33 [INFO] [stdout] | [INFO] [stdout] 17 | Discover(#[from] gix::discover::Error), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn repo_root(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `git_utils::GitUtilError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/git_utils.rs:30:36 [INFO] [stdout] | [INFO] [stdout] 17 | Discover(#[from] gix::discover::Error), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn exclude_path(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `git_utils::GitUtilError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/ops.rs:241:17 [INFO] [stdout] | [INFO] [stdout] 241 | source: std::io::Error::new(std::io::ErrorKind::Other, "Failed to rename file"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 241 - source: std::io::Error::new(std::io::ErrorKind::Other, "Failed to rename file"), [INFO] [stdout] 241 + source: std::io::Error::other("Failed to rename file"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:255:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 255 | ) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/git_utils.rs:47:6 [INFO] [stdout] | [INFO] [stdout] 17 | Discover(#[from] gix::discover::Error), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 47 | ) -> Result<(), GitUtilError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `git_utils::GitUtilError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/git_utils.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / if let Some(parent) = rel_path.parent() { [INFO] [stdout] 76 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 77 | | dir.create_dir_all(parent).map_err(io_err)?; [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ if let Some(parent) = rel_path.parent() [INFO] [stdout] 76 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 77 | dir.create_dir_all(parent).map_err(io_err)?; [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ops.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | / if let Some(parent) = target_path.parent() { [INFO] [stdout] 269 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 270 | | repo_dir [INFO] [stdout] 271 | | .create_dir_all(parent) [INFO] [stdout] ... | [INFO] [stdout] 274 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 268 ~ if let Some(parent) = target_path.parent() [INFO] [stdout] 269 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 270 | repo_dir [INFO] [stdout] 271 | .create_dir_all(parent) [INFO] [stdout] 272 | .map_err(|e| io_err(&repo_root.join(parent), e))?; [INFO] [stdout] 273 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/git_utils.rs:93:6 [INFO] [stdout] | [INFO] [stdout] 17 | Discover(#[from] gix::discover::Error), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 93 | ) -> Result<(), GitUtilError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `git_utils::GitUtilError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:305:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 305 | ) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:329:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 329 | ) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ops.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | / if let Some(parent) = dst_rel.parent() { [INFO] [stdout] 332 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 333 | | dst_dir [INFO] [stdout] 334 | | .create_dir_all(parent) [INFO] [stdout] ... | [INFO] [stdout] 337 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 331 ~ if let Some(parent) = dst_rel.parent() [INFO] [stdout] 332 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 333 | dst_dir [INFO] [stdout] 334 | .create_dir_all(parent) [INFO] [stdout] 335 | .map_err(|e| io_err(&abs_dst_base.join(parent), e))?; [INFO] [stdout] 336 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:366:58 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 366 | pub fn track(file: &Path, target_path: Option<&Path>) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> src/git_utils.rs:139:29 [INFO] [stdout] | [INFO] [stdout] 139 | let after_end = content[after_end..] [INFO] [stdout] | _____________________________^ [INFO] [stdout] 140 | | .starts_with('\n') [INFO] [stdout] 141 | | .then(|| after_end + 1) [INFO] [stdout] 142 | | .unwrap_or(after_end); [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] = note: `#[warn(clippy::obfuscated_if_else)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 139 ~ let after_end = if content[after_end..] [INFO] [stdout] 140 ~ .starts_with('\n') { after_end + 1 } else { after_end }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:449:43 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 449 | pub fn untrack(file_in_project: &Path) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:514:20 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 514 | pub fn inject() -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:551:19 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 551 | pub fn eject() -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:591:20 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 591 | pub fn status() -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:638:22 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 638 | pub fn projects() -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/ops.rs:647:26 [INFO] [stdout] | [INFO] [stdout] 647 | for (_pid, entry) in &index.projects { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 647 - for (_pid, entry) in &index.projects { [INFO] [stdout] 647 + for entry in index.projects.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 59 | fn resolve() -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ops.rs:78:35 [INFO] [stdout] | [INFO] [stdout] 78 | if repo_root.is_some() && !repo_dir.symlink_metadata(".git").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `repo_dir.symlink_metadata(".git").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:119:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 119 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:137:43 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 137 | fn validate_target_path(target: &Path) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/pid.rs:83:31 [INFO] [stdout] | [INFO] [stdout] 70 | GitDiscover(#[from] gix::discover::Error), [INFO] [stdout] | ----------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 83 | pub fn compute(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pid::PidError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/pid.rs:95:39 [INFO] [stdout] | [INFO] [stdout] 70 | GitDiscover(#[from] gix::discover::Error), [INFO] [stdout] | ----------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 95 | pub fn compute_git_pid(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pid::PidError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:217:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 217 | ) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/pid.rs:128:40 [INFO] [stdout] | [INFO] [stdout] 70 | GitDiscover(#[from] gix::discover::Error), [INFO] [stdout] | ----------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 128 | pub fn compute_path_pid(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pid::PidError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/ops.rs:241:17 [INFO] [stdout] | [INFO] [stdout] 241 | source: std::io::Error::new(std::io::ErrorKind::Other, "Failed to rename file"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 241 - source: std::io::Error::new(std::io::ErrorKind::Other, "Failed to rename file"), [INFO] [stdout] 241 + source: std::io::Error::other("Failed to rename file"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:255:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 255 | ) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ops.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | / if let Some(parent) = target_path.parent() { [INFO] [stdout] 269 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 270 | | repo_dir [INFO] [stdout] 271 | | .create_dir_all(parent) [INFO] [stdout] ... | [INFO] [stdout] 274 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 268 ~ if let Some(parent) = target_path.parent() [INFO] [stdout] 269 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 270 | repo_dir [INFO] [stdout] 271 | .create_dir_all(parent) [INFO] [stdout] 272 | .map_err(|e| io_err(&repo_root.join(parent), e))?; [INFO] [stdout] 273 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:305:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 305 | ) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:329:6 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 329 | ) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ops.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | / if let Some(parent) = dst_rel.parent() { [INFO] [stdout] 332 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 333 | | dst_dir [INFO] [stdout] 334 | | .create_dir_all(parent) [INFO] [stdout] ... | [INFO] [stdout] 337 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 331 ~ if let Some(parent) = dst_rel.parent() [INFO] [stdout] 332 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 333 | dst_dir [INFO] [stdout] 334 | .create_dir_all(parent) [INFO] [stdout] 335 | .map_err(|e| io_err(&abs_dst_base.join(parent), e))?; [INFO] [stdout] 336 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:366:58 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 366 | pub fn track(file: &Path, target_path: Option<&Path>) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:449:43 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 449 | pub fn untrack(file_in_project: &Path) -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/store.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / impl Default for GlobalIndex { [INFO] [stdout] 62 | | fn default() -> Self { [INFO] [stdout] 63 | | Self { [INFO] [stdout] 64 | | projects: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 57 + #[derive(Default)] [INFO] [stdout] 58 | pub struct GlobalIndex { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:514:20 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 514 | pub fn inject() -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:551:19 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 551 | pub fn eject() -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:591:20 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 591 | pub fn status() -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ops.rs:638:22 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 638 | pub fn projects() -> Result<(), CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/ops.rs:647:26 [INFO] [stdout] | [INFO] [stdout] 647 | for (_pid, entry) in &index.projects { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 647 - for (_pid, entry) in &index.projects { [INFO] [stdout] 647 + for entry in index.projects.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/pid.rs:83:31 [INFO] [stdout] | [INFO] [stdout] 70 | GitDiscover(#[from] gix::discover::Error), [INFO] [stdout] | ----------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 83 | pub fn compute(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pid::PidError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/pid.rs:95:39 [INFO] [stdout] | [INFO] [stdout] 70 | GitDiscover(#[from] gix::discover::Error), [INFO] [stdout] | ----------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 95 | pub fn compute_git_pid(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pid::PidError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/pid.rs:128:40 [INFO] [stdout] | [INFO] [stdout] 70 | GitDiscover(#[from] gix::discover::Error), [INFO] [stdout] | ----------------------------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 128 | pub fn compute_path_pid(dir: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pid::PidError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/store.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / impl Default for GlobalIndex { [INFO] [stdout] 62 | | fn default() -> Self { [INFO] [stdout] 63 | | Self { [INFO] [stdout] 64 | | projects: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 57 + #[derive(Default)] [INFO] [stdout] 58 | pub struct GlobalIndex { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/main.rs:64:27 [INFO] [stdout] | [INFO] [stdout] 64 | fn run(cmd: &Commands) -> Result<(), ops::CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/ops.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/main.rs:64:27 [INFO] [stdout] | [INFO] [stdout] 64 | fn run(cmd: &Commands) -> Result<(), ops::CloakError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/ops.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Pid(#[from] PidError), [INFO] [stdout] | --------------------- the largest variant contains at least 128 bytes [INFO] [stdout] ... [INFO] [stdout] 18 | GitUtil(#[from] GitUtilError), [INFO] [stdout] | ----------------------------- the variant `GitUtil` contains at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ops::CloakError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.88s [INFO] running `Command { std: "docker" "inspect" "d31123557cf3b60756361ef77e203152a088d43b0dd7e181c45aaf41c5418578", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d31123557cf3b60756361ef77e203152a088d43b0dd7e181c45aaf41c5418578", kill_on_drop: false }` [INFO] [stdout] d31123557cf3b60756361ef77e203152a088d43b0dd7e181c45aaf41c5418578