[INFO] fetching crate gfaR 0.1.3... [INFO] linting gfaR-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gfaR 0.1.3 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate gfaR 0.1.3 [INFO] finished tweaking crates.io crate gfaR 0.1.3 [INFO] tweaked toml for crates.io crate gfaR 0.1.3 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gfaR 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0d677217fe5beb4a333a3ddeaf6cf8dda5b7002d6f6cd20a09b275f5789f2d5 [INFO] running `Command { std: "docker" "start" "-a" "f0d677217fe5beb4a333a3ddeaf6cf8dda5b7002d6f6cd20a09b275f5789f2d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0d677217fe5beb4a333a3ddeaf6cf8dda5b7002d6f6cd20a09b275f5789f2d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0d677217fe5beb4a333a3ddeaf6cf8dda5b7002d6f6cd20a09b275f5789f2d5", kill_on_drop: false }` [INFO] [stdout] f0d677217fe5beb4a333a3ddeaf6cf8dda5b7002d6f6cd20a09b275f5789f2d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ea4fc43baf084c320f96c1433b8b38597311d27aa4cebb5f8c84a29607d11fae [INFO] running `Command { std: "docker" "start" "-a" "ea4fc43baf084c320f96c1433b8b38597311d27aa4cebb5f8c84a29607d11fae", kill_on_drop: false }` [INFO] [stderr] Checking gfaR v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/lib.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / #[cfg(test)] [INFO] [stdout] 7 | | [INFO] [stdout] | |_^ [INFO] [stdout] 8 | pub fn counter(start: i32, end: i32){ [INFO] [stdout] | -------------- the attribute applies to this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | nodes: nodes, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | paths: paths, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | edges: edges, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:78:44 [INFO] [stdout] | [INFO] [stdout] 78 | self.paths.push(Path { name: name, dir: dirs, nodes: nodd }); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | nodes: nodes, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | paths: paths, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | edges: edges, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:78:44 [INFO] [stdout] | [INFO] [stdout] 78 | self.paths.push(Path { name: name, dir: dirs, nodes: nodd }); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Gfa` [INFO] [stdout] --> src/lib.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / pub fn new() -> Self { [INFO] [stdout] 50 | | let nodes: HashMap = HashMap::new(); [INFO] [stdout] 51 | | let paths: Vec = Vec::new(); [INFO] [stdout] 52 | | let edges: Vec = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 48 + impl Default for Gfa { [INFO] [stdout] 49 + fn default() -> Self { [INFO] [stdout] 50 + Self::new() [INFO] [stdout] 51 + } [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:154 [INFO] [stdout] | [INFO] [stdout] 80 | ...rse().unwrap(), from_dir: if line_split[2] == "+" { !false } else { !true }, to_dir: if line_split[4] == "+" { !false } else { !t... [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:170 [INFO] [stdout] | [INFO] [stdout] 80 | ...from_dir: if line_split[2] == "+" { !false } else { !true }, to_dir: if line_split[4] == "+" { !false } else { !true } }) [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:213 [INFO] [stdout] | [INFO] [stdout] 80 | ...} else { !true }, to_dir: if line_split[4] == "+" { !false } else { !true } }) [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:229 [INFO] [stdout] | [INFO] [stdout] 80 | ..., to_dir: if line_split[4] == "+" { !false } else { !true } }) [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:76:106 [INFO] [stdout] | [INFO] [stdout] 76 | ... let dirs: Vec = line_split[2].split(",").map(|d| if &d[d.len() - 1..] == "+" { !false } else { !true }).collect(); [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:76:122 [INFO] [stdout] | [INFO] [stdout] 76 | ...p(|d| if &d[d.len() - 1..] == "+" { !false } else { !true }).collect(); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Gfa` [INFO] [stdout] --> src/lib.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / pub fn new() -> Self { [INFO] [stdout] 50 | | let nodes: HashMap = HashMap::new(); [INFO] [stdout] 51 | | let paths: Vec = Vec::new(); [INFO] [stdout] 52 | | let edges: Vec = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 48 + impl Default for Gfa { [INFO] [stdout] 49 + fn default() -> Self { [INFO] [stdout] 50 + Self::new() [INFO] [stdout] 51 + } [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:154 [INFO] [stdout] | [INFO] [stdout] 80 | ...rse().unwrap(), from_dir: if line_split[2] == "+" { !false } else { !true }, to_dir: if line_split[4] == "+" { !false } else { !t... [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:170 [INFO] [stdout] | [INFO] [stdout] 80 | ...from_dir: if line_split[2] == "+" { !false } else { !true }, to_dir: if line_split[4] == "+" { !false } else { !true } }) [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:213 [INFO] [stdout] | [INFO] [stdout] 80 | ...} else { !true }, to_dir: if line_split[4] == "+" { !false } else { !true } }) [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:229 [INFO] [stdout] | [INFO] [stdout] 80 | ..., to_dir: if line_split[4] == "+" { !false } else { !true } }) [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `gfaR` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `gfa_r` [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:76:106 [INFO] [stdout] | [INFO] [stdout] 76 | ... let dirs: Vec = line_split[2].split(",").map(|d| if &d[d.len() - 1..] == "+" { !false } else { !true }).collect(); [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:76:122 [INFO] [stdout] | [INFO] [stdout] 76 | ...p(|d| if &d[d.len() - 1..] == "+" { !false } else { !true }).collect(); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> tests/test1.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let n: Node = Node { id: "dsadka".to_owned(), len: 10 , seq: "AAT".to_owned()}; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `Command { std: "docker" "inspect" "ea4fc43baf084c320f96c1433b8b38597311d27aa4cebb5f8c84a29607d11fae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea4fc43baf084c320f96c1433b8b38597311d27aa4cebb5f8c84a29607d11fae", kill_on_drop: false }` [INFO] [stdout] ea4fc43baf084c320f96c1433b8b38597311d27aa4cebb5f8c84a29607d11fae