[INFO] fetching crate genotype_project 0.14.0... [INFO] linting genotype_project-0.14.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate genotype_project 0.14.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate genotype_project 0.14.0 [INFO] finished tweaking crates.io crate genotype_project 0.14.0 [INFO] tweaked toml for crates.io crate genotype_project 0.14.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate genotype_project 0.14.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate genotype_project 0.14.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num_cpus v1.16.0 [INFO] [stderr] Downloaded genotype_lang_core_config v0.14.0 [INFO] [stderr] Downloaded hermit-abi v0.3.9 [INFO] [stderr] Downloaded thiserror-impl v1.0.64 [INFO] [stderr] Downloaded is_ci v1.2.0 [INFO] [stderr] Downloaded pear_codegen v0.2.9 [INFO] [stderr] Downloaded genotype_path v0.14.0 [INFO] [stderr] Downloaded proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Downloaded genotype_lang_py_config v0.14.0 [INFO] [stderr] Downloaded atomic v0.6.0 [INFO] [stderr] Downloaded pear v0.2.9 [INFO] [stderr] Downloaded clap v4.5.20 [INFO] [stderr] Downloaded bytemuck v1.19.0 [INFO] [stderr] Downloaded ucd-trie v0.1.6 [INFO] [stderr] Downloaded figment v0.10.19 [INFO] [stderr] Downloaded indexmap v2.11.0 [INFO] [stderr] Downloaded winnow v0.7.9 [INFO] [stderr] Downloaded toml_edit v0.22.26 [INFO] [stderr] Downloaded clap_builder v4.5.20 [INFO] [stderr] Downloaded hashbrown v0.15.0 [INFO] [stderr] Downloaded miette v7.2.0 [INFO] [stderr] Downloaded pest v2.8.1 [INFO] [stderr] Downloaded cc v1.1.8 [INFO] [stderr] Downloaded syn v2.0.87 [INFO] [stderr] Downloaded gimli v0.29.0 [INFO] [stderr] Downloaded backtrace v0.3.73 [INFO] [stderr] Downloaded pest_meta v2.8.1 [INFO] [stderr] Downloaded object v0.36.3 [INFO] [stderr] Downloaded miniz_oxide v0.7.4 [INFO] [stderr] Downloaded miette-derive v7.2.0 [INFO] [stderr] Downloaded yansi v1.0.1 [INFO] [stderr] Downloaded toml v0.8.22 [INFO] [stderr] Downloaded genotype_parser v0.14.0 [INFO] [stderr] Downloaded addr2line v0.22.0 [INFO] [stderr] Downloaded owo-colors v4.1.0 [INFO] [stderr] Downloaded textwrap v0.16.1 [INFO] [stderr] Downloaded pretty_assertions v1.4.1 [INFO] [stderr] Downloaded delegate v0.13.3 [INFO] [stderr] Downloaded toml_write v0.1.1 [INFO] [stderr] Downloaded sha2 v0.10.8 [INFO] [stderr] Downloaded crossbeam-utils v0.8.20 [INFO] [stderr] Downloaded proc-macro2 v1.0.89 [INFO] [stderr] Downloaded uncased v0.9.10 [INFO] [stderr] Downloaded genotype_lang_rs_config v0.14.0 [INFO] [stderr] Downloaded pest_derive v2.8.1 [INFO] [stderr] Downloaded supports-color v3.0.1 [INFO] [stderr] Downloaded supports-hyperlinks v3.0.0 [INFO] [stderr] Downloaded diff v0.1.13 [INFO] [stderr] Downloaded inlinable_string v0.1.15 [INFO] [stderr] Downloaded genotype_config v0.14.0 [INFO] [stderr] Downloaded genotype_visitor v0.14.0 [INFO] [stderr] Downloaded backtrace-ext v0.2.1 [INFO] [stderr] Downloaded supports-unicode v3.0.0 [INFO] [stderr] Downloaded unicode-linebreak v0.1.5 [INFO] [stderr] Downloaded toml_datetime v0.6.9 [INFO] [stderr] Downloaded pest_generator v2.8.1 [INFO] [stderr] Downloaded smawk v0.3.2 [INFO] [stderr] Downloaded genotype_lang_ts_config v0.14.0 [INFO] [stderr] Downloaded thiserror v1.0.64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d05ded2271a6fdde060048a9c15ddbe9e0e6229488a8a289f122fc0081e1adcb [INFO] running `Command { std: "docker" "start" "-a" "d05ded2271a6fdde060048a9c15ddbe9e0e6229488a8a289f122fc0081e1adcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d05ded2271a6fdde060048a9c15ddbe9e0e6229488a8a289f122fc0081e1adcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d05ded2271a6fdde060048a9c15ddbe9e0e6229488a8a289f122fc0081e1adcb", kill_on_drop: false }` [INFO] [stdout] d05ded2271a6fdde060048a9c15ddbe9e0e6229488a8a289f122fc0081e1adcb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 92656e92e26cdd707da1e41242247d0ad33e74b633d40578788623184b824a93 [INFO] running `Command { std: "docker" "start" "-a" "92656e92e26cdd707da1e41242247d0ad33e74b633d40578788623184b824a93", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking hashbrown v0.15.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking object v0.36.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling owo-colors v4.1.0 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking indexmap v2.11.0 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking supports-color v3.0.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking winnow v0.7.9 [INFO] [stderr] Checking toml_write v0.1.1 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling yansi v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling figment v0.10.19 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking inlinable_string v0.1.15 [INFO] [stderr] Checking clap_builder v4.5.20 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v4.5.20 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling delegate v0.13.3 [INFO] [stderr] Compiling pear_codegen v0.2.9 [INFO] [stderr] Checking pear v0.2.9 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Compiling pest v2.8.1 [INFO] [stderr] Compiling pest_meta v2.8.1 [INFO] [stderr] Compiling pest_generator v2.8.1 [INFO] [stderr] Compiling pest_derive v2.8.1 [INFO] [stderr] Checking toml_datetime v0.6.9 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking relative-path v1.9.3 [INFO] [stderr] Checking toml_edit v0.22.26 [INFO] [stderr] Checking toml v0.8.22 [INFO] [stderr] Checking genotype_parser v0.14.0 [INFO] [stderr] Checking genotype_path v0.14.0 [INFO] [stderr] Checking genotype_visitor v0.14.0 [INFO] [stderr] Checking genotype_lang_core_config v0.14.0 [INFO] [stderr] Checking genotype_lang_ts_config v0.14.0 [INFO] [stderr] Checking genotype_lang_py_config v0.14.0 [INFO] [stderr] Checking genotype_lang_rs_config v0.14.0 [INFO] [stderr] Checking genotype_config v0.14.0 [INFO] [stderr] Checking genotype_project v0.14.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `GtSrcRelativePath` [INFO] [stdout] --> src/module/mod.rs:2:35 [INFO] [stdout] | [INFO] [stdout] 2 | use genotype_path::{GtModulePath, GtSrcRelativePath}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/prelude/internal.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GtSrcRelativePath` [INFO] [stdout] --> src/module/mod.rs:2:35 [INFO] [stdout] | [INFO] [stdout] 2 | use genotype_path::{GtModulePath, GtSrcRelativePath}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/prelude/internal.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `genotype_parser::GTModuleParse::source_code` [INFO] [stdout] --> src/module/mod.rs:39:49 [INFO] [stdout] | [INFO] [stdout] 39 | .map_err(|err| err.with_source_code(parse.1.source_code.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `module::GtProjectModule::source_code` [INFO] [stdout] --> src/module/mod.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | source_code: parse.1.source_code.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `genotype_parser::GTModuleParse::source_code` [INFO] [stdout] --> src/module/mod.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | source_code: parse.1.source_code.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `genotype_path::GtRelativePath` [INFO] [stdout] --> src/module/resolve.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use genotype_path::GtRelativePath; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `genotype_parser::GTModuleParse::source_code` [INFO] [stdout] --> src/module/mod.rs:39:49 [INFO] [stdout] | [INFO] [stdout] 39 | .map_err(|err| err.with_source_code(parse.1.source_code.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `module::GtProjectModule::source_code` [INFO] [stdout] --> src/module/mod.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | source_code: parse.1.source_code.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `genotype_parser::GTModuleParse::source_code` [INFO] [stdout] --> src/module/mod.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | source_code: parse.1.source_code.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `module::GtProjectModule::source_code` [INFO] [stdout] --> src/project.rs:341:21 [INFO] [stdout] | [INFO] [stdout] 341 | / source_code: NamedSource::new( [INFO] [stdout] 342 | | "anonymous.type", [INFO] [stdout] 343 | | read_to_string( [INFO] [stdout] 344 | | config.src_path().join(&module_path.clone().into()).as_str() [INFO] [stdout] 345 | | ) [INFO] [stdout] 346 | | .unwrap(), [INFO] [stdout] 347 | | ), [INFO] [stdout] | |_____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `module::GtProjectModule::source_code` [INFO] [stdout] --> src/project.rs:398:21 [INFO] [stdout] | [INFO] [stdout] 398 | / source_code: NamedSource::new( [INFO] [stdout] 399 | | "author.type", [INFO] [stdout] 400 | | read_to_string( [INFO] [stdout] 401 | | config.src_path().join(&author_path.clone().into()).as_str(), [INFO] [stdout] 402 | | ) [INFO] [stdout] 403 | | .unwrap(), [INFO] [stdout] 404 | | ), [INFO] [stdout] | |_____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `module::GtProjectModule::source_code` [INFO] [stdout] --> src/project.rs:488:21 [INFO] [stdout] | [INFO] [stdout] 488 | / source_code: NamedSource::new( [INFO] [stdout] 489 | | "book.type", [INFO] [stdout] 490 | | read_to_string(config.src_path().join(&book_path.clone().into()).as_str()) [INFO] [stdout] 491 | | .unwrap(), [INFO] [stdout] 492 | | ), [INFO] [stdout] | |_____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `module::GtProjectModule::source_code` [INFO] [stdout] --> src/project.rs:586:21 [INFO] [stdout] | [INFO] [stdout] 586 | / source_code: NamedSource::new( [INFO] [stdout] 587 | | "order.type", [INFO] [stdout] 588 | | read_to_string(config.src_path().join(&order_path.into()).as_str()) [INFO] [stdout] 589 | | .unwrap(), [INFO] [stdout] 590 | | ), [INFO] [stdout] | |_____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `module::GtProjectModule::source_code` [INFO] [stdout] --> src/project.rs:634:21 [INFO] [stdout] | [INFO] [stdout] 634 | / source_code: NamedSource::new( [INFO] [stdout] 635 | | "user.type", [INFO] [stdout] 636 | | read_to_string(config.src_path().join(&user_path.into()).as_str()).unwrap(), [INFO] [stdout] 637 | | ), [INFO] [stdout] | |_____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/module/parse.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | impl<'a> GTProjectModuleParse { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `genotype_path::GtRelativePath` [INFO] [stdout] --> src/module/resolve.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use genotype_path::GtRelativePath; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/module/resolve.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | modules: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 - modules: &Vec, [INFO] [stdout] 27 + modules: &[GTProjectModuleParse], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/module/resolve.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 128 | !import.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `import.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/module/mod.rs:43:77 [INFO] [stdout] | [INFO] [stdout] 43 | let mut visitor = GTPResolveVisitor::new(parse.1.module.id.clone(), &project_resolve); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `project_resolve` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/project.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 31 | / path.strip_prefix(src_path.relative_path().normalize()) [INFO] [stdout] 32 | | .map_err(|_| GTProjectError::Unknown) [INFO] [stdout] 33 | | .and_then(|path| Ok(GtModulePath::new(path.into()))) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ path.strip_prefix(src_path.relative_path().normalize()) [INFO] [stdout] 32 + .map_err(|_| GTProjectError::Unknown).map(|path| GtModulePath::new(path.into())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/project.rs:78:52 [INFO] [stdout] | [INFO] [stdout] 78 | modules.sort_by(|a, b| a.path.as_str().cmp(&b.path.as_str())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `b.path.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/project.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / parse.deps().and_then(|deps| { [INFO] [stdout] 101 | | // Iterate each module dependency and load it in a thread. [INFO] [stdout] 102 | | for dep in deps { [INFO] [stdout] 103 | | let config = Arc::clone(&config); [INFO] [stdout] ... | [INFO] [stdout] 118 | | Ok(()) [INFO] [stdout] 119 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 100 ~ parse.deps().map(|deps| { [INFO] [stdout] 101 | // Iterate each module dependency and load it in a thread. [INFO] [stdout] ... [INFO] [stdout] 117 | [INFO] [stdout] 118 ~ () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/resolve/visitor.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / self.definitions [INFO] [stdout] 23 | | .get(&self.module_id) [INFO] [stdout] 24 | | .and_then(|references| Some(references.clone())) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 ~ self.definitions [INFO] [stdout] 23 + .get(&self.module_id).map(|references| references.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/resolve/mod.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 72 | .or_insert(Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/resolve/mod.rs:97:26 [INFO] [stdout] | [INFO] [stdout] 97 | .or_insert(Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/module/parse.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | impl<'a> GTProjectModuleParse { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/module/resolve.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | modules: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 - modules: &Vec, [INFO] [stdout] 27 + modules: &[GTProjectModuleParse], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/module/resolve.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 128 | !import.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `import.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/module/mod.rs:43:77 [INFO] [stdout] | [INFO] [stdout] 43 | let mut visitor = GTPResolveVisitor::new(parse.1.module.id.clone(), &project_resolve); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `project_resolve` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/project.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 31 | / path.strip_prefix(src_path.relative_path().normalize()) [INFO] [stdout] 32 | | .map_err(|_| GTProjectError::Unknown) [INFO] [stdout] 33 | | .and_then(|path| Ok(GtModulePath::new(path.into()))) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ path.strip_prefix(src_path.relative_path().normalize()) [INFO] [stdout] 32 + .map_err(|_| GTProjectError::Unknown).map(|path| GtModulePath::new(path.into())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/project.rs:78:52 [INFO] [stdout] | [INFO] [stdout] 78 | modules.sort_by(|a, b| a.path.as_str().cmp(&b.path.as_str())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `b.path.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/project.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / parse.deps().and_then(|deps| { [INFO] [stdout] 101 | | // Iterate each module dependency and load it in a thread. [INFO] [stdout] 102 | | for dep in deps { [INFO] [stdout] 103 | | let config = Arc::clone(&config); [INFO] [stdout] ... | [INFO] [stdout] 118 | | Ok(()) [INFO] [stdout] 119 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 100 ~ parse.deps().map(|deps| { [INFO] [stdout] 101 | // Iterate each module dependency and load it in a thread. [INFO] [stdout] ... [INFO] [stdout] 117 | [INFO] [stdout] 118 ~ () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/project.rs:640:21 [INFO] [stdout] | [INFO] [stdout] 640 | config: &config, [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/resolve/visitor.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / self.definitions [INFO] [stdout] 23 | | .get(&self.module_id) [INFO] [stdout] 24 | | .and_then(|references| Some(references.clone())) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 ~ self.definitions [INFO] [stdout] 23 + .get(&self.module_id).map(|references| references.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/resolve/mod.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 72 | .or_insert(Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/resolve/mod.rs:97:26 [INFO] [stdout] | [INFO] [stdout] 97 | .or_insert(Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.12s [INFO] running `Command { std: "docker" "inspect" "92656e92e26cdd707da1e41242247d0ad33e74b633d40578788623184b824a93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92656e92e26cdd707da1e41242247d0ad33e74b633d40578788623184b824a93", kill_on_drop: false }` [INFO] [stdout] 92656e92e26cdd707da1e41242247d0ad33e74b633d40578788623184b824a93