[INFO] fetching crate genetic-algorithm-fn 0.1.0... [INFO] linting genetic-algorithm-fn-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate genetic-algorithm-fn 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate genetic-algorithm-fn 0.1.0 [INFO] finished tweaking crates.io crate genetic-algorithm-fn 0.1.0 [INFO] tweaked toml for crates.io crate genetic-algorithm-fn 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate genetic-algorithm-fn 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate genetic-algorithm-fn 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ppv-lite86 v0.2.16 [INFO] [stderr] Downloaded crossbeam-utils v0.8.7 [INFO] [stderr] Downloaded rand_core v0.6.3 [INFO] [stderr] Downloaded genetic-algorithm-traits v0.1.0 [INFO] [stderr] Downloaded getrandom v0.2.4 [INFO] [stderr] Downloaded wasi v0.10.2+wasi-snapshot-preview1 [INFO] [stderr] Downloaded libc v0.2.119 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aae73ae228a86f065b0173cbe1dd7a70f7a64480b80002c0bc342c2eb6df6674 [INFO] running `Command { std: "docker" "start" "-a" "aae73ae228a86f065b0173cbe1dd7a70f7a64480b80002c0bc342c2eb6df6674", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aae73ae228a86f065b0173cbe1dd7a70f7a64480b80002c0bc342c2eb6df6674", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aae73ae228a86f065b0173cbe1dd7a70f7a64480b80002c0bc342c2eb6df6674", kill_on_drop: false }` [INFO] [stdout] aae73ae228a86f065b0173cbe1dd7a70f7a64480b80002c0bc342c2eb6df6674 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 642fa2c539513349ca15ad0e564ace00290fae2564ea03db8bb4b1e1eafab4b0 [INFO] running `Command { std: "docker" "start" "-a" "642fa2c539513349ca15ad0e564ace00290fae2564ea03db8bb4b1e1eafab4b0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking genetic-algorithm-traits v0.1.0 [INFO] [stderr] Checking getrandom v0.2.4 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking genetic-algorithm-fn v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/solution.rs:456:13 [INFO] [stdout] | [INFO] [stdout] 456 | #[test] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(duplicate_macro_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/solution.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | #[test] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/solution.rs:458:13 [INFO] [stdout] | [INFO] [stdout] 458 | #[test] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/solution.rs:459:13 [INFO] [stdout] | [INFO] [stdout] 459 | #[test] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/solution.rs:460:13 [INFO] [stdout] | [INFO] [stdout] 460 | #[test] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/test_functions.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/test_functions.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/test_functions.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/test_functions.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | mod test_full_function { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/test_functions.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/test_functions.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | mod test_inner_function { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `triple_multiplication` is never used [INFO] [stdout] --> src/test_objects.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn triple_multiplication() -> fn(Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).all(identity)` [INFO] [stdout] --> src/solution.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|(self_value, other_value)| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 82 | | f64_to_floating_point_precision_string(*self_value) [INFO] [stdout] 83 | | == f64_to_floating_point_precision_string(*other_value) [INFO] [stdout] 84 | | }) [INFO] [stdout] 85 | | .all(|elem| elem)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.all(...)` instead [INFO] [stdout] | [INFO] [stdout] 81 ~ .all(|(self_value, other_value)| { [INFO] [stdout] 82 + f64_to_floating_point_precision_string(*self_value) [INFO] [stdout] 83 + == f64_to_floating_point_precision_string(*other_value) [INFO] [stdout] 84 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/solution.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | /// solution's arguments. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 256 | /// solution's arguments. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/solutions.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | /// Solutions. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 25 | /// Solutions. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/solutions.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | /// work in terms of the Function to maximize. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 99 | /// work in terms of the Function to maximize. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/solutions.rs:145:43 [INFO] [stdout] | [INFO] [stdout] 145 | solutions: HashSet::from_iter(self.evolve_individuals(mutate_prob).into_iter()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:152:20 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 145 - solutions: HashSet::from_iter(self.evolve_individuals(mutate_prob).into_iter()), [INFO] [stdout] 145 + solutions: HashSet::from_iter(self.evolve_individuals(mutate_prob)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/solutions.rs:207:22 [INFO] [stdout] | [INFO] [stdout] 207 | .map(|thread| thread.join().unwrap()) [INFO] [stdout] | ______________________^ [INFO] [stdout] 208 | | .flatten() [INFO] [stdout] | |______________________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|thread| thread.join().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/solutions.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 221 | /// evolution step. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 221 | /// evolution step. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/solutions.rs:159:26 [INFO] [stdout] | [INFO] [stdout] 159 | fn iter(&'a self) -> std::collections::hash_set::Iter { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 159 | fn iter(&'a self) -> std::collections::hash_set::Iter<'a, Solution> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `x.get(0)` [INFO] [stdout] --> tests/test_genetic.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | *x.get(0) [INFO] [stdout] | ^^^^^^^^ help: try: `x.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).all(identity)` [INFO] [stdout] --> src/solution.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|(self_value, other_value)| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 82 | | f64_to_floating_point_precision_string(*self_value) [INFO] [stdout] 83 | | == f64_to_floating_point_precision_string(*other_value) [INFO] [stdout] 84 | | }) [INFO] [stdout] 85 | | .all(|elem| elem)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.all(...)` instead [INFO] [stdout] | [INFO] [stdout] 81 ~ .all(|(self_value, other_value)| { [INFO] [stdout] 82 + f64_to_floating_point_precision_string(*self_value) [INFO] [stdout] 83 + == f64_to_floating_point_precision_string(*other_value) [INFO] [stdout] 84 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/solution.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | /// solution's arguments. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 256 | /// solution's arguments. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solution.rs:426:21 [INFO] [stdout] | [INFO] [stdout] 426 | / !(_create_hash(Solution::new(vec![1.0, 3.0, 3.0])) [INFO] [stdout] 427 | | == _create_hash(Solution::new(vec![1.0, 2.0, 3.0]))) [INFO] [stdout] | |____________________________________________________________________________^ help: try: `(_create_hash(Solution::new(vec![1.0, 3.0, 3.0])) != _create_hash(Solution::new(vec![1.0, 2.0, 3.0])))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solution.rs:440:21 [INFO] [stdout] | [INFO] [stdout] 440 | / !(_create_hash(Solution::new(vec![1.00000000001, 2.0])) [INFO] [stdout] 441 | | == _create_hash(Solution::new(vec![1.0, 2.0, 3.0]))) [INFO] [stdout] | |____________________________________________________________________________^ help: try: `(_create_hash(Solution::new(vec![1.00000000001, 2.0])) != _create_hash(Solution::new(vec![1.0, 2.0, 3.0])))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/solutions.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | /// Solutions. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 25 | /// Solutions. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/solutions.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | /// work in terms of the Function to maximize. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 99 | /// work in terms of the Function to maximize. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/solutions.rs:145:43 [INFO] [stdout] | [INFO] [stdout] 145 | solutions: HashSet::from_iter(self.evolve_individuals(mutate_prob).into_iter()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:152:20 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 145 - solutions: HashSet::from_iter(self.evolve_individuals(mutate_prob).into_iter()), [INFO] [stdout] 145 + solutions: HashSet::from_iter(self.evolve_individuals(mutate_prob)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/solutions.rs:207:22 [INFO] [stdout] | [INFO] [stdout] 207 | .map(|thread| thread.join().unwrap()) [INFO] [stdout] | ______________________^ [INFO] [stdout] 208 | | .flatten() [INFO] [stdout] | |______________________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|thread| thread.join().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/solutions.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 221 | /// evolution step. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 221 | /// evolution step. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/solutions.rs:159:26 [INFO] [stdout] | [INFO] [stdout] 159 | fn iter(&'a self) -> std::collections::hash_set::Iter { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 159 | fn iter(&'a self) -> std::collections::hash_set::Iter<'a, Solution> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `x.get(0)` [INFO] [stdout] --> src/main.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | *x.get(0) [INFO] [stdout] | ^^^^^^^^ help: try: `x.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `x.get(0)` [INFO] [stdout] --> src/main.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | *x.get(0) [INFO] [stdout] | ^^^^^^^^ help: try: `x.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 3.60s [INFO] running `Command { std: "docker" "inspect" "642fa2c539513349ca15ad0e564ace00290fae2564ea03db8bb4b1e1eafab4b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "642fa2c539513349ca15ad0e564ace00290fae2564ea03db8bb4b1e1eafab4b0", kill_on_drop: false }` [INFO] [stdout] 642fa2c539513349ca15ad0e564ace00290fae2564ea03db8bb4b1e1eafab4b0