[INFO] fetching crate gearley 0.0.4... [INFO] linting gearley-0.0.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gearley 0.0.4 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate gearley 0.0.4 [INFO] finished tweaking crates.io crate gearley 0.0.4 [INFO] tweaked toml for crates.io crate gearley 0.0.4 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gearley 0.0.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding bit-matrix v0.6.1 (available: v0.9.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.9.1) [INFO] [stderr] Adding cfg v0.5.0 (available: v0.10.1) [INFO] [stderr] Adding env_logger v0.7.1 (available: v0.11.9) [INFO] [stderr] Adding num v0.2.1 (available: v0.4.3) [INFO] [stderr] Adding num-derive v0.3.3 (available: v0.4.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded phf_shared v0.7.24 [INFO] [stderr] Downloaded optional v0.5.0 [INFO] [stderr] Downloaded phf_macros v0.7.24 [INFO] [stderr] Downloaded c_lexer v0.1.1 [INFO] [stderr] Downloaded num v0.2.1 [INFO] [stderr] Downloaded bit-matrix v0.6.1 [INFO] [stderr] Downloaded phf_generator v0.7.24 [INFO] [stderr] Downloaded phf v0.7.24 [INFO] [stderr] Downloaded cfg v0.5.0 [INFO] [stderr] Downloaded ref_slice v1.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f908750d2117fdda57f2a849bce32e82cfcc520db75b2fb702b4f897c656e205 [INFO] running `Command { std: "docker" "start" "-a" "f908750d2117fdda57f2a849bce32e82cfcc520db75b2fb702b4f897c656e205", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f908750d2117fdda57f2a849bce32e82cfcc520db75b2fb702b4f897c656e205", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f908750d2117fdda57f2a849bce32e82cfcc520db75b2fb702b4f897c656e205", kill_on_drop: false }` [INFO] [stdout] f908750d2117fdda57f2a849bce32e82cfcc520db75b2fb702b4f897c656e205 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e3f8081c69a7711eaca572afb3cbe9e245ee145f7fe9f845f40fa0796d33b12 [INFO] running `Command { std: "docker" "start" "-a" "3e3f8081c69a7711eaca572afb3cbe9e245ee145f7fe9f845f40fa0796d33b12", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking ref_slice v1.2.1 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling phf_macros v0.7.24 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking optional v0.5.0 [INFO] [stderr] Checking internship v0.6.0 [INFO] [stderr] Checking bit-matrix v0.6.1 [INFO] [stderr] Checking c_lexer v0.1.1 [INFO] [stderr] Checking cfg v0.5.0 [INFO] [stderr] Checking gearley v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/lib.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_clippy_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/binary_heap.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | #![cfg_attr(feature = "cargo-clippy", allow(nonminimal_bool))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/lib.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_clippy_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/binary_heap.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | #![cfg_attr(feature = "cargo-clippy", allow(nonminimal_bool))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/forest/null_forest.rs:19:92 [INFO] [stdout] | [INFO] [stdout] 19 | #[inline(always)] fn sum(&mut self, _lhs_sym: Symbol, _origin: u32) -> Self::NodeRef { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/binary_heap.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | #![cfg_attr(feature = "cargo-clippy", allow(nonminimal_bool))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/binary_heap.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | #![cfg_attr(feature = "cargo-clippy", allow(nonminimal_bool))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/forest/null_forest.rs:19:92 [INFO] [stdout] | [INFO] [stdout] 19 | #[inline(always)] fn sum(&mut self, _lhs_sym: Symbol, _origin: u32) -> Self::NodeRef { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 38 | 0..=1000 => 16, [INFO] [stdout] | -------- this range overlaps on `1000_usize`... [INFO] [stdout] 39 | 1000..=500_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] = note: `#[warn(overlapping_range_endpoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 39 | 1000..=500_000 => 32, [INFO] [stdout] | -------------- this range overlaps on `500000_usize`... [INFO] [stdout] 40 | 500_000..=2_000_000 => 64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 78 | 0..=200 => 16, [INFO] [stdout] | ------- this range overlaps on `200_usize`... [INFO] [stdout] 79 | 200..=10_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 79 | 200..=10_000 => 32, [INFO] [stdout] | ------------ this range overlaps on `10000_usize`... [INFO] [stdout] 80 | 10_000..=100_000 => 64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 117 | 0..=1000 => 16, [INFO] [stdout] | -------- this range overlaps on `1000_usize`... [INFO] [stdout] 118 | 1000..=500_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 118 | 1000..=500_000 => 32, [INFO] [stdout] | -------------- this range overlaps on `500000_usize`... [INFO] [stdout] 119 | 500_000..=2_000_000 => 64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 211 | 0..=1000 => 8, [INFO] [stdout] | -------- this range overlaps on `1000_usize`... [INFO] [stdout] 212 | 1000..=100_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `nop` is never read [INFO] [stdout] --> src/forest/node.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 138 | union NodeRepr { [INFO] [stdout] | -------- field in this union [INFO] [stdout] ... [INFO] [stdout] 149 | nop: NopRepr, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NodeRepr` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `nop` is never read [INFO] [stdout] --> src/forest/node.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 211 | struct NopRepr { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 212 | nop: u16, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NopRepr` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'p [INFO] [stdout] --> src/forest/traverse.rs:155:25 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn next_product<'p>(&'p mut self) -> Option { [INFO] [stdout] | ^^ ^^ ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 155 - pub fn next_product<'p>(&'p mut self) -> Option { [INFO] [stdout] 155 + pub fn next_product(&mut self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/forest/traverse.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | while let Some(node) = self.products.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for node in self.products.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/forest/bocage.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | / if right_factor.is_none() { [INFO] [stdout] 121 | | // Add omitted phantom syms here. [INFO] [stdout] 122 | | if let Some((sym, dir)) = self.grammar.borrow().nulling(action) { [INFO] [stdout] 123 | | let (left, right) = if dir { [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 119 ~ Product { ref mut left_factor, ref mut right_factor, action } [INFO] [stdout] 120 ~ if right_factor.is_none() => { [INFO] [stdout] 121 | // Add omitted phantom syms here. [INFO] [stdout] ... [INFO] [stdout] 130 | } [INFO] [stdout] 131 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/forest/bocage.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / match node { [INFO] [stdout] 119 | | Product { ref mut left_factor, ref mut right_factor, action } => { [INFO] [stdout] 120 | | if right_factor.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 133 | | _ => {} [INFO] [stdout] 134 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Product { ref mut left_factor, ref mut right_factor, action } = node { [INFO] [stdout] 119 + if right_factor.is_none() { [INFO] [stdout] 120 + // Add omitted phantom syms here. [INFO] [stdout] 121 + if let Some((sym, dir)) = self.grammar.borrow().nulling(action) { [INFO] [stdout] 122 + let (left, right) = if dir { [INFO] [stdout] 123 + (*left_factor, NodeHandle::nulling(sym)) [INFO] [stdout] 124 + } else { [INFO] [stdout] 125 + (NodeHandle::nulling(sym), *left_factor) [INFO] [stdout] 126 + }; [INFO] [stdout] 127 + *left_factor = left; [INFO] [stdout] 128 + *right_factor = Some(right); [INFO] [stdout] 129 + } [INFO] [stdout] 130 + } [INFO] [stdout] 131 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item uses `packed` representation without ABI-qualification [INFO] [stdout] --> src/forest/node.rs:188:1 [INFO] [stdout] | [INFO] [stdout] 187 | #[repr(packed)] [INFO] [stdout] | ------ `packed` representation set here [INFO] [stdout] 188 | / struct ProductRepr { [INFO] [stdout] 189 | | upper_action: u16, [INFO] [stdout] 190 | | lower_action: u16, [INFO] [stdout] 191 | | left_factor: NodeHandle, [INFO] [stdout] 192 | | right_factor: NodeHandle, [INFO] [stdout] 193 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI [INFO] [stdout] = help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repr_packed_without_abi [INFO] [stdout] = note: `#[warn(clippy::repr_packed_without_abi)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | SmallSumTag = 0b000 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | SmallLinkTag = 0b001 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | MediumLinkTag = 0b010 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | SmallProductTag = 0b011 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | SmallLeafTag = 0b100 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | SmallNullingLeafTag = 0b1001 << (TAG_BIT - 1), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | LeafTag = 0b101 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:261:5 [INFO] [stdout] | [INFO] [stdout] 261 | SumTag = 0b111 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 262 | ProductTag = 0b110 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | NopTag = 0b1111_1111_1111_1111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Tag` [INFO] [stdout] --> src/forest/node.rs:252:1 [INFO] [stdout] | [INFO] [stdout] 252 | / pub(super) enum Tag { [INFO] [stdout] 253 | | SmallSumTag = 0b000 << TAG_BIT, [INFO] [stdout] 254 | | SmallLinkTag = 0b001 << TAG_BIT, [INFO] [stdout] 255 | | MediumLinkTag = 0b010 << TAG_BIT, [INFO] [stdout] ... | [INFO] [stdout] 263 | | NopTag = 0b1111_1111_1111_1111, [INFO] [stdout] 264 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `rule.rhs().get(0)` [INFO] [stdout] --> src/grammar.rs:198:53 [INFO] [stdout] | [INFO] [stdout] 198 | self.rhs0.extend(grammar.rules().map(|rule| rule.rhs().get(0).cloned())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `rule.rhs().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/grammar.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | / for elem_inner in inner.into_iter() { [INFO] [stdout] 262 | | if let Some(inner_sym) = elem_inner { [INFO] [stdout] 263 | | self.first_sets.set(outer.usize(), inner_sym.usize(), true); [INFO] [stdout] 264 | | } [INFO] [stdout] 265 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/grammar.rs:262:17 [INFO] [stdout] | [INFO] [stdout] 262 | / if let Some(inner_sym) = elem_inner { [INFO] [stdout] 263 | | self.first_sets.set(outer.usize(), inner_sym.usize(), true); [INFO] [stdout] 264 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 ~ for inner_sym in inner.into_iter().flatten() { [INFO] [stdout] 262 + self.first_sets.set(outer.usize(), inner_sym.usize(), true); [INFO] [stdout] 263 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeSet` [INFO] [stdout] --> src/grammar.rs:261:37 [INFO] [stdout] | [INFO] [stdout] 261 | for elem_inner in inner.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap` [INFO] [stdout] --> src/grammar.rs:269:58 [INFO] [stdout] | [INFO] [stdout] 269 | for (before, after) in follow_sets.follow_sets().into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/grammar.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | / for elem_after in after.into_iter() { [INFO] [stdout] 271 | | if let Some(after_sym) = elem_after { [INFO] [stdout] 272 | | self.follow_sets.set(before.usize(), after_sym.usize(), true); [INFO] [stdout] 273 | | } [INFO] [stdout] 274 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/grammar.rs:271:17 [INFO] [stdout] | [INFO] [stdout] 271 | / if let Some(after_sym) = elem_after { [INFO] [stdout] 272 | | self.follow_sets.set(before.usize(), after_sym.usize(), true); [INFO] [stdout] 273 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 270 ~ for after_sym in after.into_iter().flatten() { [INFO] [stdout] 271 + self.follow_sets.set(before.usize(), after_sym.usize(), true); [INFO] [stdout] 272 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeSet` [INFO] [stdout] --> src/grammar.rs:270:37 [INFO] [stdout] | [INFO] [stdout] 270 | for elem_after in after.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/grammar.rs:290:25 [INFO] [stdout] | [INFO] [stdout] 290 | let mut table = iter::repeat(vec![]).take(self.size.syms).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(vec![], self.size.syms)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/grammar.rs:320:32 [INFO] [stdout] | [INFO] [stdout] 320 | let iter_table = table.into_iter().flat_map(|v| v.into_iter()); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/grammar.rs:320:59 [INFO] [stdout] | [INFO] [stdout] 320 | let iter_table = table.into_iter().flat_map(|v| v.into_iter()); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/grammar.rs:331:25 [INFO] [stdout] | [INFO] [stdout] 331 | let mut table = iter::repeat(vec![]).take(self.size.syms).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(vec![], self.size.syms)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/grammar.rs:361:32 [INFO] [stdout] | [INFO] [stdout] 361 | let iter_table = table.into_iter().flat_map(|v| v.into_iter()); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/grammar.rs:361:59 [INFO] [stdout] | [INFO] [stdout] 361 | let iter_table = table.into_iter().flat_map(|v| v.into_iter()); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/grammar.rs:366:32 [INFO] [stdout] | [INFO] [stdout] 366 | let iter_events_pred = iter::repeat((Optioned::none(), Optioned::none())).take(self.size.syms); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n((Optioned::none(), Optioned::none()), self.size.syms)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/grammar.rs:368:31 [INFO] [stdout] | [INFO] [stdout] 368 | let iter_trace_pred = iter::repeat(None).take(self.size.syms); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(None, self.size.syms)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/grammar.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 488 | &*self.nulling_intermediate_rules [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&self.nulling_intermediate_rules` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/item.rs:63:1 [INFO] [stdout] | [INFO] [stdout] 63 | / impl PartialOrd for CompletedItem { [INFO] [stdout] 64 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 65 | | Some((self.origin, self.dot).cmp(&(other.origin, other.dot))) [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 65 - Some((self.origin, self.dot).cmp(&(other.origin, other.dot))) [INFO] [stdout] 66 - } [INFO] [stdout] 64 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/item.rs:75:1 [INFO] [stdout] | [INFO] [stdout] 75 | impl Into> for CompletedItem { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 75 ~ impl From> for Item { [INFO] [stdout] 76 ~ fn from(val: CompletedItem) -> Self { [INFO] [stdout] 77 | Item { [INFO] [stdout] 78 ~ origin: val.origin, [INFO] [stdout] 79 ~ dot: val.dot, [INFO] [stdout] 80 ~ node: val.left_node, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/memory_use.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | 0..=1000 => 16, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/memory_use.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | 1000..=500_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] = note: `#[warn(clippy::match_overlapping_arm)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 47 | + (grammar.num_syms() + 31) / 32 * 4 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `grammar.num_syms().div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/memory_use.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | 0..=200 => 16, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/memory_use.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | 200..=10_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/memory_use.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | 0..=1000 => 16, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/memory_use.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | 1000..=500_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:125:15 [INFO] [stdout] | [INFO] [stdout] 125 | + (grammar.num_syms() + 31) / 32 * 4 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `grammar.num_syms().div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:167:17 [INFO] [stdout] | [INFO] [stdout] 167 | rows * ((columns + 31) / 32 * 4) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `columns.div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:171:24 [INFO] [stdout] | [INFO] [stdout] 171 | let row_size = (num_columns + 31) / 32 * 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `num_columns.div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | (self.capacity() + 31) / 32 * 4 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.capacity().div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/memory_use.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | 0..=1000 => 8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/memory_use.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 212 | 1000..=100_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/recognizer.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / self.medial[self.current_medial_start..].sort_unstable_by(|a, b| [INFO] [stdout] 164 | | (grammar.get_rhs1_cmp(a.dot), a.dot, a.origin).cmp(&(grammar.get_rhs1_cmp(b.dot), b.dot, b.origin)) [INFO] [stdout] 165 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 163 - self.medial[self.current_medial_start..].sort_unstable_by(|a, b| [INFO] [stdout] 164 - (grammar.get_rhs1_cmp(a.dot), a.dot, a.origin).cmp(&(grammar.get_rhs1_cmp(b.dot), b.dot, b.origin)) [INFO] [stdout] 165 - ); [INFO] [stdout] 163 + self.medial[self.current_medial_start..].sort_unstable_by_key(|a| (grammar.get_rhs1_cmp(a.dot), a.dot, a.origin)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/recognizer.rs:200:25 [INFO] [stdout] | [INFO] [stdout] 200 | self.medial[new_medial_start as usize + i] = self.medial[self.current_medial_start + i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_medial_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/recognizer.rs:202:30 [INFO] [stdout] | [INFO] [stdout] 202 | self.medial.truncate(new_medial_start as usize + current_medial_length); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_medial_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/recognizer.rs:203:37 [INFO] [stdout] | [INFO] [stdout] 203 | self.current_medial_start = new_medial_start as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_medial_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/recognizer.rs:493:19 [INFO] [stdout] | [INFO] [stdout] 493 | while let Some(_) = self.next_summand() {} [INFO] [stdout] | ----------^^^^^^^---------------------- help: try: `while self.next_summand().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/binary_heap.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use std::u32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.complete.get(0)` [INFO] [stdout] --> src/binary_heap.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | self.complete.get(0).and_then(|&right_item| [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.complete.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/binary_heap.rs:112:31 [INFO] [stdout] | [INFO] [stdout] 112 | if right < end && !(self.heap_get(child).unwrap() > self.heap_get(right).unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.heap_get(child).unwrap() <= self.heap_get(right).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/events.rs:158:18 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn trace(&self) -> Trace { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 158 | pub fn trace(&self) -> Trace<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/events.rs:173:19 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn events(&self) -> Events { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 173 | pub fn events(&self) -> Events<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/events.rs:188:30 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn minimal_distances(&self) -> Distances { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 188 | pub fn minimal_distances(&self) -> Distances<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/events.rs:194:31 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn expected_terminals(&self) -> ExpectedTerminals { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 194 | pub fn expected_terminals(&self) -> ExpectedTerminals<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/forest/traverse.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn traverse(&self) -> Traverse { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 16 | pub fn traverse(&self) -> Traverse<'_, G> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/forest/traverse.rs:155:53 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn next_product<'p>(&'p mut self) -> Option { [INFO] [stdout] | -- ^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'p` [INFO] [stdout] | [INFO] [stdout] 155 | pub fn next_product<'p>(&'p mut self) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/forest/node.rs:53:29 [INFO] [stdout] | [INFO] [stdout] 53 | pub(crate) fn iter_from(&self, handle: NodeHandle) -> Iter { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 53 | pub(crate) fn iter_from(&self, handle: NodeHandle) -> Iter<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/recognizer.rs:411:30 [INFO] [stdout] | [INFO] [stdout] 411 | pub fn predicted_symbols(&self) -> PredictedSymbols { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 411 | pub fn predicted_symbols(&self) -> PredictedSymbols<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/recognizer.rs:420:25 [INFO] [stdout] | [INFO] [stdout] 420 | pub fn medial_items(&self) -> MedialItems { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 420 | pub fn medial_items(&self) -> MedialItems<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 38 | 0..=1000 => 16, [INFO] [stdout] | -------- this range overlaps on `1000_usize`... [INFO] [stdout] 39 | 1000..=500_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] = note: `#[warn(overlapping_range_endpoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 39 | 1000..=500_000 => 32, [INFO] [stdout] | -------------- this range overlaps on `500000_usize`... [INFO] [stdout] 40 | 500_000..=2_000_000 => 64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 78 | 0..=200 => 16, [INFO] [stdout] | ------- this range overlaps on `200_usize`... [INFO] [stdout] 79 | 200..=10_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 79 | 200..=10_000 => 32, [INFO] [stdout] | ------------ this range overlaps on `10000_usize`... [INFO] [stdout] 80 | 10_000..=100_000 => 64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 117 | 0..=1000 => 16, [INFO] [stdout] | -------- this range overlaps on `1000_usize`... [INFO] [stdout] 118 | 1000..=500_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 118 | 1000..=500_000 => 32, [INFO] [stdout] | -------------- this range overlaps on `500000_usize`... [INFO] [stdout] 119 | 500_000..=2_000_000 => 64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/memory_use.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 211 | 0..=1000 => 8, [INFO] [stdout] | -------- this range overlaps on `1000_usize`... [INFO] [stdout] 212 | 1000..=100_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `nop` is never read [INFO] [stdout] --> src/forest/node.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 138 | union NodeRepr { [INFO] [stdout] | -------- field in this union [INFO] [stdout] ... [INFO] [stdout] 149 | nop: NopRepr, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NodeRepr` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `nop` is never read [INFO] [stdout] --> src/forest/node.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 211 | struct NopRepr { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 212 | nop: u16, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NopRepr` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'p [INFO] [stdout] --> src/forest/traverse.rs:155:25 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn next_product<'p>(&'p mut self) -> Option { [INFO] [stdout] | ^^ ^^ ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 155 - pub fn next_product<'p>(&'p mut self) -> Option { [INFO] [stdout] 155 + pub fn next_product(&mut self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/forest/traverse.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | while let Some(node) = self.products.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for node in self.products.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/forest/bocage.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | / if right_factor.is_none() { [INFO] [stdout] 121 | | // Add omitted phantom syms here. [INFO] [stdout] 122 | | if let Some((sym, dir)) = self.grammar.borrow().nulling(action) { [INFO] [stdout] 123 | | let (left, right) = if dir { [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 119 ~ Product { ref mut left_factor, ref mut right_factor, action } [INFO] [stdout] 120 ~ if right_factor.is_none() => { [INFO] [stdout] 121 | // Add omitted phantom syms here. [INFO] [stdout] ... [INFO] [stdout] 130 | } [INFO] [stdout] 131 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/forest/bocage.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / match node { [INFO] [stdout] 119 | | Product { ref mut left_factor, ref mut right_factor, action } => { [INFO] [stdout] 120 | | if right_factor.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 133 | | _ => {} [INFO] [stdout] 134 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Product { ref mut left_factor, ref mut right_factor, action } = node { [INFO] [stdout] 119 + if right_factor.is_none() { [INFO] [stdout] 120 + // Add omitted phantom syms here. [INFO] [stdout] 121 + if let Some((sym, dir)) = self.grammar.borrow().nulling(action) { [INFO] [stdout] 122 + let (left, right) = if dir { [INFO] [stdout] 123 + (*left_factor, NodeHandle::nulling(sym)) [INFO] [stdout] 124 + } else { [INFO] [stdout] 125 + (NodeHandle::nulling(sym), *left_factor) [INFO] [stdout] 126 + }; [INFO] [stdout] 127 + *left_factor = left; [INFO] [stdout] 128 + *right_factor = Some(right); [INFO] [stdout] 129 + } [INFO] [stdout] 130 + } [INFO] [stdout] 131 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item uses `packed` representation without ABI-qualification [INFO] [stdout] --> src/forest/node.rs:188:1 [INFO] [stdout] | [INFO] [stdout] 187 | #[repr(packed)] [INFO] [stdout] | ------ `packed` representation set here [INFO] [stdout] 188 | / struct ProductRepr { [INFO] [stdout] 189 | | upper_action: u16, [INFO] [stdout] 190 | | lower_action: u16, [INFO] [stdout] 191 | | left_factor: NodeHandle, [INFO] [stdout] 192 | | right_factor: NodeHandle, [INFO] [stdout] 193 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI [INFO] [stdout] = help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repr_packed_without_abi [INFO] [stdout] = note: `#[warn(clippy::repr_packed_without_abi)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | SmallSumTag = 0b000 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | SmallLinkTag = 0b001 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | MediumLinkTag = 0b010 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | SmallProductTag = 0b011 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | SmallLeafTag = 0b100 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | SmallNullingLeafTag = 0b1001 << (TAG_BIT - 1), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | LeafTag = 0b101 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:261:5 [INFO] [stdout] | [INFO] [stdout] 261 | SumTag = 0b111 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 262 | ProductTag = 0b110 << TAG_BIT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/forest/node.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | NopTag = 0b1111_1111_1111_1111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Tag` [INFO] [stdout] --> src/forest/node.rs:252:1 [INFO] [stdout] | [INFO] [stdout] 252 | / pub(super) enum Tag { [INFO] [stdout] 253 | | SmallSumTag = 0b000 << TAG_BIT, [INFO] [stdout] 254 | | SmallLinkTag = 0b001 << TAG_BIT, [INFO] [stdout] 255 | | MediumLinkTag = 0b010 << TAG_BIT, [INFO] [stdout] ... | [INFO] [stdout] 263 | | NopTag = 0b1111_1111_1111_1111, [INFO] [stdout] 264 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `rule.rhs().get(0)` [INFO] [stdout] --> src/grammar.rs:198:53 [INFO] [stdout] | [INFO] [stdout] 198 | self.rhs0.extend(grammar.rules().map(|rule| rule.rhs().get(0).cloned())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `rule.rhs().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/grammar.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | / for elem_inner in inner.into_iter() { [INFO] [stdout] 262 | | if let Some(inner_sym) = elem_inner { [INFO] [stdout] 263 | | self.first_sets.set(outer.usize(), inner_sym.usize(), true); [INFO] [stdout] 264 | | } [INFO] [stdout] 265 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/grammar.rs:262:17 [INFO] [stdout] | [INFO] [stdout] 262 | / if let Some(inner_sym) = elem_inner { [INFO] [stdout] 263 | | self.first_sets.set(outer.usize(), inner_sym.usize(), true); [INFO] [stdout] 264 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 ~ for inner_sym in inner.into_iter().flatten() { [INFO] [stdout] 262 + self.first_sets.set(outer.usize(), inner_sym.usize(), true); [INFO] [stdout] 263 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeSet` [INFO] [stdout] --> src/grammar.rs:261:37 [INFO] [stdout] | [INFO] [stdout] 261 | for elem_inner in inner.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap` [INFO] [stdout] --> src/grammar.rs:269:58 [INFO] [stdout] | [INFO] [stdout] 269 | for (before, after) in follow_sets.follow_sets().into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/grammar.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | / for elem_after in after.into_iter() { [INFO] [stdout] 271 | | if let Some(after_sym) = elem_after { [INFO] [stdout] 272 | | self.follow_sets.set(before.usize(), after_sym.usize(), true); [INFO] [stdout] 273 | | } [INFO] [stdout] 274 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/grammar.rs:271:17 [INFO] [stdout] | [INFO] [stdout] 271 | / if let Some(after_sym) = elem_after { [INFO] [stdout] 272 | | self.follow_sets.set(before.usize(), after_sym.usize(), true); [INFO] [stdout] 273 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 270 ~ for after_sym in after.into_iter().flatten() { [INFO] [stdout] 271 + self.follow_sets.set(before.usize(), after_sym.usize(), true); [INFO] [stdout] 272 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeSet` [INFO] [stdout] --> src/grammar.rs:270:37 [INFO] [stdout] | [INFO] [stdout] 270 | for elem_after in after.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/grammar.rs:290:25 [INFO] [stdout] | [INFO] [stdout] 290 | let mut table = iter::repeat(vec![]).take(self.size.syms).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(vec![], self.size.syms)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/grammar.rs:320:32 [INFO] [stdout] | [INFO] [stdout] 320 | let iter_table = table.into_iter().flat_map(|v| v.into_iter()); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/grammar.rs:320:59 [INFO] [stdout] | [INFO] [stdout] 320 | let iter_table = table.into_iter().flat_map(|v| v.into_iter()); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/grammar.rs:331:25 [INFO] [stdout] | [INFO] [stdout] 331 | let mut table = iter::repeat(vec![]).take(self.size.syms).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(vec![], self.size.syms)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/grammar.rs:361:32 [INFO] [stdout] | [INFO] [stdout] 361 | let iter_table = table.into_iter().flat_map(|v| v.into_iter()); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/grammar.rs:361:59 [INFO] [stdout] | [INFO] [stdout] 361 | let iter_table = table.into_iter().flat_map(|v| v.into_iter()); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/grammar.rs:366:32 [INFO] [stdout] | [INFO] [stdout] 366 | let iter_events_pred = iter::repeat((Optioned::none(), Optioned::none())).take(self.size.syms); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n((Optioned::none(), Optioned::none()), self.size.syms)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/grammar.rs:368:31 [INFO] [stdout] | [INFO] [stdout] 368 | let iter_trace_pred = iter::repeat(None).take(self.size.syms); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(None, self.size.syms)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/grammar.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 488 | &*self.nulling_intermediate_rules [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&self.nulling_intermediate_rules` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/item.rs:63:1 [INFO] [stdout] | [INFO] [stdout] 63 | / impl PartialOrd for CompletedItem { [INFO] [stdout] 64 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 65 | | Some((self.origin, self.dot).cmp(&(other.origin, other.dot))) [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 65 - Some((self.origin, self.dot).cmp(&(other.origin, other.dot))) [INFO] [stdout] 66 - } [INFO] [stdout] 64 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/item.rs:75:1 [INFO] [stdout] | [INFO] [stdout] 75 | impl Into> for CompletedItem { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 75 ~ impl From> for Item { [INFO] [stdout] 76 ~ fn from(val: CompletedItem) -> Self { [INFO] [stdout] 77 | Item { [INFO] [stdout] 78 ~ origin: val.origin, [INFO] [stdout] 79 ~ dot: val.dot, [INFO] [stdout] 80 ~ node: val.left_node, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/memory_use.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | 0..=1000 => 16, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/memory_use.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | 1000..=500_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] = note: `#[warn(clippy::match_overlapping_arm)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 47 | + (grammar.num_syms() + 31) / 32 * 4 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `grammar.num_syms().div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/memory_use.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | 0..=200 => 16, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/memory_use.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | 200..=10_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/memory_use.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | 0..=1000 => 16, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/memory_use.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | 1000..=500_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:125:15 [INFO] [stdout] | [INFO] [stdout] 125 | + (grammar.num_syms() + 31) / 32 * 4 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `grammar.num_syms().div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:167:17 [INFO] [stdout] | [INFO] [stdout] 167 | rows * ((columns + 31) / 32 * 4) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `columns.div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:171:24 [INFO] [stdout] | [INFO] [stdout] 171 | let row_size = (num_columns + 31) / 32 * 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `num_columns.div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/memory_use.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | (self.capacity() + 31) / 32 * 4 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.capacity().div_ceil(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/memory_use.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | 0..=1000 => 8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/memory_use.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 212 | 1000..=100_000 => 32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/recognizer.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / self.medial[self.current_medial_start..].sort_unstable_by(|a, b| [INFO] [stdout] 164 | | (grammar.get_rhs1_cmp(a.dot), a.dot, a.origin).cmp(&(grammar.get_rhs1_cmp(b.dot), b.dot, b.origin)) [INFO] [stdout] 165 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 163 - self.medial[self.current_medial_start..].sort_unstable_by(|a, b| [INFO] [stdout] 164 - (grammar.get_rhs1_cmp(a.dot), a.dot, a.origin).cmp(&(grammar.get_rhs1_cmp(b.dot), b.dot, b.origin)) [INFO] [stdout] 165 - ); [INFO] [stdout] 163 + self.medial[self.current_medial_start..].sort_unstable_by_key(|a| (grammar.get_rhs1_cmp(a.dot), a.dot, a.origin)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/recognizer.rs:200:25 [INFO] [stdout] | [INFO] [stdout] 200 | self.medial[new_medial_start as usize + i] = self.medial[self.current_medial_start + i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_medial_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/recognizer.rs:202:30 [INFO] [stdout] | [INFO] [stdout] 202 | self.medial.truncate(new_medial_start as usize + current_medial_length); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_medial_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/recognizer.rs:203:37 [INFO] [stdout] | [INFO] [stdout] 203 | self.current_medial_start = new_medial_start as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_medial_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/recognizer.rs:493:19 [INFO] [stdout] | [INFO] [stdout] 493 | while let Some(_) = self.next_summand() {} [INFO] [stdout] | ----------^^^^^^^---------------------- help: try: `while self.next_summand().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/binary_heap.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use std::u32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.complete.get(0)` [INFO] [stdout] --> src/binary_heap.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | self.complete.get(0).and_then(|&right_item| [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.complete.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/binary_heap.rs:112:31 [INFO] [stdout] | [INFO] [stdout] 112 | if right < end && !(self.heap_get(child).unwrap() > self.heap_get(right).unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.heap_get(child).unwrap() <= self.heap_get(right).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/events.rs:158:18 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn trace(&self) -> Trace { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 158 | pub fn trace(&self) -> Trace<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/events.rs:173:19 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn events(&self) -> Events { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 173 | pub fn events(&self) -> Events<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/events.rs:188:30 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn minimal_distances(&self) -> Distances { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 188 | pub fn minimal_distances(&self) -> Distances<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/events.rs:194:31 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn expected_terminals(&self) -> ExpectedTerminals { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 194 | pub fn expected_terminals(&self) -> ExpectedTerminals<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/forest/traverse.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn traverse(&self) -> Traverse { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 16 | pub fn traverse(&self) -> Traverse<'_, G> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/forest/traverse.rs:155:53 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn next_product<'p>(&'p mut self) -> Option { [INFO] [stdout] | -- ^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'p` [INFO] [stdout] | [INFO] [stdout] 155 | pub fn next_product<'p>(&'p mut self) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/forest/node.rs:53:29 [INFO] [stdout] | [INFO] [stdout] 53 | pub(crate) fn iter_from(&self, handle: NodeHandle) -> Iter { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 53 | pub(crate) fn iter_from(&self, handle: NodeHandle) -> Iter<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/recognizer.rs:411:30 [INFO] [stdout] | [INFO] [stdout] 411 | pub fn predicted_symbols(&self) -> PredictedSymbols { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 411 | pub fn predicted_symbols(&self) -> PredictedSymbols<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/recognizer.rs:420:25 [INFO] [stdout] | [INFO] [stdout] 420 | pub fn medial_items(&self) -> MedialItems { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 420 | pub fn medial_items(&self) -> MedialItems<'_, F::NodeRef> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::simple_evaluator::SimpleEvaluator` [INFO] [stdout] --> tests/helpers/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::simple_evaluator::SimpleEvaluator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::simple_evaluator::SimpleEvaluator` [INFO] [stdout] --> tests/helpers/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::simple_evaluator::SimpleEvaluator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/test_c.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | const _SYM_NAMES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/test_c.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 20 | const _SYM_NAMES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `gearley::memory_use::MemoryUse` [INFO] [stdout] --> benches/benches.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use gearley::memory_use::MemoryUse; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> benches/benches.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | const SUM_TOKENS: &'static [u32] = precedenced_arith!( [INFO] [stdout] | -^^^^^^^------ help: consider removing `'static`: `&[u32]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> tests/test_c.rs:469:93 [INFO] [stdout] | [INFO] [stdout] 469 | let mut rec: Recognizer> = Recognizer::new_with_limit(&cfg, 2_00_000); [INFO] [stdout] | ^^^^^^^^ help: consider: `200_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> tests/test_serde.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> tests/helpers/cartesian_product.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | end: start.offset(slice.len() as isize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 15 - end: start.offset(slice.len() as isize), [INFO] [stdout] 15 + end: start.add(slice.len()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> tests/helpers/cartesian_product.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if *ptr as *const _ == self.end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(*ptr, self.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match &mut item.item { [INFO] [stdout] 54 | | &mut SumHandle(ref mut products) => { [INFO] [stdout] 55 | | while let Some(product) = products.next_product() { [INFO] [stdout] 56 | | let mut cartesian_product = CartesianProduct::new(); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 53 ~ match *&mut item.item { [INFO] [stdout] 54 ~ SumHandle(ref mut products) => { [INFO] [stdout] 55 | while let Some(product) = products.next_product() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ NullingHandle => { [INFO] [stdout] 70 | (self.null)(item.symbol, &mut self.values); [INFO] [stdout] 71 | } [INFO] [stdout] 72 ~ LeafHandle => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | self.evaluated.insert(item.handle(), mem::replace(&mut self.values, vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.values)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::simple_evaluator::SimpleEvaluator` [INFO] [stdout] --> benches/../tests/helpers/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::simple_evaluator::SimpleEvaluator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> benches/bench_rust_grammar_subset.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | const TOKENS: &'static [u32] = rhs!( [INFO] [stdout] | -^^^^^^^------ help: consider removing `'static`: `&[u32]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> benches/bench_rust_grammar_subset.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | const _TOKEN_NAMES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> benches/bench_rust_grammar_subset.rs:107:32 [INFO] [stdout] | [INFO] [stdout] 107 | const _TOKEN_NAMES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::simple_evaluator::SimpleEvaluator` [INFO] [stdout] --> benches/../tests/helpers/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::simple_evaluator::SimpleEvaluator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `cfg::sequence::Separator::Proper` [INFO] [stdout] --> benches/bench_c.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use cfg::sequence::Separator::Proper; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NullForest` [INFO] [stdout] --> benches/bench_c.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | use gearley::forest::{Bocage, NullForest}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> benches/bench_c.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | const SYM_NAMES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> benches/bench_c.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 22 | const SYM_NAMES: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> benches/bench_c.rs:472:97 [INFO] [stdout] | [INFO] [stdout] 472 | let mut rec: Recognizer> = Recognizer::new_with_limit(&cfg, 2_00_000); [INFO] [stdout] | ^^^^^^^^ help: consider: `200_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/tests.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | const SUM_TOKENS: &'static [u32] = precedenced_arith!( [INFO] [stdout] | -^^^^^^^------ help: consider removing `'static`: `&[u32]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> tests/helpers/cartesian_product.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | end: start.offset(slice.len() as isize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 15 - end: start.offset(slice.len() as isize), [INFO] [stdout] 15 + end: start.add(slice.len()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> tests/helpers/cartesian_product.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | end: start.offset(slice.len() as isize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 15 - end: start.offset(slice.len() as isize), [INFO] [stdout] 15 + end: start.add(slice.len()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> tests/helpers/cartesian_product.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if *ptr as *const _ == self.end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(*ptr, self.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> tests/helpers/cartesian_product.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if *ptr as *const _ == self.end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(*ptr, self.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match &mut item.item { [INFO] [stdout] 54 | | &mut SumHandle(ref mut products) => { [INFO] [stdout] 55 | | while let Some(product) = products.next_product() { [INFO] [stdout] 56 | | let mut cartesian_product = CartesianProduct::new(); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 53 ~ match *&mut item.item { [INFO] [stdout] 54 ~ SumHandle(ref mut products) => { [INFO] [stdout] 55 | while let Some(product) = products.next_product() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ NullingHandle => { [INFO] [stdout] 70 | (self.null)(item.symbol, &mut self.values); [INFO] [stdout] 71 | } [INFO] [stdout] 72 ~ LeafHandle => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | self.evaluated.insert(item.handle(), mem::replace(&mut self.values, vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.values)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match &mut item.item { [INFO] [stdout] 54 | | &mut SumHandle(ref mut products) => { [INFO] [stdout] 55 | | while let Some(product) = products.next_product() { [INFO] [stdout] 56 | | let mut cartesian_product = CartesianProduct::new(); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 53 ~ match *&mut item.item { [INFO] [stdout] 54 ~ SumHandle(ref mut products) => { [INFO] [stdout] 55 | while let Some(product) = products.next_product() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ NullingHandle => { [INFO] [stdout] 70 | (self.null)(item.symbol, &mut self.values); [INFO] [stdout] 71 | } [INFO] [stdout] 72 ~ LeafHandle => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | self.evaluated.insert(item.handle(), mem::replace(&mut self.values, vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.values)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> benches/../tests/grammars/ambiguous_arith.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | let a0 = args.get(0).map(|f| **f).unwrap_or(!0); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> benches/../tests/grammars/precedenced_arith.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | let a0 = args.get(0).map(|f| **f).unwrap_or(!0); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> benches/../tests/helpers/cartesian_product.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | end: start.offset(slice.len() as isize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 15 - end: start.offset(slice.len() as isize), [INFO] [stdout] 15 + end: start.add(slice.len()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> benches/../tests/helpers/cartesian_product.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if *ptr as *const _ == self.end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(*ptr, self.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> benches/../tests/helpers/cartesian_product.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | end: start.offset(slice.len() as isize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 15 - end: start.offset(slice.len() as isize), [INFO] [stdout] 15 + end: start.add(slice.len()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> benches/../tests/helpers/simple_evaluator.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match &mut item.item { [INFO] [stdout] 54 | | &mut SumHandle(ref mut products) => { [INFO] [stdout] 55 | | while let Some(product) = products.next_product() { [INFO] [stdout] 56 | | let mut cartesian_product = CartesianProduct::new(); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 53 ~ match *&mut item.item { [INFO] [stdout] 54 ~ SumHandle(ref mut products) => { [INFO] [stdout] 55 | while let Some(product) = products.next_product() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ NullingHandle => { [INFO] [stdout] 70 | (self.null)(item.symbol, &mut self.values); [INFO] [stdout] 71 | } [INFO] [stdout] 72 ~ LeafHandle => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> benches/../tests/helpers/cartesian_product.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if *ptr as *const _ == self.end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(*ptr, self.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> benches/../tests/helpers/simple_evaluator.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | self.evaluated.insert(item.handle(), mem::replace(&mut self.values, vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.values)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> tests/test_c.rs:358:37 [INFO] [stdout] | [INFO] [stdout] 358 | let tokens: Vec<_> = Lexer::lex(&contents[..]).unwrap().into_iter().filter_map(|token| { [INFO] [stdout] | ^^^^^^^^^^^^^ help: use the original value instead: `contents` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> tests/helpers/cartesian_product.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | end: start.offset(slice.len() as isize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 15 - end: start.offset(slice.len() as isize), [INFO] [stdout] 15 + end: start.add(slice.len()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> tests/helpers/cartesian_product.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if *ptr as *const _ == self.end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(*ptr, self.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> benches/../tests/helpers/simple_evaluator.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match &mut item.item { [INFO] [stdout] 54 | | &mut SumHandle(ref mut products) => { [INFO] [stdout] 55 | | while let Some(product) = products.next_product() { [INFO] [stdout] 56 | | let mut cartesian_product = CartesianProduct::new(); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 53 ~ match *&mut item.item { [INFO] [stdout] 54 ~ SumHandle(ref mut products) => { [INFO] [stdout] 55 | while let Some(product) = products.next_product() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ NullingHandle => { [INFO] [stdout] 70 | (self.null)(item.symbol, &mut self.values); [INFO] [stdout] 71 | } [INFO] [stdout] 72 ~ LeafHandle => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> benches/../tests/helpers/simple_evaluator.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | self.evaluated.insert(item.handle(), mem::replace(&mut self.values, vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.values)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> benches/bench_c.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | term, identifier, signed, const_, inline, auto, break_, case, char_, continue_, default, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match &mut item.item { [INFO] [stdout] 54 | | &mut SumHandle(ref mut products) => { [INFO] [stdout] 55 | | while let Some(product) = products.next_product() { [INFO] [stdout] 56 | | let mut cartesian_product = CartesianProduct::new(); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 53 ~ match *&mut item.item { [INFO] [stdout] 54 ~ SumHandle(ref mut products) => { [INFO] [stdout] 55 | while let Some(product) = products.next_product() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ NullingHandle => { [INFO] [stdout] 70 | (self.null)(item.symbol, &mut self.values); [INFO] [stdout] 71 | } [INFO] [stdout] 72 ~ LeafHandle => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | self.evaluated.insert(item.handle(), mem::replace(&mut self.values, vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.values)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> tests/test_nulling.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 67 | arg.iter().cloned().fold(0, |a, e| a + e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i_str` [INFO] [stdout] --> benches/bench_c.rs:386:24 [INFO] [stdout] | [INFO] [stdout] 386 | Identifier(i_str) => Some(identifier), [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_i_str` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `num` [INFO] [stdout] --> benches/bench_c.rs:387:28 [INFO] [stdout] | [INFO] [stdout] 387 | NumericLiteral(num) => Some(constant), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_num` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> benches/bench_c.rs:388:27 [INFO] [stdout] | [INFO] [stdout] 388 | StringLiteral(s) => Some(string_literal), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> benches/bench_c.rs:347:9 [INFO] [stdout] | [INFO] [stdout] 347 | term, identifier, signed, const_, inline, auto, break_, case, char_, continue_, default, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `auto` [INFO] [stdout] --> benches/bench_c.rs:347:51 [INFO] [stdout] | [INFO] [stdout] 347 | term, identifier, signed, const_, inline, auto, break_, case, char_, continue_, default, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_auto` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SYM_NAMES` is never used [INFO] [stdout] --> benches/bench_c.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const SYM_NAMES: &'static [&'static str] = &[ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> benches/../tests/helpers/cartesian_product.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | end: start.offset(slice.len() as isize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 15 - end: start.offset(slice.len() as isize), [INFO] [stdout] 15 + end: start.add(slice.len()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> benches/../tests/helpers/cartesian_product.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if *ptr as *const _ == self.end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(*ptr, self.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> benches/../tests/helpers/simple_evaluator.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match &mut item.item { [INFO] [stdout] 54 | | &mut SumHandle(ref mut products) => { [INFO] [stdout] 55 | | while let Some(product) = products.next_product() { [INFO] [stdout] 56 | | let mut cartesian_product = CartesianProduct::new(); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 53 ~ match *&mut item.item { [INFO] [stdout] 54 ~ SumHandle(ref mut products) => { [INFO] [stdout] 55 | while let Some(product) = products.next_product() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ NullingHandle => { [INFO] [stdout] 70 | (self.null)(item.symbol, &mut self.values); [INFO] [stdout] 71 | } [INFO] [stdout] 72 ~ LeafHandle => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> benches/../tests/helpers/simple_evaluator.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | self.evaluated.insert(item.handle(), mem::replace(&mut self.values, vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.values)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> tests/grammars/ambiguous_arith.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | let a0 = args.get(0).map(|f| **f).unwrap_or(!0); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> tests/grammars/precedenced_arith.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | let a0 = args.get(0).map(|f| **f).unwrap_or(!0); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> tests/helpers/cartesian_product.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | end: start.offset(slice.len() as isize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 15 - end: start.offset(slice.len() as isize), [INFO] [stdout] 15 + end: start.add(slice.len()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> tests/helpers/cartesian_product.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if *ptr as *const _ == self.end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(*ptr, self.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> benches/bench_c.rs:359:37 [INFO] [stdout] | [INFO] [stdout] 359 | let tokens: Vec<_> = Lexer::lex(&contents[..]).unwrap().into_iter().filter_map(|token| { [INFO] [stdout] | ^^^^^^^^^^^^^ help: use the original value instead: `contents` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match &mut item.item { [INFO] [stdout] 54 | | &mut SumHandle(ref mut products) => { [INFO] [stdout] 55 | | while let Some(product) = products.next_product() { [INFO] [stdout] 56 | | let mut cartesian_product = CartesianProduct::new(); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 53 ~ match *&mut item.item { [INFO] [stdout] 54 ~ SumHandle(ref mut products) => { [INFO] [stdout] 55 | while let Some(product) = products.next_product() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ NullingHandle => { [INFO] [stdout] 70 | (self.null)(item.symbol, &mut self.values); [INFO] [stdout] 71 | } [INFO] [stdout] 72 ~ LeafHandle => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> tests/helpers/simple_evaluator.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | self.evaluated.insert(item.handle(), mem::replace(&mut self.values, vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.values)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `AND_expression` should have a snake case name [INFO] [stdout] --> benches/bench_c.rs:74:53 [INFO] [stdout] | [INFO] [stdout] 74 | relational_expression, equality_expression, AND_expression, exclusive_OR_expression, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `and_expression` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `exclusive_OR_expression` should have a snake case name [INFO] [stdout] --> benches/bench_c.rs:74:69 [INFO] [stdout] | [INFO] [stdout] 74 | relational_expression, equality_expression, AND_expression, exclusive_OR_expression, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `exclusive_or_expression` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inclusive_OR_expression` should have a snake case name [INFO] [stdout] --> benches/bench_c.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | inclusive_OR_expression, logical_AND_expression, logical_OR_expression, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `inclusive_or_expression` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `logical_AND_expression` should have a snake case name [INFO] [stdout] --> benches/bench_c.rs:75:34 [INFO] [stdout] | [INFO] [stdout] 75 | inclusive_OR_expression, logical_AND_expression, logical_OR_expression, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `logical_and_expression` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `logical_OR_expression` should have a snake case name [INFO] [stdout] --> benches/bench_c.rs:75:58 [INFO] [stdout] | [INFO] [stdout] 75 | inclusive_OR_expression, logical_AND_expression, logical_OR_expression, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `logical_or_expression` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.00s [INFO] running `Command { std: "docker" "inspect" "3e3f8081c69a7711eaca572afb3cbe9e245ee145f7fe9f845f40fa0796d33b12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e3f8081c69a7711eaca572afb3cbe9e245ee145f7fe9f845f40fa0796d33b12", kill_on_drop: false }` [INFO] [stdout] 3e3f8081c69a7711eaca572afb3cbe9e245ee145f7fe9f845f40fa0796d33b12