[INFO] fetching crate gcollections 1.6.0... [INFO] linting gcollections-1.6.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gcollections 1.6.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate gcollections 1.6.0 [INFO] finished tweaking crates.io crate gcollections 1.6.0 [INFO] tweaked toml for crates.io crate gcollections 1.6.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gcollections 1.6.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate gcollections 1.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded trilean v1.1.0 [INFO] [stderr] Downloaded bit-set v0.9.1 [INFO] [stderr] Downloaded bit-vec v0.9.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2fec2b5f4e8e8871df6fce430f31be3c80739aeae195415f068cbdda07d2ee00 [INFO] running `Command { std: "docker" "start" "-a" "2fec2b5f4e8e8871df6fce430f31be3c80739aeae195415f068cbdda07d2ee00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2fec2b5f4e8e8871df6fce430f31be3c80739aeae195415f068cbdda07d2ee00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fec2b5f4e8e8871df6fce430f31be3c80739aeae195415f068cbdda07d2ee00", kill_on_drop: false }` [INFO] [stdout] 2fec2b5f4e8e8871df6fce430f31be3c80739aeae195415f068cbdda07d2ee00 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91d7cb2725beb9a511907404a378b02c7ca3401dac496beb346fd74adc2b70fd [INFO] running `Command { std: "docker" "start" "-a" "91d7cb2725beb9a511907404a378b02c7ca3401dac496beb346fd74adc2b70fd", kill_on_drop: false }` [INFO] [stderr] Checking bit-vec v0.9.1 [INFO] [stderr] Checking trilean v1.1.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking bit-set v0.9.1 [INFO] [stderr] Checking gcollections v1.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/libgcollections/ops/cardinality.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | / /// For an explanation on the macros, see `lib.rs`. [INFO] [stdout] 29 | | [INFO] [stdout] | |_^ [INFO] [stdout] 30 | macro_rules! is_singleton_impl [INFO] [stdout] | ------------------------------ the comment documents this macro definition [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / /// This is the reason why we do not require `Lattice` to inherit from `Collection`. [INFO] [stdout] 12 | | [INFO] [stdout] | |_^ [INFO] [stdout] 13 | use trilean::SKleene; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 9 ~ //! A [lattice](https://en.wikipedia.org/wiki/Lattice_(order)) is an ordered set where every pair of elements can be combined with a `join` and `meet` operations. [INFO] [stdout] 10 ~ //! The following traits operate on an element of the lattice, and do not represent a set of elements (which would be the whole lattice). [INFO] [stdout] 11 ~ //! This is the reason why we do not require `Lattice` to inherit from `Collection`. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | test_id: test_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `test_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | data_a: data_a, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `data_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | data_b: data_b, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `data_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | expected_entailment: expected_entailment, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_entailment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | expected_join: expected_join, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_join` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | expected_meet: expected_meet [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_meet` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/bit_set.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | BitSet{bs: bs} [INFO] [stdout] | ^^^^^^ help: replace it with: `bs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/btree_set.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | BTreeSet{ts: ts} [INFO] [stdout] | ^^^^^^ help: replace it with: `ts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/hash_set.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | HashSet{hs: hs} [INFO] [stdout] | ^^^^^^ help: replace it with: `hs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:55:7 [INFO] [stdout] | [INFO] [stdout] 55 | value: value [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/vector.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | vec: vec [INFO] [stdout] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/vector_deque.rs:33:7 [INFO] [stdout] | [INFO] [stdout] 33 | deque: deque [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `deque` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/queue.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | seq: seq, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/stack.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | seq: seq, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/libgcollections/ops/cardinality.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | / /// For an explanation on the macros, see `lib.rs`. [INFO] [stdout] 29 | | [INFO] [stdout] | |_^ [INFO] [stdout] 30 | macro_rules! is_singleton_impl [INFO] [stdout] | ------------------------------ the comment documents this macro definition [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / /// This is the reason why we do not require `Lattice` to inherit from `Collection`. [INFO] [stdout] 12 | | [INFO] [stdout] | |_^ [INFO] [stdout] 13 | use trilean::SKleene; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 9 ~ //! A [lattice](https://en.wikipedia.org/wiki/Lattice_(order)) is an ordered set where every pair of elements can be combined with a `join` and `meet` operations. [INFO] [stdout] 10 ~ //! The following traits operate on an element of the lattice, and do not represent a set of elements (which would be the whole lattice). [INFO] [stdout] 11 ~ //! This is the reason why we do not require `Lattice` to inherit from `Collection`. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | test_id: test_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `test_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | data_a: data_a, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `data_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | data_b: data_b, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `data_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | expected_entailment: expected_entailment, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_entailment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | expected_join: expected_join, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_join` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | expected_meet: expected_meet [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_meet` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/bit_set.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | BitSet{bs: bs} [INFO] [stdout] | ^^^^^^ help: replace it with: `bs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/btree_set.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | BTreeSet{ts: ts} [INFO] [stdout] | ^^^^^^ help: replace it with: `ts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/hash_set.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | HashSet{hs: hs} [INFO] [stdout] | ^^^^^^ help: replace it with: `hs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:55:7 [INFO] [stdout] | [INFO] [stdout] 55 | value: value [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/vector.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | vec: vec [INFO] [stdout] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/wrappers/vector_deque.rs:33:7 [INFO] [stdout] | [INFO] [stdout] 33 | deque: deque [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `deque` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/queue.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | seq: seq, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libgcollections/stack.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | seq: seq, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SKleene` which implements the `Copy` trait [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:159:43 [INFO] [stdout] | [INFO] [stdout] 159 | self.assert_expected("a.entail(b)", ab.clone(), expected, ""); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `ab` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/bit_set.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | fn deref<'a>(&'a self) -> &'a StdBitSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 35 - fn deref<'a>(&'a self) -> &'a StdBitSet { [INFO] [stdout] 35 + fn deref(&self) -> &StdBitSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/bit_set.rs:42:16 [INFO] [stdout] | [INFO] [stdout] 42 | fn deref_mut<'a>(&'a mut self) -> &'a mut StdBitSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 42 - fn deref_mut<'a>(&'a mut self) -> &'a mut StdBitSet { [INFO] [stdout] 42 + fn deref_mut(&mut self) -> &mut StdBitSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/btree_set.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | fn deref<'a>(&'a self) -> &'a StdBTreeSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 34 - fn deref<'a>(&'a self) -> &'a StdBTreeSet { [INFO] [stdout] 34 + fn deref(&self) -> &StdBTreeSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/btree_set.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | fn deref_mut<'a>(&'a mut self) -> &'a mut StdBTreeSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 41 - fn deref_mut<'a>(&'a mut self) -> &'a mut StdBTreeSet { [INFO] [stdout] 41 + fn deref_mut(&mut self) -> &mut StdBTreeSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/hash_set.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | fn deref<'a>(&'a self) -> &'a StdHashSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 38 - fn deref<'a>(&'a self) -> &'a StdHashSet { [INFO] [stdout] 38 + fn deref(&self) -> &StdHashSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/hash_set.rs:45:16 [INFO] [stdout] | [INFO] [stdout] 45 | fn deref_mut<'a>(&'a mut self) -> &'a mut StdHashSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 45 - fn deref_mut<'a>(&'a mut self) -> &'a mut StdHashSet { [INFO] [stdout] 45 + fn deref_mut(&mut self) -> &mut StdHashSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | if let Some(ref x) = x.as_ref() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 16 - if let Some(ref x) = x.as_ref() { [INFO] [stdout] 16 + if let Some(x) = x.as_ref() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | if let Some(ref y) = y.as_ref() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 - if let Some(ref y) = y.as_ref() { [INFO] [stdout] 17 + if let Some(y) = y.as_ref() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | fn deref<'a>(&'a self) -> &'a Option { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 72 - fn deref<'a>(&'a self) -> &'a Option { [INFO] [stdout] 72 + fn deref(&self) -> &Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:79:16 [INFO] [stdout] | [INFO] [stdout] 79 | fn deref_mut<'a>(&'a mut self) -> &'a mut Option { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 79 - fn deref_mut<'a>(&'a mut self) -> &'a mut Option { [INFO] [stdout] 79 + fn deref_mut(&mut self) -> &mut Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | self.as_ref().map_or(false, |x| x == value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 244 - self.as_ref().map_or(false, |x| x == value) [INFO] [stdout] 244 + self.as_ref() == Some(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/vector.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | fn deref<'a>(&'a self) -> &'a Vec { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 41 - fn deref<'a>(&'a self) -> &'a Vec { [INFO] [stdout] 41 + fn deref(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/vector.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | fn deref_mut<'a>(&'a mut self) -> &'a mut Vec { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 48 - fn deref_mut<'a>(&'a mut self) -> &'a mut Vec { [INFO] [stdout] 48 + fn deref_mut(&mut self) -> &mut Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/vector_deque.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | fn deref<'a>(&'a self) -> &'a VecDeque { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 46 - fn deref<'a>(&'a self) -> &'a VecDeque { [INFO] [stdout] 46 + fn deref(&self) -> &VecDeque { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/vector_deque.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 53 | fn deref_mut<'a>(&'a mut self) -> &'a mut VecDeque { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 53 - fn deref_mut<'a>(&'a mut self) -> &'a mut VecDeque { [INFO] [stdout] 53 + fn deref_mut(&mut self) -> &mut VecDeque { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/queue.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | fn deref<'a>(&'a self) -> &'a S { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 45 - fn deref<'a>(&'a self) -> &'a S { [INFO] [stdout] 45 + fn deref(&self) -> &S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/queue.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 52 - fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stdout] 52 + fn deref_mut(&mut self) -> &mut S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/stack.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | fn deref<'a>(&'a self) -> &'a S { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 43 - fn deref<'a>(&'a self) -> &'a S { [INFO] [stdout] 43 + fn deref(&self) -> &S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/stack.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 50 - fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stdout] 50 + fn deref_mut(&mut self) -> &mut S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SKleene` which implements the `Copy` trait [INFO] [stdout] --> src/libgcollections/ops/lattice.rs:159:43 [INFO] [stdout] | [INFO] [stdout] 159 | self.assert_expected("a.entail(b)", ab.clone(), expected, ""); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `ab` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/bit_set.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | fn deref<'a>(&'a self) -> &'a StdBitSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 35 - fn deref<'a>(&'a self) -> &'a StdBitSet { [INFO] [stdout] 35 + fn deref(&self) -> &StdBitSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/bit_set.rs:42:16 [INFO] [stdout] | [INFO] [stdout] 42 | fn deref_mut<'a>(&'a mut self) -> &'a mut StdBitSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 42 - fn deref_mut<'a>(&'a mut self) -> &'a mut StdBitSet { [INFO] [stdout] 42 + fn deref_mut(&mut self) -> &mut StdBitSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/btree_set.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | fn deref<'a>(&'a self) -> &'a StdBTreeSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 34 - fn deref<'a>(&'a self) -> &'a StdBTreeSet { [INFO] [stdout] 34 + fn deref(&self) -> &StdBTreeSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/btree_set.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | fn deref_mut<'a>(&'a mut self) -> &'a mut StdBTreeSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 41 - fn deref_mut<'a>(&'a mut self) -> &'a mut StdBTreeSet { [INFO] [stdout] 41 + fn deref_mut(&mut self) -> &mut StdBTreeSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/hash_set.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | fn deref<'a>(&'a self) -> &'a StdHashSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 38 - fn deref<'a>(&'a self) -> &'a StdHashSet { [INFO] [stdout] 38 + fn deref(&self) -> &StdHashSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/hash_set.rs:45:16 [INFO] [stdout] | [INFO] [stdout] 45 | fn deref_mut<'a>(&'a mut self) -> &'a mut StdHashSet { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 45 - fn deref_mut<'a>(&'a mut self) -> &'a mut StdHashSet { [INFO] [stdout] 45 + fn deref_mut(&mut self) -> &mut StdHashSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | if let Some(ref x) = x.as_ref() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 16 - if let Some(ref x) = x.as_ref() { [INFO] [stdout] 16 + if let Some(x) = x.as_ref() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | if let Some(ref y) = y.as_ref() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 - if let Some(ref y) = y.as_ref() { [INFO] [stdout] 17 + if let Some(y) = y.as_ref() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | fn deref<'a>(&'a self) -> &'a Option { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 72 - fn deref<'a>(&'a self) -> &'a Option { [INFO] [stdout] 72 + fn deref(&self) -> &Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:79:16 [INFO] [stdout] | [INFO] [stdout] 79 | fn deref_mut<'a>(&'a mut self) -> &'a mut Option { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 79 - fn deref_mut<'a>(&'a mut self) -> &'a mut Option { [INFO] [stdout] 79 + fn deref_mut(&mut self) -> &mut Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | self.as_ref().map_or(false, |x| x == value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 244 - self.as_ref().map_or(false, |x| x == value) [INFO] [stdout] 244 + self.as_ref() == Some(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:519:15 [INFO] [stdout] | [INFO] [stdout] 519 | assert!(x.overlap(&y) == !r, "{:?} overlap {:?} is not equal to {:?}", x, y, !r); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `x.overlap(&y) != r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libgcollections/wrappers/optional.rs:520:15 [INFO] [stdout] | [INFO] [stdout] 520 | assert!(y.overlap(&x) == !r, "{:?} overlap {:?} is not equal to {:?}", y, x, !r); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `y.overlap(&x) != r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/libgcollections/wrappers/primitives.rs:98:7 [INFO] [stdout] | [INFO] [stdout] 98 | assert_eq!(i.is_singleton(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 98 - assert_eq!(i.is_singleton(), true); [INFO] [stdout] 98 + assert!(i.is_singleton()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/libgcollections/wrappers/primitives.rs:99:7 [INFO] [stdout] | [INFO] [stdout] 99 | assert_eq!(i.is_empty(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 99 - assert_eq!(i.is_empty(), false); [INFO] [stdout] 99 + assert!(!i.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/libgcollections/wrappers/primitives.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | assert_eq!(i.is_proper_subset(j), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 113 - assert_eq!(i.is_proper_subset(j), false); [INFO] [stdout] 113 + assert!(!i.is_proper_subset(j)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/libgcollections/wrappers/primitives.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | assert_eq!(j.is_proper_subset(i), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 114 - assert_eq!(j.is_proper_subset(i), false); [INFO] [stdout] 114 + assert!(!j.is_proper_subset(i)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/vector.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | fn deref<'a>(&'a self) -> &'a Vec { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 41 - fn deref<'a>(&'a self) -> &'a Vec { [INFO] [stdout] 41 + fn deref(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/vector.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | fn deref_mut<'a>(&'a mut self) -> &'a mut Vec { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 48 - fn deref_mut<'a>(&'a mut self) -> &'a mut Vec { [INFO] [stdout] 48 + fn deref_mut(&mut self) -> &mut Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/vector_deque.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | fn deref<'a>(&'a self) -> &'a VecDeque { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 46 - fn deref<'a>(&'a self) -> &'a VecDeque { [INFO] [stdout] 46 + fn deref(&self) -> &VecDeque { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/wrappers/vector_deque.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 53 | fn deref_mut<'a>(&'a mut self) -> &'a mut VecDeque { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 53 - fn deref_mut<'a>(&'a mut self) -> &'a mut VecDeque { [INFO] [stdout] 53 + fn deref_mut(&mut self) -> &mut VecDeque { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/queue.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | fn deref<'a>(&'a self) -> &'a S { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 45 - fn deref<'a>(&'a self) -> &'a S { [INFO] [stdout] 45 + fn deref(&self) -> &S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/queue.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 52 - fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stdout] 52 + fn deref_mut(&mut self) -> &mut S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/stack.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | fn deref<'a>(&'a self) -> &'a S { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 43 - fn deref<'a>(&'a self) -> &'a S { [INFO] [stdout] 43 + fn deref(&self) -> &S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/libgcollections/stack.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 50 - fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stdout] 50 + fn deref_mut(&mut self) -> &mut S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.38s [INFO] running `Command { std: "docker" "inspect" "91d7cb2725beb9a511907404a378b02c7ca3401dac496beb346fd74adc2b70fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91d7cb2725beb9a511907404a378b02c7ca3401dac496beb346fd74adc2b70fd", kill_on_drop: false }` [INFO] [stdout] 91d7cb2725beb9a511907404a378b02c7ca3401dac496beb346fd74adc2b70fd