[INFO] fetching crate gateutil 0.1.0... [INFO] linting gateutil-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gateutil 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate gateutil 0.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate gateutil 0.1.0 [INFO] tweaked toml for crates.io crate gateutil 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gateutil 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gatesim v0.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c01a293dbdcf46da43f7b7b4d6a9f94f0eeb8d9fe2eed55f665f386f32493c1e [INFO] running `Command { std: "docker" "start" "-a" "c01a293dbdcf46da43f7b7b4d6a9f94f0eeb8d9fe2eed55f665f386f32493c1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c01a293dbdcf46da43f7b7b4d6a9f94f0eeb8d9fe2eed55f665f386f32493c1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c01a293dbdcf46da43f7b7b4d6a9f94f0eeb8d9fe2eed55f665f386f32493c1e", kill_on_drop: false }` [INFO] [stdout] c01a293dbdcf46da43f7b7b4d6a9f94f0eeb8d9fe2eed55f665f386f32493c1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ea404d54681ae3652c87b1d5621ca0c10acad4c99faee6e3c81fce3373b6840 [INFO] running `Command { std: "docker" "start" "-a" "4ea404d54681ae3652c87b1d5621ca0c10acad4c99faee6e3c81fce3373b6840", kill_on_drop: false }` [INFO] [stderr] Checking gatesim v0.1.1 [INFO] [stderr] Checking gateutil v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/lib.rs:627:20 [INFO] [stdout] | [INFO] [stdout] 627 | pub fn deduplicate(circuit: Circuit) -> Circuit [INFO] [stdout] | ^ [INFO] [stdout] 628 | where [INFO] [stdout] 629 | T: Default + TryFrom, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/lib.rs:627:20 [INFO] [stdout] | [INFO] [stdout] 627 | pub fn deduplicate(circuit: Circuit) -> Circuit [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 633 | T: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/lib.rs:627:20 [INFO] [stdout] | [INFO] [stdout] 627 | pub fn deduplicate(circuit: Circuit) -> Circuit [INFO] [stdout] | ^ [INFO] [stdout] 628 | where [INFO] [stdout] 629 | T: Default + TryFrom, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/lib.rs:627:20 [INFO] [stdout] | [INFO] [stdout] 627 | pub fn deduplicate(circuit: Circuit) -> Circuit [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 633 | T: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/join_clauses.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | / match output_map[o] { [INFO] [stdout] 104 | | OutputEntryN::NewIndex(ni, omn) => { [INFO] [stdout] 105 | | let ni = usize::try_from(ni).unwrap(); [INFO] [stdout] 106 | | if let Some(dups) = output_dups.get_mut(&ni) { [INFO] [stdout] ... | [INFO] [stdout] 112 | | _ => (), [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 103 ~ if let OutputEntryN::NewIndex(ni, omn) = output_map[o] { [INFO] [stdout] 104 + let ni = usize::try_from(ni).unwrap(); [INFO] [stdout] 105 + if let Some(dups) = output_dups.get_mut(&ni) { [INFO] [stdout] 106 + dups.push((o, omn)); [INFO] [stdout] 107 + } else { [INFO] [stdout] 108 + output_dups.insert(ni, vec![(o, omn)]); [INFO] [stdout] 109 + } [INFO] [stdout] 110 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/dedup_clauses.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / impl PartialOrd for DedupClause { [INFO] [stdout] 22 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 23 | | if self.orig_index == other.orig_index { [INFO] [stdout] 24 | | Some(self.extra_index.as_ref().cmp(&other.extra_index.as_ref())) [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 23 - if self.orig_index == other.orig_index { [INFO] [stdout] 24 - Some(self.extra_index.as_ref().cmp(&other.extra_index.as_ref())) [INFO] [stdout] 25 - } else { [INFO] [stdout] 26 - Some(self.orig_index.cmp(&other.orig_index)) [INFO] [stdout] 27 - } [INFO] [stdout] 28 - } [INFO] [stdout] 22 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/dedup_clauses.rs:37:45 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn translate_clauses(clauses: &mut Vec>, trans_table: &HashMap) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - pub(crate) fn translate_clauses(clauses: &mut Vec>, trans_table: &HashMap) [INFO] [stdout] 37 + pub(crate) fn translate_clauses(clauses: &mut [DedupClause], trans_table: &HashMap) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/dedup_clauses.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | while let Some(bv) = b.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for bv in b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/dedup_clauses.rs:236:34 [INFO] [stdout] | [INFO] [stdout] 236 | let mut same_occur_lits: Vec<(Vec<(T, bool)>, Vec)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/dedup_clauses.rs:350:57 [INFO] [stdout] | [INFO] [stdout] 350 | let mut pairlit_clause_map = Vec::from_iter(pairlit_clause_map.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:152:20 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 350 - let mut pairlit_clause_map = Vec::from_iter(pairlit_clause_map.into_iter()); [INFO] [stdout] 350 + let mut pairlit_clause_map = Vec::from_iter(pairlit_clause_map); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/dedup_clauses.rs:393:18 [INFO] [stdout] | [INFO] [stdout] 393 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/dedup_clauses.rs:699:18 [INFO] [stdout] | [INFO] [stdout] 699 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:86:10 [INFO] [stdout] | [INFO] [stdout] 86 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:173:10 [INFO] [stdout] | [INFO] [stdout] 173 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:178:25 [INFO] [stdout] | [INFO] [stdout] 178 | circuit.gates().into_iter().cloned(), [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:232:10 [INFO] [stdout] | [INFO] [stdout] 232 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:290:10 [INFO] [stdout] | [INFO] [stdout] 290 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/lib.rs:504:14 [INFO] [stdout] | [INFO] [stdout] 504 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/lib.rs:642:20 [INFO] [stdout] | [INFO] [stdout] 642 | .chain(iter::repeat(T::default()).take(circuit.len())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(T::default(), circuit.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:645:35 [INFO] [stdout] | [INFO] [stdout] 645 | for (i, g) in circuit.gates().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:675:10 [INFO] [stdout] | [INFO] [stdout] 675 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:715:10 [INFO] [stdout] | [INFO] [stdout] 715 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:786:35 [INFO] [stdout] | [INFO] [stdout] 786 | for (i, g) in circuit.gates().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:1323:29 [INFO] [stdout] | [INFO] [stdout] 1323 | for (i, e) in input_map.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:1426:20 [INFO] [stdout] | [INFO] [stdout] 1426 | if !(p < l) { [INFO] [stdout] | ^^^^^^^^ help: try: `(p >= l)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/lib.rs:1846:21 [INFO] [stdout] | [INFO] [stdout] 1846 | let stage_num = (max_depth_u + depth_in_stage - 1) / depth_in_stage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `max_depth_u.div_ceil(depth_in_stage)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `cur_wires_tbl` [INFO] [stdout] --> src/lib.rs:1922:14 [INFO] [stdout] | [INFO] [stdout] 1922 | for i in 0..input_len { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1922 - for i in 0..input_len { [INFO] [stdout] 1922 + for (i, ) in cur_wires_tbl.iter_mut().enumerate().take(input_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> tests/lib2.rs:2274:24 [INFO] [stdout] | [INFO] [stdout] 2274 | (0..9).map(|x| Some(x)).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> tests/lib2.rs:2275:24 [INFO] [stdout] | [INFO] [stdout] 2275 | (0..9).map(|x| OutputEntry::NewIndex(x)).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `OutputEntry::NewIndex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> tests/lib2.rs:2381:24 [INFO] [stdout] | [INFO] [stdout] 2381 | (0..9).map(|x| Some(x)).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> tests/lib2.rs:2382:24 [INFO] [stdout] | [INFO] [stdout] 2382 | (0..9).map(|x| OutputEntry::NewIndex(x)).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `OutputEntry::NewIndex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/join_clauses.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | / match output_map[o] { [INFO] [stdout] 104 | | OutputEntryN::NewIndex(ni, omn) => { [INFO] [stdout] 105 | | let ni = usize::try_from(ni).unwrap(); [INFO] [stdout] 106 | | if let Some(dups) = output_dups.get_mut(&ni) { [INFO] [stdout] ... | [INFO] [stdout] 112 | | _ => (), [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 103 ~ if let OutputEntryN::NewIndex(ni, omn) = output_map[o] { [INFO] [stdout] 104 + let ni = usize::try_from(ni).unwrap(); [INFO] [stdout] 105 + if let Some(dups) = output_dups.get_mut(&ni) { [INFO] [stdout] 106 + dups.push((o, omn)); [INFO] [stdout] 107 + } else { [INFO] [stdout] 108 + output_dups.insert(ni, vec![(o, omn)]); [INFO] [stdout] 109 + } [INFO] [stdout] 110 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/dedup_clauses.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / impl PartialOrd for DedupClause { [INFO] [stdout] 22 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 23 | | if self.orig_index == other.orig_index { [INFO] [stdout] 24 | | Some(self.extra_index.as_ref().cmp(&other.extra_index.as_ref())) [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 23 - if self.orig_index == other.orig_index { [INFO] [stdout] 24 - Some(self.extra_index.as_ref().cmp(&other.extra_index.as_ref())) [INFO] [stdout] 25 - } else { [INFO] [stdout] 26 - Some(self.orig_index.cmp(&other.orig_index)) [INFO] [stdout] 27 - } [INFO] [stdout] 28 - } [INFO] [stdout] 22 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/dedup_clauses.rs:37:45 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn translate_clauses(clauses: &mut Vec>, trans_table: &HashMap) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - pub(crate) fn translate_clauses(clauses: &mut Vec>, trans_table: &HashMap) [INFO] [stdout] 37 + pub(crate) fn translate_clauses(clauses: &mut [DedupClause], trans_table: &HashMap) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/dedup_clauses.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | while let Some(bv) = b.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for bv in b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/dedup_clauses.rs:236:34 [INFO] [stdout] | [INFO] [stdout] 236 | let mut same_occur_lits: Vec<(Vec<(T, bool)>, Vec)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/dedup_clauses.rs:350:57 [INFO] [stdout] | [INFO] [stdout] 350 | let mut pairlit_clause_map = Vec::from_iter(pairlit_clause_map.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:152:20 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 350 - let mut pairlit_clause_map = Vec::from_iter(pairlit_clause_map.into_iter()); [INFO] [stdout] 350 + let mut pairlit_clause_map = Vec::from_iter(pairlit_clause_map); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/dedup_clauses.rs:393:18 [INFO] [stdout] | [INFO] [stdout] 393 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/dedup_clauses.rs:699:18 [INFO] [stdout] | [INFO] [stdout] 699 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:86:10 [INFO] [stdout] | [INFO] [stdout] 86 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:173:10 [INFO] [stdout] | [INFO] [stdout] 173 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:178:25 [INFO] [stdout] | [INFO] [stdout] 178 | circuit.gates().into_iter().cloned(), [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:232:10 [INFO] [stdout] | [INFO] [stdout] 232 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:290:10 [INFO] [stdout] | [INFO] [stdout] 290 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/lib.rs:504:14 [INFO] [stdout] | [INFO] [stdout] 504 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/lib.rs:642:20 [INFO] [stdout] | [INFO] [stdout] 642 | .chain(iter::repeat(T::default()).take(circuit.len())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(T::default(), circuit.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:645:35 [INFO] [stdout] | [INFO] [stdout] 645 | for (i, g) in circuit.gates().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:675:10 [INFO] [stdout] | [INFO] [stdout] 675 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:715:10 [INFO] [stdout] | [INFO] [stdout] 715 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:786:35 [INFO] [stdout] | [INFO] [stdout] 786 | for (i, g) in circuit.gates().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/lib.rs:1323:29 [INFO] [stdout] | [INFO] [stdout] 1323 | for (i, e) in input_map.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:1426:20 [INFO] [stdout] | [INFO] [stdout] 1426 | if !(p < l) { [INFO] [stdout] | ^^^^^^^^ help: try: `(p >= l)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/lib.rs:1846:21 [INFO] [stdout] | [INFO] [stdout] 1846 | let stage_num = (max_depth_u + depth_in_stage - 1) / depth_in_stage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `max_depth_u.div_ceil(depth_in_stage)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `cur_wires_tbl` [INFO] [stdout] --> src/lib.rs:1922:14 [INFO] [stdout] | [INFO] [stdout] 1922 | for i in 0..input_len { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1922 - for i in 0..input_len { [INFO] [stdout] 1922 + for (i, ) in cur_wires_tbl.iter_mut().enumerate().take(input_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/lib.rs:2094:33 [INFO] [stdout] | [INFO] [stdout] 2094 | Clause::new_and(std::iter::repeat((2, false)).take(i)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n((2, false), i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/lib.rs:2103:33 [INFO] [stdout] | [INFO] [stdout] 2103 | Clause::new_xor(std::iter::repeat((2, false)).take(i)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n((2, false), i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.32s [INFO] running `Command { std: "docker" "inspect" "4ea404d54681ae3652c87b1d5621ca0c10acad4c99faee6e3c81fce3373b6840", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ea404d54681ae3652c87b1d5621ca0c10acad4c99faee6e3c81fce3373b6840", kill_on_drop: false }` [INFO] [stdout] 4ea404d54681ae3652c87b1d5621ca0c10acad4c99faee6e3c81fce3373b6840