[INFO] fetching crate gategen2 0.1.0... [INFO] linting gategen2-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate gategen2 0.1.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate gategen2 0.1.0 [INFO] finished tweaking crates.io crate gategen2 0.1.0 [INFO] tweaked toml for crates.io crate gategen2 0.1.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate gategen2 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate gategen2 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gateutil v0.1.0 [INFO] [stderr] Downloaded gate_calc_log_bits v0.1.0 [INFO] [stderr] Downloaded gatesim v0.1.1 [INFO] [stderr] Downloaded itoap v1.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2697b249e185927bec374edb70cc5ac3ccc4303734478ace03d02c780bfa8f75 [INFO] running `Command { std: "docker" "start" "-a" "2697b249e185927bec374edb70cc5ac3ccc4303734478ace03d02c780bfa8f75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2697b249e185927bec374edb70cc5ac3ccc4303734478ace03d02c780bfa8f75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2697b249e185927bec374edb70cc5ac3ccc4303734478ace03d02c780bfa8f75", kill_on_drop: false }` [INFO] [stdout] 2697b249e185927bec374edb70cc5ac3ccc4303734478ace03d02c780bfa8f75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9fc6d3263bd9cf3db7d7e613e5e22ba524ae5a1168f8908938e4da09fe90f15e [INFO] running `Command { std: "docker" "start" "-a" "9fc6d3263bd9cf3db7d7e613e5e22ba524ae5a1168f8908938e4da09fe90f15e", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Checking itoap v1.0.1 [INFO] [stderr] Checking gate_calc_log_bits v0.1.0 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking generic-array v1.3.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking gatesim v0.1.1 [INFO] [stderr] Checking gateutil v0.1.0 [INFO] [stderr] Checking gategen2 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/dynintexpr/arith.rs:1166:1 [INFO] [stdout] | [INFO] [stdout] 1166 | / /// Most advanced: multiplication. [INFO] [stdout] 1167 | | [INFO] [stdout] | |_^ [INFO] [stdout] 1168 | impl IntModMul> for DynIntExprNode [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/dynintexpr/arith.rs:1258:1 [INFO] [stdout] | [INFO] [stdout] 1258 | / /// Full multiplication [INFO] [stdout] 1259 | | [INFO] [stdout] | |_^ [INFO] [stdout] 1260 | impl FullMul> for DynIntExprNode [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/dynintexpr/arith.rs:1166:1 [INFO] [stdout] | [INFO] [stdout] 1166 | / /// Most advanced: multiplication. [INFO] [stdout] 1167 | | [INFO] [stdout] | |_^ [INFO] [stdout] 1168 | impl IntModMul> for DynIntExprNode [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/dynintexpr/arith.rs:1258:1 [INFO] [stdout] | [INFO] [stdout] 1258 | / /// Full multiplication [INFO] [stdout] 1259 | | [INFO] [stdout] | |_^ [INFO] [stdout] 1260 | impl FullMul> for DynIntExprNode [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/intexpr/int_arith.rs:390:1 [INFO] [stdout] | [INFO] [stdout] 390 | / /// Most advanced: multiplication. [INFO] [stdout] 391 | | [INFO] [stdout] | |_^ [INFO] [stdout] 392 | impl IntModMul> for IntExprNode [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/intexpr/int_arith.rs:489:1 [INFO] [stdout] | [INFO] [stdout] 489 | / /// Full multiplication [INFO] [stdout] 490 | | [INFO] [stdout] | |_^ [INFO] [stdout] 491 | impl FullMul> for IntExprNode [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/intexpr/int_arith.rs:751:1 [INFO] [stdout] | [INFO] [stdout] 751 | / /// Division and remainder [INFO] [stdout] 752 | | [INFO] [stdout] | |_^ [INFO] [stdout] 753 | macro_rules! impl_int_div_mod { [INFO] [stdout] | ----------------------------- the comment documents this macro definition [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/intexpr/int_arith.rs:390:1 [INFO] [stdout] | [INFO] [stdout] 390 | / /// Most advanced: multiplication. [INFO] [stdout] 391 | | [INFO] [stdout] | |_^ [INFO] [stdout] 392 | impl IntModMul> for IntExprNode [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/intexpr/int_arith.rs:489:1 [INFO] [stdout] | [INFO] [stdout] 489 | / /// Full multiplication [INFO] [stdout] 490 | | [INFO] [stdout] | |_^ [INFO] [stdout] 491 | impl FullMul> for IntExprNode [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/intexpr/int_arith.rs:751:1 [INFO] [stdout] | [INFO] [stdout] 751 | / /// Division and remainder [INFO] [stdout] 752 | | [INFO] [stdout] | |_^ [INFO] [stdout] 753 | macro_rules! impl_int_div_mod { [INFO] [stdout] | ----------------------------- the comment documents this macro definition [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/gate.rs:230:6 [INFO] [stdout] | [INFO] [stdout] 230 | impl<'a, T> Clause for &'a [T] [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 230 - impl<'a, T> Clause for &'a [T] [INFO] [stdout] 230 + impl Clause for &[T] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/boolexpr.rs:266:14 [INFO] [stdout] | [INFO] [stdout] 266 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/boolexpr.rs:361:26 [INFO] [stdout] | [INFO] [stdout] 361 | let (list, assigns): ( [INFO] [stdout] | __________________________^ [INFO] [stdout] 362 | | Vec::Unsigned>>, [INFO] [stdout] 363 | | Vec::Unsigned>>, [INFO] [stdout] 364 | | ) = iter [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/boolexpr.rs:379:26 [INFO] [stdout] | [INFO] [stdout] 379 | list.into_iter().filter_map(|x| x).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/boolexpr_creator.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | / match node { [INFO] [stdout] 233 | | Node::Single(l) => { [INFO] [stdout] 234 | | if let Some(l) = l.varlit() { [INFO] [stdout] 235 | | let lp = l.positive().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 246 | | _ => {} [INFO] [stdout] 247 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 232 ~ if let Node::Single(l) = node { [INFO] [stdout] 233 + if let Some(l) = l.varlit() { [INFO] [stdout] 234 + let lp = l.positive().unwrap(); [INFO] [stdout] 235 + if !input_map.contains_key(&lp) { [INFO] [stdout] 236 + input_map.insert( [INFO] [stdout] 237 + lp, [INFO] [stdout] 238 + Unsigned::::try_from(input_map.len()).unwrap(), [INFO] [stdout] 239 + ); [INFO] [stdout] 240 + } [INFO] [stdout] 241 + } else { [INFO] [stdout] 242 + panic!("Unsupported!"); [INFO] [stdout] 243 + } [INFO] [stdout] 244 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/boolexpr_creator.rs:480:21 [INFO] [stdout] | [INFO] [stdout] 480 | / match node { [INFO] [stdout] 481 | | Node::Single(l) => { [INFO] [stdout] 482 | | visited[node_index] = true; [INFO] [stdout] 483 | | if let Some(l) = l.varlit() { [INFO] [stdout] ... | [INFO] [stdout] 495 | | _ => {} [INFO] [stdout] 496 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 480 ~ if let Node::Single(l) = node { [INFO] [stdout] 481 + visited[node_index] = true; [INFO] [stdout] 482 + if let Some(l) = l.varlit() { [INFO] [stdout] 483 + let lp = l.positive().unwrap(); [INFO] [stdout] 484 + if !input_map.contains_key(&lp) { [INFO] [stdout] 485 + input_map.insert( [INFO] [stdout] 486 + lp, [INFO] [stdout] 487 + Unsigned::::try_from(input_map.len()).unwrap(), [INFO] [stdout] 488 + ); [INFO] [stdout] 489 + } [INFO] [stdout] 490 + } else { [INFO] [stdout] 491 + panic!("Unsupported!"); [INFO] [stdout] 492 + } [INFO] [stdout] 493 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:541:55 [INFO] [stdout] | [INFO] [stdout] 541 | let (gi, n) = gate_output_map.get(&fidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `fidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:545:57 [INFO] [stdout] | [INFO] [stdout] 545 | let (gi1, n1) = gate_output_map.get(&fidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `fidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:546:57 [INFO] [stdout] | [INFO] [stdout] 546 | let (gi2, n2) = gate_output_map.get(&sidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `sidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:565:57 [INFO] [stdout] | [INFO] [stdout] 565 | let (gi1, n1) = gate_output_map.get(&fidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `fidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:566:57 [INFO] [stdout] | [INFO] [stdout] 566 | let (gi2, n2) = gate_output_map.get(&sidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `sidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:584:57 [INFO] [stdout] | [INFO] [stdout] 584 | let (gi1, n1) = gate_output_map.get(&fidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `fidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:585:57 [INFO] [stdout] | [INFO] [stdout] 585 | let (gi2, n2) = gate_output_map.get(&sidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `sidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:605:57 [INFO] [stdout] | [INFO] [stdout] 605 | let (gi1, n1) = gate_output_map.get(&fidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `fidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/boolexpr_creator.rs:606:57 [INFO] [stdout] | [INFO] [stdout] 606 | let (gi2, n2) = gate_output_map.get(&sidx).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `sidx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/boolvar.rs:54:54 [INFO] [stdout] | [INFO] [stdout] 54 | pub(crate) static EC_HISTORY_ORDER: Cell = Cell::new(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `const { Cell::new(false) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/boolvar.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | RefCell::new(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(None) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/boolvar.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | RefCell::new(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(None) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/boolvar.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | RefCell::new(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(None) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/dynintexpr/arith.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | indexes: (0..self.indexes.len()) [INFO] [stdout] | ______________________^ [INFO] [stdout] 81 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(0..self.indexes.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/dynintexpr/arith.rs:741:5 [INFO] [stdout] | [INFO] [stdout] 741 | / let mut chooser_table = vec![]; [INFO] [stdout] 742 | | chooser_table.push(!index.bit(k - 1)); [INFO] [stdout] 743 | | chooser_table.push(index.bit(k - 1)); [INFO] [stdout] | |_________________________________________^ help: consider using the `vec![]` macro: `let mut chooser_table = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `chooser_table` [INFO] [stdout] --> src/dynintexpr/arith.rs:746:18 [INFO] [stdout] | [INFO] [stdout] 746 | for i in 0..1 << l { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 746 - for i in 0..1 << l { [INFO] [stdout] 746 + for in chooser_table.iter().take(1 << l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/dynintexpr/arith.rs:773:5 [INFO] [stdout] | [INFO] [stdout] 773 | / let mut chooser_table = vec![]; [INFO] [stdout] 774 | | chooser_table.push(!index.bit(k - 1)); [INFO] [stdout] 775 | | chooser_table.push(index.bit(k - 1)); [INFO] [stdout] | |_________________________________________^ help: consider using the `vec![]` macro: `let mut chooser_table = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `chooser_table` [INFO] [stdout] --> src/dynintexpr/arith.rs:778:18 [INFO] [stdout] | [INFO] [stdout] 778 | for i in 0..1 << l { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 778 - for i in 0..1 << l { [INFO] [stdout] 778 + for in chooser_table.iter().take(1 << l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/dynintexpr/mod.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | / (0..n) [INFO] [stdout] 115 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(0..n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/dynintexpr/mod.rs:387:24 [INFO] [stdout] | [INFO] [stdout] 387 | .chain(rest.indexes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 387 - .chain(rest.indexes.into_iter()) [INFO] [stdout] 387 + .chain(rest.indexes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dynintexpr/mod.rs:635:6 [INFO] [stdout] | [INFO] [stdout] 635 | impl<'a, T, const SIGN: bool> BitVal for &'a DynIntExprNode [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 635 - impl<'a, T, const SIGN: bool> BitVal for &'a DynIntExprNode [INFO] [stdout] 635 + impl BitVal for &DynIntExprNode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter` [INFO] [stdout] --> src/dynintvar/mod.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | / pub fn from_iter>>(iter: impl IntoIterator) -> Self { [INFO] [stdout] 158 | | Self(DynIntExprNode::from_boolexprs( [INFO] [stdout] 159 | | iter.into_iter().map(|x| BoolExprNode::from(x.into())), [INFO] [stdout] 160 | | )) [INFO] [stdout] 161 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::FromIterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/dynintvar/mod.rs:232:57 [INFO] [stdout] | [INFO] [stdout] 232 | .to_translated_circuit(iter.into_iter().map(|x| BoolExprNode::from(x))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BoolExprNode::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/dynintvar/mod.rs:255:68 [INFO] [stdout] | [INFO] [stdout] 255 | .to_translated_and_filled_circuit(iter.into_iter().map(|x| BoolExprNode::from(x))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BoolExprNode::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/dynintvar/mod.rs:284:66 [INFO] [stdout] | [INFO] [stdout] 284 | .to_translated_circuit_with_map(iter.into_iter().map(|x| BoolExprNode::from(x))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BoolExprNode::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/dynintvar/mod.rs:370:18 [INFO] [stdout] | [INFO] [stdout] 370 | .map(|x| { [INFO] [stdout] | __________________^ [INFO] [stdout] 371 | | let v = x.iter().collect::>(); [INFO] [stdout] 372 | | v.into_iter() [INFO] [stdout] 373 | | }) [INFO] [stdout] 374 | | .flatten(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 370 ~ .flat_map(|x| { [INFO] [stdout] 371 + let v = x.iter().collect::>(); [INFO] [stdout] 372 + v.into_iter() [INFO] [stdout] 373 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dynintvar/mod.rs:540:6 [INFO] [stdout] | [INFO] [stdout] 540 | impl<'a, T, const SIGN: bool> BitVal for &'a DynIntVar [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 540 - impl<'a, T, const SIGN: bool> BitVal for &'a DynIntVar [INFO] [stdout] 540 + impl BitVal for &DynIntVar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/dynintvar/mod.rs:1353:20 [INFO] [stdout] | [INFO] [stdout] 1353 | .chain(std::iter::repeat(fill.into()).take((1 << k) - tbl_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fill.into(), (1 << k) - tbl_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/dynintvar/mod.rs:1408:20 [INFO] [stdout] | [INFO] [stdout] 1408 | .chain(std::iter::repeat(fill.into().into()).take((1 << k) - tbl_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fill.into().into(), (1 << k) - tbl_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/dynintvar/mod.rs:1507:20 [INFO] [stdout] | [INFO] [stdout] 1507 | .chain(std::iter::repeat(fill.into()).take((1 << k) - tbl_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fill.into(), (1 << k) - tbl_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/dynintvar/mod.rs:1564:20 [INFO] [stdout] | [INFO] [stdout] 1564 | .chain(std::iter::repeat(fill.into().into()).take((1 << k) - tbl_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fill.into().into(), (1 << k) - tbl_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/int_utils.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | let mut matrix = (0..col_num).into_iter().map(|_| vec![]).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..col_num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/intexpr/traits.rs:645:6 [INFO] [stdout] | [INFO] [stdout] 645 | impl<'a, T, N, const SIGN: bool> BitVal for &'a IntExprNode [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 645 - impl<'a, T, N, const SIGN: bool> BitVal for &'a IntExprNode [INFO] [stdout] 645 + impl BitVal for &IntExprNode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/intexpr/traits.rs:678:50 [INFO] [stdout] | [INFO] [stdout] 678 | indexes: GenericArray::try_from_iter(iter::repeat(t.index).take(N::USIZE)).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(t.index, N::USIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` [INFO] [stdout] --> src/intexpr/traits.rs:1132:24 [INFO] [stdout] | [INFO] [stdout] 1132 | fn is_power_of_two(self) -> Self::BoolOutput; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/intexpr/bin_arith.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | (0..N::USIZE).into_iter().map(|x| (!self.bit(x)).index), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..N::USIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/intexpr/mod.rs:274:17 [INFO] [stdout] | [INFO] [stdout] 274 | iter::repeat(creator.borrow_mut().single(v)).take(N::USIZE), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(creator.borrow_mut().single(v), N::USIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/intexpr/mod.rs:284:50 [INFO] [stdout] | [INFO] [stdout] 284 | indexes: GenericArray::try_from_iter(iter::repeat(v.index).take(N::USIZE)).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(v.index, N::USIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/intexpr/mod.rs:1049:5 [INFO] [stdout] | [INFO] [stdout] 1049 | / let mut chooser_table = vec![]; [INFO] [stdout] 1050 | | chooser_table.push(!index.bit(K::USIZE - 1)); [INFO] [stdout] 1051 | | chooser_table.push(index.bit(K::USIZE - 1)); [INFO] [stdout] | |________________________________________________^ help: consider using the `vec![]` macro: `let mut chooser_table = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `chooser_table` [INFO] [stdout] --> src/intexpr/mod.rs:1054:18 [INFO] [stdout] | [INFO] [stdout] 1054 | for i in 0..1 << l { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1054 - for i in 0..1 << l { [INFO] [stdout] 1054 + for in chooser_table.iter().take(1 << l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/intexpr/mod.rs:1081:5 [INFO] [stdout] | [INFO] [stdout] 1081 | / let mut chooser_table = vec![]; [INFO] [stdout] 1082 | | chooser_table.push(!index.bit(K::USIZE - 1)); [INFO] [stdout] 1083 | | chooser_table.push(index.bit(K::USIZE - 1)); [INFO] [stdout] | |________________________________________________^ help: consider using the `vec![]` macro: `let mut chooser_table = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `chooser_table` [INFO] [stdout] --> src/intexpr/mod.rs:1086:18 [INFO] [stdout] | [INFO] [stdout] 1086 | for i in 0..1 << l { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1086 - for i in 0..1 << l { [INFO] [stdout] 1086 + for in chooser_table.iter().take(1 << l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter` [INFO] [stdout] --> src/intvar/mod.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | / pub fn from_iter>>(iter: impl IntoIterator) -> Option { [INFO] [stdout] 208 | | IntExprNode::from_boolexprs(iter.into_iter().map(|x| BoolExprNode::from(x.into()))) [INFO] [stdout] 209 | | .map(|x| Self(x)) [INFO] [stdout] 210 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::FromIterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/intvar/mod.rs:269:57 [INFO] [stdout] | [INFO] [stdout] 269 | .to_translated_circuit(iter.into_iter().map(|x| BoolExprNode::from(x))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BoolExprNode::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/intvar/mod.rs:292:68 [INFO] [stdout] | [INFO] [stdout] 292 | .to_translated_and_filled_circuit(iter.into_iter().map(|x| BoolExprNode::from(x))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BoolExprNode::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/intvar/mod.rs:321:66 [INFO] [stdout] | [INFO] [stdout] 321 | .to_translated_circuit_with_map(iter.into_iter().map(|x| BoolExprNode::from(x))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BoolExprNode::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/intvar/mod.rs:414:18 [INFO] [stdout] | [INFO] [stdout] 414 | .map(|x| { [INFO] [stdout] | __________________^ [INFO] [stdout] 415 | | let v = x.iter().collect::>(); [INFO] [stdout] 416 | | v.into_iter() [INFO] [stdout] 417 | | }) [INFO] [stdout] 418 | | .flatten(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 414 ~ .flat_map(|x| { [INFO] [stdout] 415 + let v = x.iter().collect::>(); [INFO] [stdout] 416 + v.into_iter() [INFO] [stdout] 417 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/intvar/mod.rs:694:6 [INFO] [stdout] | [INFO] [stdout] 694 | impl<'a, T, N, const SIGN: bool> BitVal for &'a IntVar [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 694 - impl<'a, T, N, const SIGN: bool> BitVal for &'a IntVar [INFO] [stdout] 694 + impl BitVal for &IntVar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/intvar/mod.rs:1496:20 [INFO] [stdout] | [INFO] [stdout] 1496 | .chain(std::iter::repeat(fill.into()).take((1 << K::USIZE) - tbl_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fill.into(), (1 << K::USIZE) - tbl_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/intvar/mod.rs:1552:20 [INFO] [stdout] | [INFO] [stdout] 1552 | .chain(std::iter::repeat(fill.into().into()).take((1 << K::USIZE) - tbl_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fill.into().into(), (1 << K::USIZE) - tbl_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/intvar/mod.rs:1657:20 [INFO] [stdout] | [INFO] [stdout] 1657 | .chain(std::iter::repeat(fill.into()).take((1 << K::USIZE) - tbl_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fill.into(), (1 << K::USIZE) - tbl_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/intvar/mod.rs:1715:20 [INFO] [stdout] | [INFO] [stdout] 1715 | .chain(std::iter::repeat(fill.into().into()).take((1 << K::USIZE) - tbl_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fill.into().into(), (1 << K::USIZE) - tbl_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gategen2` (lib test); 5 warnings emitted [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `/opt/rustwide/rustup-home/toolchains/nightly-x86_64-unknown-linux-gnu/bin/clippy-driver /opt/rustwide/rustup-home/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustc --crate-name gategen2 --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 --test --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values())' -C metadata=8efe3b588d877746 -C extra-filename=-c86a4288dedac87a --out-dir /opt/rustwide/target/debug/deps -L dependency=/opt/rustwide/target/debug/deps --extern gate_calc_log_bits=/opt/rustwide/target/debug/deps/libgate_calc_log_bits-fff015fd82ede227.rmeta --extern gateutil=/opt/rustwide/target/debug/deps/libgateutil-22c7aea63eaae0b0.rmeta --extern generic_array=/opt/rustwide/target/debug/deps/libgeneric_array-e6fb5056b0e2006f.rmeta --extern itoap=/opt/rustwide/target/debug/deps/libitoap-ea15dffda2af9262.rmeta --extern thiserror=/opt/rustwide/target/debug/deps/libthiserror-73d9ffdf072d5684.rmeta --cap-lints=forbid` (signal: 9, SIGKILL: kill) [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9fc6d3263bd9cf3db7d7e613e5e22ba524ae5a1168f8908938e4da09fe90f15e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fc6d3263bd9cf3db7d7e613e5e22ba524ae5a1168f8908938e4da09fe90f15e", kill_on_drop: false }` [INFO] [stdout] 9fc6d3263bd9cf3db7d7e613e5e22ba524ae5a1168f8908938e4da09fe90f15e