[INFO] fetching crate garden-ratelimiter 0.1.1... [INFO] linting garden-ratelimiter-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate garden-ratelimiter 0.1.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate garden-ratelimiter 0.1.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate garden-ratelimiter 0.1.1 [INFO] tweaked toml for crates.io crate garden-ratelimiter 0.1.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate garden-ratelimiter 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate garden-ratelimiter 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9b7421daeb734459e0cba087910e5ac619d28fc41b3f4c6ed05b08870004d9b [INFO] running `Command { std: "docker" "start" "-a" "b9b7421daeb734459e0cba087910e5ac619d28fc41b3f4c6ed05b08870004d9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9b7421daeb734459e0cba087910e5ac619d28fc41b3f4c6ed05b08870004d9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9b7421daeb734459e0cba087910e5ac619d28fc41b3f4c6ed05b08870004d9b", kill_on_drop: false }` [INFO] [stdout] b9b7421daeb734459e0cba087910e5ac619d28fc41b3f4c6ed05b08870004d9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a9013f296c049e8e05de48db128714fb3551ff58b34202232f3096cf633413f [INFO] running `Command { std: "docker" "start" "-a" "9a9013f296c049e8e05de48db128714fb3551ff58b34202232f3096cf633413f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling moka v0.12.10 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking lock_api v0.4.13 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking garden-ratelimiter v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RateLimiter` [INFO] [stdout] --> src/ratelimiter.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | / pub fn new() -> Self { [INFO] [stdout] 151 | | let cache = moka::future::Cache::builder() [INFO] [stdout] 152 | | .time_to_live(std::time::Duration::from_secs(DEFAULT_CACHE_TTL)) [INFO] [stdout] 153 | | .build(); [INFO] [stdout] 154 | | let allow_list = moka::future::Cache::builder().build(); [INFO] [stdout] 155 | | Self { cache, allow_list } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 146 + impl Default for RateLimiter { [INFO] [stdout] 147 + fn default() -> Self { [INFO] [stdout] 148 + Self::new() [INFO] [stdout] 149 + } [INFO] [stdout] 150 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RateLimiter` [INFO] [stdout] --> src/ratelimiter.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | / pub fn new() -> Self { [INFO] [stdout] 151 | | let cache = moka::future::Cache::builder() [INFO] [stdout] 152 | | .time_to_live(std::time::Duration::from_secs(DEFAULT_CACHE_TTL)) [INFO] [stdout] 153 | | .build(); [INFO] [stdout] 154 | | let allow_list = moka::future::Cache::builder().build(); [INFO] [stdout] 155 | | Self { cache, allow_list } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 146 + impl Default for RateLimiter { [INFO] [stdout] 147 + fn default() -> Self { [INFO] [stdout] 148 + Self::new() [INFO] [stdout] 149 + } [INFO] [stdout] 150 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ratelimiter.rs:266:17 [INFO] [stdout] | [INFO] [stdout] 266 | !counter.increment().is_ok(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `counter.increment().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ratelimiter.rs:353:21 [INFO] [stdout] | [INFO] [stdout] 353 | / if let Err(SlidingWindowCounterError::RateLimitExceeded { retry_after }) = [INFO] [stdout] 354 | | response [INFO] [stdout] 355 | | { [INFO] [stdout] 356 | | if retry_after > 0 { [INFO] [stdout] ... | [INFO] [stdout] 360 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 354 ~ response [INFO] [stdout] 355 ~ && retry_after > 0 { [INFO] [stdout] 356 | dbg!(retry_after); [INFO] [stdout] 357 | sleep(Duration::from_secs(retry_after as u64)).await; [INFO] [stdout] 358 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/ratelimiter.rs:358:55 [INFO] [stdout] | [INFO] [stdout] 358 | ... sleep(Duration::from_secs(retry_after as u64)).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `retry_after` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.26s [INFO] running `Command { std: "docker" "inspect" "9a9013f296c049e8e05de48db128714fb3551ff58b34202232f3096cf633413f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a9013f296c049e8e05de48db128714fb3551ff58b34202232f3096cf633413f", kill_on_drop: false }` [INFO] [stdout] 9a9013f296c049e8e05de48db128714fb3551ff58b34202232f3096cf633413f