[INFO] fetching crate game_chess_core 0.0.2... [INFO] linting game_chess_core-0.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate game_chess_core 0.0.2 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate game_chess_core 0.0.2 [INFO] finished tweaking crates.io crate game_chess_core 0.0.2 [INFO] tweaked toml for crates.io crate game_chess_core 0.0.2 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate game_chess_core 0.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded mucow v0.1.0 [INFO] [stderr] Downloaded pleco v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9c945f8edb761d105ac95db636101b86e1ce6a9415d5d31b9c9bd970edd0a15 [INFO] running `Command { std: "docker" "start" "-a" "e9c945f8edb761d105ac95db636101b86e1ce6a9415d5d31b9c9bd970edd0a15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9c945f8edb761d105ac95db636101b86e1ce6a9415d5d31b9c9bd970edd0a15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9c945f8edb761d105ac95db636101b86e1ce6a9415d5d31b9c9bd970edd0a15", kill_on_drop: false }` [INFO] [stdout] e9c945f8edb761d105ac95db636101b86e1ce6a9415d5d31b9c9bd970edd0a15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 881a1f09a7dd031bf10a42a648cbf8723a4944b77c43c541960a8f9da1da1b6f [INFO] running `Command { std: "docker" "start" "-a" "881a1f09a7dd031bf10a42a648cbf8723a4944b77c43c541960a8f9da1da1b6f", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking mucow v0.1.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking pleco v0.5.0 [INFO] [stderr] Checking game_chess_core v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/lib.rs:66:3 [INFO] [stdout] | [INFO] [stdout] 66 | / pub fn default() -> Self [INFO] [stdout] 67 | | { [INFO] [stdout] 68 | | Self [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:92:46 [INFO] [stdout] | [INFO] [stdout] 92 | let result = pleco_board.apply_uci_move( &uci_move ); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `uci_move` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/lib.rs:233:3 [INFO] [stdout] | [INFO] [stdout] 233 | / pub fn default() -> Self [INFO] [stdout] 234 | | { [INFO] [stdout] 235 | | Self [INFO] [stdout] ... | [INFO] [stdout] 240 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | let success = !new_board.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `new_board.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return GameStatus::Continuing; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return GameStatus::Continuing; [INFO] [stdout] 291 + GameStatus::Continuing [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib.rs:300:5 [INFO] [stdout] | [INFO] [stdout] 300 | / match self.history.last() [INFO] [stdout] 301 | | { [INFO] [stdout] 302 | | Some( h ) => Some( h.uci_move.clone() ), [INFO] [stdout] 303 | | _ => None [INFO] [stdout] 304 | | } [INFO] [stdout] | |_____^ help: try: `self.history.last().map(|h| h.uci_move.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/lib.rs:66:3 [INFO] [stdout] | [INFO] [stdout] 66 | / pub fn default() -> Self [INFO] [stdout] 67 | | { [INFO] [stdout] 68 | | Self [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:92:46 [INFO] [stdout] | [INFO] [stdout] 92 | let result = pleco_board.apply_uci_move( &uci_move ); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `uci_move` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/lib.rs:233:3 [INFO] [stdout] | [INFO] [stdout] 233 | / pub fn default() -> Self [INFO] [stdout] 234 | | { [INFO] [stdout] 235 | | Self [INFO] [stdout] ... | [INFO] [stdout] 240 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | let success = !new_board.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `new_board.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return GameStatus::Continuing; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return GameStatus::Continuing; [INFO] [stdout] 291 + GameStatus::Continuing [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib.rs:300:5 [INFO] [stdout] | [INFO] [stdout] 300 | / match self.history.last() [INFO] [stdout] 301 | | { [INFO] [stdout] 302 | | Some( h ) => Some( h.uci_move.clone() ), [INFO] [stdout] 303 | | _ => None [INFO] [stdout] 304 | | } [INFO] [stdout] | |_____^ help: try: `self.history.last().map(|h| h.uci_move.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.69s [INFO] running `Command { std: "docker" "inspect" "881a1f09a7dd031bf10a42a648cbf8723a4944b77c43c541960a8f9da1da1b6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "881a1f09a7dd031bf10a42a648cbf8723a4944b77c43c541960a8f9da1da1b6f", kill_on_drop: false }` [INFO] [stdout] 881a1f09a7dd031bf10a42a648cbf8723a4944b77c43c541960a8f9da1da1b6f