[INFO] fetching crate fxsm-derive 0.3.0... [INFO] linting fxsm-derive-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate fxsm-derive 0.3.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate fxsm-derive 0.3.0 [INFO] finished tweaking crates.io crate fxsm-derive 0.3.0 [INFO] tweaked toml for crates.io crate fxsm-derive 0.3.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate fxsm-derive 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding quote v0.3.15 (available: v1.0.45) [INFO] [stderr] Adding syn v0.11.11 (available: v2.0.117) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6442621cdbba933582b46de806e0ba00680c953ca0111f87f040a949692ce52 [INFO] running `Command { std: "docker" "start" "-a" "e6442621cdbba933582b46de806e0ba00680c953ca0111f87f040a949692ce52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6442621cdbba933582b46de806e0ba00680c953ca0111f87f040a949692ce52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6442621cdbba933582b46de806e0ba00680c953ca0111f87f040a949692ce52", kill_on_drop: false }` [INFO] [stdout] e6442621cdbba933582b46de806e0ba00680c953ca0111f87f040a949692ce52 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fcca88bafba483027b0972ff0df914358f1536a42585590e98bf7d0abba96a2d [INFO] running `Command { std: "docker" "start" "-a" "fcca88bafba483027b0972ff0df914358f1536a42585590e98bf7d0abba96a2d", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking unicode-xid v0.0.4 [INFO] [stderr] Checking quote v0.3.15 [INFO] [stderr] Checking synom v0.11.3 [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking fxsm-derive v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | const TRANSITIONS_ATTRIBUTE: &'static str = "state_transitions"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | const NEW_STATE_OBJ_NAME: &'static str = "new_state"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `quote_block` [INFO] [stdout] --> src/lib.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | macro_rules! quote_block { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | const TRANSITIONS_ATTRIBUTE: &'static str = "state_transitions"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | const NEW_STATE_OBJ_NAME: &'static str = "new_state"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `quote_block` [INFO] [stdout] --> src/lib.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | macro_rules! quote_block { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | / return quote! { [INFO] [stdout] 91 | | #variant_ident => match #new_state_ident { [INFO] [stdout] 92 | | #( [INFO] [stdout] 93 | | #transitions => true, [INFO] [stdout] ... | [INFO] [stdout] 96 | | }, [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ quote! { [INFO] [stdout] 91 + #variant_ident => match #new_state_ident { [INFO] [stdout] 92 + #( [INFO] [stdout] 93 + #transitions => true, [INFO] [stdout] 94 + )* [INFO] [stdout] 95 + _ => false, [INFO] [stdout] 96 + }, [INFO] [stdout] 97 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | / return quote! { [INFO] [stdout] 100 | | _ => false, [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 ~ quote! { [INFO] [stdout] 100 + _ => false, [INFO] [stdout] 101 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/lib.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | / ... if let syn::MetaItem::Word(ref id) = *mt { [INFO] [stdout] 73 | | ... let data = *var_data_map.get(&id.to_string()) [INFO] [stdout] 74 | | ... .unwrap_or(&EnumFieldData::Unit); [INFO] [stdout] 75 | | ... let match_id = ident_with_data(ident, [INFO] [stdout] ... | [INFO] [stdout] 82 | | ... panic!("The syntax for fsm states attribute must be a list-syntax (the same as for #[derive(...)]"); [INFO] [stdout] 83 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/lib.rs:71:62 [INFO] [stdout] | [INFO] [stdout] 71 | if let syn::NestedMetaItem::MetaItem(ref mt) = *n { [INFO] [stdout] | ^^^^^^ -- use: `*n.copied()` [INFO] [stdout] | | [INFO] [stdout] | replace this binding [INFO] [stdout] 72 | if let syn::MetaItem::Word(ref id) = *mt { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:161:27 [INFO] [stdout] | [INFO] [stdout] 161 | .filter(|variant| !variant.attrs.iter() [INFO] [stdout] | ___________________________^ [INFO] [stdout] 162 | | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()) [INFO] [stdout] | |______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 161 ~ .filter(|variant| variant.attrs.iter() [INFO] [stdout] 162 ~ .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_none()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | return gen_for_clonable(&ast.ident, &variants, &ast.generics); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 239 - return gen_for_clonable(&ast.ident, &variants, &ast.generics); [INFO] [stdout] 239 + gen_for_clonable(&ast.ident, &variants, &ast.generics) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:239:45 [INFO] [stdout] | [INFO] [stdout] 239 | return gen_for_clonable(&ast.ident, &variants, &ast.generics); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `variants` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | / return quote! { [INFO] [stdout] 91 | | #variant_ident => match #new_state_ident { [INFO] [stdout] 92 | | #( [INFO] [stdout] 93 | | #transitions => true, [INFO] [stdout] ... | [INFO] [stdout] 96 | | }, [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ quote! { [INFO] [stdout] 91 + #variant_ident => match #new_state_ident { [INFO] [stdout] 92 + #( [INFO] [stdout] 93 + #transitions => true, [INFO] [stdout] 94 + )* [INFO] [stdout] 95 + _ => false, [INFO] [stdout] 96 + }, [INFO] [stdout] 97 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | / return quote! { [INFO] [stdout] 100 | | _ => false, [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 ~ quote! { [INFO] [stdout] 100 + _ => false, [INFO] [stdout] 101 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/lib.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | / ... if let syn::MetaItem::Word(ref id) = *mt { [INFO] [stdout] 73 | | ... let data = *var_data_map.get(&id.to_string()) [INFO] [stdout] 74 | | ... .unwrap_or(&EnumFieldData::Unit); [INFO] [stdout] 75 | | ... let match_id = ident_with_data(ident, [INFO] [stdout] ... | [INFO] [stdout] 82 | | ... panic!("The syntax for fsm states attribute must be a list-syntax (the same as for #[derive(...)]"); [INFO] [stdout] 83 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/lib.rs:71:62 [INFO] [stdout] | [INFO] [stdout] 71 | if let syn::NestedMetaItem::MetaItem(ref mt) = *n { [INFO] [stdout] | ^^^^^^ -- use: `*n.copied()` [INFO] [stdout] | | [INFO] [stdout] | replace this binding [INFO] [stdout] 72 | if let syn::MetaItem::Word(ref id) = *mt { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:161:27 [INFO] [stdout] | [INFO] [stdout] 161 | .filter(|variant| !variant.attrs.iter() [INFO] [stdout] | ___________________________^ [INFO] [stdout] 162 | | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()) [INFO] [stdout] | |______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 161 ~ .filter(|variant| variant.attrs.iter() [INFO] [stdout] 162 ~ .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_none()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | return gen_for_clonable(&ast.ident, &variants, &ast.generics); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 239 - return gen_for_clonable(&ast.ident, &variants, &ast.generics); [INFO] [stdout] 239 + gen_for_clonable(&ast.ident, &variants, &ast.generics) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:239:45 [INFO] [stdout] | [INFO] [stdout] 239 | return gen_for_clonable(&ast.ident, &variants, &ast.generics); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `variants` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `Command { std: "docker" "inspect" "fcca88bafba483027b0972ff0df914358f1536a42585590e98bf7d0abba96a2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcca88bafba483027b0972ff0df914358f1536a42585590e98bf7d0abba96a2d", kill_on_drop: false }` [INFO] [stdout] fcca88bafba483027b0972ff0df914358f1536a42585590e98bf7d0abba96a2d