[INFO] fetching crate framework 0.2.4... [INFO] linting framework-0.2.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate framework 0.2.4 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate framework 0.2.4 [INFO] finished tweaking crates.io crate framework 0.2.4 [INFO] tweaked toml for crates.io crate framework 0.2.4 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate framework 0.2.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding erased-serde v0.3.31 (available: v0.4.10) [INFO] [stderr] Adding maplit v0.1.6 (available: v1.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded maplit v0.1.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e2a3c23f113e8c8f2252f328ba6fe2479eee0c0825f00b734f42b3deb1b5c36 [INFO] running `Command { std: "docker" "start" "-a" "1e2a3c23f113e8c8f2252f328ba6fe2479eee0c0825f00b734f42b3deb1b5c36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e2a3c23f113e8c8f2252f328ba6fe2479eee0c0825f00b734f42b3deb1b5c36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e2a3c23f113e8c8f2252f328ba6fe2479eee0c0825f00b734f42b3deb1b5c36", kill_on_drop: false }` [INFO] [stdout] 1e2a3c23f113e8c8f2252f328ba6fe2479eee0c0825f00b734f42b3deb1b5c36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a95dd72130e97cd4d1eb6ea013e14773f3e6bd17adfcf72fbbabefe9c6f91ed [INFO] running `Command { std: "docker" "start" "-a" "8a95dd72130e97cd4d1eb6ea013e14773f3e6bd17adfcf72fbbabefe9c6f91ed", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking maplit v0.1.6 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking framework v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:6:40 [INFO] [stdout] | [INFO] [stdout] 6 | pub const WORKSPACE_FRAMEWORK_GRADLE: &'static str = "workspace.framework.gradle"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:7:50 [INFO] [stdout] | [INFO] [stdout] 7 | pub const WORKSPACE_FRAMEWORK_GRADLE_COMPOSITE: &'static str = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:9:37 [INFO] [stdout] | [INFO] [stdout] 9 | pub const WORKSPACE_FRAMEWORK_POM: &'static str = "workspace.framework.pom"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:11:32 [INFO] [stdout] | [INFO] [stdout] 11 | pub const WORKSPACE_HAS_TEST: &'static str = "workspace.source.test"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | pub const WORKSPACE_SOURCE_JAVA: &'static str = "workspace.source.java"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:13:37 [INFO] [stdout] | [INFO] [stdout] 13 | pub const WORKSPACE_SOURCE_GROOVY: &'static str = "workspace.source.groovy"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | pub const WORKSPACE_SOURCE_KOTLIN: &'static str = "workspace.source.kotlin"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:15:36 [INFO] [stdout] | [INFO] [stdout] 15 | pub const WORKSPACE_SOURCE_SCALA: &'static str = "workspace.source.scala"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:6:40 [INFO] [stdout] | [INFO] [stdout] 6 | pub const WORKSPACE_FRAMEWORK_GRADLE: &'static str = "workspace.framework.gradle"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:7:50 [INFO] [stdout] | [INFO] [stdout] 7 | pub const WORKSPACE_FRAMEWORK_GRADLE_COMPOSITE: &'static str = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:9:37 [INFO] [stdout] | [INFO] [stdout] 9 | pub const WORKSPACE_FRAMEWORK_POM: &'static str = "workspace.framework.pom"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:11:32 [INFO] [stdout] | [INFO] [stdout] 11 | pub const WORKSPACE_HAS_TEST: &'static str = "workspace.source.test"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | pub const WORKSPACE_SOURCE_JAVA: &'static str = "workspace.source.java"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:13:37 [INFO] [stdout] | [INFO] [stdout] 13 | pub const WORKSPACE_SOURCE_GROOVY: &'static str = "workspace.source.groovy"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | pub const WORKSPACE_SOURCE_KOTLIN: &'static str = "workspace.source.kotlin"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lang/jvm.rs:15:36 [INFO] [stdout] | [INFO] [stdout] 15 | pub const WORKSPACE_SOURCE_SCALA: &'static str = "workspace.source.scala"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dependency/base_library.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return self.scope == "Test"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return self.scope == "Test"; [INFO] [stdout] 17 + self.scope == "Test" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/facet/java/content_root.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for ContentRoot { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | ContentRoot { [INFO] [stdout] 16 | | root_dirs: vec![], [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 2 + #[derive(Default)] [INFO] [stdout] 3 | pub struct ContentRoot { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JavaFacet` [INFO] [stdout] --> src/facet/java/java_facet.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> JavaFacet { [INFO] [stdout] 15 | | JavaFacet { [INFO] [stdout] 16 | | jvm: Default::default(), [INFO] [stdout] 17 | | include_test: false, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for JavaFacet { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/facet/java/jvm_facet.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / impl Default for JvmFacet { [INFO] [stdout] 13 | | fn default() -> Self { [INFO] [stdout] 14 | | JvmFacet { [INFO] [stdout] 15 | | is_gradle: false, [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 2 + #[derive(Default)] [INFO] [stdout] 3 | pub struct JvmFacet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/facet/javascript/javascript_facet.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / impl Default for JavaScriptFacet { [INFO] [stdout] 23 | | fn default() -> Self { [INFO] [stdout] 24 | | JavaScriptFacet { [INFO] [stdout] 25 | | is_frontend: false, [INFO] [stdout] ... | [INFO] [stdout] 41 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 2 + #[derive(Default)] [INFO] [stdout] 3 | pub struct JavaScriptFacet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/framework_detector.rs:54:52 [INFO] [stdout] | [INFO] [stdout] 54 | self.add_language_to_frameworks(file_path, &language); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `language` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/framework_detector.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | / match frameworks.get(index) { [INFO] [stdout] 94 | | Some(framework) => Some(framework.clone()), [INFO] [stdout] 95 | | _ => None, [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________^ help: try: `frameworks.get(index).map(|framework| framework.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/framework_detector.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | / impl<'a> Default for FrameworkDetector<'a> { [INFO] [stdout] 119 | | fn default() -> Self { [INFO] [stdout] 120 | | FrameworkDetector { [INFO] [stdout] 121 | | tags: BTreeMap::default(), [INFO] [stdout] ... | [INFO] [stdout] 126 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 111 + #[derive(Default)] [INFO] [stdout] 112 | pub struct FrameworkDetector<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/framework_detector.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|fw| Framework::from(fw)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Framework::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dependency/base_library.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return self.scope == "Test"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return self.scope == "Test"; [INFO] [stdout] 17 + self.scope == "Test" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lang/jvm.rs:23:36 [INFO] [stdout] | [INFO] [stdout] 23 | static ref SOURCE_DETECT_LIST: Vec<(&'static str, fn(&str) -> bool)> = vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return JAVA_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return JAVA_TEST.is_match(path); [INFO] [stdout] 33 + JAVA_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return JAVA_SOURCE_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return JAVA_SOURCE_TEST.is_match(path); [INFO] [stdout] 37 + JAVA_SOURCE_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return GROOVY_SOURCE_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return GROOVY_SOURCE_TEST.is_match(path); [INFO] [stdout] 41 + GROOVY_SOURCE_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return KOTLIN_SOURCE_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return KOTLIN_SOURCE_TEST.is_match(path); [INFO] [stdout] 45 + KOTLIN_SOURCE_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return SCALA_SOURCE_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return SCALA_SOURCE_TEST.is_match(path); [INFO] [stdout] 49 + SCALA_SOURCE_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lang/jvm.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | if !build_tool_tag.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `build_tool_tag.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lang/jvm.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / match language { [INFO] [stdout] 85 | | Some(lang) => frameworks.add_language(parent_path, lang), [INFO] [stdout] 86 | | _ => {} [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(lang) = language { frameworks.add_language(parent_path, lang) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lang/jvm.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | / match file_name { [INFO] [stdout] 100 | | "settings.gradle" => true, [INFO] [stdout] 101 | | _ => false, [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 99 - match file_name { [INFO] [stdout] 100 - "settings.gradle" => true, [INFO] [stdout] 101 - _ => false, [INFO] [stdout] 102 - } [INFO] [stdout] 99 + matches!(file_name, "settings.gradle") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lang/jvm.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / match file_name { [INFO] [stdout] 144 | | "build.gradle" => true, [INFO] [stdout] 145 | | "pom.xml" => true, [INFO] [stdout] 146 | | _ => false, [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 143 - match file_name { [INFO] [stdout] 144 - "build.gradle" => true, [INFO] [stdout] 145 - "pom.xml" => true, [INFO] [stdout] 146 - _ => false, [INFO] [stdout] 147 - } [INFO] [stdout] 143 + matches!(file_name, "build.gradle" | "pom.xml") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lang/mod.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | fn traverse_project_directory<'a, P: AsRef, F>(path: P, mut each_entry_callback: F) [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/facet/java/content_root.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for ContentRoot { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | ContentRoot { [INFO] [stdout] 16 | | root_dirs: vec![], [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 2 + #[derive(Default)] [INFO] [stdout] 3 | pub struct ContentRoot { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JavaFacet` [INFO] [stdout] --> src/facet/java/java_facet.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> JavaFacet { [INFO] [stdout] 15 | | JavaFacet { [INFO] [stdout] 16 | | jvm: Default::default(), [INFO] [stdout] 17 | | include_test: false, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for JavaFacet { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/facet/java/jvm_facet.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / impl Default for JvmFacet { [INFO] [stdout] 13 | | fn default() -> Self { [INFO] [stdout] 14 | | JvmFacet { [INFO] [stdout] 15 | | is_gradle: false, [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 2 + #[derive(Default)] [INFO] [stdout] 3 | pub struct JvmFacet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/facet/javascript/javascript_facet.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / impl Default for JavaScriptFacet { [INFO] [stdout] 23 | | fn default() -> Self { [INFO] [stdout] 24 | | JavaScriptFacet { [INFO] [stdout] 25 | | is_frontend: false, [INFO] [stdout] ... | [INFO] [stdout] 41 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 2 + #[derive(Default)] [INFO] [stdout] 3 | pub struct JavaScriptFacet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/facet/python/python_facet.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | assert_eq!(true, PythonFacet::is_test("test_hello.py")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 25 - assert_eq!(true, PythonFacet::is_test("test_hello.py")); [INFO] [stdout] 25 + assert!(PythonFacet::is_test("test_hello.py")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/facet/python/python_facet.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | assert_eq!(false, PythonFacet::is_test("hello.py")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 26 - assert_eq!(false, PythonFacet::is_test("hello.py")); [INFO] [stdout] 26 + assert!(!PythonFacet::is_test("hello.py")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/facet/python/python_facet.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | assert_eq!(false, PythonFacet::is_test("testhellopy")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 27 - assert_eq!(false, PythonFacet::is_test("testhellopy")); [INFO] [stdout] 27 + assert!(!PythonFacet::is_test("testhellopy")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/facet/python/python_facet.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_eq!(false, PythonFacet::is_test("fatest.py")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_eq!(false, PythonFacet::is_test("fatest.py")); [INFO] [stdout] 28 + assert!(!PythonFacet::is_test("fatest.py")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/framework_detector.rs:54:52 [INFO] [stdout] | [INFO] [stdout] 54 | self.add_language_to_frameworks(file_path, &language); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `language` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/framework_detector.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | / match frameworks.get(index) { [INFO] [stdout] 94 | | Some(framework) => Some(framework.clone()), [INFO] [stdout] 95 | | _ => None, [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________^ help: try: `frameworks.get(index).map(|framework| framework.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/framework_detector.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | / impl<'a> Default for FrameworkDetector<'a> { [INFO] [stdout] 119 | | fn default() -> Self { [INFO] [stdout] 120 | | FrameworkDetector { [INFO] [stdout] 121 | | tags: BTreeMap::default(), [INFO] [stdout] ... | [INFO] [stdout] 126 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 111 + #[derive(Default)] [INFO] [stdout] 112 | pub struct FrameworkDetector<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/framework_detector.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|fw| Framework::from(fw)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Framework::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | assert_eq!(files.contains("build.gradle"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 287 - assert_eq!(files.contains("build.gradle"), true); [INFO] [stdout] 287 + assert!(files.contains("build.gradle")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | assert_eq!(files.contains("settings.gradle"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 288 - assert_eq!(files.contains("settings.gradle"), true); [INFO] [stdout] 288 + assert!(files.contains("settings.gradle")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | assert_eq!(languages.contains("Groovy"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 289 - assert_eq!(languages.contains("Groovy"), true); [INFO] [stdout] 289 + assert!(languages.contains("Groovy")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 290 | assert_eq!(languages.contains("Java"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 290 - assert_eq!(languages.contains("Java"), true); [INFO] [stdout] 290 + assert!(languages.contains("Java")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | assert_eq!(languages.contains("Kotlin"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 291 - assert_eq!(languages.contains("Kotlin"), true); [INFO] [stdout] 291 + assert!(languages.contains("Kotlin")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | assert_eq!(languages.contains("Scala"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 292 - assert_eq!(languages.contains("Scala"), true); [INFO] [stdout] 292 + assert!(languages.contains("Scala")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 | assert_eq!(files.contains("pom.xml"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 299 - assert_eq!(files.contains("pom.xml"), true); [INFO] [stdout] 299 + assert!(files.contains("pom.xml")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | assert_eq!(languages.contains("Java"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 300 - assert_eq!(languages.contains("Java"), true); [INFO] [stdout] 300 + assert!(languages.contains("Java")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/framework_detector.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | assert_eq!(languages.contains("Kotlin"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 301 - assert_eq!(languages.contains("Kotlin"), true); [INFO] [stdout] 301 + assert!(languages.contains("Kotlin")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lang/jvm.rs:23:36 [INFO] [stdout] | [INFO] [stdout] 23 | static ref SOURCE_DETECT_LIST: Vec<(&'static str, fn(&str) -> bool)> = vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return JAVA_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return JAVA_TEST.is_match(path); [INFO] [stdout] 33 + JAVA_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return JAVA_SOURCE_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return JAVA_SOURCE_TEST.is_match(path); [INFO] [stdout] 37 + JAVA_SOURCE_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return GROOVY_SOURCE_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return GROOVY_SOURCE_TEST.is_match(path); [INFO] [stdout] 41 + GROOVY_SOURCE_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return KOTLIN_SOURCE_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return KOTLIN_SOURCE_TEST.is_match(path); [INFO] [stdout] 45 + KOTLIN_SOURCE_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lang/jvm.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return SCALA_SOURCE_TEST.is_match(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return SCALA_SOURCE_TEST.is_match(path); [INFO] [stdout] 49 + SCALA_SOURCE_TEST.is_match(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lang/jvm.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | if !build_tool_tag.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `build_tool_tag.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lang/jvm.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / match language { [INFO] [stdout] 85 | | Some(lang) => frameworks.add_language(parent_path, lang), [INFO] [stdout] 86 | | _ => {} [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(lang) = language { frameworks.add_language(parent_path, lang) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lang/jvm.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | / match file_name { [INFO] [stdout] 100 | | "settings.gradle" => true, [INFO] [stdout] 101 | | _ => false, [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 99 - match file_name { [INFO] [stdout] 100 - "settings.gradle" => true, [INFO] [stdout] 101 - _ => false, [INFO] [stdout] 102 - } [INFO] [stdout] 99 + matches!(file_name, "settings.gradle") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lang/jvm.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / match file_name { [INFO] [stdout] 144 | | "build.gradle" => true, [INFO] [stdout] 145 | | "pom.xml" => true, [INFO] [stdout] 146 | | _ => false, [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 143 - match file_name { [INFO] [stdout] 144 - "build.gradle" => true, [INFO] [stdout] 145 - "pom.xml" => true, [INFO] [stdout] 146 - _ => false, [INFO] [stdout] 147 - } [INFO] [stdout] 143 + matches!(file_name, "build.gradle" | "pom.xml") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | assert_eq!(false, is_test("Hello.java")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 177 - assert_eq!(false, is_test("Hello.java")); [INFO] [stdout] 177 + assert!(!is_test("Hello.java")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | assert_eq!(true, is_test("HelloWorldTest.java")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 178 - assert_eq!(true, is_test("HelloWorldTest.java")); [INFO] [stdout] 178 + assert!(is_test("HelloWorldTest.java")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | assert_eq!(true, is_test("HelloTests.java")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 179 - assert_eq!(true, is_test("HelloTests.java")); [INFO] [stdout] 179 + assert!(is_test("HelloTests.java")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | assert_eq!(true, is_java_source_file("Hello.java")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 184 - assert_eq!(true, is_java_source_file("Hello.java")); [INFO] [stdout] 184 + assert!(is_java_source_file("Hello.java")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | assert_eq!(true, is_java_source_file("HelloWorldTest.java")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 185 - assert_eq!(true, is_java_source_file("HelloWorldTest.java")); [INFO] [stdout] 185 + assert!(is_java_source_file("HelloWorldTest.java")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | assert_eq!(true, is_groovy_source_file("Hello.groovy")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 190 - assert_eq!(true, is_groovy_source_file("Hello.groovy")); [INFO] [stdout] 190 + assert!(is_groovy_source_file("Hello.groovy")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | assert_eq!(true, is_groovy_source_file("HelloTest.groovy")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 191 - assert_eq!(true, is_groovy_source_file("HelloTest.groovy")); [INFO] [stdout] 191 + assert!(is_groovy_source_file("HelloTest.groovy")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | assert_eq!(true, is_kotlin_source_file("Hello.kt")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 196 - assert_eq!(true, is_kotlin_source_file("Hello.kt")); [INFO] [stdout] 196 + assert!(is_kotlin_source_file("Hello.kt")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | assert_eq!(true, is_kotlin_source_file("HelloTest.kt")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 197 - assert_eq!(true, is_kotlin_source_file("HelloTest.kt")); [INFO] [stdout] 197 + assert!(is_kotlin_source_file("HelloTest.kt")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | assert_eq!(true, is_scala_source_file("Hello.scala")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 202 - assert_eq!(true, is_scala_source_file("Hello.scala")); [INFO] [stdout] 202 + assert!(is_scala_source_file("Hello.scala")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lang/jvm.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | assert_eq!(true, is_scala_source_file("HelloTest.scala")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 203 - assert_eq!(true, is_scala_source_file("HelloTest.scala")); [INFO] [stdout] 203 + assert!(is_scala_source_file("HelloTest.scala")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lang/mod.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | fn traverse_project_directory<'a, P: AsRef, F>(path: P, mut each_entry_callback: F) [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.37s [INFO] running `Command { std: "docker" "inspect" "8a95dd72130e97cd4d1eb6ea013e14773f3e6bd17adfcf72fbbabefe9c6f91ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a95dd72130e97cd4d1eb6ea013e14773f3e6bd17adfcf72fbbabefe9c6f91ed", kill_on_drop: false }` [INFO] [stdout] 8a95dd72130e97cd4d1eb6ea013e14773f3e6bd17adfcf72fbbabefe9c6f91ed