[INFO] fetching crate fproxy_derive 0.0.5... [INFO] linting fproxy_derive-0.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate fproxy_derive 0.0.5 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate fproxy_derive 0.0.5 [INFO] finished tweaking crates.io crate fproxy_derive 0.0.5 [INFO] tweaked toml for crates.io crate fproxy_derive 0.0.5 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate fproxy_derive 0.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate fproxy_derive 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 298bd54db5c859f5c17bf201038da1d112f2bc4db3a0c1347d725e7246d19bfc [INFO] running `Command { std: "docker" "start" "-a" "298bd54db5c859f5c17bf201038da1d112f2bc4db3a0c1347d725e7246d19bfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "298bd54db5c859f5c17bf201038da1d112f2bc4db3a0c1347d725e7246d19bfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "298bd54db5c859f5c17bf201038da1d112f2bc4db3a0c1347d725e7246d19bfc", kill_on_drop: false }` [INFO] [stdout] 298bd54db5c859f5c17bf201038da1d112f2bc4db3a0c1347d725e7246d19bfc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b9a3bb3fd2af31e0d54b5b587c27c751eafc45189b7dc6170023c5b1f79576b5 [INFO] running `Command { std: "docker" "start" "-a" "b9a3bb3fd2af31e0d54b5b587c27c751eafc45189b7dc6170023c5b1f79576b5", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.20 [INFO] [stderr] Checking proc-macro2 v1.0.103 [INFO] [stderr] Checking quote v1.0.41 [INFO] [stderr] Checking syn v2.0.108 [INFO] [stderr] Checking fproxy_derive v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/proxy.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | input.is_trait = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `proxy::Input { is_trait: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/proxy.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | let mut input = Input::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/proxy.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 35 | lib: vec.contains(&format!("lib")), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"lib".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/proxy.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | / impl Default for Input { [INFO] [stdout] 41 | | fn default() -> Self { [INFO] [stdout] 42 | | Input { [INFO] [stdout] 43 | | lib: false, [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | struct Input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proxy.rs:110:26 [INFO] [stdout] | [INFO] [stdout] 110 | let tfident = tfident (&ident); [INFO] [stdout] | ^^^^^^ help: change this to: `ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/proxy.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | input.is_trait = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `proxy::Input { is_trait: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/proxy.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | let mut input = Input::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/proxy.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 35 | lib: vec.contains(&format!("lib")), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"lib".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/proxy.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | / impl Default for Input { [INFO] [stdout] 41 | | fn default() -> Self { [INFO] [stdout] 42 | | Input { [INFO] [stdout] 43 | | lib: false, [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | struct Input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proxy.rs:110:26 [INFO] [stdout] | [INFO] [stdout] 110 | let tfident = tfident (&ident); [INFO] [stdout] | ^^^^^^ help: change this to: `ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/imp.rs:28:26 [INFO] [stdout] | [INFO] [stdout] 28 | tag: vec.contains(&format!("tag")), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"tag".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/imp.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / impl Default for Args { [INFO] [stdout] 33 | | fn default() -> Self { [INFO] [stdout] 34 | | Args { tag: false } [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 12 + #[derive(Default)] [INFO] [stdout] 13 | struct Args { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/imp.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | let tag = attrs [INFO] [stdout] | _______________^ [INFO] [stdout] 98 | | .iter() [INFO] [stdout] 99 | | .filter(|atr| atr.to_token_stream().to_string().contains("fproxy")) [INFO] [stdout] 100 | | .next() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 ~ let tag = attrs [INFO] [stdout] 98 + .iter().find(|atr| atr.to_token_stream().to_string().contains("fproxy")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/imp.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | / if let ReturnType::Type(_, typ) = fun.sig.output.clone() { [INFO] [stdout] 121 | | if let Type::ImplTrait(TypeImplTrait { impl_token: _, bounds }) = *typ { [INFO] [stdout] 122 | | fun.returns_impl = Some(bounds); [INFO] [stdout] 123 | | } [INFO] [stdout] 124 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ if let ReturnType::Type(_, typ) = fun.sig.output.clone() [INFO] [stdout] 121 ~ && let Type::ImplTrait(TypeImplTrait { impl_token: _, bounds }) = *typ { [INFO] [stdout] 122 | fun.returns_impl = Some(bounds); [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/imp.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return quote!(#typ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return quote!(#typ); [INFO] [stdout] 157 + quote!(#typ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/imp.rs:146:31 [INFO] [stdout] | [INFO] [stdout] 146 | Type::Path(path) if path.path.segments.first().unwrap().ident.to_string() == "Self" => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.path.segments.first().unwrap().ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/imp.rs:163:6 [INFO] [stdout] | [INFO] [stdout] 163 | (!self.slf.is_some() && !self.new) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `self.slf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/imp.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | / if item.is_trait { [INFO] [stdout] 170 | | if let Some(slf) = &self.slf { [INFO] [stdout] 171 | | let refr = slf.reference.clone().map(|(and, _)| and); [INFO] [stdout] 172 | | let mutb = &slf.mutability; [INFO] [stdout] ... | [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 169 ~ if item.is_trait [INFO] [stdout] 170 ~ && let Some(slf) = &self.slf { [INFO] [stdout] 171 | let refr = slf.reference.clone().map(|(and, _)| and); [INFO] [stdout] 172 | let mutb = &slf.mutability; [INFO] [stdout] 173 | return Some(quote! {#refr #mutb dyn #item}); [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/imp.rs:28:26 [INFO] [stdout] | [INFO] [stdout] 28 | tag: vec.contains(&format!("tag")), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"tag".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/imp.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / impl Default for Args { [INFO] [stdout] 33 | | fn default() -> Self { [INFO] [stdout] 34 | | Args { tag: false } [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 12 + #[derive(Default)] [INFO] [stdout] 13 | struct Args { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/imp.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | let tag = attrs [INFO] [stdout] | _______________^ [INFO] [stdout] 98 | | .iter() [INFO] [stdout] 99 | | .filter(|atr| atr.to_token_stream().to_string().contains("fproxy")) [INFO] [stdout] 100 | | .next() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 ~ let tag = attrs [INFO] [stdout] 98 + .iter().find(|atr| atr.to_token_stream().to_string().contains("fproxy")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/imp.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | / if let ReturnType::Type(_, typ) = fun.sig.output.clone() { [INFO] [stdout] 121 | | if let Type::ImplTrait(TypeImplTrait { impl_token: _, bounds }) = *typ { [INFO] [stdout] 122 | | fun.returns_impl = Some(bounds); [INFO] [stdout] 123 | | } [INFO] [stdout] 124 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ if let ReturnType::Type(_, typ) = fun.sig.output.clone() [INFO] [stdout] 121 ~ && let Type::ImplTrait(TypeImplTrait { impl_token: _, bounds }) = *typ { [INFO] [stdout] 122 | fun.returns_impl = Some(bounds); [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/imp.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return quote!(#typ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return quote!(#typ); [INFO] [stdout] 157 + quote!(#typ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/imp.rs:146:31 [INFO] [stdout] | [INFO] [stdout] 146 | Type::Path(path) if path.path.segments.first().unwrap().ident.to_string() == "Self" => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.path.segments.first().unwrap().ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/imp.rs:163:6 [INFO] [stdout] | [INFO] [stdout] 163 | (!self.slf.is_some() && !self.new) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `self.slf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/imp.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | / if item.is_trait { [INFO] [stdout] 170 | | if let Some(slf) = &self.slf { [INFO] [stdout] 171 | | let refr = slf.reference.clone().map(|(and, _)| and); [INFO] [stdout] 172 | | let mutb = &slf.mutability; [INFO] [stdout] ... | [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 169 ~ if item.is_trait [INFO] [stdout] 170 ~ && let Some(slf) = &self.slf { [INFO] [stdout] 171 | let refr = slf.reference.clone().map(|(and, _)| and); [INFO] [stdout] 172 | let mutb = &slf.mutability; [INFO] [stdout] 173 | return Some(quote! {#refr #mutb dyn #item}); [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.52s [INFO] running `Command { std: "docker" "inspect" "b9a3bb3fd2af31e0d54b5b587c27c751eafc45189b7dc6170023c5b1f79576b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9a3bb3fd2af31e0d54b5b587c27c751eafc45189b7dc6170023c5b1f79576b5", kill_on_drop: false }` [INFO] [stdout] b9a3bb3fd2af31e0d54b5b587c27c751eafc45189b7dc6170023c5b1f79576b5