[INFO] fetching crate forecast-get 0.1.1... [INFO] linting forecast-get-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate forecast-get 0.1.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate forecast-get 0.1.1 [INFO] finished tweaking crates.io crate forecast-get 0.1.1 [INFO] tweaked toml for crates.io crate forecast-get 0.1.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate forecast-get 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate forecast-get 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded which v3.1.1 [INFO] [stderr] Downloaded clang-sys v1.3.1 [INFO] [stderr] Downloaded paste v1.0.7 [INFO] [stderr] Downloaded cexpr v0.4.0 [INFO] [stderr] Downloaded duration-string v0.0.6 [INFO] [stderr] Downloaded redox_users v0.4.2 [INFO] [stderr] Downloaded quote v1.0.16 [INFO] [stderr] Downloaded clap_derive v3.1.4 [INFO] [stderr] Downloaded redox_syscall v0.2.11 [INFO] [stderr] Downloaded serde_qs v0.9.1 [INFO] [stderr] Downloaded httparse v1.6.0 [INFO] [stderr] Downloaded tracing v0.1.32 [INFO] [stderr] Downloaded handlebars v4.2.2 [INFO] [stderr] Downloaded bindgen v0.55.1 [INFO] [stderr] Downloaded ntapi v0.3.7 [INFO] [stderr] Downloaded serde_json v1.0.79 [INFO] [stderr] Downloaded nom v5.1.2 [INFO] [stderr] Downloaded clap v3.1.6 [INFO] [stderr] Downloaded mio v0.8.2 [INFO] [stderr] Downloaded tracing-core v0.1.23 [INFO] [stderr] Downloaded getrandom v0.2.5 [INFO] [stderr] Downloaded syn v1.0.89 [INFO] [stderr] Downloaded ipnet v2.4.0 [INFO] [stderr] Downloaded tokio v1.17.0 [INFO] [stderr] Downloaded libc v0.2.121 [INFO] [stderr] Downloaded unqlite v1.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00b74adee1e1bebef48184fd816ca5009d5635ab13eecce27378a7e9268ee0fd [INFO] running `Command { std: "docker" "start" "-a" "00b74adee1e1bebef48184fd816ca5009d5635ab13eecce27378a7e9268ee0fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00b74adee1e1bebef48184fd816ca5009d5635ab13eecce27378a7e9268ee0fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00b74adee1e1bebef48184fd816ca5009d5635ab13eecce27378a7e9268ee0fd", kill_on_drop: false }` [INFO] [stdout] 00b74adee1e1bebef48184fd816ca5009d5635ab13eecce27378a7e9268ee0fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9774342f714939c93b9a308757b90751d80deaa04dc8dc546a93d639bd977278 [INFO] running `Command { std: "docker" "start" "-a" "9774342f714939c93b9a308757b90751d80deaa04dc8dc546a93d639bd977278", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Checking tracing-core v0.1.23 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling unicode-width v0.1.9 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Compiling libloading v0.7.3 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling bindgen v0.55.1 [INFO] [stderr] Compiling httparse v1.6.0 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Compiling termcolor v1.1.3 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling clang-sys v1.3.1 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Compiling regex v1.5.5 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking ipnet v2.4.0 [INFO] [stderr] Compiling paste v1.0.7 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling env_logger v0.7.1 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking tracing v0.1.32 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Compiling unqlite v1.5.0 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_qs v0.9.1 [INFO] [stderr] Checking duration-string v0.0.6 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking reqwest v0.11.10 [INFO] [stderr] Checking handlebars v4.2.2 [INFO] [stderr] Checking forecast-get v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `provider` is never read [INFO] [stdout] --> src/config/config.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Config { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 24 | pub provider: Provider, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Config` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Period` is never used [INFO] [stdout] --> src/config/config.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | pub enum Period { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/config/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod config; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `provider` is never read [INFO] [stdout] --> src/config/config.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Config { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 24 | pub provider: Provider, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Config` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Period` is never used [INFO] [stdout] --> src/config/config.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | pub enum Period { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/config/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod config; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config/config.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | / if cache.enabled { [INFO] [stdout] 93 | | if cache.expiration.is_none() { [INFO] [stdout] 94 | | return Err(Error::InvalidConfigCheck("expected cache.expiration".to_string())); [INFO] [stdout] 95 | | } [INFO] [stdout] 96 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 92 ~ if cache.enabled [INFO] [stdout] 93 ~ && cache.expiration.is_none() { [INFO] [stdout] 94 | return Err(Error::InvalidConfigCheck("expected cache.expiration".to_string())); [INFO] [stdout] 95 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config/config.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | / if cache.enabled { [INFO] [stdout] 93 | | if cache.expiration.is_none() { [INFO] [stdout] 94 | | return Err(Error::InvalidConfigCheck("expected cache.expiration".to_string())); [INFO] [stdout] 95 | | } [INFO] [stdout] 96 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 92 ~ if cache.enabled [INFO] [stdout] 93 ~ && cache.expiration.is_none() { [INFO] [stdout] 94 | return Err(Error::InvalidConfigCheck("expected cache.expiration".to_string())); [INFO] [stdout] 95 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/error/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod error; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error/error.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | HttpError(#[from] reqwest::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/error/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod error; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error/error.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | HttpError(#[from] reqwest::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i16` is unnecessary [INFO] [stdout] --> src/temperature.rs:47:74 [INFO] [stdout] | [INFO] [stdout] 47 | (val, Celsius, Fahrenheit) => Temperature::new(val * 9 / 5 + 32 as i16, Fahrenheit), [INFO] [stdout] | ^^^^^^^^^ help: try: `32_i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i16` is unnecessary [INFO] [stdout] --> src/temperature.rs:49:87 [INFO] [stdout] | [INFO] [stdout] 49 | (val, Fahrenheit, Kelvin) => Temperature::new((val + 459.67 as i16) * 5 / 9 as i16, Kelvin), [INFO] [stdout] | ^^^^^^^^ help: try: `9_i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i16` is unnecessary [INFO] [stdout] --> src/temperature.rs:51:77 [INFO] [stdout] | [INFO] [stdout] 51 | (val, Fahrenheit, Celsius) => Temperature::new((val - 32) * 5 / 9 as i16, Celsius), [INFO] [stdout] | ^^^^^^^^ help: try: `9_i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i16` is unnecessary [INFO] [stdout] --> src/temperature.rs:47:74 [INFO] [stdout] | [INFO] [stdout] 47 | (val, Celsius, Fahrenheit) => Temperature::new(val * 9 / 5 + 32 as i16, Fahrenheit), [INFO] [stdout] | ^^^^^^^^^ help: try: `32_i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/temperature.rs:66:23 [INFO] [stdout] | [INFO] [stdout] 66 | Some(self.cmp(&other)) [INFO] [stdout] | ^^^^^^ help: change this to: `other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i16` is unnecessary [INFO] [stdout] --> src/temperature.rs:49:87 [INFO] [stdout] | [INFO] [stdout] 49 | (val, Fahrenheit, Kelvin) => Temperature::new((val + 459.67 as i16) * 5 / 9 as i16, Kelvin), [INFO] [stdout] | ^^^^^^^^ help: try: `9_i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i16` is unnecessary [INFO] [stdout] --> src/temperature.rs:51:77 [INFO] [stdout] | [INFO] [stdout] 51 | (val, Fahrenheit, Celsius) => Temperature::new((val - 32) * 5 / 9 as i16, Celsius), [INFO] [stdout] | ^^^^^^^^ help: try: `9_i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/temperature.rs:66:23 [INFO] [stdout] | [INFO] [stdout] 66 | Some(self.cmp(&other)) [INFO] [stdout] | ^^^^^^ help: change this to: `other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/weather/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod weather; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/temperature.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 131 | assert!(!(Temperature(0, Celsius) < Temperature(0, Celsius))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(Temperature(0, Celsius) >= Temperature(0, Celsius))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/weather/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod weather; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/weather/weather.rs:136:67 [INFO] [stdout] | [INFO] [stdout] 136 | Condition::LightRain => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/weather/weather.rs:136:80 [INFO] [stdout] | [INFO] [stdout] 136 | Condition::LightRain => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/weather/weather.rs:137:62 [INFO] [stdout] | [INFO] [stdout] 137 | Condition::Rain => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/weather/weather.rs:137:75 [INFO] [stdout] | [INFO] [stdout] 137 | Condition::Rain => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/weather/weather.rs:141:65 [INFO] [stdout] | [INFO] [stdout] 141 | Condition::Showers => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/weather/weather.rs:141:78 [INFO] [stdout] | [INFO] [stdout] 141 | Condition::Showers => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/yandex/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod yandex; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/weather/weather.rs:136:67 [INFO] [stdout] | [INFO] [stdout] 136 | Condition::LightRain => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/weather/weather.rs:136:80 [INFO] [stdout] | [INFO] [stdout] 136 | Condition::LightRain => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/weather/weather.rs:137:62 [INFO] [stdout] | [INFO] [stdout] 137 | Condition::Rain => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/weather/weather.rs:137:75 [INFO] [stdout] | [INFO] [stdout] 137 | Condition::Rain => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/weather/weather.rs:141:65 [INFO] [stdout] | [INFO] [stdout] 141 | Condition::Showers => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/weather/weather.rs:141:78 [INFO] [stdout] | [INFO] [stdout] 141 | Condition::Showers => if is_night == Daytime::Night { '' } else { '' }, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/yandex/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod yandex; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/template/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod template; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/template/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod template; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/unqlite.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | if !self.is_expired(&KEY) { [INFO] [stdout] | ^^^^ help: change this to: `KEY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/unqlite.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | self.ttl(&KEY, self.ttl)?; [INFO] [stdout] | ^^^^ help: change this to: `KEY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/template/template.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | for unit in vec![Celsius, Kelvin, Fahrenheit] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[Celsius, Kelvin, Fahrenheit]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/template/template.rs:191:29 [INFO] [stdout] | [INFO] [stdout] 191 | for unit in vec![Celsius, Kelvin, Fahrenheit] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[Celsius, Kelvin, Fahrenheit]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/unqlite.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | if !self.is_expired(&KEY) { [INFO] [stdout] | ^^^^ help: change this to: `KEY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/unqlite.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | self.ttl(&KEY, self.ttl)?; [INFO] [stdout] | ^^^^ help: change this to: `KEY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/template/template.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | for unit in vec![Celsius, Kelvin, Fahrenheit] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[Celsius, Kelvin, Fahrenheit]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/template/template.rs:191:29 [INFO] [stdout] | [INFO] [stdout] 191 | for unit in vec![Celsius, Kelvin, Fahrenheit] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[Celsius, Kelvin, Fahrenheit]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.69s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "9774342f714939c93b9a308757b90751d80deaa04dc8dc546a93d639bd977278", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9774342f714939c93b9a308757b90751d80deaa04dc8dc546a93d639bd977278", kill_on_drop: false }` [INFO] [stdout] 9774342f714939c93b9a308757b90751d80deaa04dc8dc546a93d639bd977278