[INFO] fetching crate flyer 2.0.0... [INFO] linting flyer-2.0.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate flyer 2.0.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate flyer 2.0.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate flyer 2.0.0 [INFO] tweaked toml for crates.io crate flyer 2.0.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate flyer 2.0.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate flyer 2.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded globwalk v0.9.1 [INFO] [stderr] Downloaded derive_builder_core v0.9.0 [INFO] [stderr] Downloaded derive-new v0.5.9 [INFO] [stderr] Downloaded const_fn v0.4.12 [INFO] [stderr] Downloaded chrono-tz-build v0.3.0 [INFO] [stderr] Downloaded url-domain-parse v0.1.4 [INFO] [stderr] Downloaded rspec v1.0.0 [INFO] [stderr] Downloaded multer v3.1.0 [INFO] [stderr] Downloaded h3-quinn v0.0.10 [INFO] [stderr] Downloaded fastbloom v0.14.1 [INFO] [stderr] Downloaded humansize v2.1.3 [INFO] [stderr] Downloaded h3 v0.0.8 [INFO] [stderr] Downloaded derive_builder v0.9.0 [INFO] [stderr] Downloaded tera v1.20.1 [INFO] [stderr] Downloaded parse-zoneinfo v0.3.1 [INFO] [stderr] Downloaded chrono-tz v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed8821742e5ed9e55f2b5bdb32117cc516367aa5568f687c18a8e54b74fc873d [INFO] running `Command { std: "docker" "start" "-a" "ed8821742e5ed9e55f2b5bdb32117cc516367aa5568f687c18a8e54b74fc873d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed8821742e5ed9e55f2b5bdb32117cc516367aa5568f687c18a8e54b74fc873d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed8821742e5ed9e55f2b5bdb32117cc516367aa5568f687c18a8e54b74fc873d", kill_on_drop: false }` [INFO] [stdout] ed8821742e5ed9e55f2b5bdb32117cc516367aa5568f687c18a8e54b74fc873d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5862c4814d8bf7ee2919055573fdf355f72d4aa588b67af84c21247b72d0e831 [INFO] running `Command { std: "docker" "start" "-a" "5862c4814d8bf7ee2919055573fdf355f72d4aa588b67af84c21247b72d0e831", kill_on_drop: false }` [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking value-bag v1.12.0 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Compiling portable-atomic v1.13.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking critical-section v1.2.0 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling aws-lc-rs v1.16.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Compiling const_fn v0.4.12 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling pest v2.8.6 [INFO] [stderr] Compiling slog v2.8.2 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Compiling quinn-udp v0.5.14 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling aws-lc-sys v0.38.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Compiling derive_builder v0.9.0 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling pest_meta v2.8.6 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling derive_builder_core v0.9.0 [INFO] [stderr] Checking fastbloom v0.14.1 [INFO] [stderr] Compiling quinn v0.11.9 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking piper v0.2.5 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking lru-slab v0.1.2 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking globset v0.4.18 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking rustc-hash v2.1.1 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking ignore v0.4.25 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling pest_generator v2.8.6 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking deunicode v1.6.2 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling slog-async v2.8.0 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling enum-as-inner v0.6.1 [INFO] [stderr] Compiling pest_derive v2.8.6 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking tungstenite v0.28.0 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking h3 v0.0.8 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking term v1.2.1 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking tokio-tungstenite v0.28.0 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Checking rspec v1.0.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking slog-term v2.9.2 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking url-domain-parse v0.1.4 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.13.2 [INFO] [stderr] Checking hickory-proto v0.25.2 [INFO] [stderr] Checking tera v1.20.1 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking quinn-proto v0.11.14 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking h3-quinn v0.0.10 [INFO] [stderr] Checking flyer v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/router/mod.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | router: router [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `router` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/form.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | content: content, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/form.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | values: values, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/form.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | files: files [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/mod.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | headers: headers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/mod.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | body: body, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/response/mod.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | data: data [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http2.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | addr: addr, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http2.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | send: send [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `send` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http2.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | headers: headers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http3.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | request: request, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http3.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | stream: stream [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http3.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | headers: headers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:57:56 [INFO] [stdout] | [INFO] [stdout] 57 | self.sender.send(Payload { method: Type::Text, data: data }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:61:58 [INFO] [stdout] | [INFO] [stdout] 61 | self.sender.send(Payload { method: Type::Binary, data: data }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:65:56 [INFO] [stdout] | [INFO] [stdout] 65 | self.sender.send(Payload { method: Type::Ping, data: data }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:69:56 [INFO] [stdout] | [INFO] [stdout] 69 | self.sender.send(Payload { method: Type::Pong, data: data }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | sink: sink, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | stream: stream, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | req: req, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | res: res, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `res` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/mod.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | port: port, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/mod.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | server_config: server_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/server.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | key: key, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/server.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | cert: cert [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `cert` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cookie/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | cookies: cookies, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `cookies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/session/cookie.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | values: values, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/session/cookie.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | errors: errors, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/session/cookie.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | old: old, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `old` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/session/cookie.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | expires: expires, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `expires` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/view/functions.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | render: render, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `render` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/view/functions.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | req: req, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/validation/mod.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | form: form, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `form` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/validation/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | rules: rules, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/lib.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | let logger = crate::utils::logger::logger(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/lib.rs:69:22 [INFO] [stdout] | [INFO] [stdout] 69 | let logger = crate::utils::logger::logger(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/lib.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 81 | let logger = crate::utils::logger::logger(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/lib.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | let logger = crate::utils::logger::logger(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/router/mod.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | router: router [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `router` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/form.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | content: content, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/form.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | values: values, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/form.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | files: files [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/mod.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | headers: headers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/request/mod.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | body: body, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/response/mod.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | data: data [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http2.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | addr: addr, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http2.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | send: send [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `send` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http2.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | headers: headers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http3.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | request: request, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http3.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | stream: stream [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/http3.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | headers: headers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:57:56 [INFO] [stdout] | [INFO] [stdout] 57 | self.sender.send(Payload { method: Type::Text, data: data }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:61:58 [INFO] [stdout] | [INFO] [stdout] 61 | self.sender.send(Payload { method: Type::Binary, data: data }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:65:56 [INFO] [stdout] | [INFO] [stdout] 65 | self.sender.send(Payload { method: Type::Ping, data: data }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:69:56 [INFO] [stdout] | [INFO] [stdout] 69 | self.sender.send(Payload { method: Type::Pong, data: data }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | sink: sink, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | stream: stream, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | req: req, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/transport/handler/ws.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | res: res, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `res` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/mod.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | port: port, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/server/mod.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | server_config: server_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/server.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | key: key, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/server.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | cert: cert [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `cert` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cookie/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | cookies: cookies, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `cookies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/session/cookie.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | values: values, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/session/cookie.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | errors: errors, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/session/cookie.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | old: old, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `old` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/session/cookie.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | expires: expires, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `expires` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/view/functions.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | render: render, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `render` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/view/functions.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | req: req, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/validation/mod.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | form: form, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `form` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/validation/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | rules: rules, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/lib.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | let logger = crate::utils::logger::logger(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/lib.rs:69:22 [INFO] [stdout] | [INFO] [stdout] 69 | let logger = crate::utils::logger::logger(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/lib.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 81 | let logger = crate::utils::logger::logger(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/lib.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | let logger = crate::utils::logger::logger(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/resolver.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) ws: Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/resolver.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) ws: Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/resolver.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn new(routers: &mut Vec>) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/resolver.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return resolved; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return resolved; [INFO] [stdout] 21 + resolved [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/router/resolver.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) fn resolve<'q>(mut resolved: ResolvedRoutes, router: &mut Router) -> ResolvedRoutes { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/resolver.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return resolved; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return resolved; [INFO] [stdout] 47 + resolved [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/resolver.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn new(routers: &mut Vec>) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/resolver.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return resolved; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return resolved; [INFO] [stdout] 21 + resolved [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/router/resolver.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) fn resolve<'q>(mut resolved: ResolvedRoutes, router: &mut Router) -> ResolvedRoutes { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/resolver.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return resolved; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return resolved; [INFO] [stdout] 47 + resolved [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/router/middleware.rs:9:59 [INFO] [stdout] | [INFO] [stdout] 9 | static mut CONTAINER: LazyLock = LazyLock::new(|| Container::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Container::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return Self { [INFO] [stdout] 18 | | middlewares: LazyLock::new(|| HashMap::new()) [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Self { [INFO] [stdout] 18 + middlewares: LazyLock::new(|| HashMap::new()) [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/router/middleware.rs:18:40 [INFO] [stdout] | [INFO] [stdout] 18 | middlewares: LazyLock::new(|| HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashMap::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return ptr; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return ptr; [INFO] [stdout] 30 + ptr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return self.middlewares.get(&reference).unwrap()(req, res, next); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return self.middlewares.get(&reference).unwrap()(req, res, next); [INFO] [stdout] 34 + self.middlewares.get(&reference).unwrap()(req, res, next) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return unsafe { CONTAINER.insert(call) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return unsafe { CONTAINER.insert(call) }; [INFO] [stdout] 40 + unsafe { CONTAINER.insert(call) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return unsafe { CONTAINER.call(reference, req, res, next) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return unsafe { CONTAINER.call(reference, req, res, next) }; [INFO] [stdout] 45 + unsafe { CONTAINER.call(reference, req, res, next) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/router/middleware.rs:9:59 [INFO] [stdout] | [INFO] [stdout] 9 | static mut CONTAINER: LazyLock = LazyLock::new(|| Container::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Container::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return Self { [INFO] [stdout] 18 | | middlewares: LazyLock::new(|| HashMap::new()) [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Self { [INFO] [stdout] 18 + middlewares: LazyLock::new(|| HashMap::new()) [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/router/middleware.rs:18:40 [INFO] [stdout] | [INFO] [stdout] 18 | middlewares: LazyLock::new(|| HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashMap::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return ptr; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return ptr; [INFO] [stdout] 30 + ptr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/routes.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) ws: Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.not_found_callback` after checking its variant with `is_some` [INFO] [stdout] --> src/router/routes.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 34 | if self.not_found_callback.is_some() { [INFO] [stdout] | ------------------------------------ help: try: `if let Some() = &self.not_found_callback` [INFO] [stdout] 35 | self.not_found_callback.as_ref().unwrap()(req, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/routes.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - res.status_code = 404; [INFO] [stdout] 41 - [INFO] [stdout] 42 - return; [INFO] [stdout] 40 + res.status_code = 404; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/routes.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return None; [INFO] [stdout] 62 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/router/routes.rs:59:26 [INFO] [stdout] | [INFO] [stdout] 59 | return Some((&route, req, res)); [INFO] [stdout] | ^^^^^^ help: change this to: `route` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return self.middlewares.get(&reference).unwrap()(req, res, next); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return self.middlewares.get(&reference).unwrap()(req, res, next); [INFO] [stdout] 34 + self.middlewares.get(&reference).unwrap()(req, res, next) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return unsafe { CONTAINER.insert(call) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return unsafe { CONTAINER.insert(call) }; [INFO] [stdout] 40 + unsafe { CONTAINER.insert(call) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/middleware.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return unsafe { CONTAINER.call(reference, req, res, next) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return unsafe { CONTAINER.call(reference, req, res, next) }; [INFO] [stdout] 45 + unsafe { CONTAINER.call(reference, req, res, next) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/routes.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return true; [INFO] [stdout] 76 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/routes.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) ws: Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.not_found_callback` after checking its variant with `is_some` [INFO] [stdout] --> src/router/routes.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 34 | if self.not_found_callback.is_some() { [INFO] [stdout] | ------------------------------------ help: try: `if let Some() = &self.not_found_callback` [INFO] [stdout] 35 | self.not_found_callback.as_ref().unwrap()(req, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/routes.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - res.status_code = 404; [INFO] [stdout] 41 - [INFO] [stdout] 42 - return; [INFO] [stdout] 40 + res.status_code = 404; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/routes.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return None; [INFO] [stdout] 62 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/route.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return self; [INFO] [stdout] 31 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/router/routes.rs:59:26 [INFO] [stdout] | [INFO] [stdout] 59 | return Some((&route, req, res)); [INFO] [stdout] | ^^^^^^ help: change this to: `route` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/router/route.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) fn is_match<'a>(&self, req: &'a mut Request) -> (bool, Values) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 34 - pub(crate) fn is_match<'a>(&self, req: &'a mut Request) -> (bool, Values) { [INFO] [stdout] 34 + pub(crate) fn is_match(&self, req: &mut Request) -> (bool, Values) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/route.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return self.parameters_route_match(req); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return self.parameters_route_match(req); [INFO] [stdout] 39 + self.parameters_route_match(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/routes.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return true; [INFO] [stdout] 76 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/route.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return Some((path.trim_start_matches('{').trim_end_matches('}').to_owned(), matching)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return Some((path.trim_start_matches('{').trim_end_matches('}').to_owned(), matching)); [INFO] [stdout] 47 + Some((path.trim_start_matches('{').trim_end_matches('}').to_owned(), matching)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/router/route.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if PARAM_REGEX.is_match(&path) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!PARAM_REGEX.is_match(&path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/route.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return self; [INFO] [stdout] 31 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/router/route.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | fn parameters_route_match<'a>(&self, req: &'a mut Request) -> (bool, Values) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 51 - fn parameters_route_match<'a>(&self, req: &'a mut Request) -> (bool, Values) { [INFO] [stdout] 51 + fn parameters_route_match(&self, req: &mut Request) -> (bool, Values) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/route.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | return (true, parameters) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return (true, parameters) [INFO] [stdout] 120 + (true, parameters) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/router/route.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) fn is_match<'a>(&self, req: &'a mut Request) -> (bool, Values) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 34 - pub(crate) fn is_match<'a>(&self, req: &'a mut Request) -> (bool, Values) { [INFO] [stdout] 34 + pub(crate) fn is_match(&self, req: &mut Request) -> (bool, Values) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/route.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return self.parameters_route_match(req); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return self.parameters_route_match(req); [INFO] [stdout] 39 + self.parameters_route_match(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/route.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return Some((path.trim_start_matches('{').trim_end_matches('}').to_owned(), matching)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return Some((path.trim_start_matches('{').trim_end_matches('}').to_owned(), matching)); [INFO] [stdout] 47 + Some((path.trim_start_matches('{').trim_end_matches('}').to_owned(), matching)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/router/route.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if PARAM_REGEX.is_match(&path) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!PARAM_REGEX.is_match(&path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Some(…)).unwrap()` [INFO] [stdout] --> src/router/route.rs:64:58 [INFO] [stdout] | [INFO] [stdout] 64 | let subdomain_req: Vec = url.subdomain().or(Some(String::new())).unwrap().split(".").map(|v| v.to_string()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(String::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] = note: `#[warn(clippy::or_then_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/router/route.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | fn parameters_route_match<'a>(&self, req: &'a mut Request) -> (bool, Values) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 51 - fn parameters_route_match<'a>(&self, req: &'a mut Request) -> (bool, Values) { [INFO] [stdout] 51 + fn parameters_route_match(&self, req: &mut Request) -> (bool, Values) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/route.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | return (true, parameters) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return (true, parameters) [INFO] [stdout] 120 + (true, parameters) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/router/route.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 76 | if subdomain_req[j] == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `subdomain_req[j].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Some(…)).unwrap()` [INFO] [stdout] --> src/router/route.rs:64:58 [INFO] [stdout] | [INFO] [stdout] 64 | let subdomain_req: Vec = url.subdomain().or(Some(String::new())).unwrap().split(".").map(|v| v.to_string()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(String::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] = note: `#[warn(clippy::or_then_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/next.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | / return Self { [INFO] [stdout] 10 | | is_move: false [INFO] [stdout] 11 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 ~ Self { [INFO] [stdout] 10 + is_move: false [INFO] [stdout] 11 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/next.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return res; [INFO] [stdout] 17 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/router/route.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 76 | if subdomain_req[j] == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `subdomain_req[j].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/mod.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) ws: Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/mod.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 29 | pub(crate) routers: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return self.route("GET", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return self.route("GET", path, callback); [INFO] [stdout] 38 + self.route("GET", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return self.route("POST", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return self.route("POST", path, callback); [INFO] [stdout] 45 + self.route("POST", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return self.route("PUT", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return self.route("PUT", path, callback); [INFO] [stdout] 52 + self.route("PUT", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/next.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | / return Self { [INFO] [stdout] 10 | | is_move: false [INFO] [stdout] 11 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 ~ Self { [INFO] [stdout] 10 + is_move: false [INFO] [stdout] 11 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/next.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return res; [INFO] [stdout] 17 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/mod.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) ws: Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/router/mod.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 29 | pub(crate) routers: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return self.route("GET", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return self.route("GET", path, callback); [INFO] [stdout] 38 + self.route("GET", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return self.route("POST", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return self.route("POST", path, callback); [INFO] [stdout] 45 + self.route("POST", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return self.route("PUT", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return self.route("PUT", path, callback); [INFO] [stdout] 52 + self.route("PUT", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return self.route("PATCH", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return self.route("PATCH", path, callback); [INFO] [stdout] 59 + self.route("PATCH", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return self.route("DELETE", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return self.route("DELETE", path, callback); [INFO] [stdout] 66 + self.route("DELETE", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return self.route("PATCH", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return self.route("PATCH", path, callback); [INFO] [stdout] 59 + self.route("PATCH", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return self.route("HEAD", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return self.route("HEAD", path, callback); [INFO] [stdout] 73 + self.route("HEAD", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return self.route("OPTIONS", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return self.route("OPTIONS", path, callback); [INFO] [stdout] 80 + self.route("OPTIONS", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return &mut self.web[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return &mut self.web[idx]; [INFO] [stdout] 97 + &mut self.web[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return self.route("DELETE", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return self.route("DELETE", path, callback); [INFO] [stdout] 66 + self.route("DELETE", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return self.route("HEAD", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return self.route("HEAD", path, callback); [INFO] [stdout] 73 + self.route("HEAD", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return self.route("OPTIONS", path, callback); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return self.route("OPTIONS", path, callback); [INFO] [stdout] 80 + self.route("OPTIONS", path, callback) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return &mut self.web[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return &mut self.web[idx]; [INFO] [stdout] 97 + &mut self.web[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/router/mod.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | method: String::from(method.to_uppercase()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `method.to_uppercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return &mut self.ws[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return &mut self.ws[idx]; [INFO] [stdout] 114 + &mut self.ws[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/router/mod.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | method: String::from(method.to_uppercase()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `method.to_uppercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return &mut self.ws[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return &mut self.ws[idx]; [INFO] [stdout] 114 + &mut self.ws[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return self; [INFO] [stdout] 131 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return GroupRouter::new(self.routers[idx].as_mut()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return GroupRouter::new(self.routers[idx].as_mut()); [INFO] [stdout] 148 + GroupRouter::new(self.routers[idx].as_mut()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return self; [INFO] [stdout] 131 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | return sub_group; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return sub_group; [INFO] [stdout] 156 + sub_group [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return GroupRouter::new(self.routers[idx].as_mut()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return GroupRouter::new(self.routers[idx].as_mut()); [INFO] [stdout] 148 + GroupRouter::new(self.routers[idx].as_mut()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / return Self { [INFO] [stdout] 167 | | router: router [INFO] [stdout] 168 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 ~ Self { [INFO] [stdout] 167 + router: router [INFO] [stdout] 168 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | return sub_group; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return sub_group; [INFO] [stdout] 156 + sub_group [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return self; [INFO] [stdout] 176 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / return Self { [INFO] [stdout] 167 | | router: router [INFO] [stdout] 168 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 ~ Self { [INFO] [stdout] 167 + router: router [INFO] [stdout] 168 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/router/mod.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return self; [INFO] [stdout] 176 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/form.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / return Self { [INFO] [stdout] 23 | | name: name.to_string(), [INFO] [stdout] 24 | | mime: mime.to_string(), [INFO] [stdout] 25 | | content: content, [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ Self { [INFO] [stdout] 23 + name: name.to_string(), [INFO] [stdout] 24 + mime: mime.to_string(), [INFO] [stdout] 25 + content: content, [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/form.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(path); [INFO] [stdout] 49 + Ok(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/form.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / return Self { [INFO] [stdout] 23 | | name: name.to_string(), [INFO] [stdout] 24 | | mime: mime.to_string(), [INFO] [stdout] 25 | | content: content, [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ Self { [INFO] [stdout] 23 + name: name.to_string(), [INFO] [stdout] 24 + mime: mime.to_string(), [INFO] [stdout] 25 + content: content, [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/form.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(path); [INFO] [stdout] 49 + Ok(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/form.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return Self { [INFO] [stdout] 60 | | values: values, [INFO] [stdout] 61 | | files: files [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ Self { [INFO] [stdout] 60 + values: values, [INFO] [stdout] 61 + files: files [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/form.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return Self { [INFO] [stdout] 60 | | values: values, [INFO] [stdout] 61 | | files: files [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ Self { [INFO] [stdout] 60 + values: values, [INFO] [stdout] 61 + files: files [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/parser.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return Ok(req); [INFO] [stdout] 22 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/parser.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return Ok(req); [INFO] [stdout] 22 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/parser.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return Ok(boundary); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(boundary); [INFO] [stdout] 33 + Ok(boundary) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/parser.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Ok(req); [INFO] [stdout] 64 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Ok(…)).unwrap()` [INFO] [stdout] --> src/request/parser.rs:42:58 [INFO] [stdout] | [INFO] [stdout] 42 | while let Some(field) = multipart.next_field().await.or::>>(Ok(None)).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(None)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Ok(…)).unwrap()` [INFO] [stdout] --> src/request/parser.rs:46:36 [INFO] [stdout] | [INFO] [stdout] 46 | field.text().await.or::>(Ok("".to_string())).unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or("".to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/parser.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return Ok(boundary); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(boundary); [INFO] [stdout] 33 + Ok(boundary) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/parser.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Ok(req); [INFO] [stdout] 64 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Ok(…)).unwrap()` [INFO] [stdout] --> src/request/parser.rs:42:58 [INFO] [stdout] | [INFO] [stdout] 42 | while let Some(field) = multipart.next_field().await.or::>>(Ok(None)).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(None)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Ok(…)).unwrap()` [INFO] [stdout] --> src/request/parser.rs:46:36 [INFO] [stdout] | [INFO] [stdout] 46 | field.text().await.or::>(Ok("".to_string())).unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or("".to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Ok(…)).unwrap()` [INFO] [stdout] --> src/request/parser.rs:55:49 [INFO] [stdout] | [INFO] [stdout] 55 | let data = field.bytes().await.as_mut().or::<&mut Bytes>(Ok(&mut bytes::Bytes::new())).unwrap().to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(&mut bytes::Bytes::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Ok(…)).unwrap()` [INFO] [stdout] --> src/request/parser.rs:55:49 [INFO] [stdout] | [INFO] [stdout] 55 | let data = field.bytes().await.as_mut().or::<&mut Bytes>(Ok(&mut bytes::Bytes::new())).unwrap().to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(&mut bytes::Bytes::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/request/parser.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 57 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/request/parser.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 57 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/parser.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Ok(req); [INFO] [stdout] 74 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/parser.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Ok(req); [INFO] [stdout] 74 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / return Self { [INFO] [stdout] 31 | | session: None, [INFO] [stdout] 32 | | ip: "".to_owned(), [INFO] [stdout] 33 | | host: "".to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 42 | | cookies: Box::new(Cookies::new(Values::new())), [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ Self { [INFO] [stdout] 31 + session: None, [INFO] [stdout] 32 + ip: "".to_owned(), [INFO] [stdout] 33 + host: "".to_owned(), [INFO] [stdout] 34 + method: method.to_owned(), [INFO] [stdout] 35 + path: path.to_owned(), [INFO] [stdout] 36 + query: Values::new(), [INFO] [stdout] 37 + parameters: Values::new(), [INFO] [stdout] 38 + protocol: "HTTP/1.1".to_string(), [INFO] [stdout] 39 + headers: headers, [INFO] [stdout] 40 + body: body, [INFO] [stdout] 41 + form: Form::new(Values::new(), Files::new()), [INFO] [stdout] 42 + cookies: Box::new(Cookies::new(Values::new())), [INFO] [stdout] 43 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / return Self { [INFO] [stdout] 31 | | session: None, [INFO] [stdout] 32 | | ip: "".to_owned(), [INFO] [stdout] 33 | | host: "".to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 42 | | cookies: Box::new(Cookies::new(Values::new())), [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ Self { [INFO] [stdout] 31 + session: None, [INFO] [stdout] 32 + ip: "".to_owned(), [INFO] [stdout] 33 + host: "".to_owned(), [INFO] [stdout] 34 + method: method.to_owned(), [INFO] [stdout] 35 + path: path.to_owned(), [INFO] [stdout] 36 + query: Values::new(), [INFO] [stdout] 37 + parameters: Values::new(), [INFO] [stdout] 38 + protocol: "HTTP/1.1".to_string(), [INFO] [stdout] 39 + headers: headers, [INFO] [stdout] 40 + body: body, [INFO] [stdout] 41 + form: Form::new(Values::new(), Files::new()), [INFO] [stdout] 42 + cookies: Box::new(Cookies::new(Values::new())), [INFO] [stdout] 43 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return file_split.len() > 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return file_split.len() > 1; [INFO] [stdout] 55 + file_split.len() > 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return file_split.len() > 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return file_split.len() > 1; [INFO] [stdout] 55 + file_split.len() > 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return self.ip.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return self.ip.to_owned(); [INFO] [stdout] 59 + self.ip.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return self.ip.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return self.ip.to_owned(); [INFO] [stdout] 59 + self.ip.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return self.headers.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return self.headers.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] 63 + self.headers.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return self.headers.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return self.headers.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] 63 + self.headers.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return self.parameters.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return self.parameters.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] 67 + self.parameters.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return self.parameters.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return self.parameters.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] 67 + self.parameters.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return self.query.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return self.query.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] 71 + self.query.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return self.query.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return self.query.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] 71 + self.query.get(key).get_or_insert(&"".to_string()).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return self.form.values.get(key).get_or_insert(&"".to_owned()).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return self.form.values.get(key).get_or_insert(&"".to_owned()).to_string(); [INFO] [stdout] 75 + self.form.values.get(key).get_or_insert(&"".to_owned()).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return self.form.values.get(key).get_or_insert(&"".to_owned()).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return self.form.values.get(key).get_or_insert(&"".to_owned()).to_string(); [INFO] [stdout] 75 + self.form.values.get(key).get_or_insert(&"".to_owned()).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return self.form.files.get(key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return self.form.files.get(key); [INFO] [stdout] 79 + self.form.files.get(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return self.form.files.get(key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return self.form.files.get(key); [INFO] [stdout] 79 + self.form.files.get(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return content_type_piece.get(0).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return content_type_piece.get(0).unwrap().to_string(); [INFO] [stdout] 86 + content_type_piece.get(0).unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `content_type_piece.get(0)` [INFO] [stdout] --> src/request/mod.rs:86:16 [INFO] [stdout] | [INFO] [stdout] 86 | return content_type_piece.get(0).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content_type_piece.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return content_type_piece.get(0).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return content_type_piece.get(0).unwrap().to_string(); [INFO] [stdout] 86 + content_type_piece.get(0).unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return header_piece.get(0).unwrap().cmp(&"application/json") == Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return header_piece.get(0).unwrap().cmp(&"application/json") == Ordering::Equal; [INFO] [stdout] 93 + header_piece.get(0).unwrap().cmp(&"application/json") == Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `content_type_piece.get(0)` [INFO] [stdout] --> src/request/mod.rs:86:16 [INFO] [stdout] | [INFO] [stdout] 86 | return content_type_piece.get(0).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content_type_piece.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `header_piece.get(0)` [INFO] [stdout] --> src/request/mod.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | return header_piece.get(0).unwrap().cmp(&"application/json") == Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `header_piece.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return header_piece.get(0).unwrap().cmp(&"application/json") == Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return header_piece.get(0).unwrap().cmp(&"application/json") == Ordering::Equal; [INFO] [stdout] 93 + header_piece.get(0).unwrap().cmp(&"application/json") == Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return self.session.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return self.session.as_mut().unwrap(); [INFO] [stdout] 97 + self.session.as_mut().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `header_piece.get(0)` [INFO] [stdout] --> src/request/mod.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | return header_piece.get(0).unwrap().cmp(&"application/json") == Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `header_piece.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | return &mut self.cookies; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return &mut self.cookies; [INFO] [stdout] 101 + &mut self.cookies [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return self.session.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return self.session.as_mut().unwrap(); [INFO] [stdout] 97 + self.session.as_mut().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/parser.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return res; [INFO] [stdout] 21 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | return &mut self.cookies; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return &mut self.cookies; [INFO] [stdout] 101 + &mut self.cookies [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/parser.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return res; [INFO] [stdout] 21 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Response` [INFO] [stdout] --> src/response/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn new() -> Self { [INFO] [stdout] 29 | | return Self { [INFO] [stdout] 30 | | ws: None, [INFO] [stdout] 31 | | status_code: 200, [INFO] [stdout] ... | [INFO] [stdout] 38 | | }; [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 27 + impl Default for Response { [INFO] [stdout] 28 + fn default() -> Self { [INFO] [stdout] 29 + Self::new() [INFO] [stdout] 30 + } [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return Self { [INFO] [stdout] 30 | | ws: None, [INFO] [stdout] 31 | | status_code: 200, [INFO] [stdout] 32 | | headers: Headers::new(), [INFO] [stdout] ... | [INFO] [stdout] 37 | | old: Values::new(), [INFO] [stdout] 38 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Self { [INFO] [stdout] 30 + ws: None, [INFO] [stdout] 31 + status_code: 200, [INFO] [stdout] 32 + headers: Headers::new(), [INFO] [stdout] 33 + referer: String::new(), [INFO] [stdout] 34 + body: vec![], [INFO] [stdout] 35 + view: None, [INFO] [stdout] 36 + errors: Values::new(), [INFO] [stdout] 37 + old: Values::new(), [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return self; [INFO] [stdout] 44 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return self; [INFO] [stdout] 50 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Response` [INFO] [stdout] --> src/response/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn new() -> Self { [INFO] [stdout] 29 | | return Self { [INFO] [stdout] 30 | | ws: None, [INFO] [stdout] 31 | | status_code: 200, [INFO] [stdout] ... | [INFO] [stdout] 38 | | }; [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 27 + impl Default for Response { [INFO] [stdout] 28 + fn default() -> Self { [INFO] [stdout] 29 + Self::new() [INFO] [stdout] 30 + } [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return self; [INFO] [stdout] 56 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return Self { [INFO] [stdout] 30 | | ws: None, [INFO] [stdout] 31 | | status_code: 200, [INFO] [stdout] 32 | | headers: Headers::new(), [INFO] [stdout] ... | [INFO] [stdout] 37 | | old: Values::new(), [INFO] [stdout] 38 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Self { [INFO] [stdout] 30 + ws: None, [INFO] [stdout] 31 + status_code: 200, [INFO] [stdout] 32 + headers: Headers::new(), [INFO] [stdout] 33 + referer: String::new(), [INFO] [stdout] 34 + body: vec![], [INFO] [stdout] 35 + view: None, [INFO] [stdout] 36 + errors: Values::new(), [INFO] [stdout] 37 + old: Values::new(), [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return self; [INFO] [stdout] 44 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return self; [INFO] [stdout] 50 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self; [INFO] [stdout] 62 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return self; [INFO] [stdout] 56 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return self.header("Content-Type", "application/json") [INFO] [stdout] 70 | | .body(serde_json::to_string(object).unwrap().as_bytes()); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ self.header("Content-Type", "application/json") [INFO] [stdout] 70 ~ .body(serde_json::to_string(object).unwrap().as_bytes()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self; [INFO] [stdout] 62 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return self.header("Content-Type", "text/html") [INFO] [stdout] 75 | | .body(html.as_bytes()); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ self.header("Content-Type", "text/html") [INFO] [stdout] 75 ~ .body(html.as_bytes()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return self.header("Content-Type", "application/json") [INFO] [stdout] 70 | | .body(serde_json::to_string(object).unwrap().as_bytes()); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ self.header("Content-Type", "application/json") [INFO] [stdout] 70 ~ .body(serde_json::to_string(object).unwrap().as_bytes()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return self; [INFO] [stdout] 84 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return self.html(&html).status_code(307); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return self.html(&html).status_code(307); [INFO] [stdout] 97 + self.html(&html).status_code(307) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return self.header("Content-Type", "text/html") [INFO] [stdout] 75 | | .body(html.as_bytes()); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ self.header("Content-Type", "text/html") [INFO] [stdout] 75 ~ .body(html.as_bytes()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return self; [INFO] [stdout] 84 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return self.html(&html).status_code(307); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return self.html(&html).status_code(307); [INFO] [stdout] 97 + self.html(&html).status_code(307) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | return self.redirect(&redirect); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return self.redirect(&redirect); [INFO] [stdout] 107 + self.redirect(&redirect) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/response/mod.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | if redirect == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `redirect.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return self; [INFO] [stdout] 113 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return self; [INFO] [stdout] 121 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | return self.redirect(&redirect); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return self.redirect(&redirect); [INFO] [stdout] 107 + self.redirect(&redirect) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/response/mod.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | if redirect == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `redirect.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return self; [INFO] [stdout] 113 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return self; [INFO] [stdout] 121 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return self; [INFO] [stdout] 129 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Ws` [INFO] [stdout] --> src/ws/mod.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / pub fn new() -> Self { [INFO] [stdout] 36 | | return Ws { [INFO] [stdout] 37 | | event: None [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 34 + impl Default for Ws { [INFO] [stdout] 35 + fn default() -> Self { [INFO] [stdout] 36 + Self::new() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ws/mod.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / return Ws { [INFO] [stdout] 37 | | event: None [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 ~ Ws { [INFO] [stdout] 37 + event: None [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return self; [INFO] [stdout] 129 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Ws` [INFO] [stdout] --> src/ws/mod.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / pub fn new() -> Self { [INFO] [stdout] 36 | | return Ws { [INFO] [stdout] 37 | | event: None [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 34 + impl Default for Ws { [INFO] [stdout] 35 + fn default() -> Self { [INFO] [stdout] 36 + Self::new() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ws/mod.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / return Ws { [INFO] [stdout] 37 | | event: None [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 ~ Ws { [INFO] [stdout] 37 + event: None [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/server/transport/tcp.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | return Ok( [INFO] [stdout] | ________________^ [INFO] [stdout] 85 | | match GLOBAL_SERVER.get_mut().unwrap().on_ws_request(req, res).await { [INFO] [stdout] 86 | | Some((route, req, res)) => { [INFO] [stdout] ... | [INFO] [stdout] 95 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 84 ~ return { [INFO] [stdout] 85 + let _: () = match GLOBAL_SERVER.get_mut().unwrap().on_ws_request(req, res).await { [INFO] [stdout] 86 + Some((route, req, res)) => { [INFO] [stdout] 87 + [INFO] [stdout] 88 + [INFO] [stdout] 89 + let mut handler = ws::Handler::new(rw, req, res).await.unwrap(); [INFO] [stdout] 90 + [INFO] [stdout] 91 + handler.handle(route).await.unwrap(); [INFO] [stdout] 92 + }, [INFO] [stdout] 93 + None => { drop(rw); }, [INFO] [stdout] 94 + }; [INFO] [stdout] 95 + Ok( [INFO] [stdout] 96 + () [INFO] [stdout] 97 + ) [INFO] [stdout] 98 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/tcp.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return Ok(()); [INFO] [stdout] 124 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/server/transport/tcp.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | return Ok( [INFO] [stdout] | ________________^ [INFO] [stdout] 85 | | match GLOBAL_SERVER.get_mut().unwrap().on_ws_request(req, res).await { [INFO] [stdout] 86 | | Some((route, req, res)) => { [INFO] [stdout] ... | [INFO] [stdout] 95 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 84 ~ return { [INFO] [stdout] 85 + let _: () = match GLOBAL_SERVER.get_mut().unwrap().on_ws_request(req, res).await { [INFO] [stdout] 86 + Some((route, req, res)) => { [INFO] [stdout] 87 + [INFO] [stdout] 88 + [INFO] [stdout] 89 + let mut handler = ws::Handler::new(rw, req, res).await.unwrap(); [INFO] [stdout] 90 + [INFO] [stdout] 91 + handler.handle(route).await.unwrap(); [INFO] [stdout] 92 + }, [INFO] [stdout] 93 + None => { drop(rw); }, [INFO] [stdout] 94 + }; [INFO] [stdout] 95 + Ok( [INFO] [stdout] 96 + () [INFO] [stdout] 97 + ) [INFO] [stdout] 98 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/tcp.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return Ok(()); [INFO] [stdout] 151 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/tcp.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | Err(err) => { return Err(err.into()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 - Err(err) => { return Err(err.into()); }, [INFO] [stdout] 153 + Err(err) => { Err(err.into())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/server/transport/tcp.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | / match result { [INFO] [stdout] 138 | | Ok((request, send)) => { [INFO] [stdout] 139 | | tokio::spawn(async move { [INFO] [stdout] 140 | | let mut handler = http2::Handler::new(addr, send); [INFO] [stdout] ... | [INFO] [stdout] 148 | | Err(_) => {}, [INFO] [stdout] 149 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 137 ~ if let Ok((request, send)) = result { [INFO] [stdout] 138 + tokio::spawn(async move { [INFO] [stdout] 139 + let mut handler = http2::Handler::new(addr, send); [INFO] [stdout] 140 + let (mut req, mut res) = (handler.transform(request).await.unwrap(), Response::new()); [INFO] [stdout] 141 + [INFO] [stdout] 142 + GLOBAL_SERVER.get_mut().unwrap().on_web_request(&mut req, &mut res).await.unwrap(); // TODO: need to remove and use `server_ptr` [INFO] [stdout] 143 + [INFO] [stdout] 144 + handler.write(&mut req, &mut res).await.unwrap(); [INFO] [stdout] 145 + }); [INFO] [stdout] 146 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/tcp.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return Ok(()); [INFO] [stdout] 124 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named constant with interior mutability [INFO] [stdout] --> src/server/transport/udp.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const ALPN_PROTOCOLS: LazyLock>> = LazyLock::new(|| vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: did you mean to make this a `static` item [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stdout] = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/tcp.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return Ok(()); [INFO] [stdout] 151 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/tcp.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | Err(err) => { return Err(err.into()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 - Err(err) => { return Err(err.into()); }, [INFO] [stdout] 153 + Err(err) => { Err(err.into())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/server/transport/udp.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / match &server.server_config { [INFO] [stdout] 28 | | Some(config) => listener(get_endpoint(server.address(), config.clone()).unwrap()).await, [INFO] [stdout] 29 | | None => {}, [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(config) = &server.server_config { listener(get_endpoint(server.address(), config.clone()).unwrap()).await }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/udp.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return Ok(Endpoint::server(server_config, address.parse().unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Ok(Endpoint::server(server_config, address.parse().unwrap()).unwrap()); [INFO] [stdout] 38 + Ok(Endpoint::server(server_config, address.parse().unwrap()).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/server/transport/tcp.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | / match result { [INFO] [stdout] 138 | | Ok((request, send)) => { [INFO] [stdout] 139 | | tokio::spawn(async move { [INFO] [stdout] 140 | | let mut handler = http2::Handler::new(addr, send); [INFO] [stdout] ... | [INFO] [stdout] 148 | | Err(_) => {}, [INFO] [stdout] 149 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 137 ~ if let Ok((request, send)) = result { [INFO] [stdout] 138 + tokio::spawn(async move { [INFO] [stdout] 139 + let mut handler = http2::Handler::new(addr, send); [INFO] [stdout] 140 + let (mut req, mut res) = (handler.transform(request).await.unwrap(), Response::new()); [INFO] [stdout] 141 + [INFO] [stdout] 142 + GLOBAL_SERVER.get_mut().unwrap().on_web_request(&mut req, &mut res).await.unwrap(); // TODO: need to remove and use `server_ptr` [INFO] [stdout] 143 + [INFO] [stdout] 144 + handler.write(&mut req, &mut res).await.unwrap(); [INFO] [stdout] 145 + }); [INFO] [stdout] 146 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: borrow of a named constant with interior mutability [INFO] [stdout] --> src/server/transport/udp.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 35 | config.alpn_protocols = ALPN_PROTOCOLS.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: there is a compiler inserted call to `Deref::deref` here [INFO] [stdout] = help: this lint can be silenced by assigning the value to a local variable before borrowing [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stdout] = note: `#[warn(clippy::borrow_interior_mutable_const)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named constant with interior mutability [INFO] [stdout] --> src/server/transport/udp.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const ALPN_PROTOCOLS: LazyLock>> = LazyLock::new(|| vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: did you mean to make this a `static` item [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stdout] = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/server/transport/udp.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / match &server.server_config { [INFO] [stdout] 28 | | Some(config) => listener(get_endpoint(server.address(), config.clone()).unwrap()).await, [INFO] [stdout] 29 | | None => {}, [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(config) = &server.server_config { listener(get_endpoint(server.address(), config.clone()).unwrap()).await }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/udp.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return Ok(Endpoint::server(server_config, address.parse().unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Ok(Endpoint::server(server_config, address.parse().unwrap()).unwrap()); [INFO] [stdout] 38 + Ok(Endpoint::server(server_config, address.parse().unwrap()).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: borrow of a named constant with interior mutability [INFO] [stdout] --> src/server/transport/udp.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 35 | config.alpn_protocols = ALPN_PROTOCOLS.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: there is a compiler inserted call to `Deref::deref` here [INFO] [stdout] = help: this lint can be silenced by assigning the value to a local variable before borrowing [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stdout] = note: `#[warn(clippy::borrow_interior_mutable_const)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http1.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return parse_content_type(req).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return parse_content_type(req).await; [INFO] [stdout] 68 + parse_content_type(req).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http1.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return parse_content_type(req).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return parse_content_type(req).await; [INFO] [stdout] 68 + parse_content_type(req).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http1.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / return Ok(HttpHeader { [INFO] [stdout] 118 | | method, [INFO] [stdout] 119 | | path, [INFO] [stdout] 120 | | query: parse_query_params(&query)?, [INFO] [stdout] 121 | | headers, [INFO] [stdout] 122 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 ~ Ok(HttpHeader { [INFO] [stdout] 118 + method, [INFO] [stdout] 119 + path, [INFO] [stdout] 120 + query: parse_query_params(&query)?, [INFO] [stdout] 121 + headers, [INFO] [stdout] 122 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim_end` before `str::split_whitespace` [INFO] [stdout] --> src/server/transport/handler/http1.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 100 | let parts: Vec<&str> = line.trim_end().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^^^^^ help: remove `trim_end()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http1.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | return Ok(headers); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return Ok(headers); [INFO] [stdout] 154 + Ok(headers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http1.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / return Ok(HttpHeader { [INFO] [stdout] 118 | | method, [INFO] [stdout] 119 | | path, [INFO] [stdout] 120 | | query: parse_query_params(&query)?, [INFO] [stdout] 121 | | headers, [INFO] [stdout] 122 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 ~ Ok(HttpHeader { [INFO] [stdout] 118 + method, [INFO] [stdout] 119 + path, [INFO] [stdout] 120 + query: parse_query_params(&query)?, [INFO] [stdout] 121 + headers, [INFO] [stdout] 122 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server/transport/handler/http1.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | / if let Some(te) = headers.get("transfer-encoding") { [INFO] [stdout] 161 | | if te.eq_ignore_ascii_case("chunked") { [INFO] [stdout] 162 | | return unsafe { self.read_body_transfer_encoding() }.await; [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 160 ~ if let Some(te) = headers.get("transfer-encoding") [INFO] [stdout] 161 ~ && te.eq_ignore_ascii_case("chunked") { [INFO] [stdout] 162 | return unsafe { self.read_body_transfer_encoding() }.await; [INFO] [stdout] 163 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim_end` before `str::split_whitespace` [INFO] [stdout] --> src/server/transport/handler/http1.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 100 | let parts: Vec<&str> = line.trim_end().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^^^^^ help: remove `trim_end()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http1.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | return Ok(headers); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return Ok(headers); [INFO] [stdout] 154 + Ok(headers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server/transport/handler/http1.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | / if let Some(te) = headers.get("transfer-encoding") { [INFO] [stdout] 161 | | if te.eq_ignore_ascii_case("chunked") { [INFO] [stdout] 162 | | return unsafe { self.read_body_transfer_encoding() }.await; [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 160 ~ if let Some(te) = headers.get("transfer-encoding") [INFO] [stdout] 161 ~ && te.eq_ignore_ascii_case("chunked") { [INFO] [stdout] 162 | return unsafe { self.read_body_transfer_encoding() }.await; [INFO] [stdout] 163 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http2.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return Self { [INFO] [stdout] 30 | | addr: addr, [INFO] [stdout] 31 | | send: send [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Self { [INFO] [stdout] 30 + addr: addr, [INFO] [stdout] 31 + send: send [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http2.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return Ok(req); [INFO] [stdout] 61 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Some(…)).unwrap()` [INFO] [stdout] --> src/server/transport/handler/http2.rs:51:52 [INFO] [stdout] | [INFO] [stdout] 51 | body: request.into_body().data().await.or(Some(Ok(Bytes::new()))).unwrap().unwrap().to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(Ok(Bytes::new()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http2.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return Self { [INFO] [stdout] 30 | | addr: addr, [INFO] [stdout] 31 | | send: send [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Self { [INFO] [stdout] 30 + addr: addr, [INFO] [stdout] 31 + send: send [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http2.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return Ok(req); [INFO] [stdout] 61 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http2.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return headers; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return headers; [INFO] [stdout] 90 + headers [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http3.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return Self { [INFO] [stdout] 25 | | request: request, [INFO] [stdout] 26 | | stream: stream [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ Self { [INFO] [stdout] 25 + request: request, [INFO] [stdout] 26 + stream: stream [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http3.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return headers; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return headers; [INFO] [stdout] 37 + headers [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Some(…)).unwrap()` [INFO] [stdout] --> src/server/transport/handler/http2.rs:51:52 [INFO] [stdout] | [INFO] [stdout] 51 | body: request.into_body().data().await.or(Some(Ok(Bytes::new()))).unwrap().unwrap().to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(Ok(Bytes::new()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http3.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / return headers [INFO] [stdout] 42 | | .get("host") [INFO] [stdout] 43 | | .cloned() [INFO] [stdout] 44 | | .or_else(|| headers.get(":authority").cloned()) [INFO] [stdout] 45 | | .or_else(|| Some(String::from("127.0.0.1"))) // TODO: fix this temp (src/router/route.rs domain) [INFO] [stdout] 46 | | .unwrap_or_default(); [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 ~ headers [INFO] [stdout] 42 + .get("host") [INFO] [stdout] 43 + .cloned() [INFO] [stdout] 44 + .or_else(|| headers.get(":authority").cloned()) [INFO] [stdout] 45 + .or_else(|| Some(String::from("127.0.0.1"))) // TODO: fix this temp (src/router/route.rs domain) [INFO] [stdout] 46 ~ .unwrap_or_default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http3.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Ok(req); [INFO] [stdout] 71 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http2.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return headers; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return headers; [INFO] [stdout] 90 + headers [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http3.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return Self { [INFO] [stdout] 25 | | request: request, [INFO] [stdout] 26 | | stream: stream [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ Self { [INFO] [stdout] 25 + request: request, [INFO] [stdout] 26 + stream: stream [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http3.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return headers; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return headers; [INFO] [stdout] 37 + headers [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http3.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / return headers [INFO] [stdout] 42 | | .get("host") [INFO] [stdout] 43 | | .cloned() [INFO] [stdout] 44 | | .or_else(|| headers.get(":authority").cloned()) [INFO] [stdout] 45 | | .or_else(|| Some(String::from("127.0.0.1"))) // TODO: fix this temp (src/router/route.rs domain) [INFO] [stdout] 46 | | .unwrap_or_default(); [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 ~ headers [INFO] [stdout] 42 + .get("host") [INFO] [stdout] 43 + .cloned() [INFO] [stdout] 44 + .or_else(|| headers.get(":authority").cloned()) [INFO] [stdout] 45 + .or_else(|| Some(String::from("127.0.0.1"))) // TODO: fix this temp (src/router/route.rs domain) [INFO] [stdout] 46 ~ .unwrap_or_default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/http3.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return Ok(req); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Ok(req); [INFO] [stdout] 71 + Ok(req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/ws.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / return Ok(Self { [INFO] [stdout] 88 | | sink: sink, [INFO] [stdout] 89 | | stream: stream, [INFO] [stdout] 90 | | receiver: rx, [INFO] [stdout] ... | [INFO] [stdout] 93 | | res: res, [INFO] [stdout] 94 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 ~ Ok(Self { [INFO] [stdout] 88 + sink: sink, [INFO] [stdout] 89 + stream: stream, [INFO] [stdout] 90 + receiver: rx, [INFO] [stdout] 91 + ws: Ws::new(), [INFO] [stdout] 92 + req: req, [INFO] [stdout] 93 + res: res, [INFO] [stdout] 94 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `s` after checking its variant with `is_ok` [INFO] [stdout] --> src/server/transport/handler/ws.rs:109:29 [INFO] [stdout] | [INFO] [stdout] 108 | if s.is_ok() { [INFO] [stdout] | ------------ help: try: `if let Ok() = s` [INFO] [stdout] 109 | s.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/ws.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / return Ok(Self { [INFO] [stdout] 88 | | sink: sink, [INFO] [stdout] 89 | | stream: stream, [INFO] [stdout] 90 | | receiver: rx, [INFO] [stdout] ... | [INFO] [stdout] 93 | | res: res, [INFO] [stdout] 94 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 ~ Ok(Self { [INFO] [stdout] 88 + sink: sink, [INFO] [stdout] 89 + stream: stream, [INFO] [stdout] 90 + receiver: rx, [INFO] [stdout] 91 + ws: Ws::new(), [INFO] [stdout] 92 + req: req, [INFO] [stdout] 93 + res: res, [INFO] [stdout] 94 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `s` after checking its variant with `is_ok` [INFO] [stdout] --> src/server/transport/handler/ws.rs:109:29 [INFO] [stdout] | [INFO] [stdout] 108 | if s.is_ok() { [INFO] [stdout] | ------------ help: try: `if let Ok() = s` [INFO] [stdout] 109 | s.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/ws.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Ok(()); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/ws.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | return accept; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return accept; [INFO] [stdout] 190 + accept [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/ws.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Ok(()); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/helpers/mod.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return RequestHandler { }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return RequestHandler { }; [INFO] [stdout] 19 + RequestHandler { } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `server.session_manager` after checking its variant with `is_some` [INFO] [stdout] --> src/server/helpers/mod.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 27 | if !req.is_asset() && server.session_manager.is_some() { [INFO] [stdout] | -------------------------------- the check is happening here [INFO] [stdout] 28 | / server.session_manager [INFO] [stdout] 29 | | .as_mut() [INFO] [stdout] 30 | | .unwrap() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cookie` after checking its variant with `is_ok` [INFO] [stdout] --> src/server/helpers/mod.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 37 | if cookie.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = cookie` [INFO] [stdout] 38 | req.cookies.cookies = cookie.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/helpers/mod.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Ok(()); [INFO] [stdout] 41 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `server.view` after checking its variant with `is_some` [INFO] [stdout] --> src/server/helpers/mod.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 52 | if res.view.is_some() && server.view.is_some() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] 53 | server.view.as_mut().unwrap().render(req, res).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/helpers/mod.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Ok(()); [INFO] [stdout] 64 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/transport/handler/ws.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | return accept; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return accept; [INFO] [stdout] 190 + accept [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/server/mod.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) routers: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/helpers/mod.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return RequestHandler { }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return RequestHandler { }; [INFO] [stdout] 19 + RequestHandler { } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `server.session_manager` after checking its variant with `is_some` [INFO] [stdout] --> src/server/helpers/mod.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 27 | if !req.is_asset() && server.session_manager.is_some() { [INFO] [stdout] | -------------------------------- the check is happening here [INFO] [stdout] 28 | / server.session_manager [INFO] [stdout] 29 | | .as_mut() [INFO] [stdout] 30 | | .unwrap() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cookie` after checking its variant with `is_ok` [INFO] [stdout] --> src/server/helpers/mod.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 37 | if cookie.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = cookie` [INFO] [stdout] 38 | req.cookies.cookies = cookie.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return format!("{}:{}", self.host, self.port); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return format!("{}:{}", self.host, self.port); [INFO] [stdout] 61 + format!("{}:{}", self.host, self.port) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return self.routers[idx].as_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return self.routers[idx].as_mut(); [INFO] [stdout] 78 + self.routers[idx].as_mut() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return self; [INFO] [stdout] 84 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return self; [INFO] [stdout] 90 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return self; [INFO] [stdout] 96 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/helpers/mod.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Ok(()); [INFO] [stdout] 41 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return self; [INFO] [stdout] 103 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `server.view` after checking its variant with `is_some` [INFO] [stdout] --> src/server/helpers/mod.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 52 | if res.view.is_some() && server.view.is_some() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] 53 | server.view.as_mut().unwrap().render(req, res).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/helpers/mod.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Ok(()); [INFO] [stdout] 64 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/server/mod.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) routers: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return self; [INFO] [stdout] 109 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return format!("{}:{}", self.host, self.port); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return format!("{}:{}", self.host, self.port); [INFO] [stdout] 61 + format!("{}:{}", self.host, self.port) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return self.routers[idx].as_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return self.routers[idx].as_mut(); [INFO] [stdout] 78 + self.routers[idx].as_mut() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return self; [INFO] [stdout] 84 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return self; [INFO] [stdout] 90 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return self; [INFO] [stdout] 96 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return self; [INFO] [stdout] 103 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return self; [INFO] [stdout] 109 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.assets` after checking its variant with `is_some` [INFO] [stdout] --> src/server/mod.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 151 | if self.assets.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &mut self.assets` [INFO] [stdout] 152 | self.assets.as_mut().unwrap().handle(req, res).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/server/mod.rs:155:16 [INFO] [stdout] | [INFO] [stdout] 155 | return Ok(handler.teardown(req, res).await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 155 ~ return { [INFO] [stdout] 156 + let _: () = handler.teardown(req, res).await.unwrap(); [INFO] [stdout] 157 + Ok(()) [INFO] [stdout] 158 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | return self.routes.handle_ws_request(req, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - return self.routes.handle_ws_request(req, res); [INFO] [stdout] 161 + self.routes.handle_ws_request(req, res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/url.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return uri.trim_start_matches("/") [INFO] [stdout] 13 | | .trim_end_matches("/") [INFO] [stdout] 14 | | .to_string(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ uri.trim_start_matches("/") [INFO] [stdout] 13 + .trim_end_matches("/") [INFO] [stdout] 14 ~ .to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/url.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return clean_url(uri).split("/").map(|x| x.to_string()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return clean_url(uri).split("/").map(|x| x.to_string()).collect(); [INFO] [stdout] 18 + clean_url(uri).split("/").map(|x| x.to_string()).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.assets` after checking its variant with `is_some` [INFO] [stdout] --> src/server/mod.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 151 | if self.assets.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &mut self.assets` [INFO] [stdout] 152 | self.assets.as_mut().unwrap().handle(req, res).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/url.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return merge(vec![vec![one], vec![two]]).iter() [INFO] [stdout] 44 | | .map(|x| clean_url(x.to_owned())) [INFO] [stdout] 45 | | .filter(|x| x != "") [INFO] [stdout] 46 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ merge(vec![vec![one], vec![two]]).iter() [INFO] [stdout] 44 + .map(|x| clean_url(x.to_owned())) [INFO] [stdout] 45 + .filter(|x| x != "") [INFO] [stdout] 46 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/server/mod.rs:155:16 [INFO] [stdout] | [INFO] [stdout] 155 | return Ok(handler.teardown(req, res).await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 155 ~ return { [INFO] [stdout] 156 + let _: () = handler.teardown(req, res).await.unwrap(); [INFO] [stdout] 157 + Ok(()) [INFO] [stdout] 158 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/utils/url.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 45 | .filter(|x| x != "") [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | return self.routes.handle_ws_request(req, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - return self.routes.handle_ws_request(req, res); [INFO] [stdout] 161 + self.routes.handle_ws_request(req, res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/url.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | / return url.iter() [INFO] [stdout] 51 | | .map(|u| String::from(u.trim_matches('/'))).collect::>() [INFO] [stdout] 52 | | .join("/") [INFO] [stdout] 53 | | .trim_matches('/') [INFO] [stdout] 54 | | .to_string(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 ~ url.iter() [INFO] [stdout] 51 + .map(|u| String::from(u.trim_matches('/'))).collect::>() [INFO] [stdout] 52 + .join("/") [INFO] [stdout] 53 + .trim_matches('/') [INFO] [stdout] 54 ~ .to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/string.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | return input.chars().take(length).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return input.chars().take(length).collect() [INFO] [stdout] 6 + input.chars().take(length).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/url.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return uri.trim_start_matches("/") [INFO] [stdout] 13 | | .trim_end_matches("/") [INFO] [stdout] 14 | | .to_string(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ uri.trim_start_matches("/") [INFO] [stdout] 13 + .trim_end_matches("/") [INFO] [stdout] 14 ~ .to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/url.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return clean_url(uri).split("/").map(|x| x.to_string()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return clean_url(uri).split("/").map(|x| x.to_string()).collect(); [INFO] [stdout] 18 + clean_url(uri).split("/").map(|x| x.to_string()).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/encrypt.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return Ok(buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Ok(buffer); [INFO] [stdout] 25 + Ok(buffer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/encrypt.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(String::from_utf8(plaintext).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Ok(String::from_utf8(plaintext).unwrap()); [INFO] [stdout] 42 + Ok(String::from_utf8(plaintext).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/url.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return merge(vec![vec![one], vec![two]]).iter() [INFO] [stdout] 44 | | .map(|x| clean_url(x.to_owned())) [INFO] [stdout] 45 | | .filter(|x| x != "") [INFO] [stdout] 46 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ merge(vec![vec![one], vec![two]]).iter() [INFO] [stdout] 44 + .map(|x| clean_url(x.to_owned())) [INFO] [stdout] 45 + .filter(|x| x != "") [INFO] [stdout] 46 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/utils/url.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 45 | .filter(|x| x != "") [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/utils/cookie.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn cookie_parse<'a>(raw_cookie: String) -> Result { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/url.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | / return url.iter() [INFO] [stdout] 51 | | .map(|u| String::from(u.trim_matches('/'))).collect::>() [INFO] [stdout] 52 | | .join("/") [INFO] [stdout] 53 | | .trim_matches('/') [INFO] [stdout] 54 | | .to_string(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 ~ url.iter() [INFO] [stdout] 51 + .map(|u| String::from(u.trim_matches('/'))).collect::>() [INFO] [stdout] 52 + .join("/") [INFO] [stdout] 53 + .trim_matches('/') [INFO] [stdout] 54 ~ .to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/string.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | return input.chars().take(length).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return input.chars().take(length).collect() [INFO] [stdout] 6 + input.chars().take(length).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/encrypt.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return Ok(buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Ok(buffer); [INFO] [stdout] 25 + Ok(buffer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/encrypt.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(String::from_utf8(plaintext).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Ok(String::from_utf8(plaintext).unwrap()); [INFO] [stdout] 42 + Ok(String::from_utf8(plaintext).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/cookie.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return Ok(values); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return Ok(values); [INFO] [stdout] 16 + Ok(values) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils/logger.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | GLOBAL_LOGGER.get_or_init(|| init()) [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with the function itself: `init` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return Self { [INFO] [stdout] 29 | | key_path: String::from(key_path), [INFO] [stdout] 30 | | cert_path: String::from(cert_path) [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Self { [INFO] [stdout] 29 + key_path: String::from(key_path), [INFO] [stdout] 30 + cert_path: String::from(cert_path) [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / return Self { [INFO] [stdout] 38 | | key: key, [INFO] [stdout] 39 | | cert: cert [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ Self { [INFO] [stdout] 38 + key: key, [INFO] [stdout] 39 + cert: cert [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/utils/cookie.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn cookie_parse<'a>(raw_cookie: String) -> Result { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return Ok(TlsConfig::new(key, cert)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Ok(TlsConfig::new(key, cert)) [INFO] [stdout] 55 + Ok(TlsConfig::new(key, cert)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / return Ok( [INFO] [stdout] 60 | | rustls::ServerConfig::builder() [INFO] [stdout] 61 | | .with_no_client_auth() [INFO] [stdout] 62 | | .with_single_cert(config.cert, config.key) [INFO] [stdout] 63 | | .unwrap() [INFO] [stdout] 64 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ Ok( [INFO] [stdout] 60 + rustls::ServerConfig::builder() [INFO] [stdout] 61 + .with_no_client_auth() [INFO] [stdout] 62 + .with_single_cert(config.cert, config.key) [INFO] [stdout] 63 + .unwrap() [INFO] [stdout] 64 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | return Some(TlsAcceptor::from(Arc::new(config))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Some(TlsAcceptor::from(Arc::new(config))); [INFO] [stdout] 68 + Some(TlsAcceptor::from(Arc::new(config))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return merged [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return merged [INFO] [stdout] 23 + merged [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/cookie.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return Ok(values); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return Ok(values); [INFO] [stdout] 16 + Ok(values) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return Ok( [INFO] [stdout] 28 | | SystemTime::now() [INFO] [stdout] 29 | | .duration_since(UNIX_EPOCH) [INFO] [stdout] 30 | | .unwrap() [INFO] [stdout] 31 | | .as_millis() [INFO] [stdout] 32 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ Ok( [INFO] [stdout] 28 + SystemTime::now() [INFO] [stdout] 29 + .duration_since(UNIX_EPOCH) [INFO] [stdout] 30 + .unwrap() [INFO] [stdout] 31 + .as_millis() [INFO] [stdout] 32 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return var.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return var.unwrap(); [INFO] [stdout] 46 + var.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils/logger.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | GLOBAL_LOGGER.get_or_init(|| init()) [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with the function itself: `init` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return Self { [INFO] [stdout] 29 | | key_path: String::from(key_path), [INFO] [stdout] 30 | | cert_path: String::from(cert_path) [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Self { [INFO] [stdout] 29 + key_path: String::from(key_path), [INFO] [stdout] 30 + cert_path: String::from(cert_path) [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return Self { [INFO] [stdout] 30 | | name: name.to_string(), [INFO] [stdout] 31 | | value: value.to_string(), [INFO] [stdout] 32 | | expires: None, [INFO] [stdout] ... | [INFO] [stdout] 37 | | http_only: None, [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Self { [INFO] [stdout] 30 + name: name.to_string(), [INFO] [stdout] 31 + value: value.to_string(), [INFO] [stdout] 32 + expires: None, [INFO] [stdout] 33 + max_age: None, [INFO] [stdout] 34 + domain: None, [INFO] [stdout] 35 + path: None, [INFO] [stdout] 36 + secure: None, [INFO] [stdout] 37 + http_only: None, [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return self; [INFO] [stdout] 44 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / return Self { [INFO] [stdout] 38 | | key: key, [INFO] [stdout] 39 | | cert: cert [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ Self { [INFO] [stdout] 38 + key: key, [INFO] [stdout] 39 + cert: cert [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return Ok(TlsConfig::new(key, cert)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Ok(TlsConfig::new(key, cert)) [INFO] [stdout] 55 + Ok(TlsConfig::new(key, cert)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / return Ok( [INFO] [stdout] 60 | | rustls::ServerConfig::builder() [INFO] [stdout] 61 | | .with_no_client_auth() [INFO] [stdout] 62 | | .with_single_cert(config.cert, config.key) [INFO] [stdout] 63 | | .unwrap() [INFO] [stdout] 64 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ Ok( [INFO] [stdout] 60 + rustls::ServerConfig::builder() [INFO] [stdout] 61 + .with_no_client_auth() [INFO] [stdout] 62 + .with_single_cert(config.cert, config.key) [INFO] [stdout] 63 + .unwrap() [INFO] [stdout] 64 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/server.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | return Some(TlsAcceptor::from(Arc::new(config))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Some(TlsAcceptor::from(Arc::new(config))); [INFO] [stdout] 68 + Some(TlsAcceptor::from(Arc::new(config))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return self; [INFO] [stdout] 50 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return self; [INFO] [stdout] 56 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self; [INFO] [stdout] 62 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return self; [INFO] [stdout] 68 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return self; [INFO] [stdout] 74 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return merged [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return merged [INFO] [stdout] 23 + merged [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return Ok( [INFO] [stdout] 28 | | SystemTime::now() [INFO] [stdout] 29 | | .duration_since(UNIX_EPOCH) [INFO] [stdout] 30 | | .unwrap() [INFO] [stdout] 31 | | .as_millis() [INFO] [stdout] 32 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ Ok( [INFO] [stdout] 28 + SystemTime::now() [INFO] [stdout] 29 + .duration_since(UNIX_EPOCH) [INFO] [stdout] 30 + .unwrap() [INFO] [stdout] 31 + .as_millis() [INFO] [stdout] 32 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return self; [INFO] [stdout] 80 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return self; [INFO] [stdout] 86 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.expires` after checking its variant with `is_some` [INFO] [stdout] --> src/cookie/mod.rs:93:84 [INFO] [stdout] | [INFO] [stdout] 92 | ... if self.expires.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = self.expires` [INFO] [stdout] 93 | ... cookie.set_expires(OffsetDateTime::now_utc() + CookieDuration::seconds(self.expires.unwrap().as_secs().try_into().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.max_age` after checking its variant with `is_some` [INFO] [stdout] --> src/cookie/mod.rs:97:52 [INFO] [stdout] | [INFO] [stdout] 96 | if self.max_age.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = self.max_age` [INFO] [stdout] 97 | cookie.set_max_age(CookieDuration::new(self.max_age.unwrap().as_secs().try_into().unwrap(), 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.domain` after checking its variant with `is_some` [INFO] [stdout] --> src/cookie/mod.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 100 | if self.domain.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.domain` [INFO] [stdout] 101 | cookie.set_domain(self.domain.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.domain` after checking its variant with `is_some` [INFO] [stdout] --> src/cookie/mod.rs:105:31 [INFO] [stdout] | [INFO] [stdout] 104 | if self.domain.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.domain` [INFO] [stdout] 105 | cookie.set_domain(self.domain.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return cookie.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return cookie.to_string(); [INFO] [stdout] 116 + cookie.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return var.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return var.unwrap(); [INFO] [stdout] 46 + var.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return Self { [INFO] [stdout] 30 | | name: name.to_string(), [INFO] [stdout] 31 | | value: value.to_string(), [INFO] [stdout] 32 | | expires: None, [INFO] [stdout] ... | [INFO] [stdout] 37 | | http_only: None, [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Self { [INFO] [stdout] 30 + name: name.to_string(), [INFO] [stdout] 31 + value: value.to_string(), [INFO] [stdout] 32 + expires: None, [INFO] [stdout] 33 + max_age: None, [INFO] [stdout] 34 + domain: None, [INFO] [stdout] 35 + path: None, [INFO] [stdout] 36 + secure: None, [INFO] [stdout] 37 + http_only: None, [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | / return Self { [INFO] [stdout] 123 | | cookies: cookies, [INFO] [stdout] 124 | | new_cookie: vec![], [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 ~ Self { [INFO] [stdout] 123 + cookies: cookies, [INFO] [stdout] 124 + new_cookie: vec![], [INFO] [stdout] 125 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return self; [INFO] [stdout] 44 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return cookie.unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return cookie.unwrap().to_owned(); [INFO] [stdout] 135 + cookie.unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return self; [INFO] [stdout] 50 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return self; [INFO] [stdout] 56 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return &mut self.new_cookie[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return &mut self.new_cookie[idx]; [INFO] [stdout] 143 + &mut self.new_cookie[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self; [INFO] [stdout] 62 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return self; [INFO] [stdout] 68 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return self; [INFO] [stdout] 74 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return self; [INFO] [stdout] 80 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return self; [INFO] [stdout] 86 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.expires` after checking its variant with `is_some` [INFO] [stdout] --> src/cookie/mod.rs:93:84 [INFO] [stdout] | [INFO] [stdout] 92 | ... if self.expires.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = self.expires` [INFO] [stdout] 93 | ... cookie.set_expires(OffsetDateTime::now_utc() + CookieDuration::seconds(self.expires.unwrap().as_secs().try_into().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.max_age` after checking its variant with `is_some` [INFO] [stdout] --> src/cookie/mod.rs:97:52 [INFO] [stdout] | [INFO] [stdout] 96 | if self.max_age.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = self.max_age` [INFO] [stdout] 97 | cookie.set_max_age(CookieDuration::new(self.max_age.unwrap().as_secs().try_into().unwrap(), 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.domain` after checking its variant with `is_some` [INFO] [stdout] --> src/cookie/mod.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 100 | if self.domain.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.domain` [INFO] [stdout] 101 | cookie.set_domain(self.domain.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.domain` after checking its variant with `is_some` [INFO] [stdout] --> src/cookie/mod.rs:105:31 [INFO] [stdout] | [INFO] [stdout] 104 | if self.domain.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.domain` [INFO] [stdout] 105 | cookie.set_domain(self.domain.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return cookie.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return cookie.to_string(); [INFO] [stdout] 116 + cookie.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | / return Self { [INFO] [stdout] 123 | | cookies: cookies, [INFO] [stdout] 124 | | new_cookie: vec![], [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 ~ Self { [INFO] [stdout] 123 + cookies: cookies, [INFO] [stdout] 124 + new_cookie: vec![], [INFO] [stdout] 125 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return cookie.unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return cookie.unwrap().to_owned(); [INFO] [stdout] 135 + cookie.unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cookie/mod.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return &mut self.new_cookie[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return &mut self.new_cookie[idx]; [INFO] [stdout] 143 + &mut self.new_cookie[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / return SessionCookie { [INFO] [stdout] 43 | | values: values, [INFO] [stdout] 44 | | errors: errors, [INFO] [stdout] 45 | | old: old, [INFO] [stdout] 46 | | new_old: Values::new(), [INFO] [stdout] 47 | | new_errors: Values::new(), [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ SessionCookie { [INFO] [stdout] 43 + values: values, [INFO] [stdout] 44 + errors: errors, [INFO] [stdout] 45 + old: old, [INFO] [stdout] 46 + new_old: Values::new(), [INFO] [stdout] 47 + new_errors: Values::new(), [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / return SessionCookieManager { [INFO] [stdout] 53 | | expires: expires, [INFO] [stdout] 54 | | cookie_name: cookie_name.to_owned(), [INFO] [stdout] 55 | | encryption_key: string_fixed_length(encryption_key, 32), [INFO] [stdout] 56 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ SessionCookieManager { [INFO] [stdout] 53 + expires: expires, [INFO] [stdout] 54 + cookie_name: cookie_name.to_owned(), [INFO] [stdout] 55 + encryption_key: string_fixed_length(encryption_key, 32), [INFO] [stdout] 56 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return Ok(new_session_cookie(storage.values, storage.errors, storage.old)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Ok(new_session_cookie(storage.values, storage.errors, storage.old)); [INFO] [stdout] 78 + Ok(new_session_cookie(storage.values, storage.errors, storage.old)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Ok(()) [INFO] [stdout] 87 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 ~ Ok(()) [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | return self.values.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return self.values.clone(); [INFO] [stdout] 124 + self.values.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return value.unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return value.unwrap().to_owned(); [INFO] [stdout] 144 + value.unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return self.errors.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return self.errors.clone(); [INFO] [stdout] 152 + self.errors.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / return SessionCookie { [INFO] [stdout] 43 | | values: values, [INFO] [stdout] 44 | | errors: errors, [INFO] [stdout] 45 | | old: old, [INFO] [stdout] 46 | | new_old: Values::new(), [INFO] [stdout] 47 | | new_errors: Values::new(), [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ SessionCookie { [INFO] [stdout] 43 + values: values, [INFO] [stdout] 44 + errors: errors, [INFO] [stdout] 45 + old: old, [INFO] [stdout] 46 + new_old: Values::new(), [INFO] [stdout] 47 + new_errors: Values::new(), [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | return error.unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return error.unwrap().to_owned(); [INFO] [stdout] 172 + error.unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / return SessionCookieManager { [INFO] [stdout] 53 | | expires: expires, [INFO] [stdout] 54 | | cookie_name: cookie_name.to_owned(), [INFO] [stdout] 55 | | encryption_key: string_fixed_length(encryption_key, 32), [INFO] [stdout] 56 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ SessionCookieManager { [INFO] [stdout] 53 + expires: expires, [INFO] [stdout] 54 + cookie_name: cookie_name.to_owned(), [INFO] [stdout] 55 + encryption_key: string_fixed_length(encryption_key, 32), [INFO] [stdout] 56 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return Ok(new_session_cookie(storage.values, storage.errors, storage.old)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Ok(new_session_cookie(storage.values, storage.errors, storage.old)); [INFO] [stdout] 78 + Ok(new_session_cookie(storage.values, storage.errors, storage.old)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | return self.old.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return self.old.clone(); [INFO] [stdout] 186 + self.old.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | return self.old.get(key).or(Some(&String::new())).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return self.old.get(key).or(Some(&String::new())).unwrap().to_string(); [INFO] [stdout] 190 + self.old.get(key).or(Some(&String::new())).unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Some(…)).unwrap()` [INFO] [stdout] --> src/session/cookie.rs:190:34 [INFO] [stdout] | [INFO] [stdout] 190 | return self.old.get(key).or(Some(&String::new())).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(&String::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Ok(()) [INFO] [stdout] 87 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/functions.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / return Self { [INFO] [stdout] 19 | | render: render, [INFO] [stdout] 20 | | req: req, [INFO] [stdout] 21 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Self { [INFO] [stdout] 19 + render: render, [INFO] [stdout] 20 + req: req, [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 ~ Ok(()) [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:26:80 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] 26 | self.render.register_function("session", SessionFunctions::session(self.req.session.as_mut().unwrap().values())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:27:88 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] 26 | self.render.register_function("session", SessionFunctions::session(self.req.session.as_mut().unwrap().values())); [INFO] [stdout] 27 | self.render.register_function("session_has", SessionFunctions::session_has(self.req.session.as_mut().unwrap().values())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:28:84 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] ... [INFO] [stdout] 28 | self.render.register_function("error_has", SessionFunctions::error_has(self.req.session.as_mut().unwrap().errors())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | return self.values.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return self.values.clone(); [INFO] [stdout] 124 + self.values.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:29:76 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] ... [INFO] [stdout] 29 | self.render.register_function("error", SessionFunctions::error(self.req.session.as_mut().unwrap().errors())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:30:72 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] ... [INFO] [stdout] 30 | self.render.register_function("old", SessionFunctions::old(self.req.session.as_mut().unwrap().old_values())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/functions.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return Ok(rendered); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Ok(rendered); [INFO] [stdout] 44 + Ok(rendered) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return value.unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return value.unwrap().to_owned(); [INFO] [stdout] 144 + value.unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/view/functions.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 40 | .render(&format!("{}", bag.view), &bag.data.as_mut().unwrap().context) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `bag.view.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return self.errors.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return self.errors.clone(); [INFO] [stdout] 152 + self.errors.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 12 | | let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 13 | | [INFO] [stdout] 14 | | if session.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 18 | | return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 12 + let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 13 + [INFO] [stdout] 14 + if session.is_none() { [INFO] [stdout] 15 + return Ok(to_value("").unwrap()); [INFO] [stdout] 16 + } [INFO] [stdout] 17 + [INFO] [stdout] 18 + return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 18 + Ok(to_value(session.unwrap()).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | return error.unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return error.unwrap().to_owned(); [INFO] [stdout] 172 + error.unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 24 | | let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 25 | | [INFO] [stdout] 26 | | if session.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 30 | | return Ok(to_value(false).unwrap()); [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 24 + let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 25 + [INFO] [stdout] 26 + if session.is_none() { [INFO] [stdout] 27 + return Ok(to_value(true).unwrap()); [INFO] [stdout] 28 + } [INFO] [stdout] 29 + [INFO] [stdout] 30 + return Ok(to_value(false).unwrap()); [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | return self.old.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return self.old.clone(); [INFO] [stdout] 186 + self.old.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | return Ok(to_value(false).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(to_value(false).unwrap()); [INFO] [stdout] 30 + Ok(to_value(false).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/session/cookie.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | return self.old.get(key).or(Some(&String::new())).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return self.old.get(key).or(Some(&String::new())).unwrap().to_string(); [INFO] [stdout] 190 + self.old.get(key).or(Some(&String::new())).unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Some(…)).unwrap()` [INFO] [stdout] --> src/session/cookie.rs:190:34 [INFO] [stdout] | [INFO] [stdout] 190 | return self.old.get(key).or(Some(&String::new())).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(&String::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 36 | | let error = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 37 | | let class = args.get("class"); [INFO] [stdout] ... | [INFO] [stdout] 51 | | return Ok(to_value(class.unwrap())?); [INFO] [stdout] 52 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 36 + let error = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 37 + let class = args.get("class"); [INFO] [stdout] 38 + [INFO] [stdout] 39 + if error.is_none() && class.is_none() { [INFO] [stdout] 40 + return Ok(to_value(false).unwrap()); [INFO] [stdout] 41 + } [INFO] [stdout] 42 + [INFO] [stdout] 43 + if error.is_some() && class.is_none() { [INFO] [stdout] 44 + return Ok(to_value(true).unwrap()); [INFO] [stdout] 45 + } [INFO] [stdout] 46 + [INFO] [stdout] 47 + if error.is_none() { [INFO] [stdout] 48 + return Ok(to_value("").unwrap()); [INFO] [stdout] 49 + } [INFO] [stdout] 50 + [INFO] [stdout] 51 + return Ok(to_value(class.unwrap())?); [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | return Ok(to_value(class.unwrap())?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Ok(to_value(class.unwrap())?); [INFO] [stdout] 51 + Ok(to_value(class.unwrap())?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/functions.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / return Self { [INFO] [stdout] 19 | | render: render, [INFO] [stdout] 20 | | req: req, [INFO] [stdout] 21 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Self { [INFO] [stdout] 19 + render: render, [INFO] [stdout] 20 + req: req, [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:26:80 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] 26 | self.render.register_function("session", SessionFunctions::session(self.req.session.as_mut().unwrap().values())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:27:88 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] 26 | self.render.register_function("session", SessionFunctions::session(self.req.session.as_mut().unwrap().values())); [INFO] [stdout] 27 | self.render.register_function("session_has", SessionFunctions::session_has(self.req.session.as_mut().unwrap().values())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 57 | | let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 58 | | [INFO] [stdout] 59 | | if session.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 63 | | return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 57 + let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 58 + [INFO] [stdout] 59 + if session.is_none() { [INFO] [stdout] 60 + return Ok(to_value("").unwrap()); [INFO] [stdout] 61 + } [INFO] [stdout] 62 + [INFO] [stdout] 63 + return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 63 + Ok(to_value(session.unwrap()).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:28:84 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] ... [INFO] [stdout] 28 | self.render.register_function("error_has", SessionFunctions::error_has(self.req.session.as_mut().unwrap().errors())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:29:76 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] ... [INFO] [stdout] 29 | self.render.register_function("error", SessionFunctions::error(self.req.session.as_mut().unwrap().errors())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 69 | | return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] 70 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 69 + return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.req.session` after checking its variant with `is_some` [INFO] [stdout] --> src/view/functions.rs:30:72 [INFO] [stdout] | [INFO] [stdout] 25 | if self.req.session.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.req.session` [INFO] [stdout] ... [INFO] [stdout] 30 | self.render.register_function("old", SessionFunctions::old(self.req.session.as_mut().unwrap().old_values())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] 69 + Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Some(…)).unwrap()` [INFO] [stdout] --> src/view/session_functions.rs:69:88 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(&String::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/functions.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return Ok(rendered); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Ok(rendered); [INFO] [stdout] 44 + Ok(rendered) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/view/functions.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 40 | .render(&format!("{}", bag.view), &bag.data.as_mut().unwrap().context) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `bag.view.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 75 | | return Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()); [INFO] [stdout] 76 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 75 + return Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()); [INFO] [stdout] 75 + Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 12 | | let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 13 | | [INFO] [stdout] 14 | | if session.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 18 | | return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 12 + let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 13 + [INFO] [stdout] 14 + if session.is_none() { [INFO] [stdout] 15 + return Ok(to_value("").unwrap()); [INFO] [stdout] 16 + } [INFO] [stdout] 17 + [INFO] [stdout] 18 + return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 81 | | let mut path = String::new(); [INFO] [stdout] 82 | | [INFO] [stdout] 83 | | if let Some(p) = args.get("path") { [INFO] [stdout] ... | [INFO] [stdout] 87 | | return Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()); [INFO] [stdout] 88 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 81 + let mut path = String::new(); [INFO] [stdout] 82 + [INFO] [stdout] 83 + if let Some(p) = args.get("path") { [INFO] [stdout] 84 + path = p.as_str().unwrap().trim_start_matches("/").trim_end_matches("/").to_owned(); [INFO] [stdout] 85 + } [INFO] [stdout] 86 + [INFO] [stdout] 87 + return Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()); [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 18 + Ok(to_value(session.unwrap()).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()); [INFO] [stdout] 87 + Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 24 | | let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 25 | | [INFO] [stdout] 26 | | if session.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 30 | | return Ok(to_value(false).unwrap()); [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 24 + let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 25 + [INFO] [stdout] 26 + if session.is_none() { [INFO] [stdout] 27 + return Ok(to_value(true).unwrap()); [INFO] [stdout] 28 + } [INFO] [stdout] 29 + [INFO] [stdout] 30 + return Ok(to_value(false).unwrap()); [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | return Ok(to_value(false).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(to_value(false).unwrap()); [INFO] [stdout] 30 + Ok(to_value(false).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 36 | | let error = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 37 | | let class = args.get("class"); [INFO] [stdout] ... | [INFO] [stdout] 51 | | return Ok(to_value(class.unwrap())?); [INFO] [stdout] 52 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 36 + let error = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 37 + let class = args.get("class"); [INFO] [stdout] 38 + [INFO] [stdout] 39 + if error.is_none() && class.is_none() { [INFO] [stdout] 40 + return Ok(to_value(false).unwrap()); [INFO] [stdout] 41 + } [INFO] [stdout] 42 + [INFO] [stdout] 43 + if error.is_some() && class.is_none() { [INFO] [stdout] 44 + return Ok(to_value(true).unwrap()); [INFO] [stdout] 45 + } [INFO] [stdout] 46 + [INFO] [stdout] 47 + if error.is_none() { [INFO] [stdout] 48 + return Ok(to_value("").unwrap()); [INFO] [stdout] 49 + } [INFO] [stdout] 50 + [INFO] [stdout] 51 + return Ok(to_value(class.unwrap())?); [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/mod.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return ViewData{ [INFO] [stdout] 31 | | context: Context::new() [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ ViewData{ [INFO] [stdout] 31 + context: Context::new() [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/mod.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / return Self { [INFO] [stdout] 38 | | render: Tera::new(&format!("{}/**/*", path.trim_end_matches("/"))).unwrap() [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ Self { [INFO] [stdout] 38 + render: Tera::new(&format!("{}/**/*", path.trim_end_matches("/"))).unwrap() [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | return Ok(to_value(class.unwrap())?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Ok(to_value(class.unwrap())?); [INFO] [stdout] 51 + Ok(to_value(class.unwrap())?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/mod.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Ok(()); [INFO] [stdout] 55 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return temp.join(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return temp.join(" "); [INFO] [stdout] 5 + temp.join(" ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 57 | | let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 58 | | [INFO] [stdout] 59 | | if session.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 63 | | return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 57 + let session = values.get(args.get("name").unwrap().as_str().unwrap()); [INFO] [stdout] 58 + [INFO] [stdout] 59 + if session.is_none() { [INFO] [stdout] 60 + return Ok(to_value("").unwrap()); [INFO] [stdout] 61 + } [INFO] [stdout] 62 + [INFO] [stdout] 63 + return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return Some(format!("The {} is required", pretty(field))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Some(format!("The {} is required", pretty(field))) [INFO] [stdout] 17 + Some(format!("The {} is required", pretty(field))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(to_value(session.unwrap()).unwrap()); [INFO] [stdout] 63 + Ok(to_value(session.unwrap()).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | if form.files.get(field.as_str()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | if form.values.get(field.as_str()).is_some() && form.values.get(field.as_str()).unwrap() != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 69 | | return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] 70 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 69 + return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] 69 + Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return None [INFO] [stdout] 25 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found `.or(Some(…)).unwrap()` [INFO] [stdout] --> src/view/session_functions.rs:69:88 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(to_value(values.get(args.get("name").unwrap().as_str().unwrap()).or(Some(&String::new())).unwrap()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or(&String::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_then_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_none()` [INFO] [stdout] --> src/validation/rules.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 21 | if form.values.get(field.as_str()).is_none() { [INFO] [stdout] | ------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.values.contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])); [INFO] [stdout] 41 + Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | if form.files.get(field.as_str()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | if form.values.get(field.as_str()).is_some() && form.values.get(field.as_str()).unwrap().len() >= args[0].parse().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | return Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])); [INFO] [stdout] 57 + Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 45 | if form.files.get(field.as_str()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 53 | if form.values.get(field.as_str()).is_some() && form.values.get(field.as_str()).unwrap().len() <= args[0].parse().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return Some(format!("The {} does not match {} confirmation", pretty(field.clone()), pretty(field))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Some(format!("The {} does not match {} confirmation", pretty(field.clone()), pretty(field))); [INFO] [stdout] 65 + Some(format!("The {} does not match {} confirmation", pretty(field.clone()), pretty(field))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return None [INFO] [stdout] 73 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 75 | | return Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()); [INFO] [stdout] 76 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 75 + return Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_none()` [INFO] [stdout] --> src/validation/rules.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | if form.files.get(field.as_str()).is_none() { [INFO] [stdout] | -----------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.files.contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return Self { [INFO] [stdout] 33 | | name: field.to_string(), [INFO] [stdout] 34 | | rules: Vec::new() [INFO] [stdout] 35 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Self { [INFO] [stdout] 33 + name: field.to_string(), [INFO] [stdout] 34 + rules: Vec::new() [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return self; [INFO] [stdout] 47 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/validation/mod.rs:51:6 [INFO] [stdout] | [INFO] [stdout] 51 | impl<'a> Rules { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Rules` [INFO] [stdout] --> src/validation/mod.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / pub fn new() -> Rules { [INFO] [stdout] 53 | | return Self { [INFO] [stdout] 54 | | fields: Vec::new(), [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 51 + impl<'a> Default for Rules { [INFO] [stdout] 52 + fn default() -> Self { [INFO] [stdout] 53 + Self::new() [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()); [INFO] [stdout] 75 + Ok(to_value(env(&args.get("name").unwrap().to_string())).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / return Self { [INFO] [stdout] 54 | | fields: Vec::new(), [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 ~ Self { [INFO] [stdout] 54 + fields: Vec::new(), [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return &mut self.fields[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return &mut self.fields[idx]; [INFO] [stdout] 63 + &mut self.fields[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | / return move |args: &HashMap| -> tera::Result { [INFO] [stdout] 81 | | let mut path = String::new(); [INFO] [stdout] 82 | | [INFO] [stdout] 83 | | if let Some(p) = args.get("path") { [INFO] [stdout] ... | [INFO] [stdout] 87 | | return Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()); [INFO] [stdout] 88 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 ~ move |args: &HashMap| -> tera::Result { [INFO] [stdout] 81 + let mut path = String::new(); [INFO] [stdout] 82 + [INFO] [stdout] 83 + if let Some(p) = args.get("path") { [INFO] [stdout] 84 + path = p.as_str().unwrap().trim_start_matches("/").trim_end_matches("/").to_owned(); [INFO] [stdout] 85 + } [INFO] [stdout] 86 + [INFO] [stdout] 87 + return Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()); [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return Self { [INFO] [stdout] 70 | | form: form, [INFO] [stdout] 71 | | rules: rules, [INFO] [stdout] 72 | | errors: Values::new(), [INFO] [stdout] 73 | | validated: Form::new(Values::new(), Files::new()) [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ Self { [INFO] [stdout] 70 + form: form, [INFO] [stdout] 71 + rules: rules, [INFO] [stdout] 72 + errors: Values::new(), [INFO] [stdout] 73 + validated: Form::new(Values::new(), Files::new()) [INFO] [stdout] 74 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/session_functions.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()); [INFO] [stdout] 87 + Ok(to_value(format!("{}/{}", env("APP_URL").trim_end_matches("/"), path)).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return self.errors.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return self.errors.len() == 0; [INFO] [stdout] 84 + self.errors.len() == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/mod.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / return ViewData{ [INFO] [stdout] 31 | | context: Context::new() [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ ViewData{ [INFO] [stdout] 31 + context: Context::new() [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/mod.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / return Self { [INFO] [stdout] 38 | | render: Tera::new(&format!("{}/**/*", path.trim_end_matches("/"))).unwrap() [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ Self { [INFO] [stdout] 38 + render: Tera::new(&format!("{}/**/*", path.trim_end_matches("/"))).unwrap() [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view/mod.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Ok(()); [INFO] [stdout] 55 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return temp.join(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return temp.join(" "); [INFO] [stdout] 5 + temp.join(" ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return Some(format!("The {} is required", pretty(field))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Some(format!("The {} is required", pretty(field))) [INFO] [stdout] 17 + Some(format!("The {} is required", pretty(field))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | if form.files.get(field.as_str()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | if form.values.get(field.as_str()).is_some() && form.values.get(field.as_str()).unwrap() != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return None [INFO] [stdout] 25 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_none()` [INFO] [stdout] --> src/validation/rules.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 21 | if form.values.get(field.as_str()).is_none() { [INFO] [stdout] | ------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.values.contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])); [INFO] [stdout] 41 + Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | if form.files.get(field.as_str()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | if form.values.get(field.as_str()).is_some() && form.values.get(field.as_str()).unwrap().len() >= args[0].parse().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | return Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])); [INFO] [stdout] 57 + Some(format!("The {} must have minimum of {} characters", pretty(field), args[0])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/validation/mod.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | return self.errors.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.errors.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return next.handle(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return next.handle(res); [INFO] [stdout] 96 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return Values::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return Values::new(); [INFO] [stdout] 100 + Values::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return None [INFO] [stdout] 110 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assets/mod.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return Self { [INFO] [stdout] 33 | | path: path.trim_end_matches("/").to_owned(), [INFO] [stdout] 34 | | max_size: max_size_kilobytes_cache_size * 1000, [INFO] [stdout] 35 | | expires: expires_in_seconds, [INFO] [stdout] 36 | | cache: Cache::new(), [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Self { [INFO] [stdout] 33 + path: path.trim_end_matches("/").to_owned(), [INFO] [stdout] 34 + max_size: max_size_kilobytes_cache_size * 1000, [INFO] [stdout] 35 + expires: expires_in_seconds, [INFO] [stdout] 36 + cache: Cache::new(), [INFO] [stdout] 37 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 45 | if form.files.get(field.as_str()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_some()` [INFO] [stdout] --> src/validation/rules.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 53 | if form.values.get(field.as_str()).is_some() && form.values.get(field.as_str()).unwrap().len() <= args[0].parse().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return Some(format!("The {} does not match {} confirmation", pretty(field.clone()), pretty(field))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Some(format!("The {} does not match {} confirmation", pretty(field.clone()), pretty(field))); [INFO] [stdout] 65 + Some(format!("The {} does not match {} confirmation", pretty(field.clone()), pretty(field))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assets/mod.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | if !cached_asset.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cached_asset.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cached_asset` after checking its variant with `is_some` [INFO] [stdout] --> src/assets/mod.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 44 | if cached_asset.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = cached_asset` [INFO] [stdout] 45 | let asset = cached_asset.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assets/mod.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Ok(()); [INFO] [stdout] 72 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/rules.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return None [INFO] [stdout] 73 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(field.as_str()).is_none()` [INFO] [stdout] --> src/validation/rules.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | if form.files.get(field.as_str()).is_none() { [INFO] [stdout] | -----------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.files.contains_key(field.as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return Self { [INFO] [stdout] 33 | | name: field.to_string(), [INFO] [stdout] 34 | | rules: Vec::new() [INFO] [stdout] 35 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Self { [INFO] [stdout] 33 + name: field.to_string(), [INFO] [stdout] 34 + rules: Vec::new() [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return self; [INFO] [stdout] 47 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/assets/mod.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | if asset.size > self.max_size.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assets/mod.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if !file.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `file.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assets/mod.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | if !reading.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `reading.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assets/mod.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(Some(asset)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Ok(Some(asset)) [INFO] [stdout] 98 + Ok(Some(asset)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/validation/mod.rs:51:6 [INFO] [stdout] | [INFO] [stdout] 51 | impl<'a> Rules { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Rules` [INFO] [stdout] --> src/validation/mod.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / pub fn new() -> Rules { [INFO] [stdout] 53 | | return Self { [INFO] [stdout] 54 | | fields: Vec::new(), [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 51 + impl<'a> Default for Rules { [INFO] [stdout] 52 + fn default() -> Self { [INFO] [stdout] 53 + Self::new() [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / return unsafe { [INFO] [stdout] 25 | | let server = Server::new(host, port, None); [INFO] [stdout] 26 | | [INFO] [stdout] 27 | | GLOBAL_SERVER [INFO] [stdout] ... | [INFO] [stdout] 32 | | GLOBAL_SERVER.get_mut().unwrap().as_mut() [INFO] [stdout] 33 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ unsafe { [INFO] [stdout] 25 + let server = Server::new(host, port, None); [INFO] [stdout] 26 + [INFO] [stdout] 27 + GLOBAL_SERVER [INFO] [stdout] 28 + .set(Box::new(server)) [INFO] [stdout] 29 + .map_err(|_| "global state already initialized") [INFO] [stdout] 30 + .unwrap(); [INFO] [stdout] 31 + [INFO] [stdout] 32 + GLOBAL_SERVER.get_mut().unwrap().as_mut() [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / return Self { [INFO] [stdout] 54 | | fields: Vec::new(), [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 ~ Self { [INFO] [stdout] 54 + fields: Vec::new(), [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return &mut self.fields[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return &mut self.fields[idx]; [INFO] [stdout] 63 + &mut self.fields[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / return unsafe { [INFO] [stdout] 39 | | let server = Server::new( [INFO] [stdout] 40 | | host, [INFO] [stdout] 41 | | port, [INFO] [stdout] ... | [INFO] [stdout] 50 | | GLOBAL_SERVER.get_mut().unwrap().as_mut() [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 ~ unsafe { [INFO] [stdout] 39 + let server = Server::new( [INFO] [stdout] 40 + host, [INFO] [stdout] 41 + port, [INFO] [stdout] 42 + Some(server_config(get_tls_config(&TlsPathConfig::new(key_path, cert_path)).unwrap()).unwrap()) [INFO] [stdout] 43 + ); [INFO] [stdout] 44 + [INFO] [stdout] 45 + GLOBAL_SERVER [INFO] [stdout] 46 + .set(Box::new(server)) [INFO] [stdout] 47 + .map_err(|_| "global state already initialized") [INFO] [stdout] 48 + .unwrap(); [INFO] [stdout] 49 + [INFO] [stdout] 50 + GLOBAL_SERVER.get_mut().unwrap().as_mut() [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return Self { [INFO] [stdout] 70 | | form: form, [INFO] [stdout] 71 | | rules: rules, [INFO] [stdout] 72 | | errors: Values::new(), [INFO] [stdout] 73 | | validated: Form::new(Values::new(), Files::new()) [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ Self { [INFO] [stdout] 70 + form: form, [INFO] [stdout] 71 + rules: rules, [INFO] [stdout] 72 + errors: Values::new(), [INFO] [stdout] 73 + validated: Form::new(Values::new(), Files::new()) [INFO] [stdout] 74 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return self.errors.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return self.errors.len() == 0; [INFO] [stdout] 84 + self.errors.len() == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/validation/mod.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | return self.errors.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.errors.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return next.handle(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return next.handle(res); [INFO] [stdout] 96 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return Values::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return Values::new(); [INFO] [stdout] 100 + Values::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation/mod.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return None [INFO] [stdout] 110 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assets/mod.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return Self { [INFO] [stdout] 33 | | path: path.trim_end_matches("/").to_owned(), [INFO] [stdout] 34 | | max_size: max_size_kilobytes_cache_size * 1000, [INFO] [stdout] 35 | | expires: expires_in_seconds, [INFO] [stdout] 36 | | cache: Cache::new(), [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Self { [INFO] [stdout] 33 + path: path.trim_end_matches("/").to_owned(), [INFO] [stdout] 34 + max_size: max_size_kilobytes_cache_size * 1000, [INFO] [stdout] 35 + expires: expires_in_seconds, [INFO] [stdout] 36 + cache: Cache::new(), [INFO] [stdout] 37 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assets/mod.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | if !cached_asset.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cached_asset.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cached_asset` after checking its variant with `is_some` [INFO] [stdout] --> src/assets/mod.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 44 | if cached_asset.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = cached_asset` [INFO] [stdout] 45 | let asset = cached_asset.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assets/mod.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Ok(()); [INFO] [stdout] 72 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/assets/mod.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | if asset.size > self.max_size.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assets/mod.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if !file.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `file.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assets/mod.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | if !reading.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `reading.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assets/mod.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(Some(asset)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Ok(Some(asset)) [INFO] [stdout] 98 + Ok(Some(asset)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / return unsafe { [INFO] [stdout] 25 | | let server = Server::new(host, port, None); [INFO] [stdout] 26 | | [INFO] [stdout] 27 | | GLOBAL_SERVER [INFO] [stdout] ... | [INFO] [stdout] 32 | | GLOBAL_SERVER.get_mut().unwrap().as_mut() [INFO] [stdout] 33 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ unsafe { [INFO] [stdout] 25 + let server = Server::new(host, port, None); [INFO] [stdout] 26 + [INFO] [stdout] 27 + GLOBAL_SERVER [INFO] [stdout] 28 + .set(Box::new(server)) [INFO] [stdout] 29 + .map_err(|_| "global state already initialized") [INFO] [stdout] 30 + .unwrap(); [INFO] [stdout] 31 + [INFO] [stdout] 32 + GLOBAL_SERVER.get_mut().unwrap().as_mut() [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / return unsafe { [INFO] [stdout] 39 | | let server = Server::new( [INFO] [stdout] 40 | | host, [INFO] [stdout] 41 | | port, [INFO] [stdout] ... | [INFO] [stdout] 50 | | GLOBAL_SERVER.get_mut().unwrap().as_mut() [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 ~ unsafe { [INFO] [stdout] 39 + let server = Server::new( [INFO] [stdout] 40 + host, [INFO] [stdout] 41 + port, [INFO] [stdout] 42 + Some(server_config(get_tls_config(&TlsPathConfig::new(key_path, cert_path)).unwrap()).unwrap()) [INFO] [stdout] 43 + ); [INFO] [stdout] 44 + [INFO] [stdout] 45 + GLOBAL_SERVER [INFO] [stdout] 46 + .set(Box::new(server)) [INFO] [stdout] 47 + .map_err(|_| "global state already initialized") [INFO] [stdout] 48 + .unwrap(); [INFO] [stdout] 49 + [INFO] [stdout] 50 + GLOBAL_SERVER.get_mut().unwrap().as_mut() [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/tls.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | return res.html("

Hello World!!!

") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return res.html("

Hello World!!!

") [INFO] [stdout] 7 + res.html("

Hello World!!!

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/env.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return res.view("env.html", None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return res.view("env.html", None); [INFO] [stdout] 42 + res.view("env.html", None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/basic.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | return res.html("

Hello World!!!

") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return res.html("

Hello World!!!

") [INFO] [stdout] 7 + res.html("

Hello World!!!

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/websocket.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return next.handle(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return next.handle(res); [INFO] [stdout] 16 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> examples/subdomain.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | const DNS_HOST: &'static str = "127.0.0.1"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | return res.html("

Hello World

") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return res.html("

Hello World

") [INFO] [stdout] 8 + res.html("

Hello World

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | return res [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return res [INFO] [stdout] 12 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/session.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return res.html(format!("

Welcome to protected home page user {}

", req.session().get("user_id")).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return res.html(format!("

Welcome to protected home page user {}

", req.session().get("user_id")).as_str()); [INFO] [stdout] 13 + res.html(format!("

Welcome to protected home page user {}

", req.session().get("user_id")).as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/session.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return res.redirect("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return res.redirect("/"); [INFO] [stdout] 20 + res.redirect("/") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/session.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return res.html("

Please visit the login page to login

"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return res.html("

Please visit the login page to login

"); [INFO] [stdout] 25 + res.html("

Please visit the login page to login

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | return res [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return res [INFO] [stdout] 16 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return next.handle(res) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return next.handle(res) [INFO] [stdout] 21 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/session.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return res.redirect("register"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return res.redirect("register"); [INFO] [stdout] 32 + res.redirect("register") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/session.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return res.html("

404 Page Not Found

"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return res.html("

404 Page Not Found

"); [INFO] [stdout] 37 + res.html("

404 Page Not Found

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/session.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return next.handle(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return next.handle(res); [INFO] [stdout] 46 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> examples/session.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | if req.session().get("user_id") == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `req.session().get("user_id").is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/session.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return next.handle(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return next.handle(res); [INFO] [stdout] 55 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | return res.html("

Hello World

") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return res.html("

Hello World

") [INFO] [stdout] 8 + res.html("

Hello World

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | return res [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return res [INFO] [stdout] 12 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | return res [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return res [INFO] [stdout] 16 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return next.handle(res) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return next.handle(res) [INFO] [stdout] 21 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/forms.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return res.view("index.html", Some(view_data())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return res.view("index.html", Some(view_data())); [INFO] [stdout] 51 + res.view("index.html", Some(view_data())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/forms.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return res.redirect("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return res.redirect("/"); [INFO] [stdout] 63 + res.redirect("/") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/routing.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return res.html("

Users List

"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return res.html("

Users List

"); [INFO] [stdout] 4 + res.html("

Users List

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/routing.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | return res.redirect("users/1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return res.redirect("users/1"); [INFO] [stdout] 8 + res.redirect("users/1") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/routing.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return res.html(format!("

User {}

", req.parameter("user")).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return res.html(format!("

User {}

", req.parameter("user")).as_str()); [INFO] [stdout] 12 + res.html(format!("

User {}

", req.parameter("user")).as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/routing.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return res.redirect(format!("users/{}", req.parameter("user")).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return res.redirect(format!("users/{}", req.parameter("user")).as_str()); [INFO] [stdout] 16 + res.redirect(format!("users/{}", req.parameter("user")).as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/routing.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return res.redirect("users") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return res.redirect("users") [INFO] [stdout] 20 + res.redirect("users") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/cookie.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return res.html("

Cookie has been set visit route /cookie

"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return res.html("

Cookie has been set visit route /cookie

"); [INFO] [stdout] 14 + res.html("

Cookie has been set visit route /cookie

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/cookie.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return res.html(format!("

User ID cookie is {}

", req.cookies().get("user_id")).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return res.html(format!("

User ID cookie is {}

", req.cookies().get("user_id")).as_str()); [INFO] [stdout] 18 + res.html(format!("

User ID cookie is {}

", req.cookies().get("user_id")).as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/view.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return res.view("index.html", Some(data)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return res.view("index.html", Some(data)); [INFO] [stdout] 42 + res.view("index.html", Some(data)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/assets.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return res.view("index.html", Some(view_data())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return res.view("index.html", Some(view_data())); [INFO] [stdout] 45 + res.view("index.html", Some(view_data())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/subdomain.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return res.html("

Home Page

"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return res.html("

Home Page

"); [INFO] [stdout] 27 + res.html("

Home Page

") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/subdomain.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / return res.json(&ApiInfo { [INFO] [stdout] 33 | | info: "Application details", [INFO] [stdout] 34 | | version: 1 [INFO] [stdout] 35 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ res.json(&ApiInfo { [INFO] [stdout] 33 + info: "Application details", [INFO] [stdout] 34 + version: 1 [INFO] [stdout] 35 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/subdomain.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return res.html(format!("

Client Name {}

", req.parameter("client")).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return res.html(format!("

Client Name {}

", req.parameter("client")).as_str()); [INFO] [stdout] 41 + res.html(format!("

Client Name {}

", req.parameter("client")).as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/subdomain.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | ... return res.html(format!("

Client Name {} Account {}

", req.parameter("client"), req.parameter("account_id")).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return res.html(format!("

Client Name {} Account {}

", req.parameter("client"), req.parameter("account_id")).as_str()); [INFO] [stdout] 47 + res.html(format!("

Client Name {} Account {}

", req.parameter("client"), req.parameter("account_id")).as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/middleware.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return next.handle(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return next.handle(res); [INFO] [stdout] 27 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/middleware.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return next.handle(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return next.handle(res); [INFO] [stdout] 32 + next.handle(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/middleware.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | / return res.json(&User{ [INFO] [stdout] 43 | | id: req.parameter("user").parse().unwrap(), [INFO] [stdout] 44 | | email: "joe@deo.com".to_owned() [INFO] [stdout] 45 | | }); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ res.json(&User{ [INFO] [stdout] 43 + id: req.parameter("user").parse().unwrap(), [INFO] [stdout] 44 + email: "joe@deo.com".to_owned() [INFO] [stdout] 45 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/form_validation.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return res.view("register.html", None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return res.view("register.html", None); [INFO] [stdout] 165 + res.view("register.html", None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/form_validation.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | / return res.json(&Token { [INFO] [stdout] 170 | | token: String::from("eye.jwt.token"), [INFO] [stdout] 171 | | r#type: String::from("jwt"), [INFO] [stdout] 172 | | expires: Duration::from_secs((606 * 60) * 24).as_millis() [INFO] [stdout] 173 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 ~ res.json(&Token { [INFO] [stdout] 170 + token: String::from("eye.jwt.token"), [INFO] [stdout] 171 + r#type: String::from("jwt"), [INFO] [stdout] 172 + expires: Duration::from_secs((606 * 60) * 24).as_millis() [INFO] [stdout] 173 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/form_validation.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return None [INFO] [stdout] 187 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `Command { std: "docker" "inspect" "5862c4814d8bf7ee2919055573fdf355f72d4aa588b67af84c21247b72d0e831", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5862c4814d8bf7ee2919055573fdf355f72d4aa588b67af84c21247b72d0e831", kill_on_drop: false }` [INFO] [stdout] 5862c4814d8bf7ee2919055573fdf355f72d4aa588b67af84c21247b72d0e831