[INFO] fetching crate flx-rs 0.2.1... [INFO] linting flx-rs-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate flx-rs 0.2.1 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate flx-rs 0.2.1 [INFO] finished tweaking crates.io crate flx-rs 0.2.1 [INFO] tweaked toml for crates.io crate flx-rs 0.2.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate flx-rs 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd1f53fe4202d83276c4fce3abc6374178f0d9bf9995ef13f2ca02ffb6617eb1 [INFO] running `Command { std: "docker" "start" "-a" "dd1f53fe4202d83276c4fce3abc6374178f0d9bf9995ef13f2ca02ffb6617eb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd1f53fe4202d83276c4fce3abc6374178f0d9bf9995ef13f2ca02ffb6617eb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd1f53fe4202d83276c4fce3abc6374178f0d9bf9995ef13f2ca02ffb6617eb1", kill_on_drop: false }` [INFO] [stdout] dd1f53fe4202d83276c4fce3abc6374178f0d9bf9995ef13f2ca02ffb6617eb1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe1aeb03821590dad6094972832a8cf7115d1389c8186275f0d4475f5af2660a [INFO] running `Command { std: "docker" "start" "-a" "fe1aeb03821590dad6094972832a8cf7115d1389c8186275f0d4475f5af2660a", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking flx-rs v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return !WORD_SEPARATORS.contains(&ch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return !WORD_SEPARATORS.contains(&ch); [INFO] [stdout] 36 + !WORD_SEPARATORS.contains(&ch) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return ch_uw == ch_uw.to_uppercase().next().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return ch_uw == ch_uw.to_uppercase().next().unwrap(); [INFO] [stdout] 49 + ch_uw == ch_uw.to_uppercase().next().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return word(char) && is_uppercase(&ch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return word(char) && is_uppercase(&ch); [INFO] [stdout] 62 + word(char) && is_uppercase(&ch) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return false; [INFO] [stdout] 78 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/search.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | fn inc_vec(vec: &mut Vec, inc: Option, beg: Option, end: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - fn inc_vec(vec: &mut Vec, inc: Option, beg: Option, end: Option) { [INFO] [stdout] 82 + fn inc_vec(vec: &mut [i32], inc: Option, beg: Option, end: Option) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/search.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | .or_insert_with(VecDeque::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/search.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 118 | .or_insert_with(VecDeque::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index1` is used as a loop counter [INFO] [stdout] --> src/search.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | for char in str.chars() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index1, char) in str.chars().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 165 | if last_char != None && last_char.unwrap() == penalty_lead { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `last_char.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 169 | if group_separator != None && group_separator.unwrap() == char { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `group_separator.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 235 | let mut last_word: i32 = if last_group_limit != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `last_group_limit.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:271:8 [INFO] [stdout] | [INFO] [stdout] 271 | if sorted_list == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `sorted_list.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | if val != None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_some()` instead: `val.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/search.rs:326:8 [INFO] [stdout] | [INFO] [stdout] 326 | if !hash_value.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `hash_value.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/search.rs:308:1 [INFO] [stdout] | [INFO] [stdout] 308 | / pub fn find_best_match( [INFO] [stdout] 309 | | imatch: &mut Vec, [INFO] [stdout] 310 | | str_info: HashMap, VecDeque>>, [INFO] [stdout] 311 | | heatmap: Vec, [INFO] [stdout] ... | [INFO] [stdout] 316 | | match_cache: &mut HashMap>, [INFO] [stdout] 317 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `hash_value` after checking its variant with `is_none` [INFO] [stdout] --> src/search.rs:329:20 [INFO] [stdout] | [INFO] [stdout] 326 | if !hash_value.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 329 | for val in hash_value.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:318:31 [INFO] [stdout] | [INFO] [stdout] 318 | let greater_num: u32 = if greater_than != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `greater_than.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/search.rs:338:35 [INFO] [stdout] | [INFO] [stdout] 338 | let mut best_score: i32 = std::f32::NEG_INFINITY as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 338 - let mut best_score: i32 = std::f32::NEG_INFINITY as i32; [INFO] [stdout] 338 + let mut best_score: i32 = f32::NEG_INFINITY as i32; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:437:5 [INFO] [stdout] | [INFO] [stdout] 437 | return Some(result_1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - return Some(result_1); [INFO] [stdout] 437 + Some(result_1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return !WORD_SEPARATORS.contains(&ch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return !WORD_SEPARATORS.contains(&ch); [INFO] [stdout] 36 + !WORD_SEPARATORS.contains(&ch) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return ch_uw == ch_uw.to_uppercase().next().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return ch_uw == ch_uw.to_uppercase().next().unwrap(); [INFO] [stdout] 49 + ch_uw == ch_uw.to_uppercase().next().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return word(char) && is_uppercase(&ch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return word(char) && is_uppercase(&ch); [INFO] [stdout] 62 + word(char) && is_uppercase(&ch) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return false; [INFO] [stdout] 78 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/search.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | fn inc_vec(vec: &mut Vec, inc: Option, beg: Option, end: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - fn inc_vec(vec: &mut Vec, inc: Option, beg: Option, end: Option) { [INFO] [stdout] 82 + fn inc_vec(vec: &mut [i32], inc: Option, beg: Option, end: Option) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/search.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | .or_insert_with(VecDeque::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/search.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 118 | .or_insert_with(VecDeque::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index1` is used as a loop counter [INFO] [stdout] --> src/search.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | for char in str.chars() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index1, char) in str.chars().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 165 | if last_char != None && last_char.unwrap() == penalty_lead { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `last_char.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 169 | if group_separator != None && group_separator.unwrap() == char { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `group_separator.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 235 | let mut last_word: i32 = if last_group_limit != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `last_group_limit.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:271:8 [INFO] [stdout] | [INFO] [stdout] 271 | if sorted_list == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `sorted_list.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | if val != None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_some()` instead: `val.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/search.rs:326:8 [INFO] [stdout] | [INFO] [stdout] 326 | if !hash_value.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `hash_value.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/search.rs:308:1 [INFO] [stdout] | [INFO] [stdout] 308 | / pub fn find_best_match( [INFO] [stdout] 309 | | imatch: &mut Vec, [INFO] [stdout] 310 | | str_info: HashMap, VecDeque>>, [INFO] [stdout] 311 | | heatmap: Vec, [INFO] [stdout] ... | [INFO] [stdout] 316 | | match_cache: &mut HashMap>, [INFO] [stdout] 317 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `hash_value` after checking its variant with `is_none` [INFO] [stdout] --> src/search.rs:329:20 [INFO] [stdout] | [INFO] [stdout] 326 | if !hash_value.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 329 | for val in hash_value.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/search.rs:318:31 [INFO] [stdout] | [INFO] [stdout] 318 | let greater_num: u32 = if greater_than != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `greater_than.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/search.rs:338:35 [INFO] [stdout] | [INFO] [stdout] 338 | let mut best_score: i32 = std::f32::NEG_INFINITY as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 338 - let mut best_score: i32 = std::f32::NEG_INFINITY as i32; [INFO] [stdout] 338 + let mut best_score: i32 = f32::NEG_INFINITY as i32; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:437:5 [INFO] [stdout] | [INFO] [stdout] 437 | return Some(result_1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - return Some(result_1); [INFO] [stdout] 437 + Some(result_1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "fe1aeb03821590dad6094972832a8cf7115d1389c8186275f0d4475f5af2660a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe1aeb03821590dad6094972832a8cf7115d1389c8186275f0d4475f5af2660a", kill_on_drop: false }` [INFO] [stdout] fe1aeb03821590dad6094972832a8cf7115d1389c8186275f0d4475f5af2660a