[INFO] fetching crate fixedbuf 0.1.2... [INFO] linting fixedbuf-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate fixedbuf 0.1.2 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate fixedbuf 0.1.2 [INFO] finished tweaking crates.io crate fixedbuf 0.1.2 [INFO] tweaked toml for crates.io crate fixedbuf 0.1.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate fixedbuf 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate fixedbuf 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afc866752af833867e8b59b34b469b49595a36307c7411fe6341f40b9d96ca9b [INFO] running `Command { std: "docker" "start" "-a" "afc866752af833867e8b59b34b469b49595a36307c7411fe6341f40b9d96ca9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afc866752af833867e8b59b34b469b49595a36307c7411fe6341f40b9d96ca9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afc866752af833867e8b59b34b469b49595a36307c7411fe6341f40b9d96ca9b", kill_on_drop: false }` [INFO] [stdout] afc866752af833867e8b59b34b469b49595a36307c7411fe6341f40b9d96ca9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bbc1f424ae6d445e2a017934fd7974b94f1b855e025f616aaffdfdf9bd65f505 [INFO] running `Command { std: "docker" "start" "-a" "bbc1f424ae6d445e2a017934fd7974b94f1b855e025f616aaffdfdf9bd65f505", kill_on_drop: false }` [INFO] [stderr] Checking fixedbuf v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ArrayBuf` [INFO] [stdout] --> src/lib.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / pub fn new() -> Self { [INFO] [stdout] 41 | | Self { [INFO] [stdout] 42 | | buf: Box::new([0; LEN]), [INFO] [stdout] 43 | | len: 0, [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 22 + impl Default for ArrayBuf { [INFO] [stdout] 23 + fn default() -> Self { [INFO] [stdout] 24 + Self::new() [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return LEN; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return LEN; [INFO] [stdout] 53 + LEN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | assert!(!(len > LEN), "Out of range, {}", len); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(len <= LEN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ArrayBuf` [INFO] [stdout] --> src/lib.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / pub fn new() -> Self { [INFO] [stdout] 41 | | Self { [INFO] [stdout] 42 | | buf: Box::new([0; LEN]), [INFO] [stdout] 43 | | len: 0, [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 22 + impl Default for ArrayBuf { [INFO] [stdout] 23 + fn default() -> Self { [INFO] [stdout] 24 + Self::new() [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return LEN; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return LEN; [INFO] [stdout] 53 + LEN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | assert!(!(len > LEN), "Out of range, {}", len); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(len <= LEN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `Command { std: "docker" "inspect" "bbc1f424ae6d445e2a017934fd7974b94f1b855e025f616aaffdfdf9bd65f505", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbc1f424ae6d445e2a017934fd7974b94f1b855e025f616aaffdfdf9bd65f505", kill_on_drop: false }` [INFO] [stdout] bbc1f424ae6d445e2a017934fd7974b94f1b855e025f616aaffdfdf9bd65f505