[INFO] fetching crate fixed-point-math 0.1.0... [INFO] linting fixed-point-math-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate fixed-point-math 0.1.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate fixed-point-math 0.1.0 [INFO] finished tweaking crates.io crate fixed-point-math 0.1.0 [INFO] tweaked toml for crates.io crate fixed-point-math 0.1.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate fixed-point-math 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43f2b9ba868f7caa25f830be7d30ea291e1cb6d46770dfa4f9f83108da845770 [INFO] running `Command { std: "docker" "start" "-a" "43f2b9ba868f7caa25f830be7d30ea291e1cb6d46770dfa4f9f83108da845770", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43f2b9ba868f7caa25f830be7d30ea291e1cb6d46770dfa4f9f83108da845770", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43f2b9ba868f7caa25f830be7d30ea291e1cb6d46770dfa4f9f83108da845770", kill_on_drop: false }` [INFO] [stdout] 43f2b9ba868f7caa25f830be7d30ea291e1cb6d46770dfa4f9f83108da845770 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ecd11f92a3d275bce3f55688e640d435ad857024b05c22bc10193afadeebdf97 [INFO] running `Command { std: "docker" "start" "-a" "ecd11f92a3d275bce3f55688e640d435ad857024b05c22bc10193afadeebdf97", kill_on_drop: false }` [INFO] [stderr] Checking fixed-point-math v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/lib.rs:9:22 [INFO] [stdout] | [INFO] [stdout] 9 | pub use fixed_point::FixedPoint; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::fixed_point::FixedPoint; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | impl FixedPoint for i128 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::fixed_point::FixedPoint; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | impl FixedPoint for u64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/i128.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 - if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] 40 + if !(r > 0 && z >= 0) { [INFO] [stdout] | [INFO] [stdout] 40 - if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] 40 + if r <= 0 || z < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u64.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return match x.checked_mul(y) { [INFO] [stdout] 24 | | Some(r) => r.checked_div(z), [INFO] [stdout] 25 | | None => { [INFO] [stdout] 26 | | let res_u128 = (x as u128).checked_mul(y as u128)?.checked_div(z as u128)?; [INFO] [stdout] ... | [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ match x.checked_mul(y) { [INFO] [stdout] 24 + Some(r) => r.checked_div(z), [INFO] [stdout] 25 + None => { [INFO] [stdout] 26 + let res_u128 = (x as u128).checked_mul(y as u128)?.checked_div(z as u128)?; [INFO] [stdout] 27 + if res_u128 > u64::MAX as u128 { [INFO] [stdout] 28 + return None; [INFO] [stdout] 29 + } [INFO] [stdout] 30 + Some(res_u128 as u64) [INFO] [stdout] 31 + } [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u64.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / return match x.checked_mul(y) { [INFO] [stdout] 38 | | Some(r) => { [INFO] [stdout] 39 | | let remainder = r.checked_rem_euclid(z)?; [INFO] [stdout] ... | [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ match x.checked_mul(y) { [INFO] [stdout] 38 + Some(r) => { [INFO] [stdout] 39 + let remainder = r.checked_rem_euclid(z)?; [INFO] [stdout] 40 + // div overflow will be caught by checked_rem_euclid [INFO] [stdout] 41 + (r / z).checked_add(if remainder > 0 { 1 } else { 0 }) [INFO] [stdout] 42 + } [INFO] [stdout] 43 + None => { [INFO] [stdout] 44 + // TODO: safe cast [INFO] [stdout] 45 + let r_u128 = (x as u128).checked_mul(y as u128)?; [INFO] [stdout] 46 + let remainder = r_u128.checked_rem_euclid(z as u128)?; [INFO] [stdout] 47 + let res_u128 = r_u128 / (z as u128); [INFO] [stdout] 48 + if res_u128 > u64::MAX as u128 { [INFO] [stdout] 49 + return None; [INFO] [stdout] 50 + } [INFO] [stdout] 51 + (res_u128 as u64).checked_add(if remainder > 0 { 1 } else { 0 }) [INFO] [stdout] 52 + } [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/lib.rs:9:22 [INFO] [stdout] | [INFO] [stdout] 9 | pub use fixed_point::FixedPoint; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::fixed_point::FixedPoint; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | impl FixedPoint for i128 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::fixed_point::FixedPoint; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `fixed_point::FixedPoint`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | impl FixedPoint for u64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 62 | let result = x.fixed_mul_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 73 | let result = x.fixed_mul_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:84:24 [INFO] [stdout] | [INFO] [stdout] 84 | let result = x.fixed_mul_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:95:24 [INFO] [stdout] | [INFO] [stdout] 95 | let result = x.fixed_mul_floor(y, denominator); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:108:24 [INFO] [stdout] | [INFO] [stdout] 108 | let result = x.fixed_mul_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:119:24 [INFO] [stdout] | [INFO] [stdout] 119 | let result = x.fixed_mul_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:130:24 [INFO] [stdout] | [INFO] [stdout] 130 | let result = x.fixed_mul_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:141:24 [INFO] [stdout] | [INFO] [stdout] 141 | let result = x.fixed_mul_ceil(y, denominator); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:154:24 [INFO] [stdout] | [INFO] [stdout] 154 | let result = x.fixed_div_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | let result = x.fixed_div_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | let result = x.fixed_div_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 187 | let result = x.fixed_div_floor(y, denominator); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:200:24 [INFO] [stdout] | [INFO] [stdout] 200 | let result = x.fixed_div_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:211:24 [INFO] [stdout] | [INFO] [stdout] 211 | let result = x.fixed_div_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:222:24 [INFO] [stdout] | [INFO] [stdout] 222 | let result = x.fixed_div_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/i128.rs:233:24 [INFO] [stdout] | [INFO] [stdout] 233 | let result = x.fixed_div_ceil(y, denominator); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | let result = x.fixed_mul_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:79:24 [INFO] [stdout] | [INFO] [stdout] 79 | let result = x.fixed_mul_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:90:24 [INFO] [stdout] | [INFO] [stdout] 90 | let result = x.fixed_mul_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:101:24 [INFO] [stdout] | [INFO] [stdout] 101 | let result = x.fixed_mul_floor(y, denominator); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:114:24 [INFO] [stdout] | [INFO] [stdout] 114 | let result = x.fixed_mul_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:125:24 [INFO] [stdout] | [INFO] [stdout] 125 | let result = x.fixed_mul_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:136:24 [INFO] [stdout] | [INFO] [stdout] 136 | let result = x.fixed_mul_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_mul_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | let result = x.fixed_mul_ceil(y, denominator); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:160:24 [INFO] [stdout] | [INFO] [stdout] 160 | let result = x.fixed_div_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:171:24 [INFO] [stdout] | [INFO] [stdout] 171 | let result = x.fixed_div_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | let result = x.fixed_div_floor(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_floor`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | let result = x.fixed_div_floor(y, denominator); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:206:24 [INFO] [stdout] | [INFO] [stdout] 206 | let result = x.fixed_div_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:217:24 [INFO] [stdout] | [INFO] [stdout] 217 | let result = x.fixed_div_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:228:24 [INFO] [stdout] | [INFO] [stdout] 228 | let result = x.fixed_div_ceil(y, denominator).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `fixed_point::FixedPoint::fixed_div_ceil`: please use crate `soroban-fixed-point-math` instead [INFO] [stdout] --> src/u64.rs:239:24 [INFO] [stdout] | [INFO] [stdout] 239 | let result = x.fixed_div_ceil(y, denominator); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/i128.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 - if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] 40 + if !(r > 0 && z >= 0) { [INFO] [stdout] | [INFO] [stdout] 40 - if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] 40 + if r <= 0 || z < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u64.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return match x.checked_mul(y) { [INFO] [stdout] 24 | | Some(r) => r.checked_div(z), [INFO] [stdout] 25 | | None => { [INFO] [stdout] 26 | | let res_u128 = (x as u128).checked_mul(y as u128)?.checked_div(z as u128)?; [INFO] [stdout] ... | [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ match x.checked_mul(y) { [INFO] [stdout] 24 + Some(r) => r.checked_div(z), [INFO] [stdout] 25 + None => { [INFO] [stdout] 26 + let res_u128 = (x as u128).checked_mul(y as u128)?.checked_div(z as u128)?; [INFO] [stdout] 27 + if res_u128 > u64::MAX as u128 { [INFO] [stdout] 28 + return None; [INFO] [stdout] 29 + } [INFO] [stdout] 30 + Some(res_u128 as u64) [INFO] [stdout] 31 + } [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u64.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / return match x.checked_mul(y) { [INFO] [stdout] 38 | | Some(r) => { [INFO] [stdout] 39 | | let remainder = r.checked_rem_euclid(z)?; [INFO] [stdout] ... | [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ match x.checked_mul(y) { [INFO] [stdout] 38 + Some(r) => { [INFO] [stdout] 39 + let remainder = r.checked_rem_euclid(z)?; [INFO] [stdout] 40 + // div overflow will be caught by checked_rem_euclid [INFO] [stdout] 41 + (r / z).checked_add(if remainder > 0 { 1 } else { 0 }) [INFO] [stdout] 42 + } [INFO] [stdout] 43 + None => { [INFO] [stdout] 44 + // TODO: safe cast [INFO] [stdout] 45 + let r_u128 = (x as u128).checked_mul(y as u128)?; [INFO] [stdout] 46 + let remainder = r_u128.checked_rem_euclid(z as u128)?; [INFO] [stdout] 47 + let res_u128 = r_u128 / (z as u128); [INFO] [stdout] 48 + if res_u128 > u64::MAX as u128 { [INFO] [stdout] 49 + return None; [INFO] [stdout] 50 + } [INFO] [stdout] 51 + (res_u128 as u64).checked_add(if remainder > 0 { 1 } else { 0 }) [INFO] [stdout] 52 + } [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s [INFO] running `Command { std: "docker" "inspect" "ecd11f92a3d275bce3f55688e640d435ad857024b05c22bc10193afadeebdf97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecd11f92a3d275bce3f55688e640d435ad857024b05c22bc10193afadeebdf97", kill_on_drop: false }` [INFO] [stdout] ecd11f92a3d275bce3f55688e640d435ad857024b05c22bc10193afadeebdf97