[INFO] fetching crate filetool 0.5.2... [INFO] linting filetool-0.5.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate filetool 0.5.2 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate filetool 0.5.2 [INFO] finished tweaking crates.io crate filetool 0.5.2 [INFO] tweaked toml for crates.io crate filetool 0.5.2 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate filetool 0.5.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate filetool 0.5.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded indicatif-log-bridge v0.2.3 [INFO] [stderr] Downloaded mp4 v0.14.0 [INFO] [stderr] Downloaded clap-verbosity-flag v3.0.4 [INFO] [stderr] Downloaded serde_spanned v1.0.2 [INFO] [stderr] Downloaded more-asserts v0.3.1 [INFO] [stderr] Downloaded cargo-platform v0.3.1 [INFO] [stderr] Downloaded humansize v2.1.3 [INFO] [stderr] Downloaded coveralls-api v0.7.0 [INFO] [stderr] Downloaded cargo_metadata v0.22.0 [INFO] [stderr] Downloaded normpath v1.5.0 [INFO] [stderr] Downloaded cargo-util-schemas v0.8.2 [INFO] [stderr] Downloaded llvm_profparser v0.9.0 [INFO] [stderr] Downloaded procfs-core v0.18.0 [INFO] [stderr] Downloaded toml v0.9.7 [INFO] [stderr] Downloaded indicatif v0.18.0 [INFO] [stderr] Downloaded procfs v0.18.0 [INFO] [stderr] Downloaded ruzstd v0.8.1 [INFO] [stderr] Downloaded toml_writer v1.0.3 [INFO] [stderr] Downloaded object v0.26.2 [INFO] [stderr] Downloaded remove_dir_all v1.0.0 [INFO] [stderr] Downloaded git2 v0.20.2 [INFO] [stderr] Downloaded cargo-tarpaulin v0.33.0 [INFO] [stderr] Downloaded concat-string v1.0.1 [INFO] [stderr] Downloaded libgit2-sys v0.18.2+1.9.1 [INFO] [stderr] Downloaded testfiles v0.0.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a1ef17206902ee6e0aea4c26309ba5d425a1a076ec5994bbafa8854a5eddfe11 [INFO] running `Command { std: "docker" "start" "-a" "a1ef17206902ee6e0aea4c26309ba5d425a1a076ec5994bbafa8854a5eddfe11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a1ef17206902ee6e0aea4c26309ba5d425a1a076ec5994bbafa8854a5eddfe11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1ef17206902ee6e0aea4c26309ba5d425a1a076ec5994bbafa8854a5eddfe11", kill_on_drop: false }` [INFO] [stdout] a1ef17206902ee6e0aea4c26309ba5d425a1a076ec5994bbafa8854a5eddfe11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 696726ab57c85b0972665b4cbecbd46e22dc58efcfe7af5484334c46ecfe1dca [INFO] running `Command { std: "docker" "start" "-a" "696726ab57c85b0972665b4cbecbd46e22dc58efcfe7af5484334c46ecfe1dca", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Compiling find-msvc-tools v0.1.3 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling pest v2.8.3 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling camino v1.2.1 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Checking unicode-ident v1.0.19 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling phf_shared v0.13.1 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking flate2 v1.1.4 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking serde-untagged v0.1.9 [INFO] [stderr] Checking gzip-header v1.0.0 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Compiling procfs v0.18.0 [INFO] [stderr] Compiling cc v1.2.40 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling phf_generator v0.13.1 [INFO] [stderr] Checking procfs-core v0.18.0 [INFO] [stderr] Checking object v0.26.2 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Compiling cargo-tarpaulin v0.33.0 [INFO] [stderr] Checking serde_spanned v1.0.2 [INFO] [stderr] Checking toml_datetime v0.7.2 [INFO] [stderr] Checking cvt v0.1.2 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking console v0.16.1 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking unit-prefix v0.5.1 [INFO] [stderr] Checking toml_writer v1.0.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Compiling pest_meta v2.8.3 [INFO] [stderr] Checking toml_parser v1.0.3 [INFO] [stderr] Checking indicatif v0.18.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking fs_at v0.2.1 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking toml v0.9.7 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling include_dir_macros v0.7.4 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking quick-xml v0.38.3 [INFO] [stderr] Checking normpath v1.5.0 [INFO] [stderr] Checking twox-hash v2.1.2 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking ruzstd v0.8.1 [INFO] [stderr] Checking include_dir v0.7.4 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling libgit2-sys v0.18.2+1.9.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking crc v3.3.0 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking remove_dir_all v1.0.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking indicatif-log-bridge v0.2.3 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking concat-string v1.0.1 [INFO] [stderr] Checking more-asserts v0.3.1 [INFO] [stderr] Checking testfiles v0.0.4 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling pest_generator v2.8.3 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Compiling pest_derive v2.8.3 [INFO] [stderr] Compiling phf_macros v0.13.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking clap-verbosity-flag v3.0.4 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking cargo-platform v0.3.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking llvm_profparser v0.9.0 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking mp4 v0.14.0 [INFO] [stderr] Checking handlebars v6.3.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking git2 v0.20.2 [INFO] [stderr] Checking cargo-util-schemas v0.8.2 [INFO] [stderr] Checking coveralls-api v0.7.0 [INFO] [stderr] Checking cargo_metadata v0.22.0 [INFO] [stderr] Checking filetool v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/canonical/mod.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | assert_eq!(false, (&b_jpg).exists()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 152 - assert_eq!(false, (&b_jpg).exists()); [INFO] [stdout] 152 + assert!(!(&b_jpg).exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/canonical/mod.rs:152:27 [INFO] [stdout] | [INFO] [stdout] 152 | assert_eq!(false, (&b_jpg).exists()); [INFO] [stdout] | ^^^^^^^^ help: change this to: `b_jpg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/canonical/mod.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | assert_eq!(false, (&b_jpeg).exists()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 164 - assert_eq!(false, (&b_jpeg).exists()); [INFO] [stdout] 164 + assert!(!(&b_jpeg).exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/canonical/mod.rs:164:27 [INFO] [stdout] | [INFO] [stdout] 164 | assert_eq!(false, (&b_jpeg).exists()); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `b_jpeg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/clean_empty_directory/mod.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | assert_eq!(tmp_dir.path().exists(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 144 - assert_eq!(tmp_dir.path().exists(), false); [INFO] [stdout] 144 + assert!(!tmp_dir.path().exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/clean_empty_directory/mod.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | assert_eq!(Path::join(tmp_dir.path(), "1/2/3/4").exists(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 178 - assert_eq!(Path::join(tmp_dir.path(), "1/2/3/4").exists(), false); [INFO] [stdout] 178 + assert!(!Path::join(tmp_dir.path(), "1/2/3/4").exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/clean_empty_directory/mod.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | assert_eq!(Path::join(tmp_dir.path(), "2").exists(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 179 - assert_eq!(Path::join(tmp_dir.path(), "2").exists(), false); [INFO] [stdout] 179 + assert!(!Path::join(tmp_dir.path(), "2").exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/clean_filename/mod.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | stem_ext(&std::path::Path::new("test/abc.123")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::path::Path::new("test/abc.123")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/common/fs.rs:392:9 [INFO] [stdout] | [INFO] [stdout] 392 | assert_eq!(readonly_dir.exists(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 392 - assert_eq!(readonly_dir.exists(), true); [INFO] [stdout] 392 + assert!(readonly_dir.exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/common/fs.rs:394:9 [INFO] [stdout] | [INFO] [stdout] 394 | assert_eq!(readonly_dir.exists(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 394 - assert_eq!(readonly_dir.exists(), false); [INFO] [stdout] 394 + assert!(!readonly_dir.exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `set_readonly` with argument `false` [INFO] [stdout] --> src/common/fs.rs:398:9 [INFO] [stdout] | [INFO] [stdout] 398 | / fs::metadata(readwrite_dir.clone()) [INFO] [stdout] 399 | | .expect("read metadata") [INFO] [stdout] 400 | | .permissions() [INFO] [stdout] 401 | | .set_readonly(false); [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: on Unix platforms this results in the file being world writable [INFO] [stdout] = help: you can set the desired permissions using `PermissionsExt`. For more information, see [INFO] [stdout] https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false [INFO] [stdout] = note: `#[warn(clippy::permissions_set_readonly_false)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/common/fs.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 404 | assert_eq!(readwrite_dir.exists(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 404 - assert_eq!(readwrite_dir.exists(), true); [INFO] [stdout] 404 + assert!(readwrite_dir.exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/common/fs.rs:406:9 [INFO] [stdout] | [INFO] [stdout] 406 | assert_eq!(readwrite_dir.exists(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 406 - assert_eq!(readwrite_dir.exists(), false); [INFO] [stdout] 406 + assert!(!readwrite_dir.exists()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/duplicate/mod.rs:379:17 [INFO] [stdout] | [INFO] [stdout] 379 | assert!(match_file(&std::path::PathBuf::from("/ok"), &Vec::new()) == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!match_file(&std::path::PathBuf::from("/ok"), &Vec::new())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 15s [INFO] running `Command { std: "docker" "inspect" "696726ab57c85b0972665b4cbecbd46e22dc58efcfe7af5484334c46ecfe1dca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "696726ab57c85b0972665b4cbecbd46e22dc58efcfe7af5484334c46ecfe1dca", kill_on_drop: false }` [INFO] [stdout] 696726ab57c85b0972665b4cbecbd46e22dc58efcfe7af5484334c46ecfe1dca