[INFO] fetching crate feo3boy-microcode-generator 0.1.0... [INFO] linting feo3boy-microcode-generator-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate feo3boy-microcode-generator 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate feo3boy-microcode-generator 0.1.0 [INFO] finished tweaking crates.io crate feo3boy-microcode-generator 0.1.0 [INFO] tweaked toml for crates.io crate feo3boy-microcode-generator 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate feo3boy-microcode-generator 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding derive-syn-parse v0.1.5 (available: v0.2.0) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (available: v3.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded derive-syn-parse v0.1.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac1c507591c9312897a87bb3b9b578fa37075ce1b7f1edf101c6e8abf67305c6 [INFO] running `Command { std: "docker" "start" "-a" "ac1c507591c9312897a87bb3b9b578fa37075ce1b7f1edf101c6e8abf67305c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac1c507591c9312897a87bb3b9b578fa37075ce1b7f1edf101c6e8abf67305c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac1c507591c9312897a87bb3b9b578fa37075ce1b7f1edf101c6e8abf67305c6", kill_on_drop: false }` [INFO] [stdout] ac1c507591c9312897a87bb3b9b578fa37075ce1b7f1edf101c6e8abf67305c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e11306cf5158e9f17c47d029584af2556fa5185b7c92fcfb9548175dd520819 [INFO] running `Command { std: "docker" "start" "-a" "6e11306cf5158e9f17c47d029584af2556fa5185b7c92fcfb9548175dd520819", kill_on_drop: false }` [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Compiling derive-syn-parse v0.1.5 [INFO] [stderr] Checking proc-macro-crate v1.3.1 [INFO] [stderr] Checking feo3boy-microcode-generator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `comma` and `trailing_comma` are never read [INFO] [stdout] --> src/parsing.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct AllowedTypesMappings { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub comma: Token![,], [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 17 | pub trailing_comma: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `equals` are never read [INFO] [stdout] --> src/parsing.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct AllowedTypesName { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 23 | /// The literal token `name`. [INFO] [stdout] 24 | pub name: kw::name, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | /// The assignment on the first line of the macro invocation. [INFO] [stdout] 26 | pub equals: Token![=], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `types`, `equals`, and `bracket` are never read [INFO] [stdout] --> src/parsing.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub struct AllowedTypesList { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 40 | /// The "types" token. [INFO] [stdout] 41 | pub types: kw::types, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 42 | /// The assignment between `types` and `[` [INFO] [stdout] 43 | pub equals: Token![=], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 44 | /// The brackets for the type mappings. [INFO] [stdout] 45 | pub bracket: Bracket, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `arrow` is never read [INFO] [stdout] --> src/parsing.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct AllowedTypesMapping { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 69 | pub arrow: Token![=>], [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/extractor.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | / if mac.mac.path.is_ident("allowed_types") { [INFO] [stdout] 88 | | if allowed_types.is_some() { [INFO] [stdout] 89 | | return Err(Error::new_spanned( [INFO] [stdout] 90 | | &mac.mac.path, [INFO] [stdout] ... | [INFO] [stdout] 96 | | items.remove(i); [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 86 ~ Item::Macro(mac) [INFO] [stdout] 87 ~ if mac.mac.path.is_ident("allowed_types") => { [INFO] [stdout] 88 | if allowed_types.is_some() { [INFO] [stdout] ... [INFO] [stdout] 96 | items.remove(i); [INFO] [stdout] 97 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/extractor.rs:179:20 [INFO] [stdout] | [INFO] [stdout] 179 | if !res.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `res.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extractor.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | / return Err(Error::new( [INFO] [stdout] 218 | | recv.self_token.span, [INFO] [stdout] 219 | | "microcode funcs must be free functions, not associated functions", [INFO] [stdout] 220 | | )); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 ~ Err(Error::new( [INFO] [stdout] 218 + recv.self_token.span, [INFO] [stdout] 219 + "microcode funcs must be free functions, not associated functions", [INFO] [stdout] 220 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `comma` and `trailing_comma` are never read [INFO] [stdout] --> src/parsing.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct AllowedTypesMappings { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub comma: Token![,], [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 17 | pub trailing_comma: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `equals` are never read [INFO] [stdout] --> src/parsing.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct AllowedTypesName { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 23 | /// The literal token `name`. [INFO] [stdout] 24 | pub name: kw::name, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | /// The assignment on the first line of the macro invocation. [INFO] [stdout] 26 | pub equals: Token![=], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `types`, `equals`, and `bracket` are never read [INFO] [stdout] --> src/parsing.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub struct AllowedTypesList { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 40 | /// The "types" token. [INFO] [stdout] 41 | pub types: kw::types, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 42 | /// The assignment between `types` and `[` [INFO] [stdout] 43 | pub equals: Token![=], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 44 | /// The brackets for the type mappings. [INFO] [stdout] 45 | pub bracket: Bracket, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `arrow` is never read [INFO] [stdout] --> src/parsing.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct AllowedTypesMapping { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 69 | pub arrow: Token![=>], [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/generator.rs:97:71 [INFO] [stdout] | [INFO] [stdout] 97 | let sig_doc = format!("**Signature:** `{}`", sig.to_token_stream().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/extractor.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | / if mac.mac.path.is_ident("allowed_types") { [INFO] [stdout] 88 | | if allowed_types.is_some() { [INFO] [stdout] 89 | | return Err(Error::new_spanned( [INFO] [stdout] 90 | | &mac.mac.path, [INFO] [stdout] ... | [INFO] [stdout] 96 | | items.remove(i); [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 86 ~ Item::Macro(mac) [INFO] [stdout] 87 ~ if mac.mac.path.is_ident("allowed_types") => { [INFO] [stdout] 88 | if allowed_types.is_some() { [INFO] [stdout] ... [INFO] [stdout] 96 | items.remove(i); [INFO] [stdout] 97 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/extractor.rs:179:20 [INFO] [stdout] | [INFO] [stdout] 179 | if !res.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `res.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extractor.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | / return Err(Error::new( [INFO] [stdout] 218 | | recv.self_token.span, [INFO] [stdout] 219 | | "microcode funcs must be free functions, not associated functions", [INFO] [stdout] 220 | | )); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 ~ Err(Error::new( [INFO] [stdout] 218 + recv.self_token.span, [INFO] [stdout] 219 + "microcode funcs must be free functions, not associated functions", [INFO] [stdout] 220 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/generator.rs:200:15 [INFO] [stdout] | [INFO] [stdout] 200 | let doc = format!("Provides descriptive informaton about an instruction from the microcode."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Provides descriptive informaton about an instruction from the microcode.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/generator.rs:97:71 [INFO] [stdout] | [INFO] [stdout] 97 | let sig_doc = format!("**Signature:** `{}`", sig.to_token_stream().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/generator.rs:349:30 [INFO] [stdout] | [INFO] [stdout] 349 | fn rust_type_to_allowed_type<'a, 'b>( [INFO] [stdout] | ^^ [INFO] [stdout] 350 | rust_type: &'a Type, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 349 ~ fn rust_type_to_allowed_type<'b>( [INFO] [stdout] 350 ~ rust_type: &Type, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/generator.rs:200:15 [INFO] [stdout] | [INFO] [stdout] 200 | let doc = format!("Provides descriptive informaton about an instruction from the microcode."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Provides descriptive informaton about an instruction from the microcode.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/generator.rs:349:30 [INFO] [stdout] | [INFO] [stdout] 349 | fn rust_type_to_allowed_type<'a, 'b>( [INFO] [stdout] | ^^ [INFO] [stdout] 350 | rust_type: &'a Type, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 349 ~ fn rust_type_to_allowed_type<'b>( [INFO] [stdout] 350 ~ rust_type: &Type, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.19s [INFO] running `Command { std: "docker" "inspect" "6e11306cf5158e9f17c47d029584af2556fa5185b7c92fcfb9548175dd520819", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e11306cf5158e9f17c47d029584af2556fa5185b7c92fcfb9548175dd520819", kill_on_drop: false }` [INFO] [stdout] 6e11306cf5158e9f17c47d029584af2556fa5185b7c92fcfb9548175dd520819