[INFO] fetching crate faster-stun 1.0.2...
[INFO] linting faster-stun-1.0.2 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate faster-stun 1.0.2 into /workspace/builds/worker-6-tc1/source
[INFO] started tweaking crates.io crate faster-stun 1.0.2
[INFO] finished tweaking crates.io crate faster-stun 1.0.2
[INFO] tweaked toml for crates.io crate faster-stun 1.0.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate faster-stun 1.0.2 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]      Locking 85 packages to latest compatible versions
[INFO] [stderr]       Adding criterion v0.5.1 (available: v0.8.2)
[INFO] [stderr]       Adding generic-array v0.14.7 (available: v0.14.9)
[INFO] [stderr]       Adding num_enum v0.6.1 (available: v0.7.6)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 16a5b79d19568f9f944e007158cc9a836a2c582383b920a3475ccbc76f04a945
[INFO] running `Command { std: "docker" "start" "-a" "16a5b79d19568f9f944e007158cc9a836a2c582383b920a3475ccbc76f04a945", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "16a5b79d19568f9f944e007158cc9a836a2c582383b920a3475ccbc76f04a945", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "16a5b79d19568f9f944e007158cc9a836a2c582383b920a3475ccbc76f04a945", kill_on_drop: false }`
[INFO] [stdout] 16a5b79d19568f9f944e007158cc9a836a2c582383b920a3475ccbc76f04a945
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 5f5e788935000e9344aaef01db0ae9993ad5a1299095583cca5a3226012b56ee
[INFO] running `Command { std: "docker" "start" "-a" "5f5e788935000e9344aaef01db0ae9993ad5a1299095583cca5a3226012b56ee", kill_on_drop: false }`
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]    Compiling num_enum_derive v0.6.1
[INFO] [stderr]     Checking criterion v0.5.1
[INFO] [stderr]     Checking hmac v0.12.1
[INFO] [stderr]     Checking md-5 v0.10.6
[INFO] [stderr]     Checking sha-1 v0.10.1
[INFO] [stderr]     Checking num_enum v0.6.1
[INFO] [stderr]     Checking faster-stun v1.0.2 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/address.rs:168:12
[INFO] [stdout]     |
[INFO] [stdout] 168 |         if !(packet.len() >= 4) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^ help: try: `(packet.len() < 4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/address.rs:202:8
[INFO] [stdout]     |
[INFO] [stdout] 202 |     if !(packet.len() == 8) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^ help: try: `(packet.len() != 8)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/address.rs:227:8
[INFO] [stdout]     |
[INFO] [stdout] 227 |     if !(packet.len() == 20) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^ help: try: `(packet.len() != 20)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/error.rs:173:12
[INFO] [stdout]     |
[INFO] [stdout] 173 |         if !(packet.len() >= 4) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^ help: try: `(packet.len() < 4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/error.rs:177:12
[INFO] [stdout]     |
[INFO] [stdout] 177 |         if !(util::as_u16(&packet[..2]) == 0x0000) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(util::as_u16(&packet[..2]) != 0x0000)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:158:9
[INFO] [stdout]     |
[INFO] [stdout] 158 |         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]     = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 158 -         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout] 158 +         std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:218:9
[INFO] [stdout]     |
[INFO] [stdout] 218 |         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 218 -         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout] 218 +         std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:247:9
[INFO] [stdout]     |
[INFO] [stdout] 247 |         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 247 -         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout] 247 +         std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:276:9
[INFO] [stdout]     |
[INFO] [stdout] 276 |         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 276 -         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout] 276 +         std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:614:9
[INFO] [stdout]     |
[INFO] [stdout] 614 |         Ok(Transport::try_from(buf[0]).map_err(|_| StunError::InvalidInput)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 614 -         Ok(Transport::try_from(buf[0]).map_err(|_| StunError::InvalidInput)?)
[INFO] [stdout] 614 +         Transport::try_from(buf[0]).map_err(|_| StunError::InvalidInput)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: doc list item without indentation
[INFO] [stdout]    --> src/attribute/mod.rs:630:5
[INFO] [stdout]     |
[INFO] [stdout] 630 | /// code for the CRC-32 in Section 8 of [RFC1952].
[INFO] [stdout]     |     ^
[INFO] [stdout]     |
[INFO] [stdout]     = help: if this is supposed to be its own paragraph, add a blank line
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
[INFO] [stdout]     = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
[INFO] [stdout] help: indent this line
[INFO] [stdout]     |
[INFO] [stdout] 630 | ///   code for the CRC-32 in Section 8 of [RFC1952].
[INFO] [stdout]     |     ++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/channel.rs:58:12
[INFO] [stdout]    |
[INFO] [stdout] 58 |         if !(buf.len() >= 4) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^ help: try: `(buf.len() < 4)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]   --> src/channel.rs:67:22
[INFO] [stdout]    |
[INFO] [stdout] 67 |         if is_tcp && (size % 4) > 0 {
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^ help: replace with: `!size.is_multiple_of(4)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout]    = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/channel.rs:90:12
[INFO] [stdout]    |
[INFO] [stdout] 90 |         if !(buf.len() >= 4) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^ help: try: `(buf.len() < 4)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/channel.rs:100:12
[INFO] [stdout]     |
[INFO] [stdout] 100 |         if !(size <= buf.len() - 4) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(size > buf.len() - 4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:316:35
[INFO] [stdout]     |
[INFO] [stdout] 316 |         if self.buf.is_empty() || !(self.valid_offset >= 20) {
[INFO] [stdout]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.valid_offset < 20)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/message.rs:322:25
[INFO] [stdout]     |
[INFO] [stdout] 322 |           let integrity = self
[INFO] [stdout]     |  _________________________^
[INFO] [stdout] 323 | |             .get::<MessageIntegrity>()
[INFO] [stdout] 324 | |             .ok_or_else(|| StunError::NotIntegrity)?;
[INFO] [stdout]     | |___________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 324 -             .ok_or_else(|| StunError::NotIntegrity)?;
[INFO] [stdout] 324 +             .ok_or(StunError::NotIntegrity)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:368:12
[INFO] [stdout]     |
[INFO] [stdout] 368 |         if !(buf.len() >= 20) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^ help: try: `(buf.len() < 20)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:382:12
[INFO] [stdout]     |
[INFO] [stdout] 382 |         if !(buf[4..8] == COOKIE[..]) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(buf[4..8] != COOKIE[..])`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:386:12
[INFO] [stdout]     |
[INFO] [stdout] 386 |         if !(count_size >= size) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^ help: try: `(count_size < size)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:471:12
[INFO] [stdout]     |
[INFO] [stdout] 471 |         if !(buf[0] >> 6 == 0) || !(buf.len() >= 20) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^ help: try: `(buf[0] >> 6 != 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:471:35
[INFO] [stdout]     |
[INFO] [stdout] 471 |         if !(buf[0] >> 6 == 0) || !(buf.len() >= 20) {
[INFO] [stdout]     |                                   ^^^^^^^^^^^^^^^^^^ help: try: `(buf.len() < 20)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: transmute used without annotations
[INFO] [stdout]    --> src/lib.rs:341:36
[INFO] [stdout]     |
[INFO] [stdout] 341 |                 unsafe { std::mem::transmute(buf) },
[INFO] [stdout]     |                                    ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&[u8], &[u8]>`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
[INFO] [stdout]     = note: `#[warn(clippy::missing_transmute_annotations)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/address.rs:168:12
[INFO] [stdout]     |
[INFO] [stdout] 168 |         if !(packet.len() >= 4) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^ help: try: `(packet.len() < 4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/address.rs:202:8
[INFO] [stdout]     |
[INFO] [stdout] 202 |     if !(packet.len() == 8) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^ help: try: `(packet.len() != 8)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/address.rs:227:8
[INFO] [stdout]     |
[INFO] [stdout] 227 |     if !(packet.len() == 20) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^ help: try: `(packet.len() != 20)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/error.rs:173:12
[INFO] [stdout]     |
[INFO] [stdout] 173 |         if !(packet.len() >= 4) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^ help: try: `(packet.len() < 4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/attribute/error.rs:177:12
[INFO] [stdout]     |
[INFO] [stdout] 177 |         if !(util::as_u16(&packet[..2]) == 0x0000) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(util::as_u16(&packet[..2]) != 0x0000)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:158:9
[INFO] [stdout]     |
[INFO] [stdout] 158 |         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]     = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 158 -         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout] 158 +         std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:218:9
[INFO] [stdout]     |
[INFO] [stdout] 218 |         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 218 -         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout] 218 +         std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:247:9
[INFO] [stdout]     |
[INFO] [stdout] 247 |         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 247 -         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout] 247 +         std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:276:9
[INFO] [stdout]     |
[INFO] [stdout] 276 |         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 276 -         Ok(std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)?)
[INFO] [stdout] 276 +         std::str::from_utf8(buf).map_err(|_| StunError::Utf8Error)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/attribute/mod.rs:614:9
[INFO] [stdout]     |
[INFO] [stdout] 614 |         Ok(Transport::try_from(buf[0]).map_err(|_| StunError::InvalidInput)?)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 614 -         Ok(Transport::try_from(buf[0]).map_err(|_| StunError::InvalidInput)?)
[INFO] [stdout] 614 +         Transport::try_from(buf[0]).map_err(|_| StunError::InvalidInput)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: doc list item without indentation
[INFO] [stdout]    --> src/attribute/mod.rs:630:5
[INFO] [stdout]     |
[INFO] [stdout] 630 | /// code for the CRC-32 in Section 8 of [RFC1952].
[INFO] [stdout]     |     ^
[INFO] [stdout]     |
[INFO] [stdout]     = help: if this is supposed to be its own paragraph, add a blank line
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
[INFO] [stdout]     = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
[INFO] [stdout] help: indent this line
[INFO] [stdout]     |
[INFO] [stdout] 630 | ///   code for the CRC-32 in Section 8 of [RFC1952].
[INFO] [stdout]     |     ++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/channel.rs:58:12
[INFO] [stdout]    |
[INFO] [stdout] 58 |         if !(buf.len() >= 4) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^ help: try: `(buf.len() < 4)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]   --> src/channel.rs:67:22
[INFO] [stdout]    |
[INFO] [stdout] 67 |         if is_tcp && (size % 4) > 0 {
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^ help: replace with: `!size.is_multiple_of(4)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout]    = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/channel.rs:90:12
[INFO] [stdout]    |
[INFO] [stdout] 90 |         if !(buf.len() >= 4) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^ help: try: `(buf.len() < 4)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/channel.rs:100:12
[INFO] [stdout]     |
[INFO] [stdout] 100 |         if !(size <= buf.len() - 4) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(size > buf.len() - 4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:316:35
[INFO] [stdout]     |
[INFO] [stdout] 316 |         if self.buf.is_empty() || !(self.valid_offset >= 20) {
[INFO] [stdout]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.valid_offset < 20)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/message.rs:322:25
[INFO] [stdout]     |
[INFO] [stdout] 322 |           let integrity = self
[INFO] [stdout]     |  _________________________^
[INFO] [stdout] 323 | |             .get::<MessageIntegrity>()
[INFO] [stdout] 324 | |             .ok_or_else(|| StunError::NotIntegrity)?;
[INFO] [stdout]     | |___________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 324 -             .ok_or_else(|| StunError::NotIntegrity)?;
[INFO] [stdout] 324 +             .ok_or(StunError::NotIntegrity)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:368:12
[INFO] [stdout]     |
[INFO] [stdout] 368 |         if !(buf.len() >= 20) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^ help: try: `(buf.len() < 20)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:382:12
[INFO] [stdout]     |
[INFO] [stdout] 382 |         if !(buf[4..8] == COOKIE[..]) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(buf[4..8] != COOKIE[..])`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:386:12
[INFO] [stdout]     |
[INFO] [stdout] 386 |         if !(count_size >= size) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^ help: try: `(count_size < size)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:471:12
[INFO] [stdout]     |
[INFO] [stdout] 471 |         if !(buf[0] >> 6 == 0) || !(buf.len() >= 20) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^ help: try: `(buf[0] >> 6 != 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/message.rs:471:35
[INFO] [stdout]     |
[INFO] [stdout] 471 |         if !(buf[0] >> 6 == 0) || !(buf.len() >= 20) {
[INFO] [stdout]     |                                   ^^^^^^^^^^^^^^^^^^ help: try: `(buf.len() < 20)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: transmute used without annotations
[INFO] [stdout]    --> src/lib.rs:341:36
[INFO] [stdout]     |
[INFO] [stdout] 341 |                 unsafe { std::mem::transmute(buf) },
[INFO] [stdout]     |                                    ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&[u8], &[u8]>`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
[INFO] [stdout]     = note: `#[warn(clippy::missing_transmute_annotations)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.95s
[INFO] running `Command { std: "docker" "inspect" "5f5e788935000e9344aaef01db0ae9993ad5a1299095583cca5a3226012b56ee", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5f5e788935000e9344aaef01db0ae9993ad5a1299095583cca5a3226012b56ee", kill_on_drop: false }`
[INFO] [stdout] 5f5e788935000e9344aaef01db0ae9993ad5a1299095583cca5a3226012b56ee