[INFO] fetching crate fast_hamming 0.1.0... [INFO] linting fast_hamming-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate fast_hamming 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate fast_hamming 0.1.0 [INFO] finished tweaking crates.io crate fast_hamming 0.1.0 [INFO] tweaked toml for crates.io crate fast_hamming 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate fast_hamming 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c917955238324097831508efc80df977bb5848add5199009f9450a25dc2a29a3 [INFO] running `Command { std: "docker" "start" "-a" "c917955238324097831508efc80df977bb5848add5199009f9450a25dc2a29a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c917955238324097831508efc80df977bb5848add5199009f9450a25dc2a29a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c917955238324097831508efc80df977bb5848add5199009f9450a25dc2a29a3", kill_on_drop: false }` [INFO] [stdout] c917955238324097831508efc80df977bb5848add5199009f9450a25dc2a29a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 47258ffda3e96bc5b15c969c34219ec22d81b9ac6c3752bde4888bca522ce601 [INFO] running `Command { std: "docker" "start" "-a" "47258ffda3e96bc5b15c969c34219ec22d81b9ac6c3752bde4888bca522ce601", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Checking fast_hamming v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | p1 = p1 ^ (i as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `p1 ^= (i as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/lib.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / for i in 0..input.len() - 1 { [INFO] [stdout] 76 | | output[i] = input[i].clone(); [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `output[..(input.len() - 1)].copy_from_slice(&input[..(input.len() - 1)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | output[i] = input[i].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 95 | if j % 8 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `j.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | p1 = p1 ^ (i as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `p1 ^= (i as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | p2 = p2 % 8; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `p2 %= 8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | return 7 - v.leading_zeros() as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return 7 - v.leading_zeros() as u8; [INFO] [stdout] 141 + 7 - v.leading_zeros() as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:161:5 [INFO] [stdout] | [INFO] [stdout] 161 | return p as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - return p as u8; [INFO] [stdout] 161 + p as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | let mut p = input.clone() as u32; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | p = p & 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `p &= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | p1 = p1 ^ (i as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `p1 ^= (i as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/lib.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / for i in 0..input.len() - 1 { [INFO] [stdout] 76 | | output[i] = input[i].clone(); [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `output[..(input.len() - 1)].copy_from_slice(&input[..(input.len() - 1)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | output[i] = input[i].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 95 | if j % 8 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `j.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | p1 = p1 ^ (i as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `p1 ^= (i as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | p2 = p2 % 8; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `p2 %= 8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | return 7 - v.leading_zeros() as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return 7 - v.leading_zeros() as u8; [INFO] [stdout] 141 + 7 - v.leading_zeros() as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:161:5 [INFO] [stdout] | [INFO] [stdout] 161 | return p as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - return p as u8; [INFO] [stdout] 161 + p as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | let mut p = input.clone() as u32; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | p = p & 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `p &= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return flip_idx; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return flip_idx; [INFO] [stdout] 185 + flip_idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | let decoded_data: [u8; 15]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 207 | decoded_data = decode_block(&encoded_data).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `decoded_data` here [INFO] [stdout] | [INFO] [stdout] 204 ~ [INFO] [stdout] 205 | encoded_data = encode_block(&original_data); [INFO] [stdout] 206 | let flipped_bit_idx = flip_random_bit(&mut encoded_data); [INFO] [stdout] 207 ~ let decoded_data: [u8; 15] = decode_block(&encoded_data).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 244 | if !(bit_idx1 == bit_idx2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bit_idx1 != bit_idx2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.34s [INFO] running `Command { std: "docker" "inspect" "47258ffda3e96bc5b15c969c34219ec22d81b9ac6c3752bde4888bca522ce601", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47258ffda3e96bc5b15c969c34219ec22d81b9ac6c3752bde4888bca522ce601", kill_on_drop: false }` [INFO] [stdout] 47258ffda3e96bc5b15c969c34219ec22d81b9ac6c3752bde4888bca522ce601