[INFO] fetching crate fakelish 0.1.2... [INFO] linting fakelish-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate fakelish 0.1.2 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate fakelish 0.1.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate fakelish 0.1.2 [INFO] tweaked toml for crates.io crate fakelish 0.1.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate fakelish 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate fakelish 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4a1c1055945c5b80ac47aca1d195d32b137b8f44304bb20dd60acd06a3ee5c4 [INFO] running `Command { std: "docker" "start" "-a" "e4a1c1055945c5b80ac47aca1d195d32b137b8f44304bb20dd60acd06a3ee5c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4a1c1055945c5b80ac47aca1d195d32b137b8f44304bb20dd60acd06a3ee5c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4a1c1055945c5b80ac47aca1d195d32b137b8f44304bb20dd60acd06a3ee5c4", kill_on_drop: false }` [INFO] [stdout] e4a1c1055945c5b80ac47aca1d195d32b137b8f44304bb20dd60acd06a3ee5c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3011c7bdd018441c7bb16d804fd12c6e5966054523155c23b7bb2e21c50c99bc [INFO] running `Command { std: "docker" "start" "-a" "3011c7bdd018441c7bb16d804fd12c6e5966054523155c23b7bb2e21c50c99bc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Compiling syn v2.0.94 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_json v1.0.134 [INFO] [stderr] Checking fakelish v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | /// let mut generate = WordGenerator::new(6, 9, 4); [INFO] [stdout] | ^^^^^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 27 | /// let word: String = generate.word(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | /// let words: Vec = generate.phrase(6); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if !record.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `record.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `record` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 60 | if !record.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 61 | probabilities = record.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:57:10 [INFO] [stdout] | [INFO] [stdout] 57 | while probabilities.len() == 0 && c < chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `probabilities.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 69 | let probability = p.1.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `p.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | serde_json::from_str::(&JSON) [INFO] [stdout] | ^^^^^ help: change this to: `JSON` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | /// let mut generate = WordGenerator::new(6, 9, 4); [INFO] [stdout] | ^^^^^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 27 | /// let word: String = generate.word(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | /// let words: Vec = generate.phrase(6); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if !record.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `record.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `record` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 60 | if !record.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 61 | probabilities = record.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:57:10 [INFO] [stdout] | [INFO] [stdout] 57 | while probabilities.len() == 0 && c < chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `probabilities.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 69 | let probability = p.1.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `p.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | serde_json::from_str::(&JSON) [INFO] [stdout] | ^^^^^ help: change this to: `JSON` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.39s [INFO] running `Command { std: "docker" "inspect" "3011c7bdd018441c7bb16d804fd12c6e5966054523155c23b7bb2e21c50c99bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3011c7bdd018441c7bb16d804fd12c6e5966054523155c23b7bb2e21c50c99bc", kill_on_drop: false }` [INFO] [stdout] 3011c7bdd018441c7bb16d804fd12c6e5966054523155c23b7bb2e21c50c99bc