[INFO] fetching crate f64ad_core 0.0.5... [INFO] linting f64ad_core-0.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate f64ad_core 0.0.5 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate f64ad_core 0.0.5 [INFO] finished tweaking crates.io crate f64ad_core 0.0.5 [INFO] tweaked toml for crates.io crate f64ad_core 0.0.5 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate f64ad_core 0.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding jemallocator v0.3.2 (available: v0.5.4) [INFO] [stderr] Adding nalgebra v0.31.4 (available: v0.34.1) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] [stderr] Adding simba v0.7.3 (available: v0.9.1) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jemallocator v0.3.2 [INFO] [stderr] Downloaded timeit v0.1.2 [INFO] [stderr] Downloaded jemalloc-sys v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4d78659aa6ead3d6d9f498c546122c4bd3de29361f29fd1577a521287f6e425 [INFO] running `Command { std: "docker" "start" "-a" "c4d78659aa6ead3d6d9f498c546122c4bd3de29361f29fd1577a521287f6e425", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4d78659aa6ead3d6d9f498c546122c4bd3de29361f29fd1577a521287f6e425", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4d78659aa6ead3d6d9f498c546122c4bd3de29361f29fd1577a521287f6e425", kill_on_drop: false }` [INFO] [stdout] c4d78659aa6ead3d6d9f498c546122c4bd3de29361f29fd1577a521287f6e425 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 09e13ce06e0d77746ec05807ec4d6dae348ad8ff6a77e7326e2602011c4f2f5e [INFO] running `Command { std: "docker" "start" "-a" "09e13ce06e0d77746ec05807ec4d6dae348ad8ff6a77e7326e2602011c4f2f5e", kill_on_drop: false }` [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling libmimalloc-sys v0.1.44 [INFO] [stderr] Compiling jemalloc-sys v0.3.2 [INFO] [stderr] Checking timeit v0.1.2 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking mimalloc v0.1.48 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking nalgebra v0.31.4 [INFO] [stderr] Checking jemallocator v0.3.2 [INFO] [stderr] Checking f64ad_core v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | #[cfg_attr(feature = "inline_on", inline)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_always_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | #[cfg_attr(feature = "inline_always_on", inline(always))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_always_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg_attr(feature = "inline_on", inline)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_always_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | #[cfg_attr(feature = "inline_always_on", inline(always))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_always_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | #[cfg_attr(feature = "inline_on", inline)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_always_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | #[cfg_attr(feature = "inline_always_on", inline(always))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_always_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 36 | #[cfg_attr(feature = "inline_on", inline)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_always_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | #[cfg_attr(feature = "inline_always_on", inline(always))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_always_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | #[cfg_attr(feature = "inline_on", inline)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_always_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | #[cfg_attr(feature = "inline_always_on", inline(always))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_always_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg_attr(feature = "inline_on", inline)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_always_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | #[cfg_attr(feature = "inline_always_on", inline(always))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_always_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | #[cfg_attr(feature = "inline_on", inline)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_always_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | #[cfg_attr(feature = "inline_always_on", inline(always))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_always_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 36 | #[cfg_attr(feature = "inline_on", inline)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `inline_always_on` [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | #[cfg_attr(feature = "inline_always_on", inline(always))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `inline_always_on` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/f64ad/trait_impls/approx_impls.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / if diff.abs() < epsilon { [INFO] [stdout] 25 | | true [INFO] [stdout] 26 | | } else { [INFO] [stdout] 27 | | false [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `diff.abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/f64ad/trait_impls/approx_impls.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / if diff.abs() < epsilon { [INFO] [stdout] 40 | | true [INFO] [stdout] 41 | | } else { [INFO] [stdout] 42 | | false [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `diff.abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return f64ad::f64(0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return f64ad::f64(0.0); [INFO] [stdout] 8 + f64ad::f64(0.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return self.value() == 0.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return self.value() == 0.0; [INFO] [stdout] 14 + self.value() == 0.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / return if *self <= *other { [INFO] [stdout] 44 | | f64ad::f64(0.0) [INFO] [stdout] 45 | | } else { [INFO] [stdout] 46 | | *self - *other [INFO] [stdout] 47 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ if *self <= *other { [INFO] [stdout] 44 + f64ad::f64(0.0) [INFO] [stdout] 45 + } else { [INFO] [stdout] 46 + *self - *other [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return self.value() > 0.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return self.value() > 0.0; [INFO] [stdout] 55 + self.value() > 0.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return self.value() < 0.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return self.value() < 0.0; [INFO] [stdout] 59 + self.value() < 0.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return self.is_positive(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return self.is_positive(); [INFO] [stdout] 8 + self.is_positive() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return self.is_negative(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return self.is_negative(); [INFO] [stdout] 12 + self.is_negative() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / return if sign.is_positive() { [INFO] [stdout] 17 | | self.abs() [INFO] [stdout] 18 | | } else { [INFO] [stdout] 19 | | -self.abs() [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ if sign.is_positive() { [INFO] [stdout] 17 + self.abs() [INFO] [stdout] 18 + } else { [INFO] [stdout] 19 + -self.abs() [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.max(min).min(max); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.max(min).min(max); [INFO] [stdout] 33 + self.max(min).min(max) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:112:49 [INFO] [stdout] | [INFO] [stdout] 112 | fn from_real(re: Self::RealField) -> Self { re.clone() } [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `re` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:114:58 [INFO] [stdout] | [INFO] [stdout] 114 | fn real(self) -> ::RealField { self.clone() } [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:118:43 [INFO] [stdout] | [INFO] [stdout] 118 | fn modulus(self) -> Self::RealField { return self.abs(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - fn modulus(self) -> Self::RealField { return self.abs(); } [INFO] [stdout] 118 + fn modulus(self) -> Self::RealField { self.abs()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:124:41 [INFO] [stdout] | [INFO] [stdout] 124 | fn norm1(self) -> Self::RealField { return self.abs(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - fn norm1(self) -> Self::RealField { return self.abs(); } [INFO] [stdout] 124 + fn norm1(self) -> Self::RealField { self.abs()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:126:55 [INFO] [stdout] | [INFO] [stdout] 126 | fn scale(self, factor: Self::RealField) -> Self { return self * factor; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - fn scale(self, factor: Self::RealField) -> Self { return self * factor; } [INFO] [stdout] 126 + fn scale(self, factor: Self::RealField) -> Self { self * factor} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:128:57 [INFO] [stdout] | [INFO] [stdout] 128 | fn unscale(self, factor: Self::RealField) -> Self { return self / factor; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - fn unscale(self, factor: Self::RealField) -> Self { return self / factor; } [INFO] [stdout] 128 + fn unscale(self, factor: Self::RealField) -> Self { self / factor} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:150:50 [INFO] [stdout] | [INFO] [stdout] 150 | fn mul_add(self, a: Self, b: Self) -> Self { return (self * a) + b; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - fn mul_add(self, a: Self, b: Self) -> Self { return (self * a) + b; } [INFO] [stdout] 150 + fn mul_add(self, a: Self, b: Self) -> Self { (self * a) + b} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return (self.powi(2) + other.powi(2)).sqrt(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return (self.powi(2) + other.powi(2)).sqrt(); [INFO] [stdout] 157 + (self.powi(2) + other.powi(2)).sqrt() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:160:30 [INFO] [stdout] | [INFO] [stdout] 160 | fn recip(self) -> Self { return 1.0 / self; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - fn recip(self) -> Self { return 1.0 / self; } [INFO] [stdout] 160 + fn recip(self) -> Self { 1.0 / self} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:162:34 [INFO] [stdout] | [INFO] [stdout] 162 | fn conjugate(self) -> Self { return self; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - fn conjugate(self) -> Self { return self; } [INFO] [stdout] 162 + fn conjugate(self) -> Self { self} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | return (self.sin(), self.cos()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 173 - return (self.sin(), self.cos()); [INFO] [stdout] 173 + (self.sin(), self.cos()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:210:29 [INFO] [stdout] | [INFO] [stdout] 210 | fn log2(self) -> Self { return self.log(f64ad::f64(2.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - fn log2(self) -> Self { return self.log(f64ad::f64(2.0)); } [INFO] [stdout] 210 + fn log2(self) -> Self { self.log(f64ad::f64(2.0))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:212:30 [INFO] [stdout] | [INFO] [stdout] 212 | fn log10(self) -> Self { return self.log(f64ad::f64(10.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - fn log10(self) -> Self { return self.log(f64ad::f64(10.0)); } [INFO] [stdout] 212 + fn log10(self) -> Self { self.log(f64ad::f64(10.0))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:214:27 [INFO] [stdout] | [INFO] [stdout] 214 | fn ln(self) -> Self { return self.log(f64ad::f64(std::f64::consts::E)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - fn ln(self) -> Self { return self.log(f64ad::f64(std::f64::consts::E)); } [INFO] [stdout] 214 + fn ln(self) -> Self { self.log(f64ad::f64(std::f64::consts::E))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:224:31 [INFO] [stdout] | [INFO] [stdout] 224 | fn exp_m1(self) -> Self { return self.exp() - 1.0; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - fn exp_m1(self) -> Self { return self.exp() - 1.0; } [INFO] [stdout] 224 + fn exp_m1(self) -> Self { self.exp() - 1.0} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:226:37 [INFO] [stdout] | [INFO] [stdout] 226 | fn powi(self, n: i32) -> Self { return self.powf(f64ad::f64(n as f64)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 226 - fn powi(self, n: i32) -> Self { return self.powf(f64ad::f64(n as f64)); } [INFO] [stdout] 226 + fn powi(self, n: i32) -> Self { self.powf(f64ad::f64(n as f64))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:230:38 [INFO] [stdout] | [INFO] [stdout] 230 | fn powc(self, n: Self) -> Self { return self.powf(n); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - fn powc(self, n: Self) -> Self { return self.powf(n); } [INFO] [stdout] 230 + fn powc(self, n: Self) -> Self { self.powf(n)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:232:29 [INFO] [stdout] | [INFO] [stdout] 232 | fn cbrt(self) -> Self { return self.powf(f64ad::f64(1.0 / 3.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 - fn cbrt(self) -> Self { return self.powf(f64ad::f64(1.0 / 3.0)); } [INFO] [stdout] 232 + fn cbrt(self) -> Self { self.powf(f64ad::f64(1.0 / 3.0))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:234:35 [INFO] [stdout] | [INFO] [stdout] 234 | fn is_finite(&self) -> bool { return self.value().is_finite(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - fn is_finite(&self) -> bool { return self.value().is_finite(); } [INFO] [stdout] 234 + fn is_finite(&self) -> bool { self.value().is_finite()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | self.clone() [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | element.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*element` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:275:20 [INFO] [stdout] | [INFO] [stdout] 275 | f64ad::f64(*self as f64) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(*self)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/f64ad/f64ad_var_1_mod.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 78 | / let ret = f64ad::f64ad_var_1(f64ad_var_1 { [INFO] [stdout] 79 | | computation_graph_id: self.computation_graph_id, [INFO] [stdout] 80 | | node_idx, [INFO] [stdout] 81 | | computation_graph [INFO] [stdout] 82 | | }); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 83 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 78 ~ [INFO] [stdout] 79 ~ f64ad::f64ad_var_1(f64ad_var_1 { [INFO] [stdout] 80 + computation_graph_id: self.computation_graph_id, [INFO] [stdout] 81 + node_idx, [INFO] [stdout] 82 + computation_graph [INFO] [stdout] 83 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/f64ad_var_f_mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / return f64ad::f64ad_var_f(f64ad_var_f { [INFO] [stdout] 72 | | computation_graph_id: self.computation_graph_id, [INFO] [stdout] 73 | | node_idx, [INFO] [stdout] 74 | | computation_graph [INFO] [stdout] 75 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 ~ f64ad::f64ad_var_f(f64ad_var_f { [INFO] [stdout] 72 + computation_graph_id: self.computation_graph_id, [INFO] [stdout] 73 + node_idx, [INFO] [stdout] 74 + computation_graph [INFO] [stdout] 75 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/f64ad_var_l_mod.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 58 | let idx = self.count.borrow().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.count.borrow()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/f64ad_var_l_mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | b[idx].parent_0 = parent_0.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `parent_0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/f64ad_var_l_mod.rs:67:27 [INFO] [stdout] | [INFO] [stdout] 67 | b[idx].parent_1 = parent_1.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `parent_1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/f64ad/f64ad_var_t_mod.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 76 | / let ret = f64ad::f64ad_var_t(f64ad_var_t { [INFO] [stdout] 77 | | computation_graph_id: self.computation_graph_id, [INFO] [stdout] 78 | | node_idx, [INFO] [stdout] 79 | | computation_graph [INFO] [stdout] 80 | | }); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 81 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 76 ~ [INFO] [stdout] 77 ~ f64ad::f64ad_var_t(f64ad_var_t { [INFO] [stdout] 78 + computation_graph_id: self.computation_graph_id, [INFO] [stdout] 79 + node_idx, [INFO] [stdout] 80 + computation_graph [INFO] [stdout] 81 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return match self { [INFO] [stdout] 70 | | f64ad::f64(_) => { panic!("cannot compute gradient on f64.") } [INFO] [stdout] 71 | | f64ad::f64ad_var_1(_) => { [INFO] [stdout] 72 | | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] ... | [INFO] [stdout] 83 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ match self { [INFO] [stdout] 70 + f64ad::f64(_) => { panic!("cannot compute gradient on f64.") } [INFO] [stdout] 71 + f64ad::f64ad_var_1(_) => { [INFO] [stdout] 72 + assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 73 + f64ad_universal_forward_mode_grad(self.clone(), false) [INFO] [stdout] 74 + } [INFO] [stdout] 75 + f64ad::f64ad_var_f(_) => { [INFO] [stdout] 76 + f64ad_universal_forward_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] 77 + } [INFO] [stdout] 78 + f64ad::f64ad_var_t(_) => { panic!("cannot compute gradient on f64ad_var_t") } [INFO] [stdout] 79 + f64ad::f64ad_var_l(_) => { [INFO] [stdout] 80 + assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 81 + f64ad_universal_forward_mode_grad(self.clone(), false) [INFO] [stdout] 82 + } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/f64ad/mod.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 - assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 72 + assert!(!add_to_computation_graph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:73:51 [INFO] [stdout] | [INFO] [stdout] 73 | f64ad_universal_forward_mode_grad(self.clone(), false) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:76:51 [INFO] [stdout] | [INFO] [stdout] 76 | f64ad_universal_forward_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/f64ad/mod.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 80 + assert!(!add_to_computation_graph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | f64ad_universal_forward_mode_grad(self.clone(), false) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/f64ad/trait_impls/approx_impls.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / if diff.abs() < epsilon { [INFO] [stdout] 25 | | true [INFO] [stdout] 26 | | } else { [INFO] [stdout] 27 | | false [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `diff.abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / return match self { [INFO] [stdout] 87 | | f64ad::f64(_) => { panic!("cannot compute gradient on f64.") } [INFO] [stdout] 88 | | f64ad::f64ad_var_1(_) => { [INFO] [stdout] 89 | | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] ... | [INFO] [stdout] 100 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 ~ match self { [INFO] [stdout] 87 + f64ad::f64(_) => { panic!("cannot compute gradient on f64.") } [INFO] [stdout] 88 + f64ad::f64ad_var_1(_) => { [INFO] [stdout] 89 + assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 90 + f64ad_universal_backwards_mode_grad(self.clone(), false) [INFO] [stdout] 91 + } [INFO] [stdout] 92 + f64ad::f64ad_var_f(_) => { [INFO] [stdout] 93 + f64ad_universal_backwards_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] 94 + } [INFO] [stdout] 95 + f64ad::f64ad_var_t(_) => { panic!("cannot compute gradient on f64ad_var_t") } [INFO] [stdout] 96 + f64ad::f64ad_var_l(_) => { [INFO] [stdout] 97 + assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 98 + f64ad_universal_backwards_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] 99 + } [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/f64ad/mod.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 89 - assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 89 + assert!(!add_to_computation_graph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/f64ad/trait_impls/approx_impls.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / if diff.abs() < epsilon { [INFO] [stdout] 40 | | true [INFO] [stdout] 41 | | } else { [INFO] [stdout] 42 | | false [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `diff.abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:90:53 [INFO] [stdout] | [INFO] [stdout] 90 | f64ad_universal_backwards_mode_grad(self.clone(), false) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:93:53 [INFO] [stdout] | [INFO] [stdout] 93 | f64ad_universal_backwards_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/f64ad/mod.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 97 - assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 97 + assert!(!add_to_computation_graph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:98:53 [INFO] [stdout] | [INFO] [stdout] 98 | f64ad_universal_backwards_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return f64ad::f64(0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return f64ad::f64(0.0); [INFO] [stdout] 8 + f64ad::f64(0.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return self.value() == 0.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return self.value() == 0.0; [INFO] [stdout] 14 + self.value() == 0.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / return if *self <= *other { [INFO] [stdout] 44 | | f64ad::f64(0.0) [INFO] [stdout] 45 | | } else { [INFO] [stdout] 46 | | *self - *other [INFO] [stdout] 47 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ if *self <= *other { [INFO] [stdout] 44 + f64ad::f64(0.0) [INFO] [stdout] 45 + } else { [INFO] [stdout] 46 + *self - *other [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / return match self { [INFO] [stdout] 158 | | ComputationGraph::ComputationGraph1(c) => { [INFO] [stdout] 159 | | if c.borrow().paused() { [INFO] [stdout] 160 | | f64ad::f64(value) [INFO] [stdout] ... | [INFO] [stdout] 174 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ match self { [INFO] [stdout] 158 + ComputationGraph::ComputationGraph1(c) => { [INFO] [stdout] 159 + if c.borrow().paused() { [INFO] [stdout] 160 + f64ad::f64(value) [INFO] [stdout] 161 + } else { [INFO] [stdout] 162 + c.borrow().add_node(value, node_type_class, node_operands_mode, parent_0, parent_1, self) [INFO] [stdout] 163 + } [INFO] [stdout] 164 + } [INFO] [stdout] 165 + ComputationGraph::ComputationGraphF(c) => { [INFO] [stdout] 166 + c.borrow().add_node(value, node_type_class, node_operands_mode, parent_0, parent_1, self) [INFO] [stdout] 167 + } [INFO] [stdout] 168 + ComputationGraph::ComputationGraphT(c) => { [INFO] [stdout] 169 + c.borrow().add_node(value, node_type_class, node_operands_mode, parent_0, parent_1, self) [INFO] [stdout] 170 + } [INFO] [stdout] 171 + ComputationGraph::ComputationGraphL(c) => { [INFO] [stdout] 172 + c.borrow().add_node(value, node_type_class, node_operands_mode, parent_0, parent_1, self) [INFO] [stdout] 173 + } [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return self.value() > 0.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return self.value() > 0.0; [INFO] [stdout] 55 + self.value() > 0.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/num_trait_impls.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return self.value() < 0.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return self.value() < 0.0; [INFO] [stdout] 59 + self.value() < 0.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return self.is_positive(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return self.is_positive(); [INFO] [stdout] 8 + self.is_positive() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return self.is_negative(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return self.is_negative(); [INFO] [stdout] 12 + self.is_negative() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / return if sign.is_positive() { [INFO] [stdout] 17 | | self.abs() [INFO] [stdout] 18 | | } else { [INFO] [stdout] 19 | | -self.abs() [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ if sign.is_positive() { [INFO] [stdout] 17 + self.abs() [INFO] [stdout] 18 + } else { [INFO] [stdout] 19 + -self.abs() [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.max(min).min(max); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.max(min).min(max); [INFO] [stdout] 33 + self.max(min).min(max) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | / return match self { [INFO] [stdout] 213 | | ComputationGraph::ComputationGraph1(c) => { [INFO] [stdout] 214 | | let binding0 = c.borrow(); [INFO] [stdout] 215 | | let binding1 = binding0.computation_graph().borrow(); [INFO] [stdout] ... | [INFO] [stdout] 234 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 ~ match self { [INFO] [stdout] 213 + ComputationGraph::ComputationGraph1(c) => { [INFO] [stdout] 214 + let binding0 = c.borrow(); [INFO] [stdout] 215 + let binding1 = binding0.computation_graph().borrow(); [INFO] [stdout] 216 + let node = binding1.item(node_idx); [INFO] [stdout] 217 + ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] 218 + } [INFO] [stdout] 219 + ComputationGraph::ComputationGraphF(c) => { [INFO] [stdout] 220 + let binding0 = c.borrow(); [INFO] [stdout] 221 + let binding1 = binding0.computation_graph().borrow(); [INFO] [stdout] 222 + let node = binding1.item(node_idx); [INFO] [stdout] 223 + ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] 224 + } [INFO] [stdout] 225 + ComputationGraph::ComputationGraphT(_) => { [INFO] [stdout] 226 + unreachable!() [INFO] [stdout] 227 + } [INFO] [stdout] 228 + ComputationGraph::ComputationGraphL(c) => { [INFO] [stdout] 229 + let binding0 = c.borrow(); [INFO] [stdout] 230 + let binding1 = binding0.locked_nodes().borrow(); [INFO] [stdout] 231 + let node = &binding1[node_idx]; [INFO] [stdout] 232 + ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] 233 + } [INFO] [stdout] 234 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:217:19 [INFO] [stdout] | [INFO] [stdout] 217 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_0()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:217:44 [INFO] [stdout] | [INFO] [stdout] 217 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_1()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:223:19 [INFO] [stdout] | [INFO] [stdout] 223 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_0()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:223:44 [INFO] [stdout] | [INFO] [stdout] 223 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_1()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:232:19 [INFO] [stdout] | [INFO] [stdout] 232 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_0()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:232:44 [INFO] [stdout] | [INFO] [stdout] 232 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_1()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | return unsafe { (*self.0).spawn_variable(value) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 - return unsafe { (*self.0).spawn_variable(value) }; [INFO] [stdout] 309 + unsafe { (*self.0).spawn_variable(value) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | return unsafe { (*self.0).add_node(value, node_type_class, node_operands_mode, parent_0, parent_1) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 - return unsafe { (*self.0).add_node(value, node_type_class, node_operands_mode, parent_0, parent_1) }; [INFO] [stdout] 313 + unsafe { (*self.0).add_node(value, node_type_class, node_operands_mode, parent_0, parent_1) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:317:9 [INFO] [stdout] | [INFO] [stdout] 317 | return unsafe { (*self.0).get_node_value(node_idx) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 317 - return unsafe { (*self.0).get_node_value(node_idx) }; [INFO] [stdout] 317 + unsafe { (*self.0).get_node_value(node_idx) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | return unsafe { (*self.0).map_to_type() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 321 - return unsafe { (*self.0).map_to_type() }; [INFO] [stdout] 321 + unsafe { (*self.0).map_to_type() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | return unsafe { &(*self.0) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return unsafe { &(*self.0) } [INFO] [stdout] 325 + unsafe { &(*self.0) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | return unsafe { (*self.0).computation_graph_id() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - return unsafe { (*self.0).computation_graph_id() }; [INFO] [stdout] 329 + unsafe { (*self.0).computation_graph_id() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:112:49 [INFO] [stdout] | [INFO] [stdout] 112 | fn from_real(re: Self::RealField) -> Self { re.clone() } [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `re` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:114:58 [INFO] [stdout] | [INFO] [stdout] 114 | fn real(self) -> ::RealField { self.clone() } [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:118:43 [INFO] [stdout] | [INFO] [stdout] 118 | fn modulus(self) -> Self::RealField { return self.abs(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - fn modulus(self) -> Self::RealField { return self.abs(); } [INFO] [stdout] 118 + fn modulus(self) -> Self::RealField { self.abs()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:124:41 [INFO] [stdout] | [INFO] [stdout] 124 | fn norm1(self) -> Self::RealField { return self.abs(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - fn norm1(self) -> Self::RealField { return self.abs(); } [INFO] [stdout] 124 + fn norm1(self) -> Self::RealField { self.abs()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:126:55 [INFO] [stdout] | [INFO] [stdout] 126 | fn scale(self, factor: Self::RealField) -> Self { return self * factor; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - fn scale(self, factor: Self::RealField) -> Self { return self * factor; } [INFO] [stdout] 126 + fn scale(self, factor: Self::RealField) -> Self { self * factor} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:128:57 [INFO] [stdout] | [INFO] [stdout] 128 | fn unscale(self, factor: Self::RealField) -> Self { return self / factor; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - fn unscale(self, factor: Self::RealField) -> Self { return self / factor; } [INFO] [stdout] 128 + fn unscale(self, factor: Self::RealField) -> Self { self / factor} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:150:50 [INFO] [stdout] | [INFO] [stdout] 150 | fn mul_add(self, a: Self, b: Self) -> Self { return (self * a) + b; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - fn mul_add(self, a: Self, b: Self) -> Self { return (self * a) + b; } [INFO] [stdout] 150 + fn mul_add(self, a: Self, b: Self) -> Self { (self * a) + b} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:353:35 [INFO] [stdout] | [INFO] [stdout] 353 | parent_0: node.parent_0().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_0()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:354:35 [INFO] [stdout] | [INFO] [stdout] 354 | parent_1: node.parent_1().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_1()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/f64ad/mod.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 366 | let idx = match idx { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 367 | | None => { 0 } [INFO] [stdout] 368 | | Some(idx) => { idx } [INFO] [stdout] 369 | | }; [INFO] [stdout] | |_________^ help: replace it with: `idx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | return unsafe { (*self.0).reset() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 379 - return unsafe { (*self.0).reset() }; [INFO] [stdout] 379 + unsafe { (*self.0).reset() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return (self.powi(2) + other.powi(2)).sqrt(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return (self.powi(2) + other.powi(2)).sqrt(); [INFO] [stdout] 157 + (self.powi(2) + other.powi(2)).sqrt() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:160:30 [INFO] [stdout] | [INFO] [stdout] 160 | fn recip(self) -> Self { return 1.0 / self; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - fn recip(self) -> Self { return 1.0 / self; } [INFO] [stdout] 160 + fn recip(self) -> Self { 1.0 / self} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GenericComputationGraph` [INFO] [stdout] --> src/f64ad/mod.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 389 | / pub fn new() -> Self { [INFO] [stdout] 390 | | Self { [INFO] [stdout] 391 | | nodes: Vec::with_capacity(1_000_000), [INFO] [stdout] 392 | | curr_idx: 0, [INFO] [stdout] ... | [INFO] [stdout] 395 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 388 + impl Default for GenericComputationGraph { [INFO] [stdout] 389 + fn default() -> Self { [INFO] [stdout] 390 + Self::new() [INFO] [stdout] 391 + } [INFO] [stdout] 392 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:162:34 [INFO] [stdout] | [INFO] [stdout] 162 | fn conjugate(self) -> Self { return self; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - fn conjugate(self) -> Self { return self; } [INFO] [stdout] 162 + fn conjugate(self) -> Self { self} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | return (self.sin(), self.cos()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 173 - return (self.sin(), self.cos()); [INFO] [stdout] 173 + (self.sin(), self.cos()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | return &self.nodes[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - return &self.nodes[idx]; [INFO] [stdout] 423 + &self.nodes[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:210:29 [INFO] [stdout] | [INFO] [stdout] 210 | fn log2(self) -> Self { return self.log(f64ad::f64(2.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - fn log2(self) -> Self { return self.log(f64ad::f64(2.0)); } [INFO] [stdout] 210 + fn log2(self) -> Self { self.log(f64ad::f64(2.0))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/f64ad/mod.rs:429:40 [INFO] [stdout] | [INFO] [stdout] 429 | static mut _GLOBAL_COMPUTATION_GRAPHS: OnceCell>> = OnceCell... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:212:30 [INFO] [stdout] | [INFO] [stdout] 212 | fn log10(self) -> Self { return self.log(f64ad::f64(10.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - fn log10(self) -> Self { return self.log(f64ad::f64(10.0)); } [INFO] [stdout] 212 + fn log10(self) -> Self { self.log(f64ad::f64(10.0))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:214:27 [INFO] [stdout] | [INFO] [stdout] 214 | fn ln(self) -> Self { return self.log(f64ad::f64(std::f64::consts::E)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - fn ln(self) -> Self { return self.log(f64ad::f64(std::f64::consts::E)); } [INFO] [stdout] 214 + fn ln(self) -> Self { self.log(f64ad::f64(std::f64::consts::E))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | return Self::get_internal(name, idx, ComputationGraphType::ComputationGraphF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - return Self::get_internal(name, idx, ComputationGraphType::ComputationGraphF); [INFO] [stdout] 439 + Self::get_internal(name, idx, ComputationGraphType::ComputationGraphF) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:456:9 [INFO] [stdout] | [INFO] [stdout] 456 | / return match res { [INFO] [stdout] 457 | | None => { [INFO] [stdout] 458 | | binding.insert((name.clone(), idx, computation_graph_type), ComputationGraph::new(computation_graph_type)); [INFO] [stdout] 459 | | drop(binding); [INFO] [stdout] ... | [INFO] [stdout] 466 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 ~ match res { [INFO] [stdout] 457 + None => { [INFO] [stdout] 458 + binding.insert((name.clone(), idx, computation_graph_type), ComputationGraph::new(computation_graph_type)); [INFO] [stdout] 459 + drop(binding); [INFO] [stdout] 460 + Self::get_internal(Some(&name), Some(idx), computation_graph_type) [INFO] [stdout] 461 + } [INFO] [stdout] 462 + Some(computation_graph) => { [INFO] [stdout] 463 + let r: *const ComputationGraph = computation_graph; [INFO] [stdout] 464 + return GlobalComputationGraph(r); [INFO] [stdout] 465 + } [INFO] [stdout] 466 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:224:31 [INFO] [stdout] | [INFO] [stdout] 224 | fn exp_m1(self) -> Self { return self.exp() - 1.0; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - fn exp_m1(self) -> Self { return self.exp() - 1.0; } [INFO] [stdout] 224 + fn exp_m1(self) -> Self { self.exp() - 1.0} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:226:37 [INFO] [stdout] | [INFO] [stdout] 226 | fn powi(self, n: i32) -> Self { return self.powf(f64ad::f64(n as f64)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 226 - fn powi(self, n: i32) -> Self { return self.powf(f64ad::f64(n as f64)); } [INFO] [stdout] 226 + fn powi(self, n: i32) -> Self { self.powf(f64ad::f64(n as f64))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/f64ad/mod.rs:448:19 [INFO] [stdout] | [INFO] [stdout] 448 | let idx = match idx { [INFO] [stdout] | ___________________^ [INFO] [stdout] 449 | | None => { 0 } [INFO] [stdout] 450 | | Some(idx) => { idx } [INFO] [stdout] 451 | | }; [INFO] [stdout] | |_________^ help: replace it with: `idx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:230:38 [INFO] [stdout] | [INFO] [stdout] 230 | fn powc(self, n: Self) -> Self { return self.powf(n); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - fn powc(self, n: Self) -> Self { return self.powf(n); } [INFO] [stdout] 230 + fn powc(self, n: Self) -> Self { self.powf(n)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:232:29 [INFO] [stdout] | [INFO] [stdout] 232 | fn cbrt(self) -> Self { return self.powf(f64ad::f64(1.0 / 3.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 - fn cbrt(self) -> Self { return self.powf(f64ad::f64(1.0 / 3.0)); } [INFO] [stdout] 232 + fn cbrt(self) -> Self { self.powf(f64ad::f64(1.0 / 3.0))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:234:35 [INFO] [stdout] | [INFO] [stdout] 234 | fn is_finite(&self) -> bool { return self.value().is_finite(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - fn is_finite(&self) -> bool { return self.value().is_finite(); } [INFO] [stdout] 234 + fn is_finite(&self) -> bool { self.value().is_finite()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:504:5 [INFO] [stdout] | [INFO] [stdout] 504 | return BackwardsModeGradOutput { derivs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 504 - return BackwardsModeGradOutput { derivs }; [INFO] [stdout] 504 + BackwardsModeGradOutput { derivs } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | self.clone() [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | element.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*element` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/f64ad/trait_impls/simba_impls.rs:275:20 [INFO] [stdout] | [INFO] [stdout] 275 | f64ad::f64(*self as f64) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(*self)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:540:5 [INFO] [stdout] | [INFO] [stdout] 540 | return ForwardModeGradOutput { derivs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 540 - return ForwardModeGradOutput { derivs }; [INFO] [stdout] 540 + ForwardModeGradOutput { derivs } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:544:5 [INFO] [stdout] | [INFO] [stdout] 544 | return if !add_to_computation_graph { f64ad::f64(v.value()) } else { v }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 544 - return if !add_to_computation_graph { f64ad::f64(v.value()) } else { v }; [INFO] [stdout] 544 + if !add_to_computation_graph { f64ad::f64(v.value()) } else { v } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 553 | return self.derivs[output.node_idx() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 553 - return self.derivs[output.node_idx() as usize]; [INFO] [stdout] 553 + self.derivs[output.node_idx() as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/f64ad/f64ad_var_1_mod.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 78 | / let ret = f64ad::f64ad_var_1(f64ad_var_1 { [INFO] [stdout] 79 | | computation_graph_id: self.computation_graph_id, [INFO] [stdout] 80 | | node_idx, [INFO] [stdout] 81 | | computation_graph [INFO] [stdout] 82 | | }); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 83 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 78 ~ [INFO] [stdout] 79 ~ f64ad::f64ad_var_1(f64ad_var_1 { [INFO] [stdout] 80 + computation_graph_id: self.computation_graph_id, [INFO] [stdout] 81 + node_idx, [INFO] [stdout] 82 + computation_graph [INFO] [stdout] 83 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/f64ad_var_f_mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / return f64ad::f64ad_var_f(f64ad_var_f { [INFO] [stdout] 72 | | computation_graph_id: self.computation_graph_id, [INFO] [stdout] 73 | | node_idx, [INFO] [stdout] 74 | | computation_graph [INFO] [stdout] 75 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 ~ f64ad::f64ad_var_f(f64ad_var_f { [INFO] [stdout] 72 + computation_graph_id: self.computation_graph_id, [INFO] [stdout] 73 + node_idx, [INFO] [stdout] 74 + computation_graph [INFO] [stdout] 75 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/f64ad/mod.rs:553:28 [INFO] [stdout] | [INFO] [stdout] 553 | return self.derivs[output.node_idx() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `output.node_idx()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:563:9 [INFO] [stdout] | [INFO] [stdout] 563 | return self.derivs[input.node_idx() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 563 - return self.derivs[input.node_idx() as usize]; [INFO] [stdout] 563 + self.derivs[input.node_idx() as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/f64ad/mod.rs:563:28 [INFO] [stdout] | [INFO] [stdout] 563 | return self.derivs[input.node_idx() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input.node_idx()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/f64ad_var_l_mod.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 58 | let idx = self.count.borrow().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.count.borrow()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/f64ad_var_l_mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | b[idx].parent_0 = parent_0.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `parent_0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/f64ad_var_l_mod.rs:67:27 [INFO] [stdout] | [INFO] [stdout] 67 | b[idx].parent_1 = parent_1.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `parent_1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/f64ad/mod.rs:617:5 [INFO] [stdout] | [INFO] [stdout] 617 | / if t == F64adType::VarL { [INFO] [stdout] 618 | | [INFO] [stdout] 619 | | } [INFO] [stdout] | |_____^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/f64ad/f64ad_var_t_mod.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 76 | / let ret = f64ad::f64ad_var_t(f64ad_var_t { [INFO] [stdout] 77 | | computation_graph_id: self.computation_graph_id, [INFO] [stdout] 78 | | node_idx, [INFO] [stdout] 79 | | computation_graph [INFO] [stdout] 80 | | }); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 81 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 76 ~ [INFO] [stdout] 77 ~ f64ad::f64ad_var_t(f64ad_var_t { [INFO] [stdout] 78 + computation_graph_id: self.computation_graph_id, [INFO] [stdout] 79 + node_idx, [INFO] [stdout] 80 + computation_graph [INFO] [stdout] 81 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:720:5 [INFO] [stdout] | [INFO] [stdout] 720 | / return match operands_mode { [INFO] [stdout] 721 | | NodeOperandsMode::TwoParents => { [INFO] [stdout] 722 | | lhs.computation_graph().add_node(value, node_type_class, operands_mode, Some(lhs), rhs) [INFO] [stdout] ... | [INFO] [stdout] 733 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 720 ~ match operands_mode { [INFO] [stdout] 721 + NodeOperandsMode::TwoParents => { [INFO] [stdout] 722 + lhs.computation_graph().add_node(value, node_type_class, operands_mode, Some(lhs), rhs) [INFO] [stdout] 723 + } [INFO] [stdout] 724 + NodeOperandsMode::OneParentLHS => { [INFO] [stdout] 725 + lhs.computation_graph().add_node(value, node_type_class, operands_mode, Some(lhs), rhs) [INFO] [stdout] 726 + } [INFO] [stdout] 727 + NodeOperandsMode::OneParentRHS => { [INFO] [stdout] 728 + rhs.unwrap().computation_graph().add_node(value, node_type_class, operands_mode, Some(lhs), rhs) [INFO] [stdout] 729 + } [INFO] [stdout] 730 + NodeOperandsMode::NoParents => { [INFO] [stdout] 731 + f64ad::f64(value) [INFO] [stdout] 732 + } [INFO] [stdout] 733 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return match self { [INFO] [stdout] 70 | | f64ad::f64(_) => { panic!("cannot compute gradient on f64.") } [INFO] [stdout] 71 | | f64ad::f64ad_var_1(_) => { [INFO] [stdout] 72 | | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] ... | [INFO] [stdout] 83 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ match self { [INFO] [stdout] 70 + f64ad::f64(_) => { panic!("cannot compute gradient on f64.") } [INFO] [stdout] 71 + f64ad::f64ad_var_1(_) => { [INFO] [stdout] 72 + assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 73 + f64ad_universal_forward_mode_grad(self.clone(), false) [INFO] [stdout] 74 + } [INFO] [stdout] 75 + f64ad::f64ad_var_f(_) => { [INFO] [stdout] 76 + f64ad_universal_forward_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] 77 + } [INFO] [stdout] 78 + f64ad::f64ad_var_t(_) => { panic!("cannot compute gradient on f64ad_var_t") } [INFO] [stdout] 79 + f64ad::f64ad_var_l(_) => { [INFO] [stdout] 80 + assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 81 + f64ad_universal_forward_mode_grad(self.clone(), false) [INFO] [stdout] 82 + } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/f64ad/mod.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 - assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 72 + assert!(!add_to_computation_graph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:73:51 [INFO] [stdout] | [INFO] [stdout] 73 | f64ad_universal_forward_mode_grad(self.clone(), false) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:76:51 [INFO] [stdout] | [INFO] [stdout] 76 | f64ad_universal_forward_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/f64ad/mod.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 80 + assert!(!add_to_computation_graph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | f64ad_universal_forward_mode_grad(self.clone(), false) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:800:37 [INFO] [stdout] | [INFO] [stdout] 800 | ... if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 800 - if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] 800 + if val >= 0.0 { tiny_vec!([f64ad; 2] => f64ad::f64(1.0))} else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:800:95 [INFO] [stdout] | [INFO] [stdout] 800 | ... if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 800 - if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] 800 + if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { tiny_vec!([f64ad; 2] => f64ad::f64(-1.0))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / return match self { [INFO] [stdout] 87 | | f64ad::f64(_) => { panic!("cannot compute gradient on f64.") } [INFO] [stdout] 88 | | f64ad::f64ad_var_1(_) => { [INFO] [stdout] 89 | | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] ... | [INFO] [stdout] 100 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 ~ match self { [INFO] [stdout] 87 + f64ad::f64(_) => { panic!("cannot compute gradient on f64.") } [INFO] [stdout] 88 + f64ad::f64ad_var_1(_) => { [INFO] [stdout] 89 + assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 90 + f64ad_universal_backwards_mode_grad(self.clone(), false) [INFO] [stdout] 91 + } [INFO] [stdout] 92 + f64ad::f64ad_var_f(_) => { [INFO] [stdout] 93 + f64ad_universal_backwards_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] 94 + } [INFO] [stdout] 95 + f64ad::f64ad_var_t(_) => { panic!("cannot compute gradient on f64ad_var_t") } [INFO] [stdout] 96 + f64ad::f64ad_var_l(_) => { [INFO] [stdout] 97 + assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 98 + f64ad_universal_backwards_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] 99 + } [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/f64ad/mod.rs:739:15 [INFO] [stdout] | [INFO] [stdout] 739 | let rhs = match rhs { [INFO] [stdout] | _______________^ [INFO] [stdout] 740 | | None => { None } [INFO] [stdout] 741 | | Some(rhs) => { Some(convert_to_f64_if_not_add_to_computation_graph(rhs, add_to_computation_graph)) } [INFO] [stdout] 742 | | }; [INFO] [stdout] | |_____^ help: try: `rhs.map(|rhs| convert_to_f64_if_not_add_to_computation_graph(rhs, add_to_computation_graph))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/f64ad/mod.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 89 - assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 89 + assert!(!add_to_computation_graph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:90:53 [INFO] [stdout] | [INFO] [stdout] 90 | f64ad_universal_backwards_mode_grad(self.clone(), false) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:93:53 [INFO] [stdout] | [INFO] [stdout] 93 | f64ad_universal_backwards_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/f64ad/mod.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | assert_eq!(add_to_computation_graph, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 97 - assert_eq!(add_to_computation_graph, false); [INFO] [stdout] 97 + assert!(!add_to_computation_graph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:98:53 [INFO] [stdout] | [INFO] [stdout] 98 | f64ad_universal_backwards_mode_grad(self.clone(), add_to_computation_graph) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / return match self { [INFO] [stdout] 158 | | ComputationGraph::ComputationGraph1(c) => { [INFO] [stdout] 159 | | if c.borrow().paused() { [INFO] [stdout] 160 | | f64ad::f64(value) [INFO] [stdout] ... | [INFO] [stdout] 174 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ match self { [INFO] [stdout] 158 + ComputationGraph::ComputationGraph1(c) => { [INFO] [stdout] 159 + if c.borrow().paused() { [INFO] [stdout] 160 + f64ad::f64(value) [INFO] [stdout] 161 + } else { [INFO] [stdout] 162 + c.borrow().add_node(value, node_type_class, node_operands_mode, parent_0, parent_1, self) [INFO] [stdout] 163 + } [INFO] [stdout] 164 + } [INFO] [stdout] 165 + ComputationGraph::ComputationGraphF(c) => { [INFO] [stdout] 166 + c.borrow().add_node(value, node_type_class, node_operands_mode, parent_0, parent_1, self) [INFO] [stdout] 167 + } [INFO] [stdout] 168 + ComputationGraph::ComputationGraphT(c) => { [INFO] [stdout] 169 + c.borrow().add_node(value, node_type_class, node_operands_mode, parent_0, parent_1, self) [INFO] [stdout] 170 + } [INFO] [stdout] 171 + ComputationGraph::ComputationGraphL(c) => { [INFO] [stdout] 172 + c.borrow().add_node(value, node_type_class, node_operands_mode, parent_0, parent_1, self) [INFO] [stdout] 173 + } [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | / return match self { [INFO] [stdout] 213 | | ComputationGraph::ComputationGraph1(c) => { [INFO] [stdout] 214 | | let binding0 = c.borrow(); [INFO] [stdout] 215 | | let binding1 = binding0.computation_graph().borrow(); [INFO] [stdout] ... | [INFO] [stdout] 234 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 ~ match self { [INFO] [stdout] 213 + ComputationGraph::ComputationGraph1(c) => { [INFO] [stdout] 214 + let binding0 = c.borrow(); [INFO] [stdout] 215 + let binding1 = binding0.computation_graph().borrow(); [INFO] [stdout] 216 + let node = binding1.item(node_idx); [INFO] [stdout] 217 + ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] 218 + } [INFO] [stdout] 219 + ComputationGraph::ComputationGraphF(c) => { [INFO] [stdout] 220 + let binding0 = c.borrow(); [INFO] [stdout] 221 + let binding1 = binding0.computation_graph().borrow(); [INFO] [stdout] 222 + let node = binding1.item(node_idx); [INFO] [stdout] 223 + ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] 224 + } [INFO] [stdout] 225 + ComputationGraph::ComputationGraphT(_) => { [INFO] [stdout] 226 + unreachable!() [INFO] [stdout] 227 + } [INFO] [stdout] 228 + ComputationGraph::ComputationGraphL(c) => { [INFO] [stdout] 229 + let binding0 = c.borrow(); [INFO] [stdout] 230 + let binding1 = binding0.locked_nodes().borrow(); [INFO] [stdout] 231 + let node = &binding1[node_idx]; [INFO] [stdout] 232 + ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] 233 + } [INFO] [stdout] 234 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:217:19 [INFO] [stdout] | [INFO] [stdout] 217 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_0()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:217:44 [INFO] [stdout] | [INFO] [stdout] 217 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_1()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:223:19 [INFO] [stdout] | [INFO] [stdout] 223 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_0()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:223:44 [INFO] [stdout] | [INFO] [stdout] 223 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_1()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:232:19 [INFO] [stdout] | [INFO] [stdout] 232 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_0()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:232:44 [INFO] [stdout] | [INFO] [stdout] 232 | ([node.parent_0().clone(), node.parent_1().clone()], node.node_type_class(), node.node_operands_mode()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_1()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | return unsafe { (*self.0).spawn_variable(value) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 - return unsafe { (*self.0).spawn_variable(value) }; [INFO] [stdout] 309 + unsafe { (*self.0).spawn_variable(value) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | return unsafe { (*self.0).add_node(value, node_type_class, node_operands_mode, parent_0, parent_1) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 - return unsafe { (*self.0).add_node(value, node_type_class, node_operands_mode, parent_0, parent_1) }; [INFO] [stdout] 313 + unsafe { (*self.0).add_node(value, node_type_class, node_operands_mode, parent_0, parent_1) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:317:9 [INFO] [stdout] | [INFO] [stdout] 317 | return unsafe { (*self.0).get_node_value(node_idx) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 317 - return unsafe { (*self.0).get_node_value(node_idx) }; [INFO] [stdout] 317 + unsafe { (*self.0).get_node_value(node_idx) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | return unsafe { (*self.0).map_to_type() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 321 - return unsafe { (*self.0).map_to_type() }; [INFO] [stdout] 321 + unsafe { (*self.0).map_to_type() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | return unsafe { &(*self.0) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return unsafe { &(*self.0) } [INFO] [stdout] 325 + unsafe { &(*self.0) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | return unsafe { (*self.0).computation_graph_id() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - return unsafe { (*self.0).computation_graph_id() }; [INFO] [stdout] 329 + unsafe { (*self.0).computation_graph_id() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:353:35 [INFO] [stdout] | [INFO] [stdout] 353 | parent_0: node.parent_0().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_0()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:354:35 [INFO] [stdout] | [INFO] [stdout] 354 | parent_1: node.parent_1().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*node.parent_1()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/f64ad/mod.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 366 | let idx = match idx { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 367 | | None => { 0 } [INFO] [stdout] 368 | | Some(idx) => { idx } [INFO] [stdout] 369 | | }; [INFO] [stdout] | |_________^ help: replace it with: `idx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | return unsafe { (*self.0).reset() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 379 - return unsafe { (*self.0).reset() }; [INFO] [stdout] 379 + unsafe { (*self.0).reset() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GenericComputationGraph` [INFO] [stdout] --> src/f64ad/mod.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 389 | / pub fn new() -> Self { [INFO] [stdout] 390 | | Self { [INFO] [stdout] 391 | | nodes: Vec::with_capacity(1_000_000), [INFO] [stdout] 392 | | curr_idx: 0, [INFO] [stdout] ... | [INFO] [stdout] 395 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 388 + impl Default for GenericComputationGraph { [INFO] [stdout] 389 + fn default() -> Self { [INFO] [stdout] 390 + Self::new() [INFO] [stdout] 391 + } [INFO] [stdout] 392 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | return &self.nodes[idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - return &self.nodes[idx]; [INFO] [stdout] 423 + &self.nodes[idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/f64ad/mod.rs:429:40 [INFO] [stdout] | [INFO] [stdout] 429 | static mut _GLOBAL_COMPUTATION_GRAPHS: OnceCell>> = OnceCell... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | return Self::get_internal(name, idx, ComputationGraphType::ComputationGraphF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - return Self::get_internal(name, idx, ComputationGraphType::ComputationGraphF); [INFO] [stdout] 439 + Self::get_internal(name, idx, ComputationGraphType::ComputationGraphF) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:456:9 [INFO] [stdout] | [INFO] [stdout] 456 | / return match res { [INFO] [stdout] 457 | | None => { [INFO] [stdout] 458 | | binding.insert((name.clone(), idx, computation_graph_type), ComputationGraph::new(computation_graph_type)); [INFO] [stdout] 459 | | drop(binding); [INFO] [stdout] ... | [INFO] [stdout] 466 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 ~ match res { [INFO] [stdout] 457 + None => { [INFO] [stdout] 458 + binding.insert((name.clone(), idx, computation_graph_type), ComputationGraph::new(computation_graph_type)); [INFO] [stdout] 459 + drop(binding); [INFO] [stdout] 460 + Self::get_internal(Some(&name), Some(idx), computation_graph_type) [INFO] [stdout] 461 + } [INFO] [stdout] 462 + Some(computation_graph) => { [INFO] [stdout] 463 + let r: *const ComputationGraph = computation_graph; [INFO] [stdout] 464 + return GlobalComputationGraph(r); [INFO] [stdout] 465 + } [INFO] [stdout] 466 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/f64ad/mod.rs:448:19 [INFO] [stdout] | [INFO] [stdout] 448 | let idx = match idx { [INFO] [stdout] | ___________________^ [INFO] [stdout] 449 | | None => { 0 } [INFO] [stdout] 450 | | Some(idx) => { idx } [INFO] [stdout] 451 | | }; [INFO] [stdout] | |_________^ help: replace it with: `idx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:504:5 [INFO] [stdout] | [INFO] [stdout] 504 | return BackwardsModeGradOutput { derivs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 504 - return BackwardsModeGradOutput { derivs }; [INFO] [stdout] 504 + BackwardsModeGradOutput { derivs } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:540:5 [INFO] [stdout] | [INFO] [stdout] 540 | return ForwardModeGradOutput { derivs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 540 - return ForwardModeGradOutput { derivs }; [INFO] [stdout] 540 + ForwardModeGradOutput { derivs } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:544:5 [INFO] [stdout] | [INFO] [stdout] 544 | return if !add_to_computation_graph { f64ad::f64(v.value()) } else { v }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 544 - return if !add_to_computation_graph { f64ad::f64(v.value()) } else { v }; [INFO] [stdout] 544 + if !add_to_computation_graph { f64ad::f64(v.value()) } else { v } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 553 | return self.derivs[output.node_idx() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 553 - return self.derivs[output.node_idx() as usize]; [INFO] [stdout] 553 + self.derivs[output.node_idx() as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/f64ad/mod.rs:553:28 [INFO] [stdout] | [INFO] [stdout] 553 | return self.derivs[output.node_idx() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `output.node_idx()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:563:9 [INFO] [stdout] | [INFO] [stdout] 563 | return self.derivs[input.node_idx() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 563 - return self.derivs[input.node_idx() as usize]; [INFO] [stdout] 563 + self.derivs[input.node_idx() as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/f64ad/mod.rs:563:28 [INFO] [stdout] | [INFO] [stdout] 563 | return self.derivs[input.node_idx() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input.node_idx()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/f64ad/mod.rs:617:5 [INFO] [stdout] | [INFO] [stdout] 617 | / if t == F64adType::VarL { [INFO] [stdout] 618 | | [INFO] [stdout] 619 | | } [INFO] [stdout] | |_____^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:720:5 [INFO] [stdout] | [INFO] [stdout] 720 | / return match operands_mode { [INFO] [stdout] 721 | | NodeOperandsMode::TwoParents => { [INFO] [stdout] 722 | | lhs.computation_graph().add_node(value, node_type_class, operands_mode, Some(lhs), rhs) [INFO] [stdout] ... | [INFO] [stdout] 733 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 720 ~ match operands_mode { [INFO] [stdout] 721 + NodeOperandsMode::TwoParents => { [INFO] [stdout] 722 + lhs.computation_graph().add_node(value, node_type_class, operands_mode, Some(lhs), rhs) [INFO] [stdout] 723 + } [INFO] [stdout] 724 + NodeOperandsMode::OneParentLHS => { [INFO] [stdout] 725 + lhs.computation_graph().add_node(value, node_type_class, operands_mode, Some(lhs), rhs) [INFO] [stdout] 726 + } [INFO] [stdout] 727 + NodeOperandsMode::OneParentRHS => { [INFO] [stdout] 728 + rhs.unwrap().computation_graph().add_node(value, node_type_class, operands_mode, Some(lhs), rhs) [INFO] [stdout] 729 + } [INFO] [stdout] 730 + NodeOperandsMode::NoParents => { [INFO] [stdout] 731 + f64ad::f64(value) [INFO] [stdout] 732 + } [INFO] [stdout] 733 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:800:37 [INFO] [stdout] | [INFO] [stdout] 800 | ... if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 800 - if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] 800 + if val >= 0.0 { tiny_vec!([f64ad; 2] => f64ad::f64(1.0))} else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:800:95 [INFO] [stdout] | [INFO] [stdout] 800 | ... if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 800 - if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { return tiny_vec!([f64ad; 2] => f64ad::f64(-1.0)); } [INFO] [stdout] 800 + if val >= 0.0 { return tiny_vec!([f64ad; 2] => f64ad::f64(1.0)); } else { tiny_vec!([f64ad; 2] => f64ad::f64(-1.0))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/f64ad/mod.rs:739:15 [INFO] [stdout] | [INFO] [stdout] 739 | let rhs = match rhs { [INFO] [stdout] | _______________^ [INFO] [stdout] 740 | | None => { None } [INFO] [stdout] 741 | | Some(rhs) => { Some(convert_to_f64_if_not_add_to_computation_graph(rhs, add_to_computation_graph)) } [INFO] [stdout] 742 | | }; [INFO] [stdout] | |_____^ help: try: `rhs.map(|rhs| convert_to_f64_if_not_add_to_computation_graph(rhs, add_to_computation_graph))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/f64ad/mod.rs:1106:40 [INFO] [stdout] | [INFO] [stdout] 1106 | let add_to_computation_graph = !(curr_order == order - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(curr_order != order - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:1101:44 [INFO] [stdout] | [INFO] [stdout] 1101 | out.push_entry(vec![], output_idx, output.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JacobianOutput` [INFO] [stdout] --> src/f64ad/mod.rs:1172:5 [INFO] [stdout] | [INFO] [stdout] 1172 | / pub fn new() -> Self { [INFO] [stdout] 1173 | | Self { [INFO] [stdout] 1174 | | entries: vec![] [INFO] [stdout] 1175 | | } [INFO] [stdout] 1176 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 1171 + impl Default for JacobianOutput { [INFO] [stdout] 1172 + fn default() -> Self { [INFO] [stdout] 1173 + Self::new() [INFO] [stdout] 1174 + } [INFO] [stdout] 1175 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1191:9 [INFO] [stdout] | [INFO] [stdout] 1191 | / return match binary_search_res { [INFO] [stdout] 1192 | | Ok(i) => { Some(&self.entries[i]) } [INFO] [stdout] 1193 | | Err(_) => { None } [INFO] [stdout] 1194 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1191 ~ match binary_search_res { [INFO] [stdout] 1192 + Ok(i) => { Some(&self.entries[i]) } [INFO] [stdout] 1193 + Err(_) => { None } [INFO] [stdout] 1194 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1297:9 [INFO] [stdout] | [INFO] [stdout] 1297 | return self + f64ad::f64(rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1297 - return self + f64ad::f64(rhs); [INFO] [stdout] 1297 + self + f64ad::f64(rhs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1304:9 [INFO] [stdout] | [INFO] [stdout] 1304 | return f64ad::f64(self) + rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1304 - return f64ad::f64(self) + rhs; [INFO] [stdout] 1304 + f64ad::f64(self) + rhs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1334:9 [INFO] [stdout] | [INFO] [stdout] 1334 | return self * f64ad::f64(rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1334 - return self * f64ad::f64(rhs); [INFO] [stdout] 1334 + self * f64ad::f64(rhs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1341:9 [INFO] [stdout] | [INFO] [stdout] 1341 | return f64ad::f64(self) * rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1341 - return f64ad::f64(self) * rhs; [INFO] [stdout] 1341 + f64ad::f64(self) * rhs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1374:9 [INFO] [stdout] | [INFO] [stdout] 1374 | return self - f64ad::f64(rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1374 - return self - f64ad::f64(rhs); [INFO] [stdout] 1374 + self - f64ad::f64(rhs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1381:9 [INFO] [stdout] | [INFO] [stdout] 1381 | return f64ad::f64(self) - rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1381 - return f64ad::f64(self) - rhs; [INFO] [stdout] 1381 + f64ad::f64(self) - rhs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1411:9 [INFO] [stdout] | [INFO] [stdout] 1411 | return self / f64ad::f64(rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1411 - return self / f64ad::f64(rhs); [INFO] [stdout] 1411 + self / f64ad::f64(rhs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1418:9 [INFO] [stdout] | [INFO] [stdout] 1418 | return f64ad::f64(self) / rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1418 - return f64ad::f64(self) / rhs; [INFO] [stdout] 1418 + f64ad::f64(self) / rhs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1491:9 [INFO] [stdout] | [INFO] [stdout] 1491 | return self.value() == other.value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1491 - return self.value() == other.value(); [INFO] [stdout] 1491 + self.value() == other.value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1496:9 [INFO] [stdout] | [INFO] [stdout] 1496 | return self.eq(&f64ad::f64(*other)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1496 - return self.eq(&f64ad::f64(*other)); [INFO] [stdout] 1496 + self.eq(&f64ad::f64(*other)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1501:9 [INFO] [stdout] | [INFO] [stdout] 1501 | return f64ad::f64(*self).eq(other); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1501 - return f64ad::f64(*self).eq(other); [INFO] [stdout] 1501 + f64ad::f64(*self).eq(other) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1512:9 [INFO] [stdout] | [INFO] [stdout] 1512 | return self.value().partial_cmp(&other.value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1512 - return self.value().partial_cmp(&other.value()); [INFO] [stdout] 1512 + self.value().partial_cmp(&other.value()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1517:9 [INFO] [stdout] | [INFO] [stdout] 1517 | return self.partial_cmp(&f64ad::f64(*other)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1517 - return self.partial_cmp(&f64ad::f64(*other)); [INFO] [stdout] 1517 + self.partial_cmp(&f64ad::f64(*other)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1522:9 [INFO] [stdout] | [INFO] [stdout] 1522 | return f64ad::f64(*self).partial_cmp(other); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1522 - return f64ad::f64(*self).partial_cmp(other); [INFO] [stdout] 1522 + f64ad::f64(*self).partial_cmp(other) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/f64ad/mod.rs:1106:40 [INFO] [stdout] | [INFO] [stdout] 1106 | let add_to_computation_graph = !(curr_order == order - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(curr_order != order - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1535:9 [INFO] [stdout] | [INFO] [stdout] 1535 | return f64ad::f64(a); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1535 - return f64ad::f64(a); [INFO] [stdout] 1535 + f64ad::f64(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/f64ad/mod.rs:1538:1 [INFO] [stdout] | [INFO] [stdout] 1538 | impl Into for f64ad { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 1538 ~ impl From for f64 { [INFO] [stdout] 1539 ~ fn from(val: f64ad) -> Self { [INFO] [stdout] 1540 ~ val.value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1545:9 [INFO] [stdout] | [INFO] [stdout] 1545 | return f64ad::f64(a as f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1545 - return f64ad::f64(a as f64); [INFO] [stdout] 1545 + f64ad::f64(a as f64) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/f64ad/mod.rs:1548:1 [INFO] [stdout] | [INFO] [stdout] 1548 | impl Into for f64ad { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 1548 ~ impl From for f32 { [INFO] [stdout] 1549 ~ fn from(val: f64ad) -> Self { [INFO] [stdout] 1550 ~ val.value() as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64ad` which implements the `Copy` trait [INFO] [stdout] --> src/f64ad/mod.rs:1101:44 [INFO] [stdout] | [INFO] [stdout] 1101 | out.push_entry(vec![], output_idx, output.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JacobianOutput` [INFO] [stdout] --> src/f64ad/mod.rs:1172:5 [INFO] [stdout] | [INFO] [stdout] 1172 | / pub fn new() -> Self { [INFO] [stdout] 1173 | | Self { [INFO] [stdout] 1174 | | entries: vec![] [INFO] [stdout] 1175 | | } [INFO] [stdout] 1176 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 1171 + impl Default for JacobianOutput { [INFO] [stdout] 1172 + fn default() -> Self { [INFO] [stdout] 1173 + Self::new() [INFO] [stdout] 1174 + } [INFO] [stdout] 1175 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1191:9 [INFO] [stdout] | [INFO] [stdout] 1191 | / return match binary_search_res { [INFO] [stdout] 1192 | | Ok(i) => { Some(&self.entries[i]) } [INFO] [stdout] 1193 | | Err(_) => { None } [INFO] [stdout] 1194 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1191 ~ match binary_search_res { [INFO] [stdout] 1192 + Ok(i) => { Some(&self.entries[i]) } [INFO] [stdout] 1193 + Err(_) => { None } [INFO] [stdout] 1194 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/f64ad/mod.rs:360:40 [INFO] [stdout] | [INFO] [stdout] 360 | let hashmap = unsafe { _GLOBAL_COMPUTATION_GRAPHS.get_or_init(|| Mutex::new(HashMap::new())) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/f64ad/mod.rs:442:32 [INFO] [stdout] | [INFO] [stdout] 442 | let hashmap = unsafe { _GLOBAL_COMPUTATION_GRAPHS.get_or_init(|| Mutex::new(HashMap::new())) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1297:9 [INFO] [stdout] | [INFO] [stdout] 1297 | return self + f64ad::f64(rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1297 - return self + f64ad::f64(rhs); [INFO] [stdout] 1297 + self + f64ad::f64(rhs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1304:9 [INFO] [stdout] | [INFO] [stdout] 1304 | return f64ad::f64(self) + rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1304 - return f64ad::f64(self) + rhs; [INFO] [stdout] 1304 + f64ad::f64(self) + rhs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1334:9 [INFO] [stdout] | [INFO] [stdout] 1334 | return self * f64ad::f64(rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1334 - return self * f64ad::f64(rhs); [INFO] [stdout] 1334 + self * f64ad::f64(rhs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1341:9 [INFO] [stdout] | [INFO] [stdout] 1341 | return f64ad::f64(self) * rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1341 - return f64ad::f64(self) * rhs; [INFO] [stdout] 1341 + f64ad::f64(self) * rhs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1374:9 [INFO] [stdout] | [INFO] [stdout] 1374 | return self - f64ad::f64(rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1374 - return self - f64ad::f64(rhs); [INFO] [stdout] 1374 + self - f64ad::f64(rhs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1381:9 [INFO] [stdout] | [INFO] [stdout] 1381 | return f64ad::f64(self) - rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1381 - return f64ad::f64(self) - rhs; [INFO] [stdout] 1381 + f64ad::f64(self) - rhs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1411:9 [INFO] [stdout] | [INFO] [stdout] 1411 | return self / f64ad::f64(rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1411 - return self / f64ad::f64(rhs); [INFO] [stdout] 1411 + self / f64ad::f64(rhs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1418:9 [INFO] [stdout] | [INFO] [stdout] 1418 | return f64ad::f64(self) / rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1418 - return f64ad::f64(self) / rhs; [INFO] [stdout] 1418 + f64ad::f64(self) / rhs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1491:9 [INFO] [stdout] | [INFO] [stdout] 1491 | return self.value() == other.value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1491 - return self.value() == other.value(); [INFO] [stdout] 1491 + self.value() == other.value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1496:9 [INFO] [stdout] | [INFO] [stdout] 1496 | return self.eq(&f64ad::f64(*other)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1496 - return self.eq(&f64ad::f64(*other)); [INFO] [stdout] 1496 + self.eq(&f64ad::f64(*other)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1501:9 [INFO] [stdout] | [INFO] [stdout] 1501 | return f64ad::f64(*self).eq(other); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1501 - return f64ad::f64(*self).eq(other); [INFO] [stdout] 1501 + f64ad::f64(*self).eq(other) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1512:9 [INFO] [stdout] | [INFO] [stdout] 1512 | return self.value().partial_cmp(&other.value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1512 - return self.value().partial_cmp(&other.value()); [INFO] [stdout] 1512 + self.value().partial_cmp(&other.value()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1517:9 [INFO] [stdout] | [INFO] [stdout] 1517 | return self.partial_cmp(&f64ad::f64(*other)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1517 - return self.partial_cmp(&f64ad::f64(*other)); [INFO] [stdout] 1517 + self.partial_cmp(&f64ad::f64(*other)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1522:9 [INFO] [stdout] | [INFO] [stdout] 1522 | return f64ad::f64(*self).partial_cmp(other); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1522 - return f64ad::f64(*self).partial_cmp(other); [INFO] [stdout] 1522 + f64ad::f64(*self).partial_cmp(other) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1535:9 [INFO] [stdout] | [INFO] [stdout] 1535 | return f64ad::f64(a); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1535 - return f64ad::f64(a); [INFO] [stdout] 1535 + f64ad::f64(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/f64ad/mod.rs:1538:1 [INFO] [stdout] | [INFO] [stdout] 1538 | impl Into for f64ad { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 1538 ~ impl From for f64 { [INFO] [stdout] 1539 ~ fn from(val: f64ad) -> Self { [INFO] [stdout] 1540 ~ val.value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/f64ad/mod.rs:1545:9 [INFO] [stdout] | [INFO] [stdout] 1545 | return f64ad::f64(a as f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1545 - return f64ad::f64(a as f64); [INFO] [stdout] 1545 + f64ad::f64(a as f64) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/f64ad/mod.rs:1548:1 [INFO] [stdout] | [INFO] [stdout] 1548 | impl Into for f64ad { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 1548 ~ impl From for f32 { [INFO] [stdout] 1549 ~ fn from(val: f64ad) -> Self { [INFO] [stdout] 1550 ~ val.value() as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/f64ad/mod.rs:360:40 [INFO] [stdout] | [INFO] [stdout] 360 | let hashmap = unsafe { _GLOBAL_COMPUTATION_GRAPHS.get_or_init(|| Mutex::new(HashMap::new())) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/f64ad/mod.rs:442:32 [INFO] [stdout] | [INFO] [stdout] 442 | let hashmap = unsafe { _GLOBAL_COMPUTATION_GRAPHS.get_or_init(|| Mutex::new(HashMap::new())) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `Command { std: "docker" "inspect" "09e13ce06e0d77746ec05807ec4d6dae348ad8ff6a77e7326e2602011c4f2f5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09e13ce06e0d77746ec05807ec4d6dae348ad8ff6a77e7326e2602011c4f2f5e", kill_on_drop: false }` [INFO] [stdout] 09e13ce06e0d77746ec05807ec4d6dae348ad8ff6a77e7326e2602011c4f2f5e