[INFO] fetching crate ezjson 0.2.0... [INFO] linting ezjson-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ezjson 0.2.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate ezjson 0.2.0 [INFO] finished tweaking crates.io crate ezjson 0.2.0 [INFO] tweaked toml for crates.io crate ezjson 0.2.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ezjson 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ezjson 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syn v2.0.35 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3978017c4188eb4b214deded1cc515e8d9af852aa236d3eceac831271826a4f5 [INFO] running `Command { std: "docker" "start" "-a" "3978017c4188eb4b214deded1cc515e8d9af852aa236d3eceac831271826a4f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3978017c4188eb4b214deded1cc515e8d9af852aa236d3eceac831271826a4f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3978017c4188eb4b214deded1cc515e8d9af852aa236d3eceac831271826a4f5", kill_on_drop: false }` [INFO] [stdout] 3978017c4188eb4b214deded1cc515e8d9af852aa236d3eceac831271826a4f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7fc39942bd356fe700649c239e7fa9a25933230ae4f57e87544e2760d602c82c [INFO] running `Command { std: "docker" "start" "-a" "7fc39942bd356fe700649c239e7fa9a25933230ae4f57e87544e2760d602c82c", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling syn v2.0.35 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking serde_json v1.0.107 [INFO] [stderr] Checking ezjson v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !self.json_data.get(key).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.json_data.get(key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | Err(_) => return Err(Box::new(std::io::Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 62 | | std::io::ErrorKind::NotFound, [INFO] [stdout] 63 | | "File not found", [INFO] [stdout] 64 | | ))) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Err(_) => Err(Box::new(std::io::Error::new( [INFO] [stdout] 62 + std::io::ErrorKind::NotFound, [INFO] [stdout] 63 + "File not found", [INFO] [stdout] 64 + ))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:51:43 [INFO] [stdout] | [INFO] [stdout] 51 | let mut file = match File::create(&self.path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !self.json_data.get(key).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.json_data.get(key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | Err(_) => return Err(Box::new(std::io::Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 62 | | std::io::ErrorKind::NotFound, [INFO] [stdout] 63 | | "File not found", [INFO] [stdout] 64 | | ))) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Err(_) => Err(Box::new(std::io::Error::new( [INFO] [stdout] 62 + std::io::ErrorKind::NotFound, [INFO] [stdout] 63 + "File not found", [INFO] [stdout] 64 + ))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:51:43 [INFO] [stdout] | [INFO] [stdout] 51 | let mut file = match File::create(&self.path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:197:37 [INFO] [stdout] | [INFO] [stdout] 197 | let file = match File::open(&self.path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:197:37 [INFO] [stdout] | [INFO] [stdout] 197 | let file = match File::open(&self.path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.28s [INFO] running `Command { std: "docker" "inspect" "7fc39942bd356fe700649c239e7fa9a25933230ae4f57e87544e2760d602c82c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fc39942bd356fe700649c239e7fa9a25933230ae4f57e87544e2760d602c82c", kill_on_drop: false }` [INFO] [stdout] 7fc39942bd356fe700649c239e7fa9a25933230ae4f57e87544e2760d602c82c