[INFO] fetching crate ezjs 0.1.1... [INFO] linting ezjs-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ezjs 0.1.1 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate ezjs 0.1.1 [INFO] finished tweaking crates.io crate ezjs 0.1.1 [INFO] tweaked toml for crates.io crate ezjs 0.1.1 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ezjs 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ezjs 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4ead1d41b403d03e4b9e24c2d7703f4bf2a340539431af832707cf1671a8431 [INFO] running `Command { std: "docker" "start" "-a" "d4ead1d41b403d03e4b9e24c2d7703f4bf2a340539431af832707cf1671a8431", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4ead1d41b403d03e4b9e24c2d7703f4bf2a340539431af832707cf1671a8431", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4ead1d41b403d03e4b9e24c2d7703f4bf2a340539431af832707cf1671a8431", kill_on_drop: false }` [INFO] [stdout] d4ead1d41b403d03e4b9e24c2d7703f4bf2a340539431af832707cf1671a8431 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de53c331fcb2fa94324b3242c1eb7bb5733f7d933ce2aa9246b98f76abd256dd [INFO] running `Command { std: "docker" "start" "-a" "de53c331fcb2fa94324b3242c1eb7bb5733f7d933ce2aa9246b98f76abd256dd", kill_on_drop: false }` [INFO] [stderr] Checking ezjs v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/token.rs:198:28 [INFO] [stdout] | [INFO] [stdout] 198 | const VALID_PUNCTS: [&'static str; 24] = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/token.rs:709:13 [INFO] [stdout] | [INFO] [stdout] 709 | script: script, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/token.rs:774:25 [INFO] [stdout] | [INFO] [stdout] 774 | src_line: src_line, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `src_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/token.rs:783:21 [INFO] [stdout] | [INFO] [stdout] 783 | src_line: src_line, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `src_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/compile.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | script: script, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/compile.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | scope: scope, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/value.rs:483:4 [INFO] [stdout] | [INFO] [stdout] 483 | msg: msg [INFO] [stdout] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/value.rs:499:4 [INFO] [stdout] | [INFO] [stdout] 499 | keys: keys, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/value.rs:527:13 [INFO] [stdout] | [INFO] [stdout] 527 | value: value [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/value.rs:562:4 [INFO] [stdout] | [INFO] [stdout] 562 | scope: scope, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/builtin.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | f: f, [INFO] [stdout] | ^^^^^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:86:4 [INFO] [stdout] | [INFO] [stdout] 86 | /// Create an new JsRuntime struct of ezjs, which execute byte of VMFunction. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:103:3 [INFO] [stdout] | [INFO] [stdout] 103 | prototypes: prototypes, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prototypes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:104:3 [INFO] [stdout] | [INFO] [stdout] 104 | genv: genv, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `genv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:105:3 [INFO] [stdout] | [INFO] [stdout] 105 | cenv: cenv, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `cenv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:110:3 [INFO] [stdout] | [INFO] [stdout] 110 | root: root, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:120:4 [INFO] [stdout] | [INFO] [stdout] 120 | /// Run bytecode of VMFunction with a runtime, and return the result sharedvalue. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/token.rs:198:28 [INFO] [stdout] | [INFO] [stdout] 198 | const VALID_PUNCTS: [&'static str; 24] = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/token.rs:709:13 [INFO] [stdout] | [INFO] [stdout] 709 | script: script, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/token.rs:774:25 [INFO] [stdout] | [INFO] [stdout] 774 | src_line: src_line, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `src_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/token.rs:783:21 [INFO] [stdout] | [INFO] [stdout] 783 | src_line: src_line, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `src_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/compile.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | script: script, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/compile.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | scope: scope, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/value.rs:483:4 [INFO] [stdout] | [INFO] [stdout] 483 | msg: msg [INFO] [stdout] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/value.rs:499:4 [INFO] [stdout] | [INFO] [stdout] 499 | keys: keys, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/value.rs:527:13 [INFO] [stdout] | [INFO] [stdout] 527 | value: value [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/value.rs:562:4 [INFO] [stdout] | [INFO] [stdout] 562 | scope: scope, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/builtin.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | f: f, [INFO] [stdout] | ^^^^^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:86:4 [INFO] [stdout] | [INFO] [stdout] 86 | /// Create an new JsRuntime struct of ezjs, which execute byte of VMFunction. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:103:3 [INFO] [stdout] | [INFO] [stdout] 103 | prototypes: prototypes, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prototypes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:104:3 [INFO] [stdout] | [INFO] [stdout] 104 | genv: genv, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `genv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:105:3 [INFO] [stdout] | [INFO] [stdout] 105 | cenv: cenv, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `cenv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:110:3 [INFO] [stdout] | [INFO] [stdout] 110 | root: root, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:120:4 [INFO] [stdout] | [INFO] [stdout] 120 | /// Run bytecode of VMFunction with a runtime, and return the result sharedvalue. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:5:2 [INFO] [stdout] | [INFO] [stdout] 5 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return None; [INFO] [stdout] 5 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 30 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return None; [INFO] [stdout] 30 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/common.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | let symbol:&str = &symbol[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/common.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | if symbol.starts_with("0x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 12 ~ if let Some(symbol) = symbol.strip_prefix("0x") { [INFO] [stdout] 13 ~ if let Ok(v) = u64::from_str_radix(&symbol, 16) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/common.rs:14:38 [INFO] [stdout] | [INFO] [stdout] 14 | if let Ok(v) = u64::from_str_radix(&symbol, 16) { [INFO] [stdout] | ^^^^^^^ help: change this to: `symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/common.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | let symbol:&str = &symbol[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/common.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 18 | if symbol.starts_with("bx") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some(symbol) = symbol.strip_prefix("bx") { [INFO] [stdout] 19 ~ if let Ok(v) = u64::from_str_radix(&symbol, 2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/common.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 20 | if let Ok(v) = u64::from_str_radix(&symbol, 2) { [INFO] [stdout] | ^^^^^^^ help: change this to: `symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:5:2 [INFO] [stdout] | [INFO] [stdout] 5 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return None; [INFO] [stdout] 5 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 30 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return None; [INFO] [stdout] 30 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/common.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | let symbol:&str = &symbol[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/common.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | if symbol.starts_with("0x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 12 ~ if let Some(symbol) = symbol.strip_prefix("0x") { [INFO] [stdout] 13 ~ if let Ok(v) = u64::from_str_radix(&symbol, 16) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/common.rs:14:38 [INFO] [stdout] | [INFO] [stdout] 14 | if let Ok(v) = u64::from_str_radix(&symbol, 16) { [INFO] [stdout] | ^^^^^^^ help: change this to: `symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/common.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | let symbol:&str = &symbol[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/common.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 18 | if symbol.starts_with("bx") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some(symbol) = symbol.strip_prefix("bx") { [INFO] [stdout] 19 ~ if let Ok(v) = u64::from_str_radix(&symbol, 2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/common.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 20 | if let Ok(v) = u64::from_str_radix(&symbol, 2) { [INFO] [stdout] | ^^^^^^^ help: change this to: `symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return ct::CT_LETTER; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return ct::CT_LETTER; [INFO] [stdout] 185 + ct::CT_LETTER [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/token.rs:169:7 [INFO] [stdout] | [INFO] [stdout] 169 | if chr == None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_none()` instead: `chr.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | return c; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return c; [INFO] [stdout] 195 + c [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return false; [INFO] [stdout] 211 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `VALID_PUNCTS` [INFO] [stdout] --> src/token.rs:206:18 [INFO] [stdout] | [INFO] [stdout] 206 | for i in 0..VALID_PUNCTS.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 206 - for i in 0..VALID_PUNCTS.len() { [INFO] [stdout] 206 + for in &VALID_PUNCTS { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/token.rs:311:24 [INFO] [stdout] | [INFO] [stdout] 311 | if tkbuf.len() > 0 && tkbuf[tkbuf.len() - 1] == '\0' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tkbuf.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tkbuf` [INFO] [stdout] --> src/token.rs:405:34 [INFO] [stdout] | [INFO] [stdout] 405 | for i in 0..tkbuf.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 405 - for i in 0..tkbuf.len() { [INFO] [stdout] 405 + for in &tkbuf { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/token.rs:419:28 [INFO] [stdout] | [INFO] [stdout] 419 | if check_punct(&value) == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_punct(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 452 | return str_to_number(symbol).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 452 - return str_to_number(symbol).unwrap(); [INFO] [stdout] 452 + str_to_number(symbol).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:451:28 [INFO] [stdout] | [INFO] [stdout] 451 | let symbol: &str = &self.tk_value.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.tk_value.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return ct::CT_LETTER; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return ct::CT_LETTER; [INFO] [stdout] 185 + ct::CT_LETTER [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/token.rs:169:7 [INFO] [stdout] | [INFO] [stdout] 169 | if chr == None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_none()` instead: `chr.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `chr` after checking its variant with `is_some` [INFO] [stdout] --> src/token.rs:512:20 [INFO] [stdout] | [INFO] [stdout] 511 | if chr.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = chr` [INFO] [stdout] 512 | if chr.unwrap() == '\n' { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:513:21 [INFO] [stdout] | [INFO] [stdout] 513 | line_count = line_count + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:611:9 [INFO] [stdout] | [INFO] [stdout] 611 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 611 - return -1; [INFO] [stdout] 611 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/token.rs:594:32 [INFO] [stdout] | [INFO] [stdout] 594 | let symbol: &str = &symbol[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/token.rs:593:9 [INFO] [stdout] | [INFO] [stdout] 593 | if symbol.starts_with("0x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 593 ~ if let Some(symbol) = symbol.strip_prefix("0x") { [INFO] [stdout] 594 ~ if u64::from_str_radix(&symbol, 16).is_ok() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | return c; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return c; [INFO] [stdout] 195 + c [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:595:36 [INFO] [stdout] | [INFO] [stdout] 595 | if u64::from_str_radix(&symbol, 16).is_ok() { [INFO] [stdout] | ^^^^^^^ help: change this to: `symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/token.rs:600:32 [INFO] [stdout] | [INFO] [stdout] 600 | let symbol: &str = &symbol[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/token.rs:599:9 [INFO] [stdout] | [INFO] [stdout] 599 | if symbol.starts_with("0b") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 599 ~ if let Some(symbol) = symbol.strip_prefix("0b") { [INFO] [stdout] 600 ~ if u64::from_str_radix(&symbol, 2).is_ok() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:601:36 [INFO] [stdout] | [INFO] [stdout] 601 | if u64::from_str_radix(&symbol, 2).is_ok() { [INFO] [stdout] | ^^^^^^^ help: change this to: `symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return false; [INFO] [stdout] 211 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `VALID_PUNCTS` [INFO] [stdout] --> src/token.rs:206:18 [INFO] [stdout] | [INFO] [stdout] 206 | for i in 0..VALID_PUNCTS.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 206 - for i in 0..VALID_PUNCTS.len() { [INFO] [stdout] 206 + for in &VALID_PUNCTS { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:619:39 [INFO] [stdout] | [INFO] [stdout] 619 | let next = next_general_token(&script, cursor); [INFO] [stdout] | ^^^^^^^ help: change this to: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:636:21 [INFO] [stdout] | [INFO] [stdout] 636 | line = line + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `line += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:643:17 [INFO] [stdout] | [INFO] [stdout] 643 | line = line + count_line(&value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line += count_line(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:650:17 [INFO] [stdout] | [INFO] [stdout] 650 | line = line + count_line(&value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line += count_line(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:673:61 [INFO] [stdout] | [INFO] [stdout] 673 | if let Ok((tk2, pos2)) = next_general_token(&script, cursor){ [INFO] [stdout] | ^^^^^^^ help: change this to: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:677:73 [INFO] [stdout] | [INFO] [stdout] 677 | ... if let Ok((tk3, pos3)) = next_general_token(&script, pos2) { [INFO] [stdout] | ^^^^^^^ help: change this to: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:708:9 [INFO] [stdout] | [INFO] [stdout] 708 | / return Tokenlizer { [INFO] [stdout] 709 | | script: script, [INFO] [stdout] 710 | | cursor: 0, [INFO] [stdout] 711 | | line: 1, [INFO] [stdout] ... | [INFO] [stdout] 714 | | notin: false, [INFO] [stdout] 715 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 708 ~ Tokenlizer { [INFO] [stdout] 709 + script: script, [INFO] [stdout] 710 + cursor: 0, [INFO] [stdout] 711 + line: 1, [INFO] [stdout] 712 + forward_: LinkedList::new(), [INFO] [stdout] 713 + [INFO] [stdout] 714 + notin: false, [INFO] [stdout] 715 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:727:9 [INFO] [stdout] | [INFO] [stdout] 727 | return Ok(n); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 727 - return Ok(n); [INFO] [stdout] 727 + Ok(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/token.rs:719:12 [INFO] [stdout] | [INFO] [stdout] 719 | if self.forward_.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.forward_.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:739:9 [INFO] [stdout] | [INFO] [stdout] 739 | return Ok(n); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 739 - return Ok(n); [INFO] [stdout] 739 + Ok(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/token.rs:731:12 [INFO] [stdout] | [INFO] [stdout] 731 | if self.forward_.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.forward_.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 751 | return Ok(n); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 751 - return Ok(n); [INFO] [stdout] 751 + Ok(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/token.rs:743:12 [INFO] [stdout] | [INFO] [stdout] 743 | if self.forward_.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.forward_.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:755:9 [INFO] [stdout] | [INFO] [stdout] 755 | return self.line; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 755 - return self.line; [INFO] [stdout] 755 + self.line [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/token.rs:311:24 [INFO] [stdout] | [INFO] [stdout] 311 | if tkbuf.len() > 0 && tkbuf[tkbuf.len() - 1] == '\0' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tkbuf.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tkbuf` [INFO] [stdout] --> src/token.rs:405:34 [INFO] [stdout] | [INFO] [stdout] 405 | for i in 0..tkbuf.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 405 - for i in 0..tkbuf.len() { [INFO] [stdout] 405 + for in &tkbuf { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `ids` [INFO] [stdout] --> src/token.rs:765:18 [INFO] [stdout] | [INFO] [stdout] 765 | for i in 0..ids.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 765 - for i in 0..ids.len() { [INFO] [stdout] 765 + for (i, ) in ids.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/token.rs:419:28 [INFO] [stdout] | [INFO] [stdout] 419 | if check_punct(&value) == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_punct(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/token.rs:795:47 [INFO] [stdout] | [INFO] [stdout] 794 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 795 | let (token, (cursor, line)) = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 452 | return str_to_number(symbol).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 452 - return str_to_number(symbol).unwrap(); [INFO] [stdout] 452 + str_to_number(symbol).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:451:28 [INFO] [stdout] | [INFO] [stdout] 451 | let symbol: &str = &self.tk_value.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.tk_value.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `chr` after checking its variant with `is_some` [INFO] [stdout] --> src/token.rs:512:20 [INFO] [stdout] | [INFO] [stdout] 511 | if chr.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = chr` [INFO] [stdout] 512 | if chr.unwrap() == '\n' { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:513:21 [INFO] [stdout] | [INFO] [stdout] 513 | line_count = line_count + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:611:9 [INFO] [stdout] | [INFO] [stdout] 611 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 611 - return -1; [INFO] [stdout] 611 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/token.rs:594:32 [INFO] [stdout] | [INFO] [stdout] 594 | let symbol: &str = &symbol[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/token.rs:593:9 [INFO] [stdout] | [INFO] [stdout] 593 | if symbol.starts_with("0x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 593 ~ if let Some(symbol) = symbol.strip_prefix("0x") { [INFO] [stdout] 594 ~ if u64::from_str_radix(&symbol, 16).is_ok() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 242 | return new_list_item; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return new_list_item; [INFO] [stdout] 242 + new_list_item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return Ok(true); [INFO] [stdout] 259 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:595:36 [INFO] [stdout] | [INFO] [stdout] 595 | if u64::from_str_radix(&symbol, 16).is_ok() { [INFO] [stdout] | ^^^^^^^ help: change this to: `symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/token.rs:600:32 [INFO] [stdout] | [INFO] [stdout] 600 | let symbol: &str = &symbol[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/token.rs:599:9 [INFO] [stdout] | [INFO] [stdout] 599 | if symbol.starts_with("0b") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 599 ~ if let Some(symbol) = symbol.strip_prefix("0b") { [INFO] [stdout] 600 ~ if u64::from_str_radix(&symbol, 2).is_ok() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:601:36 [INFO] [stdout] | [INFO] [stdout] 601 | if u64::from_str_radix(&symbol, 2).is_ok() { [INFO] [stdout] | ^^^^^^^ help: change this to: `symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:619:39 [INFO] [stdout] | [INFO] [stdout] 619 | let next = next_general_token(&script, cursor); [INFO] [stdout] | ^^^^^^^ help: change this to: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 267 | return Ok(ntk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - return Ok(ntk); [INFO] [stdout] 267 + Ok(ntk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:636:21 [INFO] [stdout] | [INFO] [stdout] 636 | line = line + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `line += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 275 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 - return Ok(false); [INFO] [stdout] 275 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:643:17 [INFO] [stdout] | [INFO] [stdout] 643 | line = line + count_line(&value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line += count_line(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 281 | return Ok(node); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return Ok(node); [INFO] [stdout] 281 + Ok(node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/token.rs:650:17 [INFO] [stdout] | [INFO] [stdout] 650 | line = line + count_line(&value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line += count_line(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | return Ok(node); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return Ok(node); [INFO] [stdout] 289 + Ok(node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | return Ok( AstNode::new(AstType::AST_NULL, tkr.line())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return Ok( AstNode::new(AstType::AST_NULL, tkr.line())); [INFO] [stdout] 291 + Ok( AstNode::new(AstType::AST_NULL, tkr.line())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 307 | return ast_identifier(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 307 - return ast_identifier(tkr); [INFO] [stdout] 307 + ast_identifier(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:673:61 [INFO] [stdout] | [INFO] [stdout] 673 | if let Ok((tk2, pos2)) = next_general_token(&script, cursor){ [INFO] [stdout] | ^^^^^^^ help: change this to: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/token.rs:677:73 [INFO] [stdout] | [INFO] [stdout] 677 | ... if let Ok((tk3, pos3)) = next_general_token(&script, pos2) { [INFO] [stdout] | ^^^^^^^ help: change this to: `script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:337:5 [INFO] [stdout] | [INFO] [stdout] 337 | return Ok(exp); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return Ok(exp); [INFO] [stdout] 337 + Ok(exp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:708:9 [INFO] [stdout] | [INFO] [stdout] 708 | / return Tokenlizer { [INFO] [stdout] 709 | | script: script, [INFO] [stdout] 710 | | cursor: 0, [INFO] [stdout] 711 | | line: 1, [INFO] [stdout] ... | [INFO] [stdout] 714 | | notin: false, [INFO] [stdout] 715 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 708 ~ Tokenlizer { [INFO] [stdout] 709 + script: script, [INFO] [stdout] 710 + cursor: 0, [INFO] [stdout] 711 + line: 1, [INFO] [stdout] 712 + forward_: LinkedList::new(), [INFO] [stdout] 713 + [INFO] [stdout] 714 + notin: false, [INFO] [stdout] 715 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:727:9 [INFO] [stdout] | [INFO] [stdout] 727 | return Ok(n); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 727 - return Ok(n); [INFO] [stdout] 727 + Ok(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/token.rs:719:12 [INFO] [stdout] | [INFO] [stdout] 719 | if self.forward_.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.forward_.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:739:9 [INFO] [stdout] | [INFO] [stdout] 739 | return Ok(n); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 739 - return Ok(n); [INFO] [stdout] 739 + Ok(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/token.rs:731:12 [INFO] [stdout] | [INFO] [stdout] 731 | if self.forward_.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.forward_.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:357:5 [INFO] [stdout] | [INFO] [stdout] 357 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 357 - return Ok(head); [INFO] [stdout] 357 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 751 | return Ok(n); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 751 - return Ok(n); [INFO] [stdout] 751 + Ok(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/token.rs:743:12 [INFO] [stdout] | [INFO] [stdout] 743 | if self.forward_.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.forward_.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/token.rs:755:9 [INFO] [stdout] | [INFO] [stdout] 755 | return self.line; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 755 - return self.line; [INFO] [stdout] 755 + self.line [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:364:5 [INFO] [stdout] | [INFO] [stdout] 364 | return ast_assignment(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 364 - return ast_assignment(tkr); [INFO] [stdout] 364 + ast_assignment(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:377:5 [INFO] [stdout] | [INFO] [stdout] 377 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 377 - return Ok(head); [INFO] [stdout] 377 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `ids` [INFO] [stdout] --> src/token.rs:765:18 [INFO] [stdout] | [INFO] [stdout] 765 | for i in 0..ids.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 765 - for i in 0..ids.len() { [INFO] [stdout] 765 + for (i, ) in ids.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/token.rs:795:47 [INFO] [stdout] | [INFO] [stdout] 794 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 795 | let (token, (cursor, line)) = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:454:5 [INFO] [stdout] | [INFO] [stdout] 454 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 454 - return Ok(head); [INFO] [stdout] 454 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:464:5 [INFO] [stdout] | [INFO] [stdout] 464 | return Ok(node); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 464 - return Ok(node); [INFO] [stdout] 464 + Ok(node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:484:5 [INFO] [stdout] | [INFO] [stdout] 484 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 484 - return Ok(a); [INFO] [stdout] 484 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 242 | return new_list_item; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return new_list_item; [INFO] [stdout] 242 + new_list_item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:501:5 [INFO] [stdout] | [INFO] [stdout] 501 | return ast_primary(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 501 - return ast_primary(tkr); [INFO] [stdout] 501 + ast_primary(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return Ok(true); [INFO] [stdout] 259 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 267 | return Ok(ntk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - return Ok(ntk); [INFO] [stdout] 267 + Ok(ntk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 275 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 - return Ok(false); [INFO] [stdout] 275 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 281 | return Ok(node); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return Ok(node); [INFO] [stdout] 281 + Ok(node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | return Ok(node); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return Ok(node); [INFO] [stdout] 289 + Ok(node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:526:5 [INFO] [stdout] | [INFO] [stdout] 526 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 526 - return Ok(a); [INFO] [stdout] 526 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:541:5 [INFO] [stdout] | [INFO] [stdout] 541 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 541 - return Ok(a); [INFO] [stdout] 541 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/ast.rs:531:8 [INFO] [stdout] | [INFO] [stdout] 531 | if tkr.new_line()? == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!tkr.new_line()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | return Ok( AstNode::new(AstType::AST_NULL, tkr.line())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return Ok( AstNode::new(AstType::AST_NULL, tkr.line())); [INFO] [stdout] 291 + Ok( AstNode::new(AstType::AST_NULL, tkr.line())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:590:5 [INFO] [stdout] | [INFO] [stdout] 590 | return ast_formula_postfix(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 590 - return ast_formula_postfix(tkr); [INFO] [stdout] 590 + ast_formula_postfix(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 307 | return ast_identifier(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 307 - return ast_identifier(tkr); [INFO] [stdout] 307 + ast_identifier(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:337:5 [INFO] [stdout] | [INFO] [stdout] 337 | return Ok(exp); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return Ok(exp); [INFO] [stdout] 337 + Ok(exp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:614:5 [INFO] [stdout] | [INFO] [stdout] 614 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 614 - return Ok(a); [INFO] [stdout] 614 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:357:5 [INFO] [stdout] | [INFO] [stdout] 357 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 357 - return Ok(head); [INFO] [stdout] 357 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:633:5 [INFO] [stdout] | [INFO] [stdout] 633 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 633 - return Ok(a); [INFO] [stdout] 633 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:364:5 [INFO] [stdout] | [INFO] [stdout] 364 | return ast_assignment(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 364 - return ast_assignment(tkr); [INFO] [stdout] 364 + ast_assignment(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:657:5 [INFO] [stdout] | [INFO] [stdout] 657 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 657 - return Ok(a); [INFO] [stdout] 657 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:377:5 [INFO] [stdout] | [INFO] [stdout] 377 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 377 - return Ok(head); [INFO] [stdout] 377 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:698:5 [INFO] [stdout] | [INFO] [stdout] 698 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 698 - return Ok(a); [INFO] [stdout] 698 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ast.rs:689:9 [INFO] [stdout] | [INFO] [stdout] 689 | / if !tkr.notin { [INFO] [stdout] 690 | | if tk_accept(tkr, TokenType::TK_IN)? { [INFO] [stdout] 691 | | let b = ast_formula_shift(tkr)?; [INFO] [stdout] 692 | | a = AstNode::new_a_b(AstType::EXP_IN, tkr.line(), a, b); [INFO] [stdout] ... | [INFO] [stdout] 695 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 689 ~ if !tkr.notin [INFO] [stdout] 690 ~ && tk_accept(tkr, TokenType::TK_IN)? { [INFO] [stdout] 691 | let b = ast_formula_shift(tkr)?; [INFO] [stdout] 692 | a = AstNode::new_a_b(AstType::EXP_IN, tkr.line(), a, b); [INFO] [stdout] 693 | continue; [INFO] [stdout] 694 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 727 - return Ok(a); [INFO] [stdout] 727 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:454:5 [INFO] [stdout] | [INFO] [stdout] 454 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 454 - return Ok(head); [INFO] [stdout] 454 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:736:5 [INFO] [stdout] | [INFO] [stdout] 736 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 736 - return Ok(a); [INFO] [stdout] 736 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:745:5 [INFO] [stdout] | [INFO] [stdout] 745 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 745 - return Ok(a); [INFO] [stdout] 745 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:464:5 [INFO] [stdout] | [INFO] [stdout] 464 | return Ok(node); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 464 - return Ok(node); [INFO] [stdout] 464 + Ok(node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:754:5 [INFO] [stdout] | [INFO] [stdout] 754 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 754 - return Ok(a); [INFO] [stdout] 754 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:763:5 [INFO] [stdout] | [INFO] [stdout] 763 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 763 - return Ok(a); [INFO] [stdout] 763 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:484:5 [INFO] [stdout] | [INFO] [stdout] 484 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 484 - return Ok(a); [INFO] [stdout] 484 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:772:5 [INFO] [stdout] | [INFO] [stdout] 772 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 772 - return Ok(a); [INFO] [stdout] 772 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:501:5 [INFO] [stdout] | [INFO] [stdout] 501 | return ast_primary(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 501 - return ast_primary(tkr); [INFO] [stdout] 501 + ast_primary(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:783:5 [INFO] [stdout] | [INFO] [stdout] 783 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 783 - return Ok(a); [INFO] [stdout] 783 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:838:5 [INFO] [stdout] | [INFO] [stdout] 838 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 838 - return Ok(a); [INFO] [stdout] 838 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:526:5 [INFO] [stdout] | [INFO] [stdout] 526 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 526 - return Ok(a); [INFO] [stdout] 526 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:541:5 [INFO] [stdout] | [INFO] [stdout] 541 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 541 - return Ok(a); [INFO] [stdout] 541 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/ast.rs:531:8 [INFO] [stdout] | [INFO] [stdout] 531 | if tkr.new_line()? == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!tkr.new_line()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:590:5 [INFO] [stdout] | [INFO] [stdout] 590 | return ast_formula_postfix(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 590 - return ast_formula_postfix(tkr); [INFO] [stdout] 590 + ast_formula_postfix(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:847:5 [INFO] [stdout] | [INFO] [stdout] 847 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 847 - return Ok(a); [INFO] [stdout] 847 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:858:5 [INFO] [stdout] | [INFO] [stdout] 858 | return Ok(exp); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 858 - return Ok(exp); [INFO] [stdout] 858 + Ok(exp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:869:5 [INFO] [stdout] | [INFO] [stdout] 869 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 869 - return Ok(head); [INFO] [stdout] 869 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:887:5 [INFO] [stdout] | [INFO] [stdout] 887 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 887 - return Ok(head); [INFO] [stdout] 887 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:614:5 [INFO] [stdout] | [INFO] [stdout] 614 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 614 - return Ok(a); [INFO] [stdout] 614 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:905:5 [INFO] [stdout] | [INFO] [stdout] 905 | return Err(format!("AST error: unexpected token in switch: {:?} @ {} (expected 'case' or 'default')", tkr.forward(), tkr.line())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 905 - return Err(format!("AST error: unexpected token in switch: {:?} @ {} (expected 'case' or 'default')", tkr.forward(), tkr.line())); [INFO] [stdout] 905 + Err(format!("AST error: unexpected token in switch: {:?} @ {} (expected 'case' or 'default')", tkr.forward(), tkr.line())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:633:5 [INFO] [stdout] | [INFO] [stdout] 633 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 633 - return Ok(a); [INFO] [stdout] 633 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:657:5 [INFO] [stdout] | [INFO] [stdout] 657 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 657 - return Ok(a); [INFO] [stdout] 657 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:927:5 [INFO] [stdout] | [INFO] [stdout] 927 | return Err(format!("unexpected token: {:?} (expected ';')", lookahead)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 927 - return Err(format!("unexpected token: {:?} (expected ';')", lookahead)); [INFO] [stdout] 927 + Err(format!("unexpected token: {:?} (expected ';')", lookahead)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:937:5 [INFO] [stdout] | [INFO] [stdout] 937 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 937 - return Ok(a); [INFO] [stdout] 937 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:989:5 [INFO] [stdout] | [INFO] [stdout] 989 | return Err(format!("unexpected token in for-statement: {:?}", tkr.forward())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 989 - return Err(format!("unexpected token in for-statement: {:?}", tkr.forward())); [INFO] [stdout] 989 + Err(format!("unexpected token in for-statement: {:?}", tkr.forward())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:698:5 [INFO] [stdout] | [INFO] [stdout] 698 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 698 - return Ok(a); [INFO] [stdout] 698 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ast.rs:689:9 [INFO] [stdout] | [INFO] [stdout] 689 | / if !tkr.notin { [INFO] [stdout] 690 | | if tk_accept(tkr, TokenType::TK_IN)? { [INFO] [stdout] 691 | | let b = ast_formula_shift(tkr)?; [INFO] [stdout] 692 | | a = AstNode::new_a_b(AstType::EXP_IN, tkr.line(), a, b); [INFO] [stdout] ... | [INFO] [stdout] 695 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 689 ~ if !tkr.notin [INFO] [stdout] 690 ~ && tk_accept(tkr, TokenType::TK_IN)? { [INFO] [stdout] 691 | let b = ast_formula_shift(tkr)?; [INFO] [stdout] 692 | a = AstNode::new_a_b(AstType::EXP_IN, tkr.line(), a, b); [INFO] [stdout] 693 | continue; [INFO] [stdout] 694 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 727 - return Ok(a); [INFO] [stdout] 727 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1001:5 [INFO] [stdout] | [INFO] [stdout] 1001 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1001 - return Ok(head); [INFO] [stdout] 1001 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1021:5 [INFO] [stdout] | [INFO] [stdout] 1021 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1021 - return Ok(head); [INFO] [stdout] 1021 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:736:5 [INFO] [stdout] | [INFO] [stdout] 736 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 736 - return Ok(a); [INFO] [stdout] 736 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:745:5 [INFO] [stdout] | [INFO] [stdout] 745 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 745 - return Ok(a); [INFO] [stdout] 745 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1028:5 [INFO] [stdout] | [INFO] [stdout] 1028 | return Ok( AstNode::new_a(AstType::STM_BLOCK, tkr.line(), a) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1028 - return Ok( AstNode::new_a(AstType::STM_BLOCK, tkr.line(), a) ); [INFO] [stdout] 1028 + Ok( AstNode::new_a(AstType::STM_BLOCK, tkr.line(), a) ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1186:5 [INFO] [stdout] | [INFO] [stdout] 1186 | return Ok(stm); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1186 - return Ok(stm); [INFO] [stdout] 1186 + Ok(stm) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ast.rs:1172:9 [INFO] [stdout] | [INFO] [stdout] 1172 | / if a.ast_type == AstType::EXP_IDENTIFIER { [INFO] [stdout] 1173 | | if tk_accept(tkr, TokenType::TK_COLON)? { [INFO] [stdout] 1174 | | a.ast_type = AstType::AST_IDENTIFIER; [INFO] [stdout] 1175 | | let b = ast_statement(tkr)?; [INFO] [stdout] ... | [INFO] [stdout] 1179 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1172 ~ if a.ast_type == AstType::EXP_IDENTIFIER [INFO] [stdout] 1173 ~ && tk_accept(tkr, TokenType::TK_COLON)? { [INFO] [stdout] 1174 | a.ast_type = AstType::AST_IDENTIFIER; [INFO] [stdout] ... [INFO] [stdout] 1177 | return Ok(stm); [INFO] [stdout] 1178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1205:5 [INFO] [stdout] | [INFO] [stdout] 1205 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1205 - return Ok(head); [INFO] [stdout] 1205 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/ast.rs:1192:8 [INFO] [stdout] | [INFO] [stdout] 1192 | if tk_accept(tkr, TokenType::TK_BRACE_RIGHT)? == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tk_accept(tkr, TokenType::TK_BRACE_RIGHT)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/ast.rs:1200:11 [INFO] [stdout] | [INFO] [stdout] 1200 | while tk_accept(tkr, TokenType::TK_BRACE_RIGHT)? == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!tk_accept(tkr, TokenType::TK_BRACE_RIGHT)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1216:5 [INFO] [stdout] | [INFO] [stdout] 1216 | return Ok(func); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1216 - return Ok(func); [INFO] [stdout] 1216 + Ok(func) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1223:5 [INFO] [stdout] | [INFO] [stdout] 1223 | return ast_statement(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1223 - return ast_statement(tkr); [INFO] [stdout] 1223 + ast_statement(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1242:5 [INFO] [stdout] | [INFO] [stdout] 1242 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1242 - return Ok(head); [INFO] [stdout] 1242 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/ast.rs:1237:11 [INFO] [stdout] | [INFO] [stdout] 1237 | while tk_accept(&mut tkr, TokenType::TK_EOF)? == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!tk_accept(&mut tkr, TokenType::TK_EOF)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Rc>` [INFO] [stdout] --> src/bytecode.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 233 | pub func_tab: Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Box` is already on the heap, `Rc>` makes an extra allocation [INFO] [stdout] = help: consider using just `Rc` or `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation [INFO] [stdout] = note: `#[warn(clippy::redundant_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / return AstListIterator { [INFO] [stdout] 15 | | cursor: Some(lst), [INFO] [stdout] 16 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ AstListIterator { [INFO] [stdout] 15 + cursor: Some(lst), [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/compile.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if !node.b.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `node.b.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node.b` after checking its variant with `is_none` [INFO] [stdout] --> src/compile.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 29 | if !node.b.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 30 | self.cursor = Some( node.b.as_ref().unwrap() ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return Some(node.a.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Some(node.a.as_ref().unwrap()); [INFO] [stdout] 32 + Some(node.a.as_ref().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/compile.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / if self.cursor.is_none() { [INFO] [stdout] 25 | | return None; [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.cursor?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return self.a.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return self.a.as_ref().unwrap(); [INFO] [stdout] 43 + self.a.as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return self.b.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return self.b.as_ref().unwrap(); [INFO] [stdout] 46 + self.b.as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return self.c.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return self.c.as_ref().unwrap(); [INFO] [stdout] 49 + self.c.as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return self.d.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return self.d.as_ref().unwrap(); [INFO] [stdout] 52 + self.d.as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return false; [INFO] [stdout] 75 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return false; [INFO] [stdout] 82 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return false; [INFO] [stdout] 102 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:754:5 [INFO] [stdout] | [INFO] [stdout] 754 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 754 - return Ok(a); [INFO] [stdout] 754 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:763:5 [INFO] [stdout] | [INFO] [stdout] 763 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 763 - return Ok(a); [INFO] [stdout] 763 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:772:5 [INFO] [stdout] | [INFO] [stdout] 772 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 772 - return Ok(a); [INFO] [stdout] 772 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:783:5 [INFO] [stdout] | [INFO] [stdout] 783 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 783 - return Ok(a); [INFO] [stdout] 783 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:838:5 [INFO] [stdout] | [INFO] [stdout] 838 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 838 - return Ok(a); [INFO] [stdout] 838 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:847:5 [INFO] [stdout] | [INFO] [stdout] 847 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 847 - return Ok(a); [INFO] [stdout] 847 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:858:5 [INFO] [stdout] | [INFO] [stdout] 858 | return Ok(exp); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 858 - return Ok(exp); [INFO] [stdout] 858 + Ok(exp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:869:5 [INFO] [stdout] | [INFO] [stdout] 869 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 869 - return Ok(head); [INFO] [stdout] 869 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:887:5 [INFO] [stdout] | [INFO] [stdout] 887 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 887 - return Ok(head); [INFO] [stdout] 887 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:905:5 [INFO] [stdout] | [INFO] [stdout] 905 | return Err(format!("AST error: unexpected token in switch: {:?} @ {} (expected 'case' or 'default')", tkr.forward(), tkr.line())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 905 - return Err(format!("AST error: unexpected token in switch: {:?} @ {} (expected 'case' or 'default')", tkr.forward(), tkr.line())); [INFO] [stdout] 905 + Err(format!("AST error: unexpected token in switch: {:?} @ {} (expected 'case' or 'default')", tkr.forward(), tkr.line())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:927:5 [INFO] [stdout] | [INFO] [stdout] 927 | return Err(format!("unexpected token: {:?} (expected ';')", lookahead)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 927 - return Err(format!("unexpected token: {:?} (expected ';')", lookahead)); [INFO] [stdout] 927 + Err(format!("unexpected token: {:?} (expected ';')", lookahead)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:937:5 [INFO] [stdout] | [INFO] [stdout] 937 | return Ok(a); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 937 - return Ok(a); [INFO] [stdout] 937 + Ok(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:989:5 [INFO] [stdout] | [INFO] [stdout] 989 | return Err(format!("unexpected token in for-statement: {:?}", tkr.forward())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 989 - return Err(format!("unexpected token in for-statement: {:?}", tkr.forward())); [INFO] [stdout] 989 + Err(format!("unexpected token in for-statement: {:?}", tkr.forward())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1001:5 [INFO] [stdout] | [INFO] [stdout] 1001 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1001 - return Ok(head); [INFO] [stdout] 1001 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return l; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return l; [INFO] [stdout] 116 + l [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/compile.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if self.is_list() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.is_list()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/compile.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | l = l + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `l += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | return AstListIterator::new(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return AstListIterator::new(self); [INFO] [stdout] 120 + AstListIterator::new(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | return addr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return addr; [INFO] [stdout] 163 + addr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | return r as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return r as u16; [INFO] [stdout] 199 + r as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | return (false, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return (false, 0); [INFO] [stdout] 207 + (false, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | return r as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 - return r as u16; [INFO] [stdout] 219 + r as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1021:5 [INFO] [stdout] | [INFO] [stdout] 1021 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1021 - return Ok(head); [INFO] [stdout] 1021 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1028:5 [INFO] [stdout] | [INFO] [stdout] 1028 | return Ok( AstNode::new_a(AstType::STM_BLOCK, tkr.line(), a) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1028 - return Ok( AstNode::new_a(AstType::STM_BLOCK, tkr.line(), a) ); [INFO] [stdout] 1028 + Ok( AstNode::new_a(AstType::STM_BLOCK, tkr.line(), a) ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1186:5 [INFO] [stdout] | [INFO] [stdout] 1186 | return Ok(stm); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1186 - return Ok(stm); [INFO] [stdout] 1186 + Ok(stm) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | return self.code.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return self.code.len(); [INFO] [stdout] 223 + self.code.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ast.rs:1172:9 [INFO] [stdout] | [INFO] [stdout] 1172 | / if a.ast_type == AstType::EXP_IDENTIFIER { [INFO] [stdout] 1173 | | if tk_accept(tkr, TokenType::TK_COLON)? { [INFO] [stdout] 1174 | | a.ast_type = AstType::AST_IDENTIFIER; [INFO] [stdout] 1175 | | let b = ast_statement(tkr)?; [INFO] [stdout] ... | [INFO] [stdout] 1179 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1172 ~ if a.ast_type == AstType::EXP_IDENTIFIER [INFO] [stdout] 1173 ~ && tk_accept(tkr, TokenType::TK_COLON)? { [INFO] [stdout] 1174 | a.ast_type = AstType::AST_IDENTIFIER; [INFO] [stdout] ... [INFO] [stdout] 1177 | return Ok(stm); [INFO] [stdout] 1178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1205:5 [INFO] [stdout] | [INFO] [stdout] 1205 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1205 - return Ok(head); [INFO] [stdout] 1205 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/ast.rs:1192:8 [INFO] [stdout] | [INFO] [stdout] 1192 | if tk_accept(tkr, TokenType::TK_BRACE_RIGHT)? == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tk_accept(tkr, TokenType::TK_BRACE_RIGHT)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/ast.rs:1200:11 [INFO] [stdout] | [INFO] [stdout] 1200 | while tk_accept(tkr, TokenType::TK_BRACE_RIGHT)? == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!tk_accept(tkr, TokenType::TK_BRACE_RIGHT)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1216:5 [INFO] [stdout] | [INFO] [stdout] 1216 | return Ok(func); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1216 - return Ok(func); [INFO] [stdout] 1216 + Ok(func) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | return brk_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return brk_index; [INFO] [stdout] 281 + brk_index [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1223:5 [INFO] [stdout] | [INFO] [stdout] 1223 | return ast_statement(tkr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1223 - return ast_statement(tkr); [INFO] [stdout] 1223 + ast_statement(tkr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/compile.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | / if label.eq(name) { [INFO] [stdout] 274 | | brk_index = i + 1; [INFO] [stdout] 275 | | return brk_index; [INFO] [stdout] 276 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 272 ~ VMJumpScope::LabelSection(label) [INFO] [stdout] 273 ~ if label.eq(name) => { [INFO] [stdout] 274 | brk_index = i + 1; [INFO] [stdout] 275 | return brk_index; [INFO] [stdout] 276 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast.rs:1242:5 [INFO] [stdout] | [INFO] [stdout] 1242 | return Ok(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1242 - return Ok(head); [INFO] [stdout] 1242 + Ok(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compile.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 271 | / match &self.jumps[i].scope { [INFO] [stdout] 272 | | VMJumpScope::LabelSection(label) => { [INFO] [stdout] 273 | | if label.eq(name) { [INFO] [stdout] 274 | | brk_index = i + 1; [INFO] [stdout] ... | [INFO] [stdout] 278 | | _ => {} [INFO] [stdout] 279 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 271 ~ if let VMJumpScope::LabelSection(label) = &self.jumps[i].scope { [INFO] [stdout] 272 + if label.eq(name) { [INFO] [stdout] 273 + brk_index = i + 1; [INFO] [stdout] 274 + return brk_index; [INFO] [stdout] 275 + } [INFO] [stdout] 276 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | return brk_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return brk_index; [INFO] [stdout] 295 + brk_index [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/ast.rs:1237:11 [INFO] [stdout] | [INFO] [stdout] 1237 | while tk_accept(&mut tkr, TokenType::TK_EOF)? == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!tk_accept(&mut tkr, TokenType::TK_EOF)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | return brk_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 - return brk_index; [INFO] [stdout] 309 + brk_index [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | return r as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 319 - return r as u16; [INFO] [stdout] 319 + r as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 373 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - } [INFO] [stdout] 373 - return; [INFO] [stdout] 372 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compile.rs:367:47 [INFO] [stdout] | [INFO] [stdout] 367 | let vid = self.addstring( &name ); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/compile.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:612:5 [INFO] [stdout] | [INFO] [stdout] 612 | return num; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 612 - return num; [INFO] [stdout] 612 + num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/compile.rs:610:9 [INFO] [stdout] | [INFO] [stdout] 610 | num = num + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `num += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Rc>` [INFO] [stdout] --> src/bytecode.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 233 | pub func_tab: Vec>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Box` is already on the heap, `Rc>` makes an extra allocation [INFO] [stdout] = help: consider using just `Rc` or `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation [INFO] [stdout] = note: `#[warn(clippy::redundant_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / return AstListIterator { [INFO] [stdout] 15 | | cursor: Some(lst), [INFO] [stdout] 16 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ AstListIterator { [INFO] [stdout] 15 + cursor: Some(lst), [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/compile.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if !node.b.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `node.b.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node.b` after checking its variant with `is_none` [INFO] [stdout] --> src/compile.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 29 | if !node.b.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 30 | self.cursor = Some( node.b.as_ref().unwrap() ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return Some(node.a.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Some(node.a.as_ref().unwrap()); [INFO] [stdout] 32 + Some(node.a.as_ref().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/compile.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / if self.cursor.is_none() { [INFO] [stdout] 25 | | return None; [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.cursor?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return self.a.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return self.a.as_ref().unwrap(); [INFO] [stdout] 43 + self.a.as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return self.b.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return self.b.as_ref().unwrap(); [INFO] [stdout] 46 + self.b.as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return self.c.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return self.c.as_ref().unwrap(); [INFO] [stdout] 49 + self.c.as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return self.d.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return self.d.as_ref().unwrap(); [INFO] [stdout] 52 + self.d.as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return false; [INFO] [stdout] 75 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return false; [INFO] [stdout] 82 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return false; [INFO] [stdout] 102 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return l; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return l; [INFO] [stdout] 116 + l [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/compile.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if self.is_list() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.is_list()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/compile.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | l = l + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `l += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | return AstListIterator::new(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return AstListIterator::new(self); [INFO] [stdout] 120 + AstListIterator::new(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stm_d` after checking its variant with `is_some` [INFO] [stdout] --> src/compile.rs:909:36 [INFO] [stdout] | [INFO] [stdout] 908 | if stm_d.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = &stm_d` [INFO] [stdout] 909 | compile_stm(f, stm_d.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/compile.rs:900:8 [INFO] [stdout] | [INFO] [stdout] 900 | if f.jumps.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `f.jumps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:941:5 [INFO] [stdout] | [INFO] [stdout] 941 | let l1:usize; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 946 | l1 = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `l1` here [INFO] [stdout] | [INFO] [stdout] 941 ~ [INFO] [stdout] 942 | let l2:usize; [INFO] [stdout] ... [INFO] [stdout] 945 | f.new_scope(VMJumpScope::TryScope(Some(finally_block.clone()))); [INFO] [stdout] 946 ~ let l1:usize = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | return addr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return addr; [INFO] [stdout] 163 + addr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:979:5 [INFO] [stdout] | [INFO] [stdout] 979 | let l1:usize; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 983 | l1 = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `l1` here [INFO] [stdout] | [INFO] [stdout] 979 ~ [INFO] [stdout] 980 | let l2:usize; [INFO] [stdout] 981 | [INFO] [stdout] 982 | f.new_scope(VMJumpScope::TryScope(None)); [INFO] [stdout] 983 ~ let l1:usize = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | return r as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return r as u16; [INFO] [stdout] 199 + r as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:1004:5 [INFO] [stdout] | [INFO] [stdout] 1004 | let l1:usize; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] 1005 | [INFO] [stdout] 1006 | l1 = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `l1` here [INFO] [stdout] | [INFO] [stdout] 1004 ~ [INFO] [stdout] 1005 | [INFO] [stdout] 1006 ~ let l1:usize = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | return (false, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return (false, 0); [INFO] [stdout] 207 + (false, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/compile.rs:1037:20 [INFO] [stdout] | [INFO] [stdout] 1037 | if !def.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `def.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | return r as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 - return r as u16; [INFO] [stdout] 219 + r as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | return self.code.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return self.code.len(); [INFO] [stdout] 223 + self.code.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/compile.rs:1060:17 [INFO] [stdout] | [INFO] [stdout] 1060 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:1108:5 [INFO] [stdout] | [INFO] [stdout] 1108 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1107 - f.emitop(OpcodeType::OP_POP); [INFO] [stdout] 1108 - return; [INFO] [stdout] 1107 + f.emitop(OpcodeType::OP_POP); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | return brk_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return brk_index; [INFO] [stdout] 281 + brk_index [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stm.c` after checking its variant with `is_some` [INFO] [stdout] --> src/compile.rs:1128:32 [INFO] [stdout] | [INFO] [stdout] 1125 | if stm.c.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = &stm.c` [INFO] [stdout] ... [INFO] [stdout] 1128 | compile_stm(f, stm.c.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:1332:5 [INFO] [stdout] | [INFO] [stdout] 1332 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1332 - return false; [INFO] [stdout] 1332 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/compile.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | / if label.eq(name) { [INFO] [stdout] 274 | | brk_index = i + 1; [INFO] [stdout] 275 | | return brk_index; [INFO] [stdout] 276 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 272 ~ VMJumpScope::LabelSection(label) [INFO] [stdout] 273 ~ if label.eq(name) => { [INFO] [stdout] 274 | brk_index = i + 1; [INFO] [stdout] 275 | return brk_index; [INFO] [stdout] 276 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:1246:13 [INFO] [stdout] | [INFO] [stdout] 1246 | let break_scope: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `break_scope` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1246 ~ [INFO] [stdout] 1247 | [INFO] [stdout] 1248 ~ let break_scope: usize = if !a.is_null() { [INFO] [stdout] 1249 | let break_target = a.str(); [INFO] [stdout] 1250 ~ f.target_scope_by_name(break_target) [INFO] [stdout] 1251 | } else { [INFO] [stdout] 1252 ~ f.target_break_scope() [INFO] [stdout] 1253 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:1266:13 [INFO] [stdout] | [INFO] [stdout] 1266 | let continue_scope: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `continue_scope` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1266 ~ [INFO] [stdout] 1267 | [INFO] [stdout] 1268 ~ let continue_scope: usize = if !a.is_null() { [INFO] [stdout] 1269 | let continue_target = a.str(); [INFO] [stdout] 1270 ~ f.target_scope_by_name(continue_target) [INFO] [stdout] 1271 | } else { [INFO] [stdout] 1272 ~ f.target_continue_scope() [INFO] [stdout] 1273 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:1343:5 [INFO] [stdout] | [INFO] [stdout] 1343 | return last_stm; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1343 - return last_stm; [INFO] [stdout] 1343 + last_stm [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:1389:5 [INFO] [stdout] | [INFO] [stdout] 1389 | return Ok(f); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1389 - return Ok(f); [INFO] [stdout] 1389 + Ok(f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/compile.rs:1375:12 [INFO] [stdout] | [INFO] [stdout] 1375 | if ret == true { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:125:3 [INFO] [stdout] | [INFO] [stdout] 125 | return anonymous; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return anonymous; [INFO] [stdout] 125 + anonymous [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:132:4 [INFO] [stdout] | [INFO] [stdout] 132 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:143:3 [INFO] [stdout] | [INFO] [stdout] 143 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return value; [INFO] [stdout] 143 + value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:142:3 [INFO] [stdout] | [INFO] [stdout] 142 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:156:3 [INFO] [stdout] | [INFO] [stdout] 156 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return value; [INFO] [stdout] 156 + value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:155:3 [INFO] [stdout] | [INFO] [stdout] 155 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:168:3 [INFO] [stdout] | [INFO] [stdout] 168 | return &self.str_tab[id]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return &self.str_tab[id]; [INFO] [stdout] 168 + &self.str_tab[id] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:167:3 [INFO] [stdout] | [INFO] [stdout] 167 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:179:3 [INFO] [stdout] | [INFO] [stdout] 179 | return self.func_tab[id].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return self.func_tab[id].clone(); [INFO] [stdout] 179 + self.func_tab[id].clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:178:3 [INFO] [stdout] | [INFO] [stdout] 178 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:184:3 [INFO] [stdout] | [INFO] [stdout] 184 | return addr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return addr; [INFO] [stdout] 184 + addr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:183:3 [INFO] [stdout] | [INFO] [stdout] 183 | *pc = *pc + 2; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:222:3 [INFO] [stdout] | [INFO] [stdout] 222 | return sv; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return sv; [INFO] [stdout] 222 + sv [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:274:3 [INFO] [stdout] | [INFO] [stdout] 274 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return false; [INFO] [stdout] 274 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:281:3 [INFO] [stdout] | [INFO] [stdout] 281 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return false; [INFO] [stdout] 281 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:291:3 [INFO] [stdout] | [INFO] [stdout] 291 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return true; [INFO] [stdout] 291 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:298:3 [INFO] [stdout] | [INFO] [stdout] 298 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return false; [INFO] [stdout] 298 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:312:3 [INFO] [stdout] | [INFO] [stdout] 312 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 312 - return false; [INFO] [stdout] 312 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compile.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 271 | / match &self.jumps[i].scope { [INFO] [stdout] 272 | | VMJumpScope::LabelSection(label) => { [INFO] [stdout] 273 | | if label.eq(name) { [INFO] [stdout] 274 | | brk_index = i + 1; [INFO] [stdout] ... | [INFO] [stdout] 278 | | _ => {} [INFO] [stdout] 279 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 271 ~ if let VMJumpScope::LabelSection(label) = &self.jumps[i].scope { [INFO] [stdout] 272 + if label.eq(name) { [INFO] [stdout] 273 + brk_index = i + 1; [INFO] [stdout] 274 + return brk_index; [INFO] [stdout] 275 + } [INFO] [stdout] 276 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | return brk_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return brk_index; [INFO] [stdout] 295 + brk_index [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | return brk_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 - return brk_index; [INFO] [stdout] 309 + brk_index [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | return r as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 319 - return r as u16; [INFO] [stdout] 319 + r as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 373 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - } [INFO] [stdout] 373 - return; [INFO] [stdout] 372 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compile.rs:367:47 [INFO] [stdout] | [INFO] [stdout] 367 | let vid = self.addstring( &name ); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/compile.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:612:5 [INFO] [stdout] | [INFO] [stdout] 612 | return num; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 612 - return num; [INFO] [stdout] 612 + num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/compile.rs:610:9 [INFO] [stdout] | [INFO] [stdout] 610 | num = num + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `num += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stm_d` after checking its variant with `is_some` [INFO] [stdout] --> src/compile.rs:909:36 [INFO] [stdout] | [INFO] [stdout] 908 | if stm_d.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = &stm_d` [INFO] [stdout] 909 | compile_stm(f, stm_d.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/compile.rs:900:8 [INFO] [stdout] | [INFO] [stdout] 900 | if f.jumps.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `f.jumps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:941:5 [INFO] [stdout] | [INFO] [stdout] 941 | let l1:usize; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 946 | l1 = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `l1` here [INFO] [stdout] | [INFO] [stdout] 941 ~ [INFO] [stdout] 942 | let l2:usize; [INFO] [stdout] ... [INFO] [stdout] 945 | f.new_scope(VMJumpScope::TryScope(Some(finally_block.clone()))); [INFO] [stdout] 946 ~ let l1:usize = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:979:5 [INFO] [stdout] | [INFO] [stdout] 979 | let l1:usize; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 983 | l1 = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `l1` here [INFO] [stdout] | [INFO] [stdout] 979 ~ [INFO] [stdout] 980 | let l2:usize; [INFO] [stdout] 981 | [INFO] [stdout] 982 | f.new_scope(VMJumpScope::TryScope(None)); [INFO] [stdout] 983 ~ let l1:usize = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:1004:5 [INFO] [stdout] | [INFO] [stdout] 1004 | let l1:usize; [INFO] [stdout] | ^^^^^^^^^^^^^ created here [INFO] [stdout] 1005 | [INFO] [stdout] 1006 | l1 = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `l1` here [INFO] [stdout] | [INFO] [stdout] 1004 ~ [INFO] [stdout] 1005 | [INFO] [stdout] 1006 ~ let l1:usize = f.emitjump(OpcodeType::OP_TRY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/compile.rs:1037:20 [INFO] [stdout] | [INFO] [stdout] 1037 | if !def.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `def.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/compile.rs:1060:17 [INFO] [stdout] | [INFO] [stdout] 1060 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:1108:5 [INFO] [stdout] | [INFO] [stdout] 1108 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1107 - f.emitop(OpcodeType::OP_POP); [INFO] [stdout] 1108 - return; [INFO] [stdout] 1107 + f.emitop(OpcodeType::OP_POP); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stm.c` after checking its variant with `is_some` [INFO] [stdout] --> src/compile.rs:1128:32 [INFO] [stdout] | [INFO] [stdout] 1125 | if stm.c.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = &stm.c` [INFO] [stdout] ... [INFO] [stdout] 1128 | compile_stm(f, stm.c.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:1332:5 [INFO] [stdout] | [INFO] [stdout] 1332 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1332 - return false; [INFO] [stdout] 1332 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:332:3 [INFO] [stdout] | [INFO] [stdout] 332 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 332 - return true; [INFO] [stdout] 332 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:339:3 [INFO] [stdout] | [INFO] [stdout] 339 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 339 - return false; [INFO] [stdout] 339 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:1246:13 [INFO] [stdout] | [INFO] [stdout] 1246 | let break_scope: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `break_scope` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1246 ~ [INFO] [stdout] 1247 | [INFO] [stdout] 1248 ~ let break_scope: usize = if !a.is_null() { [INFO] [stdout] 1249 | let break_target = a.str(); [INFO] [stdout] 1250 ~ f.target_scope_by_name(break_target) [INFO] [stdout] 1251 | } else { [INFO] [stdout] 1252 ~ f.target_break_scope() [INFO] [stdout] 1253 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:359:3 [INFO] [stdout] | [INFO] [stdout] 359 | return std::f64::NAN; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 359 - return std::f64::NAN; [INFO] [stdout] 359 + std::f64::NAN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/compile.rs:1266:13 [INFO] [stdout] | [INFO] [stdout] 1266 | let continue_scope: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `continue_scope` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1266 ~ [INFO] [stdout] 1267 | [INFO] [stdout] 1268 ~ let continue_scope: usize = if !a.is_null() { [INFO] [stdout] 1269 | let continue_target = a.str(); [INFO] [stdout] 1270 ~ f.target_scope_by_name(continue_target) [INFO] [stdout] 1271 | } else { [INFO] [stdout] 1272 ~ f.target_continue_scope() [INFO] [stdout] 1273 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/value.rs:359:10 [INFO] [stdout] | [INFO] [stdout] 359 | return std::f64::NAN; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 359 - return std::f64::NAN; [INFO] [stdout] 359 + return f64::NAN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:366:3 [INFO] [stdout] | [INFO] [stdout] 366 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return false; [INFO] [stdout] 366 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:372:5 [INFO] [stdout] | [INFO] [stdout] 372 | return "undefined".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - return "undefined".to_string(); [INFO] [stdout] 372 + "undefined".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:375:5 [INFO] [stdout] | [INFO] [stdout] 375 | return "object".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 375 - return "object".to_string(); [INFO] [stdout] 375 + "object".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:378:5 [INFO] [stdout] | [INFO] [stdout] 378 | return "boolean".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 378 - return "boolean".to_string(); [INFO] [stdout] 378 + "boolean".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:381:5 [INFO] [stdout] | [INFO] [stdout] 381 | return "number".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return "number".to_string(); [INFO] [stdout] 381 + "number".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:1343:5 [INFO] [stdout] | [INFO] [stdout] 1343 | return last_stm; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1343 - return last_stm; [INFO] [stdout] 1343 + last_stm [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compile.rs:1389:5 [INFO] [stdout] | [INFO] [stdout] 1389 | return Ok(f); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1389 - return Ok(f); [INFO] [stdout] 1389 + Ok(f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:393:3 [INFO] [stdout] | [INFO] [stdout] 393 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 393 - return false; [INFO] [stdout] 393 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/compile.rs:1375:12 [INFO] [stdout] | [INFO] [stdout] 1375 | if ret == true { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `value::SharedValue` [INFO] [stdout] --> src/value.rs:395:2 [INFO] [stdout] | [INFO] [stdout] 395 | / pub fn to_string(&self) -> String { [INFO] [stdout] 396 | | let v = self.v.borrow(); [INFO] [stdout] 397 | | match &*v { [INFO] [stdout] 398 | | JsValue::JSUndefined => { [INFO] [stdout] ... | [INFO] [stdout] 433 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `value::SharedValue` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 399 | return "undefined".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return "undefined".to_string(); [INFO] [stdout] 399 + "undefined".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:402:5 [INFO] [stdout] | [INFO] [stdout] 402 | return "null".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 402 - return "null".to_string(); [INFO] [stdout] 402 + "null".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:406:6 [INFO] [stdout] | [INFO] [stdout] 406 | return "true".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return "true".to_string(); [INFO] [stdout] 406 + "true".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:408:6 [INFO] [stdout] | [INFO] [stdout] 408 | return "false".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 408 - return "false".to_string(); [INFO] [stdout] 408 + "false".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:412:5 [INFO] [stdout] | [INFO] [stdout] 412 | return num.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 412 - return num.to_string(); [INFO] [stdout] 412 + num.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:427:6 [INFO] [stdout] | [INFO] [stdout] 427 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 427 - return result; [INFO] [stdout] 427 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:429:6 [INFO] [stdout] | [INFO] [stdout] 429 | return format!("[object:_{}_]", obj.borrow().type_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - return format!("[object:_{}_]", obj.borrow().type_string()); [INFO] [stdout] 429 + format!("[object:_{}_]", obj.borrow().type_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:125:3 [INFO] [stdout] | [INFO] [stdout] 125 | return anonymous; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return anonymous; [INFO] [stdout] 125 + anonymous [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JsProperty` [INFO] [stdout] --> src/value.rs:438:2 [INFO] [stdout] | [INFO] [stdout] 438 | / pub fn new() -> Self { [INFO] [stdout] 439 | | JsProperty { [INFO] [stdout] 440 | | value: SharedValue::new_undefined(), [INFO] [stdout] 441 | | attr_writable: true, [INFO] [stdout] ... | [INFO] [stdout] 447 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 437 + impl Default for JsProperty { [INFO] [stdout] 438 + fn default() -> Self { [INFO] [stdout] 439 + Self::new() [INFO] [stdout] 440 + } [INFO] [stdout] 441 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:453:3 [INFO] [stdout] | [INFO] [stdout] 453 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return true; [INFO] [stdout] 453 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:456:3 [INFO] [stdout] | [INFO] [stdout] 456 | return self.attr_enumerable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 - return self.attr_enumerable; [INFO] [stdout] 456 + self.attr_enumerable [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:132:4 [INFO] [stdout] | [INFO] [stdout] 132 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:459:3 [INFO] [stdout] | [INFO] [stdout] 459 | return self.attr_configurable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 459 - return self.attr_configurable; [INFO] [stdout] 459 + self.attr_configurable [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:143:3 [INFO] [stdout] | [INFO] [stdout] 143 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return value; [INFO] [stdout] 143 + value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:142:3 [INFO] [stdout] | [INFO] [stdout] 142 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:156:3 [INFO] [stdout] | [INFO] [stdout] 156 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return value; [INFO] [stdout] 156 + value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/value.rs:493:12 [INFO] [stdout] | [INFO] [stdout] 493 | for x in (*target).properties.keys() { [INFO] [stdout] | ^^^^^^^^^ help: try: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:155:3 [INFO] [stdout] | [INFO] [stdout] 155 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> src/value.rs:503:2 [INFO] [stdout] | [INFO] [stdout] 503 | / pub fn next(&mut self) -> Option { [INFO] [stdout] 504 | | if self.index >= self.keys.len() { [INFO] [stdout] 505 | | return None; [INFO] [stdout] ... | [INFO] [stdout] 509 | | return Some(s); [INFO] [stdout] 510 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:509:3 [INFO] [stdout] | [INFO] [stdout] 509 | return Some(s); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 509 - return Some(s); [INFO] [stdout] 509 + Some(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:168:3 [INFO] [stdout] | [INFO] [stdout] 168 | return &self.str_tab[id]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return &self.str_tab[id]; [INFO] [stdout] 168 + &self.str_tab[id] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:508:3 [INFO] [stdout] | [INFO] [stdout] 508 | self.index = self.index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:167:3 [INFO] [stdout] | [INFO] [stdout] 167 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JsObject` [INFO] [stdout] --> src/value.rs:514:5 [INFO] [stdout] | [INFO] [stdout] 514 | / pub fn new() -> JsObject { [INFO] [stdout] 515 | | JsObject { [INFO] [stdout] 516 | | extensible: true, [INFO] [stdout] 517 | | __proto__: None, [INFO] [stdout] ... | [INFO] [stdout] 521 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 513 + impl Default for JsObject { [INFO] [stdout] 514 + fn default() -> Self { [INFO] [stdout] 515 + Self::new() [INFO] [stdout] 516 + } [INFO] [stdout] 517 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:179:3 [INFO] [stdout] | [INFO] [stdout] 179 | return self.func_tab[id].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return self.func_tab[id].clone(); [INFO] [stdout] 179 + self.func_tab[id].clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:178:3 [INFO] [stdout] | [INFO] [stdout] 178 | *pc = *pc + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:184:3 [INFO] [stdout] | [INFO] [stdout] 184 | return addr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return addr; [INFO] [stdout] 184 + addr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:183:3 [INFO] [stdout] | [INFO] [stdout] 183 | *pc = *pc + 2; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*pc += 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:605:3 [INFO] [stdout] | [INFO] [stdout] 605 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 605 - return false; [INFO] [stdout] 605 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:611:3 [INFO] [stdout] | [INFO] [stdout] 611 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 611 - return false; [INFO] [stdout] 611 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:623:3 [INFO] [stdout] | [INFO] [stdout] 623 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 623 - return false; [INFO] [stdout] 623 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:222:3 [INFO] [stdout] | [INFO] [stdout] 222 | return sv; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return sv; [INFO] [stdout] 222 + sv [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:274:3 [INFO] [stdout] | [INFO] [stdout] 274 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return false; [INFO] [stdout] 274 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:281:3 [INFO] [stdout] | [INFO] [stdout] 281 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return false; [INFO] [stdout] 281 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:291:3 [INFO] [stdout] | [INFO] [stdout] 291 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return true; [INFO] [stdout] 291 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:635:3 [INFO] [stdout] | [INFO] [stdout] 635 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 635 - return false; [INFO] [stdout] 635 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:647:3 [INFO] [stdout] | [INFO] [stdout] 647 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 647 - return false; [INFO] [stdout] 647 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:659:3 [INFO] [stdout] | [INFO] [stdout] 659 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 659 - return false; [INFO] [stdout] 659 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:671:3 [INFO] [stdout] | [INFO] [stdout] 671 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 671 - return false; [INFO] [stdout] 671 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:689:3 [INFO] [stdout] | [INFO] [stdout] 689 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 689 - return false; [INFO] [stdout] 689 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:701:3 [INFO] [stdout] | [INFO] [stdout] 701 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 701 - return false; [INFO] [stdout] 701 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:298:3 [INFO] [stdout] | [INFO] [stdout] 298 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return false; [INFO] [stdout] 298 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `r` after checking its variant with `is_some` [INFO] [stdout] --> src/value.rs:708:17 [INFO] [stdout] | [INFO] [stdout] 707 | if r.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = r` [INFO] [stdout] 708 | return Some((r.unwrap().clone(), true)); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.__proto__` after checking its variant with `is_some` [INFO] [stdout] --> src/value.rs:712:16 [INFO] [stdout] | [INFO] [stdout] 711 | if self.__proto__.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.__proto__` [INFO] [stdout] 712 | let proto = self.__proto__.as_ref().unwrap().borrow(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_some` [INFO] [stdout] --> src/value.rs:715:18 [INFO] [stdout] | [INFO] [stdout] 714 | if result.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = result` [INFO] [stdout] 715 | return Some((result.unwrap().0, false)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:719:3 [INFO] [stdout] | [INFO] [stdout] 719 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 719 - return None; [INFO] [stdout] 719 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:312:3 [INFO] [stdout] | [INFO] [stdout] 312 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 312 - return false; [INFO] [stdout] 312 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:722:3 [INFO] [stdout] | [INFO] [stdout] 722 | return self.properties.get(name).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 722 - return self.properties.get(name).unwrap().clone(); [INFO] [stdout] 722 + self.properties.get(name).unwrap().clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:736:3 [INFO] [stdout] | [INFO] [stdout] 736 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 736 - return true; [INFO] [stdout] 736 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/value.rs:732:6 [INFO] [stdout] | [INFO] [stdout] 732 | if self.extensible == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.extensible` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:332:3 [INFO] [stdout] | [INFO] [stdout] 332 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 332 - return true; [INFO] [stdout] 332 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:339:3 [INFO] [stdout] | [INFO] [stdout] 339 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 339 - return false; [INFO] [stdout] 339 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:784:3 [INFO] [stdout] | [INFO] [stdout] 784 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 784 - return false; [INFO] [stdout] 784 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:359:3 [INFO] [stdout] | [INFO] [stdout] 359 | return std::f64::NAN; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 359 - return std::f64::NAN; [INFO] [stdout] 359 + std::f64::NAN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/value.rs:359:10 [INFO] [stdout] | [INFO] [stdout] 359 | return std::f64::NAN; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 359 - return std::f64::NAN; [INFO] [stdout] 359 + return f64::NAN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:366:3 [INFO] [stdout] | [INFO] [stdout] 366 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return false; [INFO] [stdout] 366 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:372:5 [INFO] [stdout] | [INFO] [stdout] 372 | return "undefined".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - return "undefined".to_string(); [INFO] [stdout] 372 + "undefined".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:375:5 [INFO] [stdout] | [INFO] [stdout] 375 | return "object".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 375 - return "object".to_string(); [INFO] [stdout] 375 + "object".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:67:3 [INFO] [stdout] | [INFO] [stdout] 67 | return self.hooks.get(&hid).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return self.hooks.get(&hid).unwrap(); [INFO] [stdout] 67 + self.hooks.get(&hid).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:378:5 [INFO] [stdout] | [INFO] [stdout] 378 | return "boolean".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 378 - return "boolean".to_string(); [INFO] [stdout] 378 + "boolean".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:381:5 [INFO] [stdout] | [INFO] [stdout] 381 | return "number".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return "number".to_string(); [INFO] [stdout] 381 + "number".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/runtime.rs:71:3 [INFO] [stdout] | [INFO] [stdout] 71 | / if v.is_object() { [INFO] [stdout] 72 | | if v.get_object().borrow().is_hook() { [INFO] [stdout] 73 | | if SharedObject::strong_count(&v.get_object()) == 2 { [INFO] [stdout] 74 | | let hid = v.get_object().borrow().get_hook(); [INFO] [stdout] ... | [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 71 ~ if v.is_object() [INFO] [stdout] 72 ~ && v.get_object().borrow().is_hook() { [INFO] [stdout] 73 | if SharedObject::strong_count(&v.get_object()) == 2 { [INFO] [stdout] ... [INFO] [stdout] 76 | } [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/runtime.rs:72:4 [INFO] [stdout] | [INFO] [stdout] 72 | / if v.get_object().borrow().is_hook() { [INFO] [stdout] 73 | | if SharedObject::strong_count(&v.get_object()) == 2 { [INFO] [stdout] 74 | | let hid = v.get_object().borrow().get_hook(); [INFO] [stdout] 75 | | self.hooks.remove(&hid); [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if v.get_object().borrow().is_hook() [INFO] [stdout] 73 ~ && SharedObject::strong_count(&v.get_object()) == 2 { [INFO] [stdout] 74 | let hid = v.get_object().borrow().get_hook(); [INFO] [stdout] 75 | self.hooks.remove(&hid); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:393:3 [INFO] [stdout] | [INFO] [stdout] 393 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 393 - return false; [INFO] [stdout] 393 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `value::SharedValue` [INFO] [stdout] --> src/value.rs:395:2 [INFO] [stdout] | [INFO] [stdout] 395 | / pub fn to_string(&self) -> String { [INFO] [stdout] 396 | | let v = self.v.borrow(); [INFO] [stdout] 397 | | match &*v { [INFO] [stdout] 398 | | JsValue::JSUndefined => { [INFO] [stdout] ... | [INFO] [stdout] 433 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `value::SharedValue` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 399 | return "undefined".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return "undefined".to_string(); [INFO] [stdout] 399 + "undefined".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:402:5 [INFO] [stdout] | [INFO] [stdout] 402 | return "null".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 402 - return "null".to_string(); [INFO] [stdout] 402 + "null".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:406:6 [INFO] [stdout] | [INFO] [stdout] 406 | return "true".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return "true".to_string(); [INFO] [stdout] 406 + "true".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:408:6 [INFO] [stdout] | [INFO] [stdout] 408 | return "false".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 408 - return "false".to_string(); [INFO] [stdout] 408 + "false".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:412:5 [INFO] [stdout] | [INFO] [stdout] 412 | return num.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 412 - return num.to_string(); [INFO] [stdout] 412 + num.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:427:6 [INFO] [stdout] | [INFO] [stdout] 427 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 427 - return result; [INFO] [stdout] 427 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:429:6 [INFO] [stdout] | [INFO] [stdout] 429 | return format!("[object:_{}_]", obj.borrow().type_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - return format!("[object:_{}_]", obj.borrow().type_string()); [INFO] [stdout] 429 + format!("[object:_{}_]", obj.borrow().type_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:152:3 [INFO] [stdout] | [INFO] [stdout] 152 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return Ok(()); [INFO] [stdout] 152 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:192:4 [INFO] [stdout] | [INFO] [stdout] 192 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return Ok(()); [INFO] [stdout] 192 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:194:4 [INFO] [stdout] | [INFO] [stdout] 194 | return Err(JsException::new(format!("runtime TODO: {}", line!()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 - return Err(JsException::new(format!("runtime TODO: {}", line!()))); [INFO] [stdout] 194 + Err(JsException::new(format!("runtime TODO: {}", line!()))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/runtime.rs:165:6 [INFO] [stdout] | [INFO] [stdout] 165 | if attr.0 == false && value.is_undefined() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!attr.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JsProperty` [INFO] [stdout] --> src/value.rs:438:2 [INFO] [stdout] | [INFO] [stdout] 438 | / pub fn new() -> Self { [INFO] [stdout] 439 | | JsProperty { [INFO] [stdout] 440 | | value: SharedValue::new_undefined(), [INFO] [stdout] 441 | | attr_writable: true, [INFO] [stdout] ... | [INFO] [stdout] 447 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 437 + impl Default for JsProperty { [INFO] [stdout] 438 + fn default() -> Self { [INFO] [stdout] 439 + Self::new() [INFO] [stdout] 440 + } [INFO] [stdout] 441 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:453:3 [INFO] [stdout] | [INFO] [stdout] 453 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return true; [INFO] [stdout] 453 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:456:3 [INFO] [stdout] | [INFO] [stdout] 456 | return self.attr_enumerable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 - return self.attr_enumerable; [INFO] [stdout] 456 + self.attr_enumerable [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:459:3 [INFO] [stdout] | [INFO] [stdout] 459 | return self.attr_configurable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 459 - return self.attr_configurable; [INFO] [stdout] 459 + self.attr_configurable [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:240:3 [INFO] [stdout] | [INFO] [stdout] 240 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 240 - return Ok(()); [INFO] [stdout] 240 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/value.rs:493:12 [INFO] [stdout] | [INFO] [stdout] 493 | for x in (*target).properties.keys() { [INFO] [stdout] | ^^^^^^^^^ help: try: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> src/value.rs:503:2 [INFO] [stdout] | [INFO] [stdout] 503 | / pub fn next(&mut self) -> Option { [INFO] [stdout] 504 | | if self.index >= self.keys.len() { [INFO] [stdout] 505 | | return None; [INFO] [stdout] ... | [INFO] [stdout] 509 | | return Some(s); [INFO] [stdout] 510 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:509:3 [INFO] [stdout] | [INFO] [stdout] 509 | return Some(s); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 509 - return Some(s); [INFO] [stdout] 509 + Some(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:278:3 [INFO] [stdout] | [INFO] [stdout] 278 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 278 - return Ok(false); [INFO] [stdout] 278 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/value.rs:508:3 [INFO] [stdout] | [INFO] [stdout] 508 | self.index = self.index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JsObject` [INFO] [stdout] --> src/value.rs:514:5 [INFO] [stdout] | [INFO] [stdout] 514 | / pub fn new() -> JsObject { [INFO] [stdout] 515 | | JsObject { [INFO] [stdout] 516 | | extensible: true, [INFO] [stdout] 517 | | __proto__: None, [INFO] [stdout] ... | [INFO] [stdout] 521 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 513 + impl Default for JsObject { [INFO] [stdout] 514 + fn default() -> Self { [INFO] [stdout] 515 + Self::new() [INFO] [stdout] 516 + } [INFO] [stdout] 517 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:301:3 [INFO] [stdout] | [INFO] [stdout] 301 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return false; [INFO] [stdout] 301 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/runtime.rs:294:4 [INFO] [stdout] | [INFO] [stdout] 294 | / if own { [INFO] [stdout] 295 | | if prop.configable() { [INFO] [stdout] 296 | | target.drop_property(name); [INFO] [stdout] 297 | | return true; [INFO] [stdout] 298 | | } [INFO] [stdout] 299 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 294 ~ if own [INFO] [stdout] 295 ~ && prop.configable() { [INFO] [stdout] 296 | target.drop_property(name); [INFO] [stdout] 297 | return true; [INFO] [stdout] 298 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:605:3 [INFO] [stdout] | [INFO] [stdout] 605 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 605 - return false; [INFO] [stdout] 605 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:405:3 [INFO] [stdout] | [INFO] [stdout] 405 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 405 - return false; [INFO] [stdout] 405 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:611:3 [INFO] [stdout] | [INFO] [stdout] 611 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 611 - return false; [INFO] [stdout] 611 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/runtime.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 334 | / if x_str == y_str { [INFO] [stdout] 335 | | return true; [INFO] [stdout] 336 | | } else { [INFO] [stdout] 337 | | return false; [INFO] [stdout] 338 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `return x_str == y_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:623:3 [INFO] [stdout] | [INFO] [stdout] 623 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 623 - return false; [INFO] [stdout] 623 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/runtime.rs:341:5 [INFO] [stdout] | [INFO] [stdout] 341 | / if x_str == y_str { [INFO] [stdout] 342 | | return true; [INFO] [stdout] 343 | | } else { [INFO] [stdout] 344 | | return false; [INFO] [stdout] 345 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `return x_str == y_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:635:3 [INFO] [stdout] | [INFO] [stdout] 635 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 635 - return false; [INFO] [stdout] 635 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:647:3 [INFO] [stdout] | [INFO] [stdout] 647 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 647 - return false; [INFO] [stdout] 647 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/runtime.rs:384:5 [INFO] [stdout] | [INFO] [stdout] 384 | / if x_num == y_num { [INFO] [stdout] 385 | | return true; [INFO] [stdout] 386 | | } else { [INFO] [stdout] 387 | | return false; [INFO] [stdout] 388 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `return x_num == y_num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:659:3 [INFO] [stdout] | [INFO] [stdout] 659 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 659 - return false; [INFO] [stdout] 659 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:466:3 [INFO] [stdout] | [INFO] [stdout] 466 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 466 - return false; [INFO] [stdout] 466 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:671:3 [INFO] [stdout] | [INFO] [stdout] 671 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 671 - return false; [INFO] [stdout] 671 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:689:3 [INFO] [stdout] | [INFO] [stdout] 689 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 689 - return false; [INFO] [stdout] 689 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:499:3 [INFO] [stdout] | [INFO] [stdout] 499 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 499 - return None; [INFO] [stdout] 499 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:701:3 [INFO] [stdout] | [INFO] [stdout] 701 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 701 - return false; [INFO] [stdout] 701 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `r` after checking its variant with `is_some` [INFO] [stdout] --> src/value.rs:708:17 [INFO] [stdout] | [INFO] [stdout] 707 | if r.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = r` [INFO] [stdout] 708 | return Some((r.unwrap().clone(), true)); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.__proto__` after checking its variant with `is_some` [INFO] [stdout] --> src/value.rs:712:16 [INFO] [stdout] | [INFO] [stdout] 711 | if self.__proto__.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.__proto__` [INFO] [stdout] 712 | let proto = self.__proto__.as_ref().unwrap().borrow(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:520:3 [INFO] [stdout] | [INFO] [stdout] 520 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 520 - return Ok(()); [INFO] [stdout] 520 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_some` [INFO] [stdout] --> src/value.rs:715:18 [INFO] [stdout] | [INFO] [stdout] 714 | if result.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = result` [INFO] [stdout] 715 | return Some((result.unwrap().0, false)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:719:3 [INFO] [stdout] | [INFO] [stdout] 719 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 719 - return None; [INFO] [stdout] 719 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:722:3 [INFO] [stdout] | [INFO] [stdout] 722 | return self.properties.get(name).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 722 - return self.properties.get(name).unwrap().clone(); [INFO] [stdout] 722 + self.properties.get(name).unwrap().clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:569:3 [INFO] [stdout] | [INFO] [stdout] 569 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 569 - return Ok(()); [INFO] [stdout] 569 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:736:3 [INFO] [stdout] | [INFO] [stdout] 736 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 736 - return true; [INFO] [stdout] 736 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/value.rs:732:6 [INFO] [stdout] | [INFO] [stdout] 732 | if self.extensible == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.extensible` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:621:3 [INFO] [stdout] | [INFO] [stdout] 621 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 621 - return Ok(()); [INFO] [stdout] 621 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/value.rs:784:3 [INFO] [stdout] | [INFO] [stdout] 784 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 784 - return false; [INFO] [stdout] 784 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:67:3 [INFO] [stdout] | [INFO] [stdout] 67 | return self.hooks.get(&hid).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return self.hooks.get(&hid).unwrap(); [INFO] [stdout] 67 + self.hooks.get(&hid).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/runtime.rs:71:3 [INFO] [stdout] | [INFO] [stdout] 71 | / if v.is_object() { [INFO] [stdout] 72 | | if v.get_object().borrow().is_hook() { [INFO] [stdout] 73 | | if SharedObject::strong_count(&v.get_object()) == 2 { [INFO] [stdout] 74 | | let hid = v.get_object().borrow().get_hook(); [INFO] [stdout] ... | [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 71 ~ if v.is_object() [INFO] [stdout] 72 ~ && v.get_object().borrow().is_hook() { [INFO] [stdout] 73 | if SharedObject::strong_count(&v.get_object()) == 2 { [INFO] [stdout] ... [INFO] [stdout] 76 | } [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/runtime.rs:72:4 [INFO] [stdout] | [INFO] [stdout] 72 | / if v.get_object().borrow().is_hook() { [INFO] [stdout] 73 | | if SharedObject::strong_count(&v.get_object()) == 2 { [INFO] [stdout] 74 | | let hid = v.get_object().borrow().get_hook(); [INFO] [stdout] 75 | | self.hooks.remove(&hid); [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if v.get_object().borrow().is_hook() [INFO] [stdout] 73 ~ && SharedObject::strong_count(&v.get_object()) == 2 { [INFO] [stdout] 74 | let hid = v.get_object().borrow().get_hook(); [INFO] [stdout] 75 | self.hooks.remove(&hid); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/runtime.rs:697:4 [INFO] [stdout] | [INFO] [stdout] 697 | n = n - 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `n -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/runtime.rs:701:6 [INFO] [stdout] | [INFO] [stdout] 701 | if self.stack.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:152:3 [INFO] [stdout] | [INFO] [stdout] 152 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return Ok(()); [INFO] [stdout] 152 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:192:4 [INFO] [stdout] | [INFO] [stdout] 192 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return Ok(()); [INFO] [stdout] 192 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:194:4 [INFO] [stdout] | [INFO] [stdout] 194 | return Err(JsException::new(format!("runtime TODO: {}", line!()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 - return Err(JsException::new(format!("runtime TODO: {}", line!()))); [INFO] [stdout] 194 + Err(JsException::new(format!("runtime TODO: {}", line!()))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/runtime.rs:165:6 [INFO] [stdout] | [INFO] [stdout] 165 | if attr.0 == false && value.is_undefined() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!attr.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:240:3 [INFO] [stdout] | [INFO] [stdout] 240 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 240 - return Ok(()); [INFO] [stdout] 240 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:1394:2 [INFO] [stdout] | [INFO] [stdout] 1394 | return Err( with_exception.unwrap() ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1394 - return Err( with_exception.unwrap() ); [INFO] [stdout] 1394 + Err( with_exception.unwrap() ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/runtime.rs:780:10 [INFO] [stdout] | [INFO] [stdout] 780 | assert!(rt.stack.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rt.stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:278:3 [INFO] [stdout] | [INFO] [stdout] 278 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 278 - return Ok(false); [INFO] [stdout] 278 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:881:33 [INFO] [stdout] | [INFO] [stdout] 881 | let result = rt.getvariable(&s); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/runtime.rs:884:10 [INFO] [stdout] | [INFO] [stdout] 884 | if br == true { [INFO] [stdout] | ^^^^^^^^^^ help: try: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:301:3 [INFO] [stdout] | [INFO] [stdout] 301 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return false; [INFO] [stdout] 301 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:899:33 [INFO] [stdout] | [INFO] [stdout] 899 | let result = rt.getvariable(&s); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/runtime.rs:294:4 [INFO] [stdout] | [INFO] [stdout] 294 | / if own { [INFO] [stdout] 295 | | if prop.configable() { [INFO] [stdout] 296 | | target.drop_property(name); [INFO] [stdout] 297 | | return true; [INFO] [stdout] 298 | | } [INFO] [stdout] 299 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 294 ~ if own [INFO] [stdout] 295 ~ && prop.configable() { [INFO] [stdout] 296 | target.drop_property(name); [INFO] [stdout] 297 | return true; [INFO] [stdout] 298 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/runtime.rs:902:10 [INFO] [stdout] | [INFO] [stdout] 902 | if br == false { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `!br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:405:3 [INFO] [stdout] | [INFO] [stdout] 405 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 405 - return false; [INFO] [stdout] 405 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/runtime.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 334 | / if x_str == y_str { [INFO] [stdout] 335 | | return true; [INFO] [stdout] 336 | | } else { [INFO] [stdout] 337 | | return false; [INFO] [stdout] 338 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `return x_str == y_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/runtime.rs:341:5 [INFO] [stdout] | [INFO] [stdout] 341 | / if x_str == y_str { [INFO] [stdout] 342 | | return true; [INFO] [stdout] 343 | | } else { [INFO] [stdout] 344 | | return false; [INFO] [stdout] 345 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `return x_str == y_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/runtime.rs:384:5 [INFO] [stdout] | [INFO] [stdout] 384 | / if x_num == y_num { [INFO] [stdout] 385 | | return true; [INFO] [stdout] 386 | | } else { [INFO] [stdout] 387 | | return false; [INFO] [stdout] 388 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `return x_num == y_num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:466:3 [INFO] [stdout] | [INFO] [stdout] 466 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 466 - return false; [INFO] [stdout] 466 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:980:44 [INFO] [stdout] | [INFO] [stdout] 980 | if let Err(e) = rt.getproperty(target, &name) { [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:499:3 [INFO] [stdout] | [INFO] [stdout] 499 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 499 - return None; [INFO] [stdout] 499 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:998:44 [INFO] [stdout] | [INFO] [stdout] 998 | if let Err(e) = rt.setproperty(target, &name, value) { [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:520:3 [INFO] [stdout] | [INFO] [stdout] 520 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 520 - return Ok(()); [INFO] [stdout] 520 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:1015:37 [INFO] [stdout] | [INFO] [stdout] 1015 | let b = rt.delproperty(target, &name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:569:3 [INFO] [stdout] | [INFO] [stdout] 569 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 569 - return Ok(()); [INFO] [stdout] 569 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:621:3 [INFO] [stdout] | [INFO] [stdout] 621 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 621 - return Ok(()); [INFO] [stdout] 621 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1155:39 [INFO] [stdout] | [INFO] [stdout] 1155 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1156 | | rt.push_number(0.0); [INFO] [stdout] 1157 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1157:56 [INFO] [stdout] | [INFO] [stdout] 1157 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1158 | | rt.push_number(0.0); [INFO] [stdout] 1159 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1157:56 [INFO] [stdout] | [INFO] [stdout] 1157 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1158 | | rt.push_number(0.0); [INFO] [stdout] 1159 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1159:64 [INFO] [stdout] | [INFO] [stdout] 1159 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1160 | | rt.push_number(0.0); [INFO] [stdout] 1161 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1171:39 [INFO] [stdout] | [INFO] [stdout] 1171 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1172 | | rt.push_number(0.0); [INFO] [stdout] 1173 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1173:56 [INFO] [stdout] | [INFO] [stdout] 1173 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1174 | | rt.push_number(0.0); [INFO] [stdout] 1175 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1173:56 [INFO] [stdout] | [INFO] [stdout] 1173 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1174 | | rt.push_number(0.0); [INFO] [stdout] 1175 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1175:64 [INFO] [stdout] | [INFO] [stdout] 1175 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1176 | | rt.push_number(0.0); [INFO] [stdout] 1177 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/runtime.rs:697:4 [INFO] [stdout] | [INFO] [stdout] 697 | n = n - 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `n -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/runtime.rs:701:6 [INFO] [stdout] | [INFO] [stdout] 701 | if self.stack.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1187:39 [INFO] [stdout] | [INFO] [stdout] 1187 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1188 | | rt.push_number(0.0); [INFO] [stdout] 1189 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1189:56 [INFO] [stdout] | [INFO] [stdout] 1189 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1190 | | rt.push_number(0.0); [INFO] [stdout] 1191 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1189:56 [INFO] [stdout] | [INFO] [stdout] 1189 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1190 | | rt.push_number(0.0); [INFO] [stdout] 1191 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1191:64 [INFO] [stdout] | [INFO] [stdout] 1191 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1192 | | rt.push_number(0.0); [INFO] [stdout] 1193 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1271:39 [INFO] [stdout] | [INFO] [stdout] 1271 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1272 | | rt.push_number(0.0); [INFO] [stdout] 1273 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1273:56 [INFO] [stdout] | [INFO] [stdout] 1273 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1274 | | rt.push_number(0.0); [INFO] [stdout] 1275 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1273:56 [INFO] [stdout] | [INFO] [stdout] 1273 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1274 | | rt.push_number(0.0); [INFO] [stdout] 1275 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1275:64 [INFO] [stdout] | [INFO] [stdout] 1275 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1276 | | rt.push_number(0.0); [INFO] [stdout] 1277 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1285:39 [INFO] [stdout] | [INFO] [stdout] 1285 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1286 | | rt.push_number(0.0); [INFO] [stdout] 1287 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1287:56 [INFO] [stdout] | [INFO] [stdout] 1287 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1288 | | rt.push_number(0.0); [INFO] [stdout] 1289 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1287:56 [INFO] [stdout] | [INFO] [stdout] 1287 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1288 | | rt.push_number(0.0); [INFO] [stdout] 1289 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1289:64 [INFO] [stdout] | [INFO] [stdout] 1289 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1290 | | rt.push_number(0.0); [INFO] [stdout] 1291 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1299:39 [INFO] [stdout] | [INFO] [stdout] 1299 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1300 | | rt.push_number(0.0); [INFO] [stdout] 1301 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1301:56 [INFO] [stdout] | [INFO] [stdout] 1301 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1302 | | rt.push_number(0.0); [INFO] [stdout] 1303 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:1394:2 [INFO] [stdout] | [INFO] [stdout] 1394 | return Err( with_exception.unwrap() ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1394 - return Err( with_exception.unwrap() ); [INFO] [stdout] 1394 + Err( with_exception.unwrap() ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1301:56 [INFO] [stdout] | [INFO] [stdout] 1301 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1302 | | rt.push_number(0.0); [INFO] [stdout] 1303 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1303:64 [INFO] [stdout] | [INFO] [stdout] 1303 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1304 | | rt.push_number(0.0); [INFO] [stdout] 1305 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/runtime.rs:780:10 [INFO] [stdout] | [INFO] [stdout] 780 | assert!(rt.stack.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rt.stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:881:33 [INFO] [stdout] | [INFO] [stdout] 881 | let result = rt.getvariable(&s); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:1420:2 [INFO] [stdout] | [INFO] [stdout] 1420 | return Ok(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1420 - return Ok(()) [INFO] [stdout] 1420 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/runtime.rs:884:10 [INFO] [stdout] | [INFO] [stdout] 884 | if br == true { [INFO] [stdout] | ^^^^^^^^^^ help: try: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:899:33 [INFO] [stdout] | [INFO] [stdout] 899 | let result = rt.getvariable(&s); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:1480:2 [INFO] [stdout] | [INFO] [stdout] 1480 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1480 - return Ok(()); [INFO] [stdout] 1480 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/runtime.rs:902:10 [INFO] [stdout] | [INFO] [stdout] 902 | if br == false { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `!br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:1518:2 [INFO] [stdout] | [INFO] [stdout] 1518 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1518 - return Ok(()); [INFO] [stdout] 1518 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/runtime.rs:1504:5 [INFO] [stdout] | [INFO] [stdout] 1504 | if fobj.borrow().is_function() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fobj.borrow().is_function()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/runtime.rs:1512:12 [INFO] [stdout] | [INFO] [stdout] 1512 | } else if fobj.borrow().is_builtin() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fobj.borrow().is_builtin()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:980:44 [INFO] [stdout] | [INFO] [stdout] 980 | if let Err(e) = rt.getproperty(target, &name) { [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return builtins; [INFO] [stdout] 55 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:998:44 [INFO] [stdout] | [INFO] [stdout] 998 | if let Err(e) = rt.setproperty(target, &name, value) { [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:1015:37 [INFO] [stdout] | [INFO] [stdout] 1015 | let b = rt.delproperty(target, &name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - rt.push(target); [INFO] [stdout] 176 - return; [INFO] [stdout] 175 + rt.push(target); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return builtins; [INFO] [stdout] 186 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 - return builtins; [INFO] [stdout] 206 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1155:39 [INFO] [stdout] | [INFO] [stdout] 1155 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1156 | | rt.push_number(0.0); [INFO] [stdout] 1157 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1157:56 [INFO] [stdout] | [INFO] [stdout] 1157 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1158 | | rt.push_number(0.0); [INFO] [stdout] 1159 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1157:56 [INFO] [stdout] | [INFO] [stdout] 1157 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1158 | | rt.push_number(0.0); [INFO] [stdout] 1159 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1159:64 [INFO] [stdout] | [INFO] [stdout] 1159 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1160 | | rt.push_number(0.0); [INFO] [stdout] 1161 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1171:39 [INFO] [stdout] | [INFO] [stdout] 1171 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1172 | | rt.push_number(0.0); [INFO] [stdout] 1173 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1173:56 [INFO] [stdout] | [INFO] [stdout] 1173 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1174 | | rt.push_number(0.0); [INFO] [stdout] 1175 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 248 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return builtins; [INFO] [stdout] 248 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1173:56 [INFO] [stdout] | [INFO] [stdout] 1173 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1174 | | rt.push_number(0.0); [INFO] [stdout] 1175 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1175:64 [INFO] [stdout] | [INFO] [stdout] 1175 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1176 | | rt.push_number(0.0); [INFO] [stdout] 1177 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1187:39 [INFO] [stdout] | [INFO] [stdout] 1187 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1188 | | rt.push_number(0.0); [INFO] [stdout] 1189 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1189:56 [INFO] [stdout] | [INFO] [stdout] 1189 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1190 | | rt.push_number(0.0); [INFO] [stdout] 1191 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1189:56 [INFO] [stdout] | [INFO] [stdout] 1189 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1190 | | rt.push_number(0.0); [INFO] [stdout] 1191 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1191:64 [INFO] [stdout] | [INFO] [stdout] 1191 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1192 | | rt.push_number(0.0); [INFO] [stdout] 1193 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `args` [INFO] [stdout] --> src/builtin.rs:273:18 [INFO] [stdout] | [INFO] [stdout] 273 | for i in 0..args.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 273 - for i in 0..args.len() { [INFO] [stdout] 273 + for in &args { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `arguments` [INFO] [stdout] --> src/builtin.rs:281:14 [INFO] [stdout] | [INFO] [stdout] 281 | for i in 0..arguments.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 281 - for i in 0..arguments.len() { [INFO] [stdout] 281 + for in &arguments { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `arguments` [INFO] [stdout] --> src/builtin.rs:314:14 [INFO] [stdout] | [INFO] [stdout] 314 | for i in 0..arguments.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 314 - for i in 0..arguments.len() { [INFO] [stdout] 314 + for in &arguments { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:332:5 [INFO] [stdout] | [INFO] [stdout] 332 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 332 - return builtins; [INFO] [stdout] 332 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 359 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 359 - return builtins; [INFO] [stdout] 359 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:406:5 [INFO] [stdout] | [INFO] [stdout] 406 | return (class_obj, prototype_obj); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return (class_obj, prototype_obj); [INFO] [stdout] 406 + (class_obj, prototype_obj) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(SharedFunction_new(func)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(SharedFunction_new(func)); [INFO] [stdout] 49 + Ok(SharedFunction_new(func)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | addr = addr + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `addr += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:117:2 [INFO] [stdout] | [INFO] [stdout] 117 | return runtime; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return runtime; [INFO] [stdout] 117 + runtime [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:145:2 [INFO] [stdout] | [INFO] [stdout] 145 | return Ok(value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - return Ok(value); [INFO] [stdout] 145 + Ok(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/lib.rs:124:11 [INFO] [stdout] | [INFO] [stdout] 124 | assert!( vmf.script == true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `vmf.script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:140:10 [INFO] [stdout] | [INFO] [stdout] 140 | panic!(err_msg); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 140 | panic!("{}", err_msg); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/ast.rs:438:12 [INFO] [stdout] | [INFO] [stdout] 438 | panic!(format!("unexpected token in expression: {:?} @ {}", lookahead, tkr.line())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 438 - panic!(format!("unexpected token in expression: {:?} @ {}", lookahead, tkr.line())); [INFO] [stdout] 438 + panic!("unexpected token in expression: {:?} @ {}", lookahead, tkr.line()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:477:7 [INFO] [stdout] | [INFO] [stdout] 477 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(invalid_nan_comparisons)]` on by default [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 477 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 477 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:477:24 [INFO] [stdout] | [INFO] [stdout] 477 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 477 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 477 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1155:8 [INFO] [stdout] | [INFO] [stdout] 1155 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1155 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1155 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1155:25 [INFO] [stdout] | [INFO] [stdout] 1155 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1155 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1155 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1171:8 [INFO] [stdout] | [INFO] [stdout] 1171 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1171 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1171 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1171:25 [INFO] [stdout] | [INFO] [stdout] 1171 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1171 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1171 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1187:8 [INFO] [stdout] | [INFO] [stdout] 1187 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1187 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1187 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1187:25 [INFO] [stdout] | [INFO] [stdout] 1187 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1187 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1187 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1271:8 [INFO] [stdout] | [INFO] [stdout] 1271 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1271 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1271 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1271:25 [INFO] [stdout] | [INFO] [stdout] 1271 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1271 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1271 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1285:8 [INFO] [stdout] | [INFO] [stdout] 1285 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1285 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1285 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1285:25 [INFO] [stdout] | [INFO] [stdout] 1285 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1285 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1285 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1299:8 [INFO] [stdout] | [INFO] [stdout] 1299 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1299 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1299 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1299:25 [INFO] [stdout] | [INFO] [stdout] 1299 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1299 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1299 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1271:39 [INFO] [stdout] | [INFO] [stdout] 1271 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1272 | | rt.push_number(0.0); [INFO] [stdout] 1273 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1273:56 [INFO] [stdout] | [INFO] [stdout] 1273 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1274 | | rt.push_number(0.0); [INFO] [stdout] 1275 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1273:56 [INFO] [stdout] | [INFO] [stdout] 1273 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1274 | | rt.push_number(0.0); [INFO] [stdout] 1275 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1275:64 [INFO] [stdout] | [INFO] [stdout] 1275 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1276 | | rt.push_number(0.0); [INFO] [stdout] 1277 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1285:39 [INFO] [stdout] | [INFO] [stdout] 1285 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1286 | | rt.push_number(0.0); [INFO] [stdout] 1287 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1287:56 [INFO] [stdout] | [INFO] [stdout] 1287 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1288 | | rt.push_number(0.0); [INFO] [stdout] 1289 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1287:56 [INFO] [stdout] | [INFO] [stdout] 1287 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1288 | | rt.push_number(0.0); [INFO] [stdout] 1289 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1289:64 [INFO] [stdout] | [INFO] [stdout] 1289 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1290 | | rt.push_number(0.0); [INFO] [stdout] 1291 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1299:39 [INFO] [stdout] | [INFO] [stdout] 1299 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1300 | | rt.push_number(0.0); [INFO] [stdout] 1301 | | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1301:56 [INFO] [stdout] | [INFO] [stdout] 1301 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1302 | | rt.push_number(0.0); [INFO] [stdout] 1303 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/runtime.rs:1301:56 [INFO] [stdout] | [INFO] [stdout] 1301 | } else if x == f64::INFINITY || y == f64::INFINITY { [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1302 | | rt.push_number(0.0); [INFO] [stdout] 1303 | | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/runtime.rs:1303:64 [INFO] [stdout] | [INFO] [stdout] 1303 | } else if x == f64::NEG_INFINITY || y == f64::NEG_INFINITY { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 1304 | | rt.push_number(0.0); [INFO] [stdout] 1305 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:1420:2 [INFO] [stdout] | [INFO] [stdout] 1420 | return Ok(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1420 - return Ok(()) [INFO] [stdout] 1420 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:1480:2 [INFO] [stdout] | [INFO] [stdout] 1480 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1480 - return Ok(()); [INFO] [stdout] 1480 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:1518:2 [INFO] [stdout] | [INFO] [stdout] 1518 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1518 - return Ok(()); [INFO] [stdout] 1518 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/runtime.rs:1504:5 [INFO] [stdout] | [INFO] [stdout] 1504 | if fobj.borrow().is_function() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fobj.borrow().is_function()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/runtime.rs:1512:12 [INFO] [stdout] | [INFO] [stdout] 1512 | } else if fobj.borrow().is_builtin() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fobj.borrow().is_builtin()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return builtins; [INFO] [stdout] 55 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - rt.push(target); [INFO] [stdout] 176 - return; [INFO] [stdout] 175 + rt.push(target); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return builtins; [INFO] [stdout] 186 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 - return builtins; [INFO] [stdout] 206 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 248 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return builtins; [INFO] [stdout] 248 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `args` [INFO] [stdout] --> src/builtin.rs:273:18 [INFO] [stdout] | [INFO] [stdout] 273 | for i in 0..args.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 273 - for i in 0..args.len() { [INFO] [stdout] 273 + for in &args { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `arguments` [INFO] [stdout] --> src/builtin.rs:281:14 [INFO] [stdout] | [INFO] [stdout] 281 | for i in 0..arguments.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 281 - for i in 0..arguments.len() { [INFO] [stdout] 281 + for in &arguments { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `arguments` [INFO] [stdout] --> src/builtin.rs:314:14 [INFO] [stdout] | [INFO] [stdout] 314 | for i in 0..arguments.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 314 - for i in 0..arguments.len() { [INFO] [stdout] 314 + for in &arguments { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:332:5 [INFO] [stdout] | [INFO] [stdout] 332 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 332 - return builtins; [INFO] [stdout] 332 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 359 | return builtins; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 359 - return builtins; [INFO] [stdout] 359 + builtins [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builtin.rs:406:5 [INFO] [stdout] | [INFO] [stdout] 406 | return (class_obj, prototype_obj); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return (class_obj, prototype_obj); [INFO] [stdout] 406 + (class_obj, prototype_obj) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(SharedFunction_new(func)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(SharedFunction_new(func)); [INFO] [stdout] 49 + Ok(SharedFunction_new(func)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | addr = addr + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `addr += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:117:2 [INFO] [stdout] | [INFO] [stdout] 117 | return runtime; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return runtime; [INFO] [stdout] 117 + runtime [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:145:2 [INFO] [stdout] | [INFO] [stdout] 145 | return Ok(value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - return Ok(value); [INFO] [stdout] 145 + Ok(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/lib.rs:124:11 [INFO] [stdout] | [INFO] [stdout] 124 | assert!( vmf.script == true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `vmf.script` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:140:10 [INFO] [stdout] | [INFO] [stdout] 140 | panic!(err_msg); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 140 | panic!("{}", err_msg); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/ast.rs:438:12 [INFO] [stdout] | [INFO] [stdout] 438 | panic!(format!("unexpected token in expression: {:?} @ {}", lookahead, tkr.line())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 438 - panic!(format!("unexpected token in expression: {:?} @ {}", lookahead, tkr.line())); [INFO] [stdout] 438 + panic!("unexpected token in expression: {:?} @ {}", lookahead, tkr.line()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:477:7 [INFO] [stdout] | [INFO] [stdout] 477 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(invalid_nan_comparisons)]` on by default [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 477 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 477 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:477:24 [INFO] [stdout] | [INFO] [stdout] 477 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 477 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 477 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1155:8 [INFO] [stdout] | [INFO] [stdout] 1155 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1155 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1155 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1155:25 [INFO] [stdout] | [INFO] [stdout] 1155 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1155 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1155 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1171:8 [INFO] [stdout] | [INFO] [stdout] 1171 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1171 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1171 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1171:25 [INFO] [stdout] | [INFO] [stdout] 1171 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1171 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1171 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1187:8 [INFO] [stdout] | [INFO] [stdout] 1187 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1187 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1187 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1187:25 [INFO] [stdout] | [INFO] [stdout] 1187 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1187 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1187 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1271:8 [INFO] [stdout] | [INFO] [stdout] 1271 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1271 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1271 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1271:25 [INFO] [stdout] | [INFO] [stdout] 1271 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1271 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1271 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1285:8 [INFO] [stdout] | [INFO] [stdout] 1285 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1285 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1285 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1285:25 [INFO] [stdout] | [INFO] [stdout] 1285 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1285 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1285 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1299:8 [INFO] [stdout] | [INFO] [stdout] 1299 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1299 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1299 + if x.is_nan() || y == f64::NAN { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: incorrect NaN comparison, NaN cannot be directly compared to itself [INFO] [stdout] --> src/runtime.rs:1299:25 [INFO] [stdout] | [INFO] [stdout] 1299 | if x == f64::NAN || y == f64::NAN { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `f32::is_nan()` or `f64::is_nan()` instead [INFO] [stdout] | [INFO] [stdout] 1299 - if x == f64::NAN || y == f64::NAN { [INFO] [stdout] 1299 + if x == f64::NAN || y.is_nan() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/repl.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use ezjs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/repl.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use ezjs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/repl.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self.value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self.value.clone(); [INFO] [stdout] 29 + self.value.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ret` after checking its variant with `is_ok` [INFO] [stdout] --> src/bin/repl.rs:98:58 [INFO] [stdout] | [INFO] [stdout] 97 | if ret.is_ok() { [INFO] [stdout] | -------------- help: try: `if let Ok() = ret` [INFO] [stdout] 98 | println!("<{}> {}", end - begin, ret.unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/bin/repl.rs:77:46 [INFO] [stdout] | [INFO] [stdout] 77 | println!("{}", ret.err().unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/repl.rs:88:20 [INFO] [stdout] | [INFO] [stdout] 88 | if line != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/bin/repl.rs:100:58 [INFO] [stdout] | [INFO] [stdout] 100 | println!("{}", ret.err().unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/repl.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self.value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self.value.clone(); [INFO] [stdout] 29 + self.value.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ret` after checking its variant with `is_ok` [INFO] [stdout] --> src/bin/repl.rs:98:58 [INFO] [stdout] | [INFO] [stdout] 97 | if ret.is_ok() { [INFO] [stdout] | -------------- help: try: `if let Ok() = ret` [INFO] [stdout] 98 | println!("<{}> {}", end - begin, ret.unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/bin/repl.rs:77:46 [INFO] [stdout] | [INFO] [stdout] 77 | println!("{}", ret.err().unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/repl.rs:88:20 [INFO] [stdout] | [INFO] [stdout] 88 | if line != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/bin/repl.rs:100:58 [INFO] [stdout] | [INFO] [stdout] 100 | println!("{}", ret.err().unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.67s [INFO] running `Command { std: "docker" "inspect" "de53c331fcb2fa94324b3242c1eb7bb5733f7d933ce2aa9246b98f76abd256dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de53c331fcb2fa94324b3242c1eb7bb5733f7d933ce2aa9246b98f76abd256dd", kill_on_drop: false }` [INFO] [stdout] de53c331fcb2fa94324b3242c1eb7bb5733f7d933ce2aa9246b98f76abd256dd