[INFO] fetching crate ezcp 0.4.0... [INFO] linting ezcp-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ezcp 0.4.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate ezcp 0.4.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate ezcp 0.4.0 [INFO] tweaked toml for crates.io crate ezcp 0.4.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ezcp 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ezcp 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded indicatif-log-bridge v0.2.3 [INFO] [stderr] Downloaded tempfile v3.21.0 [INFO] [stderr] Downloaded libz-rs-sys v0.5.1 [INFO] [stderr] Downloaded wit-bindgen v0.45.0 [INFO] [stderr] Downloaded env_filter v0.1.3 [INFO] [stderr] Downloaded zopfli v0.8.2 [INFO] [stderr] Downloaded unit-prefix v0.5.1 [INFO] [stderr] Downloaded console v0.16.0 [INFO] [stderr] Downloaded indicatif v0.18.0 [INFO] [stderr] Downloaded wasi v0.14.3+wasi-0.2.4 [INFO] [stderr] Downloaded zip v4.5.0 [INFO] [stderr] Downloaded zlib-rs v0.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 005723820dca0ff34d28c17ce412a5f4d5856fdc4fd8592afcc145bed549d237 [INFO] running `Command { std: "docker" "start" "-a" "005723820dca0ff34d28c17ce412a5f4d5856fdc4fd8592afcc145bed549d237", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "005723820dca0ff34d28c17ce412a5f4d5856fdc4fd8592afcc145bed549d237", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "005723820dca0ff34d28c17ce412a5f4d5856fdc4fd8592afcc145bed549d237", kill_on_drop: false }` [INFO] [stdout] 005723820dca0ff34d28c17ce412a5f4d5856fdc4fd8592afcc145bed549d237 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c95f2a985bcce9cbea00b957fa2786fadacc0476d513cb4b96dba783bf1d0e3 [INFO] running `Command { std: "docker" "start" "-a" "1c95f2a985bcce9cbea00b957fa2786fadacc0476d513cb4b96dba783bf1d0e3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking bitflags v2.9.3 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking zlib-rs v0.5.1 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking unit-prefix v0.5.1 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking console v0.16.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking bumpalo v3.19.0 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking zopfli v0.8.2 [INFO] [stderr] Checking indicatif v0.18.0 [INFO] [stderr] Checking indexmap v2.11.0 [INFO] [stderr] Checking libz-rs-sys v0.5.1 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking unty v0.0.4 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking env_home v0.1.0 [INFO] [stderr] Checking indicatif-log-bridge v0.2.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking zip v4.5.0 [INFO] [stderr] Checking tempfile v3.21.0 [INFO] [stderr] Checking which v8.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Checking bincode v2.0.1 [INFO] [stderr] Checking ezcp v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary raw string literal [INFO] [stdout] --> src/tests/cpp_runner_tests.rs:158:30 [INFO] [stdout] | [INFO] [stdout] 158 | let program_source = r#" [INFO] [stdout] | ______________________________^ [INFO] [stdout] 159 | | int main() { [INFO] [stdout] 160 | | while (true) { [INFO] [stdout] ... | [INFO] [stdout] 165 | | "#; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_strings [INFO] [stdout] = note: requested on the command line with `-W clippy::needless-raw-strings` [INFO] [stdout] help: use a plain string literal instead [INFO] [stdout] | [INFO] [stdout] 158 ~ let program_source = " [INFO] [stdout] 159 | int main() { [INFO] [stdout] ... [INFO] [stdout] 164 | } [INFO] [stdout] 165 ~ "; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary raw string literal [INFO] [stdout] --> src/tests/cpp_runner_tests.rs:187:30 [INFO] [stdout] | [INFO] [stdout] 187 | let program_source = r#" [INFO] [stdout] | ______________________________^ [INFO] [stdout] 188 | | int main() { [INFO] [stdout] 189 | | int*n=nullptr; [INFO] [stdout] 190 | | while(true){ [INFO] [stdout] ... | [INFO] [stdout] 196 | | "#; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_strings [INFO] [stdout] help: use a plain string literal instead [INFO] [stdout] | [INFO] [stdout] 187 ~ let program_source = " [INFO] [stdout] 188 | int main() { [INFO] [stdout] ... [INFO] [stdout] 195 | } [INFO] [stdout] 196 ~ "; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary raw string literal [INFO] [stdout] --> examples/example2.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | const SOLUTION: &str = r" [INFO] [stdout] | ________________________^ [INFO] [stdout] 5 | | #include [INFO] [stdout] 6 | | using namespace std; [INFO] [stdout] 7 | | int main() { [INFO] [stdout] ... | [INFO] [stdout] 30 | | "; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_strings [INFO] [stdout] = note: requested on the command line with `-W clippy::needless-raw-strings` [INFO] [stdout] help: use a plain string literal instead [INFO] [stdout] | [INFO] [stdout] 4 - const SOLUTION: &str = r" [INFO] [stdout] 4 + const SOLUTION: &str = " [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/checker_tests.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] = note: requested on the command line with `-W clippy::semicolon-if-nothing-returned` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/checker_tests.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/tests/checker_tests.rs:257:96 [INFO] [stdout] | [INFO] [stdout] 257 | assert!(matches!(task.task.create_tests().unwrap_err(), Error::InputExpectedInteger { .. })); [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `-W clippy::unneeded-struct-pattern` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::unneeded_struct_pattern)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/tests/checker_tests.rs:305:92 [INFO] [stdout] | [INFO] [stdout] 305 | assert!(matches!(task.task.create_tests().unwrap_err(), Error::InputExpectedEnd { .. })); [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/checker_tests.rs:396:9 [INFO] [stdout] | [INFO] [stdout] 396 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/dependencies_tests.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/dependencies_tests.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `expect()` on a `Result` value [INFO] [stdout] --> src/tests/generic_tests.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | let task_path = TempDir::new().expect("Failed to create temporary directory"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_used [INFO] [stdout] = note: requested on the command line with `-W clippy::expect-used` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary structure name repetition [INFO] [stdout] --> src/tests/generic_tests.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | Test { task, task_path } [INFO] [stdout] | ^^^^ help: use the applicable keyword: `Self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stdout] = note: `-W clippy::use-self` implied by `-W clippy::nursery` [INFO] [stdout] = help: to override `-W clippy::nursery` add `#[allow(clippy::use_self)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/generic_tests.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/generic_tests.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/generic_tests.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/generic_tests.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/generic_tests.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 257 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/generic_tests.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/partial_solution_tests.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/partial_solution_tests.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | assert!(!task.task.create_tests().is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `task.task.create_tests().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `-W clippy::nonminimal-bool` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::nonminimal_bool)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/partial_solution_tests.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | assert!(!task.task.create_tests().is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `task.task.create_tests().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/partial_solution_tests.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/partial_solution_tests.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/tests/partial_solution_tests.rs:405:9 [INFO] [stdout] | [INFO] [stdout] 405 | task.test() [INFO] [stdout] | ^^^^^^^^^^^ help: add a `;` here: `task.test();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `assert!` with `Result::is_ok` [INFO] [stdout] --> src/tests/gcc_tests.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | assert!(gcc.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `gcc.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_result_states [INFO] [stdout] = note: requested on the command line with `-W clippy::assertions-on-result-states` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `expect()` on a `Result` value [INFO] [stdout] --> src/tests/gcc_tests.rs:95:22 [INFO] [stdout] | [INFO] [stdout] 95 | let output = std::process::Command::new(&output_path) [INFO] [stdout] | ______________________^ [INFO] [stdout] 96 | | .output() [INFO] [stdout] 97 | | .expect("Failed to execute compiled program"); [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests/cpp_runner_tests.rs:26:38 [INFO] [stdout] | [INFO] [stdout] 26 | let _runner = CppRunner::new(&tempdir.path()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `tempdir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `-W clippy::needless-borrow` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/tests/cpp_runner_tests.rs:73:59 [INFO] [stdout] | [INFO] [stdout] 73 | let task_handle = runner.add_task(program_handle, "".to_owned(), 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] = note: requested on the command line with `-W clippy::manual-string-new` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/tests/cpp_runner_tests.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | let input = format!("{}\n", i); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] = note: `-W clippy::uninlined-format-args` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::uninlined_format_args)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 113 - let input = format!("{}\n", i); [INFO] [stdout] 113 + let input = format!("{i}\n"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/tests/cpp_runner_tests.rs:226:63 [INFO] [stdout] | [INFO] [stdout] 226 | let task_handle = runner.add_task(program_handle, "".to_owned(), 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/tests/cpp_runner_tests.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | assert!(elapsed.as_secs() < 10, "Cache pickup took too long: {:?}", elapsed); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 240 - assert!(elapsed.as_secs() < 10, "Cache pickup took too long: {:?}", elapsed); [INFO] [stdout] 240 + assert!(elapsed.as_secs() < 10, "Cache pickup took too long: {elapsed:?}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.79s [INFO] running `Command { std: "docker" "inspect" "1c95f2a985bcce9cbea00b957fa2786fadacc0476d513cb4b96dba783bf1d0e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c95f2a985bcce9cbea00b957fa2786fadacc0476d513cb4b96dba783bf1d0e3", kill_on_drop: false }` [INFO] [stdout] 1c95f2a985bcce9cbea00b957fa2786fadacc0476d513cb4b96dba783bf1d0e3