[INFO] fetching crate evillatoro-data-structures 0.1.0... [INFO] linting evillatoro-data-structures-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate evillatoro-data-structures 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate evillatoro-data-structures 0.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate evillatoro-data-structures 0.1.0 [INFO] tweaked toml for crates.io crate evillatoro-data-structures 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate evillatoro-data-structures 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b443e474fad50c42a274e4ca0ddbdc763588316f84665493a152b593cbde7a9c [INFO] running `Command { std: "docker" "start" "-a" "b443e474fad50c42a274e4ca0ddbdc763588316f84665493a152b593cbde7a9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b443e474fad50c42a274e4ca0ddbdc763588316f84665493a152b593cbde7a9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b443e474fad50c42a274e4ca0ddbdc763588316f84665493a152b593cbde7a9c", kill_on_drop: false }` [INFO] [stdout] b443e474fad50c42a274e4ca0ddbdc763588316f84665493a152b593cbde7a9c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f2386fe626a7b083b2b7ca0da19f6314f001ae35d054acceb82306c23763ed5 [INFO] running `Command { std: "docker" "start" "-a" "7f2386fe626a7b083b2b7ca0da19f6314f001ae35d054acceb82306c23763ed5", kill_on_drop: false }` [INFO] [stderr] Checking evillatoro-data-structures v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `next` is never read [INFO] [stdout] --> src/doubly_linked_list.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 64 | pub struct ListNode { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 65 | next: Option>>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `linked_list::ListNode` [INFO] [stdout] --> src/linked_list.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / fn to_string(&self) -> String { [INFO] [stdout] 21 | | format!("[{}]", self.data) [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `linked_list::ListNode` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linked_list.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 36 | print(&head); [INFO] [stdout] | ^^^^^ help: change this to: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linked_list.rs:37:55 [INFO] [stdout] | [INFO] [stdout] 37 | println!("Linked list length {len}", len = length(&head)); [INFO] [stdout] | ^^^^^ help: change this to: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | return new_node; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return new_node; [INFO] [stdout] 60 + new_node [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | return head.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return head.unwrap(); [INFO] [stdout] 76 + head.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | return head.expect("head node must exist to insert at position"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return head.expect("head node must exist to insert at position"); [INFO] [stdout] 107 + head.expect("head node must exist to insert at position") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 104 | cur = &mut (*node).next; [INFO] [stdout] | ^^^^^^^ help: try: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:113:29 [INFO] [stdout] | [INFO] [stdout] 113 | Some(first_node) => return first_node.next, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - Some(first_node) => return first_node.next, [INFO] [stdout] 113 + Some(first_node) => first_node.next, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return None; [INFO] [stdout] 139 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:124:47 [INFO] [stdout] | [INFO] [stdout] 124 | while let Some(ref mut current) = (*cur).next { [INFO] [stdout] | ^^^^^^ help: try: `cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:132:25 [INFO] [stdout] | [INFO] [stdout] 132 | (*current).next = None; [INFO] [stdout] | ^^^^^^^^^^ help: try: `current` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | return head; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return head; [INFO] [stdout] 179 + head [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:159:47 [INFO] [stdout] | [INFO] [stdout] 159 | while let Some(ref mut current) = (*cur).next { [INFO] [stdout] | ^^^^^^ help: try: `cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:168:43 [INFO] [stdout] | [INFO] [stdout] 168 | (*current).next = (*next).next.take(); [INFO] [stdout] | ^^^^^^^ help: try: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:168:25 [INFO] [stdout] | [INFO] [stdout] 168 | (*current).next = (*next).next.take(); [INFO] [stdout] | ^^^^^^^^^^ help: try: `current` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DoublyLinkedList` [INFO] [stdout] --> src/doubly_linked_list.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> DoublyLinkedList { [INFO] [stdout] 17 | | DoublyLinkedList { [INFO] [stdout] 18 | | head: None, [INFO] [stdout] 19 | | length: 0, [INFO] [stdout] 20 | | } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 6 + impl Default for DoublyLinkedList { [INFO] [stdout] 7 + fn default() -> Self { [INFO] [stdout] 8 + Self::new() [INFO] [stdout] 9 + } [INFO] [stdout] 10 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `next` is never read [INFO] [stdout] --> src/doubly_linked_list.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 64 | pub struct ListNode { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 65 | next: Option>>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_with_value` is never used [INFO] [stdout] --> src/doubly_linked_list.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 87 | fn test_with_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `linked_list::ListNode` [INFO] [stdout] --> src/linked_list.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / fn to_string(&self) -> String { [INFO] [stdout] 21 | | format!("[{}]", self.data) [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `linked_list::ListNode` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linked_list.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 36 | print(&head); [INFO] [stdout] | ^^^^^ help: change this to: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linked_list.rs:37:55 [INFO] [stdout] | [INFO] [stdout] 37 | println!("Linked list length {len}", len = length(&head)); [INFO] [stdout] | ^^^^^ help: change this to: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | return new_node; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return new_node; [INFO] [stdout] 60 + new_node [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | return head.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return head.unwrap(); [INFO] [stdout] 76 + head.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | return head.expect("head node must exist to insert at position"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return head.expect("head node must exist to insert at position"); [INFO] [stdout] 107 + head.expect("head node must exist to insert at position") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 104 | cur = &mut (*node).next; [INFO] [stdout] | ^^^^^^^ help: try: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:113:29 [INFO] [stdout] | [INFO] [stdout] 113 | Some(first_node) => return first_node.next, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - Some(first_node) => return first_node.next, [INFO] [stdout] 113 + Some(first_node) => first_node.next, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return None; [INFO] [stdout] 139 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:124:47 [INFO] [stdout] | [INFO] [stdout] 124 | while let Some(ref mut current) = (*cur).next { [INFO] [stdout] | ^^^^^^ help: try: `cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:132:25 [INFO] [stdout] | [INFO] [stdout] 132 | (*current).next = None; [INFO] [stdout] | ^^^^^^^^^^ help: try: `current` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linked_list.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | return head; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return head; [INFO] [stdout] 179 + head [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:159:47 [INFO] [stdout] | [INFO] [stdout] 159 | while let Some(ref mut current) = (*cur).next { [INFO] [stdout] | ^^^^^^ help: try: `cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:168:43 [INFO] [stdout] | [INFO] [stdout] 168 | (*current).next = (*next).next.take(); [INFO] [stdout] | ^^^^^^^ help: try: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:168:25 [INFO] [stdout] | [INFO] [stdout] 168 | (*current).next = (*next).next.take(); [INFO] [stdout] | ^^^^^^^^^^ help: try: `current` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:225:20 [INFO] [stdout] | [INFO] [stdout] 225 | assert_eq!((*head).data, 1); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:226:17 [INFO] [stdout] | [INFO] [stdout] 226 | assert!((*head).next.is_none()); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linked_list.rs:233:17 [INFO] [stdout] | [INFO] [stdout] 233 | assert!(!(*head).next.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*head).next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:232:20 [INFO] [stdout] | [INFO] [stdout] 232 | assert_ne!((*head).data, 10); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:233:18 [INFO] [stdout] | [INFO] [stdout] 233 | assert!(!(*head).next.is_some()); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:241:20 [INFO] [stdout] | [INFO] [stdout] 241 | assert_eq!((*head).data, 1); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 243 | assert!((*head).next.is_some()); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:254:20 [INFO] [stdout] | [INFO] [stdout] 254 | assert_eq!((*head).data, 1); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:255:17 [INFO] [stdout] | [INFO] [stdout] 255 | assert!((*head).next.is_none()); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:258:20 [INFO] [stdout] | [INFO] [stdout] 258 | assert_eq!((*head).data, 1); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | assert!((*head).next.is_some()); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:265:20 [INFO] [stdout] | [INFO] [stdout] 265 | assert_eq!((*head).data, 1); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:266:17 [INFO] [stdout] | [INFO] [stdout] 266 | assert!((*head).next.is_none()); [INFO] [stdout] | ^^^^^^^ help: try: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linked_list.rs:283:23 [INFO] [stdout] | [INFO] [stdout] 283 | cur = &node; [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:289:20 [INFO] [stdout] | [INFO] [stdout] 289 | assert_eq!((*cur).data, value); [INFO] [stdout] | ^^^^^^ help: try: `cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:342:36 [INFO] [stdout] | [INFO] [stdout] 342 | while let Some(ref node) = (*cur).next { [INFO] [stdout] | ^^^^^^ help: try: `cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:347:23 [INFO] [stdout] | [INFO] [stdout] 347 | assert_eq!(1, (*cur).data); [INFO] [stdout] | ^^^^^^ help: try: `cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linked_list.rs:377:36 [INFO] [stdout] | [INFO] [stdout] 377 | original_cur = &node; [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:381:29 [INFO] [stdout] | [INFO] [stdout] 381 | original_data = (*original_cur).data; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `original_cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linked_list.rs:391:23 [INFO] [stdout] | [INFO] [stdout] 391 | cur = &node; [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/linked_list.rs:395:35 [INFO] [stdout] | [INFO] [stdout] 395 | assert_ne!(original_data, (*cur).data); [INFO] [stdout] | ^^^^^^ help: try: `cur` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DoublyLinkedList` [INFO] [stdout] --> src/doubly_linked_list.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> DoublyLinkedList { [INFO] [stdout] 17 | | DoublyLinkedList { [INFO] [stdout] 18 | | head: None, [INFO] [stdout] 19 | | length: 0, [INFO] [stdout] 20 | | } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 6 + impl Default for DoublyLinkedList { [INFO] [stdout] 7 + fn default() -> Self { [INFO] [stdout] 8 + Self::new() [INFO] [stdout] 9 + } [INFO] [stdout] 10 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `Command { std: "docker" "inspect" "7f2386fe626a7b083b2b7ca0da19f6314f001ae35d054acceb82306c23763ed5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f2386fe626a7b083b2b7ca0da19f6314f001ae35d054acceb82306c23763ed5", kill_on_drop: false }` [INFO] [stdout] 7f2386fe626a7b083b2b7ca0da19f6314f001ae35d054acceb82306c23763ed5