[INFO] fetching crate evdev-rs 0.6.3... [INFO] linting evdev-rs-0.6.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate evdev-rs 0.6.3 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate evdev-rs 0.6.3 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate evdev-rs 0.6.3 [INFO] tweaked toml for crates.io crate evdev-rs 0.6.3 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate evdev-rs 0.6.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate evdev-rs 0.6.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded evdev-sys v0.2.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d9c2f56e64a8af199f8d6694740e4bc7ca79b25f1bbde2fe1c2bcafa0067324d [INFO] running `Command { std: "docker" "start" "-a" "d9c2f56e64a8af199f8d6694740e4bc7ca79b25f1bbde2fe1c2bcafa0067324d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d9c2f56e64a8af199f8d6694740e4bc7ca79b25f1bbde2fe1c2bcafa0067324d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9c2f56e64a8af199f8d6694740e4bc7ca79b25f1bbde2fe1c2bcafa0067324d", kill_on_drop: false }` [INFO] [stdout] d9c2f56e64a8af199f8d6694740e4bc7ca79b25f1bbde2fe1c2bcafa0067324d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb2c0fee99324d4b7717b674f40d5b480cfc0c64c8ede62c04eca1f5017c1a19 [INFO] running `Command { std: "docker" "start" "-a" "fb2c0fee99324d4b7717b674f40d5b480cfc0c64c8ede62c04eca1f5017c1a19", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.27 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling evdev-sys v0.2.6 [INFO] [stderr] Checking evdev-rs v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/device.rs:668:16 [INFO] [stdout] | [INFO] [stdout] 668 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/device.rs:668:16 [INFO] [stdout] | [INFO] [stdout] 668 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EventTypeIterator` [INFO] [stdout] --> src/util.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn new() -> Self { [INFO] [stdout] 29 | | EventTypeIterator { [INFO] [stdout] 30 | | current: EventType::EV_SYN, [INFO] [stdout] 31 | | } [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 27 + impl Default for EventTypeIterator { [INFO] [stdout] 28 + fn default() -> Self { [INFO] [stdout] 29 + Self::new() [INFO] [stdout] 30 + } [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `InputPropIterator` [INFO] [stdout] --> src/util.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / pub fn new() -> Self { [INFO] [stdout] 60 | | InputPropIterator { [INFO] [stdout] 61 | | current: InputProp::INPUT_PROP_POINTER, [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for InputPropIterator { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/util.rs:93:48 [INFO] [stdout] | [INFO] [stdout] 93 | let ev_type: EventType = int_to_event_type(event_type as u32).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `event_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/util.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | let code = event_code as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `event_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/util.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 159 | / pub fn from_str(name: &str) -> Option { [INFO] [stdout] 160 | | let name = CString::new(name).unwrap(); [INFO] [stdout] 161 | | let result = unsafe { raw::libevdev_event_type_from_name(name.as_ptr()) }; [INFO] [stdout] ... | [INFO] [stdout] 167 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/util.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | / pub fn from_str(name: &str) -> Option { [INFO] [stdout] 213 | | let name = CString::new(name).unwrap(); [INFO] [stdout] 214 | | let result = unsafe { raw::libevdev_property_from_name(name.as_ptr()) }; [INFO] [stdout] ... | [INFO] [stdout] 220 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EventTypeIterator` [INFO] [stdout] --> src/util.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn new() -> Self { [INFO] [stdout] 29 | | EventTypeIterator { [INFO] [stdout] 30 | | current: EventType::EV_SYN, [INFO] [stdout] 31 | | } [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 27 + impl Default for EventTypeIterator { [INFO] [stdout] 28 + fn default() -> Self { [INFO] [stdout] 29 + Self::new() [INFO] [stdout] 30 + } [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `InputPropIterator` [INFO] [stdout] --> src/util.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / pub fn new() -> Self { [INFO] [stdout] 60 | | InputPropIterator { [INFO] [stdout] 61 | | current: InputProp::INPUT_PROP_POINTER, [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for InputPropIterator { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/util.rs:93:48 [INFO] [stdout] | [INFO] [stdout] 93 | let ev_type: EventType = int_to_event_type(event_type as u32).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `event_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/util.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | let code = event_code as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `event_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/util.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 159 | / pub fn from_str(name: &str) -> Option { [INFO] [stdout] 160 | | let name = CString::new(name).unwrap(); [INFO] [stdout] 161 | | let result = unsafe { raw::libevdev_event_type_from_name(name.as_ptr()) }; [INFO] [stdout] ... | [INFO] [stdout] 167 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/util.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | / pub fn from_str(name: &str) -> Option { [INFO] [stdout] 213 | | let name = CString::new(name).unwrap(); [INFO] [stdout] 214 | | let result = unsafe { raw::libevdev_property_from_name(name.as_ptr()) }; [INFO] [stdout] ... | [INFO] [stdout] 220 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `EventType` [INFO] [stdout] --> examples/vmouse.rs:3:43 [INFO] [stdout] | [INFO] [stdout] 3 | use evdev_rs::enums::{BusType, EventCode, EventType, EV_KEY, EV_REL, EV_SYN}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `EV_ABS` which implements the `Copy` trait [INFO] [stdout] --> examples/evtest.rs:14:34 [INFO] [stdout] | [INFO] [stdout] 14 | let code = EventCode::EV_ABS(axis.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*axis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> examples/evtest.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / match code { [INFO] [stdout] 44 | | EventCode::EV_ABS(k) => print_abs_bits(dev, &k), [INFO] [stdout] 45 | | _ => (), [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________^ help: try: `if let EventCode::EV_ABS(k) = code { print_abs_bits(dev, &k) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> examples/vmouse.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | let n = args.nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `args.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.29s [INFO] running `Command { std: "docker" "inspect" "fb2c0fee99324d4b7717b674f40d5b480cfc0c64c8ede62c04eca1f5017c1a19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb2c0fee99324d4b7717b674f40d5b480cfc0c64c8ede62c04eca1f5017c1a19", kill_on_drop: false }` [INFO] [stdout] fb2c0fee99324d4b7717b674f40d5b480cfc0c64c8ede62c04eca1f5017c1a19