[INFO] fetching crate ethernet-info 0.0.4... [INFO] linting ethernet-info-0.0.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ethernet-info 0.0.4 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate ethernet-info 0.0.4 [INFO] finished tweaking crates.io crate ethernet-info 0.0.4 [INFO] tweaked toml for crates.io crate ethernet-info 0.0.4 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ethernet-info 0.0.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ethernet-info 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded enum-iterator v1.5.0 [INFO] [stderr] Downloaded enum-iterator-derive v1.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 226a917204e57a1bc080147002b1910de8a58b89dc1313d8f44bbdf099df1fc2 [INFO] running `Command { std: "docker" "start" "-a" "226a917204e57a1bc080147002b1910de8a58b89dc1313d8f44bbdf099df1fc2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "226a917204e57a1bc080147002b1910de8a58b89dc1313d8f44bbdf099df1fc2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "226a917204e57a1bc080147002b1910de8a58b89dc1313d8f44bbdf099df1fc2", kill_on_drop: false }` [INFO] [stdout] 226a917204e57a1bc080147002b1910de8a58b89dc1313d8f44bbdf099df1fc2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 861f1d9307e3a6457bac8fb21c0eb231a0c240d54c9acb1ee70489c66c4f4138 [INFO] running `Command { std: "docker" "start" "-a" "861f1d9307e3a6457bac8fb21c0eb231a0c240d54c9acb1ee70489c66c4f4138", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling enum-iterator-derive v1.3.0 [INFO] [stderr] Checking enum-iterator v1.5.0 [INFO] [stderr] Checking ethernet-info v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/internal.rs:199:34 [INFO] [stdout] | [INFO] [stdout] 199 | ifru_data: { transmute(&mut ecmd as *mut _) }, [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*mut internal::EthtoolCommnad, *mut i8>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::hint::must_use` that must be used [INFO] [stdout] --> src/errors.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | format!("{:?}", err); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 35 | let _ = format!("{:?}", err); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::hint::must_use` that must be used [INFO] [stdout] --> src/ethtool_const.rs:460:13 [INFO] [stdout] | [INFO] [stdout] 460 | format!("{:?}", item); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 460 | let _ = format!("{:?}", item); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::hint::must_use` that must be used [INFO] [stdout] --> src/ethtool_const.rs:465:13 [INFO] [stdout] | [INFO] [stdout] 465 | format!("{:?}", item); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 465 | let _ = format!("{:?}", item); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::hint::must_use` that must be used [INFO] [stdout] --> src/ethtool_const.rs:470:13 [INFO] [stdout] | [INFO] [stdout] 470 | format!("{:?}", item); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 470 | let _ = format!("{:?}", item); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/internal.rs:199:34 [INFO] [stdout] | [INFO] [stdout] 199 | ifru_data: { transmute(&mut ecmd as *mut _) }, [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*mut internal::EthtoolCommnad, *mut i8>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> examples/show-all-interfaces-info.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 20 - print!("\n"); [INFO] [stdout] 20 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> tests/utils/ethtool_parser.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let port; [INFO] [stdout] | ^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 65 | / port = if port_vec.is_empty() { [INFO] [stdout] 66 | | None [INFO] [stdout] 67 | | } else { [INFO] [stdout] 68 | | Some(port_vec.join(" ")) [INFO] [stdout] 69 | | }; [INFO] [stdout] | |_________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `port` here [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 | // Get the output of the ethtool command, and conbine the lines that are [INFO] [stdout] ... [INFO] [stdout] 64 | let port_vec = parse_ethtool_output("Port", output.iter().map(|s| s.as_str()).collect()); [INFO] [stdout] 65 ~ let port = if port_vec.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils/ethtool_parser.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return None; [INFO] [stdout] 40 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/utils/ethtool_parser.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | return Some(part); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Some(part); [INFO] [stdout] 42 + Some(part) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> tests/utils/ethtool_parser.rs:52:69 [INFO] [stdout] | [INFO] [stdout] 52 | } else if pause_link_modes.contains(&"Receive-only".into()) { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 53 | | supported_ports.push("Asym_Pause".into()); [INFO] [stdout] 54 | | } else if pause_link_modes.contains(&"Transmit-only".into()) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> tests/utils/ethtool_parser.rs:54:70 [INFO] [stdout] | [INFO] [stdout] 54 | } else if pause_link_modes.contains(&"Transmit-only".into()) { [INFO] [stdout] | ______________________________________________________________________^ [INFO] [stdout] 55 | | supported_ports.push("Asym_Pause".into()); [INFO] [stdout] 56 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> tests/utils/ethtool_parser.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | last.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `last.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test_ethtool.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if !std::env::var("NO_SUPPORTED_PORTS").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("NO_SUPPORTED_PORTS").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/test_ethtool.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if ethtool_output.advertised_link_modes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ethtool_output.advertised_link_modes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test_ethtool.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 73 | if !std::env::var("NO_SUPPORTED_PORTS").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("NO_SUPPORTED_PORTS").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/test_ethtool.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 68 | if ethtool_output.supported_ports.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ethtool_output.supported_ports.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/test_ethtool.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | if ethtool_output.supported_link_modes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ethtool_output.supported_link_modes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `ethernet_info.get(0)` [INFO] [stdout] --> tests/test_ethtool.rs:109:29 [INFO] [stdout] | [INFO] [stdout] 109 | let ethernet_info = ethernet_info.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ethernet_info.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.11s [INFO] running `Command { std: "docker" "inspect" "861f1d9307e3a6457bac8fb21c0eb231a0c240d54c9acb1ee70489c66c4f4138", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "861f1d9307e3a6457bac8fb21c0eb231a0c240d54c9acb1ee70489c66c4f4138", kill_on_drop: false }` [INFO] [stdout] 861f1d9307e3a6457bac8fb21c0eb231a0c240d54c9acb1ee70489c66c4f4138