[INFO] fetching crate ethcore-logger 1.12.0... [INFO] linting ethcore-logger-1.12.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ethcore-logger 1.12.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate ethcore-logger 1.12.0 [INFO] finished tweaking crates.io crate ethcore-logger 1.12.0 [INFO] tweaked toml for crates.io crate ethcore-logger 1.12.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ethcore-logger 1.12.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding ansi_term v0.10.2 (available: v0.12.1) [INFO] [stderr] Adding arrayvec v0.4.12 (available: v0.7.6) [INFO] [stderr] Adding env_logger v0.4.3 (available: v0.11.9) [INFO] [stderr] Adding log v0.3.9 (available: v0.4.29) [INFO] [stderr] Adding parking_lot v0.5.5 (available: v0.12.5) [INFO] [stderr] Adding regex v0.2.11 (available: v1.12.3) [INFO] [stderr] Adding time v0.1.45 (available: v0.3.47) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded env_logger v0.4.3 [INFO] [stderr] Downloaded ansi_term v0.10.2 [INFO] [stderr] Downloaded parking_lot v0.5.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d33c0d669ac3a9a2e140c02433ccb14559914fd38cab0f95d712bf7a30f2e7a [INFO] running `Command { std: "docker" "start" "-a" "4d33c0d669ac3a9a2e140c02433ccb14559914fd38cab0f95d712bf7a30f2e7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d33c0d669ac3a9a2e140c02433ccb14559914fd38cab0f95d712bf7a30f2e7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d33c0d669ac3a9a2e140c02433ccb14559914fd38cab0f95d712bf7a30f2e7a", kill_on_drop: false }` [INFO] [stdout] 4d33c0d669ac3a9a2e140c02433ccb14559914fd38cab0f95d712bf7a30f2e7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 630e673253ff3e21fe8fcdf3efb1d8a6a84b8e1f1416ec525efb33322729dd72 [INFO] running `Command { std: "docker" "start" "-a" "630e673253ff3e21fe8fcdf3efb1d8a6a84b8e1f1416ec525efb33322729dd72", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ansi_term v0.10.2 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking ethcore-logger v1.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rotating.rs:62:4 [INFO] [stdout] | [INFO] [stdout] 62 | levels: levels, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `levels` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rotating.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 35 | if !builder.init().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `builder.init().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:80:3 [INFO] [stdout] | [INFO] [stdout] 80 | levels.push_str(","); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `levels.push(',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/lib.rs:134:2 [INFO] [stdout] | [INFO] [stdout] 134 | / builder.init() [INFO] [stdout] 135 | | .and_then(|_| { [INFO] [stdout] 136 | | *ROTATING_LOGGER.lock() = Arc::downgrade(&logs); [INFO] [stdout] 137 | | Ok(logs) [INFO] [stdout] 138 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 135 ~ .map(|_| { [INFO] [stdout] 136 | *ROTATING_LOGGER.lock() = Arc::downgrade(&logs); [INFO] [stdout] 137 ~ logs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rotating.rs:82:14 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn logs(&self) -> RwLockReadGuard> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 82 | pub fn logs(&self) -> RwLockReadGuard<'_, ArrayVec<[String; LOG_SIZE]>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rotating.rs:62:4 [INFO] [stdout] | [INFO] [stdout] 62 | levels: levels, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `levels` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rotating.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 35 | if !builder.init().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `builder.init().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:80:3 [INFO] [stdout] | [INFO] [stdout] 80 | levels.push_str(","); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `levels.push(',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/lib.rs:134:2 [INFO] [stdout] | [INFO] [stdout] 134 | / builder.init() [INFO] [stdout] 135 | | .and_then(|_| { [INFO] [stdout] 136 | | *ROTATING_LOGGER.lock() = Arc::downgrade(&logs); [INFO] [stdout] 137 | | Ok(logs) [INFO] [stdout] 138 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 135 ~ .map(|_| { [INFO] [stdout] 136 | *ROTATING_LOGGER.lock() = Arc::downgrade(&logs); [INFO] [stdout] 137 ~ logs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rotating.rs:82:14 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn logs(&self) -> RwLockReadGuard> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 82 | pub fn logs(&self) -> RwLockReadGuard<'_, ArrayVec<[String; LOG_SIZE]>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.21s [INFO] running `Command { std: "docker" "inspect" "630e673253ff3e21fe8fcdf3efb1d8a6a84b8e1f1416ec525efb33322729dd72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "630e673253ff3e21fe8fcdf3efb1d8a6a84b8e1f1416ec525efb33322729dd72", kill_on_drop: false }` [INFO] [stdout] 630e673253ff3e21fe8fcdf3efb1d8a6a84b8e1f1416ec525efb33322729dd72