[INFO] fetching crate esbuild-config 0.2.0... [INFO] linting esbuild-config-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate esbuild-config 0.2.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate esbuild-config 0.2.0 [INFO] finished tweaking crates.io crate esbuild-config 0.2.0 [INFO] tweaked toml for crates.io crate esbuild-config 0.2.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate esbuild-config 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate esbuild-config 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded snailquote v0.3.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.19 [INFO] [stderr] Downloaded syn v1.0.38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c892293a0cdb3ddfc726ccd6363def124e2419e192dd73a322bb765342d71dac [INFO] running `Command { std: "docker" "start" "-a" "c892293a0cdb3ddfc726ccd6363def124e2419e192dd73a322bb765342d71dac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c892293a0cdb3ddfc726ccd6363def124e2419e192dd73a322bb765342d71dac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c892293a0cdb3ddfc726ccd6363def124e2419e192dd73a322bb765342d71dac", kill_on_drop: false }` [INFO] [stdout] c892293a0cdb3ddfc726ccd6363def124e2419e192dd73a322bb765342d71dac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 701ae0f3740f64b7bc1985167885c3bc0e71c43a7328848161935e9915a1e53e [INFO] running `Command { std: "docker" "start" "-a" "701ae0f3740f64b7bc1985167885c3bc0e71c43a7328848161935e9915a1e53e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling syn v1.0.38 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking snailquote v0.3.0 [INFO] [stderr] Checking esbuild-config v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/args.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/args.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use snailquote; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/mod.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/args.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/args.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use snailquote; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/mod.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / match entries_from_config(value) { [INFO] [stdout] 22 | | Some(result) => entries = result, [INFO] [stdout] 23 | | None => (), [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(result) = entries_from_config(value) { entries = result }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / match option_from_config(key, value) { [INFO] [stdout] 28 | | Some(param) => options.push(param), [INFO] [stdout] 29 | | None => (), [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(param) = option_from_config(key, value) { options.push(param) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib/args.rs:58:33 [INFO] [stdout] | [INFO] [stdout] 58 | .filter_map(|entry| match entry.as_str() { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 59 | | Some(value) => Some(quote_value(value)), [INFO] [stdout] 60 | | None => None, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_____________^ help: try: `entry.as_str().map(|value| quote_value(value))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib/args.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | / match value.as_str() { [INFO] [stdout] 105 | | Some(value) => Some(["--", key, "=", "e_value(value)].concat()), [INFO] [stdout] 106 | | None => None, [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ help: try: `value.as_str().map(|value| ["--", key, "=", "e_value(value)].concat())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | / match v.as_str() { [INFO] [stdout] 116 | | Some(value) => options.push(["--", key, ":", k, "=", "e_value(value)].concat()), [INFO] [stdout] 117 | | None => (), [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(value) = v.as_str() { options.push(["--", key, ":", k, "=", "e_value(value)].concat()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/args.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 121 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / match param_value.as_str() { [INFO] [stdout] 134 | | Some(value) => options.push(["--", key, ":", "e_value(value)].concat()), [INFO] [stdout] 135 | | None => (), [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(value) = param_value.as_str() { options.push(["--", key, ":", "e_value(value)].concat()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/args.rs:139:8 [INFO] [stdout] | [INFO] [stdout] 139 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/args.rs:148:36 [INFO] [stdout] | [INFO] [stdout] 148 | let value = snailquote::escape(&value).to_string(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib/args.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 149 | if value == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / match entries_from_config(value) { [INFO] [stdout] 22 | | Some(result) => entries = result, [INFO] [stdout] 23 | | None => (), [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(result) = entries_from_config(value) { entries = result }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / match option_from_config(key, value) { [INFO] [stdout] 28 | | Some(param) => options.push(param), [INFO] [stdout] 29 | | None => (), [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(param) = option_from_config(key, value) { options.push(param) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib/args.rs:58:33 [INFO] [stdout] | [INFO] [stdout] 58 | .filter_map(|entry| match entry.as_str() { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 59 | | Some(value) => Some(quote_value(value)), [INFO] [stdout] 60 | | None => None, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_____________^ help: try: `entry.as_str().map(|value| quote_value(value))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib/mod.rs:27:54 [INFO] [stdout] | [INFO] [stdout] 27 | Err(_) => Err(errors::EsbuildConfigError::Io(io::Error::new( [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 28 | | io::ErrorKind::Other, [INFO] [stdout] 29 | | [ [INFO] [stdout] 30 | | "Couldn’t read ", [INFO] [stdout] ... | [INFO] [stdout] 36 | | .concat(), [INFO] [stdout] 37 | | ))), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 27 ~ Err(_) => Err(errors::EsbuildConfigError::Io(io::Error::other( [INFO] [stdout] 28 ~ [ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/mod.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | Err(_) => return Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - Err(_) => return Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] 52 + Err(_) => Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib/args.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | / match value.as_str() { [INFO] [stdout] 105 | | Some(value) => Some(["--", key, "=", "e_value(value)].concat()), [INFO] [stdout] 106 | | None => None, [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ help: try: `value.as_str().map(|value| ["--", key, "=", "e_value(value)].concat())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | / match v.as_str() { [INFO] [stdout] 116 | | Some(value) => options.push(["--", key, ":", k, "=", "e_value(value)].concat()), [INFO] [stdout] 117 | | None => (), [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(value) = v.as_str() { options.push(["--", key, ":", k, "=", "e_value(value)].concat()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/args.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 121 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / match param_value.as_str() { [INFO] [stdout] 134 | | Some(value) => options.push(["--", key, ":", "e_value(value)].concat()), [INFO] [stdout] 135 | | None => (), [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(value) = param_value.as_str() { options.push(["--", key, ":", "e_value(value)].concat()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/args.rs:139:8 [INFO] [stdout] | [INFO] [stdout] 139 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/args.rs:148:36 [INFO] [stdout] | [INFO] [stdout] 148 | let value = snailquote::escape(&value).to_string(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib/args.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 149 | if value == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/args.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | assert!(!option_from_config("name", &value).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option_from_config("name", &value).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/args.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | assert!(!option_from_config("name", &value).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option_from_config("name", &value).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/args.rs:220:17 [INFO] [stdout] | [INFO] [stdout] 220 | assert!(!option_from_config("name", &value).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option_from_config("name", &value).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/args.rs:223:17 [INFO] [stdout] | [INFO] [stdout] 223 | assert!(!option_from_config("name", &value).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option_from_config("name", &value).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib/mod.rs:27:54 [INFO] [stdout] | [INFO] [stdout] 27 | Err(_) => Err(errors::EsbuildConfigError::Io(io::Error::new( [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 28 | | io::ErrorKind::Other, [INFO] [stdout] 29 | | [ [INFO] [stdout] 30 | | "Couldn’t read ", [INFO] [stdout] ... | [INFO] [stdout] 36 | | .concat(), [INFO] [stdout] 37 | | ))), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 27 ~ Err(_) => Err(errors::EsbuildConfigError::Io(io::Error::other( [INFO] [stdout] 28 ~ [ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/mod.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | Err(_) => return Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - Err(_) => return Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] 52 + Err(_) => Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/lib/mod.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | / match parse_esbuild_config("true".to_string(), ConfigFileType::ConfigJson) { [INFO] [stdout] 77 | | Ok(_) => false, [INFO] [stdout] 78 | | Err(_) => true, [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____________^ help: try: `parse_esbuild_config("true".to_string(), ConfigFileType::ConfigJson).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/lib/mod.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | / match parse_esbuild_config("1".to_string(), ConfigFileType::PackageJson) { [INFO] [stdout] 99 | | Ok(_) => false, [INFO] [stdout] 100 | | Err(_) => true, [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____________^ help: try: `parse_esbuild_config("1".to_string(), ConfigFileType::PackageJson).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/lib/mod.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / match parse_esbuild_config("{}".to_string(), ConfigFileType::PackageJson) { [INFO] [stdout] 105 | | Ok(_) => false, [INFO] [stdout] 106 | | Err(_) => true, [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____________^ help: try: `parse_esbuild_config("{}".to_string(), ConfigFileType::PackageJson).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/args.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/args.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use snailquote; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/mod.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/args.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/args.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use snailquote; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib/mod.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/errors.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | Io(io::Error), [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EsbuildConfigError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 7 - Io(io::Error), [INFO] [stdout] 7 + Io(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/errors.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | Io(io::Error), [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ConfigPathError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 17 - Io(io::Error), [INFO] [stdout] 17 + Io(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/errors.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | JsonError(json::Error), [INFO] [stdout] | --------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ConfigParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 - JsonError(json::Error), [INFO] [stdout] 28 + JsonError(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `InvalidConfigError` is never constructed [INFO] [stdout] --> src/lib/errors.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct InvalidConfigError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / match entries_from_config(value) { [INFO] [stdout] 22 | | Some(result) => entries = result, [INFO] [stdout] 23 | | None => (), [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(result) = entries_from_config(value) { entries = result }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / match option_from_config(key, value) { [INFO] [stdout] 28 | | Some(param) => options.push(param), [INFO] [stdout] 29 | | None => (), [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(param) = option_from_config(key, value) { options.push(param) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib/args.rs:58:33 [INFO] [stdout] | [INFO] [stdout] 58 | .filter_map(|entry| match entry.as_str() { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 59 | | Some(value) => Some(quote_value(value)), [INFO] [stdout] 60 | | None => None, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_____________^ help: try: `entry.as_str().map(|value| quote_value(value))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib/args.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | / match value.as_str() { [INFO] [stdout] 105 | | Some(value) => Some(["--", key, "=", "e_value(value)].concat()), [INFO] [stdout] 106 | | None => None, [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ help: try: `value.as_str().map(|value| ["--", key, "=", "e_value(value)].concat())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | / match v.as_str() { [INFO] [stdout] 116 | | Some(value) => options.push(["--", key, ":", k, "=", "e_value(value)].concat()), [INFO] [stdout] 117 | | None => (), [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(value) = v.as_str() { options.push(["--", key, ":", k, "=", "e_value(value)].concat()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/args.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 121 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / match param_value.as_str() { [INFO] [stdout] 134 | | Some(value) => options.push(["--", key, ":", "e_value(value)].concat()), [INFO] [stdout] 135 | | None => (), [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(value) = param_value.as_str() { options.push(["--", key, ":", "e_value(value)].concat()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/args.rs:139:8 [INFO] [stdout] | [INFO] [stdout] 139 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/args.rs:148:36 [INFO] [stdout] | [INFO] [stdout] 148 | let value = snailquote::escape(&value).to_string(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib/args.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 149 | if value == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/args.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | assert!(!option_from_config("name", &value).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option_from_config("name", &value).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/args.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | assert!(!option_from_config("name", &value).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option_from_config("name", &value).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/args.rs:220:17 [INFO] [stdout] | [INFO] [stdout] 220 | assert!(!option_from_config("name", &value).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option_from_config("name", &value).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/args.rs:223:17 [INFO] [stdout] | [INFO] [stdout] 223 | assert!(!option_from_config("name", &value).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option_from_config("name", &value).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib/mod.rs:27:54 [INFO] [stdout] | [INFO] [stdout] 27 | Err(_) => Err(errors::EsbuildConfigError::Io(io::Error::new( [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 28 | | io::ErrorKind::Other, [INFO] [stdout] 29 | | [ [INFO] [stdout] 30 | | "Couldn’t read ", [INFO] [stdout] ... | [INFO] [stdout] 36 | | .concat(), [INFO] [stdout] 37 | | ))), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 27 ~ Err(_) => Err(errors::EsbuildConfigError::Io(io::Error::other( [INFO] [stdout] 28 ~ [ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/mod.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | Err(_) => return Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - Err(_) => return Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] 52 + Err(_) => Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/lib/mod.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | / match parse_esbuild_config("true".to_string(), ConfigFileType::ConfigJson) { [INFO] [stdout] 77 | | Ok(_) => false, [INFO] [stdout] 78 | | Err(_) => true, [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____________^ help: try: `parse_esbuild_config("true".to_string(), ConfigFileType::ConfigJson).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/lib/mod.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | / match parse_esbuild_config("1".to_string(), ConfigFileType::PackageJson) { [INFO] [stdout] 99 | | Ok(_) => false, [INFO] [stdout] 100 | | Err(_) => true, [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____________^ help: try: `parse_esbuild_config("1".to_string(), ConfigFileType::PackageJson).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/lib/mod.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / match parse_esbuild_config("{}".to_string(), ConfigFileType::PackageJson) { [INFO] [stdout] 105 | | Ok(_) => false, [INFO] [stdout] 106 | | Err(_) => true, [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____________^ help: try: `parse_esbuild_config("{}".to_string(), ConfigFileType::PackageJson).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/errors.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | Io(io::Error), [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EsbuildConfigError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 7 - Io(io::Error), [INFO] [stdout] 7 + Io(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/errors.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | Io(io::Error), [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ConfigPathError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 17 - Io(io::Error), [INFO] [stdout] 17 + Io(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/errors.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | JsonError(json::Error), [INFO] [stdout] | --------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ConfigParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 - JsonError(json::Error), [INFO] [stdout] 28 + JsonError(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `InvalidConfigError` is never constructed [INFO] [stdout] --> src/lib/errors.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct InvalidConfigError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / match entries_from_config(value) { [INFO] [stdout] 22 | | Some(result) => entries = result, [INFO] [stdout] 23 | | None => (), [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(result) = entries_from_config(value) { entries = result }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / match option_from_config(key, value) { [INFO] [stdout] 28 | | Some(param) => options.push(param), [INFO] [stdout] 29 | | None => (), [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(param) = option_from_config(key, value) { options.push(param) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib/args.rs:58:33 [INFO] [stdout] | [INFO] [stdout] 58 | .filter_map(|entry| match entry.as_str() { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 59 | | Some(value) => Some(quote_value(value)), [INFO] [stdout] 60 | | None => None, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_____________^ help: try: `entry.as_str().map(|value| quote_value(value))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib/args.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | / match value.as_str() { [INFO] [stdout] 105 | | Some(value) => Some(["--", key, "=", "e_value(value)].concat()), [INFO] [stdout] 106 | | None => None, [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ help: try: `value.as_str().map(|value| ["--", key, "=", "e_value(value)].concat())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | / match v.as_str() { [INFO] [stdout] 116 | | Some(value) => options.push(["--", key, ":", k, "=", "e_value(value)].concat()), [INFO] [stdout] 117 | | None => (), [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(value) = v.as_str() { options.push(["--", key, ":", k, "=", "e_value(value)].concat()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/args.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 121 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/args.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / match param_value.as_str() { [INFO] [stdout] 134 | | Some(value) => options.push(["--", key, ":", "e_value(value)].concat()), [INFO] [stdout] 135 | | None => (), [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(value) = param_value.as_str() { options.push(["--", key, ":", "e_value(value)].concat()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/args.rs:139:8 [INFO] [stdout] | [INFO] [stdout] 139 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/args.rs:148:36 [INFO] [stdout] | [INFO] [stdout] 148 | let value = snailquote::escape(&value).to_string(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib/args.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 149 | if value == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib/mod.rs:27:54 [INFO] [stdout] | [INFO] [stdout] 27 | Err(_) => Err(errors::EsbuildConfigError::Io(io::Error::new( [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 28 | | io::ErrorKind::Other, [INFO] [stdout] 29 | | [ [INFO] [stdout] 30 | | "Couldn’t read ", [INFO] [stdout] ... | [INFO] [stdout] 36 | | .concat(), [INFO] [stdout] 37 | | ))), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 27 ~ Err(_) => Err(errors::EsbuildConfigError::Io(io::Error::other( [INFO] [stdout] 28 ~ [ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/mod.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | Err(_) => return Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - Err(_) => return Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] 52 + Err(_) => Err(errors::ConfigParseError::InvalidConfigError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.85s [INFO] running `Command { std: "docker" "inspect" "701ae0f3740f64b7bc1985167885c3bc0e71c43a7328848161935e9915a1e53e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "701ae0f3740f64b7bc1985167885c3bc0e71c43a7328848161935e9915a1e53e", kill_on_drop: false }` [INFO] [stdout] 701ae0f3740f64b7bc1985167885c3bc0e71c43a7328848161935e9915a1e53e