[INFO] fetching crate envhub 0.2.18... [INFO] linting envhub-0.2.18 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate envhub 0.2.18 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate envhub 0.2.18 [INFO] finished tweaking crates.io crate envhub 0.2.18 [INFO] tweaked toml for crates.io crate envhub 0.2.18 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate envhub 0.2.18 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate envhub 0.2.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded users v0.11.0 [INFO] [stderr] Downloaded toml v0.7.8 [INFO] [stderr] Downloaded serde_spanned v0.6.3 [INFO] [stderr] Downloaded cpufeatures v0.2.9 [INFO] [stderr] Downloaded signal-hook-mio v0.2.3 [INFO] [stderr] Downloaded newline-converter v0.2.2 [INFO] [stderr] Downloaded redox_users v0.4.3 [INFO] [stderr] Downloaded tokio-macros v2.1.0 [INFO] [stderr] Downloaded colorchoice v1.0.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.68 [INFO] [stderr] Downloaded anstyle-query v1.0.0 [INFO] [stderr] Downloaded anstyle-wincon v3.0.1 [INFO] [stderr] Downloaded anstyle v1.0.4 [INFO] [stderr] Downloaded os_str_bytes v6.5.1 [INFO] [stderr] Downloaded termcolor v1.3.0 [INFO] [stderr] Downloaded clap v4.4.6 [INFO] [stderr] Downloaded pest_meta v2.7.4 [INFO] [stderr] Downloaded crossbeam-channel v0.4.4 [INFO] [stderr] Downloaded hashbrown v0.9.1 [INFO] [stderr] Downloaded pest v2.7.4 [INFO] [stderr] Downloaded hcl-rs v0.14.6 [INFO] [stderr] Downloaded crossterm v0.25.0 [INFO] [stderr] Downloaded clap_builder v4.4.6 [INFO] [stderr] Downloaded aho-corasick v1.1.1 [INFO] [stderr] Downloaded rnix v0.10.2 [INFO] [stderr] Downloaded rnix v0.11.0 [INFO] [stderr] Downloaded unicode-segmentation v1.11.0 [INFO] [stderr] Downloaded regex v1.9.6 [INFO] [stderr] Downloaded gimli v0.28.0 [INFO] [stderr] Downloaded object v0.32.1 [INFO] [stderr] Downloaded regex-syntax v0.7.5 [INFO] [stderr] Downloaded nix-editor v0.3.0 [INFO] [stderr] Downloaded backtrace v0.3.69 [INFO] [stderr] Downloaded winnow v0.5.16 [INFO] [stderr] Downloaded bstr v1.6.2 [INFO] [stderr] Downloaded inquire v0.6.2 [INFO] [stderr] Downloaded cc v1.0.83 [INFO] [stderr] Downloaded hashbrown v0.14.1 [INFO] [stderr] Downloaded miniz_oxide v0.7.1 [INFO] [stderr] Downloaded socket2 v0.5.4 [INFO] [stderr] Downloaded walkdir v2.4.0 [INFO] [stderr] Downloaded ignore v0.4.20 [INFO] [stderr] Downloaded ucd-trie v0.1.6 [INFO] [stderr] Downloaded pest_derive v2.7.4 [INFO] [stderr] Downloaded regex-automata v0.3.9 [INFO] [stderr] Downloaded addr2line v0.21.0 [INFO] [stderr] Downloaded rustc-demangle v0.1.23 [INFO] [stderr] Downloaded tokio v1.32.0 [INFO] [stderr] Downloaded libc v0.2.149 [INFO] [stderr] Downloaded smallvec v1.11.1 [INFO] [stderr] Downloaded parking_lot_core v0.9.8 [INFO] [stderr] Downloaded anstyle-parse v0.2.2 [INFO] [stderr] Downloaded clap_derive v4.4.2 [INFO] [stderr] Downloaded globset v0.4.13 [INFO] [stderr] Downloaded nixpkgs-fmt v1.3.0 [INFO] [stderr] Downloaded kstring v2.0.0 [INFO] [stderr] Downloaded vecmap-rs v0.1.12 [INFO] [stderr] Downloaded thiserror-impl v1.0.49 [INFO] [stderr] Downloaded thiserror v1.0.49 [INFO] [stderr] Downloaded owo-colors v3.5.0 [INFO] [stderr] Downloaded lock_api v0.4.10 [INFO] [stderr] Downloaded indexmap v2.2.3 [INFO] [stderr] Downloaded envhub-ext v0.1.1 [INFO] [stderr] Downloaded anstream v0.6.4 [INFO] [stderr] Downloaded clap_lex v0.5.1 [INFO] [stderr] Downloaded rowan v0.12.6 [INFO] [stderr] Downloaded text-size v1.1.1 [INFO] [stderr] Downloaded rowan v0.15.13 [INFO] [stderr] Downloaded envhub-hm v0.2.4 [INFO] [stderr] Downloaded envhub-providers v0.2.0 [INFO] [stderr] Downloaded anyhow v1.0.75 [INFO] [stderr] Downloaded envhub-stow v0.1.0 [INFO] [stderr] Downloaded envhub-types v0.2.2 [INFO] [stderr] Downloaded hcl-primitives v0.1.1 [INFO] [stderr] Downloaded maybe-uninit v2.0.0 [INFO] [stderr] Downloaded cbitset v0.2.0 [INFO] [stderr] Downloaded countme v2.0.4 [INFO] [stderr] Downloaded countme v3.0.1 [INFO] [stderr] Downloaded envhub-pkgs v0.1.4 [INFO] [stderr] Downloaded dyn-clone v1.0.16 [INFO] [stderr] Downloaded smol_str v0.1.24 [INFO] [stderr] Downloaded pest_generator v2.7.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1fc010c871f62a0a5e6b378754d5df494d8ca42239b18c11883617e88aa2255d [INFO] running `Command { std: "docker" "start" "-a" "1fc010c871f62a0a5e6b378754d5df494d8ca42239b18c11883617e88aa2255d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1fc010c871f62a0a5e6b378754d5df494d8ca42239b18c11883617e88aa2255d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fc010c871f62a0a5e6b378754d5df494d8ca42239b18c11883617e88aa2255d", kill_on_drop: false }` [INFO] [stdout] 1fc010c871f62a0a5e6b378754d5df494d8ca42239b18c11883617e88aa2255d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7af812fabada127627cc5e457f83255682186502a5f9cc602ee44e6d23feaa3 [INFO] running `Command { std: "docker" "start" "-a" "d7af812fabada127627cc5e457f83255682186502a5f9cc602ee44e6d23feaa3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.68 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Checking hashbrown v0.14.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking bstr v1.6.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking countme v2.0.4 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking winnow v0.5.16 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking os_str_bytes v6.5.1 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking envhub-pkgs v0.1.4 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking dyn-clone v1.0.16 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking newline-converter v0.2.2 [INFO] [stderr] Checking envhub-providers v0.2.0 [INFO] [stderr] Checking envhub-stow v0.1.0 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking cbitset v0.2.0 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Checking globset v0.4.13 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking ignore v0.4.20 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Compiling pest v2.7.4 [INFO] [stderr] Checking inquire v0.6.2 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Compiling pest_meta v2.7.4 [INFO] [stderr] Compiling pest_generator v2.7.4 [INFO] [stderr] Compiling pest_derive v2.7.4 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking hcl-primitives v0.1.1 [INFO] [stderr] Checking smol_str v0.1.24 [INFO] [stderr] Checking vecmap-rs v0.1.12 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking rowan v0.12.6 [INFO] [stderr] Checking rowan v0.15.13 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking rnix v0.10.2 [INFO] [stderr] Checking rnix v0.11.0 [INFO] [stderr] Checking hcl-rs v0.14.6 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking nixpkgs-fmt v1.3.0 [INFO] [stderr] Checking nix-editor v0.3.0 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking envhub-types v0.2.2 [INFO] [stderr] Checking envhub-ext v0.1.1 [INFO] [stderr] Checking envhub-hm v0.2.4 [INFO] [stderr] Checking envhub v0.2.18 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file.source` after checking its variant with `is_some` [INFO] [stdout] --> src/cmd/file.rs:34:38 [INFO] [stdout] | [INFO] [stdout] 33 | if file.source.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = file.source` [INFO] [stdout] 34 | println!(" source: {}", file.source.unwrap().cyan()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file.content` after checking its variant with `is_some` [INFO] [stdout] --> src/cmd/file.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 36 | if file.content.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = file.content` [INFO] [stdout] 37 | println!(" content: \n{}\n", file.content.unwrap().cyan()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd/package.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/unuse.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | unstow(&home_manager_dir, &target, &package)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `home_manager_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/unuse.rs:28:44 [INFO] [stdout] | [INFO] [stdout] 28 | unstow(&home_manager_dir, &target, &package)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file.source` after checking its variant with `is_some` [INFO] [stdout] --> src/cmd/file.rs:34:38 [INFO] [stdout] | [INFO] [stdout] 33 | if file.source.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = file.source` [INFO] [stdout] 34 | println!(" source: {}", file.source.unwrap().cyan()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file.content` after checking its variant with `is_some` [INFO] [stdout] --> src/cmd/file.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 36 | if file.content.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = file.content` [INFO] [stdout] 37 | println!(" content: \n{}\n", file.content.unwrap().cyan()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/use.rs:64:42 [INFO] [stdout] | [INFO] [stdout] 64 | stow(&home_manager_dir, &target, &package)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd/package.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/helpers.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | let name = name.split("@").nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `name.split("@").next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/unuse.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | unstow(&home_manager_dir, &target, &package)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `home_manager_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/unuse.rs:28:44 [INFO] [stdout] | [INFO] [stdout] 28 | unstow(&home_manager_dir, &target, &package)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return "nix"; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return "nix"; [INFO] [stdout] 96 + "nix" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 106 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 128 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:132:8 [INFO] [stdout] | [INFO] [stdout] 132 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/use.rs:64:42 [INFO] [stdout] | [INFO] [stdout] 64 | stow(&home_manager_dir, &target, &package)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.package_manager` after checking its variant with `is_some` [INFO] [stdout] --> src/helpers.rs:180:49 [INFO] [stdout] | [INFO] [stdout] 174 | if config.package_manager.is_some() && config.package_manager != Some("nix".into()) { [INFO] [stdout] | -------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 180 | let pm: Box = match config.package_manager.as_ref().unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/helpers.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | let name = name.split("@").nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `name.split("@").next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return "nix"; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return "nix"; [INFO] [stdout] 96 + "nix" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 106 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 128 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:132:8 [INFO] [stdout] | [INFO] [stdout] 132 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.package_manager` after checking its variant with `is_some` [INFO] [stdout] --> src/helpers.rs:180:49 [INFO] [stdout] | [INFO] [stdout] 174 | if config.package_manager.is_some() && config.package_manager != Some("nix".into()) { [INFO] [stdout] | -------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 180 | let pm: Box = match config.package_manager.as_ref().unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.38s [INFO] running `Command { std: "docker" "inspect" "d7af812fabada127627cc5e457f83255682186502a5f9cc602ee44e6d23feaa3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7af812fabada127627cc5e457f83255682186502a5f9cc602ee44e6d23feaa3", kill_on_drop: false }` [INFO] [stdout] d7af812fabada127627cc5e457f83255682186502a5f9cc602ee44e6d23feaa3