[INFO] fetching crate entropic 0.1.1... [INFO] linting entropic-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate entropic 0.1.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate entropic 0.1.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate entropic 0.1.1 [INFO] tweaked toml for crates.io crate entropic 0.1.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate entropic 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate entropic 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded entropic-derive v0.1.0 [INFO] [stderr] Downloaded syn v2.0.60 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43b2ffaa6eb5c16ca52bb24843f0feb587419fa5db4e30d1554911b763aa47a6 [INFO] running `Command { std: "docker" "start" "-a" "43b2ffaa6eb5c16ca52bb24843f0feb587419fa5db4e30d1554911b763aa47a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43b2ffaa6eb5c16ca52bb24843f0feb587419fa5db4e30d1554911b763aa47a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43b2ffaa6eb5c16ca52bb24843f0feb587419fa5db4e30d1554911b763aa47a6", kill_on_drop: false }` [INFO] [stdout] 43b2ffaa6eb5c16ca52bb24843f0feb587419fa5db4e30d1554911b763aa47a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 40ebbc109aa941c06ae108d765d9255e4bd38bb542f8f6586387df91fd7fab23 [INFO] running `Command { std: "docker" "start" "-a" "40ebbc109aa941c06ae108d765d9255e4bd38bb542f8f6586387df91fd7fab23", kill_on_drop: false }` [INFO] [stderr] Checking entropic v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/scheme.rs:201:55 [INFO] [stdout] | [INFO] [stdout] 201 | let mut len = self.put_unbounded_len(entropy, value.as_bytes().len())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/scheme.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | len += value.as_bytes().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> src/entropic.rs:174:29 [INFO] [stdout] | [INFO] [stdout] 174 | T: ToOwned + Entropic + ?Sized, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> src/entropic.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | T: ToOwned + Entropic + ?Sized, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = note: ...because `Entropic` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] = note: `#[warn(clippy::needless_maybe_sized)]` on by default [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 174 - T: ToOwned + Entropic + ?Sized, [INFO] [stdout] 174 + T: ToOwned + Entropic, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/entropic.rs:467:9 [INFO] [stdout] | [INFO] [stdout] 467 | Ok(self.0.to_entropy_sink(sink)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 467 - Ok(self.0.to_entropy_sink(sink)?) [INFO] [stdout] 467 + self.0.to_entropy_sink(sink) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/scheme.rs:201:55 [INFO] [stdout] | [INFO] [stdout] 201 | let mut len = self.put_unbounded_len(entropy, value.as_bytes().len())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/scheme.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | len += value.as_bytes().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> src/entropic.rs:174:29 [INFO] [stdout] | [INFO] [stdout] 174 | T: ToOwned + Entropic + ?Sized, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> src/entropic.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | T: ToOwned + Entropic + ?Sized, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = note: ...because `Entropic` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] = note: `#[warn(clippy::needless_maybe_sized)]` on by default [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 174 - T: ToOwned + Entropic + ?Sized, [INFO] [stdout] 174 + T: ToOwned + Entropic, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/entropic.rs:467:9 [INFO] [stdout] | [INFO] [stdout] 467 | Ok(self.0.to_entropy_sink(sink)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 467 - Ok(self.0.to_entropy_sink(sink)?) [INFO] [stdout] 467 + self.0.to_entropy_sink(sink) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/default.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | assert!(!sink.put_byte(0x00).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sink.put_byte(0x00).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/default.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | assert!(!s.get_byte().is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `s.get_byte().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `Command { std: "docker" "inspect" "40ebbc109aa941c06ae108d765d9255e4bd38bb542f8f6586387df91fd7fab23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40ebbc109aa941c06ae108d765d9255e4bd38bb542f8f6586387df91fd7fab23", kill_on_drop: false }` [INFO] [stdout] 40ebbc109aa941c06ae108d765d9255e4bd38bb542f8f6586387df91fd7fab23