[INFO] fetching crate enteum 0.1.1... [INFO] linting enteum-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate enteum 0.1.1 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate enteum 0.1.1 [INFO] finished tweaking crates.io crate enteum 0.1.1 [INFO] tweaked toml for crates.io crate enteum 0.1.1 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate enteum 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate enteum 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64d2303e1bbd8db603a7ba47518c4b17c0dbd7152df24ba969b6fcfe015527d5 [INFO] running `Command { std: "docker" "start" "-a" "64d2303e1bbd8db603a7ba47518c4b17c0dbd7152df24ba969b6fcfe015527d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64d2303e1bbd8db603a7ba47518c4b17c0dbd7152df24ba969b6fcfe015527d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64d2303e1bbd8db603a7ba47518c4b17c0dbd7152df24ba969b6fcfe015527d5", kill_on_drop: false }` [INFO] [stdout] 64d2303e1bbd8db603a7ba47518c4b17c0dbd7152df24ba969b6fcfe015527d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0c18e1ea999dbfc7349fefb8c0a6ffb078e743560025d441462c075463603c8 [INFO] running `Command { std: "docker" "start" "-a" "b0c18e1ea999dbfc7349fefb8c0a6ffb078e743560025d441462c075463603c8", kill_on_drop: false }` [INFO] [stderr] Checking enteum v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/data_structures/queue.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | max: max, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `max` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/data_structures/dense_array.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `set` and `unset` [INFO] [stdout] --> src/enteum/entity_manager.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::data_structures::bit_set::{set, unset, reset}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::enteum::entity_manager::EntityManager` [INFO] [stdout] --> src/enteum/component_manager.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::enteum::entity_manager::EntityManager; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::sleep` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::thread::sleep; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `data` is assigned to, but never used [INFO] [stdout] --> src/data_structures/bit_set.rs:1:14 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn reset(mut data: u16) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_data` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | data = 0b0000000000000000 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `data` is assigned to, but never used [INFO] [stdout] --> src/data_structures/bit_set.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn set(mut data: u16, bit: u8) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_data` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | 1 => data |= 0b0000000000000010, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | 2 => data |= 0b0000000000000100, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | 3 => data |= 0b0000000000001000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | 4 => data |= 0b0000000000010000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | 5 => data |= 0b0000000000100000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | 6 => data |= 0b0000000001000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | 7 => data |= 0b0000000010000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | 8 => data |= 0b0000000100000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | 9 => data |= 0b0000001000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | 10 => data |= 0b0000010000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | 11 => data |= 0b0000100000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 18 | 12 => data |= 0b0001000000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 19 | 13 => data |= 0b0010000000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | 14 => data |= 0b0100000000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 21 | 15 => data |= 0b1000000000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `data` is assigned to, but never used [INFO] [stdout] --> src/data_structures/bit_set.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn unset(mut data: u16, bit: u8) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_data` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | 1 => data &= 0b1111111111111101, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | 2 => data &= 0b1111111111111011, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | 3 => data &= 0b1111111111110111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | 4 => data &= 0b1111111111101111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:32:14 [INFO] [stdout] | [INFO] [stdout] 32 | 5 => data &= 0b1111111111011111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 33 | 6 => data &= 0b1111111110111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | 7 => data &= 0b1111111101111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 35 | 8 => data &= 0b1111111011111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | 9 => data &= 0b1111110111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | 10 => data &= 0b1111101111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 38 | 11 => data &= 0b1111011111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | 12 => data &= 0b1110111111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | 13 => data &= 0b1101111111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 41 | 14 => data &= 0b1011111111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:42:15 [INFO] [stdout] | [INFO] [stdout] 42 | 15 => data &= 0b0111111111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/enteum/component_manager.rs:13:30 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(component: T, id: u8) -> Self { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `QueueU16` [INFO] [stdout] --> src/data_structures/queue.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / pub fn new() -> Self { [INFO] [stdout] 47 | | Self { [INFO] [stdout] 48 | | data: Self::init(), [INFO] [stdout] 49 | | queue: Queue::new(MAX_U16) [INFO] [stdout] 50 | | } [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 45 + impl Default for QueueU16 { [INFO] [stdout] 46 + fn default() -> Self { [INFO] [stdout] 47 + Self::new() [INFO] [stdout] 48 + } [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `arr` [INFO] [stdout] --> src/data_structures/queue.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 56 | for i in 0..MAX_U16 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 56 - for i in 0..MAX_U16 { [INFO] [stdout] 56 + for (i, ) in arr.iter_mut().enumerate().take(MAX_U16) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/data_structures/queue.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | max: max, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `max` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/data_structures/dense_array.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `set` and `unset` [INFO] [stdout] --> src/enteum/entity_manager.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::data_structures::bit_set::{set, unset, reset}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::enteum::entity_manager::EntityManager` [INFO] [stdout] --> src/enteum/component_manager.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::enteum::entity_manager::EntityManager; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::sleep` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::thread::sleep; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data_structures/dense_array.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | if !(self.last_index == self.max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.last_index != self.max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data_structures/dense_array.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return data; [INFO] [stdout] 44 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data_structures/dense_array.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return data; [INFO] [stdout] 52 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EntityManager` [INFO] [stdout] --> src/enteum/entity_manager.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | available_entities: QueueU16::new(), [INFO] [stdout] 17 | | signatures: [1; MAX_U16] [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for EntityManager { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SystemManager` [INFO] [stdout] --> src/enteum/system_manager.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Self { [INFO] [stdout] 13 | | data: DenseArray::new([0; MAX_U16]) [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for SystemManager { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `data` is assigned to, but never used [INFO] [stdout] --> src/data_structures/bit_set.rs:1:14 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn reset(mut data: u16) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_data` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | data = 0b0000000000000000 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `data` is assigned to, but never used [INFO] [stdout] --> src/data_structures/bit_set.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn set(mut data: u16, bit: u8) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_data` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | 1 => data |= 0b0000000000000010, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | 2 => data |= 0b0000000000000100, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | 3 => data |= 0b0000000000001000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | 4 => data |= 0b0000000000010000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | 5 => data |= 0b0000000000100000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | 6 => data |= 0b0000000001000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | 7 => data |= 0b0000000010000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | 8 => data |= 0b0000000100000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | 9 => data |= 0b0000001000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | 10 => data |= 0b0000010000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | 11 => data |= 0b0000100000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 18 | 12 => data |= 0b0001000000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 19 | 13 => data |= 0b0010000000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | 14 => data |= 0b0100000000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 21 | 15 => data |= 0b1000000000000000, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `data` is assigned to, but never used [INFO] [stdout] --> src/data_structures/bit_set.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn unset(mut data: u16, bit: u8) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_data` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | 1 => data &= 0b1111111111111101, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | 2 => data &= 0b1111111111111011, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | 3 => data &= 0b1111111111110111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | 4 => data &= 0b1111111111101111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:32:14 [INFO] [stdout] | [INFO] [stdout] 32 | 5 => data &= 0b1111111111011111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 33 | 6 => data &= 0b1111111110111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | 7 => data &= 0b1111111101111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 35 | 8 => data &= 0b1111111011111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | 9 => data &= 0b1111110111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | 10 => data &= 0b1111101111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 38 | 11 => data &= 0b1111011111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | 12 => data &= 0b1110111111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | 13 => data &= 0b1101111111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 41 | 14 => data &= 0b1011111111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `data` is never read [INFO] [stdout] --> src/data_structures/bit_set.rs:42:15 [INFO] [stdout] | [INFO] [stdout] 42 | 15 => data &= 0b0111111111111111, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/enteum/component_manager.rs:13:30 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(component: T, id: u8) -> Self { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `QueueU16` [INFO] [stdout] --> src/data_structures/queue.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / pub fn new() -> Self { [INFO] [stdout] 47 | | Self { [INFO] [stdout] 48 | | data: Self::init(), [INFO] [stdout] 49 | | queue: Queue::new(MAX_U16) [INFO] [stdout] 50 | | } [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 45 + impl Default for QueueU16 { [INFO] [stdout] 46 + fn default() -> Self { [INFO] [stdout] 47 + Self::new() [INFO] [stdout] 48 + } [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `arr` [INFO] [stdout] --> src/data_structures/queue.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 56 | for i in 0..MAX_U16 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 56 - for i in 0..MAX_U16 { [INFO] [stdout] 56 + for (i, ) in arr.iter_mut().enumerate().take(MAX_U16) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data_structures/dense_array.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | if !(self.last_index == self.max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.last_index != self.max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data_structures/dense_array.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return data; [INFO] [stdout] 44 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data_structures/dense_array.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return data; [INFO] [stdout] 52 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EntityManager` [INFO] [stdout] --> src/enteum/entity_manager.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | available_entities: QueueU16::new(), [INFO] [stdout] 17 | | signatures: [1; MAX_U16] [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for EntityManager { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SystemManager` [INFO] [stdout] --> src/enteum/system_manager.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Self { [INFO] [stdout] 13 | | data: DenseArray::new([0; MAX_U16]) [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for SystemManager { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s [INFO] running `Command { std: "docker" "inspect" "b0c18e1ea999dbfc7349fefb8c0a6ffb078e743560025d441462c075463603c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0c18e1ea999dbfc7349fefb8c0a6ffb078e743560025d441462c075463603c8", kill_on_drop: false }` [INFO] [stdout] b0c18e1ea999dbfc7349fefb8c0a6ffb078e743560025d441462c075463603c8