[INFO] fetching crate enprot 0.3.1... [INFO] linting enprot-0.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate enprot 0.3.1 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate enprot 0.3.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate enprot 0.3.1 [INFO] tweaked toml for crates.io crate enprot 0.3.1 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate enprot 0.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate enprot 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rpassword v2.1.0 [INFO] [stderr] Downloaded normalize-line-endings v0.2.2 [INFO] [stderr] Downloaded predicates v1.0.2 [INFO] [stderr] Downloaded predicates-core v1.0.0 [INFO] [stderr] Downloaded memchr v2.3.0 [INFO] [stderr] Downloaded treeline v0.1.0 [INFO] [stderr] Downloaded cpu-time v1.0.0 [INFO] [stderr] Downloaded aead v0.2.0 [INFO] [stderr] Downloaded phc v0.2.0 [INFO] [stderr] Downloaded zeroize v1.1.0 [INFO] [stderr] Downloaded block-cipher-trait v0.6.2 [INFO] [stderr] Downloaded escargot v0.4.0 [INFO] [stderr] Downloaded aes-gcm-siv v0.3.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.8 [INFO] [stderr] Downloaded ryu v1.0.2 [INFO] [stderr] Downloaded aesni v0.6.0 [INFO] [stderr] Downloaded aho-corasick v0.7.8 [INFO] [stderr] Downloaded serde_json v1.0.46 [INFO] [stderr] Downloaded serde_derive v1.0.104 [INFO] [stderr] Downloaded aes-soft v0.3.3 [INFO] [stderr] Downloaded aes v0.3.2 [INFO] [stderr] Downloaded regex-syntax v0.6.14 [INFO] [stderr] Downloaded serde v1.0.104 [INFO] [stderr] Downloaded syn v1.0.14 [INFO] [stderr] Downloaded regex v1.3.4 [INFO] [stderr] Downloaded botan v0.6.0 [INFO] [stderr] Downloaded base64 v0.9.3 [INFO] [stderr] Downloaded assert_cmd v0.11.1 [INFO] [stderr] Downloaded botan-sys v0.6.0 [INFO] [stderr] Downloaded num-rational v0.2.3 [INFO] [stderr] Downloaded byteorder v1.3.2 [INFO] [stderr] Downloaded safemem v0.3.3 [INFO] [stderr] Downloaded libc v0.2.66 [INFO] [stderr] Downloaded hermit-abi v0.1.6 [INFO] [stderr] Downloaded siphasher v0.3.1 [INFO] [stderr] Downloaded universal-hash v0.3.0 [INFO] [stderr] Downloaded polyval v0.3.3 [INFO] [stderr] Downloaded subtle v2.2.2 [INFO] [stderr] Downloaded itoa v0.4.5 [INFO] [stderr] Downloaded predicates-tree v1.0.0 [INFO] [stderr] Downloaded cty v0.2.1 [INFO] [stderr] Downloaded hex v0.3.2 [INFO] [stderr] Downloaded num-iter v0.1.40 [INFO] [stderr] Downloaded proc-macro-hack v0.5.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 720b3f9f1040d48bcbd52de3ca1dc46fe82f2c49fec02895b8d3d13816b1f7d7 [INFO] running `Command { std: "docker" "start" "-a" "720b3f9f1040d48bcbd52de3ca1dc46fe82f2c49fec02895b8d3d13816b1f7d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "720b3f9f1040d48bcbd52de3ca1dc46fe82f2c49fec02895b8d3d13816b1f7d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "720b3f9f1040d48bcbd52de3ca1dc46fe82f2c49fec02895b8d3d13816b1f7d7", kill_on_drop: false }` [INFO] [stdout] 720b3f9f1040d48bcbd52de3ca1dc46fe82f2c49fec02895b8d3d13816b1f7d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a7b53698de05d921ece25b74a798cfba587910e9c7b002f766402f9ad5b6c88 [INFO] running `Command { std: "docker" "start" "-a" "5a7b53698de05d921ece25b74a798cfba587910e9c7b002f766402f9ad5b6c88", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling ppv-lite86 v0.2.6 [INFO] [stderr] Compiling siphasher v0.3.1 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking subtle v2.2.2 [INFO] [stderr] Compiling botan-sys v0.6.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling c2-chacha v0.2.3 [INFO] [stderr] Compiling num-rational v0.2.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking cty v0.2.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking aho-corasick v0.7.8 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking zeroize v1.1.0 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling escargot v0.4.0 [INFO] [stderr] Checking botan v0.6.0 [INFO] [stderr] Checking rpassword v2.1.0 [INFO] [stderr] Checking rand_pcg v0.2.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking phc v0.2.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking cpu-time v1.0.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking float-cmp v0.5.3 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking block-cipher-trait v0.6.2 [INFO] [stderr] Checking universal-hash v0.3.0 [INFO] [stderr] Checking aead v0.2.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking aes-soft v0.3.3 [INFO] [stderr] Checking polyval v0.3.3 [INFO] [stderr] Checking aes v0.3.2 [INFO] [stderr] Checking aes-gcm-siv v0.3.0 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Checking predicates v1.0.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking enprot v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/etree.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | policy: policy, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/etree.rs:321:17 [INFO] [stdout] | [INFO] [stdout] 321 | keyw: keyw, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `keyw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/etree.rs:358:25 [INFO] [stdout] | [INFO] [stdout] 358 | keyw: keyw, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `keyw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `key_len_min` is never used [INFO] [stdout] --> src/cipher.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub trait SymmetricCipher { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 46 | fn key_len_min(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `key_len_min` is never read [INFO] [stdout] --> src/cipher.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 75 | struct BotanCipher { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 78 | key_len_min: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `key_len_min` is never read [INFO] [stdout] --> src/cipher.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 136 | struct AESGCMSIVCipher [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 142 | key_len_min: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/cas.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if let Err(_) = hex::decode(hexhash) { [INFO] [stdout] | -------^^^^^^----------------------- help: try: `if hex::decode(hexhash).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cas.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | path.push(&hexhash); [INFO] [stdout] | ^^^^^^^^ help: change this to: `hexhash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/cipher.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn crypto::CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/crypto.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/crypto.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/crypto.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/crypto.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | &salt, [INFO] [stdout] | ^^^^^ help: change this to: `salt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/etree.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(policy: &Box) -> PBKDFOptions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/etree.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(policy: &Box) -> CipherOptions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/etree.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Ok(()); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `cmd` [INFO] [stdout] --> src/etree.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | for i in 0..cmd.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 159 - for i in 0..cmd.len() { [INFO] [stdout] 159 + for in &cmd { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/etree.rs:212:12 [INFO] [stdout] | [INFO] [stdout] 212 | if field.find(':') == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `field.find(':').is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/etree.rs:290:5 [INFO] [stdout] | [INFO] [stdout] 290 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 290 - return Ok(()); [INFO] [stdout] 290 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/etree.rs:311:16 [INFO] [stdout] | [INFO] [stdout] 311 | if cmd.len() >= 1 && keyw != cmd[0] { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/etree.rs:475:8 [INFO] [stdout] | [INFO] [stdout] 475 | if pstack.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!pstack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:589:43 [INFO] [stdout] | [INFO] [stdout] 589 | let pt = tree_to_blob(&txt, paops); [INFO] [stdout] | ^^^^ help: change this to: `txt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:594:59 [INFO] [stdout] | [INFO] [stdout] 594 | None => (true, prot::get_password(&keyw, true)), [INFO] [stdout] | ^^^^^ help: change this to: `keyw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:633:45 [INFO] [stdout] | [INFO] [stdout] 633 | let blob = tree_to_blob(&txt, paops); [INFO] [stdout] | ^^^^ help: change this to: `txt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:668:40 [INFO] [stdout] | [INFO] [stdout] 668 | } => cas::load(&hexhash, paops)?, [INFO] [stdout] | ^^^^^^^^ help: change this to: `hexhash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:700:77 [INFO] [stdout] | [INFO] [stdout] 700 | let subtree = blob_to_tree(pt, "decrypted".to_string(), &mut paops)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `paops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:736:44 [INFO] [stdout] | [INFO] [stdout] 736 | ... } => cas::load(&hexhash, paops)?, [INFO] [stdout] | ^^^^^^^^ help: change this to: `hexhash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:757:42 [INFO] [stdout] | [INFO] [stdout] 757 | let blob = cas::load(&cas, paops)?; [INFO] [stdout] | ^^^^ help: change this to: `cas` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:784:41 [INFO] [stdout] | [INFO] [stdout] 784 | let tree = parse(Cursor::new(data), &mut paops)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `paops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:790:33 [INFO] [stdout] | [INFO] [stdout] 790 | tree_write(&mut blob, text, &mut paops); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `paops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/pbkdf.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/pbkdf.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/pbkdf.rs:65:11 [INFO] [stdout] | [INFO] [stdout] 65 | salt: &Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 65 - salt: &Vec, [INFO] [stdout] 65 + salt: &[u8], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/pbkdf.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/pbkdf.rs:85:11 [INFO] [stdout] | [INFO] [stdout] 85 | salt: &Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - salt: &Vec, [INFO] [stdout] 85 + salt: &[u8], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/pbkdf.rs:101:66 [INFO] [stdout] | [INFO] [stdout] 101 | fn format_phc(alg: &str, params: &BTreeMap, salt: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 101 - fn format_phc(alg: &str, params: &BTreeMap, salt: &Vec) -> String { [INFO] [stdout] 101 + fn format_phc(alg: &str, params: &BTreeMap, salt: &[u8]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/pbkdf.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/pbkdf.rs:148:17 [INFO] [stdout] | [INFO] [stdout] 148 | &botan_param_order, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `botan_param_order` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/pbkdf.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | &botan_param_order, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `botan_param_order` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/prot.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/prot.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if pbkdf != None { [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `pbkdf.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/prot.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | } else if cipheropts.iv != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `cipheropts.iv.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/prot.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/prot.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | Ok(dec.process(&key, &iv, &[], &ct, policy)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 160 - Ok(dec.process(&key, &iv, &[], &ct, policy)?) [INFO] [stdout] 160 + dec.process(&key, &iv, &[], &ct, policy) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/prot.rs:118:34 [INFO] [stdout] | [INFO] [stdout] 118 | let dec = cipher::decryption(&cipher_alg)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `cipher_alg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `eprintln!` [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | eprintln!(""); [INFO] [stdout] | ^^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:361:13 [INFO] [stdout] | [INFO] [stdout] 361 | assert!(!fips || (fips && policy == "nist")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 361 - assert!(!fips || (fips && policy == "nist")); [INFO] [stdout] 361 + assert!(!(fips && policy != "nist")); [INFO] [stdout] | [INFO] [stdout] 361 - assert!(!fips || (fips && policy == "nist")); [INFO] [stdout] 361 + assert!(!fips || policy == "nist"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:170:51 [INFO] [stdout] | [INFO] [stdout] 170 | if wordpass.len() != 2 || wordpass[0].len() == 0 || wordpass[1].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wordpass[0].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:170:77 [INFO] [stdout] | [INFO] [stdout] 170 | if wordpass.len() != 2 || wordpass[0].len() == 0 || wordpass[1].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wordpass[1].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:241:28 [INFO] [stdout] | [INFO] [stdout] 241 | .validator(&validate_positive::) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `validate_positive::` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:301:25 [INFO] [stdout] | [INFO] [stdout] 301 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return Ok(()); [INFO] [stdout] 301 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `starts_with` method [INFO] [stdout] --> src/lib.rs:345:28 [INFO] [stdout] | [INFO] [stdout] 345 | Ok(str) => str.chars().next() == Some('1'), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `str.starts_with('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_next_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/lib.rs:413:14 [INFO] [stdout] | [INFO] [stdout] 413 | .unwrap_or(clap::Values::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/lib.rs:470:10 [INFO] [stdout] | [INFO] [stdout] 470 | .unwrap_or(clap::Values::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/lib.rs:475:30 [INFO] [stdout] | [INFO] [stdout] 475 | let mut output = prefix.to_string() + &input; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:475:51 [INFO] [stdout] | [INFO] [stdout] 475 | let mut output = prefix.to_string() + &input; [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | enprot::app_main(&mut std::env::args()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::env::args()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_json v1.0.46 [INFO] [stderr] Checking assert_cmd v0.11.1 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/etree.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | policy: policy, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/etree.rs:321:17 [INFO] [stdout] | [INFO] [stdout] 321 | keyw: keyw, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `keyw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/etree.rs:358:25 [INFO] [stdout] | [INFO] [stdout] 358 | keyw: keyw, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `keyw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | enprot::app_main(&mut std::env::args()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::env::args()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/cas.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if let Err(_) = hex::decode(hexhash) { [INFO] [stdout] | -------^^^^^^----------------------- help: try: `if hex::decode(hexhash).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cas.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | path.push(&hexhash); [INFO] [stdout] | ^^^^^^^^ help: change this to: `hexhash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/cipher.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn crypto::CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:254:30 [INFO] [stdout] | [INFO] [stdout] 254 | ct = enc.process(&key, &iv, &[], &pt, &policy).unwrap(); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:254:36 [INFO] [stdout] | [INFO] [stdout] 254 | ct = enc.process(&key, &iv, &[], &pt, &policy).unwrap(); [INFO] [stdout] | ^^^ help: change this to: `iv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:254:46 [INFO] [stdout] | [INFO] [stdout] 254 | ct = enc.process(&key, &iv, &[], &pt, &policy).unwrap(); [INFO] [stdout] | ^^^ help: change this to: `pt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:270:32 [INFO] [stdout] | [INFO] [stdout] 270 | assert_eq!(dec.process(&key, &iv, &[], &ct, &policy).unwrap(), pt); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:270:38 [INFO] [stdout] | [INFO] [stdout] 270 | assert_eq!(dec.process(&key, &iv, &[], &ct, &policy).unwrap(), pt); [INFO] [stdout] | ^^^ help: change this to: `iv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:293:30 [INFO] [stdout] | [INFO] [stdout] 293 | ct = enc.process(&key, &iv, &[], &pt, &policy).unwrap(); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:293:36 [INFO] [stdout] | [INFO] [stdout] 293 | ct = enc.process(&key, &iv, &[], &pt, &policy).unwrap(); [INFO] [stdout] | ^^^ help: change this to: `iv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:293:46 [INFO] [stdout] | [INFO] [stdout] 293 | ct = enc.process(&key, &iv, &[], &pt, &policy).unwrap(); [INFO] [stdout] | ^^^ help: change this to: `pt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:309:32 [INFO] [stdout] | [INFO] [stdout] 309 | assert_eq!(dec.process(&key, &iv, &[], &ct, &policy).unwrap(), pt); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cipher.rs:309:38 [INFO] [stdout] | [INFO] [stdout] 309 | assert_eq!(dec.process(&key, &iv, &[], &ct, &policy).unwrap(), pt); [INFO] [stdout] | ^^^ help: change this to: `iv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/crypto.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/crypto.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/crypto.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/crypto.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | &salt, [INFO] [stdout] | ^^^^^ help: change this to: `salt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/etree.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(policy: &Box) -> PBKDFOptions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/etree.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(policy: &Box) -> CipherOptions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/etree.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Ok(()); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `cmd` [INFO] [stdout] --> src/etree.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | for i in 0..cmd.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 159 - for i in 0..cmd.len() { [INFO] [stdout] 159 + for in &cmd { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/etree.rs:212:12 [INFO] [stdout] | [INFO] [stdout] 212 | if field.find(':') == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `field.find(':').is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/etree.rs:290:5 [INFO] [stdout] | [INFO] [stdout] 290 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 290 - return Ok(()); [INFO] [stdout] 290 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/etree.rs:311:16 [INFO] [stdout] | [INFO] [stdout] 311 | if cmd.len() >= 1 && keyw != cmd[0] { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/etree.rs:475:8 [INFO] [stdout] | [INFO] [stdout] 475 | if pstack.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!pstack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:589:43 [INFO] [stdout] | [INFO] [stdout] 589 | let pt = tree_to_blob(&txt, paops); [INFO] [stdout] | ^^^^ help: change this to: `txt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:594:59 [INFO] [stdout] | [INFO] [stdout] 594 | None => (true, prot::get_password(&keyw, true)), [INFO] [stdout] | ^^^^^ help: change this to: `keyw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:633:45 [INFO] [stdout] | [INFO] [stdout] 633 | let blob = tree_to_blob(&txt, paops); [INFO] [stdout] | ^^^^ help: change this to: `txt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:668:40 [INFO] [stdout] | [INFO] [stdout] 668 | } => cas::load(&hexhash, paops)?, [INFO] [stdout] | ^^^^^^^^ help: change this to: `hexhash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:700:77 [INFO] [stdout] | [INFO] [stdout] 700 | let subtree = blob_to_tree(pt, "decrypted".to_string(), &mut paops)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `paops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:736:44 [INFO] [stdout] | [INFO] [stdout] 736 | ... } => cas::load(&hexhash, paops)?, [INFO] [stdout] | ^^^^^^^^ help: change this to: `hexhash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:757:42 [INFO] [stdout] | [INFO] [stdout] 757 | let blob = cas::load(&cas, paops)?; [INFO] [stdout] | ^^^^ help: change this to: `cas` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:784:41 [INFO] [stdout] | [INFO] [stdout] 784 | let tree = parse(Cursor::new(data), &mut paops)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `paops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/etree.rs:790:33 [INFO] [stdout] | [INFO] [stdout] 790 | tree_write(&mut blob, text, &mut paops); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `paops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/etree.rs:815:39 [INFO] [stdout] | [INFO] [stdout] 815 | BufReader::new(File::open(ept_file.to_string()).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `ept_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/cli/pbkdf.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | &ept.path.to_str().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ept.path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/pbkdf.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/pbkdf.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/pbkdf.rs:65:11 [INFO] [stdout] | [INFO] [stdout] 65 | salt: &Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 65 - salt: &Vec, [INFO] [stdout] 65 + salt: &[u8], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/pbkdf.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/pbkdf.rs:85:11 [INFO] [stdout] | [INFO] [stdout] 85 | salt: &Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - salt: &Vec, [INFO] [stdout] 85 + salt: &[u8], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/pbkdf.rs:101:66 [INFO] [stdout] | [INFO] [stdout] 101 | fn format_phc(alg: &str, params: &BTreeMap, salt: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 101 - fn format_phc(alg: &str, params: &BTreeMap, salt: &Vec) -> String { [INFO] [stdout] 101 + fn format_phc(alg: &str, params: &BTreeMap, salt: &[u8]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/pbkdf.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/pbkdf.rs:148:17 [INFO] [stdout] | [INFO] [stdout] 148 | &botan_param_order, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `botan_param_order` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/pbkdf.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | &botan_param_order, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `botan_param_order` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/prot.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/prot.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if pbkdf != None { [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `pbkdf.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/prot.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | } else if cipheropts.iv != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `cipheropts.iv.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/prot.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | policy: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn CryptoPolicy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/prot.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | Ok(dec.process(&key, &iv, &[], &ct, policy)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 160 - Ok(dec.process(&key, &iv, &[], &ct, policy)?) [INFO] [stdout] 160 + dec.process(&key, &iv, &[], &ct, policy) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/prot.rs:118:34 [INFO] [stdout] | [INFO] [stdout] 118 | let dec = cipher::decryption(&cipher_alg)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `cipher_alg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `eprintln!` [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | eprintln!(""); [INFO] [stdout] | ^^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:361:13 [INFO] [stdout] | [INFO] [stdout] 361 | assert!(!fips || (fips && policy == "nist")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 361 - assert!(!fips || (fips && policy == "nist")); [INFO] [stdout] 361 + assert!(!(fips && policy != "nist")); [INFO] [stdout] | [INFO] [stdout] 361 - assert!(!fips || (fips && policy == "nist")); [INFO] [stdout] 361 + assert!(!fips || policy == "nist"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/tests.rs:25:51 [INFO] [stdout] | [INFO] [stdout] 25 | let source = PathBuf::from(&src_dir).join(&fname); [INFO] [stdout] | ^^^^^^ help: change this to: `fname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cli/encrypt_store.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | for hashval in vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 32 | | "1749eaec9b40e6757ddd29b58002b01cf210e46119a8345421de80c6a3dd672a", [INFO] [stdout] 33 | | "7a8da017c0fe671ba16f4bc55b884444e708849290d8366f19c552c90950b8c2", [INFO] [stdout] 34 | | ] { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 31 ~ for hashval in ["1749eaec9b40e6757ddd29b58002b01cf210e46119a8345421de80c6a3dd672a", [INFO] [stdout] 32 ~ "7a8da017c0fe671ba16f4bc55b884444e708849290d8366f19c552c90950b8c2"] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cli/encrypt_store.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 79 | for hashval in vec!["ab664af9ef8ed0a7a542c4bcc0d2d2bf06973038d83ddbfcdd031eb80a308d5a"] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["ab664af9ef8ed0a7a542c4bcc0d2d2bf06973038d83ddbfcdd031eb80a308d5a"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cli/encrypt_store.rs:124:20 [INFO] [stdout] | [INFO] [stdout] 124 | for hashval in vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 125 | | "7a8da017c0fe671ba16f4bc55b884444e708849290d8366f19c552c90950b8c2", [INFO] [stdout] 126 | | "ab664af9ef8ed0a7a542c4bcc0d2d2bf06973038d83ddbfcdd031eb80a308d5a", [INFO] [stdout] 127 | | ] { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 124 ~ for hashval in ["7a8da017c0fe671ba16f4bc55b884444e708849290d8366f19c552c90950b8c2", [INFO] [stdout] 125 ~ "ab664af9ef8ed0a7a542c4bcc0d2d2bf06973038d83ddbfcdd031eb80a308d5a"] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cli/encrypt_store.rs:172:20 [INFO] [stdout] | [INFO] [stdout] 172 | for hashval in vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 173 | | "1749eaec9b40e6757ddd29b58002b01cf210e46119a8345421de80c6a3dd672a", [INFO] [stdout] 174 | | "7a8da017c0fe671ba16f4bc55b884444e708849290d8366f19c552c90950b8c2", [INFO] [stdout] 175 | | ] { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 172 ~ for hashval in ["1749eaec9b40e6757ddd29b58002b01cf210e46119a8345421de80c6a3dd672a", [INFO] [stdout] 173 ~ "7a8da017c0fe671ba16f4bc55b884444e708849290d8366f19c552c90950b8c2"] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cli/encrypt_store.rs:198:20 [INFO] [stdout] | [INFO] [stdout] 198 | for hashval in vec!["86117980a54565a74cc5195865827aab44cfafc138e723e3a409631384d74ee2"] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["86117980a54565a74cc5195865827aab44cfafc138e723e3a409631384d74ee2"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cli/encrypt_store.rs:255:20 [INFO] [stdout] | [INFO] [stdout] 255 | for hashval in vec!["ab664af9ef8ed0a7a542c4bcc0d2d2bf06973038d83ddbfcdd031eb80a308d5a"] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["ab664af9ef8ed0a7a542c4bcc0d2d2bf06973038d83ddbfcdd031eb80a308d5a"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cli/encrypt_store.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 278 | for hashval in vec!["7a8da017c0fe671ba16f4bc55b884444e708849290d8366f19c552c90950b8c2"] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["7a8da017c0fe671ba16f4bc55b884444e708849290d8366f19c552c90950b8c2"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cli/encrypt_store.rs:338:20 [INFO] [stdout] | [INFO] [stdout] 338 | for hashval in vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 339 | | "03596e1743f8d7e969979d5e4f9f8bf41bca02c723f84a2f12193b2196077805", [INFO] [stdout] 340 | | "b30ccd443bae74afc464822857fad6974f0cbb12197368494cc311441c74ea20", [INFO] [stdout] 341 | | ] { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 338 ~ for hashval in ["03596e1743f8d7e969979d5e4f9f8bf41bca02c723f84a2f12193b2196077805", [INFO] [stdout] 339 ~ "b30ccd443bae74afc464822857fad6974f0cbb12197368494cc311441c74ea20"] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:170:51 [INFO] [stdout] | [INFO] [stdout] 170 | if wordpass.len() != 2 || wordpass[0].len() == 0 || wordpass[1].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wordpass[0].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:170:77 [INFO] [stdout] | [INFO] [stdout] 170 | if wordpass.len() != 2 || wordpass[0].len() == 0 || wordpass[1].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wordpass[1].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:241:28 [INFO] [stdout] | [INFO] [stdout] 241 | .validator(&validate_positive::) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `validate_positive::` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:301:25 [INFO] [stdout] | [INFO] [stdout] 301 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return Ok(()); [INFO] [stdout] 301 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `starts_with` method [INFO] [stdout] --> src/lib.rs:345:28 [INFO] [stdout] | [INFO] [stdout] 345 | Ok(str) => str.chars().next() == Some('1'), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `str.starts_with('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_next_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/lib.rs:413:14 [INFO] [stdout] | [INFO] [stdout] 413 | .unwrap_or(clap::Values::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/lib.rs:470:10 [INFO] [stdout] | [INFO] [stdout] 470 | .unwrap_or(clap::Values::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/lib.rs:475:30 [INFO] [stdout] | [INFO] [stdout] 475 | let mut output = prefix.to_string() + &input; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:475:51 [INFO] [stdout] | [INFO] [stdout] 475 | let mut output = prefix.to_string() + &input; [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.26s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.2.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "5a7b53698de05d921ece25b74a798cfba587910e9c7b002f766402f9ad5b6c88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a7b53698de05d921ece25b74a798cfba587910e9c7b002f766402f9ad5b6c88", kill_on_drop: false }` [INFO] [stdout] 5a7b53698de05d921ece25b74a798cfba587910e9c7b002f766402f9ad5b6c88