[INFO] fetching crate emojicon 0.5.0... [INFO] linting emojicon-0.5.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate emojicon 0.5.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate emojicon 0.5.0 [INFO] finished tweaking crates.io crate emojicon 0.5.0 [INFO] tweaked toml for crates.io crate emojicon 0.5.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate emojicon 0.5.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate emojicon 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9703c4798b1fbf1865336977065b2a654835f66369ea349d5aa334efc8afec7b [INFO] running `Command { std: "docker" "start" "-a" "9703c4798b1fbf1865336977065b2a654835f66369ea349d5aa334efc8afec7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9703c4798b1fbf1865336977065b2a654835f66369ea349d5aa334efc8afec7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9703c4798b1fbf1865336977065b2a654835f66369ea349d5aa334efc8afec7b", kill_on_drop: false }` [INFO] [stdout] 9703c4798b1fbf1865336977065b2a654835f66369ea349d5aa334efc8afec7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1842aee0fab05187e62c01d88a586f6d0a883fc06c436644ac588793229fceb9 [INFO] running `Command { std: "docker" "start" "-a" "1842aee0fab05187e62c01d88a586f6d0a883fc06c436644ac588793229fceb9", kill_on_drop: false }` [INFO] [stderr] Checking emojicon v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Emojicon` [INFO] [stdout] --> src/lib.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / pub fn new() -> Self { [INFO] [stdout] 62 | | let emojis = if cfg!(feature = "custom") { [INFO] [stdout] 63 | | emoji::emojis() [INFO] [stdout] 64 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 59 + impl Default for Emojicon { [INFO] [stdout] 60 + fn default() -> Self { [INFO] [stdout] 61 + Self::new() [INFO] [stdout] 62 + } [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | self.emoticons.get(emoticon).map(|i| *i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.emoticons.get(emoticon).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:99:39 [INFO] [stdout] | [INFO] [stdout] 99 | self.emojis.get(name).map(|v| v.iter().map(|s| *s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `v.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BengaliEmoji` [INFO] [stdout] --> src/lib.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / pub fn new() -> Self { [INFO] [stdout] 119 | | Self { emojis: bn_emojis::emojis() } [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 116 + impl Default for BengaliEmoji { [INFO] [stdout] 117 + fn default() -> Self { [INFO] [stdout] 118 + Self::new() [INFO] [stdout] 119 + } [INFO] [stdout] 120 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:132:39 [INFO] [stdout] | [INFO] [stdout] 132 | self.emojis.get(name).map(|v| v.iter().map(|s| *s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `v.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | assert!(!emoji.get_by_name("none").is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `emoji.get_by_name("none").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Emojicon` [INFO] [stdout] --> src/lib.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / pub fn new() -> Self { [INFO] [stdout] 62 | | let emojis = if cfg!(feature = "custom") { [INFO] [stdout] 63 | | emoji::emojis() [INFO] [stdout] 64 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 59 + impl Default for Emojicon { [INFO] [stdout] 60 + fn default() -> Self { [INFO] [stdout] 61 + Self::new() [INFO] [stdout] 62 + } [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | self.emoticons.get(emoticon).map(|i| *i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.emoticons.get(emoticon).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:99:39 [INFO] [stdout] | [INFO] [stdout] 99 | self.emojis.get(name).map(|v| v.iter().map(|s| *s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `v.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BengaliEmoji` [INFO] [stdout] --> src/lib.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / pub fn new() -> Self { [INFO] [stdout] 119 | | Self { emojis: bn_emojis::emojis() } [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 116 + impl Default for BengaliEmoji { [INFO] [stdout] 117 + fn default() -> Self { [INFO] [stdout] 118 + Self::new() [INFO] [stdout] 119 + } [INFO] [stdout] 120 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:132:39 [INFO] [stdout] | [INFO] [stdout] 132 | self.emojis.get(name).map(|v| v.iter().map(|s| *s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `v.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.20s [INFO] running `Command { std: "docker" "inspect" "1842aee0fab05187e62c01d88a586f6d0a883fc06c436644ac588793229fceb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1842aee0fab05187e62c01d88a586f6d0a883fc06c436644ac588793229fceb9", kill_on_drop: false }` [INFO] [stdout] 1842aee0fab05187e62c01d88a586f6d0a883fc06c436644ac588793229fceb9