[INFO] fetching crate embedded-drivers 0.0.2...
[INFO] linting embedded-drivers-0.0.2 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate embedded-drivers 0.0.2 into /workspace/builds/worker-6-tc1/source
[INFO] started tweaking crates.io crate embedded-drivers 0.0.2
[INFO] finished tweaking crates.io crate embedded-drivers 0.0.2
[INFO] tweaked toml for crates.io crate embedded-drivers 0.0.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate embedded-drivers 0.0.2 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 20 packages to latest compatible versions
[INFO] [stderr]       Adding defmt v0.3.100 (available: v1.0.1)
[INFO] [stderr]       Adding embedded-hal v0.2.7 (available: v1.0.0)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3499d6b774e2545ab3f7b4f0ff30d690281d8fe9c00e6d2a27bdd2a1f058caac
[INFO] running `Command { std: "docker" "start" "-a" "3499d6b774e2545ab3f7b4f0ff30d690281d8fe9c00e6d2a27bdd2a1f058caac", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3499d6b774e2545ab3f7b4f0ff30d690281d8fe9c00e6d2a27bdd2a1f058caac", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3499d6b774e2545ab3f7b4f0ff30d690281d8fe9c00e6d2a27bdd2a1f058caac", kill_on_drop: false }`
[INFO] [stdout] 3499d6b774e2545ab3f7b4f0ff30d690281d8fe9c00e6d2a27bdd2a1f058caac
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 5aaca6699e2e967dfbd12118d19004a145bd6a7aef5d5af1913aaf84a161db02
[INFO] running `Command { std: "docker" "start" "-a" "5aaca6699e2e967dfbd12118d19004a145bd6a7aef5d5af1913aaf84a161db02", kill_on_drop: false }`
[INFO] [stderr]    Compiling libm v0.2.16
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]     Checking nb v1.1.0
[INFO] [stderr]     Checking nb v0.1.3
[INFO] [stderr]     Checking embedded-hal v0.2.7
[INFO] [stderr]     Checking embedded-drivers v0.0.2 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unexpected `cfg` condition value: `serde`
[INFO] [stdout]    --> src/bme280.rs:133:12
[INFO] [stdout]     |
[INFO] [stdout] 133 | #[cfg_attr(feature = "serde", derive(Serialize))]
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `feature` are: `defmt`
[INFO] [stdout]     = help: consider adding `serde` as a feature in `Cargo.toml`
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout]     = note: `#[warn(unexpected_cfgs)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `serde`
[INFO] [stdout]   --> src/bme280.rs:13:7
[INFO] [stdout]    |
[INFO] [stdout] 13 | #[cfg(feature = "serde")]
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: expected values for `feature` are: `defmt`
[INFO] [stdout]    = help: consider adding `serde` as a feature in `Cargo.toml`
[INFO] [stdout]    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `core::marker::PhantomData`
[INFO] [stdout]  --> src/bme280.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 | use core::marker::PhantomData;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: operator precedence might not be obvious
[INFO] [stdout]    --> src/bmp180.rs:163:23
[INFO] [stdout]     |
[INFO] [stdout] 163 |         let b4: u32 = (self.ac4 as u32) * ((x3 + 32768) as u32) >> 15;
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((self.ac4 as u32) * ((x3 + 32768) as u32)) >> 15`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stdout]     = note: `#[warn(clippy::precedence)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `super::Device`
[INFO] [stdout]  --> src/onewire/ds18b20.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use super::Device;
[INFO] [stdout]   |     ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `serde`
[INFO] [stdout]    --> src/bme280.rs:133:12
[INFO] [stdout]     |
[INFO] [stdout] 133 | #[cfg_attr(feature = "serde", derive(Serialize))]
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `feature` are: `defmt`
[INFO] [stdout]     = help: consider adding `serde` as a feature in `Cargo.toml`
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout]     = note: `#[warn(unexpected_cfgs)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `serde`
[INFO] [stdout]   --> src/bme280.rs:13:7
[INFO] [stdout]    |
[INFO] [stdout] 13 | #[cfg(feature = "serde")]
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: expected values for `feature` are: `defmt`
[INFO] [stdout]    = help: consider adding `serde` as a feature in `Cargo.toml`
[INFO] [stdout]    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `core::marker::PhantomData`
[INFO] [stdout]  --> src/bme280.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 | use core::marker::PhantomData;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: operator precedence might not be obvious
[INFO] [stdout]    --> src/bmp180.rs:163:23
[INFO] [stdout]     |
[INFO] [stdout] 163 |         let b4: u32 = (self.ac4 as u32) * ((x3 + 32768) as u32) >> 15;
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((self.ac4 as u32) * ((x3 + 32768) as u32)) >> 15`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stdout]     = note: `#[warn(clippy::precedence)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `super::Device`
[INFO] [stdout]  --> src/onewire/ds18b20.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use super::Device;
[INFO] [stdout]   |     ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `wire` and `dev` are never read
[INFO] [stdout]    --> src/onewire/mod.rs:390:5
[INFO] [stdout]     |
[INFO] [stdout] 389 | pub struct OneWireDevice<'a, P: OneWirePinExt> {
[INFO] [stdout]     |            ------------- fields in this struct
[INFO] [stdout] 390 |     wire: &'a mut OneWire<P>,
[INFO] [stdout]     |     ^^^^
[INFO] [stdout] 391 |     dev: Option<Device>,
[INFO] [stdout]     |     ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `select_device` is never used
[INFO] [stdout]    --> src/onewire/mod.rs:395:8
[INFO] [stdout]     |
[INFO] [stdout] 394 | impl<P: OneWirePinExt> OneWireDevice<'_, P> {
[INFO] [stdout]     | ------------------------------------------- method in this implementation
[INFO] [stdout] 395 |     fn select_device<D: DelayUs<u16>>(&mut self, delay: &mut D) -> Result<(), Error> {
[INFO] [stdout]     |        ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: clamp-like pattern without using clamp function
[INFO] [stdout]    --> src/bme280.rs:186:27
[INFO] [stdout]     |
[INFO] [stdout] 186 |           let temperature = if temperature < BME280_TEMP_MIN {
[INFO] [stdout]     |  ___________________________^
[INFO] [stdout] 187 | |             BME280_TEMP_MIN
[INFO] [stdout] 188 | |         } else if temperature > BME280_TEMP_MAX {
[INFO] [stdout] 189 | |             BME280_TEMP_MAX
[INFO] [stdout] 190 | |         } else {
[INFO] [stdout] 191 | |             temperature
[INFO] [stdout] 192 | |         };
[INFO] [stdout]     | |_________^ help: replace with clamp: `temperature.clamp(BME280_TEMP_MIN, BME280_TEMP_MAX)`
[INFO] [stdout]     |
[INFO] [stdout]     = note: clamp will panic if max < min, min.is_nan(), or max.is_nan()
[INFO] [stdout]     = note: clamp returns NaN if the input is NaN
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
[INFO] [stdout]     = note: `#[warn(clippy::manual_clamp)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: clamp-like pattern without using clamp function
[INFO] [stdout]    --> src/bme280.rs:214:13
[INFO] [stdout]     |
[INFO] [stdout] 214 | /             if pressure < BME280_PRESSURE_MIN {
[INFO] [stdout] 215 | |                 BME280_PRESSURE_MIN
[INFO] [stdout] 216 | |             } else if pressure > BME280_PRESSURE_MAX {
[INFO] [stdout] 217 | |                 BME280_PRESSURE_MAX
[INFO] [stdout] 218 | |             } else {
[INFO] [stdout] 219 | |                 pressure
[INFO] [stdout] 220 | |             }
[INFO] [stdout]     | |_____________^ help: replace with clamp: `pressure.clamp(BME280_PRESSURE_MIN, BME280_PRESSURE_MAX)`
[INFO] [stdout]     |
[INFO] [stdout]     = note: clamp will panic if max < min, min.is_nan(), or max.is_nan()
[INFO] [stdout]     = note: clamp returns NaN if the input is NaN
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: clamp-like pattern without using clamp function
[INFO] [stdout]    --> src/bme280.rs:241:24
[INFO] [stdout]     |
[INFO] [stdout] 241 |           let humidity = if humidity < BME280_HUMIDITY_MIN {
[INFO] [stdout]     |  ________________________^
[INFO] [stdout] 242 | |             BME280_HUMIDITY_MIN
[INFO] [stdout] 243 | |         } else if humidity > BME280_HUMIDITY_MAX {
[INFO] [stdout] 244 | |             BME280_HUMIDITY_MAX
[INFO] [stdout] 245 | |         } else {
[INFO] [stdout] 246 | |             humidity
[INFO] [stdout] 247 | |         };
[INFO] [stdout]     | |_________^ help: replace with clamp: `humidity.clamp(BME280_HUMIDITY_MIN, BME280_HUMIDITY_MAX)`
[INFO] [stdout]     |
[INFO] [stdout]     = note: clamp will panic if max < min, min.is_nan(), or max.is_nan()
[INFO] [stdout]     = note: clamp returns NaN if the input is NaN
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout]    --> src/bmp180.rs:165:31
[INFO] [stdout]     |
[INFO] [stdout] 165 |         let b7 = (up as i64 - b3 as i64) * (50000 >> oss);
[INFO] [stdout]     |                               ^^^^^^^^^ help: try: `b3`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/esp_at.rs:276:17
[INFO] [stdout]     |
[INFO] [stdout] 276 |                 payload[6..].parse().unwrap_or(255)
[INFO] [stdout]     |                 ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/esp_at.rs:275:13
[INFO] [stdout]     |
[INFO] [stdout] 275 |             if payload.starts_with("+PING:") {
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout]     = note: `#[warn(clippy::manual_strip)]` on by default
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 275 ~             if let Some(<stripped>) = payload.strip_prefix("+PING:") {
[INFO] [stdout] 276 ~                 <stripped>.parse().unwrap_or(255)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stdout]    --> src/esp_at.rs:342:20
[INFO] [stdout]     |
[INFO] [stdout] 342 |             if let Ok(_) = self.read_response() {
[INFO] [stdout]     |             -------^^^^^----------------------- help: try: `if self.read_response().is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = note: this will change drop order of the result, as well as all temporaries
[INFO] [stdout]     = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this returns a `Result<_, ()>`
[INFO] [stdout]   --> src/pmsx003.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 |     pub fn read_measurements(&mut self) -> Result<Measurements, ()> {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: use a custom `Error` type instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
[INFO] [stdout]    = note: `#[warn(clippy::result_unit_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this returns a `Result<_, ()>`
[INFO] [stdout]   --> src/lm75.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 |     pub fn measure(&mut self) -> Result<f32, ()> {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: use a custom `Error` type instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/onewire/ds18b20.rs:49:1
[INFO] [stdout]    |
[INFO] [stdout] 49 | / impl Default for Resolution {
[INFO] [stdout] 50 | |     fn default() -> Self {
[INFO] [stdout] 51 | |         Resolution::Twelve
[INFO] [stdout] 52 | |     }
[INFO] [stdout] 53 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant
[INFO] [stdout]    |
[INFO] [stdout] 22 + #[derive(Default)]
[INFO] [stdout] 23 | pub enum Resolution {
[INFO] [stdout] 24 |     Nine = 0b000_11111,
[INFO] [stdout] 25 |     Ten = 0b001_11111,
[INFO] [stdout] 26 |     Eleven = 0b010_11111,
[INFO] [stdout] 27 ~     #[default]
[INFO] [stdout] 28 ~     Twelve = 0b011_11111,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/onewire/mod.rs:194:12
[INFO] [stdout]     |
[INFO] [stdout] 194 |         if !self.port.reset(self.delay).is_ok() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.port.reset(self.delay).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `ByteMutWriter` has a public `len` method, but no `is_empty` method
[INFO] [stdout]   --> src/lib.rs:39:5
[INFO] [stdout]    |
[INFO] [stdout] 39 |     pub fn len(&self) -> usize {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]    = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless call to `as_bytes`
[INFO] [stdout]   --> src/lib.rs:72:53
[INFO] [stdout]    |
[INFO] [stdout] 72 |         self.cursor = usize::min(cap, self.cursor + s.as_bytes().len());
[INFO] [stdout]    |                                                     ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
[INFO] [stdout]    = note: `#[warn(clippy::needless_as_bytes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `wire` and `dev` are never read
[INFO] [stdout]    --> src/onewire/mod.rs:390:5
[INFO] [stdout]     |
[INFO] [stdout] 389 | pub struct OneWireDevice<'a, P: OneWirePinExt> {
[INFO] [stdout]     |            ------------- fields in this struct
[INFO] [stdout] 390 |     wire: &'a mut OneWire<P>,
[INFO] [stdout]     |     ^^^^
[INFO] [stdout] 391 |     dev: Option<Device>,
[INFO] [stdout]     |     ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `select_device` is never used
[INFO] [stdout]    --> src/onewire/mod.rs:395:8
[INFO] [stdout]     |
[INFO] [stdout] 394 | impl<P: OneWirePinExt> OneWireDevice<'_, P> {
[INFO] [stdout]     | ------------------------------------------- method in this implementation
[INFO] [stdout] 395 |     fn select_device<D: DelayUs<u16>>(&mut self, delay: &mut D) -> Result<(), Error> {
[INFO] [stdout]     |        ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: clamp-like pattern without using clamp function
[INFO] [stdout]    --> src/bme280.rs:186:27
[INFO] [stdout]     |
[INFO] [stdout] 186 |           let temperature = if temperature < BME280_TEMP_MIN {
[INFO] [stdout]     |  ___________________________^
[INFO] [stdout] 187 | |             BME280_TEMP_MIN
[INFO] [stdout] 188 | |         } else if temperature > BME280_TEMP_MAX {
[INFO] [stdout] 189 | |             BME280_TEMP_MAX
[INFO] [stdout] 190 | |         } else {
[INFO] [stdout] 191 | |             temperature
[INFO] [stdout] 192 | |         };
[INFO] [stdout]     | |_________^ help: replace with clamp: `temperature.clamp(BME280_TEMP_MIN, BME280_TEMP_MAX)`
[INFO] [stdout]     |
[INFO] [stdout]     = note: clamp will panic if max < min, min.is_nan(), or max.is_nan()
[INFO] [stdout]     = note: clamp returns NaN if the input is NaN
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
[INFO] [stdout]     = note: `#[warn(clippy::manual_clamp)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: clamp-like pattern without using clamp function
[INFO] [stdout]    --> src/bme280.rs:214:13
[INFO] [stdout]     |
[INFO] [stdout] 214 | /             if pressure < BME280_PRESSURE_MIN {
[INFO] [stdout] 215 | |                 BME280_PRESSURE_MIN
[INFO] [stdout] 216 | |             } else if pressure > BME280_PRESSURE_MAX {
[INFO] [stdout] 217 | |                 BME280_PRESSURE_MAX
[INFO] [stdout] 218 | |             } else {
[INFO] [stdout] 219 | |                 pressure
[INFO] [stdout] 220 | |             }
[INFO] [stdout]     | |_____________^ help: replace with clamp: `pressure.clamp(BME280_PRESSURE_MIN, BME280_PRESSURE_MAX)`
[INFO] [stdout]     |
[INFO] [stdout]     = note: clamp will panic if max < min, min.is_nan(), or max.is_nan()
[INFO] [stdout]     = note: clamp returns NaN if the input is NaN
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: clamp-like pattern without using clamp function
[INFO] [stdout]    --> src/bme280.rs:241:24
[INFO] [stdout]     |
[INFO] [stdout] 241 |           let humidity = if humidity < BME280_HUMIDITY_MIN {
[INFO] [stdout]     |  ________________________^
[INFO] [stdout] 242 | |             BME280_HUMIDITY_MIN
[INFO] [stdout] 243 | |         } else if humidity > BME280_HUMIDITY_MAX {
[INFO] [stdout] 244 | |             BME280_HUMIDITY_MAX
[INFO] [stdout] 245 | |         } else {
[INFO] [stdout] 246 | |             humidity
[INFO] [stdout] 247 | |         };
[INFO] [stdout]     | |_________^ help: replace with clamp: `humidity.clamp(BME280_HUMIDITY_MIN, BME280_HUMIDITY_MAX)`
[INFO] [stdout]     |
[INFO] [stdout]     = note: clamp will panic if max < min, min.is_nan(), or max.is_nan()
[INFO] [stdout]     = note: clamp returns NaN if the input is NaN
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout]    --> src/bmp180.rs:165:31
[INFO] [stdout]     |
[INFO] [stdout] 165 |         let b7 = (up as i64 - b3 as i64) * (50000 >> oss);
[INFO] [stdout]     |                               ^^^^^^^^^ help: try: `b3`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/esp_at.rs:276:17
[INFO] [stdout]     |
[INFO] [stdout] 276 |                 payload[6..].parse().unwrap_or(255)
[INFO] [stdout]     |                 ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/esp_at.rs:275:13
[INFO] [stdout]     |
[INFO] [stdout] 275 |             if payload.starts_with("+PING:") {
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout]     = note: `#[warn(clippy::manual_strip)]` on by default
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 275 ~             if let Some(<stripped>) = payload.strip_prefix("+PING:") {
[INFO] [stdout] 276 ~                 <stripped>.parse().unwrap_or(255)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stdout]    --> src/esp_at.rs:342:20
[INFO] [stdout]     |
[INFO] [stdout] 342 |             if let Ok(_) = self.read_response() {
[INFO] [stdout]     |             -------^^^^^----------------------- help: try: `if self.read_response().is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = note: this will change drop order of the result, as well as all temporaries
[INFO] [stdout]     = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this returns a `Result<_, ()>`
[INFO] [stdout]   --> src/pmsx003.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 |     pub fn read_measurements(&mut self) -> Result<Measurements, ()> {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: use a custom `Error` type instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
[INFO] [stdout]    = note: `#[warn(clippy::result_unit_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this returns a `Result<_, ()>`
[INFO] [stdout]   --> src/lm75.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 |     pub fn measure(&mut self) -> Result<f32, ()> {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: use a custom `Error` type instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/onewire/ds18b20.rs:49:1
[INFO] [stdout]    |
[INFO] [stdout] 49 | / impl Default for Resolution {
[INFO] [stdout] 50 | |     fn default() -> Self {
[INFO] [stdout] 51 | |         Resolution::Twelve
[INFO] [stdout] 52 | |     }
[INFO] [stdout] 53 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant
[INFO] [stdout]    |
[INFO] [stdout] 22 + #[derive(Default)]
[INFO] [stdout] 23 | pub enum Resolution {
[INFO] [stdout] 24 |     Nine = 0b000_11111,
[INFO] [stdout] 25 |     Ten = 0b001_11111,
[INFO] [stdout] 26 |     Eleven = 0b010_11111,
[INFO] [stdout] 27 ~     #[default]
[INFO] [stdout] 28 ~     Twelve = 0b011_11111,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/onewire/mod.rs:194:12
[INFO] [stdout]     |
[INFO] [stdout] 194 |         if !self.port.reset(self.delay).is_ok() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.port.reset(self.delay).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `ByteMutWriter` has a public `len` method, but no `is_empty` method
[INFO] [stdout]   --> src/lib.rs:39:5
[INFO] [stdout]    |
[INFO] [stdout] 39 |     pub fn len(&self) -> usize {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]    = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless call to `as_bytes`
[INFO] [stdout]   --> src/lib.rs:72:53
[INFO] [stdout]    |
[INFO] [stdout] 72 |         self.cursor = usize::min(cap, self.cursor + s.as_bytes().len());
[INFO] [stdout]    |                                                     ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
[INFO] [stdout]    = note: `#[warn(clippy::needless_as_bytes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.11s
[INFO] running `Command { std: "docker" "inspect" "5aaca6699e2e967dfbd12118d19004a145bd6a7aef5d5af1913aaf84a161db02", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5aaca6699e2e967dfbd12118d19004a145bd6a7aef5d5af1913aaf84a161db02", kill_on_drop: false }`
[INFO] [stdout] 5aaca6699e2e967dfbd12118d19004a145bd6a7aef5d5af1913aaf84a161db02