[INFO] fetching crate embassy-executor-macros 0.7.0... [INFO] linting embassy-executor-macros-0.7.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate embassy-executor-macros 0.7.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate embassy-executor-macros 0.7.0 [INFO] finished tweaking crates.io crate embassy-executor-macros 0.7.0 [INFO] tweaked toml for crates.io crate embassy-executor-macros 0.7.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate embassy-executor-macros 0.7.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate embassy-executor-macros 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32595b225e918c166f75c3203510c1c08323003a924e0ce89fdf6dcd667b29d5 [INFO] running `Command { std: "docker" "start" "-a" "32595b225e918c166f75c3203510c1c08323003a924e0ce89fdf6dcd667b29d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32595b225e918c166f75c3203510c1c08323003a924e0ce89fdf6dcd667b29d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32595b225e918c166f75c3203510c1c08323003a924e0ce89fdf6dcd667b29d5", kill_on_drop: false }` [INFO] [stdout] 32595b225e918c166f75c3203510c1c08323003a924e0ce89fdf6dcd667b29d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76ec733101a6430a6b85f428503f45048f4fdf946d88f4863211a0208573ba58 [INFO] running `Command { std: "docker" "start" "-a" "76ec733101a6430a6b85f428503f45048f4fdf946d88f4863211a0208573ba58", kill_on_drop: false }` [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking proc-macro2 v1.0.95 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking quote v1.0.40 [INFO] [stderr] Checking syn v2.0.104 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking darling v0.20.11 [INFO] [stderr] Checking embassy-executor-macros v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/main.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 110 | if !f.sig.generics.where_clause.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.generics.where_clause.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/main.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 113 | if !f.sig.abi.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.abi.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/main.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | if !f.sig.variadic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.variadic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/macros/main.rs:136:47 [INFO] [stdout] | [INFO] [stdout] 136 | let entry = match (args.entry.as_deref(), arch.default_entry.as_deref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `arch.default_entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/macros/main.rs:138:43 [INFO] [stdout] | [INFO] [stdout] 138 | (Some(x), _) | (None, Some(x)) if x == "" => TokenStream::new(), [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/task.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if !f.sig.generics.where_clause.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.generics.where_clause.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/task.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 67 | if !f.sig.abi.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.abi.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/task.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | if !f.sig.variadic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.variadic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/macros/task.rs:280:16 [INFO] [stdout] | [INFO] [stdout] 280 | if i.ident.to_string() != "static" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `i.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/main.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 110 | if !f.sig.generics.where_clause.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.generics.where_clause.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/main.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 113 | if !f.sig.abi.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.abi.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/main.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | if !f.sig.variadic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.variadic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/macros/main.rs:136:47 [INFO] [stdout] | [INFO] [stdout] 136 | let entry = match (args.entry.as_deref(), arch.default_entry.as_deref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `arch.default_entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/macros/main.rs:138:43 [INFO] [stdout] | [INFO] [stdout] 138 | (Some(x), _) | (None, Some(x)) if x == "" => TokenStream::new(), [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/task.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if !f.sig.generics.where_clause.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.generics.where_clause.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/task.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 67 | if !f.sig.abi.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.abi.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macros/task.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | if !f.sig.variadic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.sig.variadic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/macros/task.rs:280:16 [INFO] [stdout] | [INFO] [stdout] 280 | if i.ident.to_string() != "static" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `i.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.28s [INFO] running `Command { std: "docker" "inspect" "76ec733101a6430a6b85f428503f45048f4fdf946d88f4863211a0208573ba58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76ec733101a6430a6b85f428503f45048f4fdf946d88f4863211a0208573ba58", kill_on_drop: false }` [INFO] [stdout] 76ec733101a6430a6b85f428503f45048f4fdf946d88f4863211a0208573ba58